Jean Chalard
267e528253
Arrange to send the rawChecksum to LatinIME.
...
Bug: 13125743
Change-Id: I5d111336e6a0f5ab4e93ff333654a7a1f8f46480
2014-05-22 11:01:04 +09:00
Jean Chalard
e077c01461
Add the rawChecksum column to the database.
...
Bug: 13125743
Change-Id: I082aa9df1dd4a10cdb3f97ee0692f2d72f6c8e7e
2014-05-22 11:00:46 +09:00
Keisuke Kuroyanagi
17f326b745
Add beginning of sentence information in PrevWordsInfo.
...
Bug: 14119293
Bug: 14425059
Change-Id: I65320920e840082b0b697bb621676716d0933e0c
2014-05-21 15:40:08 +09:00
Keisuke Kuroyanagi
17ae0eb7e7
Use enabled subtypes for Keyboard in DistracterFilter.
...
Bug: 13142176
Bug: 15094186
Change-Id: I142eeaa11f838080a4fc5a342155e5d470eab3d4
2014-05-21 14:08:39 +09:00
Tadashi G. Takaoka
73788ea154
Merge "Refactor MoreKeysKeyboardView to use Key class"
2014-05-21 03:06:43 +00:00
Tadashi G. Takaoka
5fc1510bc1
Refactor MoreKeysKeyboardView to use Key class
...
This can make MoreSuggestionsView to use extended Key class to hold
a index of a suggested word.
Change-Id: I54d03d2447b04e3caf3e19e7cadcd391cbf58dd5
2014-05-21 11:19:01 +09:00
Keisuke Kuroyanagi
e507d92aa3
Use PrevWordsInfo for get/add/remove n-gram(bigram) entry.
...
Bug: 14119293
Bug: 14425059
Bug: 15102610
Change-Id: Ib482390f8d15b37d44a1a54e8c243a9eaec3f815
2014-05-21 11:15:38 +09:00
Ken Wakasa
06dd0ef877
Merge "Revert "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry.""
2014-05-20 14:01:34 +00:00
Ken Wakasa
4e21d3711f
Revert "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry."
...
This reverts commit ff50b39176
.
Bug: 14119293
Bug: 14425059
Bug: 15102610
Change-Id: If278b4ab236e38d20d8cdc0761b0438911bd4ff9
2014-05-20 14:01:06 +00:00
Tadashi G. Takaoka
305778b53a
Support accessibility TalkBack in emoji palette
...
Bug: 11452158
Change-Id: I699e4e9f4baec4bb0fb9cd7875f675044f20465f
2014-05-20 17:35:39 +09:00
Tadashi G. Takaoka
f22285006a
Move generic hover event handling to KeyboardAccessibilityDelegate
...
This is a follow up of I0d73b4cf60.
Change-Id: Iecfe124321682c8fc307ccf4c79e836390403d95
2014-05-20 17:25:19 +09:00
Tadashi G. Takaoka
4d146d5e3e
Separate MainKeyboardView specific accessibility code
...
Change-Id: I0d73b4cf60145b6e34bd89f72eb49de3c686f5e3
2014-05-20 15:34:25 +09:00
Tadashi G. Takaoka
524392adfa
Merge "Refactor accessibility classes to be more generic"
2014-05-20 06:19:30 +00:00
Tadashi G. Takaoka
7b90d2c432
Refactor accessibility classes to be more generic
...
Change-Id: Ifad1905f304bccdc39f0d5fbcab8a6353e0b4f76
2014-05-20 15:07:45 +09:00
Keisuke Kuroyanagi
1afaf6770b
Merge "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry."
2014-05-20 05:36:10 +00:00
Keisuke Kuroyanagi
ff50b39176
Use PrevWordsInfo for get/add/remove n-gram(bigram) entry.
...
Bug: 14119293
Bug: 14425059
Change-Id: I12e9ba977c153b514c6591ab52940712fd0874e3
2014-05-20 13:37:04 +09:00
Tadashi G. Takaoka
9fb2797714
Fix number password field handling
...
Bug: 15088419
Change-Id: Ie88375c8c8203c318d9b410692c527443cb0a2d5
2014-05-20 10:26:26 +09:00
Tadashi G. Takaoka
437be2d5c4
Refactor Emoji tab indicators to refer keyboard theme
...
Bug: 14419121
Change-Id: I7086923fff153039c2d011bbccbfd04eb687a76a
2014-05-20 01:16:25 +09:00
Tadashi G. Takaoka
27ca9f1bf1
Remove Emoji label tab
...
Change-Id: Ia2f3482363b462c16a51f2baac59d6bcae96ffab
2014-05-19 23:11:39 +09:00
Tadashi G. Takaoka
3bfacd445e
Merge "Remove Emoji delete key UX hack"
2014-05-19 05:33:28 +00:00
Tadashi G. Takaoka
6ea0dab845
Remove Emoji delete key UX hack
...
The Emoji delete key UX hack that changes key background color based
on the key state isn't keyboard theme compliant.
Change-Id: I0fa43a91cdd6da944d6d4d1a5a09b771f852a081
2014-05-19 14:07:35 +09:00
Keisuke Kuroyanagi
b52055bfd1
Merge "Use PrevWordsInfo instead of String in Java side."
2014-05-19 05:00:21 +00:00
Keisuke Kuroyanagi
83c40a2301
Use PrevWordsInfo instead of String in Java side.
...
Bug: 14119293
Bug: 14425059
Change-Id: I3d5da84881a49a04550180dd9aac2c37da2ed762
2014-05-19 13:55:40 +09:00
Tadashi G. Takaoka
10bd458efc
Rename Emoji related resource names more consistent
...
Change-Id: I318a98feeaf7b8bc4d2ed6d54475a144e2dca0a1
2014-05-19 13:54:00 +09:00
Tadashi G. Takaoka
04e2a494e2
Rename LXX theme to LXX_Dark
...
Bug: 14419121
Change-Id: I3d73c51d339eafec26871a659575d8b7b8cc441c
2014-05-19 10:27:36 +09:00
Keisuke Kuroyanagi
23246ed18d
Use dedicated DictionaryFacilitator for DistracterFilter
...
Bug: 15002249
Change-Id: Ic77eaa7d627d406daad7dcd15cb4884d9f647312
2014-05-17 01:18:08 +09:00
Keisuke Kuroyanagi
96013c9605
Merge "Revert "Use dedicated DictionaryFacilitator for DistracterFilter""
2014-05-16 11:17:45 +00:00
Keisuke Kuroyanagi
f9377c8920
Revert "Use dedicated DictionaryFacilitator for DistracterFilter"
...
This reverts commit 7122fe76e3
.
Change-Id: I341089864a2b58de6e0f35844a12fb632bd1eabb
2014-05-16 11:16:54 +00:00
Keisuke Kuroyanagi
0dac17f5fb
Merge "Use dedicated DictionaryFacilitator for DistracterFilter"
2014-05-16 10:49:02 +00:00
Tadashi G. Takaoka
060e63835a
Merge "Fix keyboard theme selection logic"
2014-05-16 09:59:22 +00:00
Tadashi G. Takaoka
3b12718537
Fix keyboard theme selection logic
...
Bug: 15002666
Change-Id: I5cc52db71ee609edffdb2613e93245e92ac6fc6a
2014-05-16 18:45:09 +09:00
Keisuke Kuroyanagi
7122fe76e3
Use dedicated DictionaryFacilitator for DistracterFilter
...
Bug: 15002249
Change-Id: I2ebf1941fb0453ea4b97c0e539f8b36e5e0262c1
2014-05-16 18:39:31 +09:00
Keisuke Kuroyanagi
d1f9ce00db
Merge "Make session id mandatory for getSuggestions."
2014-05-16 09:33:28 +00:00
Keisuke Kuroyanagi
09c72207c6
Make session id mandatory for getSuggestions.
...
Bug: 15008504
Change-Id: Ic4a17a4b7242118ae74fd89c695da2bb52204fb2
2014-05-16 17:57:03 +09:00
Keisuke Kuroyanagi
f1b3518d71
Merge "Fix: StringIndexOutOfBoundsException."
2014-05-16 07:47:52 +00:00
Keisuke Kuroyanagi
34873a66f0
Fix: StringIndexOutOfBoundsException.
...
Bug: 14985751
Change-Id: I9df2f737555ab02e24e0fbd231a97c1eec26bc57
2014-05-16 15:32:12 +09:00
Keisuke Kuroyanagi
cfd3093362
Merge "Fix: NPE when context.getFilesDir() returns null."
2014-05-16 05:35:57 +00:00
Keisuke Kuroyanagi
a545e8dd23
Fix: NPE when context.getFilesDir() returns null.
...
Bug: 14517587
Change-Id: Ib99bea14eab3a25ddb5042527b757133734a6ba6
2014-05-15 20:20:13 +09:00
Tadashi G. Takaoka
41808192d3
Support 9-patch drawable for spacebar icon
...
Bug: 14419121
Change-Id: I901ea2a5bfae870b3aae8fea3bc38d999b2354b8
2014-05-15 18:40:16 +09:00
Tadashi G. Takaoka
2ddaf9543d
Remove unused auto correction led for spacebar feature
...
Change-Id: Ie1544bd0d28684d9b7887fddff37b224ed4f8201
2014-05-15 17:53:43 +09:00
Tadashi G. Takaoka
591ec83e40
Merge "Use slightly dimmed text color for functional keys"
2014-05-15 07:09:53 +00:00
Tadashi G. Takaoka
28289ece59
Merge "Fix NPE in KeyboardSwitcher while orientation change"
2014-05-15 07:09:44 +00:00
Keisuke Kuroyanagi
e810a266fd
Merge "Quit use bigram probability diff for ver4 dict."
2014-05-15 07:07:25 +00:00
Tadashi G. Takaoka
afdcc15ca8
Fix NPE in KeyboardSwitcher while orientation change
...
This is a follow up of I8a737e2b73.
Bug: 14981300
Bug: 14419121
Change-Id: I87f910adbff248d9606d074c351aa951c9539163
2014-05-15 16:07:15 +09:00
Keisuke Kuroyanagi
64341927d2
Quit use bigram probability diff for ver4 dict.
...
Change-Id: I2cfcfbcf351877d1dff466a24974dbb05908f14e
2014-05-15 16:02:58 +09:00
Tadashi G. Takaoka
37ec0fe984
Use slightly dimmed text color for functional keys
...
This CL introduces two new key attributes to achieve this.
- KeyboardView.functionalTextColor
- followFunctionalTextColor flag for Key.keyLabelFlags
Bug: 14419121
Change-Id: I45ca433dcc9cc8c6cf891e21d5316ee4048b0cad
2014-05-15 15:39:59 +09:00
Yohei Yukawa
f0fc320b4e
Merge "Simplify StatsUtils"
2014-05-15 06:35:42 +00:00
Xiaojun Bi
3686bdfcc1
Fix off-device build
...
This CL fixed the breakage caused by DistracterFilter.
It should be checked in together with I8f53e9481c0f
Bug: 14911612
Bug: 13142176
Change-Id: I33c3526165cea58926d10404552f1fadc385c2e5
2014-05-14 17:39:02 -07:00
Yohei Yukawa
9aa7f66a15
Simplify StatsUtils
...
With this CL, the implementation of StatsUtils no longer
needs to know how to read settings from the system.
Insted, the LatinIME class is now responsible for notifying
StatsUtils whenever the settings is changed.
BUG: 14324207
Change-Id: Ic3d26ec31c8d2c082d3e7487b578b323aad2f960
2014-05-15 00:11:13 +09:00
Keisuke Kuroyanagi
aa7329de15
Merge "Add VERSION4_DEV(402) in Java side and use it for tests."
2014-05-14 13:42:24 +00:00
Keisuke Kuroyanagi
04536f14b0
Add VERSION4_DEV(402) in Java side and use it for tests.
...
Bug: 13406708
Change-Id: I7c9c53bf34d12dced7331a359a83f6444490783a
2014-05-14 22:37:07 +09:00
Keisuke Kuroyanagi
ee59975420
Merge "Fix a NPE in DistracterFilter.isDistracterToWordsInDictionaries()"
2014-05-14 12:20:10 +00:00
Jean Chalard
babde55bf8
Merge "Fix a bug where changing languages kills the composition."
2014-05-14 11:36:43 +00:00
Jean Chalard
5ce39dfa78
Fix a bug where changing languages kills the composition.
...
Bug: 14926896
Change-Id: Id2a06c68a51f833db4d8bbc858a232c2696afb6e
2014-05-14 20:34:32 +09:00
Tadashi G. Takaoka
9f4d62cc42
Create com.android.inputmethod.keyboard.emoji package
...
Change-Id: Idd12c2fa4f5add7bb50bd7349ff9a74fffe82cfd
2014-05-14 19:32:00 +09:00
Tadashi G. Takaoka
71f4c6b8ea
Merge "Fix NPE that happens only in some unit tests"
2014-05-14 10:01:15 +00:00
Tadashi G. Takaoka
268bf2cdfe
Fix NPE that happens only in some unit tests
...
Bug: 14922410
Change-Id: Ica801e102d302e9faa7c24721b37634f1e812af3
2014-05-14 18:55:14 +09:00
Jean Chalard
08476dc107
Merge "Don't send empty composing texts."
2014-05-14 09:50:25 +00:00
Tadashi G. Takaoka
83da26422c
Merge "Rename LMP to LXX just in case"
2014-05-14 09:43:27 +00:00
Tadashi G. Takaoka
3610039723
Rename LMP to LXX just in case
...
This CL must be checked in together with I7e2ba67f31.
Change-Id: I51cb982f9cf0ace173d535a60293bb4be83bbb75
2014-05-14 18:39:39 +09:00
Tadashi G. Takaoka
d7c520bb74
Merge "Make Emoji palette more Quantum light compliant"
2014-05-14 09:33:43 +00:00
Keisuke Kuroyanagi
0a04f8be93
Merge "Output dictionary format version for dump."
2014-05-14 09:07:56 +00:00
Tadashi G. Takaoka
c1094d6913
Make Emoji palette more Quantum light compliant
...
Bug: 14419121
Change-Id: I8a737e2b73a000ad66e7e30a695677fe0bcc66fb
2014-05-14 18:01:24 +09:00
Tadashi G. Takaoka
ae1c53bead
Merge "Separate functional key background from normal one"
2014-05-14 09:00:43 +00:00
Tadashi G. Takaoka
c1e6100bde
Separate functional key background from normal one
...
This CL also moves spacebarBackground attribute from MainKeyboardView
to KeyboardView.
This CL must be checked in together with I48c383ca97.
Bug: 14419121
Change-Id: Id356d0086a8fb21375fb5c66076873258fb3d63e
2014-05-14 17:57:51 +09:00
Jean Chalard
309ab664a8
Don't send empty composing texts.
...
Bug: 13160467
Change-Id: I5e3204ac8aaa18fe9219cc6b564b832ab6cf94fc
2014-05-14 16:55:32 +09:00
Jean Chalard
a1b7f66eb2
Merge "Implement backspace in the current cluster for Myanmar"
2014-05-14 07:18:35 +00:00
Jean Chalard
d23d1970b0
Implement backspace in the current cluster for Myanmar
...
Bug: 13945569
Change-Id: I738b01ede25fd731a2e10c4775f5511ce9bb54c8
2014-05-14 16:09:33 +09:00
Tadashi G. Takaoka
ead058b002
Make EmojiCategory and EmojiPalettesAdapter as top level classes
...
Change-Id: Iea8087a240cb46e410b8de1f6a784b2995e7a6fb
2014-05-14 16:01:00 +09:00
Xiaojun Bi
eb4f8506d6
Fix a NPE in DistracterFilter.isDistracterToWordsInDictionaries()
...
Bug: 14904706
Change-Id: I3b52bb01b9c59cbba2eba0bd1d91dffb4419c019
2014-05-13 21:00:28 -07:00
Tadashi G. Takaoka
83be21a563
Fix emoji category page indicator height
...
Bug: 14419121
Change-Id: I67f2072c67c2c4da0e5ac21a90f5cc7313f70f59
2014-05-14 12:35:40 +09:00
Keisuke Kuroyanagi
935150795b
Output dictionary format version for dump.
...
Change-Id: I13873727dbb25550a5087c883968a77094d2115d
2014-05-14 11:39:28 +09:00
Tadashi G. Takaoka
08103a0e07
Show voice key even when important notice is showing
...
Bug: 14822080
Change-Id: I2a55bb630cf544b6dc31a5e0e6b932c6af268c71
2014-05-14 09:11:35 +09:00
Xiaojun Bi
25ec32f635
Merge "Implement the distracter filter"
2014-05-13 23:08:40 +00:00
Xiaojun Bi
ac20253806
Implement the distracter filter
...
Bug: 13142176
Change-Id: I85a048cdcbbad3d6020a25f900250d8d7a0fe3da
2014-05-13 15:52:14 -07:00
Tadashi G. Takaoka
5fc93fadd6
Merge "Add content description to the voice key"
2014-05-13 07:53:02 +00:00
Tadashi G. Takaoka
cda11fb3a4
Merge "Show icon on action key when it is defined in keyboard theme"
2014-05-13 07:49:37 +00:00
Tadashi G. Takaoka
06d1cdd5dc
Add content description to the voice key
...
Bug: 14849593
Change-Id: I1664b6a4ef54b78a09df65adbffff7861b54c4a9
2014-05-13 16:33:31 +09:00
Tadashi G. Takaoka
aaffc46e82
Fix inconsistent TalkBack descriptions of keyboard modes
...
The previous "symbols shift mode" is renamed as "more symbols
mode". This CL also simplifies the shift key on various keyboard
modes.
Bug: 14461550
Change-Id: I8ed48805eaf95892e0f12f5edcdf97937d5c2bd4
2014-05-13 15:55:32 +09:00
Tadashi G. Takaoka
dcd74ba929
Merge "Optimize drawing key text shadow layer"
2014-05-13 05:21:08 +00:00
Tadashi G. Takaoka
41f9f1ef70
Optimize drawing key text shadow layer
...
Change-Id: Id226fe8042ba0f538d5109459a3615d7e7113d7f
2014-05-13 14:16:33 +09:00
Tadashi G. Takaoka
9e39c603d3
Merge "Add isIconDefined predicate to Keyboard_Case attribute"
2014-05-13 03:37:35 +00:00
Keisuke Kuroyanagi
0f645381ee
Merge "Fix typo wordPreperty -> wordProperty."
2014-05-13 02:58:05 +00:00
Tadashi G. Takaoka
dd68d4e4bf
Show icon on action key when it is defined in keyboard theme
...
This CL also adds the following icons name for an action key.
- Go
- Send
- Next
- Done
- Previous
Bug: 14259323
Change-Id: I48bba708d1f78349270d2ca01aebd8f111685723
2014-05-13 11:03:49 +09:00
Tadashi G. Takaoka
1c8e069d3c
Add isIconDefined predicate to Keyboard_Case attribute
...
Bug: 14259323
Change-Id: I9450a5125b1809b9fada6ee6e6b253cabfa2e2b4
2014-05-13 10:24:32 +09:00
Keisuke Kuroyanagi
0befbf8289
Fix typo wordPreperty -> wordProperty.
...
Change-Id: I793f9a42f8dbf48fa15292e74df9edf1cf5d8901
2014-05-13 01:32:27 +09:00
Jean Chalard
61ddac28de
Merge "Add initial reordering rules for Myanmar"
2014-05-12 11:29:53 +00:00
Keisuke Kuroyanagi
490e6846a1
Merge "Add freq=0 words to user history depending on the option."
2014-05-12 11:15:52 +00:00
Keisuke Kuroyanagi
84070cbc74
Merge "Improve multi-word suggestion handling for user history."
2014-05-12 11:11:15 +00:00
Keisuke Kuroyanagi
87343166e5
Add freq=0 words to user history depending on the option.
...
Bug: 14686585
Change-Id: Ia1c3adb1bcc625788016e378e1ac7b0792ea9f4e
2014-05-12 19:48:58 +09:00
Jean Chalard
281dbc3973
Add initial reordering rules for Myanmar
...
Bug: 13945569
Change-Id: Ib546ba110e87bf72afa7f42c878cc5f638bff6c7
2014-05-12 19:17:47 +09:00
Keisuke Kuroyanagi
ddacfdeb09
Improve multi-word suggestion handling for user history.
...
Bug: 12902664
Change-Id: I03deed16047f0beaba8932d87c6129ec8061ba9c
2014-05-12 18:04:43 +09:00
Jean Chalard
be99616afa
Create the path for specifying combining rules in the subtype
...
Also add the skeleton of the combining rules for Myanmar
reordering as a pilot.
Bug: 13945569
Change-Id: Iabeb6838f45f1efff482143595ce5b48543e0c43
2014-05-12 15:58:51 +09:00
Tadashi G. Takaoka
c41d261b7e
Add voice key to suggestions strip
...
Bug: 14419121
Change-Id: I3b2bdc3c07bb7e49ea7be53649bd6dd134fea27c
2014-05-12 15:08:14 +09:00
Tadashi G. Takaoka
40f6ea720e
Merge "Activate pseudo LMP theme"
2014-05-12 05:17:09 +00:00
Tadashi G. Takaoka
fe536b2728
Activate pseudo LMP theme
...
Bug: 14419121
Change-Id: I00265315c204de2279250d9ae20f630c2ee5dec6
2014-05-12 14:11:59 +09:00
Keisuke Kuroyanagi
4eb220269b
Remove ContextualDictionary.haveContentsChanged().
...
Change-Id: I7023ba4d9515dcad90e0a226f70936550c5241f4
2014-05-12 13:50:08 +09:00
Keisuke Kuroyanagi
47c76f0a45
Merge "Add contextual dictionary to the dictionary facilitator."
2014-05-12 04:42:33 +00:00
Jean Chalard
2b95bc9b64
Cleanup : remove a useless member
...
Change-Id: I7871c3243c82b5a19acf266033187795a2ea1767
2014-05-12 11:52:45 +09:00
Tadashi G. Takaoka
59c3ef1ff8
Refactor KeyboardTheme
...
This CL introduces two preference keys in addition to the existing one.
- pref_keyboard_theme: The new preference key that is used only in the
preference settings.
- pref_keyboard_layout_20110916: The previous preference key that
holds keyboard color scheme settings. This is superseded by the next
key.
- pref_keyboard_theme_20140509: The new preference key that holds
keyboard theme settings. This value is forcibly reset to LMP theme
on a LMP device. On a KitKat and previous device, the settings of
the pref_keyboard_layout_20110916 is carried on into this
preference.
This CL must be checked in together with Id7b3ddd8aa.
Change-Id: I2d55602d026e30b38d8f822d2124f5c5e4a9a812
2014-05-12 10:59:10 +09:00
Ken Wakasa
4f5ea4dfc2
Merge "Revert "Refactor KeyboardTheme""
2014-05-09 11:28:51 +00:00
Ken Wakasa
d47dca429e
Revert "Refactor KeyboardTheme"
...
This reverts commit 19688b584b
.
Build breakage.
Change-Id: I95d4be1578824eaee5a2fb08ec277250727ac668
2014-05-09 11:28:19 +00:00
Tadashi G. Takaoka
c2a49f3006
Merge "Refactor KeyboardTheme"
2014-05-09 08:26:05 +00:00
Tadashi G. Takaoka
19688b584b
Refactor KeyboardTheme
...
This CL introduces two preference keys in addition to the existing one.
- pref_keyboard_theme: The new preference key that is used only in the
preference settings.
- pref_keyboard_layout_20110916: The previous preference key that
holds keyboard color scheme settings. This is superseded by the next
key.
- pref_keyboard_theme_20140509: The new preference key that holds
keyboard theme settings. This value is forcibly reset to LMP theme
on a LMP device. On a KitKat and previous device, the settings of
the pref_keyboard_layout_20110916 is carried on into this
preference.
This CL must be checked in together with Ifcedeabbec.
Change-Id: Ibe75146e2c1c7eebf964ca86550baf244fedb79a
2014-05-09 16:21:02 +09:00
Keisuke Kuroyanagi
eaa347bc1a
Merge "Add VERSION4_TEST for testing."
2014-05-09 07:06:06 +00:00
Keisuke Kuroyanagi
455dc84cf2
Add VERSION4_TEST for testing.
...
Bug: 13406708
Change-Id: I0b434717ea3edbb131650af634c53cfbfe113c3e
2014-05-09 15:17:01 +09:00
Keisuke Kuroyanagi
82fa755bac
Fix unit tests by adding @UsedForTesting
...
Change-Id: I9448b1bfa7bf94039de737725851e63a2921a443
2014-05-09 14:44:44 +09:00
Keisuke Kuroyanagi
28ebe2db23
Merge "Check whether contacts have changed using hashCode()."
2014-05-09 03:48:19 +00:00
Keisuke Kuroyanagi
943e28d202
Merge "Periodic GC for personalization dict."
2014-05-09 03:41:43 +00:00
Tadashi G. Takaoka
ebac0aa28f
Reorder accented letters of English
...
This is a follow up change of Idff0b6d08e.
Bug: 13177865
Change-Id: I00ea7cda954efbd248d2abc2fa6d4995d6acbf19
2014-05-09 12:06:42 +09:00
Keisuke Kuroyanagi
89eaa6701f
Periodic GC for personalization dict.
...
Change-Id: I1ef922684cbf1de10c45c66eb119c2343d194da3
2014-05-08 17:20:43 +09:00
Tadashi G. Takaoka
bf09cb2390
Reorder accented letters of English
...
Bug: 13177865
Change-Id: Idff0b6d08e6dd0ec1eb39072ba4f99e6ec7df802
2014-05-08 16:20:13 +09:00
Keisuke Kuroyanagi
08d12a1be3
Merge "Extend jni interface for dictionary migration."
2014-05-08 05:20:33 +00:00
Keisuke Kuroyanagi
1471fbad66
Extend jni interface for dictionary migration.
...
Bug: 13406708
Change-Id: Iadad6df296467d0e5b631fba4a409d53c8a5a6f2
2014-05-08 12:31:04 +09:00
Keisuke Kuroyanagi
9898ee6267
Check whether contacts have changed using hashCode().
...
Bug: 13755213
Change-Id: Ie2f7b7f9dc8bd3fce395618877d9f234287dcb21
2014-05-08 12:25:32 +09:00
Tadashi G. Takaoka
e3e331aebb
Merge "Use margin instead of padding in SuggestionStripView"
2014-05-08 01:14:59 +00:00
Xiaojun Bi
50b5295d5d
Merge "Use DistracterFilter when getting Language Model Param of a word"
2014-05-08 01:10:33 +00:00
Xiaojun Bi
17284659ce
Use DistracterFilter when getting Language Model Param of a word
...
A preparation for implementing Distracter Filter.
This CL should be checked in together with Icfefa0463180
Bug: 13142176
Change-Id: If9e5ca840c4a81cb0339ab70f146b42fbfa7af5d
2014-05-07 10:10:18 -07:00
Tadashi G. Takaoka
2b479cccae
Use margin instead of padding in SuggestionStripView
...
This CL also tunes the width of suggestions strip to be able to
display 15~16 letters without x-scaling at the center slot.
Bug: 14419121
Change-Id: Ia5766cee043899533e24e2ebc621e8dc279370b3
2014-05-07 19:12:28 +09:00
Keisuke Kuroyanagi
7d52f9b81c
Fix: mIsUserDictEnabled is never updated.
...
Bug: 14602321
Change-Id: Ib98d5648ea2a901393b79c7f300bc6d209ee98d1
2014-05-07 16:45:37 +09:00
Ken Wakasa
0de529b4ca
Fix NPE
...
Follow up to I2b0ec091a11aa8a495794d633efecb6d8b818f42
bug: 14488351
Change-Id: Ic88adbd6775910f35338d798dc0d5493715708e4
2014-05-03 00:33:41 +09:00
Tadashi G. Takaoka
71c96c079f
Merge "Add Marathi keyboard layout"
2014-05-02 01:20:07 +00:00
Keisuke Kuroyanagi
8a7f670ec3
Merge "Remove Dictionaries.mDictMap."
2014-05-01 11:17:28 +00:00
Keisuke Kuroyanagi
c005c1dc56
Merge "Use dictType to class map to create sub dicts."
2014-05-01 10:16:58 +00:00
Keisuke Kuroyanagi
61fe28831d
Merge "Create factory methods for sub dicts."
2014-05-01 10:07:24 +00:00
Keisuke Kuroyanagi
fb87c250cb
Add contextual dictionary to the dictionary facilitator.
...
Bug: 14161647
Change-Id: I0e706b2abd0cb9f351e28681e275cd7f2fdbfd9c
2014-05-01 18:45:01 +09:00
Keisuke Kuroyanagi
d46855da72
Remove Dictionaries.mDictMap.
...
Bug: 13755213
Change-Id: I9ded695c31d3db05f561956c61d56ebd16d34703
2014-05-01 18:45:01 +09:00
Keisuke Kuroyanagi
99f2664871
Use dictType to class map to create sub dicts.
...
Bug: 13755213
Change-Id: I4dcd5684bc65f13361bf9c4f9d50b07b1e33c62d
2014-05-01 18:44:57 +09:00
Tadashi G. Takaoka
a5ab5d830c
Add Marathi keyboard layout
...
Bug: 10028772
Change-Id: I7bca05bbbfdb2e5f61d5db611dff62ace3b71e31
2014-05-01 18:25:56 +09:00
Keisuke Kuroyanagi
c3b151957c
Move dict version check to proper place.
...
Change-Id: I89a5b4fa93153081b4f7a9183619cbe7c9ea01fa
2014-05-01 17:28:24 +09:00
Keisuke Kuroyanagi
98e358a936
Create factory methods for sub dicts.
...
Bug: 13755213
Change-Id: I046af54b4860d2839328f2089ea785d81d04cf43
2014-05-01 17:22:23 +09:00
Tadashi G. Takaoka
20770f4ba0
Merge "Guard accessibility function calls"
2014-05-01 08:08:48 +00:00
Tadashi G. Takaoka
1ead609e6f
Guard accessibility function calls
...
This is a follow up of I2b0ec091a1.
Change-Id: I2801bd1530556cfa6cc176efac9d9f09f2405892
2014-05-01 17:06:40 +09:00
Keisuke Kuroyanagi
765cbb81ba
Merge "Simplify DictionaryFacilitatorForSuggest."
2014-05-01 07:55:31 +00:00
Jean Chalard
bedef0b4f0
Merge "Introduce clustering punctuation"
2014-05-01 07:01:04 +00:00
Keisuke Kuroyanagi
1ab6bfdc60
Simplify DictionaryFacilitatorForSuggest.
...
Bug: 13755213
Change-Id: I9663d1d60fccd8deb1a22683fb06fe64dee06b45
2014-05-01 15:51:03 +09:00
Jean Chalard
29c00ff538
Introduce clustering punctuation
...
Bug: 10081730
Change-Id: If198fa3df68ecb267da0a278da41fd509d6165f1
2014-05-01 15:45:24 +09:00
Tadashi G. Takaoka
3903e0d6e8
Merge "Make AccessibleKeyboardViewProxy not singleton"
2014-05-01 03:29:30 +00:00
Tadashi G. Takaoka
bca7e4e9a2
Make AccessibleKeyboardViewProxy not singleton
...
This CL also renames AccessibleKeyboardViewProxy and
AccessibilityEntityProvider to MainKeyboardAccessibilityDelegate and
MainKeyboardAccessibilityNodeProvider.
Change-Id: I2b0ec091a11aa8a495794d633efecb6d8b818f42
2014-05-01 12:24:54 +09:00
Jean Chalard
ec29147375
Merge "Some cleanup and reinforcement"
2014-05-01 03:04:29 +00:00
Jean Chalard
49d7871290
Some cleanup and reinforcement
...
Bug: 9520584
Change-Id: I1c0f9e1b530d4d5bf5f52c2905c20f5ab7c26442
2014-05-01 12:00:20 +09:00
Keisuke Kuroyanagi
a9f0a96377
Merge "Handle user dict as an ExpandableBinaryDictionary."
2014-04-30 12:44:25 +00:00
Keisuke Kuroyanagi
9ed7e47539
Handle user dict as an ExpandableBinaryDictionary.
...
Bug: 13755213
Change-Id: I2d242a3332e9633d4e41e08c0bbfafcefd814ecd
2014-04-30 20:35:08 +09:00
Yohei Yukawa
6d54f9f53c
Merge "Fix the unintentional behavior change"
2014-04-30 11:33:11 +00:00
Yohei Yukawa
60003d5114
Fix the unintentional behavior change
...
I0188fa56cba8e introduced an unintentional behavior change
regarding the condition when the globe key is displayed
if LatinIME is running on KitKat or prior version.
With this CL, the previous behavior is back.
BUG: 12965588
BUG: 14426646
Change-Id: I112a327dce6ad2e40beb9a60d587e77b3954da82
2014-04-30 20:30:39 +09:00
Tadashi G. Takaoka
412ac4c573
Merge "TalkBack correct shift state"
2014-04-30 09:51:07 +00:00
Tadashi G. Takaoka
24536580bf
TalkBack correct shift state
...
Change-Id: I3097805c6c8b4a4ac19fbe062f763e2639eb5cbf
2014-04-30 18:46:46 +09:00
Yohei Yukawa
1690992d1b
Check OS codename for shouldOfferSwitchingToNextInputMethod
...
Make sure if Build.VERSION.CODENAME is "REL" or not when
Build.VERSION.SDK_INT is 19 (KitKat). This is a tentative
workaround until Build.VERSION.SDK_INT is bumped to 20 or
greater.
BUG: 12965588
Change-Id: I0f6a8ef92af221240d247997ce65bd5e351b2d5e
2014-04-30 17:08:04 +09:00
Keisuke Kuroyanagi
c0d754397e
Fix unit tests by adding @UsedFortesting.
...
Change-Id: I8f66632a32b9e9ddc1b771e8ee74492c7baf9338
2014-04-29 00:00:57 +09:00
Keisuke Kuroyanagi
4426cbc59e
Fix: contacts/user dicts are too frequently regenerated.
...
Change-Id: I6b04a58c543fda6df7a2c016b8b8a5300f137d73
2014-04-28 23:11:25 +09:00
Keisuke Kuroyanagi
f614de62aa
Merge "Cleanup ExpandableBinaryDictionary."
2014-04-28 12:08:01 +00:00
Keisuke Kuroyanagi
b451f270f3
Cleanup ExpandableBinaryDictionary.
...
Bug: 8187060
Change-Id: I9103462412e727b0160b218b1bb301ce43621c46
2014-04-28 21:02:00 +09:00
Keisuke Kuroyanagi
c207955d4f
Merge "Use ReentrantReadWriteLock in ExpandableBinaryDictionary."
2014-04-28 12:01:14 +00:00
Keisuke Kuroyanagi
1737b7ff5c
Use ReentrantReadWriteLock in ExpandableBinaryDictionary.
...
Bug: 8187060
Change-Id: Ic665f0a5e940708aa9addedac068a64900b307e7
2014-04-28 20:56:01 +09:00
Keisuke Kuroyanagi
2367f8f602
Merge "Simplify asyncFlushBinaryDictionary."
2014-04-28 08:44:52 +00:00
Keisuke Kuroyanagi
570602a088
Simplify asyncFlushBinaryDictionary.
...
We no longer write files when the dict has not been updated.
Bug: 8187060
Change-Id: I8aa23a93d5deafb3a7f16f5466a5e0e84fbbf095
2014-04-28 17:30:36 +09:00
Keisuke Kuroyanagi
5c1416e426
Merge "Remove DictionaryUpdateController."
2014-04-28 08:29:02 +00:00
Keisuke Kuroyanagi
dff7153820
Merge "Use different user dict name for spell checker."
2014-04-28 08:12:17 +00:00
Keisuke Kuroyanagi
a5202c7143
Merge "Use different contacts dict name for spell checker."
2014-04-28 07:58:41 +00:00
Keisuke Kuroyanagi
07c5b307d6
Remove DictionaryUpdateController.
...
Bug: 8187060
Change-Id: I3e1fa4060d8a5c12d8d609be3357d56051fb5815
2014-04-28 16:58:27 +09:00
Keisuke Kuroyanagi
c5de887fd2
Merge "Move dicts for spellchecker to under spellcheck."
2014-04-28 07:51:29 +00:00
Keisuke Kuroyanagi
6256ec0587
Merge "Fix: Typed word is not included in more suggestions."
2014-04-28 07:46:21 +00:00
Keisuke Kuroyanagi
817cd9a0d5
Use different user dict name for spell checker.
...
Bug: 13630847
Change-Id: Icabd08c674dcf086250b9e594328a43286d1d203
2014-04-28 16:31:20 +09:00
Keisuke Kuroyanagi
60763a06e8
Use different contacts dict name for spell checker.
...
Bug: 13630847
Change-Id: I016a464890d5e63794fb1288b4ce7b09adffc453
2014-04-28 16:25:10 +09:00
Keisuke Kuroyanagi
24ec8bd91b
Move dicts for spellchecker to under spellcheck.
...
Bug: 13630847
Change-Id: Iadcf5b31f66fb73efc5c640e96e8c2106a0224dd
2014-04-28 16:24:35 +09:00
Keisuke Kuroyanagi
a8c4731eab
Fix: Typed word is not included in more suggestions.
...
Happened when top suggestion is long and auto-corrected.
Bug: 13738879
Change-Id: I47c2dfb34cfc92b54cfe54c432ee2f646fe454e5
2014-04-28 16:21:27 +09:00
Yohei Yukawa
91db602b83
Merge "Use shouldOfferSwitchingToNextInputMethod when available"
2014-04-28 06:58:02 +00:00
Yohei Yukawa
8ba4f33709
Use shouldOfferSwitchingToNextInputMethod when available
...
With this CL, LatinIME starts using
InputMethodManager#shouldOfferSwitchingToNextInputMethod when
available and API level is higher than 19 (KitKat).
Note that relevant settings of LatinIME will be ignored if
InputMethodManager#shouldOfferSwitchingToNextInputMethod is
considered to be available at the moment. We will revisit
here to reorganize the user visible settings before the
new global IME switching mechanism becomes publicly
available.
BUG: 12965588
Change-Id: I0188fa56cba8e983c61cef3ae3400a0e3821f718
2014-04-28 15:11:19 +09:00
Tadashi G. Takaoka
0b42851eed
Merge "Move some advanced settings to debug settings"
2014-04-28 05:30:28 +00:00
Tadashi G. Takaoka
2cc7c3321d
Merge "Remove unnecessary reference to LatinIME"
2014-04-25 22:20:58 +00:00
Tadashi G. Takaoka
7a78127a56
Remove unnecessary reference to LatinIME
...
Change-Id: Idbb45c504499d39bbf272fae84ea71a83bf4dd69
2014-04-25 15:09:39 -07:00
Keisuke Kuroyanagi
169acbf9f0
Add null check in createDistracterFilter().
...
Change-Id: Iff2b73081d48f32b1d3a5d5b32c9734979362c23
2014-04-25 13:36:46 -07:00
Tadashi G. Takaoka
a3920c7e6a
Move some advanced settings to debug settings
...
This CL moves "Show slide indicator" and "Key long press delay"
advanced options to the debug settings.
Bug: 11866784
Change-Id: Iec16e09ba6e7c9f82ce0fa73a0d75766b843b44b
2014-04-25 12:03:47 -07:00
Xiaojun Bi
516c884b11
Merge "Prepare to implement distracter filter"
2014-04-25 17:15:53 +00:00
Xiaojun Bi
281dd99346
Prepare to implement distracter filter
...
It was implemented according to the Plan B in the
design doc:
http://go/ime-misspelling-filter
This CL is to create a DistracterFilter instance
and pass it to PersonalizationDictionarySessionRegistrar.
This patch should be checked in together with
Id633b4fd45693
Bug: 13142176
Change-Id: Ia4957e64218c9619fcf9bb91795a187617c72a2e
2014-04-25 09:13:22 -07:00
Keisuke Kuroyanagi
e581d8f8ab
Merge "Fix: contains() is wrongly used in hasDict()."
2014-04-25 07:58:19 +00:00
Keisuke Kuroyanagi
bdf31fb75e
Fix: contains() is wrongly used in hasDict().
...
Change-Id: I4699b1b75fed9dd479f5135f0a7a2dd098e6f798
2014-04-25 00:56:27 -07:00
Keisuke Kuroyanagi
1ed248dc2f
Merge "Fix: Wrong null check for user history dict."
2014-04-25 06:48:16 +00:00
Keisuke Kuroyanagi
93f4aec07c
Fix: Wrong null check for user history dict.
...
Change-Id: Idf0bcc44247e35cd95f9482d2a8017329fc977bb
2014-04-24 23:08:48 -07:00
Keisuke Kuroyanagi
a9861ac814
Merge "Handle personalization dictionary as an ExpandableBinaryDictionary."
2014-04-25 04:56:14 +00:00
Keisuke Kuroyanagi
194d64fa58
Merge "Handle contacts dictionary as an ExpandableBinaryDictionary."
2014-04-25 04:54:09 +00:00
Keisuke Kuroyanagi
56e4848ead
Handle personalization dictionary as an ExpandableBinaryDictionary.
...
Bug: 13755213
Change-Id: I26e070e89e09b37e9dcc200d597c74c591467a66
2014-04-24 21:37:49 -07:00
Keisuke Kuroyanagi
98e276a0ec
Merge "Quit creating empty dictionary file in ExpandableBinaryDictionary."
2014-04-25 04:36:55 +00:00
Keisuke Kuroyanagi
62c110a4c0
Handle contacts dictionary as an ExpandableBinaryDictionary.
...
Bug: 13755213
Change-Id: I0eb5055f9cdf5e1df337cdace9bf0919d4d365d3
2014-04-24 21:36:30 -07:00
Keisuke Kuroyanagi
3d2a9af20a
Merge "Handle user history dictionary as an ExpandableBinaryDictionary."
2014-04-25 04:30:39 +00:00
Keisuke Kuroyanagi
a933776bf1
Merge "Simplify DictionaryFacilitatorForSuggest to be flexible."
2014-04-25 04:29:50 +00:00
Keisuke Kuroyanagi
67c0ed8f8c
Handle user history dictionary as an ExpandableBinaryDictionary.
...
Bug: 13755213
Change-Id: I1ea8a6df007af7153852f2d32bf5e8ec669c432b
2014-04-24 14:48:01 -07:00
Tadashi G. Takaoka
e2651aa450
Merge "Announce keyboard language when TalkBack is on"
2014-04-24 20:40:31 +00:00
Keisuke Kuroyanagi
3d658a63ca
Merge "Remove clearAndFlushDictionary() and use clear()."
2014-04-24 18:29:05 +00:00
Keisuke Kuroyanagi
978958a41f
Simplify DictionaryFacilitatorForSuggest to be flexible.
...
Bug: 13755213
Change-Id: I151269a7038b72a33b436da4c7596e09949e6d00
2014-04-24 11:25:50 -07:00
Keisuke Kuroyanagi
2dcb5c1b4d
Remove clearAndFlushDictionary() and use clear().
...
clearAndFlushDictionary() was needed when dictionaries are constructed
in java side. All expandable dictionaries now use native code; thus,
this method is same to clear() and no longer needed.
Bug: 13755213
Change-Id: Ifd836e64f8ff807930f7cd2319b103b65e8fce70
2014-04-24 11:25:47 -07:00
Tadashi G. Takaoka
b9e0b99765
Merge "Fix handling shift + enter"
2014-04-24 02:38:46 +00:00
Tadashi G. Takaoka
393da03c8e
Fix handling shift + enter
...
Bug: 14278758
Change-Id: Id77c99b83cc69855972b27c9cebd482c8cbd3539
2014-04-23 19:22:00 -07:00
Tadashi G. Takaoka
f7edc6582a
Move simulateKeyPress method to AccessibleKeyboardViewProxy
...
Change-Id: Ic14ff70c7c8475983cf02dc1ba4d5a5f7769aa16
2014-04-23 17:48:27 -07:00
Tadashi G. Takaoka
3cf759074a
Announce keyboard language when TalkBack is on
...
Bug: 13013501
Change-Id: I0595abafbc177f776676cb3560f3990da9328db2
2014-04-23 13:53:06 -07:00
Keisuke Kuroyanagi
7de3d0eed7
Merge "Fix: Reporting wrong main dictionary availability."
2014-04-22 23:32:50 +00:00
Keisuke Kuroyanagi
de4d401038
Fix: Reporting wrong main dictionary availability.
...
Bug: 13965806
Change-Id: Ida2234ab8cb7785ec5efd433a58949bf21c44351
2014-04-22 16:24:22 -07:00
Tadashi G. Takaoka
5179608e19
Merge "Use ArrayList constructor directly"
2014-04-22 21:54:00 +00:00
Tadashi G. Takaoka
965621574d
Use ArrayList constructor directly
...
This is a follow up of I85a0b18d2d.
Change-Id: Ia7a642bb6e0015242d6e046019b3973226a0add2
2014-04-22 14:36:38 -07:00
Tadashi G. Takaoka
9d84d67b44
Fix typo of local variable name
...
Change-Id: I09c0aeee979e883af199f5c533d526a089064987
2014-04-22 14:25:53 -07:00
Tadashi G. Takaoka
616b84c93e
Merge "Use sorted keys index as virtual view id"
2014-04-22 20:58:24 +00:00
Keisuke Kuroyanagi
d437df0ab0
Quit creating empty dictionary file in ExpandableBinaryDictionary.
...
Bug: 14166482
Change-Id: I7b7a25141851d7bb14744567639d8e5d8f04a036
2014-04-22 13:18:36 -07:00
Keisuke Kuroyanagi
3b7984752c
Support creating BinaryDictionary without creating dict file.
...
Bug: 14166482
Change-Id: Ic8c78ec2c8f39358a1f085a041b608972a380eef
2014-04-22 13:18:34 -07:00
Keisuke Kuroyanagi
ce76821dce
Revert "Support creating BinaryDictionary without creating dict file."
...
This reverts commit 89939b8708
.
Change-Id: I8ca1b55609ad305a93178063bd88bd1cede872af
2014-04-22 19:34:44 +00:00
Tadashi G. Takaoka
9289260822
Use sorted keys index as virtual view id
...
Change-Id: Id3f81de1edaacc06362b65aa7b68e9317e6596bd
2014-04-22 12:15:52 -07:00
Keisuke Kuroyanagi
89939b8708
Support creating BinaryDictionary without creating dict file.
...
Bug: 14166482
Change-Id: Ib065279f96e227ab0fee7c8141560c4ada744d3b
2014-04-22 12:01:33 -07:00
Keisuke Kuroyanagi
68b4f2ada9
Merge "Add jni interface to use on memory dictionary."
2014-04-22 17:07:16 +00:00
Tadashi G. Takaoka
543d3d24bd
Stop using Configuration.setLocale
...
The call for method Configuration.setLocale that is introduce by
If60877b29b should be remove to be compatible with API 14 and later.
Bug: 14239862
Change-Id: I3815c2b56bd9c655b8bde6f93143adf3ff08c35d
2014-04-22 09:22:46 -07:00
Keisuke Kuroyanagi
61cb852d33
Add jni interface to use on memory dictionary.
...
Bug; 14166482
Change-Id: I33ab08dad1e39aa7617d391f7eb2561d6f2504bb
2014-04-21 19:59:09 -07:00
Tadashi G. Takaoka
a685fc1792
Merge "Remove unnecessarily getKeyFromOutputText method from Keyboard"
2014-04-22 01:57:32 +00:00
Tadashi G. Takaoka
543d25d786
Merge "Sort keys from top-left to bottom-right order"
2014-04-22 01:52:00 +00:00
Tadashi G. Takaoka
0ea82be889
Remove unnecessarily getKeyFromOutputText method from Keyboard
...
Change-Id: I61986ed65ce6696a8b0d885bdeb9668e6087bc47
2014-04-21 18:48:53 -07:00
Tadashi G. Takaoka
c13c1adfa7
Sort keys from top-left to bottom-right order
...
Change-Id: I228748824de62e9e46fa43db200d23f41eb6d2ce
2014-04-21 18:36:11 -07:00
Keisuke Kuroyanagi
3acbf7d00c
Merge "Add BinaryDictionary.flushWithGCIfHasUpdated()."
2014-04-22 00:10:42 +00:00
Keisuke Kuroyanagi
c6704dbe51
Add BinaryDictionary.flushWithGCIfHasUpdated().
...
Bug: 14166482
Bug: 14161647
Change-Id: I98b0a8b86897b1486491a3aea91729bc9e4cc03c
2014-04-21 15:21:55 -07:00
Tadashi G. Takaoka
5326dcfb7d
Use unmodifiable list to return keys from Keyboard
...
Change-Id: I85a0b18d2d78632e9a9f074eda1de9225001f876
2014-04-21 14:31:27 -07:00
Tadashi G. Takaoka
58d4e610ac
Use unmodifiable list to return the nearest keys
...
Change-Id: Ic9084b08fa9a1f25b7f4b98c627350583c401c12
2014-04-21 14:30:59 -07:00
Tadashi G. Takaoka
064af5c0fc
Stop using modifiable Key array
...
Change-Id: I0f3e96672da4261ae5628d2d5ea39d60e6287ac0
2014-04-21 13:52:00 -07:00
Xiaojun Bi
11b7076168
Fix a bug for counting code points in WordComposer.java
...
This bug threw an ArrayIndexOutOfBoundsException when the word length
is 49 (maxSize + 1) when calling StringUtils.copyCodePointsAndReturnCodePointCount(...)
in the same function. This bug is discovered by running SKETCH.
The intent is to count the code points from index 0 to index i (included).
The original code only counted the code points from index 0 to index (i-1).
Bug: 13969542
Change-Id: Idbf596aba2379ba552dbe580c83c42044d505aaf
2014-04-18 14:56:35 -07:00
Tadashi G. Takaoka
a980fb39a5
Merge "Refactor RunInLocale a bit"
2014-04-17 08:59:25 +00:00
Tadashi G. Takaoka
8180b02bed
Merge "Add contentDescription to Emoji palette"
2014-04-17 08:56:22 +00:00
Tadashi G. Takaoka
bfc998096b
Add contentDescription to Emoji palette
...
This CL adds content descriptions of:
- Emoji Category icon/label.
- Delete key
- Space key
Bug: 11452158
Change-Id: Ic00592c560b6265c880cd25f2e18cfd349b4620b
2014-04-17 17:43:34 +09:00
Tadashi G. Takaoka
5c490e5da5
Refactor RunInLocale a bit
...
Change-Id: If60877b29bb1263161ec85c99320ad07b7dd4245
2014-04-17 17:39:19 +09:00
Jean Chalard
20b0c3c5a9
Merge "Avoid lower-case version of capitalized words in user hist"
2014-04-17 08:22:42 +00:00
Jean Chalard
649dcba5a8
Avoid lower-case version of capitalized words in user hist
...
Bug: 14096825
Change-Id: Ib6cc8fc31e90862e0b05f5a06757a73069726b74
2014-04-17 16:41:26 +09:00
Jean Chalard
86ff9d6dda
Merge "Fix a wrong parameter passed."
2014-04-17 07:39:52 +00:00
Jean Chalard
26611120c9
Fix a wrong parameter passed.
...
Bug: 14120001
Change-Id: I8258304bc500fe28870fb8a5c11c15d97795423c
2014-04-17 15:44:55 +09:00
Keisuke Kuroyanagi
b21edc4402
Shuwdown executors after executing all tasks.
...
Bug: 14113276
Change-Id: Ie42ef30ffe5767ca434db4669efad2027b474e74
2014-04-17 09:28:52 +09:00
Jean Chalard
ba635ad30d
Merge "Restart suggestions when restarting input"
2014-04-16 10:43:28 +00:00
Tadashi G. Takaoka
166fd799d4
Merge "Dismiss more suggestions before showing important notice"
2014-04-16 09:43:39 +00:00
Jean Chalard
3aba6263f0
Restart suggestions when restarting input
...
Bug: 6851364
Change-Id: I3052924053f37f56c9c3953051aa1b22224a2b2e
2014-04-16 17:02:08 +09:00
Tadashi G. Takaoka
c8abd13c77
Dismiss more suggestions before showing important notice
...
Bug: 14078601
Change-Id: I029cadd8f2f170b5a3e70df170e306c9be109a70
2014-04-16 15:40:39 +09:00
Jean Chalard
66e509b1d4
Fix some failing tests
...
Bug: 13968927
Change-Id: I7e5e075535e38bf0fa24af98ed6e2cdfd6de6556
2014-04-15 21:44:46 +09:00
Jean Chalard
1ee443d848
Merge "[IL135] Make getCurrentAutoCapsState private"
2014-04-15 02:27:52 +00:00
Jean Chalard
82d3a56b09
Merge "[IL134] Add an alternative path to getCurrentAutoCapsState"
2014-04-15 02:24:41 +00:00
Jean Chalard
751dc070bf
Merge "Fix updating the shift state upon backspace"
2014-04-14 12:31:22 +00:00
Jean Chalard
2282e8520a
Fix updating the shift state upon backspace
...
Bug: 13514349
Change-Id: If4c9db12b0ab5be676f7a2f72715f469066ee537
2014-04-14 21:28:24 +09:00
Jean Chalard
f091c491ea
[IL135] Make getCurrentAutoCapsState private
...
Bug: 8636060
Change-Id: I800aefe6fee4c14df6fe5abe21b2387c69abb8f5
2014-04-14 21:09:32 +09:00
Jean Chalard
ddc163988a
[IL134] Add an alternative path to getCurrentAutoCapsState
...
Bug: 8636060
Change-Id: I959e13d34910adad028ed6174f92029ff690eeeb
2014-04-14 21:09:32 +09:00
Tadashi G. Takaoka
c3a19a5249
Remove GingerBread keyboard theme
...
This CL must be checked in together with I6a9ac172a5.
Bug: 14042743
Change-Id: Ic3f01f5d10097d743325df847bd7cd2959992487
2014-04-14 19:05:21 +09:00
Tadashi G. Takaoka
21eafd7910
Use KeyboardTheme id insteand of index
...
This CL must be checked in together with I771216f8bd.
Bug: 14042743
Change-Id: I45c3acf9242985fb03721a9a6d377fbccc8e2019
2014-04-14 18:59:54 +09:00
Tadashi G. Takaoka
3568fca95f
Merge "Refactor KeyboardTheme as top-level class"
2014-04-14 09:57:36 +00:00
Tadashi G. Takaoka
d6aa94e6b5
Refactor KeyboardTheme as top-level class
...
This CL should be checked in together with I63e33388f9.
Bug: 14042743
Change-Id: I13f0a45bac6f19e006bf1280a36173e52d6d7160
2014-04-14 17:10:11 +09:00
Tadashi G. Takaoka
30d5ed67d6
Keep ImportantNoticeDialog showing after orientation changed
...
Bug: 13951402
Change-Id: Ia6340d48843abca68ebadd299827cbe43516cc39
2014-04-14 15:48:19 +09:00
Yohei Yukawa
da498229f4
Merge "Plumbing for ProductionFlag.USES_CURSOR_ANCHOR_MONITOR"
2014-04-13 12:56:43 +00:00
Jean Chalard
4f4770cbf0
Merge "[CB26] Remove useless variables."
2014-04-11 10:00:57 +00:00
Tadashi G. Takaoka
977d052f8c
Revise myanmar keyboard layout
...
Note that this keyboard layout is still a preliminary.
Bug: 7963632
Change-Id: I4c53b3359ea2c0dd8e2ce7db8ec916ab9340eec5
2014-04-11 15:29:30 +09:00
Yohei Yukawa
fab4ce43f8
Plumbing for ProductionFlag.USES_CURSOR_ANCHOR_MONITOR
...
With this CL, LatinIME starts calling
InputMethodService#setCursorAnchorMonitorMode in #onStartInput()
when ProductionFlag.USES_CURSOR_ANCHOR_MONITOR flag is explicitly
set to true.
BUG: 13891796
Change-Id: Ib2fb0c3521b61859d4cc530155ccaaee7ee16cbc
2014-04-11 12:26:33 +09:00
Jean Chalard
cb05dc1d1b
Merge "[IL133] Avoid calling a dangerous method from outside."
2014-04-10 09:15:13 +00:00
Jean Chalard
1ef9d5938e
[CB26] Remove useless variables.
...
This is nice for code simplicity, but it has a small adverse impact on
performance.
Bug: 13406701
Change-Id: I9316b3fe8d79b940fbd83cf1187c8c0d10b26c71
2014-04-10 18:13:35 +09:00
Tadashi G. Takaoka
cc729b6df5
Merge "Refactor SubtypeLocaleUtils a bit"
2014-04-10 08:51:03 +00:00
Jean Chalard
2e967f6607
Merge "Fix some flaky tests."
2014-04-10 08:47:20 +00:00
Jean Chalard
4370ff0998
Fix some flaky tests.
...
In tests, we create many instances of LatinIME, but we never
destroy them. That means we never close the dictionaries nor
the handlers.
This change calls onDestroy, which closes all dictionaries, and
adds some code to finish the handlers.
Change-Id: I942517a2a940c54256b08763f6b38f5b55809f55
2014-04-10 17:32:05 +09:00
Tadashi G. Takaoka
58e830ec19
Refactor SubtypeLocaleUtils a bit
...
Change-Id: If8b7fd5ef0b4ff3791deeacc12abb256a10176bf
2014-04-10 17:24:58 +09:00
Tadashi G. Takaoka
9eec53a2c2
Merge "Reorder German umlaut letters"
2014-04-10 06:26:21 +00:00
Tadashi G. Takaoka
784a4429ea
Reorder German umlaut letters
...
Bug: 13940739
Change-Id: I2e377b56e4a74d36c7e0cea4ad4e8d9341eb7feb
2014-04-10 15:24:45 +09:00
Tadashi G. Takaoka
ac5e6ddd97
Add Italian (Switzerland) it_CH layout
...
Bug: 13920900
Change-Id: I57df8ca12b0d8cc4bbca2372c0470dcae5b5cbfb
2014-04-10 11:56:44 +09:00
Yohei Yukawa
a4ac18551f
Merge "Add a new production flag for Cursor/Anchor monitor"
2014-04-09 12:36:28 +00:00
Yohei Yukawa
485114905e
Add a new production flag for Cursor/Anchor monitor
...
BUG: 13891796
Change-Id: I3565ca22aaf1d3cfce4f35999e2990b2df5157ef
2014-04-09 21:13:34 +09:00
Jean Chalard
77dd17ad36
Merge "[CB25] Refactor some array copying"
2014-04-09 09:57:00 +00:00
Jean Chalard
5f430e0189
[CB25] Refactor some array copying
...
Bug: 13406701
Change-Id: I09edd822f5cc2446b324d41c76d835bcff1191e6
2014-04-09 18:38:29 +09:00
Tadashi G. Takaoka
d317796207
Use Locale to process text resources
...
Change-Id: Ic1c4e1776071332e02c368055157124bb539d14e
2014-04-09 18:28:17 +09:00
Jean Chalard
45e34b4374
[CB24] Remove a useless test
...
If 1 character, then for sure !isGesture
Bug: 13406701
Change-Id: If8e9b080372eb8ddb15b8f97cce1399dc0c7f099
2014-04-08 21:36:52 +09:00
Yohei Yukawa
36dfb6d1a4
Fix build breakage caused by I0218dd07
...
BUG: 11746191
Change-Id: I0b693c4b22793f6e8fd77a9f045f205aa8fe4050
2014-04-08 20:00:16 +09:00
Yohei Yukawa
c9539f42f6
Merge "Add StatsUtils for checking state"
2014-04-08 10:23:41 +00:00
Tadashi G. Takaoka
6bb3556ff7
Use locale to look up KeyboardTextsTable
...
Change-Id: I1e05c7fdbb757efef0e9407dc25482ef1115e49a
2014-04-08 19:12:31 +09:00
Yohei Yukawa
dc0f7ca167
Add StatsUtils for checking state
...
BUG: 11746191
Change-Id: I0218dd07dde1d09321009ea1497258fc4235a1e8
2014-04-08 19:09:49 +09:00
Tadashi G. Takaoka
ceda8b925f
Update KeyboardTextsTable.java
...
Change-Id: I821eb214f3a8c34e91ca9bbf116cc53389a2fff0
2014-04-08 16:16:05 +09:00
Tadashi G. Takaoka
a857235d0c
Merge "Remove workaround code of placing DrawingPreviewPlacerView"
2014-04-07 08:58:20 +00:00
Tadashi G. Takaoka
0c01fc6f1c
Remove workaround code of placing DrawingPreviewPlacerView
...
This CL divides MainKeyboardView.locatePreviewPlacerView method into
two methods. One is installing DrawingPreviewPlacerView to the window
as Frontmost view. Another is telling the location of MainKeyboardView
to DrawingPreviewPlacerView. Thus we can eliminate workaround code to
deal with transient states in orientation change.
Change-Id: Ia5d8f28dfb5213d27aa218c72d838a3c3be5a527
2014-04-07 17:36:53 +09:00
Jean Chalard
da5c206934
Merge "[CB23] Merge add and deleteLast"
2014-04-07 08:16:36 +00:00
Jean Chalard
b724617b41
Merge "[CB22] Merge add and delete"
2014-04-07 06:59:07 +00:00
Jean Chalard
d52bec0069
[CB23] Merge add and deleteLast
...
Bug: 13406701
Change-Id: Id9a2e4144b1908ad27d78228ee19e6fc4d4d669f
2014-04-07 15:51:44 +09:00
Jean Chalard
633e4f4533
[CB22] Merge add and delete
...
...but this time, it works.
Bug: 13406701
Change-Id: Iaa00339a6be76413ffaeb74ff1556e15b3bb039d
2014-04-07 15:47:01 +09:00
Tadashi G. Takaoka
b6c70f4ed3
Remove unneeded CustomViewPager class
...
Originally this hacky class has been introduced by I0824f82c30 to
address bug: 11721001. Because the bug: 11721001 has been addressed
by I950f13ec40 and etc., this class should be removed.
Bug: 13665882
Change-Id: Iabdd369e4dddb0188534289eea1269fb196895eb
2014-04-07 12:41:51 +09:00
Ken Wakasa
e2e41dc22c
Merge "Revert "[CB22] Merge add and delete""
2014-04-04 18:26:06 +00:00
Ken Wakasa
ef0498a8cc
Revert "[CB22] Merge add and delete"
...
This reverts commit f6bce235ae
.
Seeing several new unit test failures after this CL. Reverting..
Change-Id: Ie97127550ee36dd4a07a36701e9c5118684dfbc5
2014-04-04 18:25:34 +00:00
Jean Chalard
f9516b00ec
Merge "[IL132] Remove some calls that let a value escape."
2014-04-04 13:33:26 +00:00
Jean Chalard
76c930eede
Merge "[CB22] Merge add and delete"
2014-04-04 10:10:55 +00:00
Tadashi G. Takaoka
9b46ddc1d5
Use platform default theme for activities and dialogs
...
Bug: 13698528
Change-Id: Ib904c911452525e3749c0eb287434b504576db5f
2014-04-04 17:13:54 +09:00
Jean Chalard
f977ca6c92
Merge "[CB21] More refactoring"
2014-04-04 06:56:49 +00:00
Jean Chalard
9298c9b1e1
Merge "Reset the client database on version upgrade."
2014-04-04 05:12:02 +00:00
Jean Chalard
4ac0904f83
Merge "[CB20] Some more refactoring"
2014-04-04 05:03:45 +00:00
Jean Chalard
2e5e74d367
Reset the client database on version upgrade.
...
Bug: 13632164
Change-Id: Iba333db63558254d760fc80244b3c9753c26b069
2014-04-03 23:20:20 +09:00
Jean Chalard
28a59dd049
Fix a bug with double-space-to-period
...
Bug: 13778001
Change-Id: I3ebd57950cdfacbbcdc64ed214c0590519a0665c
2014-04-03 22:07:57 +09:00
Jean Chalard
c5bd35e45f
Merge "[IL131] Cleanup some cruft"
2014-04-03 09:52:10 +00:00
Keisuke Kuroyanagi
fdd2db576d
Always close binary dicts for personalized dicts.
...
Bug: 10923130
Bug: 13664080
Change-Id: Ib247c775194a03462387994cd832b1650bfd1915
2014-04-03 18:08:23 +09:00
Jean Chalard
8ab4ae4377
[IL133] Avoid calling a dangerous method from outside.
...
We want to remove all calls to this as it lets internal values
escape, but there is some refactoring to do to finish this.
Bug: 8636060
Change-Id: Iedba6afe4719bc0add868714a1ee5a04b7ead33e
2014-04-03 15:36:15 +09:00
Jean Chalard
9320553ab9
[IL132] Remove some calls that let a value escape.
...
Bug: 8636060
Change-Id: I696514934586ee71e734fd974026af8b2c866127
2014-04-03 15:36:15 +09:00
Jean Chalard
7ebd7ca9a4
[IL131] Cleanup some cruft
...
Bug: 8636060
Change-Id: I169618b50532df68e973e14b3f114c6c19714c84
2014-04-03 15:36:12 +09:00
Keisuke Kuroyanagi
35314af0d8
Merge "Extend jni interface to input/output languageWeight."
2014-04-02 16:20:28 +00:00
Keisuke Kuroyanagi
1de95ceada
Extend jni interface to input/output languageWeight.
...
Bug: 8187060
Change-Id: Ic55d328b87f258f4d65fff207233789a53b2b0ff
2014-04-03 01:01:51 +09:00
Keisuke Kuroyanagi
6b64de5063
Merge "Add languageWeight as an argument of getSuggestions."
2014-04-02 15:54:55 +00:00
Keisuke Kuroyanagi
18f21f96e0
Add languageWeight as an argument of getSuggestions.
...
Bug: 8187060
Change-Id: I8ae20c957a8e127b76c83cc3a65ff052d43bf2b5
2014-04-03 00:47:28 +09:00
Keisuke Kuroyanagi
a327d4a475
Merge "Use fixed order of dictionaries to get suggestions."
2014-04-02 13:24:52 +00:00
Keisuke Kuroyanagi
5b00d74c2e
Use fixed order of dictionaries to get suggestions.
...
Bug: 8187060
Change-Id: Id287776e3a82c0a6b208d677b8f2891266c5fc8d
2014-04-02 22:17:18 +09:00
Jean Chalard
06b50ed5f2
Merge "[IL130] Remove a useless local"
2014-04-02 09:18:45 +00:00
Jean Chalard
a49d326426
Merge "[IL129] Change some confusing method names."
2014-04-02 09:18:15 +00:00
Jean Chalard
4323e1126c
Merge "[CB19] Some refactoring"
2014-04-02 09:17:43 +00:00
Jean Chalard
750a3557a0
Merge "[CB18] Move some code around"
2014-04-02 09:17:30 +00:00
Jean Chalard
cc5a71caf1
Merge "[CB17] Remove a member."
2014-04-02 09:17:14 +00:00
Jean Chalard
26650377cf
[IL130] Remove a useless local
...
Bug: 8636060
Change-Id: I36ba3e00630bef644fc4671d0714490b5982f6a1
2014-04-02 18:10:21 +09:00
Jean Chalard
a777c1c460
[IL129] Change some confusing method names.
...
Bug: 8636060
Change-Id: I2f55fc23d7e05b63582a3f0660b58635eae5ec59
2014-04-02 18:10:18 +09:00
Jean Chalard
f6bce235ae
[CB22] Merge add and delete
...
Bug: 13406701
Change-Id: Ic9e90dd226b58b5ddb9693e04259cde00916007e
2014-04-02 18:01:00 +09:00
Jean Chalard
3e160bbe6b
[CB21] More refactoring
...
Bug: 13406701
Change-Id: I96e0a7fa2d9f4dfd8c355da4effc116bbd0f7f18
2014-04-02 18:01:00 +09:00
Jean Chalard
dfaeb125eb
[CB20] Some more refactoring
...
Bug: 13406701
Change-Id: I4502658f4f1e1997d0ac245d95e2d4a1415b1861
2014-04-02 18:00:57 +09:00
Jean Chalard
0f913ff5ba
[CB19] Some refactoring
...
Bug: 13406701
Change-Id: Ie4d420e8cabbbd93c3eea13a80baa4d766ee61d0
2014-04-02 18:00:19 +09:00
Jean Chalard
8bb2e99aef
[CB18] Move some code around
...
Bring next to each other two methods scheduled for a merge
Bug: 13406701
Change-Id: I335c7202cc07d8865f4ab92e4023c1d93d1f83ac
2014-04-02 17:58:33 +09:00
Jean Chalard
3285b68c97
[CB17] Remove a member.
...
Bug: 13406701
Change-Id: I2e271f637f6b529a4191a7adc5cdfa5af437761b
2014-04-02 17:57:36 +09:00
Tadashi G. Takaoka
7dd32dfc06
Remove country name from space bar text when appropriate
...
Remove country name from space bar text when there no other subtype
that is a same language and a same keyboard layout.
Bug: 8084704
Change-Id: I7c785a925ff7a0a61e5d009f138e1df52b3aeb3a
2014-04-02 12:50:52 +09:00
Tadashi G. Takaoka
65a199ca8e
Merge "Add SpacebarLanguageUtils class"
2014-04-01 03:25:31 +00:00
Tadashi G. Takaoka
9364d46ac3
Add SpacebarLanguageUtils class
...
The SpacebarLanguageUtils class is separated from SubtypeLocaleUtils
and handles the language name on the spacebar.
Bug: 8084704
Change-Id: I82f79a061d4f0cc2895263298c3ebf8ee444c61d
2014-04-01 12:17:06 +09:00
Jean Chalard
1dc354bed1
Merge "[IL128] Remove passing some handlers."
2014-03-31 09:32:00 +00:00
Jean Chalard
dbadee96b6
Do not create a handler thread for each session
...
Bug: 13710224
Bug: 12821388
Bug: 12667742
Change-Id: I6188e0240193d2bca789110e7660a0f31bbafc62
2014-03-31 15:32:48 +09:00
Keisuke Kuroyanagi
f41518dbab
Fix: spell checker wrongly sorts suggestions.
...
Change-Id: I729e1cd5e5e333038b9d9e6197cf50b574990d76
2014-03-28 14:37:48 +00:00
Jean Chalard
452cd2f619
Fix a bug where LatinIME would leak pipes.
...
Bug: 12667742
Bug: 12821388
Change-Id: Ic0bad56fb96e54ac032759adffc8ea320c06dff2
2014-03-28 19:54:07 +09:00
Jean Chalard
52eb673c46
Merge "Some cleanup"
2014-03-28 09:22:22 +00:00
Tadashi G. Takaoka
03f9c4820a
Merge "Make NeedsToDisplayLanguage as a top level class"
2014-03-28 09:15:25 +00:00
Tadashi G. Takaoka
c412a41aff
Merge "Remove redundant check to detect forceAscii"
2014-03-28 09:15:18 +00:00
Tadashi G. Takaoka
8e3c585265
Make NeedsToDisplayLanguage as a top level class
...
Change-Id: Ia05e0494a9dccebfb5c1316479e52f04cf2ae444
2014-03-28 17:59:57 +09:00
Tadashi G. Takaoka
61dbda00de
Remove redundant check to detect forceAscii
...
Change-Id: Ib3272ec19a90b3aa4937573e049ceb86855ea408
2014-03-28 17:56:08 +09:00
Keisuke Kuroyanagi
a4c5c54a19
Merge "Remove unused method."
2014-03-28 08:07:42 +00:00
Keisuke Kuroyanagi
781e3df73b
Merge "Dictionary migration in Java side."
2014-03-28 08:07:26 +00:00
Jean Chalard
35645ac39a
Merge "[CB14.5] Stop copying WordComposers."
2014-03-28 06:51:17 +00:00
Jean Chalard
70d9152c7f
Some cleanup
...
Change-Id: Ia11d656a70623168b091763ac6524750f9cca8d8
2014-03-28 15:27:00 +09:00
Jean Chalard
8e829c37df
[CB14.5] Stop copying WordComposers.
...
This is an overdue refactoring that I have been wanted to
do forever, and that we can at last do now that suggestions
come only from instances of BinaryDictionary instances.
With this, all unit tests and regression tests are
passing again.
Bug: 13667648
Bug: 13665487
Bug: 8636060
Change-Id: Ie23a19f9b7e692edf2ee0b107ddaff2d7db564b6
2014-03-28 15:26:27 +09:00
Keisuke Kuroyanagi
3c801be5e5
Merge "Fix unit tests by adding @UsedForTesting."
2014-03-28 06:08:37 +00:00
Keisuke Kuroyanagi
aa7abb2d89
Fix unit tests by adding @UsedForTesting.
...
Change-Id: I8497d6cf446297bc8c15e9d9818078b1026a8c51
2014-03-28 15:02:00 +09:00
Tadashi G. Takaoka
f173b12b03
Merge "Stop displaying locale string on short space bar"
2014-03-28 04:49:17 +00:00
Tadashi G. Takaoka
2202d47386
Stop displaying locale string on short space bar
...
Bug: 12070355
Change-Id: I2d6fa20431bc56d5139caeac33e396b73906d075
2014-03-28 13:05:13 +09:00
Keisuke Kuroyanagi
30cd0cd2a0
Fix: NPE after onDestroy().
...
Bug: 13671513
Change-Id: I06aa14870ff5422ad514356ee406600b247858c5
2014-03-28 12:17:44 +09:00
Jean Chalard
080e0253ae
Merge "Revert "[CB15] Remove a redundant variable.""
2014-03-27 09:44:31 +00:00
Jean Chalard
f459ccf4f6
Merge "Revert "[CB16] Remove unused stuff""
2014-03-27 09:44:24 +00:00
Jean Chalard
75715f7d9f
Revert "[CB15] Remove a redundant variable."
...
This reverts commit 0de7a6d1a2
.
Change-Id: I327679b76a14cf9c3aec4b00b013b921408c32f9
2014-03-27 09:43:45 +00:00
Jean Chalard
26baa759d8
Revert "[CB16] Remove unused stuff"
...
This reverts commit 05c46f59fd
.
Change-Id: Ica0feea10fff1b2a9ef42bc55cb7c1892b3a3f58
2014-03-27 09:43:21 +00:00
Jean Chalard
5154c47cbe
Merge "[CB16] Remove unused stuff"
2014-03-27 08:52:11 +00:00
Jean Chalard
6bd3723e73
[IL128] Remove passing some handlers.
...
Bug: 8636060
Change-Id: I088be9a7555265ca097667523defd73be4cbe37f
2014-03-27 17:51:32 +09:00
Keisuke Kuroyanagi
c17311cefe
Remove unused method.
...
Change-Id: Iefb75136080e73c357511df045816f18cec767a6
2014-03-27 17:46:38 +09:00
Keisuke Kuroyanagi
a785fa8edd
Dictionary migration in Java side.
...
Bug: 13406708
Change-Id: If83938e4b4810d2e8353c70cdd8ef3ea97a29571
2014-03-27 17:46:35 +09:00
Ken Wakasa
e04a9798f6
Merge "Call setLayerType(LAYER_TYPE_HARDWARE) for EmojiPalettesView too."
2014-03-27 08:27:59 +00:00
Ken Wakasa
e289441f92
Call setLayerType(LAYER_TYPE_HARDWARE) for EmojiPalettesView too.
...
This CL probably does not addresses the bug, but still this should
be the right thing to do here.
bug: 12667742
Change-Id: I587652942fd66094779fb7942c734e0ff5f9d0b6
2014-03-27 17:26:22 +09:00
Jean Chalard
5feda45a6f
Merge "[CB15] Remove a redundant variable."
2014-03-27 08:05:23 +00:00
Jean Chalard
05c46f59fd
[CB16] Remove unused stuff
...
Bug: 13406701
Change-Id: Ib863c5181e1f5d74cfa4458060afc49d1ee8109e
2014-03-27 16:47:30 +09:00
Jean Chalard
0de7a6d1a2
[CB15] Remove a redundant variable.
...
This is a tiny bit slower, but probably unnoticeable.
Still, it gains some performance in other places,
saves memory, and more importantly makes for simpler
code, so it's certainly better.
Change-Id: Id1ab4f73f71acd73f5920bc729817abd22cf0d07
2014-03-27 16:47:27 +09:00
Keisuke Kuroyanagi
6008898b99
Merge "Move code only used for dicttool and tests under tests."
2014-03-27 06:37:10 +00:00
Keisuke Kuroyanagi
93cda5bb39
Move code only used for dicttool and tests under tests.
...
Bug: 13035567
Change-Id: I13c6df013ef2b67c9bf67455d9c32d283bf9ea2e
2014-03-27 15:30:32 +09:00
Keisuke Kuroyanagi
3c38e1f269
Merge "Fix: NPE in isValidWord after dictionaries are closed."
2014-03-27 03:12:07 +00:00
Keisuke Kuroyanagi
7b516d496d
Fix: NPE in isValidWord after dictionaries are closed.
...
Bug: 13650542
Change-Id: I1bdc838fca48d6ef12db5e70d40273d1236128d1
2014-03-27 12:03:58 +09:00
Tadashi G. Takaoka
4cb152682d
Fix crash while entering emoticons
...
Bug: 13652919
Change-Id: Idd66240ac882fa890cfb28a477403ee09dc716ce
2014-03-27 11:08:11 +09:00
Tadashi G. Takaoka
c4b558d375
Merge "Rename text resources consistently"
2014-03-26 10:06:34 +00:00
Jean Chalard
071b9c1a05
Merge "[CB14] Implement backspace in the combiner chain"
2014-03-25 10:46:32 +00:00
Jean Chalard
1079665c3c
[CB14] Implement backspace in the combiner chain
...
Bug: 13622107
Bug: 13406701
Change-Id: I0023b398c4451253f9f717e2bd990b8a054004bc
2014-03-25 17:57:03 +09:00
Keisuke Kuroyanagi
adfb262797
Remove logic related to dictionary loading from LatinIME.
...
Make mSuggest final and give DictionaryFacilitator the
responsibility to manage dictionary loading state.
This can simplify the logic to decide how to deal with
additional dictionaries when loading settings or language
switching.
Bug: 13273534
Change-Id: I9f3d328272f25addfa186fbeedaaf8417455ba99
2014-03-25 15:35:20 +09:00
Tadashi G. Takaoka
393efd94e5
Rename text resources consistently
...
- keylabel_<key>, the key label text of the <key>
- keyspec_<key>, the key specification of the <key>
- keyhintlabel_<key>, the hint label text of the <key>
- morekeys_<key>, the more keys specifications of the <key>
- additional_morekeys_<key>, the additional more keys specification of
the <key>
Change-Id: Ib2127f21fa33a2568e8a6eba65cfdb2cf78b480e
2014-03-25 13:02:09 +09:00
Tadashi G. Takaoka
37b9562fd7
Fix talk back of emoji key
...
Bug: 13629734
Change-Id: Ifff6f81c2ac99a32855cd333b3d9a01ad7155ffc
2014-03-25 11:58:59 +09:00
Yohei Yukawa
f1f5ed542d
Check null before passing to Integer.parseInt
...
Just after user data is cleared, user preference associated with
PREF_KEYBOARD_LAYOUT is always empty. In such case, we might
want to return the default value immediately, rather than
calling Integer.parseInt(null) and catching NumberFormatException
unnecessarily.
BUG: 13472379
Change-Id: I8dca9a22780d057013c032bd1f56e730dcada3ce
2014-03-24 20:54:03 +09:00
Jean Chalard
d36cbc44e4
[CB13] Remove an unused method.
...
Change-Id: If4d2fa9c6499ce9b2427cea424abd497ec4a966b
2014-03-24 17:44:36 +09:00
Jean Chalard
cbed462d19
[CB12] Reset the combining state when resetting the composer
...
Bug: 13406701
Change-Id: I490574b7ca4b953f67dd2c0ef97401297fade0a4
2014-03-24 17:44:31 +09:00
Jean Chalard
7f0e5fa66c
Merge "[CB11] Get the result of the combination"
2014-03-24 05:33:34 +00:00
Jean Chalard
1dda9107ca
Merge "Rework the logic that tells if the cursor touches words"
2014-03-20 14:35:19 +00:00
Jean Chalard
835965a75e
[CB11] Get the result of the combination
...
Change-Id: I165ec4a24f5b1334d55c14948e4d942ec40eb33b
2014-03-20 23:33:12 +09:00
Jean Chalard
72b67f6541
Rework the logic that tells if the cursor touches words
...
Bug: 13312942
Change-Id: I6be6a558bbc6c88508150f9c25cadbd0240ff88e
2014-03-20 23:16:53 +09:00
Jean Chalard
4df6bc0853
Merge "[CB10] Add an event for string input"
2014-03-20 11:34:16 +00:00
Jean Chalard
058a38988b
[CB10] Add an event for string input
...
Change-Id: Ie5da6c73d4df4553067c58cd0dce9abb34534250
2014-03-20 19:47:01 +09:00
Tadashi G. Takaoka
b20dad6fab
Merge "Consolidate KeyboardTextsSet.setLocale and loadStringResoucres"
2014-03-20 09:59:11 +00:00
Tadashi G. Takaoka
df39eb6961
Consolidate KeyboardTextsSet.setLocale and loadStringResoucres
...
Change-Id: Idaf8f0d80fdeef4f1430f11d4083366e8ab7f6e0
2014-03-20 18:55:03 +09:00
Keisuke Kuroyanagi
7c20f140e0
Merge "Remove unused partial commit."
2014-03-20 09:54:15 +00:00
Tadashi G. Takaoka
0c268b08b6
Merge "Refactor KeyboardTextsSet class"
2014-03-20 09:52:02 +00:00
Keisuke Kuroyanagi
5a0381f7d0
Remove unused partial commit.
...
Change-Id: Ia9341a5cb24947d93056810890d94c1f66481d8c
2014-03-20 18:47:45 +09:00
Tadashi G. Takaoka
6007a1b7a9
Refactor KeyboardTextsSet class
...
Change-Id: Ibb59a9d4902db9ec0e00244304be9ab35b215a50
2014-03-20 18:38:59 +09:00
Jean Chalard
437dbbcfee
Merge "[IL127] Move the double space countdown to InputLogic"
2014-03-20 09:07:49 +00:00
Tadashi G. Takaoka
aacfa31c8e
Merge "Remove reference of KeyboardTextsSet from SpacingAndPunctuations"
2014-03-20 08:46:11 +00:00
Jean Chalard
83372e75e4
Merge "[CB09] Pass events through the combiner chain"
2014-03-20 08:32:36 +00:00
Tadashi G. Takaoka
44f144ab3a
Remove reference of KeyboardTextsSet from SpacingAndPunctuations
...
Change-Id: I76a8fcbd2466bcaf9cd85501af270db5aa913999
2014-03-20 17:14:43 +09:00
Tadashi G. Takaoka
e7420f6bd1
Merge "Utilize autoColumnOrder for punctuation more keys"
2014-03-20 08:01:18 +00:00
Jean Chalard
f2bb15b0ab
[CB09] Pass events through the combiner chain
...
Bug: 13406701
Change-Id: I4696f145478afdd132314b7d3c148c3a9ca11c9c
2014-03-20 16:59:29 +09:00
Tadashi G. Takaoka
844205ca2e
Utilize autoColumnOrder for punctuation more keys
...
Change-Id: I1f8f5013f0bdf93cf590b8bd00d680b31e03d8b0
2014-03-20 16:38:38 +09:00
Jean Chalard
c083733972
Merge "[CB08] Create a combiner chain in the word composer."
2014-03-20 07:02:48 +00:00
Tadashi G. Takaoka
e884fde8d2
Merge "Fix Armenian punctuation order"
2014-03-20 06:43:50 +00:00
Jean Chalard
7ede642df4
[CB08] Create a combiner chain in the word composer.
...
Bug: 13406701
Change-Id: I3b9f75de9283f76366d1bef7e14a8f22f2186669
2014-03-20 14:27:55 +09:00
Tadashi G. Takaoka
d51aebd328
Fix Armenian punctuation order
...
Bug: 12623502
Change-Id: I6cc026132922e103d212b663664e7e0aa2404b35
2014-03-20 13:17:38 +09:00
Tadashi G. Takaoka
89f1b72793
Merge "Remove Latin comma from Arabic/Persian keyboard"
2014-03-20 03:56:02 +00:00
Tadashi G. Takaoka
f96bffa69e
Suppress important notice when its title message is empty
...
Bug: 13422608
Change-Id: Ied16e87381e82d8539269ddd90d737f80c2a94c0
2014-03-20 11:48:28 +09:00
Tadashi G. Takaoka
270bd39af4
Remove Latin comma from Arabic/Persian keyboard
...
Bug: 12807701
Change-Id: Icca63586d561a57b2c15cbfbae0de98dfcc137a3
2014-03-20 11:45:53 +09:00
Tadashi G. Takaoka
14e908c348
Remove unused argument in SuggestionStripLayoutHelper
...
Bug: 13461039
Change-Id: I3f6227bd56fb81021aaacf0e901eab8a9e91d4a1
2014-03-20 11:06:55 +09:00
Tadashi G. Takaoka
110e9f9e88
Add Galician keyboard
...
Bug: 13169021
Bug: 13017434
Change-Id: I5d44dc4c2387644028a5cf594954795e014f357a
2014-03-19 19:41:18 +09:00
Tadashi G. Takaoka
0c797e8867
Add Basque keyboard
...
Bug: 13169021
Bug: 13017434
Change-Id: I46c738e833a9f287586a03bda9ab0230f8b9eac1
2014-03-19 19:40:34 +09:00
Tadashi G. Takaoka
682853c3af
Merge "Fix French accented letters order"
2014-03-19 10:38:01 +00:00
Jean Chalard
350d73932d
[IL127] Move the double space countdown to InputLogic
...
Bug: 8636060
Change-Id: Ie193b747bd9d0b5ba6a986b9a3c746c2182742ed
2014-03-19 17:47:03 +09:00
Jean Chalard
554346e94c
[IL126] Move a setting value to SettingsValues
...
Bug: 8636060
Change-Id: I7cb082df13a10cf5a3aa5786e6a9599376652dee
2014-03-19 17:47:03 +09:00
Jean Chalard
46e17983c6
[IL125] Remove arg to onPickSuggestionManually
...
Bug: 8636060
Change-Id: I55332c22897e97148621cbd367acf5175b5b3d04
2014-03-19 17:47:03 +09:00
Tadashi G. Takaoka
4640e7c989
Fix French accented letters order
...
Bug: 13497958
Change-Id: I062a0e2e75b2f6c2606b1309808cbaa83cc91018
2014-03-19 17:43:53 +09:00
Tadashi G. Takaoka
1325ddbae3
Merge "Guard possible NumberFormatException"
2014-03-18 07:26:18 +00:00
Tadashi G. Takaoka
d2c6151d4d
Guard possible NumberFormatException
...
Bug: 13472379
Change-Id: Ib7640b3d8816d8d7fb4747d2288eedd94bc49b06
2014-03-18 15:40:43 +09:00
Tadashi G. Takaoka
6bdb2e60dc
Merge "Add preliminary Myanmar keyboard"
2014-03-18 05:53:51 +00:00
Tadashi G. Takaoka
fc3263a75c
Add preliminary Myanmar keyboard
...
This CL adds preliminary Myanmar keyboard as a groundwork. The
keyboard layout comes mainly from virtual keyboard of
<http://www.google.com.mm/ >
Bug: 7963632
Change-Id: I36504ceb6c2079a6e133edaeb458da1c5cf3ded2
2014-03-18 10:28:57 +09:00
Jean Chalard
1110adad11
[CB07] Small refactoring
...
Bug: 8689779
Change-Id: I2cf10c690c7e4a9c6bf27211d1fccc1f9d4a9249
2014-03-17 21:26:36 +09:00
Jean Chalard
5eac728b4a
[CB06] Fix a design error.
...
The event interpreter should intervene later, after decoding.
Decoding should happen first, and then the Event should
be passed to the InputLogic.
For the time being, we will leave the (unused) EventInterpreter
class and its friends, because we'll use them again later.
Bug: 13406701
Change-Id: I7582d486724311e39e6692e606cca50c78800643
2014-03-17 20:49:29 +09:00
Tadashi G. Takaoka
ef27c83e74
Fix Persian symbols shifted output text
...
Bug: 13017434
Change-Id: I57af849ae4342bfee3fa08d7e90c6a6dbc229380
2014-03-17 12:31:09 +09:00
Tadashi G. Takaoka
538abc27dc
Fix Arabic keyboard text and test comments
...
Bug: 13017434
Change-Id: Iec2ddab719e0c68a70bcf56a90eb4522c5fd7978
2014-03-17 11:56:13 +09:00
Jean Chalard
5a1e351751
Merge "[CB04] Add an event array to WordComposer."
2014-03-14 04:29:59 +00:00
Jean Chalard
f8accd8839
[CB04] Add an event array to WordComposer.
...
Bug: 13406701
Change-Id: I9ecd2709c8f1c678a85b0cfaf7c5ed4f78459821
2014-03-14 12:44:49 +09:00
Tadashi G. Takaoka
a9c1a3da63
Fix clipped important notice message on tablet
...
Bug: 13461039
Change-Id: I710bf10c9cbc202c7f6ee39ab4c8b9d699741a81
2014-03-14 12:32:38 +09:00
Jean Chalard
309773c322
Merge "[CB03] Pass whole events to the various input logic handlers."
2014-03-13 12:12:31 +00:00
Tadashi G. Takaoka
a8e3ae6e96
Merge "Refactor keyboard layout test more customizable"
2014-03-13 12:09:47 +00:00
Tadashi G. Takaoka
15a6b66dda
Refactor keyboard layout test more customizable
...
Bug: 13017434
Change-Id: I804b4cb9f56684d425e83a20cb3f71d947a87f98
2014-03-13 20:55:22 +09:00
Jean Chalard
750cd48981
[CB03] Pass whole events to the various input logic handlers.
...
Bug: 13406701
Change-Id: I0a0e4e0b3357f116e1b915c548dee4575e300c92
2014-03-13 19:35:54 +09:00
Jean Chalard
a79a3265db
[CB02] Pass an Event to onCodeInput.
...
Bug: 13406701
Change-Id: Id82e9aab6544ca308e6ac6dee2cfa018b9ce2d8f
2014-03-13 18:41:02 +09:00
Jean Chalard
66dce6003f
Merge "[CB01] Reset some old assumptions about dead keys"
2014-03-13 08:53:29 +00:00
Jean Chalard
92db209c60
[CB01] Reset some old assumptions about dead keys
...
The combining framework will be more generic than previously
thought. We don't need to handle dead keys as a special type
of event, as all events can be combined arbitrarily.
Bug: 13406701
Change-Id: I8137fdb186c4d70eaa71808c5a1430b1559db1ae
2014-03-13 17:47:13 +09:00
Jean Chalard
13b446b8fb
Merge "Don't reset the value needed before it's used"
2014-03-12 08:04:42 +00:00
Tadashi G. Takaoka
567fbe90f7
Fix unused text resources of keyboard layouts
...
Icelandic keyboard has no nordic layout.
Latvian, Lithuanian, and Slovak keyboards have duplicated N WITH ACUTE.
No Language keyboard has duplicated letter a variants.
Change-Id: Iaeacebc1f7efdb70294e6342e42232b73aed9398
2014-03-10 17:31:25 +09:00
Jean Chalard
e93a7232d1
Don't reset the value needed before it's used
...
Nice recipe for failure
Bug: 13387534
Change-Id: Ida1978449c1997587b2ec0955c5c94fcef336121
2014-03-10 15:55:15 +09:00
Tadashi G. Takaoka
e07a777ed6
Fix unneeded u with diaeresis more key on Swedish keyboard
...
Change-Id: Ib4a17fa464899907616e76426e5df0d370a40f80
2014-03-10 11:15:18 +09:00
Tadashi G. Takaoka
315010636a
Fix excessive more keys on Estonian keyboard
...
Change-Id: I6c2d5d123d519278a6ff0f12fece69ccbad1aad5
2014-03-10 10:56:26 +09:00
Keisuke Kuroyanagi
32326a9d7a
Merge "Move DictionaryOptions from FusionDictionary to FormatSpec."
2014-03-07 10:42:18 +00:00
Keisuke Kuroyanagi
e137ec0a91
Introduce SuggestionResults and use it for predictions.
...
Bug: 8187060
Bug: 13333066
Change-Id: I1ead897024508b7e40fbd93af7d14bfe74b93826
2014-03-07 19:36:19 +09:00
Keisuke Kuroyanagi
a103e29d00
Merge "Separate WeightedString from FusionDictionary."
2014-03-07 09:07:26 +00:00
Tadashi G. Takaoka
ff8405cdfb
Add ActualKeyboardBuilder for testing keyboard layouts
...
Bug: 13017434
Change-Id: I38b1f5c261ea1f3ff312c780d7d9b5fe3fba8aaf
2014-03-07 17:29:58 +09:00
Keisuke Kuroyanagi
3ad4af2354
Move DictionaryOptions from FusionDictionary to FormatSpec.
...
Bug: 8187060
Bug:13035567
Change-Id: Id4f45e589521ae98c926a4c0607be10ce1a983f2
2014-03-06 18:53:09 +09:00
Keisuke Kuroyanagi
516f86815d
Separate WeightedString from FusionDictionary.
...
Bug: 8187060
Change-Id: I40c1dafca3eb52244c64fdb4c1db30a56385d678
2014-03-06 18:53:06 +09:00
Jean Chalard
3892991b80
Merge "[IL124] Remove the KeyboardSwitcher arg to onCodeInput"
2014-03-06 09:15:26 +00:00
Jean Chalard
4da06b9a19
Merge "Correctly update the suggestion strip on non-resumable word"
2014-03-06 08:54:44 +00:00
Keisuke Kuroyanagi
d93eb680c4
Merge "Use BinaryDictionaryUtils to read dictionary header."
2014-03-06 07:32:07 +00:00
Jean Chalard
a1bf550294
[IL124] Remove the KeyboardSwitcher arg to onCodeInput
...
Bug: 8636060
Change-Id: I29ce4c82ea880a937b1c9e5daf494fcdbbdd1336
2014-03-06 14:20:41 +09:00
Jean Chalard
db38d5cf63
[IL123] Put the settings values inside the transaction
...
A transaction should always operate with a consistent set
of settings. It's better to have it reference them than to
always pass them along.
Bug: 8636060
Change-Id: I3c642dfea6be30712fc6cbb279c64f3185895791
2014-03-06 14:20:37 +09:00
Jean Chalard
5054530934
Merge "[IL122] Put the code, x and y in the transaction"
2014-03-06 03:55:00 +00:00
Jean Chalard
29881854bc
[IL122] Put the code, x and y in the transaction
...
Bug: 8636060
Change-Id: Icdf87995dedec410b54c306e8d312ba7ec25cea6
2014-03-06 12:50:07 +09:00
Tadashi G. Takaoka
dbe531efa8
Merge "Remove unused text resource keylabel_for_east_slavic_row1_12"
2014-03-06 02:47:06 +00:00
Keisuke Kuroyanagi
de36b47d29
Use BinaryDictionaryUtils to read dictionary header.
...
Bug: 8187060
Bug:13035567
Change-Id: I90a5e0665c367f5a1bd786f4babf0d03e79e68fa
2014-03-05 19:42:53 +09:00
Keisuke Kuroyanagi
274eae95ba
Merge "Separate utility methods from BinaryDictionary."
2014-03-05 10:07:33 +00:00
Jean Chalard
c6e200ef3a
Correctly update the suggestion strip on non-resumable word
...
Bug: 13303965
Change-Id: Iedc5d38f70af76fbebb99e59a0d17c1e226c810d
2014-03-05 18:47:41 +09:00
Keisuke Kuroyanagi
e784148ae6
Separate utility methods from BinaryDictionary.
...
Bug: 8187060
Change-Id: Ice2984e332b7bd3bb17174aefc80b5635b72fc50
2014-03-05 18:19:34 +09:00
Jean Chalard
7b905c40e9
[IL121] Introduce InputTransaction
...
We probably can't put this off any longer
Bug: 8636060
Change-Id: I1e5d3cf62d719f4d064ced3282bebf2e822f6baa
2014-03-05 17:04:10 +09:00
Tadashi G. Takaoka
8204078a84
Merge "Remove unused MoreKeysPanel argument from Controller interface"
2014-03-04 10:53:23 +00:00
Jean Chalard
151761a276
[IL120] Cleanup
...
Remove useless arguments, local vars, make stuff private
Change-Id: I7cc6c19e9c1703304d593e02be31eb9569cc7b4e
2014-03-04 17:52:14 +09:00
Jean Chalard
fb28935f82
[IL119] Make fields private.
...
Change-Id: Ia84d3e5a102e1056e3d7467be07df89390f17617
2014-03-04 17:52:14 +09:00
Jean Chalard
0e489d1ba3
[IL118] Factorize a method
...
If we can't get the right locale from the subtype switcher, we
should fallback in all cases.
Change-Id: I46a53a67927a793d9d3592a996a5a4392a36c6ff
2014-03-04 17:52:14 +09:00
Jean Chalard
129ca9e7eb
[IL117] Simplification
...
Change-Id: Id4d4f30ecdc80dd59543f90fe2525f4bcc5afb9d
2014-03-04 17:52:11 +09:00
Tadashi G. Takaoka
4309b83ea9
Remove unused text resource keylabel_for_east_slavic_row1_12
...
The text resource used in 10 inch tablet layout.
This change also corrects {keylabel|more_keys}_for_east_slavic_row2_1
to _row2_2.
Change-Id: I60d69af22f97c008449b8dccc7c84ae6a05fe0d8
2014-03-04 17:12:31 +09:00
Tadashi G. Takaoka
1f215a58c9
Remove unused MoreKeysPanel argument from Controller interface
...
Bug: 13204690
Change-Id: Ife438e78d9bbbf796df20f95c2da7a4d50e5a035
2014-03-04 16:05:15 +09:00
Jean Chalard
2ca916c215
[IL116] Inline a method
...
Change-Id: I6af8f2bd6b4917f9b119ff78a0f299b2f6fb921e
2014-03-04 14:46:04 +09:00
Jean Chalard
e110018e2a
[IL114] Move a method to InputLogic
...
Bug: 8636060
Change-Id: I0d8f93985ddc6e93ce9af0d92a8056620351a498
2014-03-04 14:46:04 +09:00
Jean Chalard
030da519de
[IL115] Cleanup continues
...
Bug: 8636060
Change-Id: I944b10ec9798eec57d986e1075ba348aa0892cae
2014-03-04 14:46:04 +09:00
Jean Chalard
5d8f6660bf
[IL113] More cleanup
...
We should not test punctuation with this equality test any more.
Also, whether the suggestion strip is displayed or not, or whether
the hint is displayed or not, has nothing to do with this method
and should be handled elsewhere rather than here -- and as a
matter of fact, it is, which makes this useless.
Bug: 8636060
Change-Id: I6a54ee87e4e9f81bc33158acf4a264c3abd5829d
2014-03-04 14:46:04 +09:00
Jean Chalard
c92dabb27e
Merge "[IL112] Cleanup"
2014-03-04 05:45:15 +00:00
Jean Chalard
27c23c691c
Merge "[IL111] Remove a member."
2014-03-04 05:36:00 +00:00
Jean Chalard
145e8568f4
[IL112] Cleanup
...
Bug: 8636060
Change-Id: Ic7c2dec2521613d52707457463691bec383177ff
2014-03-04 14:32:02 +09:00
Jean Chalard
32c6d4caea
[IL111] Remove a member.
...
...and improve encapsulation and readability.
Bug: 8636060
Change-Id: I36407630b307df0721ea7fdb7e7a22cdf2b018b3
2014-03-04 14:31:47 +09:00
Tadashi G. Takaoka
ddc21f5bd1
Dismiss all key preview before showing more suggestions
...
This CL also release key graphics and dismiss sliding key input
preview.
Bug: 13204690
Change-Id: Ie8eb7b7beca51689a907da9c0713b4d34d48dda1
2014-03-04 14:26:00 +09:00
Ken Wakasa
61c726f591
Merge "Dismiss more keys keyboard before statring more suggestionsview to show"
2014-03-04 01:10:09 +00:00
Tadashi G. Takaoka
56e0373b5c
Dismiss more keys keyboard before statring more suggestionsview to show
...
Bug: 13204690
Change-Id: I9188edd0e99ca8acdcb0f0e045be7d267d56b12d
2014-03-04 10:02:05 +09:00
Tadashi G. Takaoka
8df489444d
Merge "Fix InputMethodInfo cache in RichInputMethodManager"
2014-03-03 15:16:55 +00:00
Tadashi G. Takaoka
ad5795a891
Fix InputMethodInfo cache in RichInputMethodManager
...
Bug: 13271570
Change-Id: Ie06cd83baaaf674d8b34f0232c164c4541aceb43
2014-03-03 23:36:35 +09:00
Tadashi G. Takaoka
3f91acdc96
Add additional subtypes test
...
Change-Id: I2994fd72bc284c84757f5a2bfa8045aa574a8fbc
2014-03-03 17:16:02 +09:00
Keisuke Kuroyanagi
e76c273502
Merge changes I20ce61c4,I2edab4e3
...
* changes:
Remove "Use only personalization dictionary".
Remove redundant creation of dictionary facilitator.
2014-03-03 04:00:24 +00:00
Keisuke Kuroyanagi
858045b41c
Merge "Fix: wrong auto correction for whilelist and personalized words."
2014-02-28 12:26:03 +00:00
Keisuke Kuroyanagi
23ae574a11
Fix: wrong auto correction for whilelist and personalized words.
...
This happens when there are tailing single quotes.
Bug: 13237314
Change-Id: I7fd2a20b25ac2217f9621d7f2510345bbd633c14
2014-02-28 21:24:26 +09:00
Keisuke Kuroyanagi
5128935ac4
Add header attributes for evaluation.
...
Bug: 13197276
Change-Id: Ib5247da691ff24a73e13485288237ccc51bb54f0
2014-02-28 21:06:03 +09:00
Keisuke Kuroyanagi
58a536e41a
Merge "Use dynamic operations to construct all ver4 dicts."
2014-02-28 09:37:23 +00:00
Keisuke Kuroyanagi
684f5f18b1
Merge "Added a method and run GC for testing."
2014-02-28 09:33:51 +00:00
Keisuke Kuroyanagi
d302b98ce6
Added a method and run GC for testing.
...
Bug: 13231889
Change-Id: If64b7422967c3e4107c845072b64a7bb26a35f7e
2014-02-28 18:17:09 +09:00
Ken Wakasa
98534dc065
Add missing null checks for getOwnerInstance()
...
It may just return null.
Change-Id: I778fb48262ef8af28a4af50b70bb94ace75a488c
2014-02-28 16:13:51 +09:00
Keisuke Kuroyanagi
ea89cb40b7
Use dynamic operations to construct all ver4 dicts.
...
Bug: 8187060
Bug: 13127350
Change-Id: I081ee904c41898128efa8ba7a1bf3fa0a46c6231
2014-02-27 23:21:09 +09:00
Keisuke Kuroyanagi
1aac28a2b9
Remove "Use only personalization dictionary".
...
Bug: 13216198
Change-Id: I20ce61c4a10c360e028bf6427f632cc5299763e4
2014-02-27 22:32:00 +09:00
Keisuke Kuroyanagi
e9926b0d11
Remove redundant creation of dictionary facilitator.
...
Change-Id: I2edab4e3ba4ea0b9b13f9bb224aac86cac9b9f31
2014-02-27 22:31:57 +09:00
Tadashi G. Takaoka
e989c6ea85
Merge "Remove wrong duplicated resource from Afrikaans layout"
2014-02-27 11:17:34 +00:00
Tadashi G. Takaoka
51cb8e6f4e
Remove wrong duplicated resource from Afrikaans layout
...
Bug: 6867914
Change-Id: Ibc329c8ea03abaa91ba27e7e62fb6d02cc67debe
2014-02-27 19:01:49 +09:00
Jean Chalard
d1394b6986
Merge "Fix a bug with auto-caps entries from personalization"
2014-02-27 07:38:24 +00:00
Jean Chalard
71e3ecd0a2
Fix a bug with auto-caps entries from personalization
...
Bug: 13215163
Change-Id: I00099cb4927c96de46e57e14ab906d41c9c2151a
2014-02-27 14:40:54 +09:00
Tadashi G. Takaoka
f8a45cfd2f
Fix NPE in KeyDetector
...
This is actually a follow up of I9290974821.
Bug: 13215075
Change-Id: Ib7eef55fd1cfbb05d06aeeb0726bc10c87b07d85
2014-02-27 14:17:14 +09:00
Tadashi G. Takaoka
997ba1b41e
Merge "Add keyboard layout set tests"
2014-02-27 03:08:42 +00:00
Keisuke Kuroyanagi
e1480a246d
Merge "Set additional attributes in dictionary facilitator."
2014-02-26 10:37:46 +00:00
Keisuke Kuroyanagi
f8552f61a4
Set additional attributes in dictionary facilitator.
...
Bug: 13197276
Change-Id: I206cf4e599ca9cdf40d669358a1067a2954d11e3
2014-02-26 19:14:16 +09:00
Keisuke Kuroyanagi
e55d44c535
Merge "Add a method to create dict with additional attributes."
2014-02-26 10:07:53 +00:00
Keisuke Kuroyanagi
18f91cf617
Add a method to create dict with additional attributes.
...
Bug: 13197276
Change-Id: I80311a51d9e98bfeb8c0dd9cd4adde93af366d54
2014-02-26 19:03:27 +09:00
Keisuke Kuroyanagi
009bb5642b
Merge "Use NOT_A_PROBABILITY for adding OOV words."
2014-02-26 09:48:57 +00:00
Jean Chalard
7e70e9dc49
Merge "[IL110] Remove an unused interface function"
2014-02-26 09:08:30 +00:00
Keisuke Kuroyanagi
2b27e06733
Merge "Read and write forgetting curve header attributes."
2014-02-26 09:06:56 +00:00
Keisuke Kuroyanagi
6112cc26a7
Read and write forgetting curve header attributes.
...
Bug: 13197276
Change-Id: I6c38a127e1745903594b7bf0ec80ef179e794feb
2014-02-26 18:04:12 +09:00
Keisuke Kuroyanagi
8559b403ed
Use NOT_A_PROBABILITY for adding OOV words.
...
Bug: 13197276
Change-Id: I23f453c2c1deea70eab552f8d433fe264adf68b3
2014-02-26 17:50:44 +09:00
Jean Chalard
bd1caac16a
[IL110] Remove an unused interface function
...
...and make a method private.
Bug: 8636060
Change-Id: If16f7e8ef3779f77a9db23fb7c54e7c23b043b86
2014-02-26 17:46:20 +09:00
Tadashi G. Takaoka
dd01a0bb1d
Add keyboard layout set tests
...
This CL is a ground work to add keyboard layout labels and more keys
tests.
Bug: 13017434
Change-Id: Ief028e8ab563d79bc0b0f9c06f1fe1d645a6469d
2014-02-26 16:10:52 +09:00
Jean Chalard
23e22613d7
Remove useless args and processing.
...
Bug: 13062385
Change-Id: I426545d1fe8fd76bcf4d1dce19e6b571a55c79ae
2014-02-26 11:40:43 +09:00
Jean Chalard
57c0c577af
[QRP6] Fix: recorrection top candidate is displayed in bold
...
Bug: 10385162
Change-Id: Icf9471d474a3a8ed8f38c46c7948c66f9131691e
2014-02-25 19:48:09 +09:00
Jean Chalard
0c34ee20a8
[QRP5] Fix boldness for predictions, and small refactoring
...
This is more correct. When predictions, the typed word should
always be null unless explicitly passed. The text color should be
that of a valid typed word only if it's actually the typed word.
Bug: 13170509
Change-Id: I769ae100e112c37c6f02064fe9ef2f81372ca9e5
2014-02-25 19:44:57 +09:00
Jean Chalard
783f193239
[QRP4] Simplification & small correctness fix.
...
This fixes the color of the predictions when running
on a theme that has different colors for typed and
suggested words (GB theme).
Also, this is easier to understand and to modify from
now on.
Change-Id: Ifdc6d86a1695e83e16103041b06a2451f8d52cc4
2014-02-25 08:59:14 +00:00
Jean Chalard
a0984662a1
[QRP3] Refactoring
...
Rename some variables for clarity and use constants
instead of immediates.
Change-Id: Ie07fbfcc3738ac4e67aefddc339fc54259172c39
2014-02-25 17:05:47 +09:00
Jean Chalard
74224f2c5c
[QRP2] Small refactor
...
Bug: 13170509
Change-Id: Ib9f10b8a137fc773ab0e5dc903e577038e29a9e2
2014-02-25 17:05:47 +09:00
Jean Chalard
ef3a45643e
[QRP1] Fix a bug where the wrong value would get passed
...
In the practice it works because this never tries to access
inside the suggestion strip, and the worst that can happen
is a wrong text color for a suggestion. But since the two
colors that would be swapped are the same, nobody ever
notices -- unless they are using the GingerBread theme.
Change-Id: Ic8c70d8b3cdddf92946dfefbbc6d061572626c7a
2014-02-25 17:05:44 +09:00
Tadashi G. Takaoka
deb5cedf81
Add Key.getIconId for testability
...
Bug: 13017434
Change-Id: I94ff45da3f58b74cc9dd4d38179670fbcf619d92
2014-02-25 09:59:38 +09:00
Jean Chalard
6e224a236a
Merge "Correctly read the header of APK-embedded dicts"
2014-02-24 13:57:46 +00:00
Jean Chalard
890b44e537
Correctly read the header of APK-embedded dicts
...
Bug: 13164518
Change-Id: I8768ad887af8b89ad9f29637f606c3c68629c7ca
2014-02-24 22:54:01 +09:00
Jean Chalard
64ace089a8
Merge "Use an executor to serialize opening dictionaries."
2014-02-24 13:43:49 +00:00
Tadashi G. Takaoka
2c55706b0e
Merge "Create a utils class for executors."
2014-02-24 13:33:44 +00:00
Jean Chalard
4de2fcdde3
Use an executor to serialize opening dictionaries.
...
Bug: 13082957
Change-Id: I25570ab4da94337ed60330c0869fe47657096626
2014-02-24 21:05:24 +09:00
Jean Chalard
b434acee34
Create a utils class for executors.
...
Preliminary refactoring to fix
Bug: 13082957
Change-Id: I9f1283c37089bc96140b774b1c559d58031de004
2014-02-24 20:52:49 +09:00
Tadashi G. Takaoka
c40eb52e43
Merge "Remove hack from EmojiPalettesView.startEmojiPalettes"
2014-02-24 10:49:59 +00:00
Tadashi G. Takaoka
d227b00a72
Remove hack from EmojiPalettesView.startEmojiPalettes
...
Bug: 12115967
Change-Id: I91c567a9577012ec28c08430c55e56e9c2e25b5f
2014-02-24 19:45:50 +09:00
Jean Chalard
65bce4cabc
Merge "Never pass negative values to setSelection."
2014-02-24 09:26:43 +00:00
Tadashi G. Takaoka
b08a9e021c
Merge "Revert "Prepare for changing text color for functional keys""
2014-02-24 08:54:55 +00:00
Tadashi G. Takaoka
da500b7ec3
Revert "Prepare for changing text color for functional keys"
...
This reverts commit 194e004e81
.
Bug: 10786040
Change-Id: I4c5287d46cabe287abce5cba77635cf26d2cd192
2014-02-24 17:42:28 +09:00
Jean Chalard
f19745728e
Never pass negative values to setSelection.
...
Bug: 13136079
Change-Id: Ieae6bafbd5339a033f0f342ba9af7dcc4ce209fa
2014-02-24 16:52:55 +09:00
Keisuke Kuroyanagi
2b72aa07a9
Disconnect app data search client after fetching all data.
...
Bug: 13138201
Change-Id: Ibaa3c2c22a4fe44ea23e92ce8576141bbad09b12
2014-02-24 14:47:54 +09:00
Jean Chalard
296adf5710
Merge "Change a heuristic and add a log."
2014-02-21 11:58:16 +00:00
Tadashi G. Takaoka
1269ae3144
Merge "Change make-keyboard-text -java option to point LatinIME/java directory"
2014-02-21 11:54:39 +00:00
Keisuke Kuroyanagi
bb6b978a19
Merge "Fix: file descriptor leaking."
2014-02-21 11:37:09 +00:00
Jean Chalard
bf075b21a1
Merge "Don't trim newer inputpointers with old data"
2014-02-21 11:19:04 +00:00
Tadashi G. Takaoka
5eb6ea9f27
Change make-keyboard-text -java option to point LatinIME/java directory
...
Change-Id: I812713da5918049c0e504e48bd0693df2f7bf46d
2014-02-21 19:24:24 +09:00
Keisuke Kuroyanagi
ad508d029f
Merge "Remove corrupted ver4 dictionaries."
2014-02-21 09:03:19 +00:00
Keisuke Kuroyanagi
d24a99cff6
Fix: file descriptor leaking.
...
File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.
Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
2014-02-21 17:25:34 +09:00
Jean Chalard
2a5ec00301
Don't trim newer inputpointers with old data
...
We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.
Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
2014-02-21 16:43:11 +09:00
Tadashi G. Takaoka
d73044a249
Add ImportantNoticeDialog
...
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
2014-02-21 16:36:15 +09:00
Keisuke Kuroyanagi
d934fb43ad
Remove corrupted ver4 dictionaries.
...
Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
2014-02-21 15:09:37 +09:00
Tadashi G. Takaoka
fe39d576dc
Support versioned important notice
...
This change must be checked in together with If38a754d00.
Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
2014-02-21 09:54:08 +09:00
Jean Chalard
3b4c1d3056
Change a heuristic and add a log.
...
The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.
Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.
Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
2014-02-20 23:49:20 +09:00
Jean Chalard
1b3a142cac
Merge "Fix a bug where suggestions would not be updated."
2014-02-20 14:46:35 +00:00
Jean Chalard
6f50c95887
Fix a bug where suggestions would not be updated.
...
Also fix a small cosmetic bug where the suggestion strip
would flash.
Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
2014-02-20 23:32:04 +09:00
Jean Chalard
a118d19f6c
Merge "Don't distrust the cursor pos so much as to bug on IPC delay"
2014-02-20 14:22:48 +00:00
Jean Chalard
3c84eb8822
Don't distrust the cursor pos so much as to bug on IPC delay
...
When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.
When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.
However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.
Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).
So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.
Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
2014-02-20 23:13:14 +09:00
Keisuke Kuroyanagi
d36328cecf
Add test only methods to test personalized dicts.
...
Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
2014-02-20 22:20:43 +09:00
Keisuke Kuroyanagi
485c1ec685
Merge "Add final and volatile for members of InputLogic."
2014-02-20 10:12:45 +00:00
Keisuke Kuroyanagi
afdb6f011b
Merge "Add user history dictionary decaying test."
2014-02-20 10:05:20 +00:00
Keisuke Kuroyanagi
b063377e77
Add final and volatile for members of InputLogic.
...
Bug: 13107471
Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
2014-02-20 18:55:19 +09:00
Keisuke Kuroyanagi
0bc66daae3
Add user history dictionary decaying test.
...
Bug: 10667710
Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
2014-02-20 18:36:46 +09:00
Keisuke Kuroyanagi
a514ea7e1b
Merge "Check all enabled IME's subtypes to enable personalization."
2014-02-20 09:33:21 +00:00
Keisuke Kuroyanagi
d10e2d85af
Merge "Throw IOException when dict header cannot be read."
2014-02-20 09:33:08 +00:00
Keisuke Kuroyanagi
afd9b62f00
Throw IOException when dict header cannot be read.
...
Bug: 13106638
Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
2014-02-20 18:11:17 +09:00
Jean Chalard
475f9f35b6
Merge "Comments improvements"
2014-02-20 08:22:39 +00:00
Tadashi G. Takaoka
1672ccbbb6
Change important notice version preference file
...
This CL also reset the notice version to 1.
This CL must be checked in together with Iea8d9ff038.
Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
2014-02-20 16:50:34 +09:00
Tadashi G. Takaoka
78db739cdb
Fix build due to Ib4c472756f
...
Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
2014-02-20 16:16:57 +09:00
Jean Chalard
ad2cf220a9
Merge "Remove a call to a deprecated method"
2014-02-20 06:40:46 +00:00
Tadashi G. Takaoka
251ed3b358
Merge "Revert "Turn off personalization default settings""
2014-02-20 06:26:48 +00:00
Tadashi G. Takaoka
c2ba73ab41
Revert "Turn off personalization default settings"
...
This reverts commit 0a4ac795d6
.
Bug: 10587358
Change-Id: Ib4c472756fb9a6ebba4a66d34a9652f1b5afc714
2014-02-20 06:06:29 +00:00
Keisuke Kuroyanagi
6b23749dec
Check all enabled IME's subtypes to enable personalization.
...
Bug: 13067743
Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
2014-02-20 15:05:37 +09:00
Jean Chalard
c44b7312ad
Remove a call to a deprecated method
...
...that would cause a crash
Bug: 13082186
Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
2014-02-20 14:40:38 +09:00
Jean Chalard
be8ad77ebb
Comments improvements
...
Typo fixes and clarifications
Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
2014-02-20 13:29:43 +09:00
Keisuke Kuroyanagi
34fb962513
Call PersonalizationDictionarySessionRegistrar.init().
...
Wrongly removed in I1f50cb137b6054dc9.
Bug: 13067743
Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
2014-02-19 23:27:14 +09:00
Keisuke Kuroyanagi
d102eb80da
Remove personalization dicts for multilingual users.
...
Bug: 13067743
Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
2014-02-19 21:00:27 +09:00
Tadashi G. Takaoka
920c40fe45
Use AlertDialog.setOnDismissListener
...
AlertDialog.Builder.setOnDismissListener is supported from API 17.
Bug: 10587358
Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
2014-02-19 19:05:06 +09:00
Tadashi G. Takaoka
ed616083dd
Merge "Turn personalization on when important notice dialog is displayed"
2014-02-19 09:46:15 +00:00
Tadashi G. Takaoka
6abc852255
Turn personalization on when important notice dialog is displayed
...
This change must be checked in together with Ifde70b1d3b.
Bug: 10587358
Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
2014-02-19 18:36:32 +09:00
Tadashi G. Takaoka
3a7ed5fdfe
Merge "Fix IllegalStateException raied by monkey"
2014-02-19 08:27:37 +00:00
Tadashi G. Takaoka
9fd7447d6c
Fix IllegalStateException raied by monkey
...
Bug: 13082467
Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
2014-02-19 16:40:52 +09:00
Keisuke Kuroyanagi
03105290d8
Merge "Throw exception when the header cannot be read."
2014-02-19 04:59:47 +00:00
Tadashi G. Takaoka
776bba098b
Merge "Turn off personalization default settings"
2014-02-19 04:25:04 +00:00
Keisuke Kuroyanagi
97a40d030f
Throw exception when the header cannot be read.
...
Bug: 13066902
Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
2014-02-19 12:35:58 +09:00
Keisuke Kuroyanagi
e49e007bb2
Fix: Use old suggest after reloading.
...
Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
2014-02-19 12:34:09 +09:00
Tadashi G. Takaoka
0a4ac795d6
Turn off personalization default settings
...
Because the previous personalization settings default value was on,
this CL changes the preference key of the personalization settings.
Bug: 10587358
Change-Id: I80233e8af4b532d8c67d8fb184c2865862bb35dd
2014-02-19 12:08:50 +09:00
Jean Chalard
80d413caff
Merge "Straighten out database cursors behavior."
2014-02-18 11:09:38 +00:00