Commit Graph

4195 Commits (345ef6762700cdb0fca25aa54b22ef83aaaac0ab)

Author SHA1 Message Date
satok 2ef0d3bf8d Merge "fix possible NPE in DebugSettings" 2013-01-10 03:00:24 -08:00
satok e8b4fd2644 fix possible NPE in DebugSettings
Change-Id: I44ec5bd3b2a00087603316f14d732164dbcf399f
2013-01-10 19:57:33 +09:00
Jean Chalard d9c7a6b9b3 Merge "Move a method to a utility class (C1)" 2013-01-10 00:04:11 -08:00
Jean Chalard 9c75ad1ade Merge "Fix international tests" 2013-01-10 00:03:05 -08:00
Tadashi G. Takaoka a80b8fc98f Merge "Show final suggested word when batch input is finished" 2013-01-09 23:35:09 -08:00
Tadashi G. Takaoka 50d902ac6f Show final suggested word when batch input is finished
This change moves dismiss timer of gesture floating preview text from
PreviewPlacerView to KeyboardView.

Bug: 7967461
Change-Id: I0ca5beddc93cb4bc4a405f914d217d37b997402b
2013-01-10 16:25:05 +09:00
Jean Chalard ae4c81993c Merge "Initial implementation for dead keys (B3)" 2013-01-09 23:15:49 -08:00
Jean Chalard 6a26de1d7e Initial implementation for dead keys (B3)
Bug: 5037589
Change-Id: I9e1ff92df7d0c58eb7a0f33603adebc9efb86585
2013-01-10 15:47:21 +09:00
Kurt Partridge b74a0a78c2 [Rlog57a] include logUnit boundaries in output
Change-Id: I4d1647b971b0e7a4cf1a96f341236f6ab1d2ab16
2013-01-09 22:38:27 -08:00
Tadashi G. Takaoka 433f54ce90 Merge "Remove unused variables" 2013-01-09 22:32:23 -08:00
Jean Chalard 424d76fbf5 Merge "Add a next Event (B2)" 2013-01-09 22:23:05 -08:00
Jean Chalard 912ad4614f Fix international tests
Tests have been broken again by recent changes to subtype
choice within Latin IME. This fixes the problem and all tests
pass again.

This change also includes a small fix to one test that was
checking for something irrelevant.

Change-Id: I6a03dea24f99b0d2ad84c4161a8413f3060bb811
2013-01-10 15:12:17 +09:00
Tadashi G. Takaoka a7a7f4e002 Add default button to vibration/volume settings dialog
Change-Id: I7beb4517314efdefeb47d91b14a6b02c3075c19f
2013-01-10 15:11:30 +09:00
Tadashi G. Takaoka 6512cd289d Merge "Cancel update batch input timer only when point is added" 2013-01-09 21:47:46 -08:00
Tadashi G. Takaoka b2f5d15250 Cancel update batch input timer only when point is added
Bug: 7972004
Change-Id: Ie5db5910efba851976da2284cafc69be2910d354
2013-01-10 14:31:07 +09:00
Tadashi G. Takaoka 88df3d9239 SeekBarDialog supports neutral and dismiss listener
Change-Id: I652fd1a383ef4074c04d03a37ebc779d229474e6
2013-01-10 14:24:54 +09:00
Kurt Partridge 759506ef2d Merge "[Rlog52z] Cleanup and small bug fixes" 2013-01-09 21:12:13 -08:00
Kurt Partridge 403c423940 [Rlog56] Buffer words before pushing out LogUnit
Previously, a logbuffer only held an n-gram.  Data went in and out of it, FIFO, until privacy
conditions were met (i.e. data not collected too frequently), and then an n-gram was saved.
E.g., if n=2, and only 10% of data is collected, then 18 words went through the logbuffer before
it captured the next 2 words.

However, if a user then went back and edited the n-gram, these edits were not captured.

This change changes the logbuffer size to temporarily hold data about words that are not recorded,
so that if the user backs up over them, the edits to an n-gram that we do eventually capture are
stored.  If the example above, instead of a logbuffer holding 2 words, it holds 20.  The system
waits until all the words not needed for the n-gram have been gathered (i.e. the buffer is full),
so the user has adequate time to edit, before shifting out the n-gram.  The buffer is still flushed
when the user closes the IME.  See the comment for MainLogBuffer for an explanation.

multi-project commit with I45317bc95eeb859adc1b35b24d0478f2df1a67f3

Change-Id: I4ffd95d08c6437dcf650d866ef9e24b6af512334
2013-01-09 21:09:19 -08:00
Kurt Partridge 8bda35809b [Rlog52z] Cleanup and small bug fixes
Change-Id: Ia3fca4881370ffcdd5f2b14d2d1094c51f4330ae
2013-01-09 21:07:51 -08:00
Kurt Partridge f11c4a9aeb Merge "[Rlog50] capture bigrams properly even with deletions" 2013-01-09 19:52:45 -08:00
Tadashi G. Takaoka 1aa547d94a Remove unused variables
Change-Id: I508679c2ad21b2624760d37a9503e21733964d4c
2013-01-10 12:34:35 +09:00
Tadashi G. Takaoka 95e3008d25 Merge "Rename variables related to key preview popup" 2013-01-09 19:32:33 -08:00
Tadashi G. Takaoka 6ece8f718b Merge "Remove unused variable" 2013-01-09 19:32:18 -08:00
Tadashi G. Takaoka 3727a3fd61 Merge "Clean up public helper methods of SettingsValues" 2013-01-09 19:04:46 -08:00
Tadashi G. Takaoka 813692c956 Rename variables related to key preview popup
Change-Id: I0161e5844dd325af9afba80ac54a569b16c80660
2013-01-10 11:47:18 +09:00
Tadashi G. Takaoka e0e0b04188 Remove unused variable
Change-Id: I7001d8b6200a5cefcf84630d663da8316422026f
2013-01-10 11:43:35 +09:00
Kurt Partridge 3b95eaf70b [Rlog50] capture bigrams properly even with deletions
multi-project commit with Ia4ec213e8356897807cb6a278fccdbaa945732f0

Change-Id: Ib3fe886dc889954a31586ab81d00a21d8d55efd2
2013-01-09 16:02:37 -08:00
Jean Chalard 6c75253c11 Add a next Event (B2)
Change-Id: If2fe6f0f4f88a6ae1f22664ded61cec6942c18b9
2013-01-09 22:12:13 +09:00
Jean Chalard 125ad22370 Merge "Abandon the idea of an Event pool and make Event immutable (B1)" 2013-01-09 05:07:42 -08:00
Jean Chalard 8da9c337db Move a method to a utility class (C1)
This is a preparatory change to fix bug 7969231

Change-Id: I44604ae75192a17b4e75a01f3e3d679d4901299e
2013-01-09 21:59:06 +09:00
Jean Chalard ae74b8cf67 Abandon the idea of an Event pool and make Event immutable (B1)
Change-Id: I750a07c0c564a95ceac734afa873ca3da9626a7f
2013-01-09 21:08:58 +09:00
Jean Chalard b112a13518 Merge "Fix a race condition with backspaces" 2013-01-09 01:53:47 -08:00
Jean Chalard 516b63db28 Fix a race condition with backspaces
And add a test to make sure it stays not-broken.

Bug: 7946604
Change-Id: I996da3d5507d591ec25a13fb57434f39843f1df5
2013-01-09 18:37:10 +09:00
Tadashi G. Takaoka e56686f43a Merge "Cancel update batch input timer whenever MotionEvent is received" 2013-01-09 01:12:59 -08:00
Tadashi G. Takaoka 915f348b35 Cancel update batch input timer whenever MotionEvent is received
Bug: 7911739
Change-Id: Id2cd98385371fd98435943ed66ec5381dfaa48e0
2013-01-09 17:55:42 +09:00
Tadashi G. Takaoka 8353e751ca Don't cancel gesture typing while more keys keyboard is shown
Bug: 7964225
Change-Id: I4c572527b6f399282bdd963e38c147c7e69815ac
2013-01-09 16:56:59 +09:00
Tadashi G. Takaoka d3b0ecec22 Clean up public helper methods of SettingsValues
Change-Id: I6c6087580b67f497eaaf16900f8df7a4a895b8e3
2013-01-09 11:23:34 +09:00
Tadashi G. Takaoka 8315e8168b Merge "Clean up debug related preference keys" 2013-01-08 16:56:13 -08:00
Kurt Partridge e9c6455881 [Rlog48] Better logging of MotionEvents
- Now includes all historical data stored in a motionEvent
- Simpler API, refactored to move extraction code to JsonUtils

Change-Id: I52d9756ddbeaa14d1704787da59bf1aad18f0335
2013-01-08 08:50:06 -08:00
Kurt Partridge 9bad176ebe Merge "[Rlog32] ResearchLogger segment motion data around gestures correctly" 2013-01-08 08:10:31 -08:00
Kurt Partridge b7fb16e8cc Merge "[Rlog27] Refactor LogBuffer" 2013-01-08 07:40:57 -08:00
Tadashi G. Takaoka a5ff9f0c77 Clean up debug related preference keys
Change-Id: Ib7129692c673b3bce253120ee709e0253aeafa52
2013-01-08 18:26:47 +09:00
Tadashi G. Takaoka ff0735ada8 Make Settings class singleton to manage SettingsValues
Change-Id: Id30828a141de86d9bcf8bce586d2adb468cc59e1
2013-01-08 17:48:47 +09:00
Tadashi G. Takaoka 8873b5ae31 Merge "Rename Settings to SettingsFragment" 2013-01-07 23:00:59 -08:00
Tadashi G. Takaoka 4b852d6044 Merge "Consolidate VibratorUtils with AudioAndHapticFeedbackManager" 2013-01-07 23:00:04 -08:00
Tadashi G. Takaoka cbee8a33d5 Rename Settings to SettingsFragment
Change-Id: If5bc53efc67be507663091de0f569f604c03e719
2013-01-08 15:59:16 +09:00
Tadashi G. Takaoka b17b887425 Consolidate VibratorUtils with AudioAndHapticFeedbackManager
Change-Id: Ica4e3193f369330da62a259c718b779ddf9fbde5
2013-01-08 15:13:19 +09:00
Jean Chalard c79493a15f Adjust the used frequency of the user dictionary words.
Bug: 7656666
Change-Id: I4b271af636f6103cb5287336229581365841d778
2013-01-08 14:57:20 +09:00
Kurt Partridge 99f3189645 [Rlog32] ResearchLogger segment motion data around gestures correctly
multi-project commit with I684ba5fed8c653777942e6b0366113ca40dfa37c

Change-Id: Id3804e6cfa97b4cdde212b8eebc413f76fa4772c
2013-01-07 20:06:29 -08:00
Xiaojun Bi 28de7223e6 Merge "[mdfp] Refactoring Gesture Floating Preview Text Code" 2013-01-07 17:12:35 -08:00
Xiaojun Bi d52730a2d7 [mdfp] Refactoring Gesture Floating Preview Text Code
This change moves gesture preview text code from PreviewPlacerView.java
to separate classes.

Change-Id: Id8d17eff38e714c3b06aafd0b24985a9bd2d2f52
2013-01-07 10:39:23 -08:00
Tadashi G. Takaoka f90fc105ab Simplify singleton class initialization
Change-Id: I16a27f2ed6ea66184bfdc9903180372cd7ea2fd1
2013-01-07 19:05:31 +09:00
Ken Wakasa b6ca354431 Small code cleanups
Multi-project commit with I249d5fbe

Change-Id: Ia28c4e970992aa1299a30e604eaa5d096655c3a5
2013-01-07 12:13:42 +09:00
Jean Chalard f677681330 Fix double input of chars typed on a h/w keyboard
Bug: 7939324
Change-Id: I11b7af54893cb645f8a06266a0b0ba95dd0b02f9
2013-01-07 10:03:20 +09:00
Kurt Partridge f77dd424b0 [Rlog27] Refactor LogBuffer
Cleanup and prepare for replaying

Change-Id: Ie09e912c6e9c0d7375168c575ccf1cfd9375dd31
2013-01-03 16:36:32 -08:00
Tadashi G. Takaoka fa7f08b373 Set default audio and haptic feedback settings
- Default keypress volume is set to 0.2f in resource.
- Default keypress vibration duration is set to 10 msec in resource.

Bug: 7055329
Change-Id: I83bd6288d171d9787d52e2b02e4e5305f1435681
2012-12-28 19:24:32 +09:00
Tadashi G. Takaoka a2982dd5a7 Refactor to add SeekBarDialog
Change-Id: Id8e08a1d5ec5efb2baf96a2634111619fcb9fd4e
2012-12-28 15:49:36 +09:00
Jean Chalard 864db4b0da A small simplification.
It's useless to setAutoCorrection(getTypedWord()). Every time the
contents of the word composer are altered, the auto-correction is
reset, and at use time if it's null then the typed word is used
anyway.

Change-Id: I0870657a1ab3f456f376995b27e70703f7a5d23a
2012-12-28 14:41:28 +09:00
Jean Chalard 997cba7dec Start committing hardware events (B4)
Essentially this does activate auto-correction with a hardware
keyboard, although a lot of things are still left to implement.
No proximity is used yet which means only missing and excessive
letters are considered. Dead keys are not handled. No combiner
is supported. No suggestions are displayed. Resuming suggestions
does not work correctly with a hardware key (because the view
holds a temporary hardware event 'onKeyPreIme' and the event
from the IME won't be handled until this is handled which won't
happen until after the IME said that it did handle the event).

Bug: 5037589
Change-Id: Idcb5c7b26d56717ed772d53c062362807f11cdae
2012-12-27 16:17:49 +09:00
Jean Chalard 581f324ed8 Initial implementation for decoding HW key events (B3)
Bug: 5037589
Change-Id: I829f70a258de58ef8d2b836a9b435198a226e37f
2012-12-27 16:17:46 +09:00
Jean Chalard 0abc48218e Rename some confusing variables
Change-Id: Ib0de800599ae7f12c86270a627616d5b52366414
2012-12-27 15:42:14 +09:00
Jean Chalard 5bde3a6163 Fix an old bug in getting a word from the connected view.
In this test, it's impossible that start < 0 so the test is useless.
I'm not sure what the cursor test was for, but it's very old code, and
it seems the assumption was either misled or doesn't hold any more:
testing for the absolute cursor position against the length of the
word against the cursor makes no sense.

The net result of this was that when the cursor index got large
enough, resuming suggestion would not work any more.

Bug: 7586467
Change-Id: I3462082374fe9579bec7698f4d424de6ff5f2ded
2012-12-27 15:41:10 +09:00
Tadashi G. Takaoka 0856ceef9a Merge "Get rid of current subtype and system locale cache from SubtypeSwitcher" 2012-12-26 19:21:36 -08:00
Tadashi G. Takaoka 1dbec26f8f Merge "Fix gesture trail width calculation" 2012-12-26 19:01:31 -08:00
Tadashi G. Takaoka f483225397 Get rid of current subtype and system locale cache from SubtypeSwitcher
Bug: 7675452
Change-Id: I2121f56964b6d25e8d40f5b8ec67eeae527b2117
2012-12-27 12:00:38 +09:00
Tadashi G. Takaoka 92aee35222 Fix gesture trail width calculation
Change-Id: I41e0a95437aa9b8ec9a8eefb3bc5eb0452284b60
2012-12-27 11:43:35 +09:00
Jean Chalard 5112b59db2 Add support for multiple keyboard event decoders (B2)
Bug: 5037589
Change-Id: I0a4926f94ef8d1caa17669801608608648b697b9
2012-12-26 20:25:05 +09:00
Kurt Partridge 4aff3bf0ea Clean up unnecessary uses of toString()
Leftover from changing variables from CharSequence to String

Change-Id: I4db43fcb075aa37bf9c5b2a23bad0e4c2d718379
2012-12-23 18:42:06 -08:00
Kurt Partridge f763dc5915 [Rlog24] ResearchLogger detect word boundaries in callers above commitText
multi project commit with I5847d4aba97a7224ae170a7153811c5a11816449

Change-Id: Ie6fbf6f19f0193451fe6f3ddf9d4ef1637a35db1
2012-12-23 12:33:16 -08:00
Kurt Partridge 13b1be988d Merge "Log LatinIME.commitCurrentAutoCorrection()" 2012-12-23 11:47:47 -08:00
Kurt Partridge c1b4d14394 Merge "Differentiate LOG_EVERYTHING and LOG_FULL_TEXTVIEW_CONTENTS" 2012-12-23 11:20:34 -08:00
Kurt Partridge 5e9a5ca998 Merge "[Rlog36z] Pass LatinIME instance to logger as LatinIME class" 2012-12-23 10:37:31 -08:00
Kurt Partridge dce58fe895 Merge "[Rlog24z] Initialize statistics variables" 2012-12-23 09:51:22 -08:00
Kurt Partridge a51fbd92a5 Merge "[Rlog20] Remove duplicate logStatistics" 2012-12-23 09:05:00 -08:00
Kurt Partridge 99bd42b295 [Rlog24z] Initialize statistics variables
Change-Id: I73a6009294a4f559a93b6ea9ceb4ea2683d97486
2012-12-23 09:04:01 -08:00
Kurt Partridge f0d626ecfc Merge "[Rlog19] ResearchLog remove unnecessary logSegment{start,end}" 2012-12-23 08:28:53 -08:00
Kurt Partridge 9e12ba6c95 Merge "[Rlog22] ResearchLogger fixed debug printing" 2012-12-22 18:02:25 -08:00
Kurt Partridge 226377e65a Log LatinIME.commitCurrentAutoCorrection()
Change-Id: Ic46c91374ae0177cafad4579d28d6980af0d8d3a
2012-12-22 17:32:12 -08:00
Kurt Partridge fc6e0cce6f [Rlog19] ResearchLog remove unnecessary logSegment{start,end}
Change-Id: I73b7765c764e5f1035f1c37df45345f26aa5acb1
2012-12-22 17:22:43 -08:00
Kurt Partridge 583a1edc4a [Rlog22] ResearchLogger fixed debug printing
Change-Id: I2c59983236c936b8698004db8213b68c2f964cd5
2012-12-22 17:16:51 -08:00
Kurt Partridge 18b01e88ac Merge "[Rlog41] ResearchLogger debugging support in UploaderService" 2012-12-22 17:12:39 -08:00
Kurt Partridge 5dd5dd2911 [Rlog36z] Pass LatinIME instance to logger as LatinIME class
Upcoming changes require LatinIME class, not just InputMethodService

Change-Id: Ia5b3a716ac02a99749fb2ba0164ba46c8a0c559a
2012-12-22 14:20:39 -08:00
Kurt Partridge 68fc33bd92 Differentiate LOG_EVERYTHING and LOG_FULL_TEXTVIEW_CONTENTS
Previously, LOG_EVERYTHING logged both all bigrams and also the entire TextView at the end of a
session.  Now, use a separate flag, LOG_FULL_TEXTVIEW_CONTENTS to determine whether the TextView
contents are recorded.

Change-Id: I0c7a90a8ff88aa65d057f3b2d3dd5adc3893504a
2012-12-22 13:57:58 -08:00
Kurt Partridge 522d739524 [Rlog20] Remove duplicate logStatistics
Change-Id: I31c5520598269a83ab218e3a024bff0a625c2770
2012-12-22 13:38:28 -08:00
Kurt Partridge ab5d2b45b9 [Rlog41] ResearchLogger debugging support in UploaderService
Change-Id: I70d5bd0cb12be7a5cc216799f92622912646466f
2012-12-22 13:07:46 -08:00
Kurt Partridge 163699e240 Merge "[Rlog12] Add comments to logging callpoints" 2012-12-22 12:59:15 -08:00
Kurt Partridge ab9f4fd359 Merge "[Rlog7] ResearchLog improve gesture tracking" 2012-12-22 11:50:46 -08:00
Kurt Partridge c322c3c3c7 [Rlog12] Add comments to logging callpoints
Change-Id: Idd786e2804dc82c1fa27ecf0fc0537491438d017
2012-12-21 12:34:39 -08:00
Kurt Partridge f1ce54891f [Rlog7] ResearchLog improve gesture tracking
- count how many times a gesture is deleted
- count num chars entered by gesture
- change name of fns to reflect capturing gesture information when setting composing text

Change-Id: I1b8ebf9cfcf304e0efd827c8b8e28a4010199728
2012-12-21 12:33:54 -08:00
Kurt Partridge 5a7ac3bf2a Merge "[Rlog6.2] ResearchLogging Refactor" 2012-12-21 11:43:18 -08:00
Kurt Partridge 58281a98eb [Rlog6.2] ResearchLogging Refactor
Move specifics of Log output format from ResearchLog to LogUnit

Change-Id: I9d0253c50bb8175ab141bd87dd9a09f39f316b10
2012-12-21 11:36:28 -08:00
Tadashi G. Takaoka 7c1e853387 Call onCancelBatchInput only when onStartBatchInput has been called
This NPE issue (Bug: 7903331) has been introduced by Ie68c7698.

Bug: 7903331
Change-Id: I44884f5608fe47d9db7a2c93a752d17b9ae39a22
2012-12-21 14:31:03 +09:00
Kurt Partridge 11bc86adcb Merge "[Rlog13] Add flag to inhibit uploading" 2012-12-20 13:13:21 -08:00
Kurt Partridge 4c2b6923c3 Merge "[Rlog11] ResearchLogger printable code for research key" 2012-12-20 11:40:18 -08:00
Kurt Partridge a98dabf106 Merge "[Rlog10] ResearchLogger change visible indicator to just lines on the side" 2012-12-20 10:43:11 -08:00
Kurt Partridge 0214f70e0c Merge "[Rlog8] Show red border if logging everything" 2012-12-20 09:53:32 -08:00
Kurt Partridge 5a50d574e4 [Rlog13] Add flag to inhibit uploading
Change-Id: I9d22dfb3fbc8332000507c8b97d9072bdd8dda91
2012-12-19 18:32:28 -08:00
Kurt Partridge c572c20cd8 [Rlog8] Show red border if logging everything
Change-Id: I5a3f21cef7d93128661b11b60eac7d84b8110e47
2012-12-19 18:26:07 -08:00
Kurt Partridge ff9e30f5a3 [Rlog10] ResearchLogger change visible indicator to just lines on the side
(Note: Rlog9 was abandoned).

Change-Id: I69de4116e33d3c79216e25efe2ad2bcb2780b0ff
2012-12-19 18:20:03 -08:00
Kurt Partridge af34813127 [Rlog11] ResearchLogger printable code for research key
Change-Id: Ifac7a801ea8534191a9258871d3d7f91e942788b
2012-12-19 18:15:41 -08:00