541b994512
Merge "Import translations. DO NOT MERGE" into jb-mr1-dev
2012-10-01 10:32:20 -07:00
7f438aa12f
Make writeCharGroup return a size of a new group.
...
bug: 6669677
Change-Id: I56f6a07b04b08443f2c052927404318c2018fc9d
2012-10-01 22:02:04 +09:00
00e1d421c2
Merge "Add writeCharGroup."
2012-10-01 05:53:24 -07:00
fb7e08ea8f
Add writeCharGroup.
...
bug: 6669677
Change-Id: I36792ba9c511a5148c963096cc93ca8c2e0ee04e
2012-10-01 21:50:38 +09:00
574b80aace
Remove debug prints.
...
Bug: 7226098
Change-Id: Ibacb740022a6af56c9d555d6797dd402a89f6ca4
2012-10-01 17:03:15 +09:00
fb7b9ded1f
Merge "Add '+' sign to more keys of '-' key"
2012-09-30 23:23:45 -07:00
7e3779e37a
Add '+' sign to more keys of '-' key
...
Note that the tablet number/phone layout has its own '+' key.
Bug: 7255318
Change-Id: I5cc0431cf772a859eb456e9c36b07bfd0cc1278d
2012-10-01 14:55:55 +09:00
7339a62a13
Fix NPE observed only by monkey test
...
Bug: 7258660
Change-Id: I286c704b32efeada8505d953438f2595166f7e8f
2012-10-01 14:55:18 +09:00
8aef47d9b1
Import translations. DO NOT MERGE
...
Change-Id: I44aae7ccdfe1b4494ba70b80276c92e78fef9a6f
Auto-generated-cl: translation import
2012-09-28 13:19:23 -07:00
1c2853f8f6
Import translations. DO NOT MERGE
...
Change-Id: I4ae7e56a20803cc9c3d5ba2d85db1ea63c943303
Auto-generated-cl: translation import
2012-09-28 13:15:05 -07:00
99501896f5
am 9925e487: am 6052a81e: Merge "Fix gesture detection algorithm" into jb-mr1-dev
...
* commit '9925e487b345e4a63d3dc25e3bf156e0fbfbb04d':
Fix gesture detection algorithm
2012-09-28 06:54:04 -07:00
6052a81e08
Merge "Fix gesture detection algorithm" into jb-mr1-dev
2012-09-28 06:49:24 -07:00
58fe5a421f
Fix gesture detection algorithm
...
This change also
* Introduces adaptive gesture detecting threshold for time domain in addition to length domain.
* Tunes the parameters for detecting gesture after fast typing.
* Fixes a bug in dismissing gesture floating preview text.
* Cleanup debug messages
Bug: 7218902
Change-Id: Iafccd872c6efe0c3b5ae65fa40b04c80d9f139c7
2012-09-28 22:47:55 +09:00
11dbf025c6
am 2626bf08: am c8f25294: Merge "Temporarily suppress key popup preview after gesture input" into jb-mr1-dev
...
* commit '2626bf0889af798e484824737e9973ffb447498f':
Temporarily suppress key popup preview after gesture input
2012-09-28 03:42:38 -07:00
c8f252940f
Merge "Temporarily suppress key popup preview after gesture input" into jb-mr1-dev
2012-09-28 03:38:20 -07:00
b88c8ac8e4
Merge "Add updateChildrenAddress."
2012-09-28 03:18:18 -07:00
29d2d48182
Temporarily suppress key popup preview after gesture input
...
Bug: 7244317
Change-Id: I39cdb0fbda51f3e4339301d9cc53403b1ad15409
2012-09-28 19:10:56 +09:00
f3aed3ea26
Add updateChildrenAddress.
...
Change-Id: Ic06a755d85612476e719e580469dc1cd9447286c
2012-09-28 18:45:56 +09:00
ad6b493c16
Merge "Remove dead code for disabling gesture input after fast typing" into jb-mr1-dev
2012-09-28 00:47:05 -07:00
acaf2bedc1
am e7ad9084: am 7a7d117a: Ignore the broken file.
...
* commit 'e7ad90840786566a2f36b4aa35893bf76449b2ce':
Ignore the broken file.
2012-09-28 00:37:48 -07:00
f9bdb738bd
Import translations. DO NOT MERGE
...
Change-Id: I37ccfcc9a3ccbda4729802b533cc44e3edeebd79
Auto-generated-cl: translation import
2012-09-28 00:17:28 -07:00
bf538ab2c0
Remove dead code for disabling gesture input after fast typing
...
Bug: 7218902
Change-Id: Iccc1d4cf0dd3ac84b30c68e11eee9a6ad89f14c4
2012-09-28 16:15:51 +09:00
587ab41709
Merge "Import translations. DO NOT MERGE" into jb-mr1-dev
2012-09-28 00:14:53 -07:00
cf85160dee
Import translations. DO NOT MERGE
...
Change-Id: I3748ecaecef1f07e1537831eb0f7c5503a460b56
Auto-generated-cl: translation import
2012-09-28 00:14:00 -07:00
7a7d117aa7
Ignore the broken file.
...
bug: 7249561
Change-Id: If001bf75ef12b4d342a77e54706c7fed90c89afb
2012-09-28 14:19:14 +09:00
4cba185195
Merge "Import translations. DO NOT MERGE"
2012-09-27 10:05:58 -07:00
a36c595353
Merge "Import translations. DO NOT MERGE" into jb-mr1-dev
2012-09-27 10:03:23 -07:00
a28a05e971
Cleanup: Make some classes as final
...
Change-Id: I6009b3c1950ba32b7f1e205a3db2307fe0cd688e
2012-09-27 19:03:30 +09:00
1775201671
Calculate default touch position correction data for keys on 4th row
...
This change also disables touch position correction for Phone/Dvorak
keyboard.
Bug: 7243101
Change-Id: Idfcc7ad1feabbe6a81635dceba5be087401fa18b
2012-09-27 17:55:58 +09:00
84d858ed5e
Use BinaryDictInputOutput to save UserHistoryDictionary.
...
bug: 6669677
Change-Id: I08193c26f76dbd48168f8ac02c1b737525bfc7b2
2012-09-27 12:02:17 +09:00
d7d43d586f
Import translations. DO NOT MERGE
...
Change-Id: Icd0176aec15c7c1baf023737ddec4d39857d695f
Auto-generated-cl: translation import
2012-09-26 19:34:00 -07:00
855c0097cd
Import translations. DO NOT MERGE
...
Change-Id: Ia971fee8c85d6726840317326d07fd2d9f93b33f
Auto-generated-cl: translation import
2012-09-26 19:30:19 -07:00
c0a1dc0e07
Merge "Draw gesture trail that is above the keyboard" into jb-mr1-dev
2012-09-26 05:01:18 -07:00
157fe98fd4
Draw gesture trail that is above the keyboard
...
Bug: 7233992
Change-Id: Ia848543a9d008c68d6ecbc7f715aa6ccdba9d1c6
2012-09-26 20:43:13 +09:00
2aea34fb31
Add updateParentAddress.
...
bug: 6669677
Change-Id: I353f8ae53720cdf7a809271a28cb703709609f53
2012-09-26 17:18:01 +09:00
2ee70804e9
Add moved char groups.
...
bug: 6669677
Change-Id: I372f841044fe8e076a50a80ac10b715e5f8fd4eb
2012-09-26 17:01:48 +09:00
002a502c84
Merge "Update keyboard settings wording" into jb-mr1-dev
2012-09-25 22:56:49 -07:00
1c820c4146
Merge "Don't cancel gesture trail update drawing" into jb-mr1-dev
2012-09-25 22:50:50 -07:00
1354910f7a
Merge "Postpone gesture start detection on non-letter key" into jb-mr1-dev
2012-09-25 22:49:36 -07:00
1645902cce
Postpone gesture start detection on non-letter key
...
Bug: 7108223
Change-Id: Ie1ead5cec947ddf86c5150dca5b20b224527e511
2012-09-26 12:46:55 +09:00
936371e64f
Don't cancel gesture trail update drawing
...
Bug: 7216955
Change-Id: Ie12bf45637b1012c9addb47279f9653334fae702
2012-09-26 12:25:24 +09:00
9458e71c0c
Update keyboard settings wording
...
Bug: 7129441
Change-Id: I1130b322126ad7c400845c1257a785ccbc7dff81
2012-09-26 11:09:15 +09:00
270c0dec94
Import translations. DO NOT MERGE
...
Change-Id: I6047254f069176a832fd7919d8c6257008698740
Auto-generated-cl: translation import
2012-09-25 16:53:14 -07:00
a161bdac88
add capacity to FusionDictionaryBufferInterface.
...
bug: 6669677
Change-Id: I4627093811a19c46ce13fe351d1db63cbd78cf4a
2012-09-25 21:47:11 +09:00
35ffb90629
Merge "Make getTerminalPosition read linked-list nodes." into jb-mr1-dev
2012-09-25 05:39:24 -07:00
93d7c6233f
Make getTerminalPosition read linked-list nodes.
...
bug: 6669677
Change-Id: I599d276f430efe23d402695c325e23906b7705b3
2012-09-25 21:11:15 +09:00
630d9c95e5
Introduce typing aware gesture detection
...
Bug: 7218902
Change-Id: I11ad85914bf991eca513e04ed8b5d12779101dda
2012-09-25 20:11:05 +09:00
10d76cdcd6
Merge "Fix touch position correction data passing" into jb-mr1-dev
2012-09-24 22:26:48 -07:00
6ca50d9920
Fix touch position correction data passing
...
Bug: 7225811
Change-Id: I3dcc0385ed633585d6810fdb742e0f88c2efbbd2
2012-09-25 14:24:15 +09:00
8ec0064c49
Make children addresses and parent addresses use signed addresses.
...
Signed addresses are used only in version 3 with dynamic update.
bug: 6669677
Change-Id: Iadaeab199b5019d2330b4573c24da74d64f0945e
2012-09-25 12:55:14 +09:00
0d4d109621
Import translations. DO NOT MERGE
...
Change-Id: I1e46157047699a32560c484d0d3a4da0403b666f
Auto-generated-cl: translation import
2012-09-24 16:00:36 -07:00
0eef4b1e6f
Merge "Add suggestion span upon starting a gesture." into jb-mr1-dev
2012-09-24 04:30:32 -07:00
6a58bb7ac9
Add suggestion span upon starting a gesture.
...
Bug: 7196761
Change-Id: If60cb809b205159ced1887f94b7caf9775fcf3bb
2012-09-24 20:25:46 +09:00
88985bfa2e
Merge "Fix a bug where the cursor pos wouldn't be tracked correctly" into jb-mr1-dev
2012-09-24 03:41:48 -07:00
72c5d32888
Fix a bug where the cursor pos wouldn't be tracked correctly
...
This would cause
Bug: 7208199
Change-Id: I8474985bfe349e1530b27bc98842937627bbe4e0
2012-09-24 19:33:42 +09:00
d3fabe7fa5
Merge "Set punctuation suggestions at start if activated" into jb-mr1-dev
2012-09-24 01:30:38 -07:00
6efe788494
Set punctuation suggestions at start if activated
...
Bug: 7218468
Change-Id: I9f8c1f13dc26cedb95b65279a34a825021dfa72a
2012-09-24 17:27:03 +09:00
b760591040
Merge "Second finger can start gesture input" into jb-mr1-dev
2012-09-24 00:12:53 -07:00
65ef26081b
Merge "Fix a race condition with shift" into jb-mr1-dev
2012-09-23 23:48:20 -07:00
b305e6775a
Second finger can start gesture input
...
Bug: 7108075
Change-Id: I17c419086a86c0bdac7a3858f8c66f6893678e67
2012-09-24 15:31:51 +09:00
fff8613df0
Fix a race condition with shift
...
Bug: 7062092
Change-Id: Ie1984673e9ffc9291d9650ec38ce99031ad93585
2012-09-24 15:07:52 +09:00
1e974deaa6
Merge "Disable gesture input while fast typing" into jb-mr1-dev
2012-09-23 21:19:55 -07:00
5274a4a630
Merge "Combine mHasParentAddress with mHasLinkedListNode into mSupportsDynamicUpdate." into jb-mr1-dev
2012-09-23 21:19:30 -07:00
82d9deaaf2
Combine mHasParentAddress with mHasLinkedListNode into mSupportsDynamicUpdate.
...
bug: 6669677
Change-Id: I82799af199358420f09ac34fc005091e202c5d3b
2012-09-24 13:17:44 +09:00
9f09c6fbc8
Disable gesture input while fast typing
...
Bug: 7032858
Change-Id: I0f9f92c712dbe45f4ba0b3cf331fbe11426c1db4
2012-09-24 13:14:47 +09:00
24da43c93a
Merge "Use all Lexiteria sources and update existing directories." into jb-mr1-dev
2012-09-23 20:18:56 -07:00
8acb881a50
Add subtypeId to nl_BE
...
Bug: 6809603
Change-Id: I8010564cfdfeef5a0c4f7542b9451202ed966a53
2012-09-24 10:47:28 +09:00
08d7f2f95a
resolved conflicts for merge of b1fbd696 to jb-mr1-dev bug:6809603
...
Change-Id: I23dcf45892d94db88f424a4ee0ae440a2c743d9b
2012-09-22 01:50:33 +09:00
c613f1e7ab
Merge "Import translations. DO NOT MERGE" into jb-mr1-dev
2012-09-21 09:11:49 -07:00
d0cf96493c
Use all Lexiteria sources and update existing directories.
...
New dictionaries :
- Danish
- Greek
- Finnish
- Lithuanian
- Latvian
- Dutch
- Polish
- Russian
- Slovene
- Serbian
- Swedish
- Turkish
Also, compress those files to reduce the footprint in the
repository.
Also, update and improve English and French dictionaries, and
add the ligatures shortcut into the French dictionary.
Finally, move the Russian binary dictionary here now that it
can at last be open sourced.
Bug: 5587752
Bug: 6775251
Bug: 6995793
Bug: 7149666
Change-Id: Iec9831d4dce425a2b5b0657571e4448436610525
2012-09-21 22:07:23 +09:00
3088e0c9e9
Merge "Fix gesture start detection algorithm" into jb-mr1-dev
2012-09-21 01:51:57 -07:00
02a67200fc
Fix gesture start detection algorithm
...
Bug: 7032858
Change-Id: I9f4d939fa87fdead4c5a5921338a16cd0a59b7ac
2012-09-21 17:30:00 +09:00
8ae8c76149
Cleanup settings
...
bug: 7200189
Change-Id: Ibfd9254670cde5f4b2b693cc9334ee2845bede59
2012-09-21 15:10:27 +09:00
b1fbd696de
am 4a80d413: am ca8af4ee: Merge "nl-rBE keyboard layout"
...
* commit '4a80d4132de2b228e8c9a12095dc9fed844ec277':
nl-rBE keyboard layout
2012-09-20 21:45:54 -07:00
4a80d4132d
am ca8af4ee: Merge "nl-rBE keyboard layout"
...
* commit 'ca8af4ee5f1e8ad15522e0e95c54ea1e2a56746e':
nl-rBE keyboard layout
2012-09-20 21:43:20 -07:00
66597f5e5f
Add deleteWord.
...
bug: 6669677
Change-Id: I1a5b90ee05e5cffd74a5c140384a3e37c79e7e70
2012-09-21 12:40:07 +09:00
546133deda
Import translations. DO NOT MERGE
...
Change-Id: Ifdd37dae4c4cbe095ed00288a7e3f95303318bdc
Auto-generated-cl: translation import
2012-09-20 18:17:39 -07:00
73779f7631
Make readUnigramsAndBigramsBinary read linked-list nodes.
...
Change-Id: I07ae036b0b06e71d7a18f2bf11e4692cd4213568
2012-09-20 20:37:02 +09:00
54717534b1
Merge "Add getTerminalPosition." into jb-mr1-dev
2012-09-20 04:32:42 -07:00
81d2e93772
Merge "Fix stuck gesture floatin preview text" into jb-mr1-dev
2012-09-20 03:47:46 -07:00
61dcaaf17e
Use device independent parameter for gesture
...
Change-Id: Iea95992e4482108a498f14ec595f3eacc7d7fc4b
2012-09-20 19:38:29 +09:00
77bcd6be33
Fix stuck gesture floatin preview text
...
Bug: 7192483
Change-Id: Ic62253180446a625330966a114a6fabf74ab4ec8
2012-09-20 18:46:23 +09:00
d36245fad2
Add getTerminalPosition.
...
Change-Id: If04d779db23b1aea2cc12e5e9b8cecfcb35a5737
2012-09-20 18:02:16 +09:00
84c1bbd76d
Merge "Move PointerTracker.MIN_GESTURE_RECOGNITION_TIME to GestureStroke" into jb-mr1-dev
2012-09-20 00:23:50 -07:00
49d080f088
Merge "Auto correct on gesture when typed word is 1 char long" into jb-mr1-dev
2012-09-20 00:17:19 -07:00
b4e74cfc87
Auto correct on gesture when typed word is 1 char long
...
Bug: 7178462
Change-Id: I779d8ee4a957a9d1fdcc80d33257a98965dec7b8
2012-09-20 16:14:16 +09:00
f80f09c7ee
Move PointerTracker.MIN_GESTURE_RECOGNITION_TIME to GestureStroke
...
Change-Id: Ib50192ed8f611fd8288ff9b7a1e0a19249cc6348
2012-09-20 15:14:25 +09:00
f5becbcd75
am f1e13f1f: DO NOT MERGE: Clear cache of the user dictionary when a word is added
...
* commit 'f1e13f1fb10db4152b2617093d827c66615ee16d':
DO NOT MERGE: Clear cache of the user dictionary when a word is added
2012-09-19 20:50:20 -07:00
a0ac9cc447
Merge "Use normal font for Hindi keyboard" into jb-mr1-dev
2012-09-19 20:44:35 -07:00
f1e13f1fb1
DO NOT MERGE: Clear cache of the user dictionary when a word is added
...
This is a backport of Iec2793de3fff7bf15f68f
Change-Id: If16d1c48edf084d892da722fb288e467f211b08e
2012-09-20 12:27:14 +09:00
bfcd2b3fc0
Merge "Change to "Show language switch key" option" into jb-mr1-dev
2012-09-19 19:56:59 -07:00
cce6f9ee1d
Use normal font for Hindi keyboard
...
Bug: 6753168
Change-Id: I731a56bce70e1881e176392acfe977de28696063
2012-09-20 11:56:20 +09:00
1a4aa7e307
Change to "Show language switch key" option
...
This change deprecates "Suppress language switch key".
Bug: 7037410
Change-Id: I1bc90877b4d2ee9364728959fd680dcb5b22ecbf
2012-09-20 11:33:40 +09:00
f1ee564897
Smaller gesture preview trail
...
Bug: 7195987
Change-Id: Ibcd4b7a00b4e89070c4dfad88bb39ac1f7e4bd9a
2012-09-20 10:47:54 +09:00
331a5e7d66
mako: adjust default keybpress vibration
...
Bug 7049944
mako's vibrator has been recalibrated so reduce this to 5.
Change-Id: Ia53df175f5389e5fd1dc198e4877c4a4e7301559
2012-09-19 14:40:30 -07:00
01a5a7d061
Merge "Clear cache of user dic" into jb-mr1-dev
2012-09-19 04:15:19 -07:00
17f7b406aa
Clear cache of user dic
...
Change-Id: Iec2793de3fff7bf15f68f82a50331de7742b7049
2012-09-19 20:11:45 +09:00
c7dc673cf0
Use Path to draw gesture preview trail
...
This change also reduces the number of points to use as preview trail.
Bug: 7167303
Change-Id: I0cf4908efa44b17b42d4fddd6725238236ac2654
2012-09-19 19:29:06 +09:00
567204a140
Merge "Show gesture floating preview text is off by default" into jb-mr1-dev
2012-09-19 03:00:40 -07:00
4f8e451d0c
Show gesture floating preview text is off by default
...
Bug: 7043127
Change-Id: Icabf080f43a5934fef3824919bb03229522d5e5a
2012-09-19 18:59:10 +09:00
caf15c3c67
Merge "Fix a bug that would persist caps lock state" into jb-mr1-dev
2012-09-19 02:30:49 -07:00
8eb2065289
Merge "Log for geometric input" into jb-mr1-dev
2012-09-19 02:22:03 -07:00
ad0642cf25
Fix a bug that would persist caps lock state
...
...with regards to suggestions. It's much simpler to look at
whether the word is actually all capitalized or not.
Bug: 7113544
Change-Id: Idc0e77b2f812964e650ade0e32b9d4c09228cb74
2012-09-19 17:54:35 +09:00
87cecf7db6
Log for geometric input
...
Change-Id: Ia0f0e38086b0be70cf2d04fc6fae48358f16e74f
2012-09-19 17:45:27 +09:00
a8dc30e6d7
Merge "Remove hack algorithm from GestureStroke" into jb-mr1-dev
2012-09-19 00:33:17 -07:00
f501e4dbd2
Remove hack algorithm from GestureStroke
...
Change-Id: Idd1c150677b989415e6fee4f543ff7639e98bed8
2012-09-19 16:13:08 +09:00
65feee12e5
Make BinaryDictIOUtils.
...
Change-Id: I45830235ee738233e8eb2bd91d659705b698f58c
2012-09-19 15:37:37 +09:00
c2fdf0dfbf
Make readNode read linked list nodes.
...
Change-Id: Ia5eaae0653179b2eb74c53b0823beaf80377a389
2012-09-19 14:49:23 +09:00
8336d33a6c
nl-rBE keyboard layout
...
Add keyboardstyle for the Dutch part of Belium and make it AZERTY (the french keyboard).
This is the default layout in Belguim but in the Netherlands (nl) they use QUERTY.
Strings and spelling checker are the same.
Change-Id: Icb2b2712e6580c0e642d5f0f70f8950449d3bfd4
Signed-off-by: Sam Segers <sam.sgrs@gmail.com>
2012-09-19 06:19:11 +02:00
a149c53c8e
add limit to FusionDictionaryBufferInterface.
...
Change-Id: Ic9ff717a9751023d47b02ff3b9d1fbf3115c2501
2012-09-19 12:28:19 +09:00
a0ebb28d15
Merge "Fix a bug with capitalizations (A15)" into jb-mr1-dev
2012-09-18 20:02:05 -07:00
3bf113f0ea
Merge "Mark 2 resolved TODOS as such (A14)" into jb-mr1-dev
2012-09-18 20:01:31 -07:00
c9923430ed
Merge "Support the gesture + phantom space case (A13)" into jb-mr1-dev
2012-09-18 18:36:13 -07:00
b686df15fc
Add a new flag for linked list nodes.
...
Change-Id: Ib2f194775cfe5ab05481ac95cd709d6e8e8dd3c6
2012-09-18 22:01:49 +09:00
bf45dc4860
Make writePlacedNode write the linked-list node.
...
Change-Id: I60feda815ea08cf73300fccca1ae12b97550f116
2012-09-18 21:20:07 +09:00
061d225fb1
Add a new option to FormatOptions.
...
Change-Id: I8bf089bea5de46570a5e81fb1ea3ab22c07eeee1
2012-09-18 21:03:13 +09:00
e55785e682
New flag for the internal settings
...
Change-Id: I81e69a6cda833a0d2c59a73388321ed11e0bd5b3
2012-09-18 20:33:43 +09:00
2040090b46
Merge "Log touch timing" into jb-mr1-dev
2012-09-18 04:32:52 -07:00
f8b35b9b04
Log touch timing
...
Change-Id: I45ce16c3194fac6da98486a986d23318347cad3a
2012-09-18 19:26:25 +09:00
75b3f81fe1
Fix a bug with capitalizations (A15)
...
When only one character has been typed, we should not take that
as a strong symbol that everything should be upper-cased.
Change-Id: I4e3a3223269e6763e3594baeaa844daa79a624ed
2012-09-18 18:52:05 +09:00
e4783f95b2
Mark 2 resolved TODOS as such (A14)
...
Change-Id: Ifbb731f5c825675436d079db4ffbae657d71f8da
2012-09-18 18:49:17 +09:00
d461bfd660
Support the gesture + phantom space case (A13)
...
Bug: 6950087
Change-Id: I198699f6e687ac74c35b9edfe469dce880d9ecaf
2012-09-18 18:48:49 +09:00
717d4938b5
Merge "Remove useless code (A12)" into jb-mr1-dev
2012-09-18 02:42:36 -07:00
ed47131612
Merge "Fix a bug with surrogate characters" into jb-mr1-dev
2012-09-18 02:06:55 -07:00
6c721b5f68
Fix a bug with surrogate characters
...
This is a pretty bad bug :/
Bug: 7013840
Change-Id: I12c7cfa4fa9d56b2c1fee6e6222c64fe20b88fa3
2012-09-18 18:01:15 +09:00
b128b1cdfe
Merge "Take space state into account for caps (A11)" into jb-mr1-dev
2012-09-18 00:21:48 -07:00
5822323514
Remove useless code (A12)
...
All this code is done inside the StringUtils or RichInputConnection
classes, where it's more logical. Since the IPC call is entirely
gone now, it's no use having these guards inside Latin IME.
Change-Id: Id324567e7458aed12b6f21d7114be3bd39725f15
2012-09-18 16:16:33 +09:00
90a9127244
Take space state into account for caps (A11)
...
Bug: 6950087
Change-Id: I8a1bca24db64b4dd54db8ac74d90cf43cbdddab6
2012-09-18 16:16:28 +09:00
8adc0154e6
Remove populateOptions(final ByteBuffer buffer).
...
Change-Id: Ifc4c64c9cffe4f343c5a604c192db010a1792acc
2012-09-18 14:42:52 +09:00
65e4970026
Fix hackCanUseDictionaryFile.
...
Bug: 7169473
Change-Id: I575aaa350042af076a8da5756993cdae9e73422c
2012-09-18 14:19:38 +09:00
252da38fcd
Take locale into account for caps (A10)
...
Bug: 4967874
Change-Id: Ic7ce7b2de088308fa00865c81246c84c605db1e5
2012-09-14 19:42:05 +09:00
da8aca6002
Merge "Fix comment warnings (A9)" into jb-mr1-dev
2012-09-14 03:20:34 -07:00
32c8704c21
Merge "Remove an unused function (A8)" into jb-mr1-dev
2012-09-14 03:19:53 -07:00
5cb9b70a3a
Merge "Fix abbreviations processing for English (A7)" into jb-mr1-dev
2012-09-14 03:14:21 -07:00
a3f06baa57
Merge "Do not auto-correct upon starting a gesture." into jb-mr1-dev
2012-09-14 03:11:51 -07:00
6e65ff8001
Fix comment warnings (A9)
...
Thanks Eclipse
Change-Id: Ie2b83f1ec7ab38a76155f8c264e3944685ae934d
2012-09-14 19:01:37 +09:00
50e61b8628
Remove an unused function (A8)
...
Change-Id: I0578068946d32192c4faf14b3e86624b7301c7d9
2012-09-14 19:01:37 +09:00
2c0d916287
Fix abbreviations processing for English (A7)
...
It's still incorrect for non-English languages.
Bug: 4967874
Change-Id: I3d4379265f72e1c0435eba90ab878a80bbcf55ce
2012-09-14 19:01:25 +09:00
b29efecd26
Merge "Fix a bug with open parens and some other chars" into jb-mr1-dev
2012-09-14 02:30:36 -07:00
7e4ad33a65
Fix a bug with open parens and some other chars
...
A space would be inserted after an open parenthesis if
it's typed after a manual pick.
Bug: 7167687
Change-Id: Ic49d09c34747117ccfbdbb8c66f634d88d4a45b0
2012-09-14 18:23:35 +09:00
e8db06fc02
Merge "Replace immediate values with named constants for characters (A6)" into jb-mr1-dev
2012-09-14 02:17:48 -07:00
371e7d702d
Merge "Make the arrobase sign a space stripper." into jb-mr1-dev
2012-09-14 02:17:20 -07:00
d806065033
Merge "Simplification again (A5)" into jb-mr1-dev
2012-09-14 02:17:01 -07:00
f035649cb6
Asynchronously look up dictionary for gesture input
...
Bug: 7149248
Change-Id: Icba2db73508b89a85828ae9e196ab618e5e6c280
2012-09-14 02:12:11 -07:00
eda096538b
Do not auto-correct upon starting a gesture.
...
We decided to revert this UI decision after negative feedback.
Indeed, if you use to gesture but tap just one word, chances
are it's because you know you do NOT want a dictionary word.
Bug: 6965241
Change-Id: I85fdfab3c1cf1d3c0fd3e95908e01bdf56bccbba
2012-09-14 17:52:54 +09:00
8d35b203ca
Make the arrobase sign a space stripper.
...
Gestures offer much more opportunity to enter e-mail user names,
so this should now be the dominant use case for arrobase use. In
this use case, the arrobase sign should be a space stripper.
Bug: 7164981
Change-Id: I736ac56dab81cd2c97275ec80dbb0ec0bc159006
2012-09-14 17:31:46 +09:00
35dc8cf223
Replace immediate values with named constants for characters (A6)
...
Change-Id: I6248f9f3ff99003ab62be22eac673df0f7f5c015
2012-09-14 16:59:50 +09:00
e94c276690
Simplification again (A5)
...
Change-Id: Id3ba200e06244e6d13cf57d346001d61f85ef1a2
2012-09-14 16:59:18 +09:00
6f8dfd92b1
Simplify the code some more (A4)
...
Change-Id: I1b1763ceefda6357dc698195928d0f16bc425830
2012-09-14 16:58:04 +09:00
33a226f897
Merge "Small simplification (A3)" into jb-mr1-dev
2012-09-13 19:53:14 -07:00
c869a224a4
Merge "Don't show gesture preview trail while detecting gesture input" into jb-mr1-dev
2012-09-13 19:30:00 -07:00
9c5d165e9c
Don't show gesture preview trail while detecting gesture input
...
Bug: 7166222
Change-Id: Iecc8403a4eca305323ed8c8e17266d23172d84d9
2012-09-14 11:21:12 +09:00
cc958dd96e
Refactor BinaryDictInputOutput.
...
Change-Id: Idb4b635fcac70cc988e0dd3ce3bf121fba12099c
2012-09-14 11:08:01 +09:00
5fbe3764ae
Small simplification (A3)
...
Change-Id: I2ea9566ce5cb1fbccd33a42836244a899365de6a
2012-09-13 20:13:52 +09:00
d7fdc730c3
Merge "Simplify a call, and add comments (A2)" into jb-mr1-dev
2012-09-13 03:38:50 -07:00
50f0388ee6
Merge "Fix gesture floating preview on up event" into jb-mr1-dev
2012-09-13 03:21:12 -07:00
350fab6dc4
Fix gesture floating preview on up event
...
This is a follow up of Iddb26ba1.
Bug: 7119032
Change-Id: Ibbc94a1a4880ca31bd8aeece89893691b14acc4d
2012-09-13 19:07:09 +09:00
3d54e1c1ec
Simplify a call, and add comments (A2)
...
Since the function has to be modified heavily but does a lot
of non-trivial work, add a wealth of comments explaining what
it does and why so as to facilitate understanding the changes
to come.
Bug: 4967874
Change-Id: I6c21aea15f161d807035f279dfb7d1b98b3e9144
2012-09-13 18:59:04 +09:00
2427f578c8
Merge "Import TextUtils.getCapsMode to fix it internally (A1)" into jb-mr1-dev
2012-09-13 02:57:35 -07:00
737e915093
Merge "Show gesture floating preview text at oldest finger" into jb-mr1-dev
2012-09-13 02:32:53 -07:00
378728920b
Merge "Make onUpdateSelection much more resilient to race conditions." into jb-mr1-dev
2012-09-13 02:28:52 -07:00
f0e83046f0
Show gesture floating preview text at oldest finger
...
Bug: 7119032
Change-Id: Iddb26ba1a595e472fde0982d744b5652d5fbda3e
2012-09-13 18:17:15 +09:00
9d1c73ffd8
Import TextUtils.getCapsMode to fix it internally (A1)
...
This should have on effect at all on behavior,
except an increase in performance.
Bug: 4967874
Bug: 6950087
Change-Id: Ie2b51efefe84ca767f5dc8e3b80bfef7e1faab3d
2012-09-13 17:46:39 +09:00
5ed88457bf
Make onUpdateSelection much more resilient to race conditions.
...
This is pretty much as strong as it gets. It should be
impossible to get false positives and nearly impossible to
get true negatives with this new code.
Bug: 6981089
Change-Id: Ia32ab62f89c5943f0be169b979abab652e67bf5b
2012-09-13 17:35:26 +09:00
71fcf0f5ec
Assign subtypes' hashCode value as its subtypeId
...
Bug: 6752230
Change-Id: I311b840c890f4c6ff89c2808237d7e9b8baef21d
2012-09-13 16:56:59 +09:00
9144eecd8e
Merge "Add boolean resource isDefault=true for all supported locales" into jb-mr1-dev
2012-09-13 00:43:18 -07:00
328755eee2
Merge "Move FormatOptions and FileHeader to FormatSpec." into jb-mr1-dev
2012-09-13 00:38:44 -07:00
1a347723c5
Move FormatOptions and FileHeader to FormatSpec.
...
Change-Id: I232e35598635113bf2c81825669c744aadc79efe
2012-09-13 16:35:41 +09:00
82902e7671
Add boolean resource isDefault=true for all supported locales
...
Bug: 7115368
Change-Id: I390d52d10d6c7d1639f73255ace9985886ea2157
2012-09-13 15:56:35 +09:00
9deb52c996
Merge "Cosmetic change to remove trailing space" into jb-mr1-dev
2012-09-12 23:44:22 -07:00
c54614d9f3
Cosmetic change to remove trailing space
...
Change-Id: If8c00c763f815d5eb97e18b19060c63d321ccd61
2012-09-13 15:21:54 +09:00
81d97eec0e
Move constants and comments.
...
Change-Id: Ifd66bda7d528827ba61c60531121ea206a2325be
2012-09-13 14:28:39 +09:00
18fc3bf4c4
Merge "Make Latin IME aware of its surrounding text." into jb-mr1-dev
2012-09-12 02:07:48 -07:00
57e9511113
Merge "Use offscreen bitmap buffer to draw gesture preview trail" into jb-mr1-dev
2012-09-12 02:01:46 -07:00
28d765ed90
Make Latin IME aware of its surrounding text.
...
This is a preparatory change for
Bug: 4967874
Bug: 6617760
Bug: 6950087
Change-Id: I3abf8e45c0d02c42491421f108370220134b9602
2012-09-12 17:54:16 +09:00
9ad4b2a894
Use offscreen bitmap buffer to draw gesture preview trail
...
Bug: 7042741
Change-Id: Ie3d7054e786938dc501c7aa2ffc96b5924a7967b
2012-09-12 17:47:17 +09:00
8d031a63b4
Add put method to FusionDictionaryBufferInterface.
...
Change-Id: Iac0b35d2da05e81237d105e8fe13c56d16038de1
2012-09-12 15:41:21 +09:00
64c65ce6d7
Add missing MoreKeySpec.hashCode
...
Bug: 7149235
Change-Id: I14ba1017dffccc690e24289052a3ad7265a5f5f7
2012-09-12 11:52:44 +09:00
655be140a0
Merge "When Accessibility is on, intercept touch events during dispatch." into jb-mr1-dev
2012-09-11 13:31:30 -07:00
e30c4e0bb1
Stabilize gesture recognition algorithm that looks for the nearest key.
...
It relies on the order of the key array.
Change-Id: I58fa71a7b330e59cd774fc208e5b6bc1a3decd2e
2012-09-11 20:00:21 +09:00
8c06a468e0
Stop auto-correcting non-whitelisted one-char strings
...
Bug: 7134017
Change-Id: I75cf474dedafda3e1683dd8f7740c13aafdcf5ab
2012-09-11 17:24:08 +09:00
dc2ee77724
When Accessibility is on, intercept touch events during dispatch.
...
This allows Accessibility code to safely inject events into
onTouchEvent() without accidentally intercepting them.
Bug: 7137557
Change-Id: Ie4fa8e3be5b1bb84f57c6254feab1129cb89998f
2012-09-10 15:47:24 -07:00
e55b644aef
Add new binary dictionary format.
...
Change-Id: Ia99411d4009857d5e420ca87ef8acf1f1826d3ed
2012-09-10 13:05:46 +09:00
60af4f03a8
Fix dicttool_aosp build
...
Change-Id: Iabcf420b4120e3d275fdbcb23939a0ab6052ddf0
2012-09-10 12:56:10 +09:00
eae7b293e4
Check the length of the word when add to FusionDictionary.
...
Change-Id: Id98d18e90a8b83b597507728b467f56888c8fd12
2012-09-10 12:35:53 +09:00
f117f77766
Fix bimanual gesture preview trail
...
Bug: 7122288
Change-Id: I9f0aabe08628880a8439bfda98844ae60206b8de
2012-09-07 17:20:07 +09:00
3069e22610
Merge "Add tests for readDictionaryBinary with byte array." into jb-mr1-dev
2012-09-06 04:40:41 -07:00
be5db53a09
Add tests for readDictionaryBinary with byte array.
...
Change-Id: I2c2815e9d4867687fb3f5b0c661e6162b88c0a0c
2012-09-06 20:35:33 +09:00
c1780c16a7
Revise gesture preview trail design
...
Bug: 7042741
Change-Id: I99e3b3a6fc52afaee3cc5daf371131c3afebb3ae
2012-09-06 20:09:12 +09:00
15496ec4d7
Merge "Revise gesture floating preview design" into jb-mr1-dev
2012-09-05 20:35:40 -07:00
71e2e8152f
Revise gesture floating preview design
...
Bug: 7043127
Change-Id: Ibf9a6d57279263d9b60753e0eb734b658eeda9f2
2012-09-06 12:29:57 +09:00
aa7cc7beed
Merge "Cosmetic cleanup" into jb-mr1-dev
2012-09-05 19:07:45 -07:00
6fbb8ed253
Merge "add logging code" into jb-mr1-dev
2012-09-05 18:46:26 -07:00
1093952cbb
Merge "ResearchLogging do not even show basic data for password fields" into jb-mr1-dev
2012-09-05 11:53:07 -07:00
625cfe3d21
Merge "ResearchLog uploadingService now waits for logging to finish" into jb-mr1-dev
2012-09-05 10:39:03 -07:00
d3a9b70307
Cosmetic cleanup
...
Change-Id: I5e95440019f58c606ac2e947c6e0cbd4d51f6522
2012-09-06 01:13:12 +09:00
e8c6d5a480
Utilize StateListDrawable for key preview background
...
Change-Id: I268550a185701caecefc27ebaec40fb2c940d883
2012-09-05 20:38:00 +09:00
83dfe0fd8c
Add FormatOptions.
...
Change-Id: Ibad05a5f9143de1156b2c897593ec89b0a0b07e7
2012-09-05 18:05:43 +09:00
fe05b88134
add logging code
...
Change-Id: I0abb4a1ad67666162ab6703ffdb33c5e0675be93
2012-09-04 15:24:25 -07:00
596911479c
ResearchLogging do not even show basic data for password fields
...
Change-Id: I5489bad95f238e2f4d43bdd65bcf2f752d7a63fe
2012-09-04 15:24:25 -07:00
17114054e9
ResearchLog uploadingService now waits for logging to finish
...
Bug: 6188932
Change-Id: I31c0f380b334d9117990f2d92de8d385e4a52c7c
2012-09-04 15:24:25 -07:00
ac25fcac71
Display punctuation suggestions on cursor move
...
...if punctuation suggestions are requested.
Fixes the symptom, but not the root cause of
Bug: 6981089
Change-Id: I683a7451c99457829cb4e5a762f43548ff89a535
2012-09-04 19:54:55 +09:00
2e4713a54e
Merge "Check the length of the word when add to userhistory." into jb-mr1-dev
2012-09-04 02:36:35 -07:00
848331222e
Use string-array resource to define predefined-subtypes
...
Bug: 6809603
Change-Id: Icafe4652ec17844838b28c04977deb88bcb9aa8f
2012-09-04 17:18:39 +09:00
147a62a8a8
Merge "Reduce amount of empty space in which keypresses are detected" into jb-mr1-dev
2012-09-04 00:55:25 -07:00
3f00c6151f
Reduce amount of empty space in which keypresses are detected
...
Bug: 6942329
Change-Id: Ie92ccf43f307b8ceb9a311c30390d0cb2abf2cd7
2012-09-04 16:11:21 +09:00
dd435b305e
Check the length of the word when add to userhistory.
...
Change-Id: I7f2fe1771eed6b610704892b24f8a0283a779162
2012-09-04 15:34:41 +09:00
d34dd5bb6b
Merge "Cosmetic fixes and a bug fix in UnigramDictionary::testCharGroupForContinuedLikeness()." into jb-mr1-dev
2012-09-03 22:26:42 -07:00
f2789819bd
Cosmetic fixes and a bug fix in UnigramDictionary::testCharGroupForContinuedLikeness().
...
This change has actually been extracted from a change work in progress I4fe423834b8131fb122251892c98228a6e08ba25
Change-Id: I52568fa09da2ea22be7f8bfe9676b7cd73c31fa4
2012-09-04 14:23:37 +09:00
2c0c1cc677
Merge "Fix key info reported by keyboard accessibility node provider." into jb-mr1-dev
2012-09-03 18:34:55 -07:00
eceea877bd
Consolidate Esperanto layout into Spanish layout
...
This change also removes AsciiCapable extra value from Esperanto
subtype.
Change-Id: I0fa18ef7c52e4ba24b182e8ecb9788572660b704
2012-09-03 17:38:56 +09:00
ab5f9532db
Use 5-row layout for Thai phone keybopard
...
Bug: 6911182
Change-Id: I78f59564e8c31b9b66ed9a136584d0c57cc43120
2012-09-03 14:15:48 +09:00
8624a0a186
Use normal font for Thai
...
This change also adds workaround to display Thai composing letters
correctly.
Bug: 6753168
Change-Id: Ibd42ebb40df08b5de32b3500f10003c4a5de4897
2012-09-03 14:05:10 +09:00
8251036616
Match calls in I8a70e43b for Icbe60bdf
...
Change-Id: I3a9eaaa018cd338ca8d9aa09c0fa58800b637e19
2012-09-03 11:58:23 +09:00
2035b946a3
Merge "Reinstate the shortcut-only attribute" into jb-mr1-dev
2012-09-02 19:28:01 -07:00
27c093fc5e
am 70fb1d1a: am f0adce8a: Merge "Esperanto keyboard"
...
* commit '70fb1d1a690f3f16e4bbb19ffea349af1402cb1f':
Esperanto keyboard
2012-08-31 07:08:55 -07:00
70fb1d1a69
am f0adce8a: Merge "Esperanto keyboard"
...
* commit 'f0adce8a491f1f1970354eef7e6fd078b237684c':
Esperanto keyboard
2012-08-31 07:04:00 -07:00
72b1c93941
Reinstate the shortcut-only attribute
...
Also add the blacklist attribute
Bug: 7005742
Bug: 2704000
Change-Id: Icbe60bdf25bfb098d9e3f20870be30d6aef07c9d
2012-08-31 22:11:52 +09:00
a643b54b4d
Add missing KeyDrawParams default constructor to fix build
...
Change-Id: Id2ae9e4085b4137c961b5202e0822d484dd71e8e
2012-08-31 20:28:46 +09:00
aa54607246
Merge "Support per-Key and per-Keyboard key visual attributes" into jb-mr1-dev
2012-08-31 04:24:48 -07:00
dc34da218a
Support per-Key and per-Keyboard key visual attributes
...
This change refactors KeyDrawParams and KeyPreviewDrawParams to
separate KeyVisualAttributes.
Change-Id: I4de549eef303e1debe4b8f84668e042445fc18da
2012-08-31 20:23:21 +09:00
67d0a597bc
Merge "Use resource to specify 5-rows keyboard parameters" into jb-mr1-dev
2012-08-31 04:06:35 -07:00
74b89db8a4
Merge "Fix key label padding" into jb-mr1-dev
2012-08-31 03:58:21 -07:00
36b5f4aae2
Fix key label padding
...
Change-Id: I971dd17afdaf1ce6e64e3c41bdb42a6ba3f6fd0e
2012-08-31 19:57:25 +09:00
518838b778
Use resource to specify 5-rows keyboard parameters
...
Change-Id: I67b290c4600dee43a81ba975ffc93a32a6d060b4
2012-08-31 19:14:33 +09:00
9d05f36b77
Use normal font for Arabic and Farsi
...
Bug: 6753168
Change-Id: Iaef85847cf9f6c432c6ca25e7e6ec522c084d073
2012-08-31 18:56:50 +09:00
666a433802
add UserHistoryDictIOUtils.
...
Change-Id: I8a70e43b23f65b5fd5f0ee0b30a94ad8f5ef8a8a
2012-08-31 15:08:57 +09:00
9bbc7ec052
Merge changes Ifb983c35,I0b947421 into jb-mr1-dev
...
* changes:
ResearchLogger clean up splash screen
ResearchLogger no longer offers option to disable logging
2012-08-30 22:56:53 -07:00
48643b08a9
Merge "add readUnigramsAndBigramsBinary." into jb-mr1-dev
2012-08-30 22:55:12 -07:00
25405eafb0
ResearchLogger clean up splash screen
...
- simpler text
- AlertDialog implementation
- declining users are redirected to regular IME
Bug: 6188932
Change-Id: Ifb983c3511125f8919f4a8b25aeee7de66dbb0cb
2012-08-30 22:52:00 -07:00
58eb4d9f27
ResearchLogger no longer offers option to disable logging
...
Bug: 6188932
Change-Id: I0b9474216080f3820438c09f89b0b6c6c102c69d
2012-08-30 22:51:56 -07:00
b2a43a2ed4
add readUnigramsAndBigramsBinary.
...
Change-Id: I7967f11211221d4877bf0a0c30183af885f45390
2012-08-31 14:39:19 +09:00
71b52a84e2
Move key label padding attributes back to KeyboardView
...
This is a partially reverting change of I1e2d59bf8c438ca653e2e415ccf66fd4f15d5394
Change-Id: Id213541cdddcc0761bf6418c8429a5f96c0281ef
2012-08-31 10:35:54 +09:00
49d8af8a4e
Separate inner classes of KeyboardView out under internal package
...
Change-Id: I6d53b53526bbab951044a026476bd88a9ebd5a90
2012-08-30 16:23:01 +09:00
749cc18751
Move some key top visual attributes from KeyboardView to Key
...
Change-Id: I1e2d59bf8c438ca653e2e415ccf66fd4f15d5394
2012-08-30 16:14:32 +09:00
3ed057a058
Esperanto keyboard
...
Universal esperanto keyboard. Has letters for all latin scripts, as users
will often need to type something in both Esperanto and other languages
(for example their country's).
Signed-off-by: Jacob Nordfalk <jacob.nordfalk@gmail.com>
Change-Id: Ia8a739fa31a60e118d42ae9e8c62ddfd66e2ca35
2012-08-30 08:48:19 +02:00
35ff94547c
Separate inner classes of keyboard package out under internal package
...
Change-Id: Ia3969bd5ddec5aa5d81d05ad4cf676d818587922
2012-08-30 15:37:55 +09:00
ded498d4a4
Merge "add readHeader." into jb-mr1-dev
2012-08-29 22:32:14 -07:00
62ed901100
add readHeader.
...
Change-Id: I5be5d62a63ca897e36fe93200ffdca6befb363aa
2012-08-30 14:17:50 +09:00
29d5973fd3
Optimize rare Key attributes to separate class
...
This change also removes per-Key verticalGap and horizontalGap.
Change-Id: Id4d2129022fbbfbf5d740b8d1257032c945bb775
2012-08-30 11:48:19 +09:00
61bc66b324
Revert "Revert "Fix key letter size of 5-rows Thai keyboard""
...
This reverts commit 7a5ca9982f
2012-08-30 11:30:13 +09:00
b590d69e1f
Merge "Revert "Revert "Move resource related methods to ResourceUtils""" into jb-mr1-dev
2012-08-29 19:29:37 -07:00
d2a81ab9bd
Merge "Add FusionDictionaryBufferInterface." into jb-mr1-dev
2012-08-29 18:49:03 -07:00
85cb45c80f
Merge "Add defaults for manta" into jb-mr1-dev
2012-08-29 15:40:41 -07:00
26b424b644
Fix key info reported by keyboard accessibility node provider.
...
Bug: 6704529
Change-Id: I519881a96767a8858c11da7c0abac3e276a45cf5
2012-08-29 13:07:37 -07:00
3b54385d61
Add defaults for manta
...
Change-Id: I8784a126b02e3e6618ac845a32a894ceb58ea39e
2012-08-29 09:10:26 -07:00
92821614fd
Revert "Revert "Move resource related methods to ResourceUtils""
...
This reverts commit bfc02a7005
2012-08-29 22:30:55 +09:00
bfc02a7005
Revert "Move resource related methods to ResourceUtils"
...
This reverts commit 160dc0f98e
2012-08-29 04:33:39 -07:00
f5c4ff4817
Add FusionDictionaryBufferInterface.
...
Change-Id: I8640c994231d5f46bc6e074ce8a5bf5344fed0aa
2012-08-29 19:27:49 +09:00
160dc0f98e
Move resource related methods to ResourceUtils
...
Change-Id: I14535b030e58363315dd2daecaaef4edd6990cd9
2012-08-29 17:51:07 +09:00
Baligh Uddin
Yuichiro Hanada
Ken Wakasa
Jean Chalard
Tadashi G. Takaoka
Satoshi Kataoka
Brian Muramatsu
Sam Segers
Charles Chen
alanv
Kurt Partridge
Jean-Baptiste Queru
Jacob Nordfalk
Jason Chen