Commit Graph

2766 Commits (2866da88a781c501c6f83cfd91eca0d95e25f6e5)

Author SHA1 Message Date
Tadashi G. Takaoka b4b3e80f11 Merge "Fix empty custom input style entry appears after orientation change" into jb-dev 2012-05-15 04:23:50 -07:00
Tadashi G. Takaoka c6846f28ba Fix empty custom input style entry appears after orientation change
Bug: 6495828
Change-Id: I77c44e24340cff4e0702ac6dee02e4dd84076f3e
2012-05-15 20:19:31 +09:00
Jean Chalard 2bbdac539a Merge "Use a formula packing more information into 4 bits field" into jb-dev 2012-05-15 03:02:01 -07:00
Jean Chalard 418b343797 Use a formula packing more information into 4 bits field
Bug: 6313806
Change-Id: Id0779bd69afae0bb4a4a285340c1eb306544663a
2012-05-15 18:59:21 +09:00
Jean Chalard a86c0f1ea4 Stop meaningless bigram computations
Bug: 6313806
Change-Id: Idf765b40812a43de13aa166ed0b44c7b5f7cc218
2012-05-15 16:34:17 +09:00
Jean Chalard 8dced70b06 Merge "Read and use user dictionary shortcuts." into jb-dev 2012-05-14 20:38:23 -07:00
Tadashi G. Takaoka 30236efee1 Remove "fillBoth" enum value from keyWidth attribute of Key
Change-Id: Icc5ffb8286aeda298b46aeba05e44608e342bc57
2012-05-15 12:27:34 +09:00
Jean Chalard 19ad9bf145 Read and use user dictionary shortcuts.
Bug: 4646172

Change-Id: I51002c73d5bad1a698110c5cda02253348be8eed
2012-05-15 12:23:43 +09:00
satok 76218b966a Merge "Do not set "SuggestionSpan"s for suggestions from the next word predicition" into jb-dev 2012-05-14 20:14:53 -07:00
satok 0142b997bf Do not set "SuggestionSpan"s for suggestions from the next word predicition
Bug: 6294817
Change-Id: I5010eafa5ba7e947743706adf7e722f4f0cfb415
2012-05-15 12:08:31 +09:00
Jean Chalard a9aeb6f3cc Merge "Small optimization" into jb-dev 2012-05-14 19:11:19 -07:00
Jean Chalard b1120fe79a Merge "Small optimizations" into jb-dev 2012-05-14 19:11:11 -07:00
Jean Chalard f5ac6c725a Merge "More optimizations" into jb-dev 2012-05-14 19:11:06 -07:00
Jean Chalard f184e73dd7 Merge "Some more obvious optimizations" into jb-dev 2012-05-14 19:11:02 -07:00
Jean Chalard 78df7181ff Merge "Some obvious optimizations to makedict" into jb-dev 2012-05-14 19:10:48 -07:00
Jean Chalard 76319c6931 Small optimization
Performance gain is < 2%

Bug: 6394357
Change-Id: I2b7da946788cf11d1a491efd20fb2bd2333c23d1
2012-05-14 15:52:01 +09:00
Jean Chalard 4df5b43df8 Small optimizations
Bug: 6394357
Change-Id: I00ba1b5ab3d527b3768e28090c758ddd1629f281
2012-05-14 15:51:58 +09:00
Jean Chalard 3b1b72ac4d More optimizations
We don't merge tails anyway, and we can't do it any more
because that would break the bigram lookup algorithm.
The speedup is about 20%, and possibly double this if
there are no bigrams.

Bug: 6394357

Change-Id: I9eec11dda9000451706d280f120404a2acbea304
2012-05-14 12:41:18 +09:00
Jean Chalard 12efad3d15 Some more obvious optimizations
The speedup is about 15%

Bug: 6394357
Change-Id: Ibd57363d9d793206dd916d8927366db4192083b6
2012-05-14 12:35:31 +09:00
Jean Chalard 47db0be7cb Some obvious optimizations to makedict
Bug: 6394357
Change-Id: Ibfd98aac2304ef50cf90b1de984736ddcfe7a4bc
2012-05-14 12:34:05 +09:00
Tom Ouyang 4d289d39ae Contacts dictionary rebuilds only when contact names have changed.
Bug: 6396600
Change-Id: Iad693ec4bab6351793d624e5c5b0a9f5c12a60e3
2012-05-11 18:43:53 -07:00
Charles Chen 38b5e4239d Merge "Implement "lift-to-type" interaction. Fix event text." into jb-dev 2012-05-11 10:16:05 -07:00
Jean Chalard 59e6ad3874 Merge "Write the bigram frequency following the new formula" into jb-dev 2012-05-11 04:42:36 -07:00
Jean Chalard f7346de94a Write the bigram frequency following the new formula
This also tests for bigram frequency against unigram frequency

Bug: 6313806
Bug: 6028348
Change-Id: If7faa3559fee9f2496890f0bc0e081279e100854
2012-05-11 20:27:22 +09:00
Jean Chalard ad0233fa02 Merge "Refactor a method" into jb-dev 2012-05-11 04:09:17 -07:00
Jean Chalard 4455fe2c89 Refactor a method
Rename it, rename parameters, and add a parameter that will
be necessary soon.
Also, rescale the bigram frequency as necessary.

Bug: 6313806
Change-Id: I192543cfb6ab6bccda4a1a53c8e67fbf50a257b0
2012-05-11 19:34:35 +09:00
Tadashi G. Takaoka a6204bbe2a Fix Spanish keyboard to have easy access to inverted ? and !
Bug: 6480385
Change-Id: Iae7879b5264711962a662f4b3d47a834bda715be
2012-05-11 19:17:53 +09:00
Tadashi G. Takaoka 2de0b52a03 Merge "Reorganize punctuations and diacritics of Arabic and Persian" into jb-dev 2012-05-11 03:06:33 -07:00
satok 6792a909cd Merge "Output caps debug code" into jb-dev 2012-05-11 03:06:29 -07:00
satok 5434f46481 Remove unexpectedly split words with single quotes
Bug: 6451163
Change-Id: I4c5595f727934f2b401e9bb11a6ba613668f4a42
2012-05-11 18:49:29 +09:00
satok b6fb5eb391 Output caps debug code
Change-Id: I4a3399d9066bd28dab893ecebb720924110b871d
2012-05-11 17:37:14 +09:00
Ken Wakasa 88794b24c0 Remove the dependency to SpellCheckerProximityInfo from ProximityInfo.
In conjunction with I596b2deb

Change-Id: I42f059158ae78e1c1c807ed4d3688edbcf18c006
2012-05-11 17:03:06 +09:00
Tadashi G. Takaoka ef6dadbe6c Reorganize punctuations and diacritics of Arabic and Persian
Bug: 6029665
Change-Id: Id72d5af2c9c8fff09a366819901c950b87756dea
2012-05-11 15:48:56 +09:00
alanv 6662e2a40d Implement "lift-to-type" interaction. Fix event text.
Bug: 6456970
Change-Id: Idd6b84fc7a730a1e78d9c1157e3b5f22e5d49fc4
2012-05-10 11:37:13 -07:00
Charles Chen 7c23ad92fc Merge "Use key index as virtual view ID." into jb-dev 2012-05-10 11:34:20 -07:00
Tadashi G. Takaoka 684c519d9d Merge "Cleanup indentation" into jb-dev 2012-05-10 01:53:38 -07:00
Tadashi G. Takaoka cee24a1f6c Cleanup indentation
Change-Id: Iaaade378acb81a2d68e2e721778a82fd8d5e20a5
2012-05-10 17:48:10 +09:00
alanv b4c41fa813 Use key index as virtual view ID.
Bug: 6464677
Change-Id: I443e4add8052dbce1d413c2ce38a7b98408613bf
2012-05-09 22:23:14 -07:00
Svetoslav Ganov 52ab6864d0 Merge "Remove unused code from AccessibilityEntityProvider." into jb-dev 2012-05-09 22:18:50 -07:00
Tadashi G. Takaoka bced82709a Merge "Fix calculation of more keys keyboard position based on key preview" into jb-dev 2012-05-09 06:04:47 -07:00
Tadashi G. Takaoka 7ecc1081ab Fix calculation of more keys keyboard position based on key preview
Bug: 6135881
Change-Id: Id1c4e2c13d13b474466cb9b42b425aa9f6f9448b
2012-05-09 21:23:09 +09:00
Tadashi G. Takaoka 5a40dcaf8b Release previously pressed key even when the up event points new key
Bug: 6457266
Change-Id: I52c9fe88791d2c3a4385dfa457f07da160c60699
2012-05-09 20:24:14 +09:00
Tadashi G. Takaoka c8bde75cf4 Merge "Optimize InputConnection.getCursorCapsMode calling" into jb-dev 2012-05-09 00:24:00 -07:00
Tadashi G. Takaoka 03ca17c841 Optimize InputConnection.getCursorCapsMode calling
Bug: 6464226
Change-Id: I30c1b01be5e1719ded5f7f8a7e24a38e9bbc3637
2012-05-09 16:19:08 +09:00
Jean Chalard d5cd7e64aa Small optimization
Change-Id: I067249976e557b60b606d2153deaeb3c8f1f38ac
2012-05-09 16:14:25 +09:00
Jean Chalard 442ac5d0bb Merge "Don't ask for surrounding characters for each keypress" into jb-dev 2012-05-08 23:38:53 -07:00
Jean Chalard 736b109e16 Don't ask for surrounding characters for each keypress
Bug: 6464226
Change-Id: I03745bbcc21e5ec6ca57fa1257bf21c0cd26391a
2012-05-09 15:19:35 +09:00
alanv 8e5f79f57d Remove unused code from AccessibilityEntityProvider.
Change-Id: I73882668b516344d36e69355e9cb39534becb629
2012-05-08 19:51:49 -07:00
alanv 34b2b5e694 Remove accessibility gesture handlers from LatinIME.
Bug: 6457558
Change-Id: If33ca6f026d4846ba79a701ef42c0112f5b0b488
2012-05-08 17:23:58 -07:00
Tadashi G. Takaoka f52aef84a5 Merge "Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified" into jb-dev 2012-05-08 06:43:05 -07:00
Tadashi G. Takaoka 0b831ba2aa Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified
Bug: 6435484
Change-Id: Iccca7d1b770c547efae0b5e5931cebd910083d40
2012-05-08 13:20:39 +09:00
Tadashi G. Takaoka 7b6afb1287 Enable long-press spacebar on 7 inch tablet
This change also eliminate useless attribute longPressSpaceKeyTimeout
of LatinKeyboardView.

Bug: 6449356
Change-Id: Ib4dace4b9510c0eb96bdddacf8e0dbaa14fcfbbf
2012-05-08 12:50:07 +09:00
satok e58f3af8a7 Treat apostrophe as single quote in spell checker
Bug: 6435348
Change-Id: Iaaac9042e7e6cb21a3f2243bc6e8e055cc24f74d
2012-05-07 22:21:55 +09:00
Tadashi G. Takaoka 165725aba8 Fix build
Related-change: I173a3dc0
Change-Id: I4b5adedb70f7501e84fd3604aa240161c97dc713
2012-05-07 08:19:17 +09:00
Tadashi G. Takaoka 8e50c5d198 Fix subtype name for a custom input style with en_US and en_GB
This change utilizes "UntranslatableReplacementStringInSubtypeName"
subtype extra value to display keyboard layout name dynamically.

Bug: 6449315
Change-Id: I9ef4c3d66ff9a223aa8c89c346d04cb72e4f6263
2012-05-07 03:25:08 +09:00
Tadashi G. Takaoka 4e6c604645 Merge "Fix newly created custom input style display name" into jb-dev 2012-05-06 10:46:07 -07:00
Tadashi G. Takaoka ca93442026 Fix newly created custom input style display name
This will revert I4263632e

Bug: 6443665
Bug: 6410653
Change-Id: Id9ad1a204ed9802488abfc2c536a95d62d55afe0
2012-05-07 02:42:08 +09:00
Ken Wakasa 3665e2a8fc Merge "Tidy up the MakedictLog class." into jb-dev 2012-05-06 10:31:46 -07:00
Tadashi G. Takaoka 4c9bdcc957 Merge "Fix missing synchronized modifier" into jb-dev 2012-05-06 09:52:52 -07:00
Tadashi G. Takaoka 5b2eb0f505 Fix missing synchronized modifier
Change-Id: Ied70a86bedb08adcf8353b189367172459f55292
2012-05-07 00:55:01 +09:00
Tadashi G. Takaoka 757c12556b Get subtype name string resource from its own locale
Bug: 6443655
Change-Id: Ib9ee55178f0d0f885aa0640b9cba4a179cf0c566
2012-05-07 00:44:54 +09:00
Ken Wakasa 84478103ec Tidy up the MakedictLog class.
Follow up to I436b2b7b

Change-Id: Id17b134dab2f876b874a505e92a379c8b5567fa4
2012-05-05 23:40:21 +09:00
Ken Wakasa 03b423f313 Suppress debug log from makedict in LatinIME
bug: 6447900
Change-Id: I436b2b7b261b422a7edca9cb99a4689b63877fe0
2012-05-05 09:28:27 +09:00
satok 9ec06c17d4 Fix build breakage
Change-Id: I22305137b336c9aab019d044a517ae8bc5fefe45
2012-05-02 18:14:40 +09:00
satok 57007ed582 Merge "Workaround return preserved backing view height when the backing view is not ready" into jb-dev 2012-05-02 01:42:00 -07:00
satok f4cf5b9952 Workaround return preserved backing view height when the backing view is not ready
Change-Id: If4f24500ead516c46e6a93a95291e0897548c2f0
2012-05-02 17:40:10 +09:00
Tadashi G. Takaoka 76d6673b2a Merge "Fix checking if subtype belongs to this ime" into jb-dev 2012-05-01 04:23:40 -07:00
Tadashi G. Takaoka ae2388c7f7 Fix checking if subtype belongs to this ime
Bug: 6422318
Change-Id: I5779c0e277444315191fa964a976dcb4316cc24a
2012-05-01 20:21:10 +09:00
Tadashi G. Takaoka aec1770ed1 Tune letter text size of 7 inch tablet
Bug: 6422086
Bug: 6411272
Change-Id: Ia3c40206555353b6f0c633a529d546dc2379e9aa
2012-05-01 19:56:40 +09:00
Jean Chalard a474dbc5c2 Merge "Don't autocorrect after suggestion resuming" into jb-dev 2012-05-01 01:15:23 -07:00
Jean Chalard 4b5b46bb66 Don't autocorrect after suggestion resuming
Bug: 6105732
Change-Id: I92e7a9c6d6eb648f747c3b396d7993479fd8478a
2012-05-01 17:06:29 +09:00
Tadashi G. Takaoka 2f83e9e532 Can override key-style
Bug: 6412932
Change-Id: I9576ae5b42bcc54cfd8ede0bae5148f3b04c1978
2012-05-01 16:56:53 +09:00
Ken Wakasa 0ab1c664c1 Avoid Resources$NotFoundException
bug: 6410653
Change-Id: I4263632e76b44abf8ecd9114a9eb185ad39201fd
2012-04-28 03:24:05 +09:00
Jean Chalard 20a6dea1ca Add a flag for bigram presence in the header
This is a cherry-pick of Icb602762 onto jb-dev.

Bug: 6355745
Change-Id: Icb602762bb0d81472f024fa491571062ec1fc4e9
2012-04-26 16:40:29 +09:00
Jean Chalard 329c8d7bcc Merge "Ignore bigrams that are not also listed as unigrams" into jb-dev 2012-04-26 00:26:04 -07:00
Tadashi G. Takaoka 93e122e28d Merge "Fix potential "divided by zero" exception" into jb-dev 2012-04-26 00:21:07 -07:00
Tadashi G. Takaoka bd2ca9c021 Fix potential "divided by zero" exception
This change also refactors the language name selection to use text
x-scale.

Bug: 6396854
Change-Id: I31249a85bd042a93d627f40413161aef13617c87
2012-04-26 16:01:55 +09:00
Tadashi G. Takaoka 45c57dcc2d Merge "Fix SubtypeSwitcher incomplete initialization" into jb-dev 2012-04-25 23:22:06 -07:00
Jean Chalard 44c64f46a1 Ignore bigrams that are not also listed as unigrams
This is a cherry pick of I14b67e51 on jb-dev

Bug: 6340915
Change-Id: Iaa512abe1b19ca640ea201f9761fd7f1416270ed
2012-04-26 15:20:30 +09:00
Tadashi G. Takaoka 3d407cc086 Fix SubtypeSwitcher incomplete initialization
Bug: 6400718
Change-Id: Id5dce156ad397b911bfeaedeeddd4aeb21a10b3a
2012-04-26 13:41:15 +09:00
Tadashi G. Takaoka 27b42ced86 Fix "no language" subtype name (DO NOT MERGE)
* Move SubtypeLocale.get{Full,Middle,Short}DisplayName() to
  LatinLeyboardView and add unit tests (SpacebarTextTests).
* Add SubtypeLocale.getSubtypeDisplayName()

This is a cherry-pick of I57420c6a from Master.

Bug: 6393865
Change-Id: I68748189c17c73984ac4ae05a5a40fb54bf46453
2012-04-26 11:50:28 +09:00
Tadashi G. Takaoka 49caddbdab Support PC QWERTY layout
Bug: 4460018
Change-Id: I9a29f6a322af66f6a152fa1883b3686c5f7a3328
2012-04-25 16:34:59 +09:00
Tadashi G. Takaoka cbaf6d85f1 Cancel SubtypePreference dialog properly
Bug: 6384416
Bug: 6387408
Change-Id: Ia7b0653a09410b42a55915815c887bf0ad56c856
2012-04-25 15:42:14 +09:00
Tadashi G. Takaoka 9f0a137f82 Save & restore additional subtype dialog state when orientation is changed
Bug: 6384416
Change-Id: Id5fa4742ad900fafb82cc37a0bbb9f380b99254d
2012-04-25 15:29:05 +09:00
Tadashi G. Takaoka d454fcc2cf Merge "Ignore unknown keyboard layout safely" 2012-04-24 23:22:26 -07:00
Tadashi G. Takaoka 96e404310d Ignore unknown keyboard layout safely
Bug: 6393755
Change-Id: I3a74b23f934cd52925026ad04647cc76de92ee07
2012-04-25 13:34:04 +09:00
Tadashi G. Takaoka b7286439f6 Fix percent sign in more keys
Bug: 6029665
Change-Id: I4bf0f5703d0c11d76bab478da2729b0e20fc64ea
2012-04-25 11:51:19 +09:00
Tom Ouyang ce54a14bed Merge "Change expandable binary dict write to a temp file first." 2012-04-24 10:54:56 -07:00
Tom Ouyang a9b2be8a81 Change expandable binary dict write to a temp file first.
Bug: 6380724
Change-Id: Ic1d0d902dc45ecb41a1792f33a60ab85e606fcef
2012-04-24 10:52:53 -07:00
Tadashi G. Takaoka 8e7740b28a Merge "Add header commnets of KeyboardTextsSet.tmpl" 2012-04-24 00:49:11 -07:00
Tadashi G. Takaoka 5723bedcd0 Merge "Revert keyHintLetterPadding only to apply horizontally" 2012-04-24 00:41:57 -07:00
Tadashi G. Takaoka ab771b01eb Revert keyHintLetterPadding only to apply horizontally
Partially reverts the Ia3680d84.

Bug: 6356125
Change-Id: I8faa810b833cb98ce6f0f760aa1722e63475cd45
2012-04-24 16:20:47 +09:00
Tadashi G. Takaoka aaac9a5217 Add header commnets of KeyboardTextsSet.tmpl
Bug: 6371604
Change-Id: I1054685b9985b6923e3176679b3d95424d8114e0
2012-04-24 16:19:17 +09:00
Jean Chalard 805fed49e1 Merge "Fix binary reading code performance." 2012-04-23 23:39:37 -07:00
Tadashi G. Takaoka fe4d13cbcb Merge "Make the "Touch again to save" hint text touchable." 2012-04-23 23:20:49 -07:00
Jean Chalard 1d80a7f395 Fix binary reading code performance.
This is not the Right fix ; the Right fix would be to read
the file in a buffered way. However this delivers tolerable
performance for a minimal amount of code changes.
We may want to skip submitting this patch, but keep it around
in case we need to use the functionality until we have a good
patch.

Change-Id: I1ba938f82acfd9436c3701d1078ff981afdbea60
2012-04-24 15:16:17 +09:00
Jean Chalard cbebbaf065 Merge "Fix a bug where a node size would be seen as increasing." 2012-04-23 22:19:19 -07:00
Jean Chalard a64a1a46e4 Fix a bug where a node size would be seen as increasing.
The core reason for this is quite shrewd. When a word is a bigram
of itself, the corresponding chargroup will have a bigram referring
to itself. When computing bigram offsets, we use cached addresses of
chargroups, but we compute the size of the node as we go. Hence, a
discrepancy may happen between the base offset as seen by the bigram
(which uses the recomputed value) and the target offset (which uses
the cached value).
When this happens, the cached node address is too large. The relative
offset is negative, which is expected, since it points to this very
charnode whose start is a few bytes earlier. But since the cached
address is too large, the offset is computed as smaller than it should
be.
On the next pass, the cache has been refreshed with the newly computed
size and the seen offset is now correct (or at least, much closer to
correct). The correct value is larger than the previously computed
offset, which was too small. If it happens that it crosses the -255 or
-65335 boundary, the address will be seen as needing 1 more byte than
previously computed. If this is the only change in size of this node,
the node will be seen as having a larger size than previously, which
is unexpected. Debug code was catching this and crashing the program.

So this case is very rare, but in an even rarer occurence, it may
happen that in the same node, another chargroup happens to decrease
it size by the same amount. In this case, the node may be seen as
having not been modified. This is probably extremely rare. If on
top of this, it happens that no other node has been modified, then
the file may be seen as complete, and the discrepancy left as is
in the file, leading to a broken file. The probability that this
happens is abyssally low, but the bug exists, and the current debug
code would not have caught this.
To further catch similar bugs, this change also modifies the test
that  decides if the node has changed. On grounds that all components
of a node may only decrease in size with each successive pass, it's
theoritically safe to assume that the same size means the node
contents have not changed, but in case of a bug like the bug above
where a component wrongly grows while another shrinks and both cancel
each other out, the new code will catch this. Also, this change adds
a check against the number of passses, to avoid infinite loops in
case of a bug in the computation code.

This change fixes this bug by updating the cached address of each
chargroup as we go. This eliminates the discrepancy and fixes the
bug.

Bug: 6383103
Change-Id: Ia3f450e22c87c4c193cea8ddb157aebd5f224f01
2012-04-24 14:04:02 +09:00
Tadashi G. Takaoka 9f763d1445 Make the "Touch again to save" hint text touchable.
Bug: 6355346
Change-Id: I96933719cc94f25e6c7ecb1d6345c11b6acc4134
2012-04-24 13:44:14 +09:00
Tadashi G. Takaoka 3e3bb36f1f Fix NPE in AdditionalSubtypeSettings
Bug: 6384416
Change-Id: I878071b8b78acce51649f9637b59830ab681c696
2012-04-24 11:01:45 +09:00