Kurt Partridge
99931201d0
[Rlog59b] Log CodeInput and KeyCode properly
...
- Fix function calls to happen at more resilient times
- In the case of phantom spaces, ensure that the logStatement goes to the
correct logUnit
Change-Id: Ida8f6eba1e4f33d9f9b4735316e3c6316ed316c0
2013-01-10 23:39:11 -08:00
Kurt Partridge
90aaa2d0a5
[Rlog59a] Split logUnits correctly around separators
...
Change-Id: I65ecdead7e7bdeb8a5f1748e27068ddbd5d3ce00
2013-01-10 16:36:18 -08:00
Kurt Partridge
75e69753b7
[Rlog57b] fix logging of reverts
...
Change-Id: I07c817061a0cc060197e0fea45195ca07a9bf276
2013-01-10 15:00:28 -08:00
Tadashi G. Takaoka
50d902ac6f
Show final suggested word when batch input is finished
...
This change moves dismiss timer of gesture floating preview text from
PreviewPlacerView to KeyboardView.
Bug: 7967461
Change-Id: I0ca5beddc93cb4bc4a405f914d217d37b997402b
2013-01-10 16:25:05 +09:00
Kurt Partridge
f11c4a9aeb
Merge "[Rlog50] capture bigrams properly even with deletions"
2013-01-09 19:52:45 -08:00
Tadashi G. Takaoka
3727a3fd61
Merge "Clean up public helper methods of SettingsValues"
2013-01-09 19:04:46 -08:00
Kurt Partridge
3b95eaf70b
[Rlog50] capture bigrams properly even with deletions
...
multi-project commit with Ia4ec213e8356897807cb6a278fccdbaa945732f0
Change-Id: Ib3fe886dc889954a31586ab81d00a21d8d55efd2
2013-01-09 16:02:37 -08:00
Jean Chalard
516b63db28
Fix a race condition with backspaces
...
And add a test to make sure it stays not-broken.
Bug: 7946604
Change-Id: I996da3d5507d591ec25a13fb57434f39843f1df5
2013-01-09 18:37:10 +09:00
Tadashi G. Takaoka
d3b0ecec22
Clean up public helper methods of SettingsValues
...
Change-Id: I6c6087580b67f497eaaf16900f8df7a4a895b8e3
2013-01-09 11:23:34 +09:00
Kurt Partridge
9bad176ebe
Merge "[Rlog32] ResearchLogger segment motion data around gestures correctly"
2013-01-08 08:10:31 -08:00
Kurt Partridge
b7fb16e8cc
Merge "[Rlog27] Refactor LogBuffer"
2013-01-08 07:40:57 -08:00
Tadashi G. Takaoka
ff0735ada8
Make Settings class singleton to manage SettingsValues
...
Change-Id: Id30828a141de86d9bcf8bce586d2adb468cc59e1
2013-01-08 17:48:47 +09:00
Tadashi G. Takaoka
b17b887425
Consolidate VibratorUtils with AudioAndHapticFeedbackManager
...
Change-Id: Ica4e3193f369330da62a259c718b779ddf9fbde5
2013-01-08 15:13:19 +09:00
Kurt Partridge
99f3189645
[Rlog32] ResearchLogger segment motion data around gestures correctly
...
multi-project commit with I684ba5fed8c653777942e6b0366113ca40dfa37c
Change-Id: Id3804e6cfa97b4cdde212b8eebc413f76fa4772c
2013-01-07 20:06:29 -08:00
Xiaojun Bi
28de7223e6
Merge "[mdfp] Refactoring Gesture Floating Preview Text Code"
2013-01-07 17:12:35 -08:00
Xiaojun Bi
d52730a2d7
[mdfp] Refactoring Gesture Floating Preview Text Code
...
This change moves gesture preview text code from PreviewPlacerView.java
to separate classes.
Change-Id: Id8d17eff38e714c3b06aafd0b24985a9bd2d2f52
2013-01-07 10:39:23 -08:00
Tadashi G. Takaoka
f90fc105ab
Simplify singleton class initialization
...
Change-Id: I16a27f2ed6ea66184bfdc9903180372cd7ea2fd1
2013-01-07 19:05:31 +09:00
Ken Wakasa
b6ca354431
Small code cleanups
...
Multi-project commit with I249d5fbe
Change-Id: Ia28c4e970992aa1299a30e604eaa5d096655c3a5
2013-01-07 12:13:42 +09:00
Jean Chalard
f677681330
Fix double input of chars typed on a h/w keyboard
...
Bug: 7939324
Change-Id: I11b7af54893cb645f8a06266a0b0ba95dd0b02f9
2013-01-07 10:03:20 +09:00
Kurt Partridge
f77dd424b0
[Rlog27] Refactor LogBuffer
...
Cleanup and prepare for replaying
Change-Id: Ie09e912c6e9c0d7375168c575ccf1cfd9375dd31
2013-01-03 16:36:32 -08:00
Jean Chalard
864db4b0da
A small simplification.
...
It's useless to setAutoCorrection(getTypedWord()). Every time the
contents of the word composer are altered, the auto-correction is
reset, and at use time if it's null then the typed word is used
anyway.
Change-Id: I0870657a1ab3f456f376995b27e70703f7a5d23a
2012-12-28 14:41:28 +09:00
Jean Chalard
997cba7dec
Start committing hardware events (B4)
...
Essentially this does activate auto-correction with a hardware
keyboard, although a lot of things are still left to implement.
No proximity is used yet which means only missing and excessive
letters are considered. Dead keys are not handled. No combiner
is supported. No suggestions are displayed. Resuming suggestions
does not work correctly with a hardware key (because the view
holds a temporary hardware event 'onKeyPreIme' and the event
from the IME won't be handled until this is handled which won't
happen until after the IME said that it did handle the event).
Bug: 5037589
Change-Id: Idcb5c7b26d56717ed772d53c062362807f11cdae
2012-12-27 16:17:49 +09:00
Tadashi G. Takaoka
f483225397
Get rid of current subtype and system locale cache from SubtypeSwitcher
...
Bug: 7675452
Change-Id: I2121f56964b6d25e8d40f5b8ec67eeae527b2117
2012-12-27 12:00:38 +09:00
Kurt Partridge
4aff3bf0ea
Clean up unnecessary uses of toString()
...
Leftover from changing variables from CharSequence to String
Change-Id: I4db43fcb075aa37bf9c5b2a23bad0e4c2d718379
2012-12-23 18:42:06 -08:00
Kurt Partridge
f763dc5915
[Rlog24] ResearchLogger detect word boundaries in callers above commitText
...
multi project commit with I5847d4aba97a7224ae170a7153811c5a11816449
Change-Id: Ie6fbf6f19f0193451fe6f3ddf9d4ef1637a35db1
2012-12-23 12:33:16 -08:00
Kurt Partridge
13b1be988d
Merge "Log LatinIME.commitCurrentAutoCorrection()"
2012-12-23 11:47:47 -08:00
Kurt Partridge
226377e65a
Log LatinIME.commitCurrentAutoCorrection()
...
Change-Id: Ic46c91374ae0177cafad4579d28d6980af0d8d3a
2012-12-22 17:32:12 -08:00
Kurt Partridge
ab9f4fd359
Merge "[Rlog7] ResearchLog improve gesture tracking"
2012-12-22 11:50:46 -08:00
Kurt Partridge
f1ce54891f
[Rlog7] ResearchLog improve gesture tracking
...
- count how many times a gesture is deleted
- count num chars entered by gesture
- change name of fns to reflect capturing gesture information when setting composing text
Change-Id: I1b8ebf9cfcf304e0efd827c8b8e28a4010199728
2012-12-21 12:33:54 -08:00
Jean Chalard
cff28c5d5d
Add skeleton classes for hardware event flow (B1)
...
Bug: 5037589
Change-Id: Id8eea0e2bd00dd339a1efb4b0542e4c091a84195
2012-12-19 17:47:29 +09:00
Kurt Partridge
ce8b139124
Merge "[Rlog5] ResearchLogging change from onFinishInput to onFinishInputView"
2012-12-18 11:34:34 -08:00
Kurt Partridge
8432c1317a
Merge "[Rlog3] improve stat recording"
2012-12-18 09:54:05 -08:00
Kurt Partridge
606058f777
[Rlog5] ResearchLogging change from onFinishInput to onFinishInputView
...
Change-Id: I7d3bcfe647249e0b8a14ac3d67460c2684f16d8c
2012-12-17 21:39:54 -08:00
Kurt Partridge
48160f9d84
[Rlog3] improve stat recording
...
Change-Id: Ie3b70e6eadc2a9af5ef45ddfad6a3398cea7bfe8
2012-12-17 17:08:47 -08:00
Tadashi G. Takaoka
f21a491ad8
Show last valid suggestions when gesture typing gets no suggestion
...
Bug: 7679566
Change-Id: Ie68c7698144c7576b5814ee35664309bcfdcbf0f
2012-12-17 16:19:10 +09:00
Tadashi G. Takaoka
b808188b2f
Show last valid suggestions when tap typing gets no suggestion
...
Bug: 7872809
Change-Id: Ib5a255de7968aba214249c1b934327d248a15efd
2012-12-17 14:32:18 +09:00
Ken Wakasa
8c15e91344
resolved conflicts for merge of d48d6fee
to master
...
Change-Id: I21141956135debe737453dba87617671b1716d0a
2012-12-15 09:44:39 +09:00
Jean Chalard
18d688c94b
Use the amended user dictionary word for insertion
...
When the user edits a word before adding it to the user
dictionary, the keyboard should replace whatever was
committed before with the amended version.
Bug: 7725834
Change-Id: I1a417be6c5a86d6a96bc2c76aca314ad8f1202a9
2012-12-14 20:28:22 +09:00
Tadashi G. Takaoka
edbb65be3e
Reset composing state at onFinishInputView
...
Bug: 7709817
Change-Id: Icac0b8cb28209d98d291d8f00be55e33af5bf696
2012-12-14 17:48:13 +09:00
Tom Ouyang
fa2d543785
Refactor more keys menu framework (part 1)
...
Eliminate use of slower popup window for rendering the more keys menu and more suggestions menu.
These menus are now drawn directly on the preview placer view.
Change-Id: I40638724a6ffde2be4b5d0341d2a5db7ff7be930
2012-12-07 16:34:25 -08:00
Tadashi G. Takaoka
8e2b34cdb2
Cancel batch input when orientation has been changed
...
Bug: 7665231
Bug: 7662486
Change-Id: I7b6095026dbf1b9b2f6d3b29f2ab83c462ab374e
2012-12-06 14:24:05 -08:00
Jean Chalard
2da8866518
Remove a couple Eclipse and Android Lint warnings
...
Change-Id: I0c29c5d2abcbf80759b996d34b534deb083cd7d3
2012-12-06 21:30:51 +09:00
Ken Wakasa
2b6a1fed76
Method/variable/resource names clean up for the double-space period
...
bug: 7664717
Change-Id: I914aa588b863c442c2d360221e3fa0f4c42640e7
2012-12-05 12:40:10 +09:00
Ken Wakasa
139bd83f0c
Add a new option for the double-space period functionality
...
bug: 6934756
Change-Id: I94b2d08cac6533e96031d8e97f347e9b5fd72859
2012-12-04 15:27:22 +09:00
Tadashi G. Takaoka
b5fc0e02d0
Cancel update batch input timer when gesture typing has been canceled
...
Bug: 7594165
Change-Id: I9dc42919bd196c249c79668570004d3f541cc9ec
2012-11-30 16:30:56 +09:00
Tadashi G. Takaoka
85e397cd10
Set additional subtypes before getting current subtype
...
Bug: 7594188
Change-Id: I1977acb7189f8eb186b9b20a3e5b64b4aaabf191
2012-11-28 14:49:38 +09:00
Tadashi G. Takaoka
b3f789799a
Cancel gesture typing by sliding out from keyboard
...
Bug: 7594165
Change-Id: I7849d763e49b57716e8418fb8b6f90eca3a5d2ec
2012-11-22 17:49:56 +09:00
Jean Chalard
e36af707c8
resolved conflicts for merge of b7e6bbae
to master
...
Change-Id: Ic02809190721472d138532d2189328519117e042
2012-11-21 13:07:31 +09:00
Jean Chalard
ec60d60078
Only add spaces automatically when appropriate.
...
Correctly check the variations to determine if we should
add automatic spaces (in manual picks and gestures) or not.
Bug: 7164981
Change-Id: I19e25af839b4062c217113cd804b1473912f22a5
2012-11-19 19:47:40 +09:00
Ken Wakasa
41a2c10e72
resolved conflicts for merge of 4ad92578
to master
...
Change-Id: I29ad9f0ba357e39889e30c9ebfcf61f9d08ee4ef
2012-11-17 11:33:48 +09:00
Ken Wakasa
f9ff4fb5da
Merge "Revert "Only add spaces automatically when appropriate."" into jb-mr1.1-dev
2012-11-16 18:00:15 -08:00
Ken Wakasa
5986931fcb
Revert "Only add spaces automatically when appropriate."
...
This reverts commit 6ce66d1c7d
Change-Id: I90004a5fea0bc7999ecf8742f883ff4dac264d8a
bug: 7565414
2012-11-16 17:49:22 -08:00
Marco Nelissen
ea23a28557
resolved conflicts for merge of 6f42cf1d
to master
...
Change-Id: I054bb0cfba9de06473100010a76e2f3d9c2c1180
2012-11-16 11:23:33 -08:00
Jean Chalard
191d49ae8a
Merge "Only add spaces automatically when appropriate." into jb-mr1.1-dev
2012-11-15 19:09:04 -08:00
Jean Chalard
6ce66d1c7d
Only add spaces automatically when appropriate.
...
Bug: 7164981
Change-Id: Id672104a0fda99c52923913fb0e40c3a1ead4787
2012-11-15 17:57:16 +09:00
Tadashi G. Takaoka
0dfb89b41e
am eea28db3
: am d4886ff5
: am 929bfdd0
: Merge "Update shift state only when input field is restarted" into jb-mr1.1-dev
...
* commit 'eea28db3333a734bf73e688b8335245929d5f322':
Update shift state only when input field is restarted
2012-11-14 16:34:42 -08:00
Tadashi G. Takaoka
929bfdd059
Merge "Update shift state only when input field is restarted" into jb-mr1.1-dev
2012-11-14 16:29:43 -08:00
Tadashi G. Takaoka
d0725a6842
Update shift state only when input field is restarted
...
Bug: 7482766
Change-Id: Ifdfa110c44b95acfbcd3e0aa34f675c70b7d7285
2012-11-14 18:44:43 +09:00
Tadashi G. Takaoka
4a3d4620fc
Merge "Fix language switch key behavior"
2012-11-14 01:42:12 -08:00
Tadashi G. Takaoka
d62be28515
Fix language switch key behavior (DO NOT MERGE)
...
Bug: 7075923
Change-Id: If139411db4aa65eed64337bf2a79387cfcd04496
2012-11-14 18:29:01 +09:00
Tadashi G. Takaoka
1931c1cab1
Fix language switch key behavior
...
Bug: 7075923
Change-Id: I306e1ff5d9f873541e84e1fafb64b9473947f623
2012-11-14 18:27:00 +09:00
Jean Chalard
80d7d32424
am d2116eb2
: am 7d34763e
: am fac619a3
: Merge "Don\'t restrict reset composing state to non-identical setText" into jb-mr1.1-dev
...
* commit 'd2116eb2ea7d08e81b7efe5e342772ffcd8a7efc':
Don't restrict reset composing state to non-identical setText
2012-11-12 23:48:20 -08:00
Jean Chalard
1b909c2846
Resolve conflicts for merge of 3a9ba17f
to master"
...
Change-Id: I8a1a84a81745a708f63e4211267c4afc3a6b8e49
2012-11-13 16:34:23 +09:00
Jean Chalard
fac619a34c
Merge "Don't restrict reset composing state to non-identical setText" into jb-mr1.1-dev
2012-11-12 23:00:12 -08:00
Jean Chalard
0e84041bf7
Refactor all phantom-space-inserted spaces in one place
...
Bug: 7164981
Change-Id: If1635c212b2d5d9cf51f5fb074f3b20dd7ec7b2a
2012-11-13 12:53:55 +09:00
Jean Chalard
61cc2a3391
Don't restrict reset composing state to non-identical setText
...
Bug: 7497063
Change-Id: Ifbd5c37408131867458fd921bdef46ef90d81478
2012-11-12 18:34:18 +09:00
Tadashi G. Takaoka
eaaee28647
Merge "Enhance ImfUtils to InputMethodManagerWrapper class"
2012-11-11 22:43:07 -08:00
Tadashi G. Takaoka
6fbbab3b84
Enhance ImfUtils to InputMethodManagerWrapper class
...
Change-Id: I6ff86ee819a446dd3ed5f9c3400d23564027b020
2012-11-12 15:23:43 +09:00
Jean Chalard
01d47b8096
Fix a logic flaw.
...
This test is seriously wrong : although we do have a method that
does exactly the right thing, this looks at a very specific, unrelated
variable state in hope it happens to be set only in the relevant
cases by the play of logic.
I don't think this changes anything concretely, as the assumption
was probably true in the practice ; still, this code is very hard to
read and prone to unexpected breakage.
Change-Id: I77ab576f90762429fcc752df31ed30e1c81871dc
2012-11-09 19:16:37 +09:00
Ken Wakasa
710d06cea9
Suppress dictionary pack support when IS_EXPERIMENTAL is true
...
Change-Id: If8813cb989c1fa8744a3bf36e8514ced3c8f46a3
2012-11-09 15:03:31 +09:00
Ken Wakasa
43f579e9f6
am 4eef5101
: am aa5d6fe0
: am 9cc22c45
: am 5d2556b9
: Reset the IME if requested by the app.
...
* commit '4eef51016adc4e103fa65d944a0ab31527ddced8':
Reset the IME if requested by the app.
2012-11-08 06:22:02 -08:00
Ken Wakasa
5d2556b932
Reset the IME if requested by the app.
...
Specifically, reset the KeyboardState to the main Alphabet layout in
LatinIME.onStartInputViewInternal() if a keyboard layout set doesn't get
reloaded in the method.
Please note TextView.setText() calls up resetInput(), then the IME should
reset with it.
bug: 7482086
Note that bug: 6851364 needs to be revisited.
Change-Id: I5d448c10963d3dd952dd13cb587085ec7b014e69
2012-11-07 01:09:26 +09:00
Tadashi G. Takaoka
24ab8055aa
Move isInvalidCordinates() method to Constants class
...
Change-Id: Iad1464c299ad6055af1db1ff7978e5cd9a14750f
2012-11-01 13:12:58 +09:00
Tadashi G. Takaoka
c7318bbc0b
Fix possible NPE
...
Bug: 7398904
Change-Id: I6b7aba7a9bf52ca494cb4390b19525c98790bd49
2012-10-29 18:40:37 +09:00
Tadashi G. Takaoka
240871ecaf
Move code point constants from Keyboard to Constants class
...
Change-Id: Iee01d4d2b916d0b584531104ac865ae6e6370a3d
2012-10-29 16:04:20 +09:00
Satoshi Kataoka
6067b9e1bd
am ef5f88f3
: am 5e118c4c
: am 60dea36d
: Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN
...
* commit 'ef5f88f33e432284c958fafe18f891a10f77e1f9':
Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN
2012-10-25 19:31:27 -07:00
Satoshi Kataoka
60dea36daf
Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN
...
Bug: 7393485
Bug: 7272829
Change-Id: I873e8d99486c734e76484526631a90fc55e91c86
2012-10-25 20:00:46 +09:00
Jean Chalard
751f3dc0e1
am 6fe6f38d
: am d39e6435
: am f960eb18
: Don\'t put spaces after characters that don\'t take one
...
* commit '6fe6f38d8af09b24e40a6e01eae919820cd04c16':
Don't put spaces after characters that don't take one
2012-10-22 21:46:43 -07:00
Jean Chalard
f960eb186d
Don't put spaces after characters that don't take one
...
Bug: 7393639
Change-Id: I1245a7b5077e554642838d6856ce269ca7f91988
2012-10-23 12:28:28 +09:00
Tadashi G. Takaoka
7f77aed507
Merge "Replace useless CharSequence to String"
2012-10-22 14:27:35 -07:00
Tadashi G. Takaoka
15f6d4ae34
Add @UsedForTesting and @ExternallyReferenced annotations
...
Bug: 7268357
Change-Id: I0b7e0c19f04af9ae30874d0a4c26ad81bc80be8c
2012-10-22 11:18:43 -07:00
Tadashi G. Takaoka
bc464e2952
Replace useless CharSequence to String
...
Change-Id: Idc478f901185ee1b4912acc82d0cbc54fee4e991
2012-10-22 11:03:28 -07:00
Tadashi G. Takaoka
8e360c68f1
Move AudioAndHapticFeedbackManager from LatinIME to KeyboardSwitcher
...
Bug: 7313372
Change-Id: I9bd3275f57ed3f5c2c4a95768443af505513ee97
2012-10-17 19:39:16 -07:00
Jean Chalard
c5dc32ac59
am b37e87e7
: am 63b3fc0d
: am 15142588
: Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev
...
* commit 'b37e87e7d50725f20a6b2f8484fc25cc7db3134f':
Have "no whitespace before cursor" upon gesture trigger phantom space
2012-10-16 18:12:50 -07:00
Jean Chalard
1514258824
Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev
2012-10-16 18:06:11 -07:00
Jean Chalard
e91d495c53
Have "no whitespace before cursor" upon gesture trigger phantom space
...
Bug: 7359291
Bug: 7357758
Bug: 7197651
Change-Id: Ia805a87e922739ae0a06978a3bf00d91c94b6c51
2012-10-17 09:36:07 +09:00
Jean Chalard
fa3d984d1b
am 60211f0d
: am 2631fe4c
: am 6686e63f
: Honor automatic shift turned off for gestures
...
* commit '60211f0d250ca931788d32d5a69c880f75ef7d49':
Honor automatic shift turned off for gestures
2012-10-16 17:28:18 -07:00
Jean Chalard
6686e63f21
Honor automatic shift turned off for gestures
...
Bug: 7354129
Change-Id: Ia02336e8cea2f04b629edbe74b7815cce0d7fad6
2012-10-17 05:41:06 +09:00
Ken Wakasa
fc62882591
Fix a small typo
...
Change-Id: I813d97b9453f8aa7aae99bd165336b1e5a81dc6a
2012-10-07 12:05:23 +09:00
Tadashi G. Takaoka
792980d4aa
Avoid calling switchToLastInputMethod when other IMEs are in effect (DO NOT MERGE)
...
Bug: 7299050
Change-Id: Ife6721a5fcbc4872bd36ffd8a8b81b04d73aebec
2012-10-06 19:01:36 +09:00
Tadashi G. Takaoka
c6ff7c42d9
Add SuggestedWords.isEmpty() method
...
Change-Id: I0fcb104a6a81aee4b99f5ee848eba7495630dc7d
2012-10-03 15:09:10 +09:00
Tadashi G. Takaoka
5f5f7825e7
am 4d009dbc
: am ace7d128
: am d445b56c
: Fix possible NPE caused while monkey test
...
* commit '4d009dbc514cd77eb22e4162e4ae7ea852e1b77e':
Fix possible NPE caused while monkey test
2012-10-02 22:44:57 -07:00
Tadashi G. Takaoka
d445b56ce1
Fix possible NPE caused while monkey test
...
Bug: 7269036
Change-Id: I9054b33ad3c8996cac3ee5f0e9c01ba8ceea4971
2012-10-03 14:33:52 +09:00
Tadashi G. Takaoka
aec5cc8476
Avoid calling switchToLastInputMethod when other IMEs are in effect
...
Bug: 7268389
Change-Id: I4d960cbf063002b4dc0ea813c966366b56c0346d
2012-10-02 17:29:15 +09:00
Jean Chalard
574b80aace
Remove debug prints.
...
Bug: 7226098
Change-Id: Ibacb740022a6af56c9d555d6797dd402a89f6ca4
2012-10-01 17:03:15 +09:00
Tadashi G. Takaoka
58fe5a421f
Fix gesture detection algorithm
...
This change also
* Introduces adaptive gesture detecting threshold for time domain in addition to length domain.
* Tunes the parameters for detecting gesture after fast typing.
* Fixes a bug in dismissing gesture floating preview text.
* Cleanup debug messages
Bug: 7218902
Change-Id: Iafccd872c6efe0c3b5ae65fa40b04c80d9f139c7
2012-09-28 22:47:55 +09:00
Tadashi G. Takaoka
a28a05e971
Cleanup: Make some classes as final
...
Change-Id: I6009b3c1950ba32b7f1e205a3db2307fe0cd688e
2012-09-27 19:03:30 +09:00
Jean Chalard
0eef4b1e6f
Merge "Add suggestion span upon starting a gesture." into jb-mr1-dev
2012-09-24 04:30:32 -07:00
Jean Chalard
6a58bb7ac9
Add suggestion span upon starting a gesture.
...
Bug: 7196761
Change-Id: If60cb809b205159ced1887f94b7caf9775fcf3bb
2012-09-24 20:25:46 +09:00
Jean Chalard
88985bfa2e
Merge "Fix a bug where the cursor pos wouldn't be tracked correctly" into jb-mr1-dev
2012-09-24 03:41:48 -07:00
Jean Chalard
72c5d32888
Fix a bug where the cursor pos wouldn't be tracked correctly
...
This would cause
Bug: 7208199
Change-Id: I8474985bfe349e1530b27bc98842937627bbe4e0
2012-09-24 19:33:42 +09:00
Jean Chalard
6efe788494
Set punctuation suggestions at start if activated
...
Bug: 7218468
Change-Id: I9f8c1f13dc26cedb95b65279a34a825021dfa72a
2012-09-24 17:27:03 +09:00
Jean Chalard
fff8613df0
Fix a race condition with shift
...
Bug: 7062092
Change-Id: Ie1984673e9ffc9291d9650ec38ce99031ad93585
2012-09-24 15:07:52 +09:00
Jean Chalard
b4e74cfc87
Auto correct on gesture when typed word is 1 char long
...
Bug: 7178462
Change-Id: I779d8ee4a957a9d1fdcc80d33257a98965dec7b8
2012-09-20 16:14:16 +09:00
Satoshi Kataoka
87cecf7db6
Log for geometric input
...
Change-Id: Ia0f0e38086b0be70cf2d04fc6fae48358f16e74f
2012-09-19 17:45:27 +09:00
Jean Chalard
e4783f95b2
Mark 2 resolved TODOS as such (A14)
...
Change-Id: Ifbb731f5c825675436d079db4ffbae657d71f8da
2012-09-18 18:49:17 +09:00
Jean Chalard
5822323514
Remove useless code (A12)
...
All this code is done inside the StringUtils or RichInputConnection
classes, where it's more logical. Since the IPC call is entirely
gone now, it's no use having these guards inside Latin IME.
Change-Id: Id324567e7458aed12b6f21d7114be3bd39725f15
2012-09-18 16:16:33 +09:00
Jean Chalard
90a9127244
Take space state into account for caps (A11)
...
Bug: 6950087
Change-Id: I8a1bca24db64b4dd54db8ac74d90cf43cbdddab6
2012-09-18 16:16:28 +09:00
Jean Chalard
252da38fcd
Take locale into account for caps (A10)
...
Bug: 4967874
Change-Id: Ic7ce7b2de088308fa00865c81246c84c605db1e5
2012-09-14 19:42:05 +09:00
Jean Chalard
a3f06baa57
Merge "Do not auto-correct upon starting a gesture." into jb-mr1-dev
2012-09-14 03:11:51 -07:00
Jean Chalard
b29efecd26
Merge "Fix a bug with open parens and some other chars" into jb-mr1-dev
2012-09-14 02:30:36 -07:00
Jean Chalard
7e4ad33a65
Fix a bug with open parens and some other chars
...
A space would be inserted after an open parenthesis if
it's typed after a manual pick.
Bug: 7167687
Change-Id: Ic49d09c34747117ccfbdbb8c66f634d88d4a45b0
2012-09-14 18:23:35 +09:00
Tadashi G. Takaoka
f035649cb6
Asynchronously look up dictionary for gesture input
...
Bug: 7149248
Change-Id: Icba2db73508b89a85828ae9e196ab618e5e6c280
2012-09-14 02:12:11 -07:00
Jean Chalard
eda096538b
Do not auto-correct upon starting a gesture.
...
We decided to revert this UI decision after negative feedback.
Indeed, if you use to gesture but tap just one word, chances
are it's because you know you do NOT want a dictionary word.
Bug: 6965241
Change-Id: I85fdfab3c1cf1d3c0fd3e95908e01bdf56bccbba
2012-09-14 17:52:54 +09:00
Jean Chalard
2427f578c8
Merge "Import TextUtils.getCapsMode to fix it internally (A1)" into jb-mr1-dev
2012-09-13 02:57:35 -07:00
Jean Chalard
9d1c73ffd8
Import TextUtils.getCapsMode to fix it internally (A1)
...
This should have on effect at all on behavior,
except an increase in performance.
Bug: 4967874
Bug: 6950087
Change-Id: Ie2b51efefe84ca767f5dc8e3b80bfef7e1faab3d
2012-09-13 17:46:39 +09:00
Jean Chalard
5ed88457bf
Make onUpdateSelection much more resilient to race conditions.
...
This is pretty much as strong as it gets. It should be
impossible to get false positives and nearly impossible to
get true negatives with this new code.
Bug: 6981089
Change-Id: Ia32ab62f89c5943f0be169b979abab652e67bf5b
2012-09-13 17:35:26 +09:00
Jean Chalard
28d765ed90
Make Latin IME aware of its surrounding text.
...
This is a preparatory change for
Bug: 4967874
Bug: 6617760
Bug: 6950087
Change-Id: I3abf8e45c0d02c42491421f108370220134b9602
2012-09-12 17:54:16 +09:00
Jean Chalard
ac25fcac71
Display punctuation suggestions on cursor move
...
...if punctuation suggestions are requested.
Fixes the symptom, but not the root cause of
Bug: 6981089
Change-Id: I683a7451c99457829cb4e5a762f43548ff89a535
2012-09-04 19:54:55 +09:00
Kurt Partridge
58eb4d9f27
ResearchLogger no longer offers option to disable logging
...
Bug: 6188932
Change-Id: I0b9474216080f3820438c09f89b0b6c6c102c69d
2012-08-30 22:51:56 -07:00
Jean Chalard
a05a0f2077
Allow Latin IME to cancel smiley-auto-correct consistenly
...
This change makes Latin IME behave consistently with regards
to other auto-correction cancellations in cases of auto-correction
cancellation after smiley-triggered auto-correction. That is,
pressing the smiley key when the keyboard signals it's about to
auto-correct will get the auto-correction there plus a smiley,
and pressing backspace will cancel the auto-correction, and
pressing backspace again will delete the smiley.
Bug: 7067593
Change-Id: Ia7eef70a5d06b8b9afa1f1fbb0ed1dbc21a3059f
2012-08-29 16:49:39 +09:00
Jean Chalard
6c70b92003
Auto-correct after smileys and gestures.
...
Bug: 6936790
Bug: 6965241
Change-Id: I1f61327eb5591960c280e425df9cd86b9c52f5d6
2012-08-27 18:54:05 +09:00
Kurt Partridge
d573bad5bd
Merge "ResearchLogging capture full n-gram data" into jb-mr1-dev
2012-08-22 10:41:10 -07:00
Tadashi G. Takaoka
9fc6af325e
Fix SubtypeSwitcher initialization path
...
This change also removes the reference of LatinIME from
SubtypeSwitcher.
Bug: 7026856
Change-Id: I78a266f3682b11f09b49bbcdcdb6aee713e6af37
2012-08-22 16:05:34 +09:00
Kurt Partridge
bf653996ea
ResearchLogging capture full n-gram data
...
- Captures complete motion data for all words in an n-gram.
- Also filters n-grams properly; if any word in the n-gram is not
in the dictionary, it is not included.
- Simplify ResearchLog to not require explicit state
- Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
about privacy.
- Moved LogUnit out from ResearchLogger
multi-project change with Ic70ccb6c2e11eb02d887821434b44daa3eb7a3e2
Bug: 6188932
Change-Id: I731d6cff6539e997874f723b68bdb0d9b651b937
2012-08-21 22:37:33 -07:00
Tadashi G. Takaoka
1f05cf6dab
Remove GCUtils utility class
...
Change-Id: Ia666aeb10c155d69763faf7f01ceca113b9b4653
2012-08-22 12:34:22 +09:00
Tadashi G. Takaoka
c3f78c9057
Remove KeyboardSwitcher reference from ResearchLogger
...
Change-Id: I671a83c19977fda358c8e8a730e22ee155f65512
2012-08-22 12:14:52 +09:00
Kurt Partridge
94e7f4bef9
ResearchLogger log RichInputConnection
...
Move many ResearchLogger data collection points to RichInputConnection.
By collecting data here, developers do not have to remember to keep the
ResearchLog consistent with calls to the RichInputConnection.
In addition, some unnecessary log points were removed, and the ResearchLogger
is now independent of LatinImeLogger.
multi-project change with I05496cfd762e9a41c42c50099143f1efc0a3d8a2
Bug: 6188932
Change-Id: I424abb2e437901262a9620255493916b7c3ff74b
2012-08-21 17:13:36 -07:00
Jean Chalard
324cc1dbe6
Merge "Tell the shift mode to the word composer." into jb-mr1-dev
2012-08-21 04:38:27 -07:00
Jean Chalard
adbd9ae105
Tell the shift mode to the word composer.
...
Bug: 6950087
Change-Id: Ifab9d6d075af398c6468d081216488712f8a53fb
2012-08-21 20:27:42 +09:00
Tadashi G. Takaoka
ac78633be2
Rename and consolidate some constants
...
Change-Id: I7863936cca18b28bf0117afcbcf544a5fd7f185d
2012-08-21 17:54:53 +09:00
Tadashi G. Takaoka
6785b90727
Remove touch coordinate from pickSuggestionManually
...
Change-Id: I33b1b4bc6fdfd263c4b2bb7125c07b4bddcf3c9f
2012-08-21 17:13:45 +09:00
Kurt Partridge
48643b0e0d
Merge "Revert "ResearchLogger log RichInputConnection"" into jb-mr1-dev
2012-08-20 10:18:40 -07:00
Kurt Partridge
adb591e75b
Merge "Revert "ResearchLogging capture full n-gram data"" into jb-mr1-dev
2012-08-20 10:18:30 -07:00
Kurt Partridge
35c11842a7
Revert "ResearchLogger log RichInputConnection"
...
This reverts commit 1964ffb3f4
Change-Id: Ie43e7ac828faa91e1824a255bb3ecf6c8222d4e8
2012-08-20 10:17:45 -07:00
Kurt Partridge
3d35908749
Revert "ResearchLogging capture full n-gram data"
...
This reverts commit 221e756fd7
Change-Id: Iefc4e4e27ddc925d4a4634627b0467bd4ee2a66e
2012-08-20 10:17:40 -07:00
Kurt Partridge
752c53760c
Merge changes I568c90d4,I4667f8f6 into jb-mr1-dev
...
* changes:
ResearchLogging capture full n-gram data
ResearchLogger to track simple statistics
2012-08-20 08:47:45 -07:00
Kurt Partridge
461f1942f9
Merge "ResearchLogger log RichInputConnection" into jb-mr1-dev
2012-08-20 08:47:33 -07:00
Jean Chalard
fb087a95f9
Fix capitalization, part 1
...
The case this fixes is typing "Ah.\n" in gmail for example
Bug: 6950087
Change-Id: Ia4bf3a57dde49b9c9d47d315e9f85b7ffc7ee6e3
2012-08-20 13:51:27 +09:00
Kurt Partridge
221e756fd7
ResearchLogging capture full n-gram data
...
DO NOT MERGE
- Captures complete motion data for all words in an n-gram.
- Also filters n-grams properly; if any word in the n-gram is not
in the dictionary, it is not included.
- Simplify ResearchLog to not require explicit state
- Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
about privacy.
- Moved LogUnit out from ResearchLogger
multi-project change with Ie2bc79fd7fe6b951b24771e94b8d4ca21989af65
Bug: 6188932
Change-Id: I568c90d4af07e7c759c1e7fc64b716bd8c7b4ae5
2012-08-17 21:44:07 -07:00
Kurt Partridge
1964ffb3f4
ResearchLogger log RichInputConnection
...
Move many ResearchLogger data collection points to RichInputConnection.
By collecting data here, developers do not have to remember to keep the
ResearchLog consistent with calls to the RichInputConnection.
In addition, some unnecessary log points were removed, and the ResearchLogger
is now independent of LatinImeLogger.
multi-project change with Ib71f841044ec1072610ab5638a5edfce29b7c05b
DO NOT MERGE
Bug: 6188932
Change-Id: I9ec7500a5b18bfe1a5a5bb1e5bf21c43351fc59e
2012-08-17 21:44:06 -07:00
Ken Wakasa
e46d12927e
Fix NPE in LatinIME.addToUserHistoryDictionary()
...
bug: 7007063
Change-Id: Ie3e2f77dcbc597dda0c0df9a970336e5aac0edba
2012-08-18 00:04:33 +09:00
Jean Chalard
e234aed428
Refresh editor info when the text field attributes changes.
...
For some reason we get a "restarting" flag from the browser
some times when the input field is different. The attributes
however are not the same, so we can detect that and reload
appropriately.
Bug: 6946793
Change-Id: I6762dae6f41db690497b026a707d9cc89c840b34
2012-08-15 18:32:59 +09:00
alanv
0538493309
Fix the build.
...
Change-Id: I744f6232e81981ab694d3d1e92bab5fd6efa46c0
2012-08-14 15:34:29 -07:00
Charles Chen
dd7f79097a
Merge "Change accessibility event type for app-driven speech." into jb-mr1-dev
2012-08-14 14:33:32 -07:00
alanv
5f312c9c15
Change accessibility event type for app-driven speech.
...
Bug: 6614400
Change-Id: I0ef309b7f3f35bf37b4664ea599c9e6ffb1a4ab8
2012-08-10 13:51:17 -07:00
Tadashi G. Takaoka
2be2d77664
Update dictionary availability at onStartInputView
...
This is a follow up of I7901c0f9489b4deb79314c2c903b138611bfd78e
Change-Id: I38c22e886db247c402a964e3ddd10b09a461151c
2012-08-09 16:09:54 +09:00
Tadashi G. Takaoka
8335c59ea7
Fix NPE and don't call UI API from non-UI thread
...
This change also reverts I29ec3e9f10484f30288fac76f0c45b3707bc2259
Bug: 6956969
Bug: 6891020
Bug: 6947253
Change-Id: I7901c0f9489b4deb79314c2c903b138611bfd78e
2012-08-09 11:55:41 +09:00
Tadashi G. Takaoka
79eefda0d3
Add SuggestInitializationListener to BinaryDictionary.resetMainDict()
...
Change-Id: I4c01f172ddb2ca60fa6e604384610c90b76e5457
2012-08-08 15:55:26 +09:00
Tadashi G. Takaoka
27e48447a4
Lingering gesture floating preview text a bit
...
Bug: 6936095
Change-Id: I873343e9aa6afdf6bdb223795f03232509b012a7
2012-08-07 13:54:42 +09:00
Tadashi G. Takaoka
0a524de3df
Separate updateSuggestionStrip from commitTyped
...
The commitTyped() called updateSuggestionStrip(), and that led to call
Suggest.getSuggestedWordsForTypingInput() even after a batch input was
started because WordComposer.commitWord() reset the batch input state.
Bug: 6932442
Change-Id: If645b1ef0343aa1e21ca71a9275b40c6c3be13df
2012-08-06 14:31:01 +09:00
Jean Chalard
8ee4b35c70
Cleanup unused code
...
The Italian dictionary has been amended to contain words that
include apostrophes, and accordingly the apostrophe is now
excluded from word separators in Italian.
This code was only used for Italian, and in the general case
it does the wrong thing; it was only needed by limitations of
the old dictionary.
Bug: 6929108
Change-Id: I7ff4615e01899a1cebed2c4c51679cd0746740fe
2012-08-04 01:15:04 +09:00
Tadashi G. Takaoka
622d6a5b1b
Using hardware accelerated drawing
...
When Canvas has been hardware accelerated, don't use offscreen bitmap.
Bug: 6872994
Change-Id: I1121f76377991692bc29ebeedbfbfa1b2a12dbb7
2012-08-03 20:46:10 +09:00
Ken Wakasa
fb955693d4
Enable hardware accelerated drawing for SoftInputWindow of LatinIME
...
Taking advantage of Ib6a8bda46223ce1153f32834daf02a820d16136e
bug: 6872994
Change-Id: I799b25b6509980dd9f039bead9bc926b42cbb040
2012-08-02 15:11:31 +09:00
Jean Chalard
f68fe7a9c9
Don't forward phantom space state on stripper input
...
Bug: 6890540
Change-Id: I923b24e3bc17e7b923be4940ad739b58dca24a1f
2012-07-31 01:48:10 +09:00
Tadashi G. Takaoka
ca57f5ba40
Move gesture preview parameters to KeyboardView attributes
...
Change-Id: Iff9d6b485e202656fc869f3ff4d94575ad2c186f
2012-07-30 20:10:48 +09:00
Tadashi G. Takaoka
47e2bf3298
Add advanced options to turn on/off the gesture trail and text preview
...
Bug: 6883053
Change-Id: I601718afb37289108b45ef68626c7c315edca35d
2012-07-30 15:54:27 +09:00
Jean Chalard
6fc72cae20
Fix a bug with autocaps
...
Port of Iece016f4
Bug: 6886405
Change-Id: I148c296d8a3841c40b6748e73ed2b0fff473b627
2012-07-27 21:09:25 +09:00
Jean Chalard
aa906c36aa
Handle correctly the restarting argument
...
Bug: 6851364
Change-Id: Ie939a43b8527a76aec213b702d3d850717f22a81
2012-07-26 21:57:15 +09:00
Tadashi G. Takaoka
941f222c21
Merge "Remove unused setProximityCorrectionEnabled() methods"
2012-07-25 19:54:40 -07:00
Tadashi G. Takaoka
c4376db0f0
Remove unused setProximityCorrectionEnabled() methods
...
Change-Id: I03aa6608ee435b36377de41684162b303740f571
2012-07-25 20:37:36 +09:00
Tom Ouyang
2f81757c3a
Add dynamic floating preview for incremental gesture recognition.
...
Change-Id: I7ba7ac24aa96a0ff19267997c5b58853079bc6dc
2012-07-25 19:40:55 +09:00
Tadashi G. Takaoka
0657b9698a
Update gesture mode state when dictionary gets available
...
Bug: 6860204
Change-Id: I840b7bf1983ab92fa4e0b180129176539e96409f
2012-07-25 16:11:53 +09:00
Tadashi G. Takaoka
369e54cc33
Add Suggest initialization finish listener
...
Bug: 6860204
Change-Id: I1e4c03c99415cd9bdea5a8556ff4093c33f0f508
2012-07-25 09:55:22 +09:00
Tadashi G. Takaoka
506259396f
Merge "Update gesture suggestions even when suggestions strip is off"
2012-07-23 03:45:21 -07:00
Tadashi G. Takaoka
7575ac7054
Update gesture suggestions even when suggestions strip is off
...
Bug: 6852483
Change-Id: I873ae0f2e3bc863e989629f8bc0cc90ee33a4920
2012-07-23 19:37:00 +09:00
Jean Chalard
c0f0ceeccf
Merge "Fix a bug with the 'add to dict' hint popping up too much"
2012-07-23 03:20:01 -07:00
Jean Chalard
491d451e38
Fix a bug with the 'add to dict' hint popping up too much
...
Not having a main dictionary is not sufficient reason to display
the hint. If the user already added the word to the dictionary then
we shouldn't be displaying it again, even if we don't have a main
dictionary for the current language.
Bug: 6829798
Change-Id: I6b081f51c82ef395fe2e394fd3167363e743ea6f
2012-07-23 18:32:13 +09:00
Tadashi G. Takaoka
259905ba90
Rename suggestion strip related methods
...
Change-Id: I942692bbc2e577482f353d875405c4658a1102fc
2012-07-23 18:04:02 +09:00
Tadashi G. Takaoka
4702671ea4
Rename SuggestionsView to SuggestionStripView
2012-07-23 15:37:43 +09:00
Tadashi G. Takaoka
c8e45ddb03
Rename LatinKeyboardView to MainKeyboardView
...
Change-Id: I8f3123b8d727c7beb72e226f80c17794f89c8b60
2012-07-23 12:11:43 +09:00
Kurt Partridge
3c233bf1a5
ResearchLogger feedback form
...
- also cleaned up RLog menu
multi-project commit with If0fd4fef89d390073e6939d5188ed5696866cb33
Bug: 6188932
Change-Id: I4f66f13bd366b4e8bde742ccd0704f812c6d33f9
2012-07-22 18:36:24 -07:00
Kurt Partridge
6b966160ac
ResearchLog refactor
...
- new package: com.android.inputmethod.research
multi-project commit with Ic0a5744f3160d13218addd589890623c0d120ffc
Bug: 6188932
Change-Id: Icf8d4a40a5725401799be6e209a640d99a5f34c4
2012-07-20 15:06:51 -07:00
Kurt Partridge
0df487678e
ResearchLogger: make logging more reliable (esp on startup)
...
Bug: 6188932
Change-Id: I692e427ba2e6da7bb15f48208304c4a034392a22
2012-07-19 09:00:21 -07:00
Tadashi G. Takaoka
10102f02af
Change the batch input methods of KeyboardActionListener
...
This change also removes the reference of SuggestedWords from
GestureTracker and KeyboardActionListener.
Change-Id: I25ef8756007986abf99a931afd665bbfe6fa387f
2012-07-18 18:53:36 +09:00
Tom Ouyang
eea34598bf
Merging minimal gesture input
...
Change-Id: Iee6ae48bb6309c2867b5d2e344fe7d86dfabd654
2012-07-13 19:32:18 +09:00
Jean Chalard
2c5cf744e5
Increase encapsulation (A118)
...
showSuggestions is only ever called by updateSuggestionsOrPredictions.
It only feels natural that, when called with a 0-sized or null
suggestion list, it clears the suggestions.
Change-Id: I5b52bc9151afca1bb6c6f0a7f81e3255add92177
2012-07-12 15:58:16 +09:00
Kurt Partridge
0d54692ce4
Merge "intentional logging"
2012-07-10 21:20:47 -07:00
Kurt Partridge
223d671ffc
intentional logging
...
- separate ResearchLog from ResearchLogger
- fix abort menu to explicitly indicate re-enabling of logging
- auto flush entries every 5s
- conform to new suggestedWords class
multi-project change with I9fe1f8fe59d5891daa4ca84af157f36fb1bb17dc
Bug: 6188932
Change-Id: I7e99390f934481c6ed9cea2b259944583edda5bb
2012-07-10 18:44:18 -07:00
Jean Chalard
5e573a1f0a
Remove a useless parameter (A91A)
...
Change-Id: I1d1758048649ef337875a5141d825569af7ad38c
2012-07-10 19:31:36 +09:00
Jean Chalard
a5bb353de9
Cleanup visibility in LatinIME (A80)
...
Many methods were public but could have been private: change them
to private. Also, add a comment above public methods that don't
come from the IMF to make it clearer why they are necessary.
Change-Id: I574154b015d09c0f8542b81763f497691afdc3c1
2012-07-10 18:05:15 +09:00
Jean Chalard
728c0cb251
Remove useless code (A79)
...
We postUpdateSuggestionStrip right away anyway - this only
makes the suggestion strip blink
Change-Id: I2ebd933e9a4c804ef1e8c62ccdaf4953a98a792e
2012-07-10 16:41:49 +09:00
Jean Chalard
09fdd30e52
Simplification (A78)
...
Change-Id: I622503af858ef419e94a17f182253cb03da00462
2012-07-10 16:41:47 +09:00
Jean Chalard
c466cd3f99
Move a test (A77)
...
Change-Id: I417bd5f1318696aaa39fee18f3e750ea5c231f6b
2012-07-10 14:24:33 +09:00
Jean Chalard
32f5384fc9
Pull up common code in the consolidated method (A76)
...
Change-Id: I3ebecec37b49e139c243cf9da8bfe491e7ddada1
2012-07-10 14:22:12 +09:00
Jean Chalard
e4498929b0
Simple refactoring (A75)
...
Change-Id: Id19efc5d279616da52667fa70326b86aba70d4a0
2012-07-09 15:06:16 +09:00
Jean Chalard
d579f1aefc
Consolidate methods that do the same thing (A74)
...
Change-Id: I6e7c3aba2b40ecefa483c9680978bc806368e96e
2012-07-09 15:06:16 +09:00
Jean Chalard
347a80f793
Tiny refactoring (A73)
...
If !mWordComposer.isComposingWord(), then mWordComposer.getTypedWord()
will always return an empty string.
Change-Id: Ife66d0abc44c743cbc30d31724e833cda168fd5c
2012-07-09 15:06:16 +09:00
Jean Chalard
7a422a0142
Cleanup again (A72)
...
Change-Id: Id3765bf9826cc2c7ca70158cda53c75dc58f51c6
2012-07-09 15:06:16 +09:00
Jean Chalard
37eaa24b5a
Simplification (A71)
...
Change-Id: I7a91d84291bea581ecc8ec5b29b9a87ccec76e7d
2012-07-09 15:06:16 +09:00
Jean Chalard
dc1b84d96c
Defer testing composition to a later time (A70)
...
This is not exactly the same logically speaking, because it's
theoretically possible that the composing state changed in between
the message enqueueing and it's retrieval. However in the practice,
if the composing state changed the message *must* have been
cancelled and resent, else the behavior breaks. So this actually
is more robust, and removes some obscure requirements on the
calling code.
In the practice, it should also make the cancelUpdateSuggestionStrip
message useless, although this change does not yet remove it.
Change-Id: I75141920ce64e38e2f92e9c02b6c979936eee9a9
2012-07-09 15:06:16 +09:00
Jean Chalard
a6757f400a
Code simplification (A69)
...
Change-Id: I2a77e437795fbbea47fd2e604ee6c26f8d0e458a
2012-07-09 15:06:16 +09:00
Jean Chalard
8f9c9377fc
Consolidate two methods (A68)
...
Change-Id: I4b91414190b3786065ebd962a76299b605e5797e
2012-07-09 15:06:15 +09:00
Jean Chalard
146bd2e456
Pass the value we really want to pass to update functions (A67)
...
Change-Id: Ica9b875d119dea2f8dc237fd63e5b4eaa5e1c400
2012-07-09 15:06:15 +09:00
Jean Chalard
60dbe0be43
Preparative change to pass a boolean with known value (A66)
...
Change-Id: Iff03fe7c4a8eec17c00a2fe99197e0cf21a0630a
2012-07-09 15:06:15 +09:00
Jean Chalard
853f4221ab
Merge "Remove useless processing (A65)"
2012-07-08 23:05:11 -07:00
Tadashi G. Takaoka
36311cacd6
Merge "Extend onTextInput to be able to inject suggestions"
2012-07-06 03:40:03 -07:00
Tadashi G. Takaoka
4be03befe3
Extend onTextInput to be able to inject suggestions
...
Change-Id: I1061da0edfdb05c64c5711717d4ef9fa9681e568
2012-07-06 19:36:11 +09:00
Jean Chalard
a3dee0d062
Merge "Fix a bug where spaces would be forgotten"
2012-07-06 02:09:28 -07:00
Jean Chalard
4fde56b818
Fix a bug where spaces would be forgotten
...
Bug: 6785706
Change-Id: Ic7bf242ef058d116b986d47ad197b6d2802e2342
2012-07-06 17:51:10 +09:00
Jean Chalard
8e36e5102e
Remove useless processing (A65)
...
We just resetted the composing state - updating suggestions
is sure to yield no results. We may as well not call
updateSuggestions at all.
We should however still cancel any lingering timer from a
previous input field, to avoid this useless processing.
Change-Id: Ic1a19d577903d792bb797c837cc517ea8d430e75
2012-07-06 16:28:42 +09:00
Jean Chalard
449be371ae
Refinement (A64)
...
Change-Id: I7c16e28ffce4fe0965b756bf2b00ee63b77dd039
2012-07-06 16:28:42 +09:00
Jean Chalard
43193ad60f
Remove useless code (A63)
...
If the separator is not a space, then we will always call
setPunctuationSuggestions and reset the suggestion strip anyway.
If the separator is a space, then the cursor has a space on
the left, which means isCursorTouchingWord depends only on
whether it touches a word on the right. If we were displaying
the "add to dictionary hint", it means a suggestion was just
chosen, so it had to be displayed, and that requires a composing
word and no non-separator at the right of the cursor.
In the end, if we go through this postUpdateSuggestions call,
we are sure we will reset the suggestions later in this method,
either by calling postUpdateBigramPredictions, or
setPunctuationSuggestions.
Change-Id: I95d5f77a5d0ac6d1a6ced8d67d6ac8f650db4a32
2012-07-06 16:28:42 +09:00
Jean Chalard
8ba33c1a49
Simplification (A62)
...
Change-Id: I606270a0387787445b7cd6b94e4830bfc144b49e
2012-07-06 16:27:55 +09:00
Jean Chalard
66a2e96fb4
Remove useless code (A61)
...
Just after this, clear() will be called, removing the suggestion
strip from the screen. It will later be displayed again through
onStartInputView, which will update its content.
Change-Id: I15c23ad2adecab76b0791d7fc222d15b6533f3bd
2012-07-06 13:07:48 +09:00
Jean Chalard
b1dc8ad5f2
Simplification (A60)
...
Change-Id: I99e912d3edfc7dd3f17ee835331d5fcba976750c
2012-07-06 13:07:48 +09:00
Jean Chalard
663dbfd1cc
Simplification & UI improvement (A59)
...
The responsivity is better like this. This does not seem to
feel slow as the previous comment seemed to indicate.
Also remove a stale comment.
Change-Id: I4e7bf9fe28716e112db182e44b3fa88ee4526bb4
2012-07-06 13:07:48 +09:00
Jean Chalard
746e014eb5
Show predictions in the right cases (A58)
...
After reverting an auto-correct we always have a separator after
the previously inserted word, and the cursor is never touching
a word. Showing predictions is the right thing to do, while
calling postUpdateSuggestions will invariably yield an invariably
blank suggestion strip, which is not very helpful.
Likewise, after we pick a suggestion, we should be showing the
predictions unless showing the addToDictionary hint. There was
a bug here in the corner case that the word would be a candidate
for user dictionary, but the user dictionary provider is not
available: in this case we should be showing predictions, but
we were showing an unhelpful empty suggestion bar.
Change-Id: I287bb5eb4af762bd5a433e85e185fab6d203e91a
2012-07-06 13:07:48 +09:00
Jean Chalard
0e9e7e337d
Cleanup (A57)
...
We stopped cancelling manual picks a few weeks ago. This code
is dead.
Change-Id: I4032fcc3c95e9379f1839fe860a1b8a9bd7d0bc7
2012-07-06 13:07:30 +09:00
Jean Chalard
29eeef75ec
Merge "Fix a bug where the caps mode would not be changed"
2012-07-05 19:11:28 -07:00
Jean Chalard
f254e3fec7
Fix a bug where the caps mode would not be changed
...
Bug: 6766059
Change-Id: I378f9d35c4904c4f373260bda5863235d833eb31
2012-07-06 11:08:20 +09:00
Jean Chalard
d81e7d24d3
Simplification (A56)
...
If suggestion and prediction messages both happen to be in
the queue, the latest one will win (update the suggestion strip
later than the other, overwriting any previous suggestions).
So when we enqueue either one, it is always safe to cancel
all messages of both types.
Change-Id: Iad9dd06d08c49f60cac16b88edcc9531a18ec02e
2012-07-05 18:19:51 +09:00
Jean Chalard
414f14436e
Remove an unused method (A55)
...
Change-Id: I9974b88923b85cd6bec74f7607067c660f36f040
2012-07-05 18:10:37 +09:00
Jean Chalard
c84f178cd9
Merge "Remove a useless method, rename another. (A54)"
2012-07-05 02:05:50 -07:00
Jean Chalard
792e7ddc24
Merge "Remove a redundant test (A53)"
2012-07-05 01:57:04 -07:00
Jean Chalard
9636735c0a
Merge "Small simplification (A52)"
2012-07-05 01:56:55 -07:00
Jean Chalard
21524c755c
Merge "Put some more code in common (A51)"
2012-07-05 01:50:44 -07:00
Jean Chalard
71d7fc91b7
Merge "Pull up a common variable into the wrapping method (A50)"
2012-07-05 01:47:59 -07:00
Jean Chalard
ac3ad6ef9f
Merge "Factorize some common code (A49)"
2012-07-05 01:45:08 -07:00
Tadashi G. Takaoka
15d3532170
Merge "Fix tab key's navigation behavior"
2012-07-05 01:24:00 -07:00
Jean Chalard
3d8e7a62fc
Remove a useless method, rename another. (A54)
...
Change-Id: If36b5375b04f68deeb72bcece3cb8d37aed57f59
2012-07-05 17:22:15 +09:00
Jean Chalard
0783366036
Remove a redundant test (A53)
...
Change-Id: If711074fdcb586e35d02e421c845f2c9024ca718
2012-07-05 17:22:04 +09:00
Jean Chalard
4cba560dbb
Small simplification (A52)
...
Change-Id: I56bc5b9b584de5a14b41fc32c19f7fefb3b12e88
2012-07-05 17:22:00 +09:00
Jean Chalard
ea80794dd4
Put some more code in common (A51)
...
Change-Id: If1589e29728df20713c75e08df7f47f0de9202d4
2012-07-05 17:21:55 +09:00
Jean Chalard
cbfd2e1fdb
Pull up a common variable into the wrapping method (A50)
...
Change-Id: I0b62098308169b5c44ced25ffb902766e3732fbf
2012-07-05 17:21:51 +09:00
Jean Chalard
7ed22f1f72
Factorize some common code (A49)
...
Also add some comment to clarify what's happening inside those
methods
Change-Id: I5b9b1e105b3145f0b050f35d12c5b6ca6e4a4d8c
2012-07-05 17:21:44 +09:00
Tadashi G. Takaoka
b28934adac
Fix tab key's navigation behavior
...
Bug: 6435484
Change-Id: Iffe459c117ad438e96ec6f5c7e64fb80b32d227e
2012-07-05 16:57:14 +09:00
Jean Chalard
e47c728dd5
Add a wrapper to updateSuggestions / Predictions (A48)
...
The goal is to have those converge, as they contain almost 100%
duplicated code.
Change-Id: I6921791d47efce9fb396efd9626839d706664a91
2012-07-05 11:10:04 +09:00
Jean Chalard
7b40c68277
Refactoring which will help with future changes (A47)
...
Change-Id: Ibc2d28f9f95966f77d4d7bdf9ae4688baaed5989
2012-07-05 11:10:02 +09:00
Tadashi G. Takaoka
5c641a9f59
Remove WordComposer.add(int, int, int, KeyDetector) method
...
Change-Id: Ie6af46acba18a2d1cf3ddd1578d60ded4c90f89a
2012-07-04 17:29:47 +09:00
Jean Chalard
aba432bf8d
Remove a duplicate method (A36)
...
Bug: 6705473
Change-Id: Ib6260034b09739b60071e90a018b2dc6be3815d7
2012-07-02 12:12:16 +09:00
Jean Chalard
0a63111821
Remove a useless parameter (A29)
...
Change-Id: I52625e707abf61da9b95e542f0814c66b532f483
2012-06-29 17:00:56 +09:00
Jean Chalard
f4267c0521
Fix a small bug (A27)
...
TypedWordValid and AllowsToBeAutoCorrected are almost the
same thing; the difference is whether the word is also a
whitelist entry or not. In this case, TypedWordValid was
the right one to test.
Change-Id: I695fe5b9f6bbe9d3ba314c646da3a25742c9f4ed
2012-06-29 17:00:56 +09:00
Jean Chalard
305326e789
Refactoring and add debug prints (A9)
...
Change-Id: I46497bff107f0def0dfa2b043b20d9a0b0cde040
2012-06-29 14:24:54 +09:00
Jean Chalard
b5afd3de0c
Remove unused stuff.
...
Change-Id: Ifd0d5b6978f76b841574a6e10157c32d0cd656b6
2012-06-27 17:44:16 +09:00
Jean Chalard
05efe576f9
Cleanup the dictionary type.
...
Stop storing an int in each of the different class types, and
just store a string in the top class.
Change-Id: I2af1832743e6fe78e5c1364f6d9cc21252bf5831
2012-06-27 17:31:09 +09:00
Jean Chalard
28eeb35d14
Merge the interface of two methods that do the same thing (A9)
...
Change-Id: Ia5701d713d0fd5bb646b54a03a1a5602dad0a9e6
2012-06-26 16:55:09 +09:00
Satoshi Kataoka
2cf265b345
Merge "Fix possible NPE from a concurrent problem in LatinIME"
2012-06-21 22:16:48 -07:00
Jean Chalard
1b71ff00a2
Merge "Update an outdated comment"
2012-06-20 20:18:51 -07:00
Jean Chalard
e8bb8351d6
Cleanup, part 9 (C9)
...
Change-Id: Ifb15553824915d0634aea83689302c2418b093f3
2012-06-21 09:22:32 +09:00
Jean Chalard
ca6b7d5265
Cleanup, part 8 (C8)
...
Change-Id: Iecc9b3d43c191614c2951408e14085cb77eefd4d
2012-06-20 03:45:40 +09:00
Jean Chalard
2f3a694e29
Cleanup, part 7 (C7)
...
Change-Id: I662be9d3b31fb9e157722f38cab1e6fb8a1152ab
2012-06-20 03:17:33 +09:00
Jean Chalard
c03bd090ea
Merge "Cleanup, part 4 (C4)"
2012-06-19 09:24:25 -07:00
Jean Chalard
bd765d3355
Merge "Cleanup, part 3 (C3)"
2012-06-19 09:24:00 -07:00
Satoshi Kataoka
67b9337b6c
Fix possible NPE from a concurrent problem in LatinIME
...
Bug: 6620746
Change-Id: Icc18de92d7edc6888c712c2cf5ce479a65f8bfad
2012-06-19 03:34:45 +09:00
Jean Chalard
b0561ae980
Remove a member (B5)
...
The new call in the test ensures getCurrentInputEditorInfo actually
works.
Change-Id: I2ee407bd9927d22db537d12f339e2b977a38054a
2012-06-19 03:27:37 +09:00
Jean Chalard
fe53e5c060
Move a settings method to SettingsValues (B3)
...
Change-Id: Ibfa27bd919c92be219c4d107b3ace008ca80a19f
2012-06-19 02:52:36 +09:00
Kurt Partridge
6080f6878b
Remove non-dictionary words and digit touch data.
...
Output to the ResearchLogger is now queued and only flushed if the word
the user was working on is a dictionary word.
multi-project commit with Ic713ec00777fbdcf4a937b3c77b995257e100fc7
Bug: 6188932
Change-Id: I9de15227ff51be23083d9096f1c1b3d83802fff7
2012-06-17 15:02:15 -07:00
Jean Chalard
9b233ecef2
Cleanup, part 4 (C4)
...
Change-Id: I2821ae71ec49e4b6b512157d17b80198f74321e4
2012-06-16 10:51:04 +09:00
Jean Chalard
5475e92b3f
Cleanup, part 3 (C3)
...
Change-Id: Ib0be8dc26b6fa366a3dabeea940d466602073244
2012-06-16 10:46:18 +09:00
Jean Chalard
4a5cb5c36a
Update an outdated comment
...
Change-Id: I3d02dc8597ed14d998caeaa056813353e2d7ec1a
2012-06-16 10:34:57 +09:00
Jean Chalard
dca729fddd
Move final attributes to SettingsValues (B2)
...
Bug: 6675475
Bug: 6677394
Change-Id: I4a26efb9226d3f909f331c4d2e47cd83a05c011e
2012-06-16 08:01:09 +09:00
Jean Chalard
3d44f489b3
Inline a method for simplicity (B1)
...
This has a confusing name and is a one-liner
Change-Id: I954a648a8413e38a535c2b81e4b171e1bdc9f1c2
2012-06-16 03:18:00 +09:00
Jean Chalard
a19c5e6380
resolved conflicts for merge of be82f297
to master
...
Change-Id: If49ca384ea0ac415a75f8ea1bad77dc6719cb04d
2012-06-15 09:03:52 +09:00
Jean Chalard
7cbd0478cf
Merge "Do not display punctuation suggestions when bigrams are on." into jb-dev
2012-06-14 14:37:13 -07:00
Jean Chalard
d5b765b3bb
Do not display punctuation suggestions when bigrams are on.
...
Bug: 6310401
Change-Id: I9d31c48e287aceedaf2f4c5129031ddb31402451
2012-06-15 06:01:09 +09:00
Jean Chalard
78573f2e8a
Fix an NPE
...
This code is temporary until we get rid of this member.
Bug: 6662963
Bug: 6667091
Change-Id: I1d970d2a97992507e86c5b94978a2543fe42b375
2012-06-15 05:47:35 +09:00
Satoshi Kataoka
d2f210dbe2
am d9c702d2
: am 5caaf1b9
: Merge "Do not add profanity to user history bigram dicitonary" into jb-dev
...
* commit 'd9c702d2ff017452f0264f2be12b6bffd6204e4a':
Do not add profanity to user history bigram dicitonary
2012-06-14 10:33:47 -07:00
Satoshi Kataoka
68c650fb2a
Do not add profanity to user history bigram dicitonary
...
Change-Id: I864c4206e3e6cde4d6ed687a9759e98901e16b9a
2012-06-14 15:15:08 +09:00
Jean Chalard
9d71748ba4
Fix an occurrence of nested batch edits.
...
This is harmless, but against policy.
Also, rework the checking code to be more readable, give more
information, and be called for all relevant methods - and not
for informative methods, which are not required to be in a
batch edit.
Change-Id: I03fa8b2e7d68a6a133f86be8a214671750c29256
2012-06-13 07:02:07 +09:00
Jean Chalard
c7564a787e
Optimization
...
This is much faster. It doesn't create messages, it doesn't post
stuff in a queue, it doesn't delay execution of other messages.
Also, it decouples the timer from the functionality of the Handler
so this can be pulled up in another change to consolidate with
mLastKeyTime or so.
Change-Id: I9044fc031373e66b9b40eee8025633613d0945dc
2012-06-13 07:02:07 +09:00
Jean Chalard
72b358aa90
Small optimization.
...
This will avoid some two-way IPC calls.
Change-Id: If9eb3e99b3d08346aadd4bbed2a1761f8c2527b9
2012-06-13 07:02:07 +09:00
Jean Chalard
e86054e5c2
Consolidate a test.
...
Stop using the numerical value, use the actual method
Change-Id: Iffa7f2d21a0471c7862afd3234cc9c5dd86feb2e
2012-06-13 03:34:58 +09:00
Jean Chalard
140adf204b
Consolidate auto-correction settings.
...
For some reason, there were several ways, not exactly identical,
to get this setting. The ones that used mAutoCorrectionEnabled
would kick in when the input field was specifying no correction,
so it would be a little strange (although harmless in the practice
because the settings set in this way would not get used later,
because the correct test would be done at that time).
Also perform a very small refactoring
Change-Id: Ica9f32b238d98009ae1852d3c1e940398f5d341c
2012-06-12 10:29:55 +09:00
Jean Chalard
2010aad741
Move two methods in a more appropriate place
...
Change-Id: I512b04e23490413a44b1ca0517102fe2d9138df3
2012-06-12 10:29:55 +09:00
Jean Chalard
a32eb27213
Move an editing method to the RichInputConnection
...
Change-Id: Ie143ad008ca8deb1c5034cb80ec1cb28a6b0682d
2012-06-12 10:29:55 +09:00
Jean Chalard
243e370fcb
Move a member call out of the way
...
Change-Id: I5da48442c0b39aaff817c3b6d067a9b13fda0643
2012-06-12 10:29:55 +09:00
Jean Chalard
747cf0435a
Move two editing utility methods to RichInputConnection
...
Change-Id: If8d03bea1b6369cb3043da6321048d052995d664
2012-06-12 10:29:55 +09:00
Jean Chalard
297e6d590b
Rename mSettingsValues to mCurrentSettings
...
...for readability. After all, it makes sense that "current settings"
is a "SettingsValues", while it's harder to understand why we'd
manipulate an object named "SettingsValues".
Change-Id: Ide9a17b970a6cc00b80b9a217f986268c739c662
2012-06-08 21:34:07 +09:00
Jean Chalard
d273697259
Move suggestion strip visibility to SettingsValues
...
Change-Id: If34112c69acd5122d87554043d87d8f4dbdf5d15
2012-06-08 21:26:25 +09:00
Jean Chalard
01e3b014bb
Accept a null input attributes for reading settings.
...
Change-Id: I11a8e1aca3541c35d2b39b27716687fcd8ff3dc6
2012-06-08 21:15:33 +09:00
Jean Chalard
4b9e6ee6fb
Move the correction mode to SettingsValue and make it final
...
At last this guy is final, at last
Change-Id: I76911f8d47493f8a1719f75fc7e949be5d7da1a2
2012-06-08 21:10:35 +09:00
Jean Chalard
3791183076
Consolidate updateCorrectionMode() calls
...
Change-Id: I43c0505e9a1652bfc568f23b787fc68a5c5e9220
2012-06-08 21:02:19 +09:00
Jean Chalard
bbbdab12be
Move some editing methods to RichInputConnection.
...
Change-Id: I8527776a4bd8236a85bb77f9791f9b76977ad181
2012-06-08 20:23:13 +09:00
Jean Chalard
e091982868
Straighten batch edits, pass 1
...
Change-Id: I73acfee9098a87b9cde8aca720586ec748b2a82f
2012-06-08 20:09:41 +09:00
Jean Chalard
02308bec63
Merge RichInputConnection with EditingUtils
...
Change-Id: I9982ff325bef56694402caef28a77683c52ccd71
2012-06-08 20:04:09 +09:00
Jean Chalard
5475b38328
Make a wrapper for the input connection.
...
The goal is to simplify the code in LatinIME.java as well as having
a handy place to put debug calls to see interaction with TextView.
Change-Id: I255227e7e7343e0c2f3dcd1f185e5020d6186732
2012-06-08 19:50:12 +09:00
Jean Chalard
67fd0c240d
Remove deprecated classes.
...
Should we maybe rename back *BinaryDict* to *Dict* in another
change for simplicity?
Change-Id: I8f7dcb78b9bdf1a13ce403a997fbb8619f2b453b
2012-06-08 17:12:15 +09:00
Jean Chalard
7214617622
Remove a slew of Eclipse warnings.
...
Change-Id: I03236386aea13fbd4fb8eaeee18e0008aa136502
2012-06-08 16:23:18 +09:00
Ken Wakasa
d418580a71
Fix typo
...
Change-Id: I264f829c1584a37995dbc5ee4ba6b6783d5d4834
2012-06-08 03:42:02 +09:00
Tom Ouyang
11dc22d964
Merge "Contacts binary dictionary updates with change in keyboard locale."
2012-06-07 01:19:44 -07:00
Tom Ouyang
2e8aa06002
Contacts binary dictionary updates with change in keyboard locale.
...
Bug: 6616436
Change-Id: I8d66a37f295134c5b9875b2a305a9be7442bd75d
2012-06-07 00:25:41 -07:00
Kurt Partridge
9b300f0caa
Merge "add research log ui control"
2012-06-06 20:47:53 -07:00
Kurt Partridge
724bc479f7
add research log ui control
...
- lets users flag a particular time in the research log
- lets users delete the log for this session
also makes the UsabilityLog setting control whether the ResearchLog logs or not.
multi-project commit with I89067e7d3b8daca7179333f1dbe82224c26920fe
Bug: 6188932
Change-Id: I89864ef3ab53b0efe1ea8d75247be08712f0c399
2012-06-06 20:42:01 -07:00
Satoshi Kataoka
91c8c4f3a7
am e08cfda1
: am 5a8d2fd1
: Merge "Cache UserHistoryDictionary for each language" into jb-dev
...
* commit 'e08cfda1ebea693c56681816076c419f23c51076':
Cache UserHistoryDictionary for each language
2012-06-06 10:48:46 -07:00
Satoshi Kataoka
5a8d2fd1d3
Merge "Cache UserHistoryDictionary for each language" into jb-dev
2012-06-06 10:43:50 -07:00
Satoshi Kataoka
a836808f8b
Cache UserHistoryDictionary for each language
...
Bug: 6603257
Change-Id: I73b65e921cff8337a00594525f67f6aec2178881
2012-06-06 20:02:00 +09:00
Tadashi G. Takaoka
876711930d
am 2eb5eb4d
: am be2fef4d
: Merge "Fix backing view height calculation in landscape orientation" into jb-dev
...
* commit '2eb5eb4d447cb326b4c10cff2cae64df4e431ffd':
Fix backing view height calculation in landscape orientation
2012-06-05 17:58:59 -07:00
Tadashi G. Takaoka
b94f4cc71c
Fix backing view height calculation in landscape orientation
...
This logic has been dropped by Ib814c07f.
Bug: 6610497
Change-Id: Id89ad3280b73a31d8c9c6826e9ee297791624db1
2012-06-05 17:41:01 -07:00
Tadashi G. Takaoka
9895b815a8
am e2832daf
: am 8cf3654a
: Merge "Use calculated backing view height instead of the view\'s height" into jb-dev
...
* commit 'e2832daf4c289f94d68c546c485fc06bbf6aefd6':
Use calculated backing view height instead of the view's height
2012-06-03 21:55:26 -07:00
Tadashi G. Takaoka
bc5b89cdff
Use calculated backing view height instead of the view's height
...
This change removes the work around that was introduced by If4f24500.
Bug: 6596131
Change-Id: Ib814c07fdac7d0aa0d7fbc2764fda1af42b82ad5
2012-06-04 12:49:27 +09:00
satok
083fb024d7
am e6560252
: am 72cd8466
: Merge "Fix NPE in user history bigram dictionary" into jb-dev
...
* commit 'e656025282c0da28ed80b2604949092dbc5fb72e':
Fix NPE in user history bigram dictionary
2012-05-31 20:29:43 -07:00
satok
4f96bb4520
Fix NPE in user history bigram dictionary
...
Bug: 6584882
Change-Id: Id0162bffc4f0f36239cdc68383f8a47d7a957397
2012-06-01 12:19:22 +09:00
Satoshi Kataoka
c5d4362b59
am 408fa1ac
: am 961e676b
: Merge "Set level 1 as the initial value of the valid words" into jb-dev
...
* commit '408fa1ac48a3eb6f378274d5dd0e490da0f453ae':
Set level 1 as the initial value of the valid words
2012-05-29 04:49:33 -07:00
Satoshi Kataoka
c88f61215c
Set level 1 as the initial value of the valid words
...
Bug: 4192129
Change-Id: I867e78ce79c78977d08e8b66881a25b6fe5bf41f
2012-05-29 20:39:39 +09:00
satok
1c69942683
am fff5cd6f
: am aa064139
: Merge "Forget user history" into jb-dev
...
* commit 'fff5cd6f767e248ecb5b30ea39cb9a22a476b953':
Forget user history
2012-05-27 23:03:46 -07:00
satok
aa0641394b
Merge "Forget user history" into jb-dev
2012-05-27 22:59:22 -07:00
satok
fd53b8cc2b
Forget user history
...
Bug: 4192129
Change-Id: Ic98398e5383093a1c24373849eadc48fc4d3626f
2012-05-28 14:34:02 +09:00
Jean Chalard
1a31b4e484
am fac23787
: am bed613cf
: Merge "Simulate hardware enter/delete events if the app targets < 16" into jb-dev
...
* commit 'fac23787bbd7723acba4e7e344aa6f799d9584f6':
Simulate hardware enter/delete events if the app targets < 16
2012-05-27 21:26:06 -07:00
Jean Chalard
4e1a558ee8
Simulate hardware enter/delete events if the app targets < 16
...
This will make text input buggy on all apps until they target
JB or superior.
Bug: 6537051
Change-Id: I726347db8c84d1582ad1962d3a910e698389e08c
2012-05-28 12:00:43 +09:00
Jean Chalard
f27ac2733c
am d45e334f
: am 7707e045
: Merge "Cache application info." into jb-dev
...
* commit 'd45e334f5a73d2cc36800a81e1bbf881e633f026':
Cache application info.
2012-05-25 04:11:15 -07:00
Jean Chalard
64766fbcaa
am 6691bd67
: am 9b93817b
: Merge "Get information about the target application." into jb-dev
...
* commit '6691bd675a555163aa59c2ac791c6138c1d8a32c':
Get information about the target application.
2012-05-25 03:34:46 -07:00
Jean Chalard
1b1243d61f
Cache application info.
...
Bug: 6537051
Change-Id: Ieca891235df0d697bdeb0510651b703654fdef38
2012-05-25 18:54:53 +09:00
Jean Chalard
b224b60c94
Get information about the target application.
...
Bug: 6537051
Change-Id: I9fe7a07b5ddf2a423d5764840753ea70544206f1
2012-05-25 18:41:32 +09:00
satok
6d6c070eba
am 925212ff
: am c54d558e
: Cancel adding user history bigram when autocorrection is cancelled
...
* commit '925212ff4b3d6ff4182a94a133c0e4a4f23dd6aa':
Cancel adding user history bigram when autocorrection is cancelled
2012-05-23 20:19:46 -07:00
satok
c54d558e2e
Cancel adding user history bigram when autocorrection is cancelled
...
Bug: 6465474
Change-Id: Ifbfe0ddc2ce5fab070939ede3db7bf03a8535a45
2012-05-24 12:11:02 +09:00
Jean Chalard
008b528cbd
am c4f66d32
: am 6c034901
: Fix an NPE
...
* commit 'c4f66d3233159ee224dd0b30dd117fe539af2be6':
Fix an NPE
2012-05-22 20:18:01 -07:00
Jean Chalard
6c0349012e
Fix an NPE
...
Bug: 6538761
Change-Id: Id85486ee93437cfec7db421d5c7f2d7980a7e32e
2012-05-23 12:05:36 +09:00
Kurt Partridge
8ccc875754
Merge "switch ResearchLogger output to json."
2012-05-22 10:32:23 -07:00
Jean Chalard
906857430b
am 37105e86
: am 09c4909c
: Merge "Remove a high surrogate after a delete if any" into jb-dev
...
* commit '37105e8636fc84f9e903581443730a0bf6692996':
Remove a high surrogate after a delete if any
2012-05-22 03:38:05 -07:00
Jean Chalard
978c96aa99
Remove a high surrogate after a delete if any
...
Bug: 6526328
Change-Id: Iae70cad7b3c114bc13af48ae0eadd52ab88e8471
2012-05-22 19:04:31 +09:00
Kurt Partridge
07cd1e1731
switch ResearchLogger output to json.
...
use multiple logging files, clean up internal nested class structure.
multi-project commit with I1813b6710ef586d96cf8936662f58b870040d6e5
Bug: 6188932
Change-Id: I438790e28f74747c4c1a48a20c1942a0fd818b6c
2012-05-21 18:45:21 -07:00
Tadashi G. Takaoka
d4577f738b
am 82ffc9fe
: am 16950d65
: Reset automatic upper case when chroding key is pressed
...
* commit '82ffc9fe5f7255c902e371bb5353bdef97205fd6':
Reset automatic upper case when chroding key is pressed
2012-05-21 14:29:59 -07:00
Tadashi G. Takaoka
865df41ba8
am 647827cc
: am 78e3977e
: Get rid of unused CODE_HAPTIC_AND_AUDIO_FEEDBACK
...
* commit '647827cc0171f7dc5d425dea5754fca3df49d036':
Get rid of unused CODE_HAPTIC_AND_AUDIO_FEEDBACK
2012-05-21 14:29:25 -07:00
Tom Ouyang
cfec078d8b
am 4bdb2bf3
: am e1128687
: Merge "Change to a binary version of the expandable user dictionary." into jb-dev
...
* commit '4bdb2bf3b9cceb99736a736de42088fcf3bd1a0f':
Change to a binary version of the expandable user dictionary.
2012-05-21 14:10:54 -07:00
Tadashi G. Takaoka
6fbb8c8fc3
am 628a5745
: am 75c60bf3
: Merge "Change auto caps mode argument to int type" into jb-dev
...
* commit '628a5745e19d227cdff2370704a4958e2791eb5a':
Change auto caps mode argument to int type
2012-05-21 14:10:50 -07:00
Jean Chalard
45befb946f
am 9ad774d1
: am 91492993
: Merge "Close batch edit" into jb-dev
...
* commit '9ad774d1f68bf3d2a4c38e5b4c3a2fa03e371eff':
Close batch edit
2012-05-21 12:44:10 -07:00
Jean Chalard
8717ad4cbd
am 79daef2e
: am 71b047e3
: Merge "Don\'t deactivate the LastComposedWord on shift" into jb-dev
...
* commit '79daef2e9b29b67048cd052b33c88675a0c62220':
Don't deactivate the LastComposedWord on shift
2012-05-21 11:52:11 -07:00
Tadashi G. Takaoka
16950d65c3
Reset automatic upper case when chroding key is pressed
...
Bug: 6501446
Change-Id: Idc3b88b5370c0d7968cc388885e9066f922cfcf3
2012-05-21 19:24:43 +09:00
Tadashi G. Takaoka
78e3977e90
Get rid of unused CODE_HAPTIC_AND_AUDIO_FEEDBACK
...
Bug: 6523953
Change-Id: Ibea6c74d00e956116f492a3bedfe40e580b4c316
2012-05-21 12:24:17 +09:00
Tom Ouyang
e1128687b1
Merge "Change to a binary version of the expandable user dictionary." into jb-dev
2012-05-18 10:05:11 -07:00
Tadashi G. Takaoka
553e2f19c1
Change auto caps mode argument to int type
...
Bug: 6501446
Change-Id: I3f7bc0fc39edd29ebf96107c3d43b9ccc9b8022e
2012-05-18 17:46:05 +09:00
Jean Chalard
d4cacb1e41
Close batch edit
...
This does the same thing as Ie30e1aff but differently
Bug: 6512086
Change-Id: I47ae990510d3f657abd45ad5f0e325d93dec83c0
2012-05-18 12:07:58 +09:00
Tom Ouyang
f6adff6227
Change to a binary version of the expandable user dictionary.
...
Bug: 6435677
Change-Id: If83409f699608d443796e64a3c65692ae81b98e6
2012-05-17 15:12:00 -07:00
Jean Chalard
125de3dfdf
Don't deactivate the LastComposedWord on shift
...
Bug: 6495116
Change-Id: Ib86de02a1216146082bf58a033982ac37fefffe1
2012-05-17 17:05:30 +09:00
Jean Chalard
848081ad8b
am 8dced70b
: Merge "Read and use user dictionary shortcuts." into jb-dev
...
* commit '8dced70b062744a2c27e0cf6dcd0787cf598a97c':
Read and use user dictionary shortcuts.
2012-05-15 11:37:54 -07:00
satok
d9c4aa83e1
am 76218b96
: Merge "Do not set "SuggestionSpan"s for suggestions from the next word predicition" into jb-dev
...
* commit '76218b966a6a712f3baa72d95c6d125d414cdbd4':
Do not set "SuggestionSpan"s for suggestions from the next word predicition
2012-05-15 11:37:52 -07:00
Kurt Partridge
0320c526c2
Merge "include text context in researchLogger"
2012-05-15 10:17:59 -07:00
Jean Chalard
8dced70b06
Merge "Read and use user dictionary shortcuts." into jb-dev
2012-05-14 20:38:23 -07:00
Jean Chalard
19ad9bf145
Read and use user dictionary shortcuts.
...
Bug: 4646172
Change-Id: I51002c73d5bad1a698110c5cda02253348be8eed
2012-05-15 12:23:43 +09:00
satok
0142b997bf
Do not set "SuggestionSpan"s for suggestions from the next word predicition
...
Bug: 6294817
Change-Id: I5010eafa5ba7e947743706adf7e722f4f0cfb415
2012-05-15 12:08:31 +09:00
Kurt Partridge
aec44d50a7
include text context in researchLogger
...
when logging LatinIME.onUpdateSelection(), now include the current word and
preceding word. no escaping of the word is performed; this is temporary
until the output format is cleaned up.
also fix EditingUtils.getWordRangeAtCursor to support supplementary
UTF-16 characters.
Bug: 6188932
Change-Id: If4612a2627537d5d8bb2f9585a3ad1b4e56c2e26
2012-05-14 09:55:26 -07:00
satok
9978953e29
am 6792a909
: Merge "Output caps debug code" into jb-dev
...
* commit '6792a909cd0da3db6a957cb2576b4d08f46a53b7':
Output caps debug code
2012-05-11 03:33:42 -07:00
satok
b6fb5eb391
Output caps debug code
...
Change-Id: I4a3399d9066bd28dab893ecebb720924110b871d
2012-05-11 17:37:14 +09:00
Tadashi G. Takaoka
46b26ed892
am c8bde75c
: Merge "Optimize InputConnection.getCursorCapsMode calling" into jb-dev
...
* commit 'c8bde75cf455c02efc57c2e35bbe446b83c23739':
Optimize InputConnection.getCursorCapsMode calling
2012-05-09 01:55:45 -07:00
Jean Chalard
9648b1674e
am d5cd7e64
: Small optimization
...
* commit 'd5cd7e64aa30096241f63e47a9169699bdd98231':
Small optimization
2012-05-09 01:55:44 -07:00
Jean Chalard
4e02b1273b
am 442ac5d0
: Merge "Don\'t ask for surrounding characters for each keypress" into jb-dev
...
* commit '442ac5d0bb96ec257d26b28df2fabefdefe59b96':
Don't ask for surrounding characters for each keypress
2012-05-09 01:55:43 -07:00
Tadashi G. Takaoka
3b0f0b57ff
am f52aef84
: Merge "Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified" into jb-dev
...
* commit 'f52aef84a582197d6f8e580044b2d24d2a710cef':
Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified
2012-05-09 01:55:41 -07:00
Tadashi G. Takaoka
c8bde75cf4
Merge "Optimize InputConnection.getCursorCapsMode calling" into jb-dev
2012-05-09 00:24:00 -07:00
Tadashi G. Takaoka
03ca17c841
Optimize InputConnection.getCursorCapsMode calling
...
Bug: 6464226
Change-Id: I30c1b01be5e1719ded5f7f8a7e24a38e9bbc3637
2012-05-09 16:19:08 +09:00
Jean Chalard
d5cd7e64aa
Small optimization
...
Change-Id: I067249976e557b60b606d2153deaeb3c8f1f38ac
2012-05-09 16:14:25 +09:00
Jean Chalard
736b109e16
Don't ask for surrounding characters for each keypress
...
Bug: 6464226
Change-Id: I03745bbcc21e5ec6ca57fa1257bf21c0cd26391a
2012-05-09 15:19:35 +09:00
Tadashi G. Takaoka
0b831ba2aa
Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified
...
Bug: 6435484
Change-Id: Iccca7d1b770c547efae0b5e5931cebd910083d40
2012-05-08 13:20:39 +09:00
Kurt Partridge
5a937aae99
Merge "record full text after finishing session"
2012-05-04 21:09:22 -07:00
Kurt Partridge
d67a248de4
record full text after finishing session
...
uses onWindowHidden() callback as proxy for finishing session.
Bug: 6188932
Change-Id: Ic63b47c946ca91fc35f80d71b2f9e24e2d0339ac
2012-05-04 10:57:50 -07:00
satok
9ec06c17d4
Fix build breakage
...
Change-Id: I22305137b336c9aab019d044a517ae8bc5fefe45
2012-05-02 18:14:40 +09:00
satok
57007ed582
Merge "Workaround return preserved backing view height when the backing view is not ready" into jb-dev
2012-05-02 01:42:00 -07:00
satok
f4cf5b9952
Workaround return preserved backing view height when the backing view is not ready
...
Change-Id: If4f24500ead516c46e6a93a95291e0897548c2f0
2012-05-02 17:40:10 +09:00
Tadashi G. Takaoka
ae2388c7f7
Fix checking if subtype belongs to this ime
...
Bug: 6422318
Change-Id: I5779c0e277444315191fa964a976dcb4316cc24a
2012-05-01 20:21:10 +09:00
Jean Chalard
551612dd9e
Fix a bug where two spaces would be added instead of one
...
Bug: 6378291
Change-Id: Id2453333ae16146f816faf0eb68baa8ea1dd106a
2012-04-23 18:15:51 +09:00
Jean Chalard
96fb3094aa
Fix a bug where a batch edit would not be started.
...
This would end up in TextView sometimes calling onUpdateSelection
multiple times (this is the correct behavior for TextView). We now
commit the space and the word in a batch edit, and we only get
onUpdateSelection once.
Bug: 6300527
Change-Id: I9579f3d8f5320c1cc24a7a42f19db8e105eb090d
2012-04-23 17:45:50 +09:00
Jean Chalard
29a1fc0f6b
Don't allow cancelling manual pick.
...
Bug: 6347202
Change-Id: I30b53256e83c534436b0f0ff594fd4aaabf4558c
2012-04-20 15:55:45 +09:00
Kurt Partridge
48a7681e06
researchLogger detail on IME sessions
...
log device type, screen size, etc. also simplification inside ResearchLogger
to use exceptions better, and fix ResearchLoggerTests to not change
preferences to specify the logfile.
multi-project change with Idfd193b16260215cca32886e288f03a0c12b2781
Bug: 6188932
Change-Id: Idd3ca6eb8e8e3934f68234b241c7fd7d0cc3bcd5
2012-04-19 20:19:55 -07:00
Tadashi G. Takaoka
6a7019ff5d
Move main dictionary availability check to LatinIME
...
Change-Id: Ib6183fec833d87bc32514b03bb691fec0a1e6ff8
2012-04-19 23:23:26 +09:00
Tadashi G. Takaoka
65e93e352f
Fix SubtypeSwitcher to honor subtype
...
Bug: 6364170
Change-Id: I31f9a7c9b6b4ca04a1c78a4210dcaae0db9825db
2012-04-19 22:42:14 +09:00
Tadashi G. Takaoka
1cb08acaf3
Add Constants class to hold public constants
...
This change also gets rid of compiler warnings about "deprecations".
Change-Id: Id9b83483c453a81ebac34b684656db05e3599657
2012-04-19 19:45:19 +09:00
Tadashi G. Takaoka
344af15674
Change predefined additional subtype format in preference
...
This change also refactor StringUtils class
Change-Id: Ie0b4d169b21c260bf238d6fcc9ab0ee8bfd6b508
2012-04-19 17:11:21 +09:00
Tadashi G. Takaoka
f5a0bd2c28
Make predefined subtype configurable by XML resource
...
Change-Id: I1f8486a1fb652f1e06789e7bfd2cc57273092234
2012-04-18 22:45:26 +09:00
Tadashi G. Takaoka
55d28fd1b2
Cleanup InputMethodManagerCompatWrapper
...
Change-Id: Id3b84ee19bb504ed8fbb398e260cc663a5b5ae0d
2012-04-18 18:01:29 +09:00
Tadashi G. Takaoka
a58ebc73ae
Fix typo of some methods' name
...
Also changes some methods' argument type from Locale to String.
Change-Id: Ib68b528a450dc68a01546483403230f76500bee4
2012-04-18 16:40:50 +09:00
Kurt Partridge
d442984e96
researchLogging for inputConnection events
...
Bug: 6188932
Change-Id: I596df68956abd879293cfb550e66e7d7d0ba74e9
2012-04-17 20:05:10 -07:00
Tadashi G. Takaoka
79e07e3f84
Remove useless key event handling methods
...
Change-Id: I8c42fba79aba643ab7a145e6fd54ef23855a3ad0
2012-04-18 11:55:11 +09:00
Tadashi G. Takaoka
69bcc15cb3
Add SubtypeUtils.setAditionalInputMethodSubtypes method
...
Change-Id: Ia3043346ed87297e01d505980555fdf29ce4f96f
2012-04-17 22:48:00 +09:00
Kurt Partridge
9bfb620215
add logPoint for manual correction (inc touch pos)
...
Bug: 6188932
Change-Id: Ibcc4901bcfab6632ee4c59cb58d35452218a288d
2012-04-16 16:52:25 -07:00
Tom Ouyang
a7352c8df4
Merge "Add a new binary contacts dictionary based on ExpandableBinaryDictionary and use locale for bigrams."
2012-04-13 18:30:19 -07:00
Tom Ouyang
18222f8c86
Add a new binary contacts dictionary based on ExpandableBinaryDictionary and use locale for bigrams.
...
Bug: 6188977
Change-Id: I753422eed1effaeb5fd01124cf1ddd1e31ee9d60
2012-04-13 17:54:39 -07:00
Kurt Partridge
2783c51e6d
Merge "clean up researchLogging of autocorrection"
2012-04-13 10:47:19 -07:00
Tadashi G. Takaoka
c206d04623
Use InputMethodSettingsFragment for IME settings
...
Change-Id: Id6d9cd0ddf99c0687b6d3ea4b2f868f6cf2a0eaf
2012-04-13 19:56:47 +09:00
Tadashi G. Takaoka
f6972561fc
Utilize InputMethodSubtype and additional subtype
...
* Remove de_QY and fr_CH from supported subtypes
* Add de-qwerty and fr-qwertz predefined additional subtypes instead.
Change-Id: I49e8ba0299529302f2b91b4d018b07304cdd6897
2012-04-13 18:36:26 +09:00
Kurt Partridge
60adb87574
clean up researchLogging of autocorrection
...
remove dependence of ResearchLogger on LatinImeLogger
for autocorrection
multi-project commit with I32cc134b
Bug: 6188932
Change-Id: Iaeda97eb43fa4782db2d1b2a6d8d09a93b395111
2012-04-12 22:59:21 -07:00
satok
cf6b2099be
Add isDictionaryAvailable to SubtypeSwitcher
...
Change-Id: I534878d330b57bbfaa8b7711082456969771f4dc
2012-04-12 19:46:02 +09:00
Jean Chalard
e6269759d6
Read the dictionary resource in a more sensical place.
...
We don't need to pass this down all the way from LatinIME any more.
It fetched be done exactly where it needs to be.
Change-Id: I9f277f9c4f9de70ae755a1334d86c67bbb24c988
2012-04-11 21:03:21 +09:00
Tadashi G. Takaoka
78ab80844b
Add language suffix to main dictionary
...
Bug: 6319377
Change-Id: Ie6a887fefa12e33c17bfeb5d22984e7c1a7bdb46
2012-04-11 16:11:34 +09:00
Kurt Partridge
9bc29d78a6
add more data collection points to ResearchLogger (attempt #2 )
...
the new points are all at Log.x() positions; only those appearing directly
related to user input were added.
multi-project change with I159f5de2
this CL is the same as I618bcd07, which was reverted because of
incompatibilities with vendor branches.
Bug: 6188932
Change-Id: I999249dceb0c04f5a4ffbfff25caed09d24a2c52
2012-04-09 09:38:07 -07:00
Kurt Partridge
d16bda4a4a
Revert "add more data collection points to ResearchLogger"
...
This reverts commit ac9e87c03e
2012-04-06 18:26:34 -07:00
Kurt Partridge
ac9e87c03e
add more data collection points to ResearchLogger
...
the new points are all at Log.x() positions; only those appearing directly
related to user input were added.
Bug: 6188932
Change-Id: I618bcd07b22c9efc794745678b073afe1e79a697
2012-04-06 09:35:13 -07:00
Tadashi G. Takaoka
11d9ee742f
Use keyboardSet extra value of subtype to specify layout type
...
Change-Id: Ice1f345a08a8d760e3b847c885c4072e3e142c97
2012-04-05 17:25:15 +09:00
Tadashi G. Takaoka
cb389ef0d6
Refactor to utilize InputMethodSubtype
...
Change-Id: I76fbc8a395eb8dab996c02c86d7328f07865f8cf
2012-04-05 12:27:27 +09:00
Tadashi G. Takaoka
d2c5533fd9
Merge "Add RunInLocale class to guard locale switching"
2012-04-03 01:53:05 -07:00
Tadashi G. Takaoka
16c6f35570
Add RunInLocale class to guard locale switching
...
Bug: 6128216
Change-Id: I8d9c75c773c3de886183b291ada7a3836295839b
2012-04-03 17:43:45 +09:00
Tadashi G. Takaoka
8f433a66b2
Fix typo
...
Follow up for I5b9964f2
Bug: 6129704
Change-Id: Ia90c013cf4c4e6f675da5701644bd10833898c3f
2012-04-03 17:27:51 +09:00
Tadashi G. Takaoka
0d1a5d5b97
Cleanup EditorInfoCompatUtils
...
Bug: 6129704
Change-Id: I5b9964f2ad52e7cd60c63acca93d0241a1e729ef
2012-04-03 16:45:36 +09:00
Tadashi G. Takaoka
13d6ecc4c2
Remove InputMethodServiceCompatWrapper
...
Bug: 6129704
Change-Id: I76f2854e27623be940a711d0d48fd3f90132141c
2012-04-03 16:02:09 +09:00
Tadashi G. Takaoka
9cc2c94c8b
Remove InputMethodSubtypeCompatWrapper
...
Bug: 6129704
Change-Id: I8f84f0f61a2205ac1fcd1cd40e3a586ee535282d
2012-04-03 15:31:26 +09:00
satok
7e518d8b83
Combine candidate words and scores
...
Bug: 5240798
Change-Id: Ie56c1c2cfd7f365e771fee88c1ed15012448feed
2012-04-02 18:39:24 +09:00
Ken Wakasa
96fdc4dd84
Remove InputConnectionCompatUtils
...
Also, small cleanup in proguard.flags
bug: 6129704
Change-Id: If4cc694dbe74b26b1d0da301bbc321ee7afc0211
2012-03-31 19:04:38 +09:00
Ken Wakasa
911b8f9d19
Remove the "deprecated" classes
...
bug: 6129704
Change-Id: Ib27f2774444e1f084b19be3fe6f56d25dffa7084
2012-03-30 16:20:56 +09:00
Kurt Partridge
347fcab043
improve ResearchLogger performance
...
also demonstrate proposed logpoint invocation
Bug: 6188932
Change-Id: Ib6a7a196fe2e5f8184d26d1e0e3e91b404454112
2012-03-29 15:37:41 -07:00
Tadashi G. Takaoka
20b4c223b4
Merge "Fix some obvious compiler warnings"
2012-03-29 00:18:36 -07:00
Tadashi G. Takaoka
8dcad2ed47
Don't send touch coordinates if proximity characters correction is disabled
...
Bug: 6225317
Change-Id: I4fa65e020d838f53066d4a071f58fb6f40583e0b
2012-03-29 16:11:54 +09:00
Tadashi G. Takaoka
c61cd79229
Fix some obvious compiler warnings
...
Change-Id: I10a634f7492b45d5a72345f14d36cf341946387d
2012-03-29 15:07:53 +09:00
Tadashi G. Takaoka
e07db71d26
Remove SupportTouchPositionCorrection from subtype extra value
...
Change-Id: Ieedff9ec212f5567405ca276b0f2194132ba7b0c
2012-03-28 19:45:28 +09:00
Ken Wakasa
c166697e3f
Optimization: Start making use of ProductionFlag.IS_EXPERIMENTAL for ResearchLogger
...
Move GodMode specific tests to relevant directories as well.
This goes along with I9dc4d469
Change-Id: I4a21c53846b26eede346cb1da13e6abbdf9ec27f
2012-03-27 11:55:23 +09:00
Jean Chalard
a77bbc64f0
Merge "Correct a shaky processing and move it to a better place"
2012-03-25 17:57:49 -07:00
Kurt Partridge
d05afa3f4c
move usability log code to new class (ResearchLogger) and clean api
...
This change also undoes the effects of I8694eb9016, which was an initial
effort built on Utils.UsabilityStudyLogs. Now Utils operates as it did
previously, for backward compatibility, but the ResearchLogger retains
the new log format.
Coordinated with I274b75c5.
Bug: 6188932
Change-Id: I41208bdc6b511f69a010c9fc38a936521beba7d5
2012-03-24 20:14:42 +09:00
Tadashi G. Takaoka
fce9ca4202
Merge "Remove verbose debug message"
2012-03-23 06:25:13 -07:00
Tadashi G. Takaoka
61f24842c7
Remove verbose debug message
...
Change-Id: I05bfe24228a6fbe806987d2a0d81e59611c3b476
2012-03-23 22:23:56 +09:00
Jean Chalard
71f9d30b18
Correct a shaky processing and move it to a better place
...
The old code would remove caps from the first letter if
auto-capsed but that makes very little sense when the word
is camel-cased. Also, it would not correctly handle
surrogate pairs, and would require a direct reference to
LatinIME and a specific method to do the processing in an
unexpected place.
Change-Id: I416d6a805242788a2473f007ca7452c9fe3f5205
2012-03-23 21:40:07 +09:00
Jean Chalard
3ee7d97587
Optimization and typo fix
...
Change-Id: Iafa414b8bcf2cca4569b3753bfac58f301a72269
2012-03-23 21:29:30 +09:00
Jean Chalard
e7cfe43652
Merge "Don't rely on spell checker proximity in tests"
2012-03-22 02:15:29 -07:00
Jean Chalard
109728193e
Don't rely on spell checker proximity in tests
...
This fixes the input logic tests that were broken and suppresses
their dependency upon the spell checker proximity. Instead, it
gets the Keyboard instance from Latin IME and uses the actual
coordinates, which results in a test run closer to what actually
happens during typing.
Change-Id: I3a81d249ee7fb3ac6ae6940aa2e8b2421e829e5c
2012-03-22 18:08:23 +09:00
Kurt Partridge
fdd68f0657
log through group level abstractions
...
For the groups:
- LogGroup.MOTION subfields now deteremined in Utils.writeMotionEvent() rather
than in LatinKeyboardView.processMotionEvent()
- LogGroup.KEY is now logged throguh LatinIME.onCodeInput() rather than
Utils.push(). This catches keys more generally, including modifiers, and
records touch positions for everything. Removed now-redundant
Utils.writeBackspace() and Utils.writeChar().
- LogGroup.CORRECTION uses Utils.writeCorrection(), and formats instead of
leaving this to callers.
- LogGroup.STATE_CHANGE uses Utils.writeStateChange(). Optional fields are
still left to callers, as this group has more variety.
Formats have changed to incorporate new fields.
Minor housekeeping:
ENABLE_USABILITY_STUDY_LOG constants replaced with variable references, as
the logging feature can be changed in Settings and therefore dynamically
changes.
New log format:
20120322-111203.621+0900 1332382323621 s [onStartInputView] com.socialnmobile.dictapps.notepad.color.note 2131624043 147457 1140850694
20120322-111204.912+0900 1332382324912 m [Down] 2782355 0 243 171 0.5666667 0.895
20120322-111204.975+0900 1332382324975 m [Move] 2782419 0 240 171 0.6 1.17
20120322-111204.983+0900 1332382324983 m [Move] 2782428 0 238 171 0.6 1.1899999
20120322-111204.992+0900 1332382324992 m [Move] 2782437 0 236 171 0.6 1.1899999
20120322-111205.002+0900 1332382325002 m [Move] 2782446 0 232 170 0.6 1.1899999
20120322-111205.012+0900 1332382325012 m [Move] 2782456 0 227 169 0.6 1.125
20120322-111205.021+0900 1332382325021 m [Move] 2782465 0 224 168 0.6 1.125
20120322-111205.031+0900 1332382325031 m [Move] 2782475 0 221 167 0.6 0.895
20120322-111205.040+0900 1332382325040 m [Move] 2782483 0 213 164 0.6 0.58
20120322-111205.047+0900 1332382325047 m [Up] 2782491 0 213 164 0.6 0.58
20120322-111205.052+0900 1332382325052 k 'D' 243 171
20120322-111205.228+0900 1332382325228 m [Down] 2782622 0 171 71 0.6333334 1.275
20120322-111205.243+0900 1332382325243 m [Move] 2782677 0 178 69 0.6333334 1.275
20120322-111205.325+0900 1332382325325 m [Up] 2782750 0 178 69 0.6333334 1.275
20120322-111205.333+0900 1332382325333 k 'e' 171 71
20120322-111205.509+0900 1332382325509 m [Down] 2782936 0 265 139 0.53333336 0.885
20120322-111205.512+0900 1332382325512 m [Move] 2782954 0 265 141 0.53333336 1.04
20120322-111205.552+0900 1332382325552 m [Move] 2782973 0 265 143 0.5666667 1.14
20120322-111205.663+0900 1332382325663 m [Up] 2783102 0 265 143 0.5666667 1.14
20120322-111205.668+0900 1332382325668 k 'f' 265 139
20120322-111206.140+0900 1332382326140 m [Down] 2783584 0 348 352 0.53333336 0.675
20120322-111206.206+0900 1332382326206 m [Move] 2783648 0 348 354 0.5666667 0.73499995
20120322-111206.223+0900 1332382326223 m [Move] 2783666 0 348 356 0.5666667 0.545
20120322-111206.232+0900 1332382326232 m [Up] 2783674 0 348 356 0.5666667 0.545
20120322-111206.236+0900 1332382326236 k ' ' 348 352
20120322-111206.245+0900 1332382326245 c [----] Def -1
Bug: 6188932
Change-Id: Iea46a0c683f858b72005b8e81191ef1d70262dca
2012-03-22 12:02:10 +09:00
Kurt Partridge
140467b8b6
Updated logger to record touch position within backspace key events.
...
Bug: 6188932
Change-Id: Ida2aff618153792f9803f30f1251d67c89af1fe0
2012-03-20 23:29:34 +09:00
Jean Chalard
9ffb94fa13
Rename the user history dictionary.
...
UserBigramDictionary -> UserHistoryDictionary.
Also update all methods, strings and comments, except those needed
for backward compatibility (which only include the name of the
database file).
Change-Id: I0bccea29880dc566b90100575b83baaa947b03ae
2012-03-19 12:03:51 +09:00
Ken Wakasa
660776e09b
Small performance improvement by removing interface accesses.
...
Change-Id: I6d91f3b086470b79306dbe2874db9748b9e0eb5f
2012-03-17 01:53:51 +09:00
Jean Chalard
c68d1bbfaf
Move the UserUnigramDictionary functionality over
...
UserBigramDictionary now assumes both functionalities. It will
be renamed to UserHistoryDictionary in a future change.
There are several reasons to do this. First, there is a lot of
duplicate code in User{Unigram,Bigram}Dictionaries that are
factored by the few lines of code in this change. Also, other
dictionaries like BinaryDictionary or ContactsDictionary all
assume both responsibilities, as should be the case
theoretically.
It is also possible to do this because previous versions don't
write any unigram data that we'd want to reuse. For even older
versions that do write data, we can't really make any sense out
of it. Bigram data however can be useful, and this allows us to
reuse it easily.
Change-Id: I755525f92744e1536eaef097527e8151b7859a30
2012-03-16 17:01:57 +09:00
Jean Chalard
c24f66e180
Streamline some user history dictionary code
...
A lot of things don't really make sense in the old code.
Let's streamline it for now so that we have a cleaner interface
to work with. This is preliminary work for bug 4192129.
Change-Id: If01a5974cfadc43afced610c57fcf7fde67c1346
2012-03-16 12:22:39 +09:00
Jean Chalard
3fe263fac6
Extract an annoying method call
...
Change-Id: I78f22bb38222fea54a55e460fcf728bf941d15e9
2012-03-15 19:30:15 +09:00
Jean Chalard
6ec1209a33
Fix a bug where quotes and dashes are considered letters
...
Bug: 6174065
Change-Id: I702760d44ead0eeb60d06360aa3bb03c2ec73325
2012-03-15 18:18:52 +09:00
Jean Chalard
2be7a37acf
Small cleanup
...
Exit-fast, update comment, make a method private
Change-Id: Id103bf03aeef43a1a4d064ecabb819490dc5d39a
2012-03-15 15:54:25 +09:00
Jean Chalard
03a3517075
Add info for obsolete suggestions in SuggestedWords
...
Change-Id: I9684c7b08244b34853ce8a99b6e9d885389f6687
2012-03-15 13:12:08 +09:00
Jean Chalard
f985efe39c
Remove a useless parameter
...
Change-Id: I03005240238fb004c20b2df0d836796e2e8b307f
2012-03-14 18:12:12 +09:00
Jean Chalard
bdf6d1b18b
Remove a useless method
...
Change-Id: I208dd2e725e37c2fb3cd51fe48194679e5912f6b
2012-03-14 15:59:04 +09:00
Jean Chalard
7d55c891af
Make the Builder private
...
Change-Id: I2184084f4b7729c4324f8291d548bd4c4c2872a1
2012-03-14 15:42:14 +09:00
Jean Chalard
5b0643f50d
Re-sequence the last calls to build()
...
Change-Id: If77ee5aa9483d3ca03c52812f31665dee6468e99
2012-03-14 14:19:24 +09:00
Jean Chalard
88bf1ba526
Move up the static methods of the Builder
...
Change-Id: Ic3e07b745b7b24cae0f772ea49e0de615b44caf9
2012-03-14 13:10:22 +09:00
Jean Chalard
8e19b1183e
Kill the last place where the Builder was being used
...
I had missed that one
Change-Id: I9a5040a7a61e294396aa424de96a69dbb15f037a
2012-03-14 13:10:12 +09:00
Jean Chalard
e3afb7d192
Make the Builder fully immutable at last
...
Change-Id: Ie399ca7a9e76ccab44a92bc378d11f92392fed2c
2012-03-13 20:33:13 +09:00
Jean Chalard
ec471c72f8
Add to SuggestedWords a missing parameter, and use it.
...
Also stop using Builder between its creation and the call to
the #build() method.
Change-Id: Ie1fc3ec7b6f4c7c3789f672f4e26b4bf58c3e062
2012-03-13 20:19:21 +09:00
Jean Chalard
2e2519ee91
Make still more members of the Builder final.
...
Change-Id: Ic455f97247da5e40d4939555ab639ecffef36e2d
2012-03-13 20:05:00 +09:00
Jean Chalard
b5eeb724fc
Make some more Builder attributes final.
...
Change-Id: I3132b7fe4ee97c566736bfc21c3783cfc79fc7ff
2012-03-13 19:53:38 +09:00
Jean Chalard
c60fea852d
Make the suggested word list final in Builder.
...
Change-Id: I2ddfab00dc8c141fc989a051f16eb2b3571b7e86
2012-03-13 19:37:17 +09:00
Jean Chalard
674ffcdf93
Make an add into a set.
...
This method now only sets words, so it should be named set.
The functionality is identical since there are no more places
where the list is reused.
This will also allow to make the list final in an upcoming change.
Change-Id: I25b0c7d7f13c3fa5d89806f01f48f1026769603f
2012-03-13 19:07:42 +09:00
Jean Chalard
4ee186920e
Remove a method that causes annoying side-effects.
...
...and replace by a call to a central method.
Change-Id: I93d0a2c2e99963a5b69923d1062d0e01853216b6
2012-03-13 18:22:49 +09:00
Jean Chalard
d0d4074392
Remove a useless parameter.
...
Change-Id: I7625bf17158c207ad7e8cd496bef825704173c4c
2012-03-13 15:34:06 +09:00
Tadashi G. Takaoka
4c0c638a18
Use Animator to draw language name on spacebar
...
Note that Animator class exists in framework only on Honeycomb or
later.
Change-Id: Ie3392dbf8acc1547ebb2d16e04086c911d961aed
2012-03-13 14:25:57 +09:00
Jean Chalard
1dfef0336d
Make a method static
...
Change-Id: Ie1d460562d38105abe91ae2da17cafd49e2cd394
2012-03-12 15:00:36 +09:00
Ken Wakasa
c1ca8815f5
Fix an obvious bug in handleLanguageSwitchKey()
...
bug: 5759092
Change-Id: I8c7b2ef024cbab399d96f6b3ec553da4e9d2fb18
2012-03-11 00:44:47 +09:00
Jean Chalard
68823ae08e
Make the safety net memory private
...
Change-Id: I10959d47c980d2e8f2ea995955acf02193e3ff7b
2012-03-09 22:01:15 +09:00
Jean Chalard
d5f618e90a
Remove a useless test
...
If we are not composing a word here, we have already returned
Change-Id: I63281abace777e3658286d4df6781d2cd5a29c33
2012-03-09 20:53:45 +09:00
Jean Chalard
c5d2bb786e
Don't use an intermediate object with a different meaning
...
Change-Id: Ie89916b49c852a51385ffd61cb596a58f23a46a0
2012-03-09 20:51:33 +09:00
Jean Chalard
ed9986824e
Move some auto-correction logic to where it belongs
...
Change-Id: I897c5ec3a630a4a6bfc593906df4d3fc7b244482
2012-03-09 20:45:37 +09:00
Jean Chalard
dfd4abe818
Fix a shameful bug
...
I must have been sleeping when I wrote that
Change-Id: I887180ab610785a2000636adeeed99230b3c5390
2012-03-09 19:31:35 +09:00
Jean Chalard
0cf422fbb7
Reduction, step 8
...
Change-Id: I54334039597e235e24f169e34c1d44109180ee88
2012-03-09 19:00:29 +09:00
Jean Chalard
a333ff19ef
Reduction, step 7
...
Change-Id: I177ef2f29c8b6000c5e3d021c016c5d216fe3fc6
2012-03-09 18:59:20 +09:00
Jean Chalard
a3ee019331
Reduction, step 6
...
Change-Id: I22ad4cea0e0cac23813da7e788f5c94974ce0ebf
2012-03-09 18:58:01 +09:00
Jean Chalard
de165aed2a
Separate bigram prediction from suggestion process
...
Change-Id: Ibdef206fbd6688a45cebbd7fb8a9f6cd175d03b0
2012-03-09 18:38:20 +09:00
Jean Chalard
6f722c8301
Remove useless stuff
...
Change-Id: I462d24da2d26661990d6aab2a13fde851763fd61
2012-03-09 18:36:52 +09:00
Jean Chalard
67af2a2415
Export some more logic out of Latin IME
...
Change-Id: Ib264533a05e9e09347bf254789e6ab5beec92400
2012-03-09 18:36:49 +09:00
Jean Chalard
df9fce5df1
Export some logic out of LatinIME
...
Hopefully that will end in Suggest/SuggestedWords being autonomous
and won't need the logic spoon-fed to them
Change-Id: I915661bce13c69c8a5b8e5d4a8c41e18fea594cf
2012-03-09 18:36:45 +09:00
Jean Chalard
91e55ac000
Small optimization
...
We only use some of those results in one branch of an if() test.
Let's not compute those that are not needed.
Change-Id: I6ca068646b86d2980fb88e75b110ad077362c4ff
2012-03-09 16:47:43 +09:00
Jean Chalard
195419b1ec
Small reorganization
...
...resulting in a slight optimization
Change-Id: I83a9b8c92c3d93ce75988285997ec138b3ffe52e
2012-03-09 16:41:35 +09:00
Jean Chalard
838629aea0
Remove useless test
...
typedWord may not be null here
Change-Id: I9e7afb89fafbf6fcbc91fbc132aecc06aec8979f
2012-03-09 15:52:23 +09:00
Jean Chalard
5a7cb9305a
Merge "Remove a provably useless test (B4)"
2012-03-08 22:22:20 -08:00
Jean Chalard
31a5da28e3
Merge "Move some code around (B1)"
2012-03-08 21:15:25 -08:00
Jean Chalard
8cd847c2fa
Remove a provably useless test (B4)
...
If !mInputAttributes.mInputTypeNoAutoCorrect then mCorrectionMode
will not have allowed #hasAutoCorrection() to return true.
Change-Id: I1b498d5aeb26194c765cc9b9dcb24d980de43894
2012-03-09 12:56:48 +09:00
Jean Chalard
dc5dfe37e0
Move some code around (B1)
...
The goal is to make the creation of the Builder closer to
the #build() call
Change-Id: I48d76d4efdc180479829016582edd9de47e7332c
2012-03-09 12:33:23 +09:00
Jean Chalard
13fb8fb775
Limit escape of parameters
...
Change-Id: I3a7ab069042d5542ab2e033d1eeb13d718cd7698
2012-03-09 12:30:23 +09:00
Jean Chalard
21af2f40c5
Merge broadcast receivers again
...
It's probably simpler not to have registers dance around,
and just message the feedback manager when the audio event
happens.
Change-Id: Id0710ed102d10d01f1af93ad8cb660653bb3a9f8
2012-03-09 11:00:23 +09:00
Jean Chalard
7b77c683d7
Fix a crash
...
Bug: 6137076
Change-Id: I05f9f72a2678d10d3400dab5fc71544276739dcf
2012-03-09 10:29:51 +09:00
Tadashi G. Takaoka
f686211183
Merge "Split Utils class to StringUtils, SubtypeUtils, and JniUtils"
2012-03-08 03:59:59 -08:00
Tadashi G. Takaoka
cc8c8b99bd
Split Utils class to StringUtils, SubtypeUtils, and JniUtils
...
Change-Id: I09e91675fe7d573dad8c933ad513b21d7e409144
2012-03-08 20:30:38 +09:00
Jean Chalard
0f1efae262
Merge "Cleanup unused imports (A7)"
2012-03-08 02:32:48 -08:00
Jean Chalard
663aabca0c
Merge "Get the view for haptic feedback as a parameter (A6)"
2012-03-08 02:32:39 -08:00
Jean Chalard
7cfae83434
Merge "Export audio and haptic feedback to a specialized class. (A1)"
2012-03-08 02:31:45 -08:00
Jean Chalard
8667bbeab3
Small rename
...
Left/Right is wrong terminology here
Change-Id: I58c55849e45d9984dd3fb7b75a64e07667c9eba4
2012-03-08 18:49:38 +09:00
Jean Chalard
41a2929282
Cleanup unused imports (A7)
...
Change-Id: I48ba12e4311cbf2982ee8f5312b279bc8c1fdfe8
2012-03-08 18:37:03 +09:00
Jean Chalard
544c3c2952
Get the view for haptic feedback as a parameter (A6)
...
It's rather annoying (and possibly dangerous) to keep this as a member.
Get it from outside.
Change-Id: I00c42db96395fb65204fb140aeedc82bf312a86e
2012-03-08 18:37:00 +09:00
Jean Chalard
564496bad6
Export audio and haptic feedback to a specialized class. (A1)
...
Change-Id: I957d883d1ccf188cb98eb11031aa0a32fce4ed76
2012-03-08 18:35:20 +09:00
Jean Chalard
f8b39f39cd
Merge "Remove a useless class (B4)"
2012-03-08 01:14:33 -08:00
Jean Chalard
4b656a3fef
Merge "Remove stuff that's not used any more (B3)"
2012-03-08 01:13:06 -08:00
Jean Chalard
d8447ec353
Merge "Use the simple auto-correction status (B2)"
2012-03-08 01:12:46 -08:00
Jean Chalard
fbe767cec5
Merge "Remember auto-correction status simply (B1)"
2012-03-08 00:54:30 -08:00
Tadashi G. Takaoka
c648b88779
Merge "Dynamically determine key preview backing view height"
2012-03-07 04:17:52 -08:00
Tadashi G. Takaoka
c8b0e5797e
Dynamically determine key preview backing view height
...
Bug: 6023947
Change-Id: I53a5c0eb99100a0dfe3e025808f5dc55747d1287
2012-03-07 20:33:17 +09:00
Jean Chalard
dab392c6f4
Merge "Fix a bug with successive manual picks"
2012-03-07 01:51:59 -08:00
Jean Chalard
3dd4bcb283
Merge "Recompute suggestions on language change."
2012-03-07 01:35:12 -08:00
Jean Chalard
b84ee82e66
Recompute suggestions on language change.
...
Bug: 6106407
Change-Id: I43d9c89610a9ed7a9f6825bd90334d7b343df52c
2012-03-07 17:35:32 +09:00
Jean Chalard
845b24d9d3
Fix a bug with successive manual picks
...
Bug: 6121571
Change-Id: Ib16fbef1087da3b7da5539901ec57156f242f089
2012-03-07 17:32:42 +09:00
Jean Chalard
f773ef19e8
Remove a useless class (B4)
...
\o/
Bug: 5975068
Change-Id: Ia18b55af6d555e7ee7af1cdd7c6227fc1ee6786b
2012-03-07 15:34:15 +09:00
Jean Chalard
a0beebf711
Remove stuff that's not used any more (B3)
...
Change-Id: Ie86675ff2facd37430051bf129ddd930fb933dc9
2012-03-07 15:32:55 +09:00
Jean Chalard
0a59ac2ba8
Use the simple auto-correction status (B2)
...
Change-Id: I9d2f053b6f7bad20fc6afe5f5086a965e5014a5c
2012-03-07 15:31:22 +09:00
Jean Chalard
70852c91dc
Remember auto-correction status simply (B1)
...
This duplicates the functionality in ComposingStateManager at
a fraction of the cost. It's not used yet.
Change-Id: Ica2607fb2f7c41e11189fcb566e253db8f62596f
2012-03-07 15:20:01 +09:00
Tadashi G. Takaoka
65fe7f7994
Merge "Add language switch key only to the phone layouts"
2012-03-06 18:19:45 -08:00
Tadashi G. Takaoka
81d4e3cd66
Add language switch key only to the phone layouts
...
Bug: 5759092
Change-Id: Ic7d7d4812976654c0e85fecabd1128eadfc52c5c
2012-03-07 10:03:21 +09:00
Jean Chalard
89ffb212b4
Make the keyboardswitcher and the subtypeswitcher final.
...
Change-Id: Ifcc79357adcc53f93b190b6e98d5569f42f74655
2012-03-06 19:07:21 +09:00
Jean Chalard
3cd1a00eca
Resolve a todo
...
This exports some voiceproxy complexity to voiceproxy rather
than keeping it in latinime
Change-Id: I0b3523e77af4104cc3ed28417956059c734c8bfe
2012-03-06 18:43:18 +09:00
satok
231ef8fa3e
Merge "Integrate the logic to calculate the proximities"
2012-03-05 23:25:29 -08:00
satok
ca7ec2097c
Integrate the logic to calculate the proximities
...
Bug: 4343280
Change-Id: I0f6a7e6912ed4abea07c10d266da4c7ccb0dae76
2012-03-06 15:34:27 +09:00
Jean Chalard
00ed3be95c
Correct special space handling of punctuation
...
This fixes two defects:
- One where some separators should promote a phantom space to
a real space. This bug had a unit test but wasn't tracked.
- One where French punctuations would behave incorrectly. Tracked
Bug: 6113693
Change-Id: Ia7f86fc960e00141757632ab2c9bce9168dd6966
2012-03-06 14:00:34 +09:00
Tadashi G. Takaoka
e79b1a8312
Make SuggestedWords immutable completely
...
Change-Id: I1b0f7b857e89307c987187c1969a2846aa97fdcc
2012-03-05 23:06:37 +09:00
Tadashi G. Takaoka
8cc8f26adf
Make SuggestedWords partially immutable
...
Change-Id: I72a2f71d7f6565a30c06e563b0a64f496542cde9
2012-03-05 22:11:13 +09:00
Tadashi Takaoka
d5b6360549
Merge "Revert "Make SuggestedWords immutable""
2012-03-05 02:57:00 -08:00
Tadashi Takaoka
d62fa834c6
Revert "Make SuggestedWords immutable"
...
This reverts commit c208f4dfb7
2012-03-05 02:54:21 -08:00
Jean Chalard
6a830277df
Merge "Refactoring"
2012-03-05 01:49:46 -08:00
Jean Chalard
611a5bdf65
Refactoring
...
Change-Id: I2f92c01fa1ff6b318128d387f26942b5d47de3e0
2012-03-05 18:36:51 +09:00
Tadashi G. Takaoka
c208f4dfb7
Make SuggestedWords immutable
...
Change-Id: I26bd82aee5ead84e40abfc3db5a48ed6d1e42361
2012-03-05 17:24:30 +09:00
Jean Chalard
895b70b8af
Move some treatment to a more sensical place.
...
It makes more sense to catch words with the safety net in
updateSuggestions() than in showSuggestions(). Also, it's useless
to do it in updateBigramPredictions, because the result will
always be provably false.
This will also help with writing unit tests.
Change-Id: Ifab81e6c5a74b1aa75cf85ef7742fee69a98f5ce
2012-03-05 14:27:49 +09:00
Jean Chalard
9b01890254
Move a method to a more sensical place.
...
Change-Id: I11f87448f689cf828bff960ad7a3e4739a3457dc
2012-03-05 14:19:35 +09:00
Jean Chalard
428178aca6
Merge "Replace a useless computation with a constant"
2012-03-04 19:35:11 -08:00
Jean Chalard
4ab5486bf2
Merge "Remove a useless test"
2012-03-04 19:35:02 -08:00
Jean Chalard
4e112d0782
Replace a useless computation with a constant
...
This is provably always false
Change-Id: I88d783fa59fec0b7a729558ba974a6a58c158645
2012-03-05 11:57:36 +09:00
Jean Chalard
a04d2358c0
Remove a useless test
...
With the current logic, this test provably always resolves
to false.
Change-Id: Iba84ef5f3a14cd8ac48c6a813519ab283bf605f8
2012-03-05 11:38:45 +09:00
Tadashi G. Takaoka
49079df8ec
Merge "Omit InputMethodManagerCompatWrapper argument from some utility methods"
2012-03-04 18:12:47 -08:00
Tadashi G. Takaoka
2d25ba2750
Omit InputMethodManagerCompatWrapper argument from some utility methods
...
Change-Id: Ic837018c702c8c575de3e5e81fe8e31fee16fe22
2012-03-05 10:43:12 +09:00
Jean Chalard
a83a53ba24
Some renaming
...
Change-Id: I445277cb3af469a0145a8da0ffb801b7e19048cd
2012-03-02 20:46:54 +09:00
Jean Chalard
dd931c47be
Some more simplification
...
I wish "are we autocorrecting?" was not computed in a dozen
places all depending on a hundred code paths
More than likely, this fixes very subtle discrepancies
between auto-correction indicator with the underline and with
the LED on the spacebar - which is not displayed any more in
the current version anyway. Especially, the LED probably
would have been off when the word was caught by the safety net.
Change-Id: Idda3021771081d6155b06915e728ecd64d9e042e
2012-03-02 20:34:10 +09:00
Jean Chalard
e2a50bd804
Optimization
...
Avoid doing some useless processing.
Change-Id: I4ce0a188e10db30322bd25751dc5c09492cea301
2012-03-02 20:26:51 +09:00
Jean Chalard
7204eab3da
Precompute two values that never change
...
Change-Id: Ic54e7926028ea8374564da5e5004d710f42c53e1
2012-03-02 20:04:42 +09:00
Jean Chalard
38e535e596
Change a parameter type to make a call clearer
...
Change-Id: I2918d0a8b00da743689b919f80128bbf36973f24
2012-03-02 20:01:34 +09:00