nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
41,682 Commits
1 Branch
0 Tags
363 MiB
Commit Graph

339 Commits (1d9bf42009301bee11ebdafb26ca6a0a18240e84)

Author SHA1 Message Date
Jean Chalard 521a83a3f1 Merge "[IL86] Simplification and correctness fix." 2014-01-27 11:17:31 +00:00
Jean Chalard 264f4e380d Merge "[IL84] Remove a useless call and rename a method" 2014-01-27 11:17:05 +00:00
Jean Chalard 75ec579e07 Merge "[IL81] Remove a useless test." 2014-01-27 10:11:14 +00:00
Jean Chalard 6d1c8b2c3f Merge "Try to figure out whether d.quotes open or close." 2014-01-27 10:01:17 +00:00
Jean Chalard 3b939ed77f [IL86] Simplification and correctness fix. 
This should be what was intended.

Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
 2014-01-27 18:42:33 +09:00
Jean Chalard b2c0388a69 [IL84] Remove a useless call and rename a method 
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
 2014-01-27 18:42:32 +09:00
Jean Chalard abbd755689 [IL81] Remove a useless test. 
It seems the comments were right all along. This seems to really
be useless.

Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
 2014-01-27 18:42:32 +09:00
Jean Chalard f1e5b9b4d1 [IL80] Reverse a test for clarity. 
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
 2014-01-27 18:42:32 +09:00
Jean Chalard f59487379e [IL79] Some refactoring 
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
 2014-01-27 18:42:29 +09:00
Jean Chalard 10460441db [IL78] Move most of onUpdateSelection to InputLogic. 
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
 2014-01-27 18:42:04 +09:00
Jean Chalard 48df380f78 [IL77] Remove refs to Settings from InputLogic 
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
 2014-01-27 18:18:54 +09:00
Jean Chalard 969c06072d [IL75] Move the SubtypeSwitcher out of InputLogic. 
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
 2014-01-27 18:18:27 +09:00
Jean Chalard c7ef305bbc Try to figure out whether d.quotes open or close. 
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
 2014-01-27 18:17:33 +09:00
Jean Chalard 3aa2043a66 Merge "[IL76] Remove a SuggestionStripView dependency" 2014-01-23 10:06:42 +00:00
Jean Chalard a1ed211c4e [IL76] Remove a SuggestionStripView dependency 
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.

Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
 2014-01-23 16:25:48 +09:00
Jean Chalard 4173610bc5 [IL66.1] Add a comment 
Followup to IL66

Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
 2014-01-23 16:00:49 +09:00
Jean Chalard 1284e556f4 [IL70] Remove unused arguments 
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
 2014-01-23 15:33:14 +09:00
Jean Chalard d1f463eacf [IL69] Oust Keyboard from WordComposer#setComposingWord 
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
 2014-01-23 15:32:59 +09:00
Jean Chalard eb6d41a525 [IL67] Externalize a call to the keyboard switcher 
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
 2014-01-23 13:10:02 +09:00
Jean Chalard ab80b41a0d [IL66] Remove two accesses to KeyboardSwitcher. 
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
 2014-01-23 13:09:58 +09:00
Jean Chalard 352286a43b [IL64] Pull up X,Y processing, step 3 
Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
 2014-01-22 14:44:25 +09:00
Jean Chalard b8216a4e7e [IL63] Pull up X,Y processing, step 2 
This also fixes the coordinates passed to logOnDelete and
log onSeparator.

Bug: 8636060
Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
 2014-01-22 14:42:52 +09:00
Jean Chalard 2b38b5e8e6 [IL62] Pull up X,Y processing, step 1 
This is fine because getKey{X,Y} is idempotent for any
non-keyboard coordinate value.

However this makes a net change : the x,y values passed to
LatinImeLoggerUtils.onNonSeparator are now different.
The point is however that they used to be wrong. The logged
values used not to account for the keyboard padding that
is present on tablets, and in the simulating tools we don't
know about that padding so we couldn't use the coordinates.
The catch here is that other calls like LoggerUtils.onSeparator
should follow suit, but this is too big a change to do it at once.
Follow-up changes will fix them too.

Bug: 8636060
Change-Id: If4b3d3cb1ed4b44c35f23e66aba3b5797236bba7
 2014-01-22 14:41:45 +09:00
Jean Chalard 591580ee8a Merge "[IL61] Remove an internal use of key coordinates" 2014-01-22 05:19:45 +00:00
Tadashi G. Takaoka c93cf1c398 Use sorted int[] to represent word separators 
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
 2014-01-20 19:40:02 +09:00
Tadashi G. Takaoka 3033cc51b8 Refactor logic to retrieve relevant suggestions a bit 
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
 2014-01-20 12:08:25 +09:00
Tadashi G. Takaoka 6a18af634e Refactor RichInputConnection a bit 
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
 2014-01-17 13:14:29 +09:00
Jean Chalard ab4543d593 [IL61] Remove an internal use of key coordinates 
Bug: 8636060
Change-Id: Id87b0ac4a99ec6a26db6e250d6cd22defc02a23d
 2014-01-17 02:10:56 +09:00
Jean Chalard 81255612bc [IL60] Make InputLogicHandler package private 
Yay

Bug: 8636060
Change-Id: Iad9c3804504635094e861999198f4baf70e61955
 2014-01-17 02:10:56 +09:00
Jean Chalard 17bd129faf [IL59] Rename a method 
Um... this is not async ? Remove that from the name

Bug: 8636060
Change-Id: Ida5f9bd6929eae75103eb2e3fb866ed7468af806
 2014-01-17 02:10:56 +09:00
Jean Chalard ac6dfaf80b [IL58] Simplification 
No need to test multiple times for this. Let's just never do useless
stuff, and only test for that once.

Bug: 8636060
Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
 2014-01-17 02:10:51 +09:00
Jean Chalard 4752b68f5a [IL56] Don't erase suggestions when reverting a commit. 
Bug: 12297051
Change-Id: Iffa1c98b8fe2b816c3ac6bc171037288107f637d
 2014-01-16 03:22:46 +09:00
Tadashi G. Takaoka bf418f7cba Pass time stamp to addToUserHistory method as an argument 
Bug: 12179576
Change-Id: I93037ee2aa7c0432400fe2f93fb60d2e60f70f5f
 2014-01-14 15:48:08 +09:00
Jean Chalard 6c24b91601 [IL55] Remove a useless argument. 
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
 2014-01-10 20:28:50 +09:00
Jean Chalard a224aafea3 [IL54.5] Use the cursor pos estimate, not the last value 
For edit tasks, the estimate is actually the right thing to use.
This is really dangerous, but it will get rid of pretty much all
race conditions.

Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
 2014-01-10 19:08:47 +09:00
Jean Chalard ecf46df226 [IL54] Add a mirror method to fix the cursor pos estimate 
This just mirrors what InputLogic#tryFixLyingCursorPosition
is doing. That method will go away in the next change.

Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
 2014-01-10 16:05:02 +09:00
Jean Chalard e1de87ae69 Fix an NPE. 
Bug: 12397228
Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
 2014-01-10 13:46:37 +09:00
Tadashi G. Takaoka 494e2d6c17 Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords 
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
 2014-01-09 18:33:25 +09:00
Jean Chalard b90fa0fb2c Revert "Revert "Separate spacing and punctuation related settings values"" 
This reverts commit 8bc427799a.

Change-Id: I34f509998afdb1a7c120fbfdb9f0a1b188224a4d
 2014-01-08 18:08:01 +09:00
Jean Chalard e5cdcaff65 Fix a race condition, take 2. 
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
 2014-01-08 18:04:44 +09:00
Jean Chalard 1e7f2809d2 Merge "Revert "Separate spacing and punctuation related settings values"" 2014-01-08 09:03:15 +00:00
Jean Chalard 8bc427799a Revert "Separate spacing and punctuation related settings values" 
This is conflicting with later changes. Temporary revert for cherry-pick.

This reverts commit 0b593ce858.

Change-Id: Id53eadb023a950cfcca496c0cfbfe583c7ec7b8c
 2014-01-08 09:00:45 +00:00
Jean Chalard a247264dc6 Revert "Fix a race condition, take 2." 
Conflicts prevent this to be cherry-picked.

This reverts commit dd3d697a6e.

Change-Id: Ib97fae2234633b4bb27d611f48a79060db9ab16f
 2014-01-08 08:59:26 +00:00
Jean Chalard dd3d697a6e Fix a race condition, take 2. 
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
 2014-01-08 17:19:29 +09:00
Jean Chalard f628629f69 Revert "Revert "Fix a race condition."" 
This reverts commit 3840127244.

Change-Id: I7f0d975ec9e18d94fe3505250360c2b79ccbe96d
 2014-01-08 16:44:43 +09:00
Tadashi G. Takaoka 0b593ce858 Separate spacing and punctuation related settings values 
Bug: 12179576
Change-Id: Ibafd824a0ea2251843b388e95dcbd8f9bca92d5c
 2014-01-08 10:02:37 +09:00
Jean Chalard 1e50c681af [IL52] Remove a useless method. 
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.

Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.

Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
 2013-12-27 22:40:19 +09:00
Jean Chalard 8ce921dd6b [IL51] Make private what can be made private 
Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
 2013-12-27 21:09:47 +09:00
Jean Chalard 53c320e275 [IL50] Move the InputUpdater out of LatinIME. 
...at last

Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
 2013-12-27 21:09:41 +09:00
Jean Chalard 81e0ca5fd3 [IL49] Move InputLogic-related init code to InputLogic. 
Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
 2013-12-27 20:06:39 +09:00
Jean Chalard c654fe57b1 [IL48] Move onEndBatchInputAsyncInternal to InputLogic. 
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
 2013-12-27 16:50:08 +09:00
Jean Chalard 69e7a0d24d [IL44] Some factorization 
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.

Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
 2013-12-27 15:34:26 +09:00
Jean Chalard 6bca9ac43d Fix a bug where predictions would not pop upon manual pick 
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
 2013-12-26 23:19:29 +09:00
Jean Chalard 33b2aaafc2 Merge "Fix a code path that looks ridiculous" 2013-12-26 13:39:21 +00:00
Jean Chalard f294ed3308 Fix a code path that looks ridiculous 
Bug: 12295276
Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
 2013-12-26 22:28:16 +09:00
Jean Chalard f441047fad [IL43] Small cleanup 
All calls are already passing this

Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
 2013-12-26 22:12:24 +09:00
Jean Chalard c28f02880c [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync 
Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
 2013-12-26 22:12:22 +09:00
Keisuke Kuroyanagi a374482719 Extract dict operations from Suggest to a new class. 
Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
 2013-12-26 20:48:19 +09:00
Jean Chalard 52a2682b99 [IL35] Preparative cleanup 
Bug: 8636060
Change-Id: Id6791085816891c78289b0223bf0807db2da6300
 2013-12-25 22:25:49 +09:00
Jean Chalard 0154609a2e Merge "[IL34] Introduce InputLogicHandler" 2013-12-25 13:21:54 +00:00
Keisuke Kuroyanagi eea7122e5b Move dict operations to Suggest. 
Bug: 8187060

Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160
 2013-12-25 15:26:50 +09:00
Jean Chalard 621dcbc31c [IL34] Introduce InputLogicHandler 
Bug: 8636060
Change-Id: I5d08ed5d69cdb03bd188e36b7014de03f04fa72f
 2013-12-25 14:20:19 +09:00
Jean Chalard 8476c2e788 [IL33] Opportunistically remove some KeyboardSwitcher 
Bug: 8636060
Change-Id: I0480ac03b9902e940f566b5558b8499647983968
 2013-12-24 15:11:35 +09:00
Jean Chalard 07f7536b04 [IL32] Remove a useless variable 
Change-Id: I8f5d8fd8c1627a568df57255dc3dceda26c4720c
 2013-12-20 21:34:07 +09:00
Jean Chalard 1587be6977 [IL31] Move *BatchInput to InputLogic 
Bug: 8636060
Change-Id: If0309be038518a71d735108b78ac9efbfe38c82b
 2013-12-20 21:24:27 +09:00
Jean Chalard 0547b33130 [IL29] Move retryResetCaches and tryFixLyingCursorPosition 
Bug: 8636060
Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59
 2013-12-20 20:47:29 +09:00
Jean Chalard 221df9e59a [IL26] Move restartSuggestionsOnWordTouchedByCursor 
Bug: 8636060
Change-Id: I373874585f4fa663b4207b9a02d751805259eb36
 2013-12-20 19:09:36 +09:00
Jean Chalard aa161eb371 [IL24] Move mDisplayOrientation to SettingsValues. 
Bug: 8636060
Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402
 2013-12-20 18:44:09 +09:00
Jean Chalard 6cf843cba6 [IL23] Resolve a long-standing TODO. 
Bug: 8636060
Change-Id: I3a840c30cc4489debf9118beeec448488503bc1c
 2013-12-20 16:50:14 +09:00
Jean Chalard 11730aa224 [IL22] Move onTextInput to InputLogic. 
Also pull the TLD specific processing

Bug: 8636060
Change-Id: I20931ac6fc6c55a05aa8f8b97b0210c07d230ea2
 2013-12-20 16:50:14 +09:00
Jean Chalard 1404c1af85 [IL21] Move the workaround utils to a better place. 
Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
 2013-12-20 16:48:54 +09:00
Jean Chalard 4487a30e0d [IL19] Resolve a TODO. 
Bug: 8636060
Change-Id: Iec7c1001c46cf8e9a44422e3f9008e437cc5cab6
 2013-12-20 16:02:03 +09:00
Jean Chalard 2a6de7903c [IL18] Move and rename updateSuggestionStrip 
Bug: 8636060
Change-Id: I3d00095cd0e83d1ee3834b37ff188b5aa9806fcb
 2013-12-20 15:46:34 +09:00
Jean Chalard 1c0374da49 [IL17] Move commitChosenWord to InputLogic. 
Also not-cache a value whose documentation says not to cache
it. That makes it write only, so remove it.

Bug: 8636060
Change-Id: I39798a039cebf79ad78a41fe457c9d9764a3f275
 2013-12-20 15:13:48 +09:00
Jean Chalard 5c9e677c2a [IL15] Some small refactoring 
Bug: 8636060
Change-Id: I4bfdf1628c9b55a79bd2d88ee30bf10b08a49232
 2013-12-20 11:24:45 +09:00
Jean Chalard 48ba1f25ff [IL14] Move getCurrent*Caps* to InputLogic 
Bug: 8636060
Change-Id: I6338dcee0f7a80f2181ba0369f71350cb21d231a
 2013-12-20 11:24:42 +09:00
Jean Chalard cdd8a1a69d [IL13] Inline restartSuggestionsOnWordBeforeCursor 
It's only ever used in one place and makes unhealthy assumptions
about what the caller is doing. It's better inlined.

Bug: 8636060
Change-Id: I265d5d96894e929d09247ee2e3dc2e81efc2a276
 2013-12-19 20:31:52 +09:00
Jean Chalard bbe40835a9 [IL12] move restartSuggestions* to InputLogic 
Bug: 8636060
Change-Id: I99474248e8fa35eb3053b5520abc8716805fdfb4
 2013-12-19 20:30:41 +09:00
Jean Chalard 10755af97b [IL11] Cleanup 
Make some methods private and add comments.

Bug: 8636060
Change-Id: I6c7d13dca8a22dd1a6f110e8b18d52864429579f
 2013-12-19 20:13:14 +09:00
Jean Chalard 060e292628 [IL10] Move revertCommit to InputLogic 
Bug: 8636060
Change-Id: Ia5788b365f05ae880bad957cbef00ecc93abb5d1
 2013-12-19 19:30:26 +09:00
Jean Chalard 69a57bcdcd [IL9] Move commitCurrentAutoCorrection to InputLogic 
Bug: 8636060
Change-Id: I405c4a537858a6d5ab0b29502a2792e8c3b2564e
 2013-12-19 19:30:20 +09:00
Jean Chalard 035e3885ac [IL8] Move handleNonSeparator to InputLogic 
Also move getActualCapsMode and getNthPreviousWordForSuggestion

Bug: 8636060
Change-Id: I1ee9162d0b7a517070c4b7420b084c973f061533
 2013-12-19 18:32:51 +09:00
Jean Chalard d85e49bf8c [IL7] Move performRecapitalization to InputLogic 
Bug: 8636060
Change-Id: I5bf2b1fa2f9338fe28151e66eac1ceda6dbd4a7f
 2013-12-19 18:20:41 +09:00
Jean Chalard 40b42b7d84 [IL6] Move handleSeparator to InputLogic 
Also move swapSwapperAndSpace, maybeDoubleSpacePeriod,
maybeStripSpace, promotePhantomSpace and canBeFollowedByDoubleSpacePeriod

Bug: 8636060
Change-Id: I864053d21c4b3d51ee7a3cd79053ca602337f6f8
 2013-12-19 17:39:01 +09:00
Jean Chalard c8dfaab783 [IL5] Some renaming 
Bug: 8636060
Change-Id: Id76889f8405458bcacb9c7c694cb193b27b842f3
 2013-12-19 17:38:55 +09:00
Jean Chalard 37d3f1bd02 [IL4] Move handleNonSpecialCharacter to InputLogic. 
Bug: 8636060
Change-Id: I9c6869c85db49d7f87e95a421389eaf47ae3ab2e
 2013-12-19 16:46:57 +09:00
Jean Chalard 0e82fa273d [IL3] Move handleBackspace to InputLogic. 
Also move resetEntireInputState, resetComposingState,
sendDownUpKeyEvent, sendKeyCodePoint and getTextWithUnderline

Bug: 8636060
Change-Id: Ic4c270ac49769ffba41dc3f12d16ac3aa938717f
 2013-12-19 16:46:54 +09:00
Jean Chalard cddf4f9d78 [IL2] Move onCodeInput to InputLogic. 
Bug: 8636060
Change-Id: I8c5c028d81183adb0167b2034ee01de8048edafb
 2013-12-19 16:24:45 +09:00
Jean Chalard 7bd2a75ca1 Start separating the input logic from LatinIME. 
Create an InputEngine class and start moving the relevant
variables to it.

Bug: 8636060
Change-Id: I64adef4ac01e665c19bb7c5b93517a0cbd03d817
 2013-12-19 14:48:43 +09:00