47ff423121
Merge "[IL82] Fix a wrong comment"
2014-01-27 10:11:42 +00:00
75ec579e07
Merge "[IL81] Remove a useless test."
2014-01-27 10:11:14 +00:00
c0c74d22a0
Add SubtypeLocaleUtils.isRtlLanguage method
...
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
2014-01-27 19:05:16 +09:00
6d1c8b2c3f
Merge "Try to figure out whether d.quotes open or close."
2014-01-27 10:01:17 +00:00
b084da2ae6
Merge changes I5092942a,I931c553f
...
* changes:
[IL80] Reverse a test for clarity.
[IL79] Some refactoring
2014-01-27 10:00:37 +00:00
a3a85e8c2b
Merge "[IL78] Move most of onUpdateSelection to InputLogic."
2014-01-27 09:55:08 +00:00
d38b0468b0
[IL90] Small refactoring
...
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
2014-01-27 18:42:33 +09:00
33ff321d6c
[IL89] Inline a function
...
We will then refactor the contents of showSuggestionStripWithTypedWord
Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
2014-01-27 18:42:33 +09:00
ca819178a1
[IL88] Simple refactoring
...
With this, the value passed to suggestedWords is never null.
Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
2014-01-27 18:42:33 +09:00
d90bdd2187
[IL87] Remove a call to clearSuggestionStrip
...
The goal is to remove the function completely.
Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
2014-01-27 18:42:33 +09:00
3b939ed77f
[IL86] Simplification and correctness fix.
...
This should be what was intended.
Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
2014-01-27 18:42:33 +09:00
07eddf3c43
[IL85] Maybe show punctuations when app completions are null
...
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.
Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
2014-01-27 18:42:32 +09:00
b2c0388a69
[IL84] Remove a useless call and rename a method
...
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
2014-01-27 18:42:32 +09:00
eb190ab32f
[IL83] Inline a call
...
The coming string of changes is very complicated, so
I'm going to do things really slowly.
Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
2014-01-27 18:42:32 +09:00
17f1528f9e
[IL82] Fix a wrong comment
...
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
2014-01-27 18:42:32 +09:00
abbd755689
[IL81] Remove a useless test.
...
It seems the comments were right all along. This seems to really
be useless.
Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
2014-01-27 18:42:32 +09:00
f1e5b9b4d1
[IL80] Reverse a test for clarity.
...
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
2014-01-27 18:42:32 +09:00
f59487379e
[IL79] Some refactoring
...
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
2014-01-27 18:42:29 +09:00
10460441db
[IL78] Move most of onUpdateSelection to InputLogic.
...
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
2014-01-27 18:42:04 +09:00
1e4b1300e6
Merge "Refactor SuggestionsStripLayoutHelper class"
2014-01-27 09:36:52 +00:00
68d7291a6b
Merge "[IL77] Remove refs to Settings from InputLogic"
2014-01-27 09:29:50 +00:00
148dedbc5d
Refactor SuggestionsStripLayoutHelper class
...
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
2014-01-27 18:25:25 +09:00
7bee84095e
Merge "[IL75] Move the SubtypeSwitcher out of InputLogic."
2014-01-27 09:24:10 +00:00
829ad708db
Merge "Revert "Use ViewCompat support library""
2014-01-27 09:20:19 +00:00
48df380f78
[IL77] Remove refs to Settings from InputLogic
...
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
2014-01-27 18:18:54 +09:00
969c06072d
[IL75] Move the SubtypeSwitcher out of InputLogic.
...
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
2014-01-27 18:18:27 +09:00
c7ef305bbc
Try to figure out whether d.quotes open or close.
...
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
2014-01-27 18:17:33 +09:00
e4692c0050
Revert "Use ViewCompat support library"
...
This reverts commit e7ee4fa862
2014-01-27 18:14:40 +09:00
5cf70a1d44
Merge "[IL74] Remove unused/unwanted arguments to a method."
2014-01-27 08:57:12 +00:00
0b58617951
Merge "Fix inconsistent behavior with backspace in the Emoji pallete."
2014-01-27 08:11:51 +00:00
0fd556ceca
[IL74] Remove unused/unwanted arguments to a method.
...
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
2014-01-27 16:48:17 +09:00
ea8c1c811c
Fix inconsistent behavior with backspace in the Emoji pallete.
...
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
the key.
This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
subsequent delete key events when the finger is moved away
from the key area.
Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
2014-01-27 16:24:51 +09:00
f3ca92dd33
Merge "Use ViewCompat support library"
2014-01-27 07:21:41 +00:00
e7ee4fa862
Use ViewCompat support library
...
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
2014-01-27 16:11:03 +09:00
03283b636c
Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
...
some cleanups as well
Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
2014-01-27 16:08:27 +09:00
95043145df
Merge "Check length of words for personalization dict."
2014-01-25 00:44:58 +00:00
b7197b705b
Check length of words for personalization dict.
...
Bug: 12602903
Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
2014-01-24 16:32:28 -08:00
0acd121083
Fix wrong indents.
...
Removed an unused method too.
Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
2014-01-24 23:55:33 +09:00
b6e128cc05
Merge "[IL69.1] Move a static method to a utility class."
2014-01-24 03:04:12 +00:00
1d6e647ac3
[IL69.1] Move a static method to a utility class.
...
This is a followup to IL69.
Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
2014-01-24 11:59:23 +09:00
0c72529088
Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer"
2014-01-24 01:55:57 +00:00
6a39811d90
Merge "Import translations. DO NOT MERGE"
2014-01-23 21:02:33 +00:00
5047b4aa84
Import translations. DO NOT MERGE
...
Change-Id: Ib5a8be5d9ac508d57648e4e8811805eea4355fc3
Auto-generated-cl: translation import
2014-01-23 12:25:35 -08:00
2efb58fc98
Import translations. DO NOT MERGE
...
Change-Id: I6c8aa53b9be4c3aa5822a820cc8cfdc3cf31c390
Auto-generated-cl: translation import
2014-01-23 12:22:23 -08:00
3aa2043a66
Merge "[IL76] Remove a SuggestionStripView dependency"
2014-01-23 10:06:42 +00:00
f16a2a36d2
[IL71.1] Add some javadoc.
...
Change-Id: I382abd3104d535a1e868935d8cfb4e34ad8ebaed
2014-01-23 17:11:47 +09:00
a1ed211c4e
[IL76] Remove a SuggestionStripView dependency
...
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.
Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
2014-01-23 16:25:48 +09:00
4173610bc5
[IL66.1] Add a comment
...
Followup to IL66
Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
2014-01-23 16:00:49 +09:00
be846fc352
[IL73] Remove all refs to Key and Keyboard in WordComposer
...
Please hold my gun while I have this nice cup of tea.
Yes !!
Bug: 8636060
Change-Id: I33c8ffe51bb2106b17f7941235ad1e427e3a81f7
2014-01-23 15:52:29 +09:00
df8310c6e2
Merge "[IL71] Add indices to toCodePointArray."
2014-01-23 06:50:19 +00:00
1284e556f4
[IL70] Remove unused arguments
...
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
2014-01-23 15:33:14 +09:00
d1f463eacf
[IL69] Oust Keyboard from WordComposer#setComposingWord
...
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
2014-01-23 15:32:59 +09:00
9da4b49ef6
[IL68] Start refactoring setComposingWord
...
Bug: 8636060
Change-Id: I242b7c264abf380bcd6b6b3c848238921f988e54
2014-01-23 15:15:49 +09:00
18638d30c0
[IL71] Add indices to toCodePointArray.
...
This is necessary for tests
Bug: 8636060
Change-Id: I50ea401a22e4df72333eda61ca39aa180966ee4b
2014-01-23 13:11:40 +09:00
eb6d41a525
[IL67] Externalize a call to the keyboard switcher
...
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
2014-01-23 13:10:02 +09:00
ab80b41a0d
[IL66] Remove two accesses to KeyboardSwitcher.
...
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
2014-01-23 13:09:58 +09:00
a91dfff5e5
[IL65] Pull up X,Y processing, step 4
...
This works because getKey{X,Y} is a no-op on
Constants.NOT_A_COORDINATE.
Bug: 8636060
Change-Id: I2f7dd96b6011f094110f7978f8ff24ef2a6e2585
2014-01-22 14:44:27 +09:00
352286a43b
[IL64] Pull up X,Y processing, step 3
...
Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
2014-01-22 14:44:25 +09:00
b8216a4e7e
[IL63] Pull up X,Y processing, step 2
...
This also fixes the coordinates passed to logOnDelete and
log onSeparator.
Bug: 8636060
Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
2014-01-22 14:42:52 +09:00
2b38b5e8e6
[IL62] Pull up X,Y processing, step 1
...
This is fine because getKey{X,Y} is idempotent for any
non-keyboard coordinate value.
However this makes a net change : the x,y values passed to
LatinImeLoggerUtils.onNonSeparator are now different.
The point is however that they used to be wrong. The logged
values used not to account for the keyboard padding that
is present on tablets, and in the simulating tools we don't
know about that padding so we couldn't use the coordinates.
The catch here is that other calls like LoggerUtils.onSeparator
should follow suit, but this is too big a change to do it at once.
Follow-up changes will fix them too.
Bug: 8636060
Change-Id: If4b3d3cb1ed4b44c35f23e66aba3b5797236bba7
2014-01-22 14:41:45 +09:00
591580ee8a
Merge "[IL61] Remove an internal use of key coordinates"
2014-01-22 05:19:45 +00:00
6e15af2626
Merge "Fix newline string resource"
2014-01-20 10:45:11 +00:00
c93cf1c398
Use sorted int[] to represent word separators
...
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
2014-01-20 19:40:02 +09:00
08ce454aa5
Fix newline string resource
...
The newline string resource "\n" doesn't work off-device simulation.
Bug: 12623502
Change-Id: I3ad63d8afe50be174493d43f00f7191062c87cb7
2014-01-20 19:36:20 +09:00
5b6ebdbe9e
Merge "Refactor logic to retrieve relevant suggestions a bit"
2014-01-20 09:57:43 +00:00
837cdd738b
Add SpacingAndPunctuationsTests
...
Change-Id: I78d488ad84a11af809ee1f8d3d2fa01a89fbfa28
2014-01-20 18:33:45 +09:00
3033cc51b8
Refactor logic to retrieve relevant suggestions a bit
...
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
2014-01-20 12:08:25 +09:00
3f3b0af5b7
Merge "Fix unit tests by adding @UsedForTesting"
2014-01-19 22:47:03 +00:00
fde4c5f128
Fix unit tests by adding @UsedForTesting
...
Change-Id: I2d2d226e21a46239077394ab09db88a4bd563460
2014-01-19 13:37:23 -08:00
b1814c9633
Merge "Make contacts dict and user dict version 4."
2014-01-17 20:05:17 +00:00
ed95d79cc4
Make contacts dict and user dict version 4.
...
Bug: 12515251
Change-Id: I0b332e03b9102957bffaea56d4de17b9ee3cef23
2014-01-17 10:30:16 -08:00
6a18af634e
Refactor RichInputConnection a bit
...
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
2014-01-17 13:14:29 +09:00
2334bf6d8c
Merge "Fix a bug specific to German capitalization."
2014-01-17 01:49:14 +00:00
e4f584de73
Merge "[IL60] Make InputLogicHandler package private"
2014-01-16 18:15:15 +00:00
87f87d9ac5
Merge "[IL59] Rename a method"
2014-01-16 18:13:39 +00:00
9c9c43c0b7
Merge "[IL58] Simplification"
2014-01-16 17:45:59 +00:00
f4bf620502
Merge "Add a dedicated method to control time in native code."
2014-01-16 17:25:29 +00:00
ab4543d593
[IL61] Remove an internal use of key coordinates
...
Bug: 8636060
Change-Id: Id87b0ac4a99ec6a26db6e250d6cd22defc02a23d
2014-01-17 02:10:56 +09:00
81255612bc
[IL60] Make InputLogicHandler package private
...
Yay
Bug: 8636060
Change-Id: Iad9c3804504635094e861999198f4baf70e61955
2014-01-17 02:10:56 +09:00
17bd129faf
[IL59] Rename a method
...
Um... this is not async ? Remove that from the name
Bug: 8636060
Change-Id: Ida5f9bd6929eae75103eb2e3fb866ed7468af806
2014-01-17 02:10:56 +09:00
ac6dfaf80b
[IL58] Simplification
...
No need to test multiple times for this. Let's just never do useless
stuff, and only test for that once.
Bug: 8636060
Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
2014-01-17 02:10:51 +09:00
60afa7000f
Fix a bug specific to German capitalization.
...
Bug: 9663105
Change-Id: Ib68ee4edb135e96dfca229c1ccce308e7e638bdd
2014-01-17 02:06:24 +09:00
9e882e3937
Merge "Update personalization dict via dictionary facilitator."
2014-01-16 02:00:21 +00:00
12474634c5
Update personalization dict via dictionary facilitator.
...
Change-Id: I512c41e12d8d31f03b5df6ad03bf7711611c80f5
2014-01-15 17:54:17 -08:00
0851ac5726
Merge "Import translations. DO NOT MERGE"
2014-01-16 00:49:15 +00:00
5802fb05a8
Import translations. DO NOT MERGE
...
Change-Id: I9d276ae4391f209e2db3a080b3221e5a8aa59938
Auto-generated-cl: translation import
2014-01-15 16:42:37 -08:00
d78a447d10
Add a dedicated method to control time in native code.
...
Bug: 12443085
Change-Id: I41a5cf6c895cb59e54af98b40efded36afcd3247
2014-01-15 14:55:57 -08:00
2c1a13c56c
Merge "[IL57] Don't require a main dict suggestion."
2014-01-15 22:14:27 +00:00
118a4fc2b7
Merge "[IL56] Don't erase suggestions when reverting a commit."
2014-01-15 19:21:06 +00:00
e22e67e37a
[IL57] Don't require a main dict suggestion.
...
This is bad for recorrection (it will ignore recorrection suggestions).
But if you think about it well, if you didn't have a main dict, then you
probably will compute the same stuff anyway. It's not useful
to make this check at all.
Bug: 12297051
Change-Id: I6d6cf4d9353b7c668c5413c67701563b243e585c
2014-01-16 03:22:51 +09:00
4752b68f5a
[IL56] Don't erase suggestions when reverting a commit.
...
Bug: 12297051
Change-Id: Iffa1c98b8fe2b816c3ac6bc171037288107f637d
2014-01-16 03:22:46 +09:00
20a8a4a3d9
Fix native method signature
...
Change-Id: Ia2d566f162f746c6b2b2b874f7278d86abd9e839
2014-01-15 18:56:40 +09:00
01c1a1a2ba
Refactor LanguageModelParam class a bit
...
This change must be checked in together with I9ecfd1adc1.
Change-Id: I26f8c17d6347b75dba6abb3d73239f4052327dae
2014-01-15 17:46:32 +09:00
17a2bcfcce
Make final Locale field public
...
This change must be checked in together with Id9382498a8.
Change-Id: I804d78969bccf8bdc224477bd64c8ac12c1ab0d6
2014-01-15 17:11:54 +09:00
b8a2772b0e
Consolidate LanguageModelParam constructors
...
Change-Id: I142651d1f268456a5901da524cbe55d315f76d28
2014-01-15 16:17:53 +09:00
7b9b095090
Move LanguageModelParams class to utility package
...
This change must be checked in together with Ic82d951237.
Change-Id: I2ab451330f85a0147563b805682f26edecb71a29
2014-01-15 16:14:53 +09:00
2d1e72b774
Merge "Revert "Disable Nepali layouts temporarily per product call""
2014-01-15 03:50:58 +00:00
27274601e7
Merge "Revert "Remove Azerbaijani subtype""
2014-01-15 03:32:55 +00:00
4d1620f895
Revert "Disable Nepali layouts temporarily per product call"
...
This reverts Id58cdf117d.
This also partially reverts I99be3d54d3.
This change must be checked in together with Ied923ed80b.
Bug: 6910787
Change-Id: Icdeee1b93a6b626b43fefc06d3bb3fe40d2e056b
2014-01-15 12:31:44 +09:00
7ae9efbb6a
Revert "Remove Azerbaijani subtype"
...
This reverts I0d2a98dffe.
This also partially reverts I99be3d54d3.
This change must be checked in together with Ibf49c89832.
Bug: 7963448
Change-Id: Idbb3e1ac9f4e067a0051f618946a345632102fb3
2014-01-15 12:13:25 +09:00
68069c55c4
Fix flaky unit test.
...
Change-Id: I8df0f9a0398b29f679844f256ad84f09ebcea8ee
2014-01-14 18:51:29 -08:00
4f8e678bab
Revert "Revert "Disable Nepali layouts temporarily per product call""
...
This reverts commit 93fdfc110b
2014-01-14 12:44:11 +00:00
93fdfc110b
Revert "Disable Nepali layouts temporarily per product call"
...
This reverts Id58cdf117d.
This also partially reverts I456268b68f.
This change must be checked in together with I4d5c8ffa45.
Bug: 6910787
Change-Id: I59ba69f1b14164edea8eddf3784554a29a97e9b3
2014-01-14 17:39:24 +09:00
6584d42b02
Merge "Move phrase gesture related string resources to AOSP"
2014-01-14 08:20:14 +00:00
7504913807
Move phrase gesture related string resources to AOSP
...
This change must be checked in together with Ica8fc5135.
Change-Id: I288d7083391954f1266a9b77ee4ffc0bc9d4229d
2014-01-14 17:15:41 +09:00
bf418f7cba
Pass time stamp to addToUserHistory method as an argument
...
Bug: 12179576
Change-Id: I93037ee2aa7c0432400fe2f93fb60d2e60f70f5f
2014-01-14 15:48:08 +09:00
62df0a6d53
Merge "Update dictionaries"
2014-01-14 03:44:20 +00:00
155cb77231
Update dictionaries
...
This change has no effect on TRT results.
>>> dictionaries/en_US_wordlist.combined.gz
Header :
date : 1381226409 <=> 1389654051
version : 42 <=> 43
Body :
Added: dialogue 120
Added: dialogues 94
>>> dictionaries/fr_wordlist.combined.gz
Header :
date : 1381226409 <=> 1389654052
version : 42 <=> 43
Body :
Deleted: d'Orange 114
Added: d'orange 114
>>> dictionaries/it_wordlist.combined.gz
Header :
date : 1380519383 <=> 1389654052
version : 40 <=> 43
Body :
Freq changed: ciao 85 -> 180
>>> java/res/raw/main_fr.dict
Header :
date : 1381226409 <=> 1389654052
version : 42 <=> 43
Body :
Deleted: d'Orange 114
Added: d'orange 114
>>> java/res/raw/main_it.dict
Header :
date : 1380519383 <=> 1389654052
version : 40 <=> 43
Body :
Freq changed: ciao 85 -> 180
Bug: 12487270
Bug: 12344108
Change-Id: I94768e223d05ad2551a5508e9e01222a028665c4
2014-01-14 10:37:15 +09:00
9fa6663403
Import translations. DO NOT MERGE
...
Change-Id: I3233aa7d5f64fbf8818e0065cd1da47d84070fb6
Auto-generated-cl: translation import
2014-01-13 16:31:58 -08:00
5717c63a2b
Fix possible NPE in DictionaryFacilitatorForSuggest.
...
Change-Id: I57792b7417b5f1acbb99e6ea60250eb44b193785
2014-01-10 21:42:08 +09:00
db0adf86a4
Merge "[IL55] Remove a useless argument."
2014-01-10 11:36:01 +00:00
eb66f1906d
Merge "Check corpus handles during startup for personalization."
2014-01-10 11:34:39 +00:00
6c24b91601
[IL55] Remove a useless argument.
...
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
2014-01-10 20:28:50 +09:00
eb28bac542
Check corpus handles during startup for personalization.
...
Bug: 12479792
Change-Id: I62fd75d4bebd28afebd9631e865f5d59385511e7
2014-01-10 20:28:30 +09:00
4be9137609
Merge "[IL54.5] Use the cursor pos estimate, not the last value"
2014-01-10 10:46:27 +00:00
a224aafea3
[IL54.5] Use the cursor pos estimate, not the last value
...
For edit tasks, the estimate is actually the right thing to use.
This is really dangerous, but it will get rid of pretty much all
race conditions.
Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
2014-01-10 19:08:47 +09:00
f96e0f07af
Merge "Periodic wipe of the personalization dict."
2014-01-10 09:31:22 +00:00
ba07df7fc1
Periodic wipe of the personalization dict.
...
Bug: 12216453
Change-Id: Ie59dd19c044e9b1eb9b8bd805366200737ea506a
2014-01-10 16:30:59 +09:00
ecf46df226
[IL54] Add a mirror method to fix the cursor pos estimate
...
This just mirrors what InputLogic#tryFixLyingCursorPosition
is doing. That method will go away in the next change.
Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
2014-01-10 16:05:02 +09:00
6fbe83be7a
[IL53] Fix a wrong test.
...
This test was intended only for cases without a selection, and as
a safety net for cases where the app would pretend the cursor
is at N but we can get P chars from the editor where P > N.
When there is a selection, this is wrong. In the practice it works
because these values are not used in this case, but it's still wrong.
The case where P > N is arguable, but actually I see little reason
to trust the getTextBeforeCursor() method more than the
onUpdate selection method. Plus in the practice, I don't think
we are aware of any app with this bug, and it's probably not a
great idea to be too robust about this as it may encourage wrong
values sent to onUpdateSelection.
Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
2014-01-10 15:21:20 +09:00
958e452025
Merge "Fix an NPE."
2014-01-10 05:13:47 +00:00
e1de87ae69
Fix an NPE.
...
Bug: 12397228
Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
2014-01-10 13:46:37 +09:00
84a3047e80
Fix build.
...
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
2014-01-10 12:18:26 +09:00
ee35e69eae
Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
...
This change must be checked in together with Iec437d6df0.
Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
2014-01-09 19:05:09 +09:00
494e2d6c17
Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
...
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
2014-01-09 18:33:25 +09:00
d7660c6f56
Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode"
2014-01-09 09:31:32 +00:00
c912b2228a
Merge "Add American typography boolean to SpacingAndPunctuations"
2014-01-09 09:31:24 +00:00
0a75cf51af
Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode
...
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
2014-01-09 18:19:17 +09:00
860c3b8e8c
Add American typography boolean to SpacingAndPunctuations
...
Change-Id: Ic2663eaef38fbe7c5bd1fb3a81771e94c2d4de52
2014-01-09 18:17:29 +09:00
6c326caa4f
A style fix
...
Just a style fix to follow up the previous commit.
BUG: 11439600
Change-Id: Ib7a4654627a6fc22d86f2097f86f001bd76426e9
2014-01-09 15:54:47 +09:00
b30f7e4bce
Merge "Check whether the word is OOV or not for amanatto update."
2014-01-09 06:24:17 +00:00
eab4d25210
Merge "Remove some warnings"
2014-01-09 05:45:10 +00:00
c1f2986a72
Merge "Trigger haptic feedback at touch down on the EmojiPalettesView"
2014-01-09 05:19:37 +00:00
b11339b3ab
Remove some warnings
...
Change-Id: I5cfa0d2fccc139bd6c45c5590a68c3e0c90534b8
2014-01-09 14:04:34 +09:00
d3e78fc5ce
Merge "Fix a bug where changing auto-shift would cancel autorepeat."
2014-01-09 04:53:34 +00:00
5cbda70956
Fix a bug where changing auto-shift would cancel autorepeat.
...
Bug: 12453966
Change-Id: Idd65f732e2de0a7309e08315893c28cca63732c5
2014-01-09 12:57:10 +09:00
df10aeb1da
Trigger haptic feedback at touch down on the EmojiPalettesView
...
EmojiPalettesView triggers the haptic feedback at the timing of touch-up rather than touch-down.
This patch set changes the timing to touch-up so that the UX on the EmojiPalettesView can be consistent with normal keyboard layouts.
This patch set also fixes the missing haptic feedback from facemarks such as ":-)".
Bug: 11439600
Change-Id: I22245946712bd1c36226786d6ff81e3b563f7ef7
2014-01-09 12:27:31 +09:00
941a4540bc
Import translations. DO NOT MERGE
...
Change-Id: Ia2d0f4528529df463307e1706cd4d7265b3958c1
Auto-generated-cl: translation import
2014-01-08 13:45:51 -08:00
05113c1847
Check whether the word is OOV or not for amanatto update.
...
Bug: 11736529
Change-Id: I27973212da7e922b2185dbb4febfb5bb4dfbdcbb
2014-01-08 21:02:35 +09:00
5742a415f3
Merge "Make reloadMainDict() private."
2014-01-08 11:03:02 +00:00
9f1fe87580
Make reloadMainDict() private.
...
Bug: 8187060
Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
2014-01-08 18:59:43 +09:00
b90fa0fb2c
Revert "Revert "Separate spacing and punctuation related settings values""
...
This reverts commit 8bc427799a
2014-01-08 18:08:01 +09:00
e5cdcaff65
Fix a race condition, take 2.
...
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.
Bug: 12390573
Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
2014-01-08 18:04:44 +09:00
1e7f2809d2
Merge "Revert "Separate spacing and punctuation related settings values""
2014-01-08 09:03:15 +00:00
8bc427799a
Revert "Separate spacing and punctuation related settings values"
...
This is conflicting with later changes. Temporary revert for cherry-pick.
This reverts commit 0b593ce858
2014-01-08 09:00:45 +00:00
d4843c25e2
Merge "Revert "Fix a race condition, take 2.""
2014-01-08 09:00:18 +00:00
a247264dc6
Revert "Fix a race condition, take 2."
...
Conflicts prevent this to be cherry-picked.
This reverts commit dd3d697a6e
2014-01-08 08:59:26 +00:00
ff7103d356
Merge "Fix a race condition, take 2."
2014-01-08 08:35:24 +00:00
0a0a3cdad8
Merge "Revert "Revert "Fix a race condition."""
2014-01-08 08:35:19 +00:00
dd3d697a6e
Fix a race condition, take 2.
...
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.
Bug: 12390573
Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
2014-01-08 17:19:29 +09:00
Jean Chalard
Tadashi G. Takaoka
Yohei Yukawa
Ken Wakasa
Keisuke Kuroyanagi
Baligh Uddin
Geoff Mendal
Narayan Kamath