Jean Chalard
0c186c31d2
Merge "[IL106] Inline a now useless method."
2014-01-30 03:47:32 +00:00
Jean Chalard
90c072a5ba
Merge "[IL105] Remove more useless arguments"
2014-01-30 03:46:08 +00:00
Jean Chalard
362779d608
Merge "[IL104] Remove useless arguments"
2014-01-30 03:45:15 +00:00
Jean Chalard
e5040f6b0d
Merge "[IL103] Save the typed word separately in SuggestedWords."
2014-01-30 03:44:54 +00:00
Keisuke Kuroyanagi
26bd46095a
Reading dictionary containing timestamps in Java Side.
...
Just skipping historical information fields.
Bug: 11281877
Change-Id: I43d2adaa576b7da11ed3ca54990265dbb6f53b08
2014-01-29 20:19:24 +09:00
Jean Chalard
ac84fe642e
[IL106] Inline a now useless method.
...
Bug: 8636060
Change-Id: Ic8e0225206358680aa0de421f17ab443c888036d
2014-01-29 12:23:40 +09:00
Jean Chalard
fa7075768d
[IL105] Remove more useless arguments
...
Bug: 8636060
Change-Id: I9e817bb9622c84544a5ca8708e5c1fccad1ed447
2014-01-29 12:23:26 +09:00
Jean Chalard
084c9961f4
[IL104] Remove useless arguments
...
Bug: 8636060
Change-Id: I97a371fe0c6227eb0f03d3e391a33726e6280322
2014-01-29 12:23:25 +09:00
Jean Chalard
1d2e4f9dcc
[IL103] Save the typed word separately in SuggestedWords.
...
This helps managing the cases where the typed word is not
in the suggestions. This happens during recorrection.
Bug: 8636060
Change-Id: I6784feb793cae96272a7f1d123a0e3bbb8f03143
2014-01-29 12:22:21 +09:00
Tadashi G. Takaoka
a454a7b85c
Add method to clear user history dictionary for testing
...
This change should be checked in together with I19cd689157.
Bug: 12179576
Change-Id: I5cc9f52a37ad6623809a14575f3f4b1cd18725c3
2014-01-29 12:01:37 +09:00
Tadashi G. Takaoka
005d2454c9
Merge "Remove suggestion_word and suggestion_info layout files"
2014-01-29 01:05:37 +00:00
Yohei Yukawa
be18530acf
Merge "Fix inconsistent behavior with the back-to-the-main-keyboard key"
2014-01-28 10:50:23 +00:00
Tadashi G. Takaoka
c2ea3f7dd9
Remove suggestion_word and suggestion_info layout files
...
Change-Id: I37fea41cfc6e717ce7e5aa36ad331675fc9e8ce5
2014-01-28 19:38:35 +09:00
Yohei Yukawa
576f8a5b72
Fix inconsistent behavior with the back-to-the-main-keyboard key
...
With this patch, the back-to-the-main-keyboard in the Emoji
palette will be registered as a key-release action instead of
a key-press action, like switch-to-the-emoji-palette in the
main layout. This provides mroe consistent UX when the layout is
switched from the main layout to the Emoji palette then
switched back to the main layout.
BUG: 12464067
Change-Id: Ia0d0185db43234dfcfb7cee2677f3d199fe6ed96
2014-01-28 19:30:27 +09:00
Jean Chalard
c9cc1b1de5
[IL102] Rename a method
...
Bug: 8636060
Change-Id: Ia54afdfab9124aa5c35699e357e63eae66a7557f
2014-01-28 17:18:02 +09:00
Jean Chalard
4500dedfa9
[IL101] Remove a method
...
Bug: 8636060
Change-Id: Ic9c12fc6970987b0e1912e8ae85bed55260d66b5
2014-01-28 17:18:02 +09:00
Jean Chalard
675f1dbaf0
[IL98] Refactoring of setSuggestedWords
...
Bug: 8636060
Change-Id: Iab53df96f2c23bddc6c70c3560b380fbaef1053c
2014-01-28 17:18:01 +09:00
Jean Chalard
491a6a6f23
[IL100] Pull up a check
...
Bug: 8636060
Change-Id: I344ed59f5f55b412880fc6dc70205eecb1e79961
2014-01-28 17:18:01 +09:00
Jean Chalard
4761d2fb00
[IL99] Migrate some code to InputLogic.
...
Bug: 8636060
Change-Id: Ibf1f9c7bdc3fdd872d6c15447fa555434485cc52
2014-01-28 17:18:01 +09:00
Jean Chalard
eb00023b9b
[IL97] Readability improvement
...
Bug: 8636060
Change-Id: I6b15c7fb91cd4cf23a993541c19842b51e328f8f
2014-01-28 17:17:58 +09:00
Tadashi G. Takaoka
95e5e267ac
Merge "Suggestion strip honors RTL layout"
2014-01-28 07:52:25 +00:00
Keisuke Kuroyanagi
25270ec540
Merge "Check probability before adding to the user history dict."
2014-01-28 07:35:31 +00:00
Jean Chalard
36fda2bae3
Merge "[IL96] Inline a method"
2014-01-28 07:31:48 +00:00
Keisuke Kuroyanagi
90ac041c9f
Check probability before adding to the user history dict.
...
Bug: 12764888
Change-Id: I5da3ef21d9d82b7034e7dc9b7d0fdca0d48a49f4
2014-01-28 16:31:37 +09:00
Jean Chalard
7593f93565
Merge "[IL95] Inline a method that's always called in sequence"
2014-01-28 07:31:31 +00:00
Tadashi G. Takaoka
bcd30bf3e7
Suggestion strip honors RTL layout
...
Bug: 9126496
Change-Id: Ia4a1c52bd2a80ea7fe6b9529f2767fee5f9e8aeb
2014-01-28 15:47:54 +09:00
Jean Chalard
86210c7dc7
[IL96] Inline a method
...
Bug: 8636060
Change-Id: I517591c484dce74788398cf4a4db9a074d91a6c0
2014-01-28 15:47:04 +09:00
Jean Chalard
90916143b6
[IL95] Inline a method that's always called in sequence
...
Bug: 8636060
Change-Id: I514cf14596b3fa46eccadcf536342e4bb805708d
2014-01-28 15:47:01 +09:00
Tadashi G. Takaoka
02b087090e
Merge "Fix test fails caused by I8bede13c87"
2014-01-28 05:19:53 +00:00
Yohei Yukawa
0272553578
Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete."
2014-01-28 05:06:07 +00:00
Yohei Yukawa
0e04c24a05
Fix inconsistent behavior with the spacebar on the Emoji pallete.
...
On the Emoji palette, unlike other layouts, a user could not
cancel events by moving the finger away from the spacebar.
With this patch, the actual handler of the spacebar will be
registered as onClick event, which will not occur when the user
cancel the event.
Bug: 12464067
Change-Id: I7e7e11ae5f17073e5d92116adca0702579d3ae9c
2014-01-28 13:44:31 +09:00
Jean Chalard
ca1c1ddd4e
Merge "[IL94] Remove a function and some reordering"
2014-01-28 03:46:28 +00:00
Jean Chalard
9909d6aa49
Merge "[IL93] Refactor a method inside another"
2014-01-28 03:32:52 +00:00
Jean Chalard
cbf54dea49
Merge "[IL92] Straighten out showSuggestionStripWithTypedWord"
2014-01-28 03:32:17 +00:00
Jean Chalard
5a1f837356
Merge "[IL91] Call reorder"
2014-01-28 03:26:23 +00:00
Tadashi G. Takaoka
9ac6c9064d
Fix test fails caused by I8bede13c87
...
Change-Id: I1e816bf7ea5fd46b39c2482bbcbfcdc16d5acc21
2014-01-28 11:17:47 +09:00
Tadashi G. Takaoka
c2e2b3949b
Merge "Add SubtypeLocaleUtils.isRtlLanguage method"
2014-01-28 01:28:47 +00:00
Baligh Uddin
16a9bb3da8
Import translations. DO NOT MERGE
...
Change-Id: I9632cf713ad9e1bba1df5819c4038739229f7ec2
Auto-generated-cl: translation import
2014-01-27 14:42:02 -08:00
Jean Chalard
5b5e877efe
[IL94] Remove a function and some reordering
...
Bug: 8636060
Change-Id: I4baa237c9c7b58a8eb4158c34b9d3f3dfb95c69c
2014-01-27 20:38:45 +09:00
Jean Chalard
37e1cc931f
[IL93] Refactor a method inside another
...
The calls to setAutoCorrectionIndicator with a constant are
always the exact same as mWillAutoCorrect.
Bug: 8636060
Change-Id: I8106919819b978b0a9655af2ef444664fad4c1ad
2014-01-27 20:38:45 +09:00
Jean Chalard
4c6029e530
[IL92] Straighten out showSuggestionStripWithTypedWord
...
Bug: 8636060
Change-Id: I066ff29c76349f0ab61441ea5f7bc9085d24bdbc
2014-01-27 20:38:45 +09:00
Jean Chalard
c6367ee64d
[IL91] Call reorder
...
Bug: 8636060
Change-Id: I3d0ce6dcb3b51cabc424d00a397d243c32360e92
2014-01-27 20:38:43 +09:00
Jean Chalard
01893b25dd
Merge "[IL90] Small refactoring"
2014-01-27 11:18:52 +00:00
Jean Chalard
3f226af439
Merge "[IL89] Inline a function"
2014-01-27 11:18:19 +00:00
Jean Chalard
5b9e54c135
Merge "[IL88] Simple refactoring"
2014-01-27 11:17:54 +00:00
Jean Chalard
8f3e37a631
Merge "[IL87] Remove a call to clearSuggestionStrip"
2014-01-27 11:17:45 +00:00
Jean Chalard
521a83a3f1
Merge "[IL86] Simplification and correctness fix."
2014-01-27 11:17:31 +00:00
Jean Chalard
7aa7e36611
Merge "[IL85] Maybe show punctuations when app completions are null"
2014-01-27 11:17:18 +00:00
Jean Chalard
264f4e380d
Merge "[IL84] Remove a useless call and rename a method"
2014-01-27 11:17:05 +00:00
Jean Chalard
7ac542d490
Merge "[IL83] Inline a call"
2014-01-27 11:16:30 +00:00
Jean Chalard
47ff423121
Merge "[IL82] Fix a wrong comment"
2014-01-27 10:11:42 +00:00
Jean Chalard
75ec579e07
Merge "[IL81] Remove a useless test."
2014-01-27 10:11:14 +00:00
Tadashi G. Takaoka
c0c74d22a0
Add SubtypeLocaleUtils.isRtlLanguage method
...
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
2014-01-27 19:05:16 +09:00
Jean Chalard
6d1c8b2c3f
Merge "Try to figure out whether d.quotes open or close."
2014-01-27 10:01:17 +00:00
Jean Chalard
b084da2ae6
Merge changes I5092942a,I931c553f
...
* changes:
[IL80] Reverse a test for clarity.
[IL79] Some refactoring
2014-01-27 10:00:37 +00:00
Jean Chalard
a3a85e8c2b
Merge "[IL78] Move most of onUpdateSelection to InputLogic."
2014-01-27 09:55:08 +00:00
Jean Chalard
d38b0468b0
[IL90] Small refactoring
...
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
2014-01-27 18:42:33 +09:00
Jean Chalard
33ff321d6c
[IL89] Inline a function
...
We will then refactor the contents of showSuggestionStripWithTypedWord
Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
2014-01-27 18:42:33 +09:00
Jean Chalard
ca819178a1
[IL88] Simple refactoring
...
With this, the value passed to suggestedWords is never null.
Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
2014-01-27 18:42:33 +09:00
Jean Chalard
d90bdd2187
[IL87] Remove a call to clearSuggestionStrip
...
The goal is to remove the function completely.
Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
2014-01-27 18:42:33 +09:00
Jean Chalard
3b939ed77f
[IL86] Simplification and correctness fix.
...
This should be what was intended.
Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
2014-01-27 18:42:33 +09:00
Jean Chalard
07eddf3c43
[IL85] Maybe show punctuations when app completions are null
...
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.
Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
2014-01-27 18:42:32 +09:00
Jean Chalard
b2c0388a69
[IL84] Remove a useless call and rename a method
...
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
2014-01-27 18:42:32 +09:00
Jean Chalard
eb190ab32f
[IL83] Inline a call
...
The coming string of changes is very complicated, so
I'm going to do things really slowly.
Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
2014-01-27 18:42:32 +09:00
Jean Chalard
17f1528f9e
[IL82] Fix a wrong comment
...
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
2014-01-27 18:42:32 +09:00
Jean Chalard
abbd755689
[IL81] Remove a useless test.
...
It seems the comments were right all along. This seems to really
be useless.
Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
2014-01-27 18:42:32 +09:00
Jean Chalard
f1e5b9b4d1
[IL80] Reverse a test for clarity.
...
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
2014-01-27 18:42:32 +09:00
Jean Chalard
f59487379e
[IL79] Some refactoring
...
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
2014-01-27 18:42:29 +09:00
Jean Chalard
10460441db
[IL78] Move most of onUpdateSelection to InputLogic.
...
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
2014-01-27 18:42:04 +09:00
Tadashi G. Takaoka
1e4b1300e6
Merge "Refactor SuggestionsStripLayoutHelper class"
2014-01-27 09:36:52 +00:00
Jean Chalard
68d7291a6b
Merge "[IL77] Remove refs to Settings from InputLogic"
2014-01-27 09:29:50 +00:00
Tadashi G. Takaoka
148dedbc5d
Refactor SuggestionsStripLayoutHelper class
...
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
2014-01-27 18:25:25 +09:00
Jean Chalard
7bee84095e
Merge "[IL75] Move the SubtypeSwitcher out of InputLogic."
2014-01-27 09:24:10 +00:00
Tadashi G. Takaoka
829ad708db
Merge "Revert "Use ViewCompat support library""
2014-01-27 09:20:19 +00:00
Jean Chalard
48df380f78
[IL77] Remove refs to Settings from InputLogic
...
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
2014-01-27 18:18:54 +09:00
Jean Chalard
969c06072d
[IL75] Move the SubtypeSwitcher out of InputLogic.
...
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
2014-01-27 18:18:27 +09:00
Jean Chalard
c7ef305bbc
Try to figure out whether d.quotes open or close.
...
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
2014-01-27 18:17:33 +09:00
Tadashi G. Takaoka
e4692c0050
Revert "Use ViewCompat support library"
...
This reverts commit e7ee4fa862
.
Change-Id: I56fab60ac859289d3ed51f691cd7e2a15da01856
2014-01-27 18:14:40 +09:00
Jean Chalard
5cf70a1d44
Merge "[IL74] Remove unused/unwanted arguments to a method."
2014-01-27 08:57:12 +00:00
Yohei Yukawa
0b58617951
Merge "Fix inconsistent behavior with backspace in the Emoji pallete."
2014-01-27 08:11:51 +00:00
Jean Chalard
0fd556ceca
[IL74] Remove unused/unwanted arguments to a method.
...
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
2014-01-27 16:48:17 +09:00
Yohei Yukawa
ea8c1c811c
Fix inconsistent behavior with backspace in the Emoji pallete.
...
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
the key.
This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
subsequent delete key events when the finger is moved away
from the key area.
Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
2014-01-27 16:24:51 +09:00
Tadashi G. Takaoka
f3ca92dd33
Merge "Use ViewCompat support library"
2014-01-27 07:21:41 +00:00
Tadashi G. Takaoka
e7ee4fa862
Use ViewCompat support library
...
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
2014-01-27 16:11:03 +09:00
Ken Wakasa
03283b636c
Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
...
some cleanups as well
Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
2014-01-27 16:08:27 +09:00
Keisuke Kuroyanagi
95043145df
Merge "Check length of words for personalization dict."
2014-01-25 00:44:58 +00:00
Keisuke Kuroyanagi
b7197b705b
Check length of words for personalization dict.
...
Bug: 12602903
Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
2014-01-24 16:32:28 -08:00
Ken Wakasa
0acd121083
Fix wrong indents.
...
Removed an unused method too.
Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
2014-01-24 23:55:33 +09:00
Jean Chalard
b6e128cc05
Merge "[IL69.1] Move a static method to a utility class."
2014-01-24 03:04:12 +00:00
Jean Chalard
1d6e647ac3
[IL69.1] Move a static method to a utility class.
...
This is a followup to IL69.
Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
2014-01-24 11:59:23 +09:00
Jean Chalard
0c72529088
Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer"
2014-01-24 01:55:57 +00:00
Baligh Uddin
6a39811d90
Merge "Import translations. DO NOT MERGE"
2014-01-23 21:02:33 +00:00
Baligh Uddin
5047b4aa84
Import translations. DO NOT MERGE
...
Change-Id: Ib5a8be5d9ac508d57648e4e8811805eea4355fc3
Auto-generated-cl: translation import
2014-01-23 12:25:35 -08:00
Baligh Uddin
2efb58fc98
Import translations. DO NOT MERGE
...
Change-Id: I6c8aa53b9be4c3aa5822a820cc8cfdc3cf31c390
Auto-generated-cl: translation import
2014-01-23 12:22:23 -08:00
Jean Chalard
3aa2043a66
Merge "[IL76] Remove a SuggestionStripView dependency"
2014-01-23 10:06:42 +00:00
Jean Chalard
f16a2a36d2
[IL71.1] Add some javadoc.
...
Change-Id: I382abd3104d535a1e868935d8cfb4e34ad8ebaed
2014-01-23 17:11:47 +09:00
Jean Chalard
a1ed211c4e
[IL76] Remove a SuggestionStripView dependency
...
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.
Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
2014-01-23 16:25:48 +09:00
Jean Chalard
4173610bc5
[IL66.1] Add a comment
...
Followup to IL66
Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
2014-01-23 16:00:49 +09:00
Jean Chalard
be846fc352
[IL73] Remove all refs to Key and Keyboard in WordComposer
...
Please hold my gun while I have this nice cup of tea.
Yes !!
Bug: 8636060
Change-Id: I33c8ffe51bb2106b17f7941235ad1e427e3a81f7
2014-01-23 15:52:29 +09:00
Jean Chalard
df8310c6e2
Merge "[IL71] Add indices to toCodePointArray."
2014-01-23 06:50:19 +00:00