Commit Graph

10116 Commits (0917b6fd8f07bd3f1f35a55ec9e045f09cb98a82)

Author SHA1 Message Date
Jean Chalard 80d413caff Merge "Straighten out database cursors behavior." 2014-02-18 11:09:38 +00:00
Jean Chalard 6eb49ba835 am 28e0b249: Merge "Fix a bug where the cache would be out of sync"
* commit '28e0b249650d08f25f2b7da8034e09a244be825c':
  Fix a bug where the cache would be out of sync
2014-02-18 03:01:35 -08:00
Jean Chalard 28e0b24965 Merge "Fix a bug where the cache would be out of sync" 2014-02-18 10:58:50 +00:00
Jean Chalard b8ff8ca9d9 Straighten out database cursors behavior.
Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.

It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.

Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
2014-02-18 19:58:23 +09:00
Jean Chalard fe92c174ea Fix a bug where the cache would be out of sync
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.

Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
2014-02-18 19:55:54 +09:00
Jean Chalard db10e81973 am 783dabb8: Merge "Cleanup."
* commit '783dabb812d983a7c56dbb1071145c5e58da9ff1':
  Cleanup.
2014-02-18 01:56:57 -08:00
Jean Chalard 783dabb812 Merge "Cleanup." 2014-02-18 09:54:33 +00:00
Jean Chalard 63be066544 Cleanup.
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.

Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
2014-02-18 17:07:46 +09:00
Ken Wakasa f2131ad92d am 266c8c5b: Merge "Some cosmetic fixes in LatinIME.java"
* commit '266c8c5b1dbccbc4252fb79f042a4a5660c62763':
  Some cosmetic fixes in LatinIME.java
2014-02-17 22:10:57 -08:00
Ken Wakasa 266c8c5b1d Merge "Some cosmetic fixes in LatinIME.java" 2014-02-18 06:08:34 +00:00
Ken Wakasa 12ff7da19d Some cosmetic fixes in LatinIME.java
Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
2014-02-18 14:56:50 +09:00
Jean Chalard e0db1262b0 am db21fad1: Merge "Avoid crashing when the Content URL is not found."
* commit 'db21fad18f70eb4abaf60a8c0ae7f285682acf20':
  Avoid crashing when the Content URL is not found.
2014-02-17 21:37:51 -08:00
Jean Chalard db21fad18f Merge "Avoid crashing when the Content URL is not found." 2014-02-18 05:35:54 +00:00
Jean Chalard 9967f0a1d0 Avoid crashing when the Content URL is not found.
I'm not sure when this can happen, but it seems it does
at least on older versions of the platform. Let's avoid
crashing.

Bug: 11618402
Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
2014-02-18 14:27:58 +09:00
Baligh Uddin 0f8134dc40 Merge "Import translations. DO NOT MERGE" 2014-02-18 04:58:14 +00:00
Baligh Uddin 51ffdd3733 Merge "Import translations. DO NOT MERGE" into jb-ub-latinimegoogle 2014-02-18 04:58:08 +00:00
Ken Wakasa 7db82a711a am 0d32643e: Merge "Cosmetic fixes"
* commit '0d32643e69dd75ba55ccca3c08d1478afb395125':
  Cosmetic fixes
2014-02-17 19:30:19 -08:00
Ken Wakasa 0d32643e69 Merge "Cosmetic fixes" 2014-02-18 03:28:04 +00:00
Ken Wakasa 2312c1954f Cosmetic fixes
Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
2014-02-18 12:17:24 +09:00
Tadashi G. Takaoka f6fb3e979f am cc05f468: Merge "Refactor InputAttributes a bit"
* commit 'cc05f468ca2599e6efd7517f5f946152ed2ad3b7':
  Refactor InputAttributes a bit
2014-02-17 18:27:20 -08:00
Tadashi G. Takaoka cc05f468ca Merge "Refactor InputAttributes a bit" 2014-02-18 02:25:46 +00:00
Baligh Uddin 3a73aa4182 Import translations. DO NOT MERGE
Change-Id: I2025fbb4b811c98f520ec048e4df4973da651709
Auto-generated-cl: translation import
2014-02-17 18:19:28 -08:00
Baligh Uddin 0f68ca6f03 Import translations. DO NOT MERGE
Change-Id: I7d2af0a3e69dd9f20369163141e9c71c8c6505e9
Auto-generated-cl: translation import
2014-02-17 18:18:34 -08:00
Baligh Uddin af78cea362 Import translations. DO NOT MERGE
Change-Id: I2dc0e76dc4c696c1a7e9748b55e1badd273aea09
Auto-generated-cl: translation import
2014-02-17 18:17:03 -08:00
Baligh Uddin 74aa40e0a2 Import translations. DO NOT MERGE
Change-Id: Icd3f92273190c481f98e176097d933c2078dad9d
Auto-generated-cl: translation import
2014-02-17 18:16:25 -08:00
Tadashi G. Takaoka b512946c90 am affdd364: Set neutral suggestions should be called after load settings
* commit 'affdd364232549d2062fc180f924f5b6496c26fd':
  Set neutral suggestions should be called after load settings
2014-02-17 18:12:12 -08:00
Tadashi G. Takaoka 06fbfc4951 Refactor InputAttributes a bit
Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
2014-02-18 11:11:36 +09:00
Tadashi G. Takaoka affdd36423 Set neutral suggestions should be called after load settings
Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
2014-02-18 11:04:00 +09:00
Tadashi G. Takaoka 4d46767585 am f0f4e9fc: Update important notice version even when user select Settings
* commit 'f0f4e9fc16f669f4499fb9de42362d8d52862ae2':
  Update important notice version even when user select Settings
2014-02-17 07:30:37 -08:00
Tadashi G. Takaoka f0f4e9fc16 Update important notice version even when user select Settings
Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
2014-02-18 00:14:30 +09:00
Jean Chalard 5828d1f3fa am 782c9fee: Merge "Don\'t resume suggestion on links."
* commit '782c9fee6bcb32d67c8ee9faa7e5c9dfb091afd3':
  Don't resume suggestion on links.
2014-02-17 03:48:50 -08:00
Jean Chalard 782c9fee6b Merge "Don't resume suggestion on links." 2014-02-17 11:46:54 +00:00
Jean Chalard 7a7aeffcdc Don't resume suggestion on links.
Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
2014-02-17 20:36:16 +09:00
Jean Chalard daf28b45a4 am d91cd991: Merge "Catch exceptions we can\'t do anything about."
* commit 'd91cd9919e309e72f912f5cb135792351d7081ac':
  Catch exceptions we can't do anything about.
2014-02-17 03:35:58 -08:00
Jean Chalard d91cd9919e Merge "Catch exceptions we can't do anything about." 2014-02-17 11:33:39 +00:00
Tadashi G. Takaoka 8a045cd6c3 am da0edf86: Merge "Stop overriding InputView.dispatchTouchEvent"
* commit 'da0edf86c412194483ac84b9a0961573f8377583':
  Stop overriding InputView.dispatchTouchEvent
2014-02-17 02:57:00 -08:00
Tadashi G. Takaoka da0edf86c4 Merge "Stop overriding InputView.dispatchTouchEvent" 2014-02-17 10:55:11 +00:00
Tadashi G. Takaoka 5cd732f8c5 Stop overriding InputView.dispatchTouchEvent
Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
2014-02-17 19:51:47 +09:00
Jean Chalard a149731a67 Catch exceptions we can't do anything about.
This also abstracts away the "package deactivated" case for
simpler and safer code.

Bug: 11072561
Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
2014-02-17 18:49:31 +09:00
Jean Chalard 0eb6486d73 am 1e9897b0: Merge "Consider non-breaking spaces separators."
* commit '1e9897b0c77b858ae479d531732b6795aaf0b2de':
  Consider non-breaking spaces separators.
2014-02-17 01:46:40 -08:00
Jean Chalard 1e9897b0c7 Merge "Consider non-breaking spaces separators." 2014-02-17 09:45:41 +00:00
Tadashi G. Takaoka fa00cf6536 am 891e4860: Merge "Stop overriding SuggestionStripView.dispatchTouchEvent"
* commit '891e4860f838d3dbe139542d4a1172b3de7a5225':
  Stop overriding SuggestionStripView.dispatchTouchEvent
2014-02-17 01:38:03 -08:00
Tadashi G. Takaoka 891e4860f8 Merge "Stop overriding SuggestionStripView.dispatchTouchEvent" 2014-02-17 09:20:54 +00:00
Jean Chalard c051ee7025 Consider non-breaking spaces separators.
Bug: 13056209
Change-Id: I6100b3ee21cf143140398757d9f7e7445067877a
2014-02-17 18:20:46 +09:00
Tadashi G. Takaoka e32548f32d Stop overriding SuggestionStripView.dispatchTouchEvent
Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
2014-02-17 18:11:10 +09:00
Tadashi G. Takaoka bf723b081a am 1751615f: Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent"
* commit '1751615f7d6702c6f3438a402e0ce179aafd15cf':
  Remove unnecessary override of MainKeyboardView.dispatchTouchEvent
2014-02-17 00:29:04 -08:00
Tadashi G. Takaoka 93441101ac am 3dd6bdf9: Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()"
* commit '3dd6bdf9312007ed43827975d121e972b98ab5e3':
  Add InputMethodSubtypeCompatUtils.isAsciiCapable()
2014-02-17 00:29:01 -08:00
Tadashi G. Takaoka 1751615f7d Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent" 2014-02-17 08:26:38 +00:00
Tadashi G. Takaoka 3dd6bdf931 Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()" 2014-02-17 08:25:57 +00:00
Tadashi G. Takaoka 800ab579a9 Remove unnecessary override of MainKeyboardView.dispatchTouchEvent
Bug: 11721001
Bug: 11976254
Change-Id: I762bd9e76ea31d67b3e31c3a0a19ee9f040015b8
2014-02-17 17:09:06 +09:00
Tadashi G. Takaoka 3c4213ea0e am 4c628b9d: Merge "Don\'t show important notice on password field"
* commit '4c628b9d5b05045e9bbe5be7327e28aee2309e1d':
  Don't show important notice on password field
2014-02-17 00:06:37 -08:00
Tadashi G. Takaoka 4c628b9d5b Merge "Don't show important notice on password field" 2014-02-17 08:04:11 +00:00
Tadashi G. Takaoka 20ddd4cff5 Add InputMethodSubtypeCompatUtils.isAsciiCapable()
Change-Id: I8145f090486f6fe30ef1e992db374cfba0c31012
2014-02-17 16:08:33 +09:00
Tadashi G. Takaoka ce78a2d8ab Don't show important notice on password field
Bug: 10587358
Change-Id: Ieff7960e5e2b8609fddeb173af578a5d9b2c4d98
2014-02-17 15:38:43 +09:00
Tadashi G. Takaoka f96e9cf172 am 4f4fb5ef: Merge "Use the same label of switch-to-alphabet key on Emoji palette"
* commit '4f4fb5ef345bebfed2c2d3fee5527a5f6b25a342':
  Use the same label of switch-to-alphabet key on Emoji palette
2014-02-16 22:18:16 -08:00
Tadashi G. Takaoka ec947ebfff am 4c680e7b: Merge "Add go to "Settings" button to important notice dialog"
* commit '4c680e7bcfe7737302f9900aea3f1d11f5e60b21':
  Add go to "Settings" button to important notice dialog
2014-02-16 22:18:13 -08:00
Tadashi G. Takaoka 4f4fb5ef34 Merge "Use the same label of switch-to-alphabet key on Emoji palette" 2014-02-17 06:13:39 +00:00
Tadashi G. Takaoka 4c680e7bcf Merge "Add go to "Settings" button to important notice dialog" 2014-02-17 06:13:26 +00:00
Tadashi G. Takaoka 28c02b400f Add go to "Settings" button to important notice dialog
This CL also
- removes icons on important notice title.
- changes the "Personalized suggestions" summary text.

This change must be checked in together with Id115d89ba9.

Bug: 10587358
Change-Id: I52ff26fa8ae12445e9014ba08253f69e1be609f4
2014-02-17 14:57:04 +09:00
Tadashi G. Takaoka fe39aec08a Use the same label of switch-to-alphabet key on Emoji palette
Bug: 12115967
Change-Id: I61cf80db933aa2ab220ddcaa88a4c9af7beeb35c
2014-02-17 14:54:39 +09:00
Tadashi G. Takaoka a3ce57cca5 am b092aef4: Merge "Remove key show up and dismiss animation"
* commit 'b092aef4a7034f5a4a50f0e50bf3b4ebb4e2a86c':
  Remove key show up and dismiss animation
2014-02-16 19:24:46 -08:00
Tadashi G. Takaoka b092aef4a7 Merge "Remove key show up and dismiss animation" 2014-02-17 03:22:48 +00:00
Tadashi G. Takaoka c9072dc8da Remove key show up and dismiss animation
Bug: 11518021
Change-Id: I4a5eb0732f399612141f7c22d83e2210da612d7e
2014-02-17 12:10:09 +09:00
Tadashi G. Takaoka 613d4766d1 am ffde401b: Fix PC/QWERTY phone layout
* commit 'ffde401b656ba801b4187eeb61e41e0a00884a18':
  Fix PC/QWERTY phone layout
2014-02-16 19:03:10 -08:00
Tadashi G. Takaoka ffde401b65 Fix PC/QWERTY phone layout
Bug: 13025426
Change-Id: I980832ccab7fb7700ca8b01d4f05e920b3f45582
2014-02-17 09:27:47 +09:00
Keisuke Kuroyanagi 37da7b4db8 am 95d16561: Remove unused code.
* commit '95d16561e0e6c38dbd99c893f09c5dbe9d4a465d':
  Remove unused code.
2014-02-15 01:40:02 -08:00
Keisuke Kuroyanagi 610653bb2c am 0fc93fe4: Implement PatriciaTriePolicy::getNextWordAndNextToken().
* commit '0fc93fe4455f24809f6c9baf0d3b936519779cfb':
  Implement PatriciaTriePolicy::getNextWordAndNextToken().
2014-02-15 01:40:00 -08:00
Keisuke Kuroyanagi 95d16561e0 Remove unused code.
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
2014-02-15 17:39:24 +09:00
Keisuke Kuroyanagi 0fc93fe445 Implement PatriciaTriePolicy::getNextWordAndNextToken().
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
2014-02-15 17:39:20 +09:00
Keisuke Kuroyanagi b623c3a89e am 85fe06e7: Merge "Remove unused argument from readDictionaryBinary."
* commit '85fe06e759ab89c629caab5fb73de7ff0441d060':
  Remove unused argument from readDictionaryBinary.
2014-02-14 02:41:13 -08:00
Keisuke Kuroyanagi 85fe06e759 Merge "Remove unused argument from readDictionaryBinary." 2014-02-14 10:37:56 +00:00
Tadashi G. Takaoka 0a7db9e008 am 36d606fc: Use 16sp text to show important notice title
* commit '36d606fcbc666c331ffaba02fe6b55afa4509348':
  Use 16sp text to show important notice title
2014-02-14 02:19:38 -08:00
Tadashi G. Takaoka 36d606fcbc Use 16sp text to show important notice title
Bug: 10587358
Change-Id: Ib840cb71d9e87282ea0d13839dbf2a2da2081d5f
2014-02-14 19:10:47 +09:00
Keisuke Kuroyanagi 8e3a1d0f89 Remove unused argument from readDictionaryBinary.
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
2014-02-14 19:02:15 +09:00
Tadashi G. Takaoka 56120831a6 am b136b7dd: Merge "Add sanity check to KeybaordTextsTable for debugging"
* commit 'b136b7dd6f0757e3988639b0794c04d50b4087da':
  Add sanity check to KeybaordTextsTable for debugging
2014-02-14 01:54:48 -08:00
Tadashi G. Takaoka b136b7dd6f Merge "Add sanity check to KeybaordTextsTable for debugging" 2014-02-14 09:52:36 +00:00
Tadashi G. Takaoka 53a237323a Add sanity check to KeybaordTextsTable for debugging
Bug: 13007104
Change-Id: Id12f75da7a1c6a2a078d41721ee4016794e9dd2a
2014-02-14 18:51:03 +09:00
Jean Chalard 82b92b2147 am fdc41732: Merge "Fix a view-related crash"
* commit 'fdc417321345037fdcf31de95fbaf7cc195856b3':
  Fix a view-related crash
2014-02-14 01:38:52 -08:00
Jean Chalard fdc4173213 Merge "Fix a view-related crash" 2014-02-14 09:19:34 +00:00
Jean Chalard a7e3e74ddd Fix a view-related crash
Bug: 12788164
Change-Id: If0d815518824a8e57b15e80111c5e6e08e93ba7e
2014-02-14 18:03:34 +09:00
Tadashi G. Takaoka 0d25c11b6f am 3c4f05dd: Remove unused label_tab_key
* commit '3c4f05dd66f8211508010e82b414d111037f35dd':
  Remove unused label_tab_key
2014-02-14 00:53:46 -08:00
Tadashi G. Takaoka 3c4f05dd66 Remove unused label_tab_key
Change-Id: Ic10b9678c9b0ebab977589aa0093740b9c9f2d90
2014-02-14 17:40:53 +09:00
Tadashi G. Takaoka 9286ff7f2b am e422c946: Fix test resource declarations and parsing a bit
* commit 'e422c94634da4d0e61a9106addebf06cbcf70c2e':
  Fix test resource declarations and parsing a bit
2014-02-13 23:38:49 -08:00
Tadashi G. Takaoka e422c94634 Fix test resource declarations and parsing a bit
Change-Id: I882a41b2934c48f4405f1ea5bf4d6ad41e87322c
2014-02-14 16:27:26 +09:00
Tadashi G. Takaoka 240cc54a0a am d4469756: Merge "Special punctuations for Arabic and Persian"
* commit 'd4469756beca3b890fa52ff21aefa0559b0c38ac':
  Special punctuations for Arabic and Persian
2014-02-13 23:22:56 -08:00
Tadashi G. Takaoka d4469756be Merge "Special punctuations for Arabic and Persian" 2014-02-14 07:20:25 +00:00
Tadashi G. Takaoka 96e16d6f18 am 17993ed4: Merge "Fix null KeyDetector reference"
* commit '17993ed4ef235a730f609f6bd38c914ff0f5b4a6':
  Fix null KeyDetector reference
2014-02-13 23:19:37 -08:00
Tadashi G. Takaoka 17993ed4ef Merge "Fix null KeyDetector reference" 2014-02-14 07:17:33 +00:00
Tadashi G. Takaoka d508b676cf Special punctuations for Arabic and Persian
This change also removes duplications from tablet punctuation suggestions

Bug: 12640318
Change-Id: I221922484027d6b91e2f23a6bf60a18766f3a13c
2014-02-14 16:11:50 +09:00
Tadashi G. Takaoka 65507d5fb1 am 32a7e079: Merge "Add PunctuationSuggestions class"
* commit '32a7e079e0f66c23405880bc228edcbaa42bd945':
  Add PunctuationSuggestions class
2014-02-13 22:21:01 -08:00
Tadashi G. Takaoka 8cdd284d59 am 42e4ea7d: Add Kazakh (kk) subtype
* commit '42e4ea7d6cdaddcd2b055d3d8ddf04c86dba2575':
  Add Kazakh (kk) subtype
2014-02-13 22:20:58 -08:00
Tadashi G. Takaoka 32a7e079e0 Merge "Add PunctuationSuggestions class" 2014-02-14 06:19:52 +00:00
Tadashi G. Takaoka 42e4ea7d6c Add Kazakh (kk) subtype
The Kazakh (kk) subtype has been temporarily disabled by Ic44ef378a9.

Bug: 9698902
Change-Id: Ib2096cdf79fd45d36f5504be55f76416ba11445d
2014-02-14 15:16:16 +09:00
Tadashi G. Takaoka a273319c59 Add PunctuationSuggestions class
This change must be checked in together with I366c477516.

Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
2014-02-14 14:13:39 +09:00
Jean Chalard 19d5d141a5 am 4197c6f3: Merge "Show the suggestion strip for the important notice"
* commit '4197c6f3ab1db7d37bfb5fca05bd7169504f451e':
  Show the suggestion strip for the important notice
2014-02-13 20:10:09 -08:00
Jean Chalard 4197c6f3ab Merge "Show the suggestion strip for the important notice" 2014-02-14 04:07:46 +00:00
Tadashi G. Takaoka ef8a03685f Fix null KeyDetector reference
This change must be checked in together with I737c266c45.

Bug: 13011041
Change-Id: Ia3d25be6de47fa16ab7156a25641e53a23948ff4
2014-02-14 11:42:09 +09:00
Yohei Yukawa f45b3b98cf am 362ab36c: Fix a null object reference crash on Emoji Palette
* commit '362ab36cf009d724768e742c3b2e264387efc521':
  Fix a null object reference crash on Emoji Palette
2014-02-13 17:56:36 -08:00
Yohei Yukawa 362ab36cf0 Fix a null object reference crash on Emoji Palette
Do nothing if the current EmojiPageKeyboardView is null.

BUG: 13006906
Change-Id: I169b70122ec939075b5be033953b48762fd528fc
2014-02-14 10:36:31 +09:00
Yohei Yukawa a1e6d5cb5f am 5f9f4b92: Merge "Fix indent."
* commit '5f9f4b929b246491865553758fe55d58e720ca44':
  Fix indent.
2014-02-13 17:28:34 -08:00