Commit Graph

8273 Commits (06a6bf5ecca650965cd0643de973e295b59539c1)

Author SHA1 Message Date
Dan Zivkovic 755b3d882f Notify the facilitator on IME start/finish.
Allows the facilitator to flush language models without a recurring task.

Bug 19773937.

Change-Id: I01a3c10da26f9df38fee05df33387eb082e2ff33
2015-03-20 09:03:48 -07:00
David Faden 6e86632311 Pass DictionaryFacilitator to GestureConsumer#onImeSuggestionsProcessed.
Bug: 19712589
Change-Id: I81f9bf09b37487450780d85a1e4f752a9ba49370
2015-03-19 18:23:35 -07:00
Mohammadinamul Sheik 7df95c54fa Merge "Add prev words context to the SuggestedWordInfo." 2015-03-20 00:41:27 +00:00
Mohammadinamul Sheik ab59129594 Add prev words context to the SuggestedWordInfo.
Bug: 19712589
Bug: 19715579
Change-Id: Ie06665cab8405455c1b0a2ff034e0bb0731c9156
2015-03-19 16:07:04 -07:00
Dan Zivkovic dbf117b661 Log accepted punctuation suggestions.
Bug 19825927.

Change-Id: If65b56aa5c269e47bcc609bdc673ba18c450ee66
2015-03-19 15:40:40 -07:00
Chieu Nguyen 60835872a1 Set background color for emoji category tabs.
Bug: 19686516.
Change-Id: I519d09491ded4f5d85a5951afb48a9638b5fe652
2015-03-18 18:48:30 -07:00
Chieu Nguyen 8ec36026c9 Disable message if personalization is disabled.
Bug: 19087415.
Change-Id: I3974f1b676aa4a9bb04ab7f609b6daf1860c64f1
2015-03-18 15:30:22 -07:00
Mohammadinamul Sheik 0bbbbdf1c4 Merge "Pass DictionaryFacilitator for autocorrection and suggestion stats" 2015-03-17 22:39:17 +00:00
Tom Ouyang edcf5853d1 Merge "Start-of-sentence should include newlines and non-period terminators." 2015-03-17 22:25:00 +00:00
Tom Ouyang 5aeb092130 Start-of-sentence should include newlines and non-period terminators.
Bug: 19795382
Change-Id: Id6cc4a494a06de03d351aa6257632bd3b82e2ec4
2015-03-17 15:18:42 -07:00
Mohammadinamul Sheik 4024984c1e Pass DictionaryFacilitator for autocorrection and suggestion stats
Bug: 19715579
Change-Id: Ic48de74bde0f9f5d5e68e8289948cc5e92cbfa1e
2015-03-17 15:18:21 -07:00
Mohammadinamul Sheik ea727b6b71 Carry over the mMaxPreWordCount when creating the new NgramContext
Change-Id: Iaba2e4b356486b60d550f10121695ef46e5e75da
2015-03-17 12:31:18 -07:00
Mohammadinamul Sheik f468609223 Use BinaryDicitonary.MAX_PREV_WORD_COUNT_FOR_NGRAM for D2 dictioanries.
Fixes the UserHistoryDictionaryTests

Change-Id: I49776f53298ced3cd7e771cfe77a940b80b01f20
2015-03-17 11:43:16 -07:00
Dan Zivkovic a10808d7d6 Merge "Remove rejected suggestion in LatinIME." 2015-03-17 18:14:36 +00:00
Mario Tanev 320cef5fe7 Merge "Bump up the current metadata database version to 14." 2015-03-17 01:45:14 +00:00
Dan Zivkovic 8844c35e7e Remove rejected suggestion in LatinIME.
Bug 19744396.

Change-Id: I64e59b3fb1ab627c70bf27a12a78d8d927da7e97
2015-03-16 18:26:37 -07:00
Tom Ouyang 263dd9fe03 Merge "Deprecate SuggestedWords.mSourceDict" 2015-03-17 01:25:21 +00:00
Mario Tanev 323d48d748 Bump up the current metadata database version to 14.
Change-Id: I49057f117666291c2e9e7ba3c3627f75ffc3cca5
2015-03-16 18:01:23 -07:00
Chieu Nguyen 56e7673917 Merge "Add cloud sync setting to SettingsValues." 2015-03-17 00:22:14 +00:00
Chieu Nguyen 93205b17ff Add cloud sync setting to SettingsValues.
Bug: 19573092
Change-Id: I41174188743c8a78facebff547e378a2b467a8c7
2015-03-16 17:11:52 -07:00
Dan Zivkovic bff393ce13 Fix NPE in AccountSettingsFragment.
Bug 19773815.

Change-Id: Ib5eb27cdf385c81d1a3822836f424fa29c0bbaa8
2015-03-16 17:08:35 -07:00
Dan Zivkovic 52dafe8c32 Don't test format version 403 twice.
BinaryDictionaryTests runs all tests 3 times for 3 format verisons.
Cut that number down by 33% to speed things up.

Change-Id: I8a2f78017fa30f46b5873dcf6a5f478f57af2ebd
2015-03-16 14:38:44 -07:00
Dan Zivkovic f508209f6a Remove unused imports.
Change-Id: Ic537cc7080a0ca98fc855a6f24a415d63f747891
2015-03-16 14:17:51 -07:00
Dan Zivkovic 4e1f0f1bb0 Redundant code matches multiple languages.
InputLogic should not have code that tweaks suggestion ranking based on the
language of the source dictionary.

Bug 19744396.

Change-Id: I8c0849555e74cec1302e78da04148dedd1cddabe
2015-03-16 14:11:59 -07:00
Dan Zivkovic 2321c41b5b Check boxes are replaced by switches in KitKat.
Make the code work for both widgets by using the TwoStatePreference interface.

Bug 19596067.

Change-Id: I8352361dcf74b54136b6177de9aac3eb2942a4c0
2015-03-16 12:03:04 -07:00
Dan Zivkovic 5455179b54 Revert "Next-word suggestion bit in keyboard settings."
This reverts commit 1ae16dc3db.

Bug 19596067.

Change-Id: Ie7286acbb70b215d7bd08e271bcf14526b68576f
2015-03-16 11:23:22 -07:00
Mohammadinamul Sheik 900502f1ec Merge "Make RichInputMethodSubtype non-final for easy mocking" 2015-03-14 03:04:02 +00:00
Mohammadinamul Sheik 29500ef4ba Fix the BinaryDictionaryTests
Change-Id: I09378d74705e6943946ea4f76b15664086a387ed
2015-03-13 18:21:22 -07:00
Mohammadinamul Sheik f04e2ed83a Make RichInputMethodSubtype non-final for easy mocking
Change-Id: I167bc56b5224eb389ec853aeb539d7fcf79b81e1
2015-03-13 17:05:11 -07:00
Mohammadinamul Sheik 93d2ab3857 Add StatsUtils.onSettingsActivity to collect the settings page stats.
Bug:19214944
Change-Id: I113f47c49d638790d770fe2781afe7cd1565619d
2015-03-13 16:12:14 -07:00
Tom Ouyang 89e2d93634 Deprecate SuggestedWords.mSourceDict
Change-Id: I29d9bec427660a7a501054fe9b1ea71be2d5ee3f
2015-03-13 14:30:18 -07:00
Chieu Nguyen 116e58c437 Remove autocorrection aggressiveness settings.
Replace multiple settings with binary switch for autocorrection.

Bug: 19589766
Change-Id: Ic8a0362dd36d18930493a55699851161e9cb23e8
2015-03-13 12:21:26 -07:00
Mohammadinamul Sheik 80f9034955 Log.i on dictionary download start
Change-Id: I8b501fb5512d4d3bbca75e4c4be7c7eb95f32020
2015-03-13 11:53:33 -07:00
Mario Tanev b9a16b88bf Bump up the current metadata database version.
Change-Id: Id2814a2224b90ba124f1c9801760a2c86f2dc2e2
2015-03-13 10:39:05 -07:00
Dan Zivkovic eaa710d4aa Separate executor for the Spelling decoder.
Bug 19710676.

Change-Id: I6e66eddd507c11e424105869833fe6841b90275d
2015-03-12 17:10:38 -07:00
Dan Zivkovic 26fb83c481 Avoid creating empty String[].
Minor cleanup on the way to fixing spelling for downloaded language.

Bug 19710676.

Change-Id: I7be25fa82248f0317d894d44802bede9dbc4fe2a
2015-03-12 10:49:29 -07:00
Dan Zivkovic 7e1dfaae3d Merge "Remove ALS from LatinIME." 2015-03-12 17:17:59 +00:00
Dan Zivkovic 107fb4c476 Remove ALS from LatinIME.
This fixes unit tests and brings us closer to a green build.

Change-Id: Iffcc392eda4a7671a238b79cc7367320ca648725
2015-03-11 17:29:12 -07:00
Chieu Nguyen 4e0af43673 Remove unused phrase gesture code.
Bug: 19687841
Change-Id: I0862aa3127bf7f1564a4845efdf99ebf5ae4d5ac
2015-03-11 17:09:44 -07:00
Dan Zivkovic 9a289da4e6 Remove deprecated distractor filtering methods.
Change-Id: I10ccf75d9c00d66b4e85de6c3c019242f2e90b0e
2015-03-11 14:39:48 -07:00
Dan Zivkovic 7472cc8245 Mark method @UsedForTesting
This prevents it from being optimized away.

Change-Id: Iecd317568e23e86e4c0ece8134a4926a7a56d65b
2015-03-11 14:00:30 -07:00
Dan Zivkovic 820317f7aa Make inner classes visible for testing.
We need this to assert the correct behavior in the facilitator.

Bug 19695605.

Change-Id: I3923d00791c99208bc72f7c4210ae1ea0a34bd0e
2015-03-11 13:40:20 -07:00
Dan Zivkovic bdd6c995ce Delete user history files.
Bug 19669016.

Change-Id: I8069fe561347851bf3c27423dbd8ba99d38c049e
2015-03-11 11:46:15 -07:00
Dan Zivkovic 77fd5dbf3e Remove dead code, including tests.
Change-Id: Id88b02b74bdfe4ca05b08181ceb6b34d5652fc0c
2015-03-10 17:22:41 -07:00
Dan Zivkovic 70c096d9a1 Restart background executor.
Bug 19671650.

Change-Id: I1a28a53e94bdb79aeb173f6905c1035022495acc
2015-03-10 10:03:17 -07:00
Chieu Nguyen 21a28abc6a Handle empty previous ngram context correctly.
Fixes bug where empty previous ngram context not at the
beginning of a sentence incorrectly returned the
beginning-of-sentence marker.

Bug: 19612336
Change-Id: I5ddf3408e20dcedf70487b85c983cd3fc12550e7
2015-03-09 19:02:43 -07:00
Dan Zivkovic 375035905d Kill+restart tasks before/after decoder init.
Bug 19625976.

Change-Id: I6d8b0d2b0a77ccda1bfc914501cf568b92862980
2015-03-09 18:54:48 -07:00
Dan Zivkovic bd1bc4067f ExecutorUtils lets use schedule a runnable chain.
Bug 19625976.

Change-Id: Iebbef7fed57a381498301dcf26fefa27d06802f7
2015-03-09 14:58:16 -07:00
Dan Zivkovic f9e2d271ca Use a single background executor.
Bug 19625976.

Change-Id: Ia03f440a31b059b5af42d162e1145330bf7b5ddf
2015-03-09 13:22:56 -07:00
Dan Zivkovic 491ca900a7 Merge "Handle null InputMethodSubtype." 2015-03-06 22:51:35 +00:00
Dan Zivkovic 2fcb7c5de5 Merge "Log from LatinIME." 2015-03-06 22:45:17 +00:00
Dan Zivkovic edaa83bb32 Log from LatinIME.
When the DEBUG setting is on, log from this critical class.
This will make it easier to diagnose issues.

Bug 19632709.

Change-Id: I5e14b3705f50cd021ad3d64af106ad28dc8b9321
2015-03-06 14:42:57 -08:00
Dan Zivkovic b86ca76cea Handle null InputMethodSubtype.
Bug 19627494.

Change-Id: I50dc77c59ced0f2e7c07a49ae0cb040197c2ab35
2015-03-06 14:34:57 -08:00
Chieu Nguyen e3ac02e796 Merge "Sync setting disabled if no account." 2015-03-06 17:40:47 +00:00
Tom Ouyang 8eb2fad570 Merge "Restart suggestions when backspacing into a reverted word." 2015-03-06 02:29:35 +00:00
Chieu Nguyen b717f91ffa Sync setting disabled if no account.
Bug: 19361223

Change-Id: Id5e8d34920f5bf3bffb6d6d287557e85d7b72c79
2015-03-05 18:25:56 -08:00
Chieu Nguyen c4f6a8dcd4 Make privacy policy link clickable in sync settings.
Bug: 19361223
Change-Id: I83128d771bf5214a446afd6a3d5244a184d0a4a8
2015-03-05 17:48:02 -08:00
Tom Ouyang 222f647137 Restart suggestions when backspacing into a reverted word.
This is required for the final corrected word to be learned,
as learning only occurs when suggestions are active.

Note: This is already happening when backspacing into a non-reverted
word

Bug: 19619907
Bug: 18465402
Change-Id: I99a1d4f0ca0d62a2cdfa24cc0833ce89391715d9
2015-03-05 17:42:35 -08:00
Dan Zivkovic 38b9bffa3f Handle words longer tha 256 characters.
Bug 19612315.

Change-Id: I75e84df88b4da5cfc6a39b956613972841342c4b
2015-03-05 10:56:14 -08:00
Dan Zivkovic 1ae16dc3db Next-word suggestion bit in keyboard settings.
This feature works in supported languages.
We don't need a user setting.

Bug 19596067.

Change-Id: Icdded772745f9816da47f8a5e3b87b733083b121
2015-03-04 15:02:53 -08:00
Dan Zivkovic 83e95e6018 Remove SHORTCUT column in FROM clause.
The column is no longer used, and is not available on pre-Jellybean devices.

Bug 19595958.

Change-Id: Ief54c7210698d6668b1b7815900a394cc7f27299
2015-03-04 10:16:28 -08:00
Mohammadinamul Sheik 6e29d261cb Introduce DictionaryHeaderUtils to get dictionary header values
Change-Id: I86cef6c7f2f68a75428bb2b9c4d5a1dc1876b541
2015-03-03 16:17:27 -08:00
Chieu Nguyen 2281ba7666 Merge "Add DictionaryFacilitator dump()." 2015-03-03 23:16:49 +00:00
Chieu Nguyen c809dc26a1 Add DictionaryFacilitator dump().
Change-Id: I8b75aded3fc2b9b33128b6ba5a3e8d943dfca352
2015-03-03 14:36:47 -08:00
Jatin Matani 148aab1228 Merge "Add util method in ngramcontext for context array" 2015-03-03 21:59:52 +00:00
Jatin Matani a568e0acb4 Add util method in ngramcontext for context array
Change-Id: I2e3e2ac7706be50ed2055b0c69b30e25a516a879
2015-03-03 13:20:53 -08:00
Dan Zivkovic 63a0bdb41b Forgot to remove reference to deleted class.
Change-Id: Ic662a536e468390a3f7266daf9c56e4fc5a70ac6
2015-03-03 12:11:00 -08:00
Dan Zivkovic fbfc62209a Remove no-op broadcast receiver from LatinIME.
Bug 19583388.

Change-Id: Ia1ca481e2eae0c9791932f7f28a9072cc3dbbe7c
2015-03-03 11:03:11 -08:00
Chieu Nguyen ddee491450 Merge "Move dictionary facilitator handling." 2015-03-02 23:30:42 +00:00
Chieu Nguyen 0103d75aaf Move dictionary facilitator handling.
Change-Id: Ibd42982996a36ac52b4c916035491b835f8d14f9
2015-03-02 15:24:51 -08:00
Jatin Matani 55d9651929 Merge "Turn off cloud sync if we have managed profiles" 2015-03-02 20:21:29 +00:00
Jatin Matani 854edce6dd Turn off cloud sync if we have managed profiles
UserManager#getUserProfiles > 1 implies managed
profile.

Workflow:
- Disable sync prefs
- Execute an async task to check for managed profile; if
  managed profile is found, remove the sync prefs. If not, enable
  the preference;
- Move the logging pref from Advanced to Account & Privacy.

Bug:19230544
Change-Id: I4dbd1fe8433b3263ccc74c35dc0ee0bb371122b3
2015-03-02 12:03:57 -08:00
Jatin Matani 8b2908066d Fix build breakage due to changed resource Id
Change-Id: I09ba038930416d1261ef095ec503f1ac68cd92ea
2015-03-02 09:44:19 -08:00
Dan Zivkovic 9770336a9b Merge "Label empty suggestions." 2015-02-27 21:33:02 +00:00
Chieu Nguyen 98886775cf Merge "Handle double space inserting a period." 2015-02-27 21:24:36 +00:00
Chieu Nguyen fdf3cc41ee Handle double space inserting a period.
Change-Id: I109f0e9cf3e972bf60aa3fbbe817337aef70ea3c
2015-02-27 13:19:21 -08:00
Mohammadinamul Sheik 62cbaba715 Merge "Update the MAX supported file version for downloaded static Dictionaries." 2015-02-27 21:09:04 +00:00
Dan Zivkovic 24c275ccb9 Label empty suggestions.
When talkback is enabled, empty strings will have a content description.

Bug 19479836.

Change-Id: I25679a2bdeff238a5330ba406d5bc7e6e2868ba1
2015-02-27 12:44:28 -08:00
Mohammadinamul Sheik 377ba98b75 Update the MAX supported file version for downloaded static Dictionaries.
Change-Id: I72d37cc21585b18f4a41ff32627024502f10e993
2015-02-27 10:30:23 -08:00
Dan Zivkovic 69c04cadc7 Race condition in cursor move.
The method WordComposer.moveCursorByAndReturnIfInsideComposingWord() iterates
through all the code points in the word that's currently being composed, and
it tries to adjust the cursor position by a given amount (left or right).
It copies the code points to a new array while processing. But the code point
count comes from a member variable. If the member variable changes while the
method is processing the copy of the code points, it can run over the length
of the code point array.

Bug 18876474.

Change-Id: Ib3a2d90a4e82b76d381efa774e6b3d6bca99c869
2015-02-27 10:29:47 -08:00
Jatin Matani c83352d527 Merge "Refresh pref settings for cloud sync" 2015-02-26 22:10:02 +00:00
Jatin Matani 8ec328fb2e Refresh pref settings for cloud sync
- Show the opt-in text
- Show the account picker if user presses 'enable sync'. Previously
  we disabled the sync pref which was confusing.
- Remove the debug tags from some prefs; and improve messaging overall

General rules;
- sync is turned ON : user checks 'enable sync' pref AND
  accepts the opt-in AND chooses an account
- sync is turned OFF: when user signs out

Demo link
https://drive.google.com/a/google.com/file/d/0B9tNQOWdRuiWSUdVVE5rVDJudlk/view?usp=sharing

Change-Id: I2e7933796b15e47005ba9970a8c1294416ef31a0
2015-02-26 11:43:42 -08:00
Dan Zivkovic edd94a449e Ignore the Emoji key when not connected.
When the LatinIME does not have an active InputConnection, it will not try
to toggle the Emoji keyboard.

Bug 19513415.

Change-Id: I31f928cd7db1cddd771c548cd3dc42f8af64d0e2
2015-02-26 11:10:37 -08:00
Jatin Matani 48b071249c Merge "Share decoders among latinime components." 2015-02-26 17:54:26 +00:00
Dan Zivkovic 7d7f082075 Stop waking up to decay dynamic dictionaries.
Bug 19516048.

Change-Id: Ibc27a792b4fa80fa8c6af4721c47a617526e9584
2015-02-25 20:13:59 -08:00
Dan Zivkovic e4619f029e Merge "Don't assume that correctable words are invalid" 2015-02-26 03:44:20 +00:00
Mohammadinamul Sheik 48ba1ea19f Merge "Make DictionaryFactory.killDictionary public" 2015-02-26 03:33:08 +00:00
Dan Zivkovic 5551302d27 Don't assume that correctable words are invalid
Currently, the Delight3DictionaryFacilitator sets a boolean flag when the top
suggestion score exceeds the auto-correction threshold. This flag is used to
trigger auto-correction of the typed word. Also, the existing logic assumes
that if allowsToBeAutoCorrected then the word is invalid, which is no longer
true after we stopped using whitelists.

Bug 19518376.

Change-Id: Ifa7f6a09c07d25ac68c6cf3aec91f358bd88689f
2015-02-25 17:59:58 -08:00
Mohammadinamul Sheik 20fb37afee Make DictionaryFactory.killDictionary public
Change-Id: I9a0733392651714b3ba232cdb805565a5238eb93
2015-02-25 17:53:35 -08:00
Jatin Matani b684d2d2e4 Share decoders among latinime components.
Change-Id: I6c8d3cf10e05e606308cea42d1e935a415ada9f8
2015-02-25 17:48:30 -08:00
Mario Tanev 487e038ff3 Use Keyboard in several interfaces.
Simplify interfaces by passing Keyboard instead of
KeyboardLayout and ProximityInfo directly.  Also require
the Keyboard passed be non-null and change the SpellChecker
to bail out if there is no keyboard for the locale.

Change-Id: I960f15ff60171f55d3e0a96fd6469b7dc3a045e2
2015-02-25 17:20:00 -08:00
Dan Zivkovic ed378c78a1 Auto-correct without whitelist in Delight3.
Bug 19390471.

Change-Id: Ie09b916ca80591c98f48ae1d74d4fd5b0c5d6b33
2015-02-25 11:47:43 -08:00
Martin Paraskevov 2b8d763c65 Pass ComposedData to the decoder instead of WordComposer.
Change-Id: I8bd544d03d9087a02294b08a9986cad229dae795
2015-02-24 17:59:47 -08:00
Mario Tanev a3ac6f24cc Merge "Don't call resetDictionaries if DictionaryFacilitatorLruCache.get() hasn't been called yet. This breaks the AOSP SpellChecker. This seems to be a bug introduced recently, when the DictionaryFacilitatorLruCache was turned into a "cache" of 1 element." 2015-02-25 00:20:32 +00:00
Mario Tanev 1a6d01b61e Don't call resetDictionaries if DictionaryFacilitatorLruCache.get()
hasn't been called yet. This breaks the AOSP SpellChecker.  This seems
to be a bug introduced recently, when the
DictionaryFacilitatorLruCache was turned into a "cache" of 1 element.

Change-Id: I55f6c18b274c9a33fd62cb25bcd02f64788d5ff0
2015-02-24 15:56:43 -08:00
Mohammadinamul Sheik 24c282437d Do not crash when dictioanryInfo is NULL
Bug: 19417599
Change-Id: I82174401c595b57b42fc74bc478b551869729ba6
2015-02-24 15:45:10 -08:00
Jatin Matani f7058c2a89 Merge "Pass long timestamps to DictionaryFacilitator" 2015-02-24 20:57:34 +00:00
Tom Ouyang edb2d23802 Check for null TextRange in InputLogic.unlearnWordBeingDeleted
Change-Id: Ia0df0ab740c76185f94966f59a74a6ebdd1cffe8
2015-02-24 11:30:42 -08:00
Mohammadinamul Sheik 1d5ec6136c Use DECODER_DICT_SUFFIX on fallback to the default main dict resource.
Change-Id: Icec45c364732c0aa9ac713846cad23439b9e42b5
2015-02-23 17:25:08 -08:00
Jatin Matani 94b8523566 Pass long timestamps to DictionaryFacilitator
Change-Id: I95500f210ed409c0ff254b08b68fe3b5b59ba4f4
2015-02-23 16:50:02 -08:00
Mohammadinamul Sheik bae3c4bac5 Merge "Make checksum and header checks decoder dependent." 2015-02-23 21:47:28 +00:00
Chieu Nguyen 53b4bfdba0 Merge "Add StatsUtils method for handling subtype change." 2015-02-23 19:11:15 +00:00
Dan Zivkovic 08f3cdb3c8 Hide app icon when keyboard is a system app.
The objective is to show an app icon when the user installs the keyboard from
the Play Store, but not show the icon when it comes from the system image.
The latter rule applies to AOSP keyboards and to the Google Keyboard on a
Nexus device.

This change partially reverts ag/613096.

Bug 19001197.

Change-Id: Icb202deffe9f1ab2bde9b3c9d221347da6793a19
2015-02-23 10:21:20 -08:00
Mohammadinamul Sheik eeeec21bac Make checksum and header checks decoder dependent.
Change-Id: I0ec4aa69d9b5f013ae926cc368e25225d9d3073b
2015-02-20 18:30:23 -08:00
Jatin Matani 1c11f3fe0e Merge "Remove unused APIs in DIctionaryFacilitator" 2015-02-21 01:17:25 +00:00
Jatin Matani 83e9a29c33 Remove unused APIs in DIctionaryFacilitator
Change-Id: Iae20a0a3b7c1aa0c2f6d29cef780fb50dc9010cb
2015-02-20 11:19:27 -08:00
Dan Zivkovic fe3c4ef940 Merge "Spell checker uses cache of size 1." 2015-02-20 19:06:48 +00:00
Dan Zivkovic 29aa3df3da Spell checker uses cache of size 1.
This is a step in the direction of removing the LRU cache completely.

Change-Id: I8886f7ef74e6b1b35135e68f169cb461682964e9
2015-02-20 11:05:44 -08:00
Jatin Matani 01b023730e Add tests for Contact* classes
Also add empty implementation for dictionary
facilitator iteration APIs
Change-Id: Ia847e3faa75075c819fcfda89193d1024d2d5aca
2015-02-20 09:14:27 -08:00
Dan Zivkovic 40b754565c Rename in preparation of caching an instance.
Change-Id: I112c957e20d4573daaa71aa218b575037585385c
2015-02-19 15:41:58 -08:00
Dan Zivkovic 3bfc9d4692 Merge "Schedule with 0 delay is the same as execute." 2015-02-19 22:42:55 +00:00
Dan Zivkovic 6a000183c5 Schedule with 0 delay is the same as execute.
Change-Id: Ifadae8aee668edbe2b507735d3ed6e68d52ef329
2015-02-19 14:19:23 -08:00
Dan Zivkovic 7041313f71 Merge "If contacts observer is running, return early." 2015-02-19 22:16:33 +00:00
Tom Ouyang 076f76cc12 Merge "Add more options for calling removeWordFromPersonalizedDicts." 2015-02-19 21:31:38 +00:00
Tom Ouyang edea47ff2e Add more options for calling removeWordFromPersonalizedDicts.
Bug: 19441205

Change-Id: I41aff536a64271d2dc9489a20df33d64170756cc
2015-02-19 12:03:42 -08:00
Dan Zivkovic 705b118672 If contacts observer is running, return early.
Change-Id: I084a251b0f72288243c73b6166d992b427449635
2015-02-19 11:54:18 -08:00
Dan Zivkovic 0b03f13cab Sanitize the usage of executors.
There should be 1 executor each for static and dynamic language models.
This prevents too many dynamic LM updates from running in parallel,
competing for resources.

Change-Id: I8ec439e0ea2d92fba275bc20a0b8c9193346a0c1
2015-02-19 11:40:57 -08:00
Chieu Nguyen 40833d2dd7 Add StatsUtils method for handling subtype change.
Change-Id: I0f334ab5e6f5aa41ad780641276dc3d2aa232f48
2015-02-18 16:00:59 -08:00
Mohammadinamul Sheik 95711bfcee Add Decoder specific dictionary suffix to resource lookup
Change-Id: Ia2c74acdc8ac6f7b605bb06a1078d23b32f388a1
2015-02-12 19:56:46 -08:00
Dan Zivkovic cf84f8ce0c Switch from script to language codes.
Unfortunately, our Locale objects don't always have a script code.
But we can get almost the same functionality by specifying script
codes for some languages, and defaulting the rest to Latin.

Change-Id: Id81ff67bf44c84f44707a2e167c2787c60c6ecee
2015-02-12 15:42:25 -08:00
Dan Zivkovic 98596e51a1 Map ISO 15924 codes to internal IME script codes.
This way we can support all the languages for which we define a script code.

Bug 19340741.

Change-Id: Ia80eca4cc2511b70f11058f73bd31746948ded19
2015-02-12 11:00:06 -08:00
Jatin Matani 4084fa5cae Refactor content provider code from ContactsDict
Break contacts binary dictionary into two parts
- one that talks to contacts content provider and maintains
  local state. Includes a manager class and a content observer
- other one that just manages the dict code.

Change-Id: Ie8f89ac9ce174c803ff3168ee0bee5cbe7721d5b
2015-02-11 16:29:14 -08:00
Dan Zivkovic 5254c01d4c Fix master build.
For some reason, we can't import android.os package in our Constants.

Change-Id: I357ed72d13c5039a83c6e2489cdf5ef74d0ffea8
2015-02-11 13:32:13 -08:00
Dan Zivkovic 12d80ebead Remove shortcut support from LatinIME.
Note this change does not affect the native decoder interface.

Change-Id: I73b7dc008a5acaf75a31a36a2d332b5afabd82d0
2015-02-11 13:02:41 -08:00
Mario Tanev 2979fad213 Merge "Add new class spellcheck.UserDictionaryLookup that can look up the system "Personal dictionary" in the event that the DictionaryFacilitator doesn't." 2015-02-10 23:25:50 +00:00
Jatin Matani a7805e9870 Add a addOrIncrement term api to DicFacilitator
The API is used by the decoder to add term to the
dictionary.

Change-Id: I607c8c676b7650f3052b2d3ed3f7f656573fca45
2015-02-10 11:45:54 -08:00
Mario Tanev 8aa310aa5a Add new class spellcheck.UserDictionaryLookup that can look up the
system "Personal dictionary" in the event that the DictionaryFacilitator
doesn't.

Change-Id: Ib4f15ec4d8f06ea43c2e063f5a13a2f699afbb8a
2015-02-10 10:56:35 -08:00
Dan Zivkovic 644a709a5f Remove distracter filter from client.
Bug 19296201.

Change-Id: Ic834e5956347cd86a96bd14024c42ad8ee258659
2015-02-09 11:52:12 -08:00
Mohammadinamul Sheik aadfef6ffa Merge "Move decoder specific constants to DecoderSpecificConstants.java" 2015-02-06 22:46:08 +00:00
Dan Zivkovic d6a8adcb04 Cleanup in preparation of distracter change.
Bug 19296201.

Change-Id: If016da2b7f4b3ecb9afd6d7aed9d19fbd4938758
2015-02-06 14:25:37 -08:00
Mohammadinamul Sheik 0f7d881dc7 Move decoder specific constants to DecoderSpecificConstants.java
Change-Id: Ie4d325b3152e1e7e424b8b436e222e194e4d9da0
2015-02-05 13:27:36 -08:00
Chieu Nguyen 608ef4729c Merge "Add accessor methods for typed word info to SuggestedWords and for word and source dictionary to SuggestedWordInfo." 2015-02-05 03:16:45 +00:00
Dan Zivkovic 23d19626f3 Use shared constants in old+new facilitators.
Change-Id: I18b701df6ecbcc20ff0c664c218289179c4b2b2d
2015-02-04 18:55:39 -08:00
Chieu Nguyen 4e94109031 Add accessor methods for typed word info to SuggestedWords and for word
and source dictionary to SuggestedWordInfo.

Change-Id: Ic3bdf67a9edd5352f3b911f5cb72a25986e31e2c
2015-02-04 18:35:20 -08:00
Dan Zivkovic 6e0467c20e Fix accidentally inverted if check.
Change-Id: I9c28f4154f69c63564a2bda357c16cef4e68dc0d
2015-02-04 18:23:38 -08:00
Dan Zivkovic c0eb57124f Don't check user dictionary, except for spelling.
We check different lists of dictionaries based on the use case.

Bug 19270992.

Change-Id: Ide69f2855978ebad32a58e9689b3a8d47e095994
2015-02-04 18:23:38 -08:00
Dan Zivkovic c4977b5f89 Merge "Removing code from RichInputConnection." 2015-02-05 01:14:46 +00:00
Dan Zivkovic a6d2cf5ec7 Removing code from RichInputConnection.
Followup CL that removes some more unused methods and variables.

Change-Id: I4163c7cd017f59d1fd445adb6294fc89dcaafe6e
2015-02-04 16:47:56 -08:00
Dan Zivkovic 7b2646dd58 Merge "Selections spans should not split surrogate pair." 2015-02-05 00:47:29 +00:00
Mohammadinamul Sheik bae6848434 Merge "AOSP changes to use KeyboardLayout to support the new DictionaryFacilitator" 2015-02-05 00:44:10 +00:00
Dan Zivkovic f3c319fb8a Selections spans should not split surrogate pair.
When committing a span after a revert, the offset logic was such that it
split a surrogate unicode pair used to express an emoji.
Checking the last character of the span lets us avoid this problem.

Fix for bug 19255233.

Change-Id: I07d18d9002b5075f7925319dd05962011656c311
2015-02-04 16:35:18 -08:00
Mohammadinamul Sheik b00c054125 AOSP changes to use KeyboardLayout to support the new DictionaryFacilitator
Change-Id: Ie0c9ce805d9ad009fc9bbaac37b715aff90cd844
2015-02-04 12:50:31 -08:00
Dan Zivkovic c71e4d6534 Remnant of green [+] feature.
Change-Id: I059b1062e1d73b2fa439d9d4ee04ff0182795335
2015-02-04 11:57:16 -08:00
Dan Zivkovic 0d3f01f301 Remove last vestiges of contextual+personal dictionary.
Change-Id: I20746381583ee8a4d7d42b1243f5c7ba45529e5e
2015-02-04 11:38:19 -08:00
Dan Zivkovic 00ae43316e Fix delete handling in Emoji keyboard.
Bug 19113652.

Change-Id: I4255c248a25bb92f5c12da6a185d17cc13a9a69d
2015-02-03 18:27:17 -08:00
Dan Zivkovic 23574d1231 LatinIME portion of "green plus" feature.
Removes the feature that adds strings to the user dictionary,
aka the "green highlight with a plus sign".

Bug 19237189.

Change-Id: I2387129a3add2d69d625f2ff16ed8cab3f10a735
2015-02-03 15:12:01 -08:00
Jatin Matani 48cc0d6420 Merge "Nuke Amanatto" 2015-02-03 19:20:40 +00:00
Jatin Matani 15acbdc905 Nuke Amanatto
Change-Id: Ieff2cd37f869dca69abf53ac32a576c2e45cc1e3
2015-02-02 17:10:38 -08:00
Dan Zivkovic 53e81fdc55 Remove custom code for Emoji keyboard Delete key.
The code tries to implement a completely separate touch handler for the Delete
key, so it can do fancy things like suppress haptic feedback during long press.
This is not really necessary.

Change-Id: I0eae758b617e94605035c40e0df15d972ae733c1
2015-02-02 15:24:17 -08:00
Mohammadinamul Sheik a0efc133bd Merge "Create a new KeyboardLayout class to represent the layout." 2015-01-31 01:46:12 +00:00
Mohammadinamul Sheik d543984d2e Create a new KeyboardLayout class to represent the layout.
Change-Id: Ia08c8194f460271c831702675cfb687ab9f6678b
2015-01-30 17:24:09 -08:00
Dan Zivkovic 77e0fa1d67 LatinIME portion of multi-lang option removal.
Bug 19188067.

Change-Id: Ic9a3637f59dda30c699141222b9dcac3cd624b99
2015-01-29 15:57:03 -08:00
Dan Zivkovic e1758feeff Disable the Burmese keyboard.
We'll resurrect this effort in the new code base.

Bug 16900511.

Change-Id: Iae4cd27cb29cb8f991e97cffd88ed59c30d66628
2015-01-29 10:17:33 -08:00
Mario Tanev ab6f3b36d0 Change DictionaryFacilitator.java to an interface, create its
implementation DictionaryFacilitatorImpl.java and add a java-overridable
factory DictionaryFacilitatorProvider.java used to create a
DictionaryFacilitator.

Change-Id: Id4a58ae31feaa4d12a048a772c8d76ff82fdee45
2015-01-27 21:38:32 +00:00
Chieu Nguyen d523bacebc Merge "Add a method for handling for words not found in dictionary." 2015-01-23 16:35:16 +00:00
Dan Zivkovic fc47007674 Merge "AOSP change for showing the app icon." 2015-01-16 17:49:37 +00:00
Dan Zivkovic d913617e0c AOSP change for showing the app icon.
This change deletes a bunch of code that was used to conditionally show/hide
the keyboard app icon given system states and user preferences.

Bug 19001197.

Change-Id: I69a57aa21872a571af87a193b3e52b7f985e5168
2015-01-16 09:37:30 -08:00
Jean Chalard 9fe700ec4f Merge "Fix moving the cursor inside composition in lang w/o spaces" 2015-01-16 03:22:18 +00:00
Chieu Nguyen 2e8d536678 Add a method for handling for words not found in dictionary.
This is apparently called only once for every unique word, so repeated instances
of the same word are not handled separately. Upon changing orientation of the
device, however, all invalid words in the textbox are underlined again and this
method is called for each unique instance in order.

Change-Id: Ic57e4b9e5675bd7abd723644aa318d964f7f875f
2015-01-14 16:20:42 -08:00
Dan Zivkovic 303a2ae5c9 Fix NPE in PunctuationSuggestions.
The NPE happens when the keyboard doesn't specify any punctuation suggestions.

Bug 18047927.

Change-Id: I9f8aa35df4f163b527dc6580a99afc6da45a96b8
2015-01-13 13:24:16 -08:00
Jatin Matani a1a9896b42 Rename production flag for cloud sync feature
Change-Id: I24cbe94f128f54fb9bfeeef78cf271fee2216c8e
2014-12-29 12:45:27 -08:00
Jean Chalard 8e235191dd Fix moving the cursor inside composition in lang w/o spaces
Also introduce the cursor move event, which we needed to do
anyway

Bug: 18827118
Change-Id: I30e994764c095b4423b874dc05d1bbedc0de592f
2014-12-22 17:47:33 +09:00
Jatin Matani 3e35b8712c [3]Ping dictionary stats:Pass DictionaryFacilitator
Pass dictionaryFacilitator to StatsUtilsManager from
LatinIME
Bug:16553957

Change-Id: I912a0b447e5684909ff67e3653a4bd8649cd03c5
2014-12-18 13:42:41 -08:00
Jatin Matani 20469a8779 Merge "[2]Pass context to StatsUtilsManager for alarms." 2014-12-18 21:35:45 +00:00
Jatin Matani 2b69244555 [2]Pass context to StatsUtilsManager for alarms.
Change corresponding to ag/605384

Bug:16553957

Change-Id: I77024957b9497c45296bbbb24ca972b26348a8c3
2014-12-17 12:16:02 -08:00
Tadashi G. Takaoka dbdc81a36a Merge "Cleanup InputMethodInfoCache" 2014-12-17 06:39:19 +00:00
Tadashi G. Takaoka 4077a7e52f Merge "Remove SubtypeSwitcher" 2014-12-17 06:39:07 +00:00
Jatin Matani bc4ae6bdc0 Passing account info to dictionaryFacilitator
Attempt to use dictionary facilitor without invoking
preference manager. Instead use account from settings only when
things are being reset/changed. Discussion forked from ag/591663

Overall, the idea here is to maintain an account information
inside dictionary groups. Reset the dictionary groups if
account changes (the way we do for locale). Since only user
history dictionary is currently affected, the check to reset user
history dictionary also includes the check to verify the account.
For other things remain the same.

SettingsValues holds the current account (and is updated if prefs change
due to change in account settings). The updated settings are then
propagated to dictionary facilitator via LatinIME#loadSettings.

Bug:18104749,18469539
Change-Id: I553e776e7ea125d0fb7a1fe70a4c7eb0b2277fb8
2014-12-16 15:56:00 -08:00
Jatin Matani 25daca0053 Merge "Provide a preference to delete data from cloud." 2014-12-12 19:43:16 +00:00
Tadashi G. Takaoka afd52dfc60 Cleanup InputMethodInfoCache
Change-Id: I40afeb4557c3b1ad32bd90f67502a625df2bc3fb
2014-12-12 13:53:13 +09:00
Tadashi G. Takaoka 31a10e226d Remove SubtypeSwitcher
Change-Id: Ic4def69a9f742f13c98bc3e518c406658b52797d
2014-12-12 13:45:46 +09:00
Tadashi G. Takaoka 8cfad7ed64 Merge "Make LanguageOnSpacebarHelper as utility class" 2014-12-12 04:42:09 +00:00
Jean Chalard 498dbfbd9d Disable multiple language input
Bug: 18705799
Change-Id: I73730ccf59e2697acfb3fe436c01b94c40307f2f
2014-12-11 14:50:03 +09:00
Tadashi G. Takaoka 4934a88b61 Make LanguageOnSpacebarHelper as utility class
Change-Id: I546f3b1943999a41803222bd14f9ddd23aa87a51
2014-12-11 14:22:21 +09:00
Tadashi G. Takaoka 2b25f674f2 Add NetworkConnectivityUtils class
Change-Id: I7bd71f1d4ef0fc0fe21ddfd9f3e11463f53ac4e7
2014-12-11 01:37:44 +00:00
Jatin Matani 6814e7aa87 Provide a preference to delete data from cloud.
For now, it is a debug preference, but we may make this a proper
user setting in the future. Thus note that the messaging is not
final.

Pref looks like :
1. https://screenshot.googleplex.com/OLxW0myWD9.png
2. https://screenshot.googleplex.com/YeqWYXGstw.png

Bug: 18106936
Change-Id: I88bbc1a2ee0c23a48ff3972a91d57c218b10bb65
2014-12-09 12:45:34 -08:00
Keisuke Kuroyanagi 52e92f812b Merge "Quit auto-correct explicit accented letters to base letters." 2014-12-09 10:24:56 +00:00
Keisuke Kuroyanagi 515c508135 Quit auto-correct explicit accented letters to base letters.
Bug: 7677193
Change-Id: I66eddbf27a9db8682c0347a1be19922792a3bea7
2014-12-09 19:23:27 +09:00
Tadashi G. Takaoka be819dbe2b Revert "Add keyboard margin options to place the keyboard dynamically."
This reverts commit 8584db1461.

Bug: 18675223
Bug: 18675476
Change-Id: I4e25d87ac261c44b1943df832115f8cca690103a
2014-12-09 17:53:24 +09:00
Jatin Matani 45bbdc20bb Merge "Rename variable name to remove ambiguity" 2014-12-09 03:53:22 +00:00
Jatin Matani 88cd34f8f8 Rename variable name to remove ambiguity
Change-Id: If95c34c9eab09cbc941bef5ee3d34b9048bf3bf9
2014-12-08 19:27:25 -08:00
Tadashi G. Takaoka 8af412d80c Remove unnecessary cast and import
Change-Id: I9bcd6c9c48ad51aa0f95937869eb6757e4dd4511
2014-12-09 11:57:32 +09:00
Jatin Matani 2bdd5290a9 Merge "Hook for fetching sync content from UserHistoryDict" 2014-12-08 20:00:10 +00:00
Tadashi G. Takaoka 3dca77ec07 Merge "Refactor KeysCache to UniqueKeysCache" 2014-12-08 08:33:38 +00:00
Tadashi G. Takaoka 5ac8b040e8 Merge "Remove RichInputMethodManager.updateShortcutIME call from SubtypeSwitcher" 2014-12-06 01:44:54 +00:00
Andy Wang 8584db1461 Add keyboard margin options to place the keyboard dynamically.
Keyboard location and location can now be set in the debug options
section.

Change-Id: I87c5a1d679489e12dccf26632c399af28087629e
2014-12-05 16:21:20 +09:00
Keisuke Kuroyanagi e79d504cf5 Merge "Cancel interval alarm for dictionary decaying in onDestroy." 2014-12-03 02:32:52 +00:00
Keisuke Kuroyanagi 47ae0c3af4 Cancel interval alarm for dictionary decaying in onDestroy.
Bug: 18528171
Change-Id: I6e12c006bd9eff15f3fa9cfd335bdd9fa081be61
2014-12-02 15:10:10 +09:00
Andy Wang d179e40899 Stop passing through keyPrefs as it's already available.
Change-Id: I43a56beba0cf0fdf5f93c5c764edbd279ee033b2
2014-12-02 05:17:51 +00:00
Adrian Velicu 11a3965f8c Fix a misspelled method name
Change-Id: I1151dc1d5db3986a97daf68c1e387dbc2e4610dc
2014-12-02 12:53:56 +09:00
Tadashi G. Takaoka 391e83dc8f Merge "Add null analysis annotations to keyboard package" 2014-12-01 03:37:53 +00:00
Tadashi G. Takaoka 4486314225 Remove RichInputMethodManager.updateShortcutIME call from SubtypeSwitcher
Change-Id: I5661a7926cf5a404788516c542b25cc0707bb417
2014-12-01 12:16:10 +09:00
Jean Chalard 949045b6a3 Merge "Be always confident in the current language when only one" 2014-11-28 03:25:29 +00:00
Jean Chalard 2d81c1f183 Be always confident in the current language when only one
Change-Id: I7ea289f7e78aa33562c7737e91024a25c02333b6
2014-11-28 12:22:16 +09:00
Tadashi G. Takaoka 063b2e8d71 Merge "Make LocaleUtils.constructLocaleFromString as @Nonnull" 2014-11-28 03:02:20 +00:00
Tadashi G. Takaoka b0a0ce0b31 Remove unused import and local variable
Change-Id: I256d1c6bf96c07b10d2d063d7935e20e0ab8ea17
2014-11-28 11:53:12 +09:00
Tadashi G. Takaoka 60d880cf5e Remove unnecessary code of CustomInputStylePreference
Change-Id: I68d2c85139e01684d5f0705f621ba223fc5e4425
2014-11-27 17:05:37 +09:00
Tadashi G. Takaoka 01d54002b3 Refactor KeysCache to UniqueKeysCache
Change-Id: I8e3c4705c705a1c6e05e9112211d7012912d7e41
2014-11-27 15:44:22 +09:00
Tadashi G. Takaoka 9d5d01a543 Add null analysis annotations to keyboard package
Change-Id: I6f020ece3c45d584d413e4265d6d3fbdf1ea8bd8
2014-11-27 12:37:38 +09:00
Tadashi G. Takaoka bb4075bc93 Merge "Fix possible NPE in MainKeyboardView" 2014-11-27 03:03:54 +00:00