059f4c2f39
[IL30] Minor refactoring
...
Change-Id: I8a8aa9f703c6fca5e25ec573b41f325680ac92dc
2013-12-20 20:47:44 +09:00
0547b33130
[IL29] Move retryResetCaches and tryFixLyingCursorPosition
...
Bug: 8636060
Change-Id: I45b322e4844f023e91b80f9c2e0f7fa0166bcc59
2013-12-20 20:47:29 +09:00
81e8d16031
[IL28] Remove useless code
...
I don't understand why this was checked in. The tests are completely
useless, that makes the variables write-only, and the only side effect
is useless as the keyboard commits suicide upon exiting debug
settings.
Change-Id: I4eb25295183f43a2e947a6a0467ea168d023c18a
2013-12-20 19:48:05 +09:00
55ce2cc2d5
[IL27] Some refactoring
...
Bug: 8636060
Change-Id: Iedfdf71350f5fe3ab451fc5ec6e3c9901f71e50f
2013-12-20 19:24:38 +09:00
221df9e59a
[IL26] Move restartSuggestionsOnWordTouchedByCursor
...
Bug: 8636060
Change-Id: I373874585f4fa663b4207b9a02d751805259eb36
2013-12-20 19:09:36 +09:00
ec4b6e7bb3
[IL25] Inline handleClose
...
Only ever used here.
Bug: 8636060
Change-Id: Ia98c8bbe1c63ad4d057efe1cee87829b06124479
2013-12-20 18:44:13 +09:00
aa161eb371
[IL24] Move mDisplayOrientation to SettingsValues.
...
Bug: 8636060
Change-Id: Id57ced0cca9dc9e5e85c3a53683588feb28c1402
2013-12-20 18:44:09 +09:00
11730aa224
[IL22] Move onTextInput to InputLogic.
...
Also pull the TLD specific processing
Bug: 8636060
Change-Id: I20931ac6fc6c55a05aa8f8b97b0210c07d230ea2
2013-12-20 16:50:14 +09:00
1404c1af85
[IL21] Move the workaround utils to a better place.
...
Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
2013-12-20 16:48:54 +09:00
8a390023e1
[IL20] Remove some useless processing.
...
If we have the same text field, then the target app is
necessarily the same. No need to re-evaluate it.
Bug: 8636060
Change-Id: I66eb194c4cd08a6c1d47b26b99bd7f420130097e
2013-12-20 16:02:07 +09:00
4487a30e0d
[IL19] Resolve a TODO.
...
Bug: 8636060
Change-Id: Iec7c1001c46cf8e9a44422e3f9008e437cc5cab6
2013-12-20 16:02:03 +09:00
2a6de7903c
[IL18] Move and rename updateSuggestionStrip
...
Bug: 8636060
Change-Id: I3d00095cd0e83d1ee3834b37ff188b5aa9806fcb
2013-12-20 15:46:34 +09:00
1c0374da49
[IL17] Move commitChosenWord to InputLogic.
...
Also not-cache a value whose documentation says not to cache
it. That makes it write only, so remove it.
Bug: 8636060
Change-Id: I39798a039cebf79ad78a41fe457c9d9764a3f275
2013-12-20 15:13:48 +09:00
a905fcec00
[IL16] Improve getTextWithSuggestionSpan
...
Dynamically test for the presence of main dict suggestions. This
is much more potent and more accurate than the vaguely defined
boolean.
Also, resolve a TODO and avoid creating an object uselessly.
Not directly related, but helpful with:
Bug: 8636060
Change-Id: Ib1745f77ee6d9ec7cd8bbfa5a548652ec84ec902
2013-12-20 15:13:48 +09:00
5c9e677c2a
[IL15] Some small refactoring
...
Bug: 8636060
Change-Id: I4bfdf1628c9b55a79bd2d88ee30bf10b08a49232
2013-12-20 11:24:45 +09:00
48ba1f25ff
[IL14] Move getCurrent*Caps* to InputLogic
...
Bug: 8636060
Change-Id: I6338dcee0f7a80f2181ba0369f71350cb21d231a
2013-12-20 11:24:42 +09:00
bbe40835a9
[IL12] move restartSuggestions* to InputLogic
...
Bug: 8636060
Change-Id: I99474248e8fa35eb3053b5520abc8716805fdfb4
2013-12-19 20:30:41 +09:00
10755af97b
[IL11] Cleanup
...
Make some methods private and add comments.
Bug: 8636060
Change-Id: I6c7d13dca8a22dd1a6f110e8b18d52864429579f
2013-12-19 20:13:14 +09:00
060e292628
[IL10] Move revertCommit to InputLogic
...
Bug: 8636060
Change-Id: Ia5788b365f05ae880bad957cbef00ecc93abb5d1
2013-12-19 19:30:26 +09:00
69a57bcdcd
[IL9] Move commitCurrentAutoCorrection to InputLogic
...
Bug: 8636060
Change-Id: I405c4a537858a6d5ab0b29502a2792e8c3b2564e
2013-12-19 19:30:20 +09:00
035e3885ac
[IL8] Move handleNonSeparator to InputLogic
...
Also move getActualCapsMode and getNthPreviousWordForSuggestion
Bug: 8636060
Change-Id: I1ee9162d0b7a517070c4b7420b084c973f061533
2013-12-19 18:32:51 +09:00
d85e49bf8c
[IL7] Move performRecapitalization to InputLogic
...
Bug: 8636060
Change-Id: I5bf2b1fa2f9338fe28151e66eac1ceda6dbd4a7f
2013-12-19 18:20:41 +09:00
40b42b7d84
[IL6] Move handleSeparator to InputLogic
...
Also move swapSwapperAndSpace, maybeDoubleSpacePeriod,
maybeStripSpace, promotePhantomSpace and canBeFollowedByDoubleSpacePeriod
Bug: 8636060
Change-Id: I864053d21c4b3d51ee7a3cd79053ca602337f6f8
2013-12-19 17:39:01 +09:00
c8dfaab783
[IL5] Some renaming
...
Bug: 8636060
Change-Id: Id76889f8405458bcacb9c7c694cb193b27b842f3
2013-12-19 17:38:55 +09:00
37d3f1bd02
[IL4] Move handleNonSpecialCharacter to InputLogic.
...
Bug: 8636060
Change-Id: I9c6869c85db49d7f87e95a421389eaf47ae3ab2e
2013-12-19 16:46:57 +09:00
0e82fa273d
[IL3] Move handleBackspace to InputLogic.
...
Also move resetEntireInputState, resetComposingState,
sendDownUpKeyEvent, sendKeyCodePoint and getTextWithUnderline
Bug: 8636060
Change-Id: Ic4c270ac49769ffba41dc3f12d16ac3aa938717f
2013-12-19 16:46:54 +09:00
cddf4f9d78
[IL2] Move onCodeInput to InputLogic.
...
Bug: 8636060
Change-Id: I8c5c028d81183adb0167b2034ee01de8048edafb
2013-12-19 16:24:45 +09:00
7bd2a75ca1
Start separating the input logic from LatinIME.
...
Create an InputEngine class and start moving the relevant
variables to it.
Bug: 8636060
Change-Id: I64adef4ac01e665c19bb7c5b93517a0cbd03d817
2013-12-19 14:48:43 +09:00
dfbe2bfe08
Add some info to test crashes to help diagnose flakiness
...
Bug: 11142685
Change-Id: Ic3a5d452f6c325248ac4e1bfa37774c58586f359
2013-12-18 18:10:56 +09:00
1f5a3faf76
Merge "Enable Personalized dictionaries based on the setting."
2013-12-17 10:40:29 +00:00
8732f9c5f9
Enable Personalized dictionaries based on the setting.
...
Bug: 11757851
Change-Id: I83e484195f036e35cbae21fe63148bc9c22bfad7
2013-12-17 19:36:19 +09:00
7cd7cf73f4
Fix a bug with languages without spaces and predictions
...
This is simpler and more correct.
Change-Id: I41806d2fc12b4ca25f76e32972b38f91f3d05c2b
2013-12-16 23:16:02 +09:00
dc06ee85ef
A simplification.
...
This does the same thing, but simpler and faster.
Was noticed while investigating bug#12164555
Change-Id: If9926e4da8a53a65489da55197ac87122c44fe7c
2013-12-16 21:38:31 +09:00
7a904514fb
Merge "Don't use the previous word after a non-whitespace separator"
2013-12-13 11:53:30 +00:00
0b51fac907
Merge "Only update shift state if left in auto mode."
2013-12-13 11:52:13 +00:00
fae1ba767c
Don't use the previous word after a non-whitespace separator
...
Bug: 12101276
Change-Id: Icf36d55ec171194e5561b946021bcf648782ddd4
2013-12-13 20:51:28 +09:00
28bd6e2297
Only update shift state if left in auto mode.
...
Bug: 12100417
Change-Id: I7bc2b19332e142a257b0399f2e5d128caf01fc7c
2013-12-13 20:47:25 +09:00
cc8c544ee2
Remove code for forgetting curve in Java side.
...
Change-Id: I294ed179c642ff52452b5884326c1083477e1bce
2013-12-13 18:40:58 +09:00
2fa3693c26
Reset to 9bd6dac470
...
The bulk merge from -bayo to klp-dev should not have been merged to master.
Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
2013-12-13 17:13:32 +09:00
ea8f8da1ac
Fix unusual NPE after onDestroy
...
Bug: 11673978
Change-Id: I4d5268312911685ff1ca9483a62442a1a9686c62
2013-11-22 17:26:42 -08:00
db86a6f271
Add keyboard color switch option
...
Bug: 11622614
Change-Id: I25aa1ff7376fe72fd94ab2cb7190c61d7a98a1af
2013-11-22 17:26:33 -08:00
87cd39124a
handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL
...
This is a fix only for the Bayo branch because this part in master has
been changed.
The corresponding fix in master is I295eeb5f9f0f1f07e919bf54122d003be150a174
bug: 11797053
Change-Id: I779be039ebf992de5d246c7a9d9509623fc3c120
2013-11-21 17:47:05 +09:00
3a9b2430a5
Fix many small nits.
...
...the interaction of which results in a very bad bug.
Bug: 11648854
Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
2013-11-12 22:44:59 -08:00
e4022137ee
Remove an out-of-place check
...
Bug: 11584525
Change-Id: I76cc3e4ee21d62fbd56042adcf085efd5cafb53f
2013-11-12 22:44:58 -08:00
c130be8779
Add a sequence number to SuggestedWords.
...
This allows testing for suggestion freshness in an asynchronous
suggestions world.
In-advance cherrypick of Ic76cd17568598d8534aec81e037f9e37f52eb6b4
because there's a merge conflict.
Bug: 11301597
Change-Id: I4aec765a975298fcac30a48dede73d2622224fe5
2013-10-22 13:19:16 +09:00
b044047227
mExpectingUpdateSelection was out of sync when nothing to delete.
...
cherripick of I9c6a948331726a821bd3ccec9c1d02dec2c4703a
(forward cherrypicking this because the automerger is stuck now.)
This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.
1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace
The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.
bug: 11181913
Change-Id: I1cbf444d8d105416e7de75c16d80b3797f470495
2013-10-15 14:05:34 +09:00
cf5dfd2464
am 3a3bbf4a: am eed74b81: am c8383eda: Fix wrong commitText parameter in sendKeyCodePoint()
...
* commit '3a3bbf4a38870ecc42b7f6fbd3a7cae20fe020a7':
Fix wrong commitText parameter in sendKeyCodePoint()
2013-10-14 10:52:40 -07:00
c8383eda8b
Fix wrong commitText parameter in sendKeyCodePoint()
...
Small optimization on generating a String instance from a single code
point too.
bug: 11181913
Change-Id: I0f905e4dc6ec7841092bb4d3d940daf3b2303f5b
2013-10-13 10:56:10 +09:00
fe97ff4083
am 60fb5865: am 06e1bdaa: am 3e35e072: Merge "Make emoji separators" into klp-dev
...
* commit '60fb58654e33448651fea191ba22cfdc87e37466':
Make emoji separators
2013-10-11 05:10:21 -07:00
eb7fa4dc6d
am 40506273: am ac6d0c65: am 6d915037: Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev
...
* commit '405062733cfe066c4b9af719bfc36a9a516c9dd3':
Fix a bug where emojis would remove the suggestion strip.
2013-10-11 05:10:19 -07:00
Jean Chalard
Keisuke Kuroyanagi
Ken Wakasa
Tadashi G. Takaoka
Satoshi Kataoka