gitea/models
mrsdizzie 8d99ee2773
Add Organization Wide Labels ()
* Add organization wide labels

Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).

This makes it possible for small organizations with many repos to use
labels effectively.

Fixes 

* Add migration

* remove comments

* fix tests

* Update options/locale/locale_en-US.ini

Removed unused translation string

* show org labels in issue search label filter

* Use more clear var name

* rename migration after merge from master

* comment typo

* update migration again after rebase with master

* check for orgID <=0 per guillep2k review

* fmt

* Apply suggestions from code review

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* remove unused code

* Make sure RepoID is 0 when searching orgID per code review

* more changes/code review requests

* More descriptive translation var per code review

* func description/delete comment when issue label deleted instead of hiding it

* remove comment

* only use issues in that repo when calculating number of open issues for org label on repo label page

* Add integration test for IssuesSearch API with labels

* remove unused function

* Update models/issue_label.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* Use subquery in GetLabelIDsInReposByNames

* Fix tests to use correct orgID

* fix more tests

* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well

* update comment for clarity

* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition

* Don't sort repos by date in IssuesSearch API

After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45

Returns different results for MySQL than other engines. However, the similar query:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30

Returns the same results.

This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.

* linter is back!

* code review

* remove now unused option

* Fix newline at end of files

* more unused code

* update to master

* check for matching ids before query

* Update models/issue_label.go

Co-Authored-By: 6543 <6543@obermui.de>

* Update models/issue_label.go

* update comments

* Update routers/org/setting.go

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 01:14:46 -03:00
..
fixtures Add Organization Wide Labels () 2020-04-01 01:14:46 -03:00
migrations Add Organization Wide Labels () 2020-04-01 01:14:46 -03:00
access.go Upgrade xorm to v1.0.0 () 2020-03-22 11:12:55 -04:00
access_test.go Fix "access" fixtures and tests () 2020-02-15 12:29:06 +08:00
action.go Fix potential bugs () 2020-02-27 20:10:27 -03:00
action_list.go refactor: reduce sql query in retrieveFeeds () 2018-02-21 18:55:34 +08:00
action_test.go Restricted users () 2020-01-13 18:33:46 +01:00
admin.go Use gitea forked macaron () 2019-08-23 12:40:29 -04:00
admin_test.go Fix tests code to prevent some runtime errors () 2017-08-28 12:17:45 +03:00
attachment.go Fix potential bugs () 2020-02-27 20:10:27 -03:00
attachment_test.go Reading pull attachments should depend on read UnitTypePullRequests () 2020-02-18 21:36:19 -03:00
avatar.go make avatar lookup occur at image request () 2020-03-27 14:34:39 +02:00
branches.go Allow to set protected file patterns that can not be changed under no conditions () 2020-03-27 00:26:34 +02:00
branches_test.go Add deleted_branch table fixture () 2017-11-04 15:31:59 +02:00
commit_status.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
commit_status_test.go Fix wrong hint when status checking is running on pull request view () 2020-01-22 11:46:04 +08:00
consistency.go Auto-subscribe user to repository when they commit/tag to it () 2019-11-10 09:22:19 +00:00
context.go Refactor repository check and sync functions () 2020-01-20 20:01:19 +00:00
convert.go Move database settings from models to setting () 2019-08-24 11:24:45 +02:00
error.go Add Organization Wide Labels () 2020-04-01 01:14:46 -03:00
error_oauth2.go gofmt () 2017-05-04 13:54:56 +08:00
external_login_user.go Migrate reviews when migrating repository from github () 2020-01-23 19:28:15 +02:00
fixture_generation.go Move fixture generation to contrib and add test () 2020-02-15 10:59:43 +02:00
fixture_test.go Move fixture generation to contrib and add test () 2020-02-15 10:59:43 +02:00
gpg_key.go Show Signer in commit lists and add basic trust () 2020-02-27 16:20:55 -03:00
gpg_key_test.go Display ui time with customize time location () 2019-08-15 22:46:21 +08:00
helper.go Add reactions to issues/PR and comments () 2017-12-04 01:14:26 +02:00
helper_directory.go Remove SavePatch and generate patches on the fly () 2019-12-13 23:21:06 +01:00
helper_environment.go Move PushUpdateAddDeleteTags to repository module from models () 2020-02-03 09:47:04 +01:00
issue.go Add Organization Wide Labels () 2020-04-01 01:14:46 -03:00
issue_assignees.go Remove Unused Functions () 2020-03-02 00:05:44 +02:00
issue_assignees_test.go Fix API Bug (fail on empty assignees) () 2019-11-10 16:07:21 +08:00
issue_comment.go Fix potential bugs () 2020-02-27 20:10:27 -03:00
issue_comment_list.go Fixed repo link in generated comment for cross repository dependency () 2020-01-21 10:18:52 +00:00
issue_comment_test.go Pull request review/approval and comment on code () 2018-08-06 06:43:21 +02:00
issue_dependency.go Display ui time with customize time location () 2019-08-15 22:46:21 +08:00
issue_dependency_test.go Refactor comment () 2019-12-15 16:57:34 -05:00
issue_label.go Add Organization Wide Labels () 2020-04-01 01:14:46 -03:00
issue_label_test.go Add Organization Wide Labels () 2020-04-01 01:14:46 -03:00
issue_list.go Add Approval Counts to pulls list () 2020-03-06 03:44:06 +00:00
issue_list_test.go Add Organization Wide Labels () 2020-04-01 01:14:46 -03:00
issue_lock.go remove unused method and rename createcommentWithNoAction () 2019-12-16 11:54:24 +08:00
issue_milestone.go Fix milestones too many SQL variables bug () 2020-03-31 10:47:00 +03:00
issue_milestone_test.go Fix milestones too many SQL variables bug () 2020-03-31 10:47:00 +03:00
issue_reaction.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
issue_reaction_test.go Migrate reactions when migrating repository from github () 2020-01-15 12:14:07 +01:00
issue_stopwatch.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
issue_stopwatch_test.go Display ui time with customize time location () 2019-08-15 22:46:21 +08:00
issue_test.go issue search on my related repositories () 2020-02-29 03:52:05 -03:00
issue_tracked_time.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
issue_tracked_time_test.go [API] Extend times API () 2019-12-27 20:30:58 +00:00
issue_user.go Mail assignee when issue/pull request is assigned () 2019-10-25 22:46:37 +08:00
issue_user_test.go Add "Update Branch" button to Pull Requests () 2020-01-17 08:03:40 +02:00
issue_watch.go [BugFix] Avoid mailing explicit unwatched () 2020-02-27 10:07:05 +00:00
issue_watch_test.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
issue_xref.go remove unused method and rename createcommentWithNoAction () 2019-12-16 11:54:24 +08:00
issue_xref_test.go Refactor comment () 2019-12-15 16:57:34 -05:00
lfs.go Restricted users () 2020-01-13 18:33:46 +01:00
lfs_lock.go Make repository management section handle lfs locks () 2019-12-12 21:18:07 +08:00
list_options.go Upgrade xorm to v1.0.0 () 2020-03-22 11:12:55 -04:00
log.go Upgrade xorm to v1.0.0 () 2020-03-22 11:12:55 -04:00
login_source.go Upgrade xorm to v1.0.0 () 2020-03-22 11:12:55 -04:00
main_test.go Unit tests for wiki routers () 2017-11-30 17:52:15 +02:00
migrate.go Fix migration information update bug when linked github account () 2020-02-17 19:42:13 -05:00
models.go Fix typo of MSSQL () 2020-03-27 16:12:39 +02:00
models_test.go Move database settings from models to setting () 2019-08-24 11:24:45 +02:00
notification.go Upgrade golangci-lint to 1.24.0 () 2020-03-30 21:52:45 +03:00
notification_test.go [API] Add notification endpoint () 2020-01-09 11:56:32 +00:00
oauth2.go OAuth2: add Yandex provider () () 2020-03-05 00:08:52 +02:00
oauth2_application.go adds API endpoints to manage OAuth2 Application (list/create/delete) () 2020-02-29 03:19:32 -03:00
oauth2_application_test.go OAuth2 Grant UI () 2019-04-17 16:18:16 +08:00
org.go Ensure DeleteUser is not allowed to Delete Orgs and visa versa () 2020-02-04 16:27:18 +02:00
org_team.go Upgrade xorm to v1.0.0 () 2020-03-22 11:12:55 -04:00
org_team_test.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
org_test.go Ensure DeleteUser is not allowed to Delete Orgs and visa versa () 2020-02-04 16:27:18 +02:00
pull.go Add Approval Counts to pulls list () 2020-03-06 03:44:06 +00:00
pull_list.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
pull_sign.go Display pull request head branch even the branch deleted or repository deleted () 2020-03-02 22:31:55 +00:00
pull_test.go Display pull request head branch even the branch deleted or repository deleted () 2020-03-02 22:31:55 +00:00
release.go Move PushUpdateAddDeleteTags to repository module from models () 2020-02-03 09:47:04 +01:00
repo.go Option to set default branch at repository creation () 2020-03-26 19:14:51 +00:00
repo_activity.go Add top author stats to activity page () 2020-01-20 12:07:30 +02:00
repo_branch.go Move newbranch to standalone package () 2020-01-14 11:38:04 +08:00
repo_collaboration.go Show Signer in commit lists and add basic trust () 2020-02-27 16:20:55 -03:00
repo_collaboration_test.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
repo_generate.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
repo_generate_test.go Variable expansion in repository templates () 2019-11-30 01:54:47 -05:00
repo_indexer.go Index code and stats only for non-empty repositories () 2020-02-14 13:42:30 +01:00
repo_issue.go Add EnableTimetracking option to app settings () 2018-04-09 23:15:32 +08:00
repo_language_stats.go Index code and stats only for non-empty repositories () 2020-02-14 13:42:30 +01:00
repo_list.go Fix milestones too many SQL variables bug () 2020-03-31 10:47:00 +03:00
repo_list_test.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
repo_mirror.go Move some repository methods from models to modules/repository () 2019-12-14 18:30:01 +01:00
repo_permission.go Restricted users () 2020-01-13 18:33:46 +01:00
repo_permission_test.go fix bug when update owner team then visit team's repo return 404 () 2019-02-22 11:14:45 -05:00
repo_redirect.go Move repoWorkPool outside rename/transfer repository () 2019-12-06 12:00:50 +08:00
repo_redirect_test.go Move repoWorkPool outside rename/transfer repository () 2019-12-06 12:00:50 +08:00
repo_sign.go Sign: Handle ErrTwoFactorNotEnrolled correctly () 2020-01-26 23:44:12 +00:00
repo_test.go Move create/fork repository from models to modules/repository () 2020-01-12 20:11:17 +08:00
repo_unit.go Upgrade xorm to v1.0.0 () 2020-03-22 11:12:55 -04:00
repo_watch.go Code Refactor of IssueWatch related things () 2020-02-26 03:32:22 -03:00
repo_watch_test.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
review.go Migrate reviews when migrating repository from github () 2020-01-23 19:28:15 +02:00
review_test.go Branch protection: Possibility to not use whitelist but allow anyone with write access () 2019-12-03 20:08:56 -05:00
ssh_key.go Use ErrKeyUnableToVerify if fail to calc fingerprint in ssh-keygen () 2020-03-28 19:24:55 +02:00
ssh_key_test.go Fix SSH2 conditonal in key parsing code () 2019-11-03 19:08:18 +08:00
star.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
star_test.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
task.go Move create/fork repository from models to modules/repository () 2020-01-12 20:11:17 +08:00
test_fixtures.go Upgrade xorm to v1.0.0 () 2020-03-22 11:12:55 -04:00
token.go FIX Pagination of ListAccessTokens and GetIssueWatchers () 2020-02-24 16:50:32 -06:00
token_test.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
topic.go Update topics repo count when deleting repository () 2020-01-31 08:57:19 +02:00
topic_test.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
twofactor.go Display ui time with customize time location () 2019-08-15 22:46:21 +08:00
u2f.go Display ui time with customize time location () 2019-08-15 22:46:21 +08:00
u2f_test.go Override xorm type mapping for U2F counter () 2019-03-04 21:34:52 -05:00
unit.go Add setting to set default and global disabled repository units. () 2020-01-17 09:34:37 +02:00
unit_tests.go Upgrade xorm to v1.0.0 () 2020-03-22 11:12:55 -04:00
update.go Remove Unused Functions () 2020-03-02 00:05:44 +02:00
upload.go Use gitea forked macaron () 2019-08-23 12:40:29 -04:00
user.go Add restricted user filter to LDAP authentication () 2020-03-05 08:30:33 +02:00
user_follow.go Refactor session close as xorm already does everything needed internally () 2017-06-21 08:57:05 +08:00
user_follow_test.go Move user_follow to separate file () 2017-03-11 16:46:53 +08:00
user_heatmap.go Move database settings from models to setting () 2019-08-24 11:24:45 +02:00
user_heatmap_test.go Restricted users () 2020-01-13 18:33:46 +01:00
user_mail.go Admin page for managing user e-mail activation () 2020-03-02 15:25:36 -03:00
user_mail_test.go Admin page for managing user e-mail activation () 2020-03-02 15:25:36 -03:00
user_openid.go Fix SQL quoting () 2018-10-20 18:19:21 -04:00
user_openid_test.go Add golangci () 2019-06-12 15:41:28 -04:00
user_test.go Ensure DeleteUser is not allowed to Delete Orgs and visa versa () 2020-02-04 16:27:18 +02:00
userlist.go API add/generalize pagination () 2020-01-24 14:00:29 -05:00
userlist_test.go Team permission to create repository in organization () 2019-11-20 19:27:49 +08:00
webhook.go Add Matrix webhook () 2020-03-28 15:09:55 +02:00
webhook_test.go Granular webhook events () 2020-03-06 07:10:48 +02:00
wiki.go Add owner_name column for table repository for maintaince reason () 2020-01-12 17:36:21 +08:00
wiki_test.go Move wiki related funtions from models to services/wiki () 2020-01-07 18:27:36 +00:00