diff --git a/app/src/main/java/code/name/monkey/retromusic/adapter/ContributorAdapter.kt b/app/src/main/java/code/name/monkey/retromusic/adapter/ContributorAdapter.kt index 4095e801..376c6825 100644 --- a/app/src/main/java/code/name/monkey/retromusic/adapter/ContributorAdapter.kt +++ b/app/src/main/java/code/name/monkey/retromusic/adapter/ContributorAdapter.kt @@ -51,7 +51,7 @@ class ContributorAdapter( inner class ViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) { val title: TextView = itemView.findViewById(R.id.title) val text: TextView = itemView.findViewById(R.id.text) - val image: CircularImageView = itemView.findViewById(R.id.image) + val image: CircularImageView = itemView.findViewById(R.id.icon) internal fun bindData(contributor: Contributor) { title.text = contributor.name diff --git a/app/src/main/java/code/name/monkey/retromusic/preferences/LibraryPreference.kt b/app/src/main/java/code/name/monkey/retromusic/preferences/LibraryPreference.kt index 21700811..1903463e 100644 --- a/app/src/main/java/code/name/monkey/retromusic/preferences/LibraryPreference.kt +++ b/app/src/main/java/code/name/monkey/retromusic/preferences/LibraryPreference.kt @@ -25,6 +25,7 @@ import androidx.recyclerview.widget.LinearLayoutManager import androidx.recyclerview.widget.RecyclerView import code.name.monkey.appthemehelper.ThemeStore import code.name.monkey.appthemehelper.common.prefs.supportv7.ATEDialogPreference +import code.name.monkey.retromusic.R import code.name.monkey.retromusic.adapter.CategoryInfoAdapter import code.name.monkey.retromusic.model.CategoryInfo import code.name.monkey.retromusic.util.PreferenceUtil @@ -58,7 +59,7 @@ class LibraryPreferenceDialog : PreferenceDialogFragmentCompat() { lateinit var adapter: CategoryInfoAdapter override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { - val view = activity!!.layoutInflater.inflate(code.name.monkey.retromusic.R.layout.preference_dialog_library_categories, null) + val view = requireActivity().layoutInflater.inflate(R.layout.preference_dialog_library_categories, null) val categoryInfos: List if (savedInstanceState != null) { @@ -68,14 +69,14 @@ class LibraryPreferenceDialog : PreferenceDialogFragmentCompat() { } adapter = CategoryInfoAdapter(categoryInfos) - val recyclerView = view.findViewById(code.name.monkey.retromusic.R.id.recycler_view) + val recyclerView = view.findViewById(R.id.recycler_view) recyclerView.layoutManager = LinearLayoutManager(activity) recyclerView.adapter = adapter adapter.attachToRecyclerView(recyclerView) return MaterialDialog(requireContext(), BottomSheet(LayoutMode.WRAP_CONTENT)) - .title(code.name.monkey.retromusic.R.string.library_categories) + .title(R.string.library_categories) .cornerRadius(PreferenceUtil.getInstance(requireContext()).dialogCorner) .customView(view = view) .positiveButton(android.R.string.ok) { @@ -85,7 +86,7 @@ class LibraryPreferenceDialog : PreferenceDialogFragmentCompat() { .negativeButton(android.R.string.cancel) { dismiss() } - .neutralButton(code.name.monkey.retromusic.R.string.reset_action) { + .neutralButton(R.string.reset_action) { adapter.categoryInfos = PreferenceUtil.getInstance(requireContext()).defaultLibraryCategoryInfos } .noAutoDismiss() diff --git a/app/src/main/java/code/name/monkey/retromusic/views/ListItemView.kt b/app/src/main/java/code/name/monkey/retromusic/views/ListItemView.kt index fdf5dc66..5ebfd419 100644 --- a/app/src/main/java/code/name/monkey/retromusic/views/ListItemView.kt +++ b/app/src/main/java/code/name/monkey/retromusic/views/ListItemView.kt @@ -18,8 +18,10 @@ import android.content.Context import android.util.AttributeSet import android.view.View import android.widget.FrameLayout +import androidx.constraintlayout.widget.ConstraintLayout import code.name.monkey.retromusic.R import code.name.monkey.retromusic.extensions.hide +import code.name.monkey.retromusic.util.DensityUtil import kotlinx.android.synthetic.main.list_item_view.view.* /** @@ -42,7 +44,16 @@ class ListItemView : FrameLayout { View.inflate(context, R.layout.list_item_view, this) val typedArray = context.obtainStyledAttributes(attrs, R.styleable.ListItemView) - appCompatImageView.setImageDrawable(typedArray.getDrawable(R.styleable.ListItemView_listItemIcon)) + if (typedArray.hasValue(R.styleable.ListItemView_listItemIcon)) { + icon.setImageDrawable(typedArray.getDrawable(R.styleable.ListItemView_listItemIcon)) + } else { + val params = title.layoutParams as ConstraintLayout.LayoutParams + val startDP = DensityUtil.dip2px(context, 72.0f) + params.setMargins(startDP, title.paddingTop, title.paddingRight, title.paddingBottom) + summary.setPadding(startDP, title.paddingTop, title.paddingRight, title.paddingBottom) + icon.hide() + } + title.text = typedArray.getText(R.styleable.ListItemView_listItemTitle) if (typedArray.hasValue(R.styleable.ListItemView_listItemSummary)) { summary.text = typedArray.getText(R.styleable.ListItemView_listItemSummary) diff --git a/app/src/main/res/layout/fragment_color_player_playback_controls.xml b/app/src/main/res/layout/fragment_color_player_playback_controls.xml index 55f46125..67018ae0 100644 --- a/app/src/main/res/layout/fragment_color_player_playback_controls.xml +++ b/app/src/main/res/layout/fragment_color_player_playback_controls.xml @@ -98,8 +98,8 @@ android:ellipsize="end" android:gravity="center" android:maxLines="1" - android:paddingStart="24dp" - android:paddingEnd="24dp" + android:paddingStart="16dp" + android:paddingEnd="16dp" android:textAppearance="@style/TextViewBody2" app:layout_constraintBottom_toTopOf="@+id/playerMediaControllerContainer" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout/fragment_fit_playback_controls.xml b/app/src/main/res/layout/fragment_fit_playback_controls.xml index 04d97a37..6cbb778f 100644 --- a/app/src/main/res/layout/fragment_fit_playback_controls.xml +++ b/app/src/main/res/layout/fragment_fit_playback_controls.xml @@ -84,9 +84,9 @@ android:ellipsize="end" android:gravity="center" android:maxLines="1" - android:paddingStart="24dp" - android:paddingTop="12dp" - android:paddingEnd="24dp" + android:paddingStart="16dp" + android:paddingTop="8dp" + android:paddingEnd="16dp" android:textAppearance="@style/TextViewBody2" tools:text="@tools:sample/lorem/random" /> diff --git a/app/src/main/res/layout/fragment_material_playback_controls.xml b/app/src/main/res/layout/fragment_material_playback_controls.xml index 0b8b4b2b..5bddaa46 100644 --- a/app/src/main/res/layout/fragment_material_playback_controls.xml +++ b/app/src/main/res/layout/fragment_material_playback_controls.xml @@ -100,9 +100,8 @@ android:layout_gravity="center" android:ellipsize="end" android:gravity="center" - android:maxLines="1" - android:paddingStart="24dp" - android:paddingEnd="24dp" + android:maxLines="1" android:paddingStart="16dp" + android:paddingEnd="16dp" android:textAppearance="@style/TextViewBody1" app:layout_constraintBottom_toTopOf="@+id/playerMediaControllerContainer" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout/fragment_player_playback_controls.xml b/app/src/main/res/layout/fragment_player_playback_controls.xml index a49e722e..71030278 100755 --- a/app/src/main/res/layout/fragment_player_playback_controls.xml +++ b/app/src/main/res/layout/fragment_player_playback_controls.xml @@ -101,8 +101,8 @@ android:layout_gravity="center" android:ellipsize="end" android:gravity="center" - android:maxLines="1" - android:padding="16dp" + android:maxLines="1" android:paddingStart="16dp" + android:paddingEnd="16dp" android:textAppearance="@style/TextViewBody1" android:textColor="?android:attr/textColorSecondary" app:layout_constraintBottom_toTopOf="@+id/playerMediaControllerContainer" diff --git a/app/src/main/res/layout/fragment_volume.xml b/app/src/main/res/layout/fragment_volume.xml index 2e7e738b..72353973 100755 --- a/app/src/main/res/layout/fragment_volume.xml +++ b/app/src/main/res/layout/fragment_volume.xml @@ -6,7 +6,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:gravity="center_vertical" - android:orientation="horizontal"> + android:orientation="horizontal" + android:paddingBottom="12dp"> @@ -36,7 +38,9 @@ android:layout_height="wrap_content" android:layout_weight="0" android:background="?roundSelector" - android:padding="12dp" + android:paddingStart="12dp" + android:paddingEnd="12dp" + android:paddingBottom="12dp" app:srcCompat="@drawable/ic_volume_up_white_24dp" app:tint="?colorOnBackground" /> \ No newline at end of file diff --git a/app/src/main/res/layout/item_contributor.xml b/app/src/main/res/layout/item_contributor.xml index eaf4a3fc..fab39e15 100644 --- a/app/src/main/res/layout/item_contributor.xml +++ b/app/src/main/res/layout/item_contributor.xml @@ -12,50 +12,54 @@ ~ See the GNU General Public License for more details. --> - - + android:layout_marginStart="16dp" + android:textAppearance="@style/TextViewSubtitle1" + android:textStyle="bold" + app:layout_constrainedWidth="true" + app:layout_constraintBottom_toTopOf="@+id/text" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintHorizontal_bias="0" + app:layout_constraintStart_toEndOf="@+id/icon" + tools:text="@tools:sample/lorem" /> - + - - - \ No newline at end of file + \ No newline at end of file diff --git a/app/src/main/res/layout/item_contributor_header.xml b/app/src/main/res/layout/item_contributor_header.xml index 40964742..d0951196 100644 --- a/app/src/main/res/layout/item_contributor_header.xml +++ b/app/src/main/res/layout/item_contributor_header.xml @@ -24,7 +24,7 @@ tools:ignore="PrivateResource"> - - + app:tint="?colorOnSurface" + tools:srcCompat="@drawable/ic_telegram_white" /> + app:layout_constraintEnd_toStartOf="@android:id/checkbox" + app:layout_constraintStart_toStartOf="@+id/guideline_front_margin" + app:layout_constraintTop_toTopOf="parent" + tools:maxLines="@string/grid_size_1" + tools:text="@tools:sample/lorem" /> + app:layout_constraintEnd_toStartOf="@android:id/checkbox" + app:layout_constraintStart_toStartOf="@+id/guideline_front_margin" + app:layout_constraintTop_toBottomOf="@android:id/title" + app:lineHeightHint="24sp" + tools:maxLines="2" + tools:text="@tools:sample/lorem/random" /> + + \ No newline at end of file diff --git a/app/src/main/res/layout/list_item_view_no_title.xml b/app/src/main/res/layout/list_item_view_no_title.xml new file mode 100644 index 00000000..90eed14e --- /dev/null +++ b/app/src/main/res/layout/list_item_view_no_title.xml @@ -0,0 +1,58 @@ + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/layout/list_item_view_switch.xml b/app/src/main/res/layout/list_item_view_switch.xml new file mode 100644 index 00000000..fb69a2ac --- /dev/null +++ b/app/src/main/res/layout/list_item_view_switch.xml @@ -0,0 +1,81 @@ + + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/layout/list_item_view_switch_no_title.xml b/app/src/main/res/layout/list_item_view_switch_no_title.xml new file mode 100644 index 00000000..79cc406d --- /dev/null +++ b/app/src/main/res/layout/list_item_view_switch_no_title.xml @@ -0,0 +1,68 @@ + + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/xml/pref_advanced.xml b/app/src/main/res/xml/pref_advanced.xml index 67cd0210..bb3f9b98 100755 --- a/app/src/main/res/xml/pref_advanced.xml +++ b/app/src/main/res/xml/pref_advanced.xml @@ -16,6 +16,7 @@ + app:enableCopying="true" + app:icon="@drawable/ic_equalizer_white_24dp" /> + @@ -26,6 +29,7 @@ @@ -42,6 +47,7 @@ @@ -49,6 +55,7 @@ @@ -56,6 +63,7 @@ diff --git a/app/src/main/res/xml/pref_images.xml b/app/src/main/res/xml/pref_images.xml index 6542701d..bc521a66 100755 --- a/app/src/main/res/xml/pref_images.xml +++ b/app/src/main/res/xml/pref_images.xml @@ -4,17 +4,19 @@ + app:enableCopying="true" + app:icon="@drawable/ic_image_white_24dp" /> \ No newline at end of file diff --git a/app/src/main/res/xml/pref_lockscreen.xml b/app/src/main/res/xml/pref_lockscreen.xml index b5dcc1ed..19e6caae 100755 --- a/app/src/main/res/xml/pref_lockscreen.xml +++ b/app/src/main/res/xml/pref_lockscreen.xml @@ -7,6 +7,7 @@ @@ -15,6 +16,7 @@ android:defaultValue="false" android:dependency="album_art_on_lockscreen" android:key="blurred_album_art" + android:layout="@layout/list_item_view_switch" android:summary="@string/pref_summary_blurred_album_art" android:title="@string/pref_title_blurred_album_art" app:enableCopying="true" /> @@ -22,6 +24,7 @@ diff --git a/app/src/main/res/xml/pref_notification.xml b/app/src/main/res/xml/pref_notification.xml index 93aa85a1..c293e2de 100755 --- a/app/src/main/res/xml/pref_notification.xml +++ b/app/src/main/res/xml/pref_notification.xml @@ -4,6 +4,7 @@ diff --git a/app/src/main/res/xml/pref_now_playing_screen.xml b/app/src/main/res/xml/pref_now_playing_screen.xml index 8ab33277..d37cf43c 100644 --- a/app/src/main/res/xml/pref_now_playing_screen.xml +++ b/app/src/main/res/xml/pref_now_playing_screen.xml @@ -4,6 +4,7 @@ @@ -11,8 +12,10 @@ + @@ -22,10 +25,12 @@ android:entries="@array/pref_album_cover_transform_entities" android:entryValues="@array/pref_album_cover_transform_values" android:key="album_cover_transform" + android:layout="@layout/list_item_view" android:title="@string/pref_title_album_cover_transform" app:enableCopying="true" /> + @@ -51,6 +55,7 @@ + android:title="@string/window"> diff --git a/appthemehelper/src/main/java/code/name/monkey/appthemehelper/common/prefs/supportv7/ATEDialogPreference.kt b/appthemehelper/src/main/java/code/name/monkey/appthemehelper/common/prefs/supportv7/ATEDialogPreference.kt index 94365b90..6ef22e0b 100755 --- a/appthemehelper/src/main/java/code/name/monkey/appthemehelper/common/prefs/supportv7/ATEDialogPreference.kt +++ b/appthemehelper/src/main/java/code/name/monkey/appthemehelper/common/prefs/supportv7/ATEDialogPreference.kt @@ -17,7 +17,6 @@ package code.name.monkey.appthemehelper.common.prefs.supportv7 import android.content.Context import android.util.AttributeSet import androidx.preference.DialogPreference -import code.name.monkey.appthemehelper.R open class ATEDialogPreference @JvmOverloads constructor( context: Context, @@ -26,6 +25,6 @@ open class ATEDialogPreference @JvmOverloads constructor( ) : DialogPreference(context, attrs, defStyleAttr, defStyleRes) { init { - layoutResource = R.layout.ate_preference_custom_support + } } \ No newline at end of file diff --git a/appthemehelper/src/main/java/code/name/monkey/appthemehelper/common/prefs/supportv7/ATEPreference.kt b/appthemehelper/src/main/java/code/name/monkey/appthemehelper/common/prefs/supportv7/ATEPreference.kt index de30caa6..7dc47aa2 100755 --- a/appthemehelper/src/main/java/code/name/monkey/appthemehelper/common/prefs/supportv7/ATEPreference.kt +++ b/appthemehelper/src/main/java/code/name/monkey/appthemehelper/common/prefs/supportv7/ATEPreference.kt @@ -18,7 +18,6 @@ import android.content.Context import android.graphics.PorterDuff import android.util.AttributeSet import androidx.preference.Preference -import code.name.monkey.appthemehelper.R import code.name.monkey.appthemehelper.ThemeStore class ATEPreference @JvmOverloads constructor( @@ -29,7 +28,7 @@ class ATEPreference @JvmOverloads constructor( ) : Preference(context, attrs, defStyleAttr, defStyleRes) { init { - layoutResource = R.layout.ate_preference_custom_support + icon?.setColorFilter(ThemeStore.textColorSecondary(context), PorterDuff.Mode.SRC_IN) } } \ No newline at end of file