From df225e179f1c7900f88135c939d75cc9e0c9b1c8 Mon Sep 17 00:00:00 2001 From: Hemanth S Date: Fri, 22 May 2020 16:21:08 +0530 Subject: [PATCH] Code refactor --- .../retromusic/adapter/SongFileAdapter.kt | 15 +++++++++++ .../retromusic/data/RetroDataService.kt | 26 ------------------ .../monkey/retromusic/util/MusicUtil.java | 27 +++++++++++-------- 3 files changed, 31 insertions(+), 37 deletions(-) delete mode 100644 app/src/main/java/code/name/monkey/retromusic/data/RetroDataService.kt diff --git a/app/src/main/java/code/name/monkey/retromusic/adapter/SongFileAdapter.kt b/app/src/main/java/code/name/monkey/retromusic/adapter/SongFileAdapter.kt index 4909ad37..daaba32d 100644 --- a/app/src/main/java/code/name/monkey/retromusic/adapter/SongFileAdapter.kt +++ b/app/src/main/java/code/name/monkey/retromusic/adapter/SongFileAdapter.kt @@ -1,3 +1,18 @@ +/* + * Copyright 2019 Google LLC + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package code.name.monkey.retromusic.adapter import android.graphics.PorterDuff diff --git a/app/src/main/java/code/name/monkey/retromusic/data/RetroDataService.kt b/app/src/main/java/code/name/monkey/retromusic/data/RetroDataService.kt deleted file mode 100644 index cb7cee6d..00000000 --- a/app/src/main/java/code/name/monkey/retromusic/data/RetroDataService.kt +++ /dev/null @@ -1,26 +0,0 @@ -package code.name.monkey.retromusic.data - -import code.name.monkey.retromusic.model.Contributor -import com.google.gson.GsonBuilder -import retrofit2.Retrofit -import retrofit2.converter.gson.GsonConverterFactory -import retrofit2.http.GET - -private const val BASE_URL = "https://github.com/h4h13/RetroMusicPlayer/blob/dev/data/" - -interface RetroDataService { - - @GET("translators.json") - suspend fun getContributors(): List - - @GET("translators.json") - suspend fun getTranslators(): List - - companion object { - val retoService: RetroDataService = Retrofit.Builder() - .baseUrl(BASE_URL) - .addConverterFactory(GsonConverterFactory.create(GsonBuilder().create())) - .build() - .create(RetroDataService::class.java) - } -} diff --git a/app/src/main/java/code/name/monkey/retromusic/util/MusicUtil.java b/app/src/main/java/code/name/monkey/retromusic/util/MusicUtil.java index 5e24f1b7..6f8d4f61 100644 --- a/app/src/main/java/code/name/monkey/retromusic/util/MusicUtil.java +++ b/app/src/main/java/code/name/monkey/retromusic/util/MusicUtil.java @@ -304,19 +304,24 @@ public class MusicUtil { @NonNull public static String getSectionName(@Nullable String musicMediaTitle) { - if (TextUtils.isEmpty(musicMediaTitle)) { + try { + if (TextUtils.isEmpty(musicMediaTitle)) { + return ""; + } + + musicMediaTitle = musicMediaTitle.trim().toLowerCase(); + if (musicMediaTitle.startsWith("the ")) { + musicMediaTitle = musicMediaTitle.substring(4); + } else if (musicMediaTitle.startsWith("a ")) { + musicMediaTitle = musicMediaTitle.substring(2); + } + if (musicMediaTitle.isEmpty()) { + return ""; + } + return musicMediaTitle.substring(0, 1).toUpperCase(); + } catch (Exception e) { return ""; } - musicMediaTitle = musicMediaTitle.trim().toLowerCase(); - if (musicMediaTitle.startsWith("the ")) { - musicMediaTitle = musicMediaTitle.substring(4); - } else if (musicMediaTitle.startsWith("a ")) { - musicMediaTitle = musicMediaTitle.substring(2); - } - if (musicMediaTitle.isEmpty()) { - return ""; - } - return musicMediaTitle.substring(0, 1).toUpperCase(); } @NonNull