From dac7bd16b7366f91e90bb7fd26b5852b5f9ae953 Mon Sep 17 00:00:00 2001 From: h4h13 Date: Mon, 17 Feb 2020 20:38:20 +0530 Subject: [PATCH] Code refactor --- app/build.gradle | 4 +- .../dialogs/OptionsSheetDialogFragment.kt | 6 ++ ...PagerRecyclerViewCustomGridSizeFragment.kt | 1 + .../fragments/mainactivity/AlbumsFragment.kt | 2 +- .../fragments/mainactivity/ArtistsFragment.kt | 2 +- .../fragments/mainactivity/GenresFragment.kt | 2 +- .../mainactivity/LibraryFragment.java | 56 ++++++++++--------- .../mainactivity/PlaylistsFragment.kt | 9 +-- .../fragments/mainactivity/SongsFragment.kt | 2 +- .../normal/PlayerPlaybackControlsFragment.kt | 17 +++++- .../main/res/layout-land/activity_album.xml | 2 +- .../layout-land/activity_artist_details.xml | 2 +- .../fragment_player_playback_controls.xml | 11 ++-- app/src/main/res/layout/activity_album.xml | 2 +- .../res/layout/activity_album_content.xml | 6 +- .../res/layout/activity_artist_content.xml | 9 ++- .../res/layout/activity_artist_details.xml | 2 +- app/src/main/res/layout/fragment_material.xml | 26 ++++----- .../fragment_player_playback_controls.xml | 2 +- .../res/layout/sliding_music_panel_layout.xml | 2 +- 20 files changed, 91 insertions(+), 74 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index b1584cf7..f0171d5a 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -22,8 +22,8 @@ android { vectorDrawables.useSupportLibrary = true applicationId "code.name.monkey.retromusic" - versionCode 405 - versionName '3.4.900' + versionCode 409 + versionName '3.5.000' multiDexEnabled true diff --git a/app/src/main/java/code/name/monkey/retromusic/dialogs/OptionsSheetDialogFragment.kt b/app/src/main/java/code/name/monkey/retromusic/dialogs/OptionsSheetDialogFragment.kt index 18d3a2a9..2467610c 100644 --- a/app/src/main/java/code/name/monkey/retromusic/dialogs/OptionsSheetDialogFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/dialogs/OptionsSheetDialogFragment.kt @@ -22,6 +22,8 @@ import android.view.ViewGroup import androidx.fragment.app.DialogFragment import code.name.monkey.retromusic.R import code.name.monkey.retromusic.activities.MainActivity +import code.name.monkey.retromusic.extensions.hide +import code.name.monkey.retromusic.helper.MusicPlayerRemote import code.name.monkey.retromusic.util.NavigationUtil import code.name.monkey.retromusic.util.PreferenceUtil import code.name.monkey.retromusic.views.OptionMenuItemView @@ -72,6 +74,10 @@ class OptionsSheetDialogFragment : DialogFragment(), View.OnClickListener { actionFolders.setOnClickListener(this) actionDriveMode.setOnClickListener(this) + if (MusicPlayerRemote.playingQueue.isEmpty()) { + actionDriveMode.hide() + } + materialDialog = MaterialDialog(requireActivity(), BottomSheet(LayoutMode.WRAP_CONTENT)) .show { icon(R.mipmap.ic_launcher_round) diff --git a/app/src/main/java/code/name/monkey/retromusic/fragments/base/AbsLibraryPagerRecyclerViewCustomGridSizeFragment.kt b/app/src/main/java/code/name/monkey/retromusic/fragments/base/AbsLibraryPagerRecyclerViewCustomGridSizeFragment.kt index 051f0d3f..8b078163 100644 --- a/app/src/main/java/code/name/monkey/retromusic/fragments/base/AbsLibraryPagerRecyclerViewCustomGridSizeFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/fragments/base/AbsLibraryPagerRecyclerViewCustomGridSizeFragment.kt @@ -34,6 +34,7 @@ abstract class AbsLibraryPagerRecyclerViewCustomGridSizeFragment(), PlaylistView { @Inject @@ -38,13 +37,15 @@ class PlaylistsFragment : AbsLibraryPagerRecyclerViewFragment diff --git a/app/src/main/res/layout-land/activity_artist_details.xml b/app/src/main/res/layout-land/activity_artist_details.xml index 9b5f4916..df20567b 100644 --- a/app/src/main/res/layout-land/activity_artist_details.xml +++ b/app/src/main/res/layout-land/activity_artist_details.xml @@ -90,7 +90,7 @@ android:layout_height="wrap_content" android:maxLines="2" android:textColor="?android:attr/textColorPrimary" - android:textAppearance="@style/TextViewHeadline4" + android:textAppearance="@style/TextViewHeadline5" android:textStyle="bold" tools:ignore="MissingPrefix" tools:text="Title" /> diff --git a/app/src/main/res/layout-xlarge-land/fragment_player_playback_controls.xml b/app/src/main/res/layout-xlarge-land/fragment_player_playback_controls.xml index 7558016c..fd2eea83 100755 --- a/app/src/main/res/layout-xlarge-land/fragment_player_playback_controls.xml +++ b/app/src/main/res/layout-xlarge-land/fragment_player_playback_controls.xml @@ -71,7 +71,6 @@ android:id="@+id/previousButton" android:layout_width="72dp" android:layout_height="72dp" - android:layout_centerVertical="true" android:layout_marginStart="24dp" android:background="?attr/roundSelector" android:padding="16dp" @@ -85,14 +84,13 @@ + tools:listitem="@layout/item_song" /> - - - - - @@ -63,5 +50,18 @@ android:layout_height="match_parent" tools:layout="@layout/fragment_material_playback_controls" /> + + + + + diff --git a/app/src/main/res/layout/fragment_player_playback_controls.xml b/app/src/main/res/layout/fragment_player_playback_controls.xml index 5e011af4..d7d2ab06 100755 --- a/app/src/main/res/layout/fragment_player_playback_controls.xml +++ b/app/src/main/res/layout/fragment_player_playback_controls.xml @@ -162,7 +162,7 @@ app:layout_constraintHorizontal_bias="0.5" app:layout_constraintStart_toEndOf="@+id/previousButton" app:layout_constraintTop_toBottomOf="@+id/songInfo" - app:srcCompat="@drawable/ic_pause_white_64dp" + app:srcCompat="@drawable/ic_pause_white_24dp" tools:tint="@color/md_black_1000" /> - +