From d132dafef5297f1c86c66e68af35d5897f3d1e2c Mon Sep 17 00:00:00 2001 From: h4h13 Date: Mon, 24 Jun 2019 01:44:27 +0530 Subject: [PATCH] Fix layout issues for tablet --- .../activities/AlbumDetailsActivity.kt | 5 +- .../activities/ArtistDetailActivity.kt | 11 +- .../mainactivity/home/BannerHomeFragment.kt | 10 +- .../fragments/player/normal/PlayerFragment.kt | 1 - .../main/res/layout-land/activity_album.xml | 87 +++++++------ .../layout-land/activity_artist_details.xml | 76 ++++++----- .../res/layout-xlarge-land/activity_album.xml | 110 ++++++++-------- .../activity_artist_details.xml | 74 ++++++----- .../fragment_banner_home.xml | 4 +- .../main/res/layout-xlarge/abs_playlists.xml | 5 +- .../main/res/layout-xlarge/activity_album.xml | 118 +++++++++--------- .../layout-xlarge/activity_artist_details.xml | 78 ++++++------ .../layout-xlarge/fragment_banner_home.xml | 6 +- .../main/res/layout-xlarge/fragment_home.xml | 4 +- .../res/layout-xlarge/fragment_player.xml | 13 +- app/src/main/res/layout/activity_album.xml | 90 ++++++------- .../res/layout/activity_artist_details.xml | 70 ++++++----- 17 files changed, 412 insertions(+), 350 deletions(-) diff --git a/app/src/main/java/code/name/monkey/retromusic/activities/AlbumDetailsActivity.kt b/app/src/main/java/code/name/monkey/retromusic/activities/AlbumDetailsActivity.kt index 1835f39f..85d5e379 100644 --- a/app/src/main/java/code/name/monkey/retromusic/activities/AlbumDetailsActivity.kt +++ b/app/src/main/java/code/name/monkey/retromusic/activities/AlbumDetailsActivity.kt @@ -1,6 +1,7 @@ package code.name.monkey.retromusic.activities import android.content.Intent +import android.content.res.ColorStateList import android.graphics.Color import android.os.Bundle import android.transition.Slide @@ -70,7 +71,7 @@ class AlbumDetailsActivity : AbsSlidingMusicPanelActivity(), AlbumDetailsContrac setupWindowTransition() super.onCreate(savedInstanceState) toggleBottomNavigationView(true) - collapsingToolbarLayout?.setBackgroundColor(ThemeStore.primaryColor(this)) + contentContainer?.setCardBackgroundColor( ColorStateList.valueOf(ThemeStore.primaryColor(this))) setLightNavigationBar(true) setNavigationbarColorAuto() @@ -111,7 +112,7 @@ class AlbumDetailsActivity : AbsSlidingMusicPanelActivity(), AlbumDetailsContrac supportActionBar!!.title = null val primaryColor = ThemeStore.primaryColor(this) - TintHelper.setTintAuto(contentContainer!!, primaryColor, true) + //TintHelper.setTintAuto(contentContainer!!, primaryColor, true) if (collapsingToolbarLayout != null) { collapsingToolbarLayout!!.apply { diff --git a/app/src/main/java/code/name/monkey/retromusic/activities/ArtistDetailActivity.kt b/app/src/main/java/code/name/monkey/retromusic/activities/ArtistDetailActivity.kt index 9152abf5..30e88b0a 100755 --- a/app/src/main/java/code/name/monkey/retromusic/activities/ArtistDetailActivity.kt +++ b/app/src/main/java/code/name/monkey/retromusic/activities/ArtistDetailActivity.kt @@ -2,6 +2,7 @@ package code.name.monkey.retromusic.activities import android.app.Activity import android.content.Intent +import android.content.res.ColorStateList import android.graphics.Color import android.graphics.drawable.Drawable import android.os.Build @@ -17,7 +18,10 @@ import androidx.recyclerview.widget.DefaultItemAnimator import androidx.recyclerview.widget.GridLayoutManager import androidx.recyclerview.widget.LinearLayoutManager import code.name.monkey.appthemehelper.ThemeStore -import code.name.monkey.appthemehelper.util.* +import code.name.monkey.appthemehelper.util.ATHUtil +import code.name.monkey.appthemehelper.util.ColorUtil +import code.name.monkey.appthemehelper.util.MaterialUtil +import code.name.monkey.appthemehelper.util.ToolbarContentTintHelper import code.name.monkey.retromusic.R import code.name.monkey.retromusic.activities.base.AbsSlidingMusicPanelActivity import code.name.monkey.retromusic.adapter.album.AlbumAdapter @@ -68,7 +72,8 @@ class ArtistDetailActivity : AbsSlidingMusicPanelActivity(), ArtistDetailContrac setDrawUnderStatusBar() setupWindowTransitions() super.onCreate(savedInstanceState) - collapsingToolbarLayout?.setBackgroundColor(ThemeStore.primaryColor(this)) + //collapsingToolbarLayout?.setBackgroundColor(ThemeStore.primaryColor(this)) + contentContainer?.setCardBackgroundColor(ColorStateList.valueOf(ThemeStore.primaryColor(this))) toggleBottomNavigationView(true) setNavigationbarColorAuto() setLightNavigationBar(true) @@ -114,7 +119,7 @@ class ArtistDetailActivity : AbsSlidingMusicPanelActivity(), ArtistDetailContrac private fun setupToolbarMarginHeight() { val primaryColor = ThemeStore.primaryColor(this) - TintHelper.setTintAuto(contentContainer!!, primaryColor, true) + collapsingToolbarLayout?.let { it.setContentScrimColor(primaryColor) it.setStatusBarScrimColor(ColorUtil.darkenColor(primaryColor)) diff --git a/app/src/main/java/code/name/monkey/retromusic/fragments/mainactivity/home/BannerHomeFragment.kt b/app/src/main/java/code/name/monkey/retromusic/fragments/mainactivity/home/BannerHomeFragment.kt index b6edb294..1622c9b5 100644 --- a/app/src/main/java/code/name/monkey/retromusic/fragments/mainactivity/home/BannerHomeFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/fragments/mainactivity/home/BannerHomeFragment.kt @@ -17,6 +17,7 @@ import code.name.monkey.retromusic.Constants import code.name.monkey.retromusic.Constants.USER_BANNER import code.name.monkey.retromusic.R import code.name.monkey.retromusic.adapter.HomeAdapter +import code.name.monkey.retromusic.extensions.hide import code.name.monkey.retromusic.extensions.show import code.name.monkey.retromusic.fragments.base.AbsMainActivityFragment import code.name.monkey.retromusic.glide.GlideApp @@ -201,16 +202,17 @@ class BannerHomeFragment : AbsMainActivityFragment(), MainActivityFragmentCallba private lateinit var homeAdapter: HomeAdapter override fun showData(list: ArrayList) { - if (list.isEmpty()){ - showEmptyView() - return - } val finalList = list.sortedWith(compareBy { it.priority }) homeAdapter.swapData(finalList) recyclerView.apply { layoutManager = LinearLayoutManager(mainActivity) adapter = homeAdapter } + if (list.isEmpty()) { + showEmptyView() + } else { + emptyContainer.hide() + } } override fun onCreateOptionsMenu(menu: Menu, inflater: MenuInflater) { diff --git a/app/src/main/java/code/name/monkey/retromusic/fragments/player/normal/PlayerFragment.kt b/app/src/main/java/code/name/monkey/retromusic/fragments/player/normal/PlayerFragment.kt index dfea11f7..f0eb0203 100644 --- a/app/src/main/java/code/name/monkey/retromusic/fragments/player/normal/PlayerFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/fragments/player/normal/PlayerFragment.kt @@ -101,7 +101,6 @@ class PlayerFragment : AbsPlayerFragment(), PlayerAlbumCoverFragment.Callbacks { super.onViewCreated(view, savedInstanceState) setUpSubFragments() setUpPlayerToolbar() - snowfall.visibility = if (PreferenceUtil.getInstance().isSnowFall) View.VISIBLE else View.GONE //val display = activity?.windowManager?.defaultDisplay diff --git a/app/src/main/res/layout-land/activity_album.xml b/app/src/main/res/layout-land/activity_album.xml index b675249d..7a0cd264 100644 --- a/app/src/main/res/layout-land/activity_album.xml +++ b/app/src/main/res/layout-land/activity_album.xml @@ -30,70 +30,77 @@ - + app:cardCornerRadius="16dp" + app:cardElevation="0dp"> - - + android:orientation="vertical"> + android:gravity="center_vertical" + android:orientation="horizontal"> - + + + android:layout_gravity="bottom" + android:layout_weight="1" + android:orientation="vertical" + android:padding="16dp"> - + + + + + + - - - + diff --git a/app/src/main/res/layout-land/activity_artist_details.xml b/app/src/main/res/layout-land/activity_artist_details.xml index 3f6d44be..c1fec3fe 100644 --- a/app/src/main/res/layout-land/activity_artist_details.xml +++ b/app/src/main/res/layout-land/activity_artist_details.xml @@ -1,5 +1,6 @@ - + app:cardCornerRadius="16dp" + app:cardElevation="0dp"> + android:orientation="vertical"> - + android:orientation="vertical" + android:padding="16dp"> - + + + + + + - + + - - - - + diff --git a/app/src/main/res/layout-xlarge-land/activity_album.xml b/app/src/main/res/layout-xlarge-land/activity_album.xml index 43dbcaa9..bf0fd9e2 100644 --- a/app/src/main/res/layout-xlarge-land/activity_album.xml +++ b/app/src/main/res/layout-xlarge-land/activity_album.xml @@ -41,7 +41,6 @@ - + app:cardCornerRadius="16dp" + app:cardElevation="0dp"> - - - - - - - - + android:orientation="vertical"> + android:orientation="horizontal"> - + + + + + + + + + android:layout_weight="1" + android:orientation="vertical" + android:padding="16dp"> - + + + + + + - - - - + - - + android:layout_height="wrap_content" + app:cardCornerRadius="16dp" + app:cardElevation="0dp"> + android:layout_height="match_parent" + android:orientation="vertical"> - + android:orientation="vertical" + android:padding="24dp"> - + + + + + + + - - - - + diff --git a/app/src/main/res/layout-xlarge-land/fragment_banner_home.xml b/app/src/main/res/layout-xlarge-land/fragment_banner_home.xml index 486b4c97..89d6a690 100644 --- a/app/src/main/res/layout-xlarge-land/fragment_banner_home.xml +++ b/app/src/main/res/layout-xlarge-land/fragment_banner_home.xml @@ -30,7 +30,7 @@ diff --git a/app/src/main/res/layout-xlarge/abs_playlists.xml b/app/src/main/res/layout-xlarge/abs_playlists.xml index ddd3129f..1a499e09 100644 --- a/app/src/main/res/layout-xlarge/abs_playlists.xml +++ b/app/src/main/res/layout-xlarge/abs_playlists.xml @@ -13,10 +13,7 @@ android:layout_gravity="center_vertical" android:gravity="center_vertical" android:orientation="horizontal" - android:paddingStart="24dp" - android:paddingTop="10dp" - android:paddingEnd="24dp" - android:paddingBottom="10dp"> + android:padding="24dp"> - + android:layout_height="wrap_content" + app:cardCornerRadius="16dp" + app:cardElevation="0dp"> - - - - - - - - + android:layout_height="match_parent" + android:orientation="vertical"> + android:baselineAligned="false" + android:orientation="horizontal"> - + + + + + + + + + android:layout_weight="1" + android:orientation="vertical" + android:paddingStart="16dp" + android:paddingEnd="16dp"> - + + + + + + - - - - + - - + android:layout_height="wrap_content" + app:cardCornerRadius="16dp" + app:cardElevation="0dp"> + tools:background="@color/md_red_500"> - + android:orientation="vertical" + android:padding="12dp"> - + + + + + + + + - - - - - + diff --git a/app/src/main/res/layout-xlarge/fragment_banner_home.xml b/app/src/main/res/layout-xlarge/fragment_banner_home.xml index ec497cca..5e194f47 100644 --- a/app/src/main/res/layout-xlarge/fragment_banner_home.xml +++ b/app/src/main/res/layout-xlarge/fragment_banner_home.xml @@ -30,7 +30,7 @@ diff --git a/app/src/main/res/layout-xlarge/fragment_home.xml b/app/src/main/res/layout-xlarge/fragment_home.xml index 5f3df993..0368f661 100644 --- a/app/src/main/res/layout-xlarge/fragment_home.xml +++ b/app/src/main/res/layout-xlarge/fragment_home.xml @@ -32,10 +32,10 @@ android:id="@+id/toolbarContainer" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginStart="64dp" + android:layout_marginEnd="64dp" app:cardCornerRadius="8dp" app:cardElevation="0dp" - android:layout_marginEnd="8dp" - android:layout_marginStart="8dp" app:cardUseCompatPadding="true" app:layout_scrollFlags="scroll|enterAlways" app:strokeColor="?dividerColor" diff --git a/app/src/main/res/layout-xlarge/fragment_player.xml b/app/src/main/res/layout-xlarge/fragment_player.xml index 7d0fa653..c919d1ef 100644 --- a/app/src/main/res/layout-xlarge/fragment_player.xml +++ b/app/src/main/res/layout-xlarge/fragment_player.xml @@ -11,10 +11,7 @@ android:id="@+id/colorGradientBackground" android:layout_width="match_parent" android:layout_height="match_parent" /> - + + + + + + app:navigationIcon="@drawable/ic_keyboard_arrow_down_black_24dp" /> diff --git a/app/src/main/res/layout/activity_album.xml b/app/src/main/res/layout/activity_album.xml index d4749c39..da066f7d 100755 --- a/app/src/main/res/layout/activity_album.xml +++ b/app/src/main/res/layout/activity_album.xml @@ -46,69 +46,75 @@ - + app:cardCornerRadius="16dp" + app:cardElevation="0dp"> - - + android:orientation="vertical"> + android:orientation="horizontal" + android:padding="12dp"> - + + + android:layout_weight="1" + android:orientation="vertical" + android:paddingStart="16dp" + android:paddingEnd="0dp"> - + + + + + + + - - - - + \ No newline at end of file diff --git a/app/src/main/res/layout/activity_artist_details.xml b/app/src/main/res/layout/activity_artist_details.xml index 98597a92..8a8c57a4 100755 --- a/app/src/main/res/layout/activity_artist_details.xml +++ b/app/src/main/res/layout/activity_artist_details.xml @@ -47,54 +47,60 @@ - + app:cardCornerRadius="16dp" + app:cardElevation="0dp"> + android:orientation="vertical"> - + android:orientation="vertical" + android:padding="16dp"> + + + + + + + + - - - - - - +