From a5afb189291e283d4cec50e05ef6933f6c1c19d3 Mon Sep 17 00:00:00 2001 From: hemanthStack Date: Thu, 10 Oct 2019 19:32:24 +0530 Subject: [PATCH] fix big screen --- .../mainactivity/home/BannerHomeFragment.kt | 2 -- .../main/res/layout-land/fragment_banner_home.xml | 8 ++++---- app/src/main/res/layout-land/fragment_home.xml | 2 ++ .../main/res/layout-xlarge-land/activity_album.xml | 8 +++++--- .../layout-xlarge-land/activity_artist_details.xml | 4 +++- .../res/layout-xlarge-land/fragment_banner_home.xml | 8 +++----- .../main/res/layout-xlarge-land/fragment_home.xml | 2 ++ .../fragment_player_playback_controls.xml | 4 +++- .../main/res/layout-xlarge/fragment_banner_home.xml | 13 ++++++------- app/src/main/res/layout-xlarge/fragment_home.xml | 5 ++--- app/src/main/res/layout/abs_playlists.xml | 1 + app/src/main/res/layout/fragment_banner_home.xml | 2 +- app/src/main/res/layout/fragment_home.xml | 1 + app/src/main/res/layout/home_content.xml | 2 +- app/src/main/res/layout/item_song.xml | 1 + app/src/main/res/values-xlarge/dimens.xml | 2 +- 16 files changed, 36 insertions(+), 29 deletions(-) diff --git a/app/src/main/java/code/name/monkey/retromusic/fragments/mainactivity/home/BannerHomeFragment.kt b/app/src/main/java/code/name/monkey/retromusic/fragments/mainactivity/home/BannerHomeFragment.kt index e19da7c0..7c4078aa 100644 --- a/app/src/main/java/code/name/monkey/retromusic/fragments/mainactivity/home/BannerHomeFragment.kt +++ b/app/src/main/java/code/name/monkey/retromusic/fragments/mainactivity/home/BannerHomeFragment.kt @@ -126,8 +126,6 @@ class BannerHomeFragment : AbsMainActivityFragment(), MainActivityFragmentCallba NavigationUtil.goToPlaylistNew(requireActivity(), HistoryPlaylist(requireActivity())) } - contentContainer.setBackgroundColor(ATHUtil.resolveColor(requireContext(), R.attr.colorPrimary)) - setupToolbar() checkPadding() diff --git a/app/src/main/res/layout-land/fragment_banner_home.xml b/app/src/main/res/layout-land/fragment_banner_home.xml index b1c66473..71d97ae7 100644 --- a/app/src/main/res/layout-land/fragment_banner_home.xml +++ b/app/src/main/res/layout-land/fragment_banner_home.xml @@ -74,9 +74,9 @@ android:id="@+id/toolbarContainer" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginStart="58dp" + android:layout_marginStart="@dimen/toolbar_margin_horizontal" android:layout_marginTop="@dimen/toolbar_margin_vertical" - android:layout_marginEnd="58dp" + android:layout_marginEnd="@dimen/toolbar_margin_horizontal" android:layout_marginBottom="@dimen/toolbar_margin_vertical" app:cardCornerRadius="8dp" app:cardElevation="6dp" @@ -105,8 +105,8 @@ diff --git a/app/src/main/res/layout-land/fragment_home.xml b/app/src/main/res/layout-land/fragment_home.xml index 7c4f57a9..f6424ce4 100644 --- a/app/src/main/res/layout-land/fragment_home.xml +++ b/app/src/main/res/layout-land/fragment_home.xml @@ -71,6 +71,8 @@ diff --git a/app/src/main/res/layout-xlarge-land/activity_album.xml b/app/src/main/res/layout-xlarge-land/activity_album.xml index 6ef65179..9652184c 100644 --- a/app/src/main/res/layout-xlarge-land/activity_album.xml +++ b/app/src/main/res/layout-xlarge-land/activity_album.xml @@ -19,10 +19,11 @@ android:id="@+id/appBarLayout" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="@android:color/transparent"> + android:background="@android:color/transparent" + android:elevation="0dp" + app:elevation="0dp"> + app:cardElevation="0dp" + app:cardPreventCornerOverlap="true"> + android:background="@android:color/transparent" + android:elevation="0dp" + app:elevation="0dp"> + app:liftOnScroll="true"> diff --git a/app/src/main/res/layout-xlarge-land/fragment_home.xml b/app/src/main/res/layout-xlarge-land/fragment_home.xml index eb2fc24b..9ffea6e3 100644 --- a/app/src/main/res/layout-xlarge-land/fragment_home.xml +++ b/app/src/main/res/layout-xlarge-land/fragment_home.xml @@ -71,6 +71,8 @@ diff --git a/app/src/main/res/layout-xlarge-land/fragment_player_playback_controls.xml b/app/src/main/res/layout-xlarge-land/fragment_player_playback_controls.xml index dc12b49c..6a470047 100755 --- a/app/src/main/res/layout-xlarge-land/fragment_player_playback_controls.xml +++ b/app/src/main/res/layout-xlarge-land/fragment_player_playback_controls.xml @@ -71,6 +71,7 @@ android:layout_width="96dp" android:layout_height="96dp" android:layout_centerInParent="true" + android:layout_marginStart="8dp" android:layout_marginTop="8dp" android:background="@drawable/color_circle_gradient" android:elevation="4dp" @@ -78,7 +79,8 @@ app:layout_constraintBottom_toTopOf="@+id/volumeFragmentContainer" app:layout_constraintStart_toEndOf="@id/previousButton" app:layout_constraintTop_toBottomOf="@+id/text" - app:srcCompat="@drawable/ic_play_arrow_white_32dp" /> + app:srcCompat="@drawable/ic_play_arrow_white_32dp" + tools:tint="@color/md_black_1000" /> + android:layout_height="match_parent" + android:background="?colorPrimary"> + app:liftOnScroll="true"> diff --git a/app/src/main/res/layout-xlarge/fragment_home.xml b/app/src/main/res/layout-xlarge/fragment_home.xml index dbffe743..96500119 100644 --- a/app/src/main/res/layout-xlarge/fragment_home.xml +++ b/app/src/main/res/layout-xlarge/fragment_home.xml @@ -72,10 +72,9 @@ diff --git a/app/src/main/res/layout/abs_playlists.xml b/app/src/main/res/layout/abs_playlists.xml index eaf6901a..f50e617c 100644 --- a/app/src/main/res/layout/abs_playlists.xml +++ b/app/src/main/res/layout/abs_playlists.xml @@ -51,6 +51,7 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginTop="24dp" + app:layout_constraintHorizontal_chainStyle="spread_inside" app:layout_constraintEnd_toStartOf="@+id/lastAdded" app:layout_constraintHorizontal_bias="0.5" app:layout_constraintStart_toStartOf="parent" diff --git a/app/src/main/res/layout/fragment_banner_home.xml b/app/src/main/res/layout/fragment_banner_home.xml index 68e6c414..c3b7d1ef 100644 --- a/app/src/main/res/layout/fragment_banner_home.xml +++ b/app/src/main/res/layout/fragment_banner_home.xml @@ -16,7 +16,7 @@ xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" - android:layout_height="match_parent"> + android:layout_height="match_parent" > diff --git a/app/src/main/res/layout/home_content.xml b/app/src/main/res/layout/home_content.xml index 7b0920a5..0395b678 100644 --- a/app/src/main/res/layout/home_content.xml +++ b/app/src/main/res/layout/home_content.xml @@ -18,7 +18,7 @@ \ No newline at end of file diff --git a/app/src/main/res/values-xlarge/dimens.xml b/app/src/main/res/values-xlarge/dimens.xml index 9bf91381..cecf6e52 100644 --- a/app/src/main/res/values-xlarge/dimens.xml +++ b/app/src/main/res/values-xlarge/dimens.xml @@ -1,5 +1,5 @@ - 128dp + 64dp 64dp 16dp 64dp