From 8789eeb8548c8651a5209a10649e8bb68aec1142 Mon Sep 17 00:00:00 2001 From: h4h13 Date: Wed, 31 Jul 2019 17:26:46 +0530 Subject: [PATCH] Improved bug report screen --- app/build.gradle | 4 +- app/src/main/assets/retro-changelog.html | 2 +- .../retromusic/activities/AboutActivity.kt | 3 +- .../activities/bugreport/BugReportActivity.kt | 11 +- .../tageditor/SongTagEditorActivity.kt | 1 - .../retromusic/util/NavigationUtil.java | 5 + .../main/res/layout/activity_bug_report.xml | 1 - .../layout/bug_report_card_device_info.xml | 15 +- .../res/layout/bug_report_card_report.xml | 314 +++++++++--------- app/src/main/res/layout/card_retro_info.xml | 44 +++ 10 files changed, 224 insertions(+), 176 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 7f5edd14..7322c109 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -13,8 +13,8 @@ android { vectorDrawables.useSupportLibrary = true applicationId "code.name.monkey.retromusic" - versionCode 345 - versionName '3.2.220' + versionCode 346 + versionName '3.2.240' multiDexEnabled true diff --git a/app/src/main/assets/retro-changelog.html b/app/src/main/assets/retro-changelog.html index 22f909aa..5a48d106 100644 --- a/app/src/main/assets/retro-changelog.html +++ b/app/src/main/assets/retro-changelog.html @@ -1 +1 @@ -

v3.2.220

v3.2.203

v3.2.135

v3.2.125

v3.2.120

v3.2.105

v3.2.100

v3.2.000

v3.1.900

v3.1.850

v3.1.800

v3.1.700

v3.1.400

v3.1.300

v3.1.240

v3.1.200

v3.0.570

If you see entire app white or dark or black select same theme in settings to fix

FAQ's

*If you face any UI related issues you clear app data and cache, if its not working try to uninstall and install again.

\ No newline at end of file +

v3.2.240

v3.2.220

v3.2.203

v3.2.135

v3.2.125

v3.2.120

v3.2.105

v3.2.100

v3.2.000

v3.1.900

v3.1.850

v3.1.800

v3.1.700

v3.1.400

v3.1.300

v3.1.240

v3.1.200

v3.0.570

If you see entire app white or dark or black select same theme in settings to fix

FAQ's

*If you face any UI related issues you clear app data and cache, if its not working try to uninstall and install again.

\ No newline at end of file diff --git a/app/src/main/java/code/name/monkey/retromusic/activities/AboutActivity.kt b/app/src/main/java/code/name/monkey/retromusic/activities/AboutActivity.kt index b6fbb822..ce313874 100644 --- a/app/src/main/java/code/name/monkey/retromusic/activities/AboutActivity.kt +++ b/app/src/main/java/code/name/monkey/retromusic/activities/AboutActivity.kt @@ -71,7 +71,6 @@ class AboutActivity : AbsBaseActivity(), View.OnClickListener { appVersion.text = getAppVersion() setUpView() - } @@ -110,6 +109,7 @@ class AboutActivity : AbsBaseActivity(), View.OnClickListener { changelog.setOnClickListener(this) openSource.setOnClickListener(this) pinterestLink.setOnClickListener(this) + bugReportLink.setOnClickListener(this) } override fun onClick(view: View) { @@ -126,6 +126,7 @@ class AboutActivity : AbsBaseActivity(), View.OnClickListener { R.id.twitterLink -> openUrl(APP_TWITTER_LINK) R.id.changelog -> showChangeLogOptions() R.id.openSource -> NavigationUtil.goToOpenSource(this) + R.id.bugReportLink -> NavigationUtil.bugReport(this) } } diff --git a/app/src/main/java/code/name/monkey/retromusic/activities/bugreport/BugReportActivity.kt b/app/src/main/java/code/name/monkey/retromusic/activities/bugreport/BugReportActivity.kt index 98a3d4ed..c7f28c40 100644 --- a/app/src/main/java/code/name/monkey/retromusic/activities/bugreport/BugReportActivity.kt +++ b/app/src/main/java/code/name/monkey/retromusic/activities/bugreport/BugReportActivity.kt @@ -16,15 +16,16 @@ import androidx.annotation.StringDef import androidx.annotation.StringRes import androidx.appcompat.app.AlertDialog import code.name.monkey.appthemehelper.ThemeStore +import code.name.monkey.appthemehelper.util.MaterialUtil import code.name.monkey.appthemehelper.util.TintHelper import code.name.monkey.retromusic.R -import code.name.monkey.retromusic.misc.DialogAsyncTask import code.name.monkey.retromusic.activities.base.AbsThemeActivity import code.name.monkey.retromusic.activities.bugreport.model.DeviceInfo import code.name.monkey.retromusic.activities.bugreport.model.Report import code.name.monkey.retromusic.activities.bugreport.model.github.ExtraInfo import code.name.monkey.retromusic.activities.bugreport.model.github.GithubLogin import code.name.monkey.retromusic.activities.bugreport.model.github.GithubTarget +import code.name.monkey.retromusic.misc.DialogAsyncTask import com.afollestad.materialdialogs.MaterialDialog import com.afollestad.materialdialogs.callbacks.onCancel import com.google.android.material.floatingactionbutton.FloatingActionButton @@ -125,10 +126,10 @@ open class BugReportActivity : AbsThemeActivity() { TintHelper.setTintAuto(sendFab!!, accentColor, true) sendFab!!.setOnClickListener { reportIssue() } - TintHelper.setTintAuto(inputTitle!!, accentColor, false) - TintHelper.setTintAuto(inputDescription!!, accentColor, false) - TintHelper.setTintAuto(inputUsername!!, accentColor, false) - TintHelper.setTintAuto(inputPassword!!, accentColor, false) + MaterialUtil.setTint(inputLayoutTitle, false) + MaterialUtil.setTint(inputLayoutDescription, false) + MaterialUtil.setTint(inputLayoutUsername, false) + MaterialUtil.setTint(inputLayoutPassword, false) } private fun reportIssue() { diff --git a/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/SongTagEditorActivity.kt b/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/SongTagEditorActivity.kt index ed909898..b43ffc2e 100755 --- a/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/SongTagEditorActivity.kt +++ b/app/src/main/java/code/name/monkey/retromusic/activities/tageditor/SongTagEditorActivity.kt @@ -45,7 +45,6 @@ class SongTagEditorActivity : AbsTagEditorActivity(), TextWatcher { private fun setUpViews() { fillViewsWithFileTags() MaterialUtil.setTint(songTextContainer, false) - MaterialUtil.setTint(composerContainer, false) MaterialUtil.setTint(albumTextContainer, false) MaterialUtil.setTint(artistContainer, false) diff --git a/app/src/main/java/code/name/monkey/retromusic/util/NavigationUtil.java b/app/src/main/java/code/name/monkey/retromusic/util/NavigationUtil.java index 956865ab..c567f146 100755 --- a/app/src/main/java/code/name/monkey/retromusic/util/NavigationUtil.java +++ b/app/src/main/java/code/name/monkey/retromusic/util/NavigationUtil.java @@ -42,6 +42,7 @@ import code.name.monkey.retromusic.activities.SettingsActivity; import code.name.monkey.retromusic.activities.SupportDevelopmentActivity; import code.name.monkey.retromusic.activities.UserInfoActivity; import code.name.monkey.retromusic.activities.WhatsNewActivity; +import code.name.monkey.retromusic.activities.bugreport.BugReportActivity; import code.name.monkey.retromusic.helper.MusicPlayerRemote; import code.name.monkey.retromusic.model.Genre; import code.name.monkey.retromusic.model.Playlist; @@ -166,4 +167,8 @@ public class NavigationUtil { public static void gotoWhatNews(@NonNull Activity activity) { ActivityCompat.startActivity(activity, new Intent(activity, WhatsNewActivity.class), null); } + + public static void bugReport(@NonNull Activity activity) { + ActivityCompat.startActivity(activity, new Intent(activity, BugReportActivity.class), null); + } } diff --git a/app/src/main/res/layout/activity_bug_report.xml b/app/src/main/res/layout/activity_bug_report.xml index bb0696ca..cb83b507 100644 --- a/app/src/main/res/layout/activity_bug_report.xml +++ b/app/src/main/res/layout/activity_bug_report.xml @@ -62,5 +62,4 @@ app:srcCompat="@drawable/ic_send_white_24dp" /> - \ No newline at end of file diff --git a/app/src/main/res/layout/bug_report_card_device_info.xml b/app/src/main/res/layout/bug_report_card_device_info.xml index 3649c915..4fe23451 100644 --- a/app/src/main/res/layout/bug_report_card_device_info.xml +++ b/app/src/main/res/layout/bug_report_card_device_info.xml @@ -1,6 +1,7 @@ - + android:textAppearance="@style/TextAppearance.MaterialComponents.Overline" /> - + android:textAppearance="@style/TextAppearance.MaterialComponents.Body1" + android:textColor="?android:textColorSecondary" + tools:text="@string/donate_summary" /> - diff --git a/app/src/main/res/layout/bug_report_card_report.xml b/app/src/main/res/layout/bug_report_card_report.xml index 6020c1e1..cffda7d2 100644 --- a/app/src/main/res/layout/bug_report_card_report.xml +++ b/app/src/main/res/layout/bug_report_card_report.xml @@ -1,191 +1,189 @@ - + android:layout_height="match_parent" + android:layout_marginTop="8dp" + android:layout_marginBottom="8dp" + android:orientation="vertical"> - + android:layout_height="wrap_content" + android:gravity="center_vertical" + android:minHeight="@dimen/md_listitem_height" + android:orientation="horizontal" + android:paddingLeft="16dp" + android:paddingRight="16dp"> - - - - - - - - - - - - + android:checked="true" + android:gravity="start|center_vertical" + android:minHeight="@dimen/md_listitem_height" /> + android:paddingTop="8dp" + android:paddingBottom="8dp"> + android:lineSpacingExtra="8dp" + android:text="@string/bug_report_use_account" + android:textAppearance="@style/TextAppearance.MaterialComponents.Subtitle1" /> - - - - - - - - - - - - - - - - - - - - - - - - - - + android:lineSpacingExtra="8dp" + android:text="@string/your_account_data_is_only_used_for_authentication" + android:textAppearance="@style/TextAppearance.MaterialComponents.Caption" /> - + + + + + android:paddingTop="8dp" + android:paddingBottom="8dp" + android:text="@string/bug_report_issue" + android:textAppearance="@style/TextAppearance.AppCompat.Body2" + android:textColor="?android:textColorSecondary" /> - + + + android:hint="@string/title" + android:inputType="textCapSentences" + android:singleLine="true" /> - + + + + + android:gravity="top" + android:hint="@string/description" + android:inputType="textMultiLine" + android:minLines="3" /> - + - - + - + + + + + + + + + + + - \ No newline at end of file + + + + + + + + + + + + \ No newline at end of file diff --git a/app/src/main/res/layout/card_retro_info.xml b/app/src/main/res/layout/card_retro_info.xml index fa4eebaa..43708bbc 100644 --- a/app/src/main/res/layout/card_retro_info.xml +++ b/app/src/main/res/layout/card_retro_info.xml @@ -199,6 +199,50 @@ + + + + + + + + + + + +