nyancrimew/PlayerAndroid
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix crashing when empty strings

Browse source
This commit is contained in:
h4h13 2019-05-08 14:42:31 +05:30
parent 0ffab0c9fb
commit 5a36491ad2
1 changed files with 10 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
app/src/main/java/code/name/monkey/retromusic/util/MusicUtil.java
View file

@ -29,10 +29,6 @@ import android.text.TextUtils;
import android.util.Log; import android.util.Log;
import android.widget.Toast; import android.widget.Toast;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.core.content.FileProvider;
import org.jaudiotagger.audio.AudioFileIO; import org.jaudiotagger.audio.AudioFileIO;
import org.jaudiotagger.tag.FieldKey; import org.jaudiotagger.tag.FieldKey;
@ -43,6 +39,9 @@ import java.util.List;
import java.util.Locale; import java.util.Locale;
import java.util.regex.Pattern; import java.util.regex.Pattern;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.core.content.FileProvider;
import code.name.monkey.retromusic.R; import code.name.monkey.retromusic.R;
import code.name.monkey.retromusic.helper.MusicPlayerRemote; import code.name.monkey.retromusic.helper.MusicPlayerRemote;
import code.name.monkey.retromusic.loaders.PlaylistLoader; import code.name.monkey.retromusic.loaders.PlaylistLoader;
@ -99,22 +98,15 @@ public class MusicUtil {
* Ex: for a given album --> buildInfoString(album.artist, album.songCount) * Ex: for a given album --> buildInfoString(album.artist, album.songCount)
*/ */
public static String buildInfoString(@NonNull final String string1, @NonNull final String string2) { public static String buildInfoString(@NonNull final String string1, @NonNull final String string2) {
// Skip empty strings if (TextUtils.isEmpty(string1)) {
if (string1.isEmpty()) { //noinspection ConstantConditions
return string2; return TextUtils.isEmpty(string2) ? "" : string2;
} }
if (string2.isEmpty()) { if (TextUtils.isEmpty(string2)) {
return string1; //noinspection ConstantConditions
return TextUtils.isEmpty(string1) ? "" : string1;
} }
return string1 + " • " + string2;
final String separator = " • ";
final StringBuilder builder = new StringBuilder();
builder.append(string1);
builder.append(separator);
builder.append(string2);
return builder.toString();
} }
@NonNull @NonNull