From 448d5b6345fb5abba73bb94c463bb8fa4ae2ef10 Mon Sep 17 00:00:00 2001
From: h4h13 <hemanths@live.com>
Date: Thu, 10 Oct 2019 22:37:05 +0530
Subject: [PATCH] Refactor

---
 app/src/main/assets/retro-changelog.html         | 2 +-
 app/src/main/res/layout/fragment_banner_home.xml | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/app/src/main/assets/retro-changelog.html b/app/src/main/assets/retro-changelog.html
index 7e1c2dc4..1651aa45 100644
--- a/app/src/main/assets/retro-changelog.html
+++ b/app/src/main/assets/retro-changelog.html
@@ -1 +1 @@
-<html><head>    <style type="text/css">        * {        word-wrap: break-word;        }        {style-placeholder}        a {        color: {link-color};        }        a:active {        color: {link-color-active};        }        ol {        list-style-position: inside;        padding-left: 0;        padding-right: 0;        }        li {        padding-top: 8px;        }    </style></head><body><h4>v3.4.000</h4><ul>    <li>Added app rating dialog</li>    <li>Fix remaining time in playing queue</li>    <li>Fix font not applied for some components</li>    <li>Fix crashing on album details sorting</li>    <li>Fixed lot of internal bugs</li>    <li>Fix dialog expand</li>    <li>Removed SlidingUpPanel to replace with BottomSheet</li>    <li>Removed color theme as per material design guidelines</li>    <li>Removed classic theme(We're bringing back)</li>    <li>Removed artist loading from Deezer because it's not official to use(will come back with        official)    </li>    <li>Replace line switch to Material Switch in settings</li>    <li>Performance improved</li>    <li>Updated internal libraries</li>    <li>Updated translation</li>    <li>Limiting the use of Theme engine for making use of system colors</li>    <li>Change home icon from user icon</li>    <li>Corrected all toolbar with elevation when scroll</li></ul><h4>v3.3.200</h4><ul>    <li>Fix fullscreen bottom tabs icons squash</li>    <li>Improved tiny theme colors</li>    <li>Android auto support</li>    <li>New notification icon</li>    <li>Favorite icon in mini player</li></ul><h4>v.3.3.100</h4><ul>    <li>Improved Now playing controls alignment</li>    <li>Lot internal changes to improve performance</li>    <li>Fix playlist adding crash</li>    <li>Fix color corrections</li>    <li>Fix file editing crash</li></ul><h4>v3.3.000</h4><ul>    <li>SD card support for deleting and editing</li></ul><h4>v3.2.240</h4><ul>    <li>Improved options dialog with selected color and title icon</li>    <li>Fix dialog color on dark theme</li></ul><h4>v3.2.220</h4><ul>    <li>Fix Notification SeekBar position (Need Android Q test)</li>    <li>Rolled back settings tint icons</li>    <li>Changed preference category title style according Android Q</li>    <li>Fix tabs options not working</li></ul><h4>v3.2.203</h4><ul>    <li>Carousel effect improved</li>    <li>Settings icons are now tint accent color</li>    <li>Settings title, back arrow and icons are now tint accent color</li>    <li>Equalizer is removed</li>    <li>Fix keyboard not popping on Search</li>    <li>Curated the main options</li>    <li>Folder toolbar outlined, folder icon background fix and separate line removed</li>    <li>Edit text input handles are colored</li></ul><h4>v3.2.135</h4><ul>    <li>Fix crashing on sharing song</li></ul><h4>v3.2.125</h4><ul>    <li>Fix crashing on selecting profile picture</li>    <li>Semi transparent color fix(s) on now playing themes</li></ul><h4>v3.2.120</h4><ul>    <li>Fix crashing on choosing a theme</li>    <li>Fix color theme selection without pro enabled</li>    <li>Fix icon tint some places</li></ul><h4>v3.2.105</h4><ul>    <li>Fix color notifications</li></ul><h4>v3.2.100</h4><ul>    <li>Fix crashing on Sleep timer</li>    <li>Toolbar elevation removed added stroke instead</li>    <li>Show empty indication for home</li></ul><h4>v3.2.000</h4><ul>    <li>Implemented Artist image loading all thanks to <a            href="https://github.com/AdrienPoupa/VinylMusicPlayer"> VinylMusicPlayer</a></li>    <li>Fixed buttons in Genre details</li>    <li>Fixed color buttons in Album and Artist details screen</li></ul><h4>v3.1.900</h4><ul>    <li>Added Play and Shuffle buttons on Songs list, Album Details, Artist Details, Playlist        Details etc.    </li>    <li>Home toolbar is semi transparent in Banner mode</li>    <li>Added new Buy Retro Music pro in settings</li>    <li>Improved dark color in Dark theme</li></ul><h4>v3.1.850</h4><ul>    <li>Toolbar will be clickable for Search</li></ul><h4>v3.1.800</h4><ul>    <li>Search bar CardView background</li>    <li>Improve volume zero</li>    <li>Now playing and Album theme picker rollback to dialog</li>    <li>Fix sharing app link</li>    <li>Fix scanning dialog</li>    <li>Added settings icons for options</li></ul><h4>v3.1.700</h4><ul>    <li>Cleaned internal code</li>    <li>Removed full screen option</li>    <li>Added Toolbar elevation</li>    <li>To access menu either tap on Toolbar or Hamburger icon</li>    <li>Fix back button not working on playing queue</li>    <li>Fix crashing on What's New screen</li>    <li>Fix lyrics dialog</li>    <li>Changed toggles to line icons</li>    <li>Fix crashing on artist list for number format error</li>    <li>Fix blacklist dialog crashing</li>    <li>Rearranged icons and main menu access</li>    <li>Fix some crashes when device is locked or background</li>    <li>Folder screen have main options access</li>    <li>Dialogs are now using Material Dialogs v3(BottomSheet)</li>    <li>Fix Shuffle icon for Artist, Album, Genre and Playlist details</li></ul><h4>v3.1.400</h4><ul>    <li>Removed sync lyrics for Android 5</li>    <li>Fix Seek-bar color in settings</li>    <li>Added keyboard to popup on search</li>    <li>Added keyboard to popup on search</li>    <li>Improved lock-screen behavior and UI</li>    <li>Improved text appearance</li>    <li>Fix bio text not showing in settings</li>    <li>Fix not showing slider(blur, filter song) amount in settings</li>    <li>Fix setting ringtone</li>    <li>Fix file sharing crash</li>    <li>Fix some crashes</li>    <li>Fix playlist icon on small devices</li>    <li>Fix empty lyrics text color</li>    <li>Fix album cover background purple color in color theme</li></ul><h4>v3.1.300</h4><ul>    <li>Fix rename playlist text color</li>    <li>Fix same album showing in details page</li>    <li>Fix lyrics text alignment on sync and lyrics reading improved</li>    <li>Improved home sections loading</li>    <li>Removed library options which are duplicated (it's available from profile menu)</li>    <li>Replaced collapsing Fab with Android Floating Extended Fab</li>    <li>Replaced home with for you</li>    <li>Fixed profile image not loading in about</li>    <li>Improved selecting user profile image</li>    <li>Added bio to enter custom message</li>    <li>Improved some UI screens</li></ul><p>If you see entire app white or dark or black select same theme in settings to fix </p><p style="line-height:150%"><a href="https://github.com/h4h13/RetroMusicPlayer/wiki/FAQ">FAQ's</a></p><p style="line-height:150%">*If you face any UI related issues you clear app data and cache, if its    not working try to    uninstall and install again. </p></body>
\ No newline at end of file
+<html><head>    <style type="text/css">        * {        word-wrap: break-word;        }        {style-placeholder}        a {        color: {link-color};        }        a:active {        color: {link-color-active};        }        ol {        list-style-position: inside;        padding-left: 0;        padding-right: 0;        }        li {        padding-top: 8px;        }    </style></head><body><h4>v3.4.400</h4><ul>    <li>Added app rating dialog</li>    <li>Fix remaining time in playing queue</li>    <li>Fix font not applied for some components</li>    <li>Fix crashing on album details sorting</li>    <li>Fixed lot of internal bugs</li>    <li>Fix dialog expand</li>    <li>Fix list card color</li>    <li>Removed SlidingUpPanel to replace with BottomSheet</li>    <li>Removed color theme as per material design guidelines</li>    <li>Removed classic theme(We're bringing back)</li>    <li>Removed artist loading from Deezer because it's not official to use(will come back with        official)    </li>    <li>Replace line switch to Material Switch in settings</li>    <li>Performance improved</li>    <li>Updated internal libraries</li>    <li>Updated translation</li>    <li>Limiting the use of Theme engine for making use of system colors</li>    <li>Change home icon from the user icon</li>    <li>Corrected all toolbar with elevation when scrolling</li></ul><h4>v3.3.200</h4><ul>    <li>Fix fullscreen bottom tabs icons squash</li>    <li>Improved tiny theme colors</li>    <li>Android auto support</li>    <li>New notification icon</li>    <li>Favorite icon in mini player</li></ul><h4>v.3.3.100</h4><ul>    <li>Improved Now playing controls alignment</li>    <li>Lot internal changes to improve performance</li>    <li>Fix playlist adding crash</li>    <li>Fix color corrections</li>    <li>Fix file editing crash</li></ul><h4>v3.3.000</h4><ul>    <li>SD card support for deleting and editing</li></ul><h4>v3.2.240</h4><ul>    <li>Improved options dialog with selected color and title icon</li>    <li>Fix dialog color on dark theme</li></ul><h4>v3.2.220</h4><ul>    <li>Fix Notification SeekBar position (Need Android Q test)</li>    <li>Rolled back settings tint icons</li>    <li>Changed preference category title style according Android Q</li>    <li>Fix tabs options not working</li></ul><h4>v3.2.203</h4><ul>    <li>Carousel effect improved</li>    <li>Settings icons are now tint accent color</li>    <li>Settings title, back arrow and icons are now tint accent color</li>    <li>Equalizer is removed</li>    <li>Fix keyboard not popping on Search</li>    <li>Curated the main options</li>    <li>Folder toolbar outlined, folder icon background fix and separate line removed</li>    <li>Edit text input handles are colored</li></ul><h4>v3.2.135</h4><ul>    <li>Fix crashing on sharing song</li></ul><h4>v3.2.125</h4><ul>    <li>Fix crashing on selecting profile picture</li>    <li>Semi transparent color fix(s) on now playing themes</li></ul><h4>v3.2.120</h4><ul>    <li>Fix crashing on choosing a theme</li>    <li>Fix color theme selection without pro enabled</li>    <li>Fix icon tint some places</li></ul><h4>v3.2.105</h4><ul>    <li>Fix color notifications</li></ul><h4>v3.2.100</h4><ul>    <li>Fix crashing on Sleep timer</li>    <li>Toolbar elevation removed added stroke instead</li>    <li>Show empty indication for home</li></ul><h4>v3.2.000</h4><ul>    <li>Implemented Artist image loading all thanks to <a            href="https://github.com/AdrienPoupa/VinylMusicPlayer"> VinylMusicPlayer</a></li>    <li>Fixed buttons in Genre details</li>    <li>Fixed color buttons in Album and Artist details screen</li></ul><h4>v3.1.900</h4><ul>    <li>Added Play and Shuffle buttons on Songs list, Album Details, Artist Details, Playlist        Details etc.    </li>    <li>Home toolbar is semi transparent in Banner mode</li>    <li>Added new Buy Retro Music pro in settings</li>    <li>Improved dark color in Dark theme</li></ul><h4>v3.1.850</h4><ul>    <li>Toolbar will be clickable for Search</li></ul><h4>v3.1.800</h4><ul>    <li>Search bar CardView background</li>    <li>Improve volume zero</li>    <li>Now playing and Album theme picker rollback to dialog</li>    <li>Fix sharing app link</li>    <li>Fix scanning dialog</li>    <li>Added settings icons for options</li></ul><h4>v3.1.700</h4><ul>    <li>Cleaned internal code</li>    <li>Removed full screen option</li>    <li>Added Toolbar elevation</li>    <li>To access menu either tap on Toolbar or Hamburger icon</li>    <li>Fix back button not working on playing queue</li>    <li>Fix crashing on What's New screen</li>    <li>Fix lyrics dialog</li>    <li>Changed toggles to line icons</li>    <li>Fix crashing on artist list for number format error</li>    <li>Fix blacklist dialog crashing</li>    <li>Rearranged icons and main menu access</li>    <li>Fix some crashes when device is locked or background</li>    <li>Folder screen have main options access</li>    <li>Dialogs are now using Material Dialogs v3(BottomSheet)</li>    <li>Fix Shuffle icon for Artist, Album, Genre and Playlist details</li></ul><h4>v3.1.400</h4><ul>    <li>Removed sync lyrics for Android 5</li>    <li>Fix Seek-bar color in settings</li>    <li>Added keyboard to popup on search</li>    <li>Added keyboard to popup on search</li>    <li>Improved lock-screen behavior and UI</li>    <li>Improved text appearance</li>    <li>Fix bio text not showing in settings</li>    <li>Fix not showing slider(blur, filter song) amount in settings</li>    <li>Fix setting ringtone</li>    <li>Fix file sharing crash</li>    <li>Fix some crashes</li>    <li>Fix playlist icon on small devices</li>    <li>Fix empty lyrics text color</li>    <li>Fix album cover background purple color in color theme</li></ul><h4>v3.1.300</h4><ul>    <li>Fix rename playlist text color</li>    <li>Fix same album showing in details page</li>    <li>Fix lyrics text alignment on sync and lyrics reading improved</li>    <li>Improved home sections loading</li>    <li>Removed library options which are duplicated (it's available from profile menu)</li>    <li>Replaced collapsing Fab with Android Floating Extended Fab</li>    <li>Replaced home with for you</li>    <li>Fixed profile image not loading in about</li>    <li>Improved selecting user profile image</li>    <li>Added bio to enter custom message</li>    <li>Improved some UI screens</li></ul><p>If you see entire app white or dark or black select same theme in settings to fix </p><p style="line-height:150%"><a href="https://github.com/h4h13/RetroMusicPlayer/wiki/FAQ">FAQ's</a></p><p style="line-height:150%">*If you face any UI related issues you clear app data and cache, if its    not working try to    uninstall and install again. </p></body>
\ No newline at end of file
diff --git a/app/src/main/res/layout/fragment_banner_home.xml b/app/src/main/res/layout/fragment_banner_home.xml
index 68e6c414..c0c5745f 100644
--- a/app/src/main/res/layout/fragment_banner_home.xml
+++ b/app/src/main/res/layout/fragment_banner_home.xml
@@ -75,9 +75,7 @@
                     android:layout_marginEnd="@dimen/toolbar_margin_horizontal"
                     android:layout_marginBottom="@dimen/toolbar_margin_vertical"
                     app:cardCornerRadius="8dp"
-                    app:cardElevation="0dp"
                     app:cardUseCompatPadding="true"
-                    app:layout_collapseMode="pin"
                     app:layout_scrollFlags="scroll|enterAlways">
 
                     <com.google.android.material.appbar.MaterialToolbar
