From 2f4632fd675cc6bf9f801a21dade70f1add90719 Mon Sep 17 00:00:00 2001 From: Hemanth S Date: Sat, 17 Oct 2020 18:00:11 +0530 Subject: [PATCH] Fix free label showing when Pro is enable #934 --- .../AlbumCoverStylePreferenceDialog.kt | 7 +++--- .../NowPlayingScreenPreferenceDialog.kt | 22 +++++------------- .../main/res/layout/activity_pro_version.xml | 23 ------------------- .../preference_now_playing_screen_item.xml | 4 ++-- 4 files changed, 11 insertions(+), 45 deletions(-) diff --git a/app/src/main/java/code/name/monkey/retromusic/preferences/AlbumCoverStylePreferenceDialog.kt b/app/src/main/java/code/name/monkey/retromusic/preferences/AlbumCoverStylePreferenceDialog.kt index f74f61d6..5c7e91ba 100644 --- a/app/src/main/java/code/name/monkey/retromusic/preferences/AlbumCoverStylePreferenceDialog.kt +++ b/app/src/main/java/code/name/monkey/retromusic/preferences/AlbumCoverStylePreferenceDialog.kt @@ -33,9 +33,7 @@ import androidx.viewpager.widget.ViewPager import code.name.monkey.appthemehelper.common.prefs.supportv7.ATEDialogPreference import code.name.monkey.retromusic.App import code.name.monkey.retromusic.R -import code.name.monkey.retromusic.extensions.colorButtons -import code.name.monkey.retromusic.extensions.colorControlNormal -import code.name.monkey.retromusic.extensions.materialDialog +import code.name.monkey.retromusic.extensions.* import code.name.monkey.retromusic.fragments.AlbumCoverStyle import code.name.monkey.retromusic.fragments.AlbumCoverStyle.* import code.name.monkey.retromusic.util.NavigationUtil @@ -126,9 +124,10 @@ class AlbumCoverStylePreferenceDialog : DialogFragment(), Glide.with(context).load(albumCoverStyle.drawableResId).into(image) title.setText(albumCoverStyle.titleRes) if (isAlbumCoverStyle(albumCoverStyle)) { + proText.show() proText.setText(R.string.pro) } else { - proText.setText(R.string.free) + proText.hide() } return layout } diff --git a/app/src/main/java/code/name/monkey/retromusic/preferences/NowPlayingScreenPreferenceDialog.kt b/app/src/main/java/code/name/monkey/retromusic/preferences/NowPlayingScreenPreferenceDialog.kt index d5f36405..e6760195 100644 --- a/app/src/main/java/code/name/monkey/retromusic/preferences/NowPlayingScreenPreferenceDialog.kt +++ b/app/src/main/java/code/name/monkey/retromusic/preferences/NowPlayingScreenPreferenceDialog.kt @@ -32,9 +32,7 @@ import androidx.viewpager.widget.ViewPager import code.name.monkey.appthemehelper.common.prefs.supportv7.ATEDialogPreference import code.name.monkey.retromusic.App import code.name.monkey.retromusic.R -import code.name.monkey.retromusic.extensions.colorButtons -import code.name.monkey.retromusic.extensions.colorControlNormal -import code.name.monkey.retromusic.extensions.materialDialog +import code.name.monkey.retromusic.extensions.* import code.name.monkey.retromusic.fragments.NowPlayingScreen import code.name.monkey.retromusic.fragments.NowPlayingScreen.* import code.name.monkey.retromusic.util.NavigationUtil @@ -93,7 +91,7 @@ class NowPlayingScreenPreferenceDialog : DialogFragment(), ViewPager.OnPageChang val nowPlayingScreen = values()[viewPagerPosition] if (isNowPlayingThemes(nowPlayingScreen)) { val result = - getString(nowPlayingScreen.titleRes) + " theme is Pro version feature." + "${getString(nowPlayingScreen.titleRes)} theme is Pro version feature." Toast.makeText(context, result, Toast.LENGTH_SHORT).show() NavigationUtil.goToProVersion(requireContext()) } else { @@ -131,9 +129,10 @@ private class NowPlayingScreenAdapter(private val context: Context) : PagerAdapt Glide.with(context).load(nowPlayingScreen.drawableResId).into(image) title.setText(nowPlayingScreen.titleRes) if (isNowPlayingThemes(nowPlayingScreen)) { + proText.show() proText.setText(R.string.pro) - } else { - proText.setText(R.string.free) + }else{ + proText.hide() } return layout } @@ -160,14 +159,5 @@ private class NowPlayingScreenAdapter(private val context: Context) : PagerAdapt } private fun isNowPlayingThemes(screen: NowPlayingScreen): Boolean { - return (screen == Full || - screen == Card || - screen == Plain || - screen == Blur || - screen == Color || - screen == Simple || - screen == BlurCard || - screen == Circle || - screen == Adaptive) - && !App.isProVersion() + return (screen == Full || screen == Card || screen == Plain || screen == Blur || screen == Color || screen == Simple || screen == BlurCard || screen == Circle || screen == Adaptive) && !App.isProVersion() } \ No newline at end of file diff --git a/app/src/main/res/layout/activity_pro_version.xml b/app/src/main/res/layout/activity_pro_version.xml index fbcf2516..9c62feeb 100644 --- a/app/src/main/res/layout/activity_pro_version.xml +++ b/app/src/main/res/layout/activity_pro_version.xml @@ -127,29 +127,6 @@ android:textColor="@color/md_white_1000" /> - - - - - - - - + app:layout_constraintStart_toStartOf="parent" + tools:text="@string/pro" /> \ No newline at end of file