From 1a4905cd76b15bda8d9d42fe0010869d122b4095 Mon Sep 17 00:00:00 2001
From: Hemanth S <hemanths@live.com>
Date: Mon, 12 Oct 2020 13:08:17 +0530
Subject: [PATCH] Added permission strings

---
 app/src/main/res/layout/activity_permission.xml | 8 ++++----
 app/src/main/res/values/strings.xml             | 6 ++++--
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/app/src/main/res/layout/activity_permission.xml b/app/src/main/res/layout/activity_permission.xml
index 784da5c4..a03ffe0c 100644
--- a/app/src/main/res/layout/activity_permission.xml
+++ b/app/src/main/res/layout/activity_permission.xml
@@ -37,9 +37,9 @@
         app:layout_constraintTop_toBottomOf="@id/divider"
         app:permissionButtonTitle="Grant access"
         app:permissionIcon="@drawable/ic_sd_storage"
-        app:permissionTitle="Storage Access"
+        app:permissionTitle="@string/permission_title"
         app:permissionTitleNumber="1"
-        app:permissionTitleSubTitle="The app needs permission to access your device storage for music files playing music" />
+        app:permissionTitleSubTitle="@string/permission_summary" />
 
     <code.name.monkey.retromusic.views.PermissionItem
         android:id="@+id/audioPermission"
@@ -51,9 +51,9 @@
         app:layout_constraintTop_toBottomOf="@id/storagePermission"
         app:permissionButtonTitle="Grant access"
         app:permissionIcon="@drawable/ic_phonelink_ring"
-        app:permissionTitle="Ringtone"
+        app:permissionTitle="@string/ringtone_title"
         app:permissionTitleNumber="2"
-        app:permissionTitleSubTitle="The app needs permission to access your device settings in order to set music as Ringtone"
+        app:permissionTitleSubTitle="@string/ringtone_summary"
         tools:visibility="visible" />
 
     <com.google.android.material.button.MaterialButton
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 4e789221..95add41a 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -885,8 +885,6 @@
         <item quantity="one">%d Artist</item>
         <item quantity="other">%d Artists</item>
     </plurals>
-    <!-- TODO: Remove or change this placeholder text -->
-    <string name="hello_blank_fragment">Hello blank fragment</string>
     <string name="done">Done</string>
     <string name="import_playlist">Import playlist</string>
     <string name="import_playlist_message">It imports all playlists listed in the Android Media Store with songs, if the playlists already exists, the songs will get merged.</string>
@@ -894,4 +892,8 @@
     <string name="sort_order_num_songs">Song count</string>
     <string name="sort_order_asc">Ascending</string>
     <string name="sort_order_num_songs_desc">Song count desc</string>
+    <string name="permission_summary">The app needs permission to access your device storage for playing music</string>
+    <string name="permission_title">Storage Access</string>
+    <string name="ringtone_title">Ringtone</string>
+    <string name="ringtone_summary">The app needs permission to access your device settings in order to set music as Ringtone</string>
 </resources>