Commit graph

5595 commits

Author SHA1 Message Date
Jean Chalard
ca9c3c0613 Fix a possible IOOB
We want to use StringUtils here, but it's full of references to
stuff not accessible host-side like JsonReader and TextUtils
and SettingsValues :/

Bug: 11061476
Change-Id: I3c0194979833ede283b4f9190335dba5376fe6fc
2013-10-07 23:16:57 +09:00
Jean Chalard
3c4e8cb693 Call loadKeyboard later if it can't be called right away
Since loadKeyboard relies on the input connection being
available to give it the auto-caps state, but also can't
be called twice in a row because it needs to save and
restore its state and invalidates it after the restore,
we need to wait until we know we have a valid input
connection to call it.

Bug: 11107229
Change-Id: I1c7baf3215682df6f6ceb357bd37254f9e7418c7
2013-10-07 22:57:59 +09:00
Satoshi Kataoka
291ef1c9c3 Merge "Clear the cache of subtypes in onStartInputViewInternal" 2013-10-07 11:19:47 +00:00
Satoshi Kataoka
4be5f221e6 Clear the cache of subtypes in onStartInputViewInternal
Bug: 11077905
Change-Id: I9495f13a20edca0e6153cd1a7a0ac6891f707c59
2013-10-07 20:10:58 +09:00
Jean Chalard
86f7711407 Merge "Don't auto-correct to non-whitelist shortcuts" 2013-10-07 10:04:18 +00:00
Jean Chalard
f309f2288b Don't auto-correct to non-whitelist shortcuts
Bug: 11076722
Change-Id: I0de10ab24d33ec31f45664fe92d80d5a7bec9c20
2013-10-07 19:01:57 +09:00
Jean Chalard
a6047aae94 Merge "Set the shortcut frequency correctly." 2013-10-07 10:00:34 +00:00
Jean Chalard
f3204eebb1 Set the shortcut frequency correctly.
14 is the right value.

Bug: 11076722
Change-Id: I95d404b540f7fbe4932d1f8498cde23f1df0314f
2013-10-07 18:55:42 +09:00
Keisuke Kuroyanagi
be4d85feb0 Merge "Fix bug and Add large test for decaying dictionary." 2013-10-07 09:32:56 +00:00
Jean Chalard
7da62bbe24 Merge "Remove suggestions when string contains a period" 2013-10-07 08:34:52 +00:00
Keisuke Kuroyanagi
cfb018ba6d Fix bug and Add large test for decaying dictionary.
- GC gets failure when the dictionary become empty.
- Useless unigrams are sometimes not removed.

Bug: 10197478
Change-Id: I8d1479c01efba61a81f03bc077da6bcb4797a940
2013-10-07 17:31:01 +09:00
Jean Chalard
df33982fce Remove suggestions when string contains a period
This is not the right way to do it, but it's simple and will kill the
regression. We should investigate why the return values are
wrong in this case.

Bug: 10780091
Change-Id: I808727242c9cb1598df00a7426358dc3a658add4
2013-10-07 17:27:27 +09:00
Satoshi Kataoka
4746217247 Enter -> Alpha keyboard switcher in Emoji palette view
Bug: 11103091
Change-Id: I0c5384e9f148566d1ac1d178a8227eb913d59908
2013-10-07 17:05:54 +09:00
Satoshi Kataoka
4deb824f3a Add navigateEmoji
Bug: 11074625
Change-Id: I1ef6b81ef923684b502c24fddb4ced8fe1691733
2013-10-07 15:28:39 +09:00
Satoshi Kataoka
e6e4c70a23 Fix build
Change-Id: I61341aa7b1ceb311aaa5faa5888ba31e463a95d5
2013-10-07 12:48:14 +09:00
Satoshi Kataoka
d76b552979 Rename EmojiKeyboardView -> EmojiPalettesView
Change-Id: I226bb8e21fd2b2b6639896a1cc433d19f3f431c2
2013-10-07 12:28:13 +09:00
Jean Chalard
423921ca13 Merge "Fallback on empty locales." 2013-10-04 13:44:44 +00:00
Jean Chalard
5db7eabafb Merge "Accept double-space-period after emoji." 2013-10-04 13:05:43 +00:00
Jean Chalard
43a8a0c527 Fallback on empty locales.
This is a very rare corner case.

Bug: 11072132
Change-Id: Iad2aa69511f7dc99105284a049c63f2f997b8ef0
2013-10-04 22:04:59 +09:00
Jean Chalard
8142fd83a6 Accept double-space-period after emoji.
This also includes a fix that allows this code to read surrogate
pairs in this processing.

Bug: 11070482
Change-Id: If5ef8d6863938252f09128b7e99ea07ece6e7019
2013-10-04 22:01:36 +09:00
Satoshi Kataoka
1d188a28fb Merge "Fix emoji" 2013-10-04 12:00:39 +00:00
Satoshi Kataoka
0cf92aa826 Fix emoji
Bug: 10538430

Change-Id: Ib11e29794216b54001806ab12fe440d157243dc1
2013-10-04 20:58:09 +09:00
Satoshi Kataoka
0b288985b7 Merge "Fix emoji recent key behavior" 2013-10-04 11:18:07 +00:00
Satoshi Kataoka
e7ed5cae44 Fix emoji recent key behavior
Bug: 10538430
Change-Id: I91e03a8e7914628cdc8e57c124c95e5e6e8ea2a6
2013-10-04 20:01:00 +09:00
Ken Wakasa
c01707db03 Merge "Suppress exceptions that have always been happening." 2013-10-04 10:13:53 +00:00
Ken Wakasa
fba1bd0ec4 Suppress exceptions that have always been happening.
Change-Id: I5f85a7a0f94ea9ecbe0c4a8caebcf551fa9c9669
2013-10-04 19:10:26 +09:00
Yuichiro Hanada
e4e0add9fb Add Ver4DictUpdater.
Change-Id: I986ab26faf535fc4bc98443053f534eced9d048f
2013-10-04 17:33:29 +09:00
Yuichiro Hanada
75d60e821c Refactor BinaryDictIOUtilsTests.
Change-Id: I2208378b33038771b460abb33f9a690872e998e2
2013-10-04 14:19:13 +09:00
Yuichiro Hanada
14d31d4640 Add AbstractDictDecoder.
Change-Id: Ie69d84e090f69dc3ea1f5de73ad8c954ecd2c6a7
2013-10-04 14:16:59 +09:00
Yuichiro Hanada
73b9d3b879 Separate shortcut targets from the trie file.
Bug: 10920165
Change-Id: I340759eadbde7fb64cb3b9a3c619ee3a768cedf8
2013-10-04 11:16:10 +09:00
Keisuke Kuroyanagi
864ee881bd Merge "Fix UserHistoryDictionaryTests." 2013-10-03 12:02:34 +00:00
Keisuke Kuroyanagi
11f7cae094 Fix UserHistoryDictionaryTests.
Bug: 6669677
Bug: 10667710

Change-Id: I6cdc6a6c9cacc7f276fda3a26ec31e3eb928471c
2013-10-03 20:55:34 +09:00
Yuichiro Hanada
3dd77a6d66 Add SparseTableContentWriter to Ver4DictEncoder.
Bug: 10920165
Change-Id: I6372492e97297baad4c5aeeb3fb36dcccd7a944b
2013-10-03 20:31:01 +09:00
Yuichiro Hanada
d6e307a4b7 Add DictUpdater.
Change-Id: Ic586e46e5a9f59de53d53e59886d635345940974
2013-10-03 20:16:34 +09:00
Satoshi Kataoka
85607c5965 Merge "Fix the subtype id of the additional subtypes" 2013-10-03 07:45:24 +00:00
Satoshi Kataoka
9ecdb831db Fix the subtype id of the additional subtypes
Bug: 11032428
Change-Id: I5d422f1c15a582015770ef9a652348ca6eb8ab85
2013-10-03 16:41:13 +09:00
Satoshi Kataoka
c7f8d54d6e Merge "Prepare for changing text color for functional keys" 2013-10-03 07:15:03 +00:00
Satoshi Kataoka
194e004e81 Prepare for changing text color for functional keys
Bug: 10786040

Change-Id: I0de7d4923ea13b44adcf1f4ea456796cd02ef27b
2013-10-03 15:54:46 +09:00
Keisuke Kuroyanagi
d25cd26f1a Merge "Try decaying user history at hourly intervals." 2013-10-02 09:44:03 +00:00
Yuichiro Hanada
3aa8977cb2 Remove some unused variables.
Change-Id: Iaf1556fec194d17cb4318f2bdcc837f8d79449ef
2013-10-02 18:26:03 +09:00
Keisuke Kuroyanagi
f36a97ab3a Try decaying user history at hourly intervals.
Bug: 6669677

Change-Id: Ib465fa7e1a7f289a07843535ba89d0dd5259e803
2013-10-02 18:06:08 +09:00
Ken Wakasa
2dcb63375d Merge "Make SparseTable have multiple content tables." 2013-10-02 08:32:55 +00:00
Jean Chalard
cd7422f4df Merge "Fix a pernicious bug with caps." 2013-10-02 07:59:08 +00:00
Jean Chalard
f735117d36 Fix a pernicious bug with caps.
What's happening here is, setAlphabetKeyboard sets the
keyboard to AUTOMATIC_SHIFTED and updates the keyboard, then
restoring the keyboard old state sets it back to UNSHIFTED without
updating it. When we finally know what the correct value is,
we try to set it to UNSHIFTED, but since that's already the currently
recorded state, it skips updating the keyboard forever.

The solution is to avoid setting the shift state without updating the
keyboard.

Bug: 10948582
Change-Id: Ic8670401e378f8284e851281f91a9ad93eac8e90
2013-10-02 16:57:36 +09:00
Satoshi Kataoka
c5182c9a4a Correspond to the security related API change for PreferenceActivity
Bug: 10118761
Change-Id: Ia7d1c6c526dae849f447c26387e96a4fb4d6042f
2013-10-02 16:25:07 +09:00
Yuichiro Hanada
4284e9aae7 Make SparseTable have multiple content tables.
Bug: 10920165
Change-Id: Ie9008452ee292fb0b1fec66e2ffed228c4af6c3e
2013-10-02 15:36:13 +09:00
Jean Chalard
a8b838b473 Merge "Fix a test and crash with a better error message when reading" 2013-10-02 06:28:06 +00:00
Jean Chalard
fa946d4a0f Fix a test and crash with a better error message when reading
When there are too many bigrams, we stop reading the file,
so the file pointer is in an inconsistent place. This means we
have no idea what's going to happen next. It's better to crash
right away.

Change-Id: Id3b7b78cbe4fda3493b3c9c46758763e1ab5f6a3
2013-10-02 11:48:47 +09:00
Satoshi Kataoka
5ceae026e0 Retain Emoji Keyboard after rotation
Bug: 10612450
Change-Id: Ie0ae953958d2b0a0a4da651584f1e28b0ba38ae3
2013-10-01 22:59:02 +09:00
Satoshi Kataoka
9d76391058 Merge "Unfortunately, hide some broken "emoji"s" 2013-10-01 12:18:13 +00:00
Jean Chalard
74577bedb3 Merge "Implement the heuristic for auto-commit." 2013-10-01 12:10:57 +00:00
Satoshi Kataoka
c7e6f3dbc3 Unfortunately, hide some broken "emoji"s
Bug: 10923117
Change-Id: I27ba38e5f388cc15ae331fd05d63db4e4a41cbbf
2013-10-01 21:02:59 +09:00
Jean Chalard
459cd6f8ef Implement the heuristic for auto-commit.
Bug: 9059617
Change-Id: I066abf018df5aaeabf415425dd822ebe233e6008
2013-10-01 21:00:40 +09:00
Jean Chalard
2afa0e621e Merge "Fix a bug where gesture would delay update." 2013-10-01 11:21:59 +00:00
Jean Chalard
b1e6eeea57 Fix a bug where gesture would delay update.
Change-Id: I94c394f45f2717bc1a4b95692a5757c1e7179152
2013-10-01 20:06:36 +09:00
Ken Wakasa
382094a784 Merge "Cleanup and remove redundant more keys on phones" 2013-10-01 10:29:15 +00:00
Ken Wakasa
e56c2f979f Cleanup and remove redundant more keys on phones
Change-Id: I419c3c119eb1e4d2e877c8c00564e46f40b6abc2
2013-10-01 19:02:09 +09:00
Ken Wakasa
cc81a93b01 Merge "Add skipPtNode to DictDecoders." 2013-10-01 09:06:39 +00:00
Yuichiro Hanada
bc4926235d Add skipPtNode to DictDecoders.
Change-Id: I042ff041b68572182c87dc87db6a6aa2bbbefc6c
2013-10-01 17:21:21 +09:00
Satoshi Kataoka
a4913994c2 Hide indication bar if only one page
Bug: 10923117
Change-Id: If81bf07ba2e7c4fff44a8832f98b4a393c15edc7
2013-10-01 16:58:42 +09:00
Keisuke Kuroyanagi
126d758c1e Merge "Quit blocking getSuggestion during GC." 2013-10-01 07:08:11 +00:00
Jean Chalard
bb57090f1d Create the wiring for auto-commit confidence computation.
Bug: 9059617
Change-Id: I7e4e05ffa8c68cfebbe362a977fd176555cad12a
2013-10-01 15:04:15 +09:00
Keisuke Kuroyanagi
03cb8f751a Quit blocking getSuggestion during GC.
Bug: 10831272

Change-Id: I995c619dc18a9120a47f547d31045cb73a9353ec
2013-10-01 12:04:06 +09:00
Alan Viverette
458fb52b98 Merge "Speak auto-corrections for accessibility" 2013-09-30 18:14:13 +00:00
Keisuke Kuroyanagi
65330d2820 Merge "Implement simple dictionary decay." 2013-09-30 11:56:15 +00:00
Keisuke Kuroyanagi
fd02b2d6ee Implement simple dictionary decay.
Groundwork and implement simple decay.
Increment probability when typed and decrement probability
at GC.

Bug: 6669677

Change-Id: Ib12caead0cbeef4ce7808fe8ac0b00ee331523fe
2013-09-30 20:53:35 +09:00
Keisuke Kuroyanagi
ef084229f6 Merge "Use reentrant lock for main dictionaries." 2013-09-30 09:25:54 +00:00
Keisuke Kuroyanagi
3e6275634b Use reentrant lock for main dictionaries.
Bug: 10964805
Change-Id: Iaa9b79fc770d8ae2ec9d7c362c90c28bc9f65ea8
2013-09-30 18:16:29 +09:00
Ken Wakasa
25f4782853 Merge "Separate bigram entries from the trie file." 2013-09-30 08:00:01 +00:00
Yuichiro Hanada
fd46e87da2 Separate bigram entries from the trie file.
Bug: 10920165
Change-Id: I42eb7f228994a56c2f31a1c83904c8c360b6d088
2013-09-30 16:42:42 +09:00
Ken Wakasa
d40a931a4d Merge "Change scopes of some methods in DynamicBinaryDictIOUtils." 2013-09-30 07:17:38 +00:00
Keisuke Kuroyanagi
c18510049a Prepare dictionary decay.
Bug: 6669677
Change-Id: I8fbae190dd44a6bdbee7e9b6d3a16208322727f7
2013-09-30 13:57:54 +09:00
Yuichiro Hanada
dc4f357f6b Change scopes of some methods in DynamicBinaryDictIOUtils.
Change-Id: I1371d41760b38834d1d5ff40e682ac0a6fc9f2e9
2013-09-30 11:32:07 +09:00
Keisuke Kuroyanagi
1cf4789ba6 Merge "Set header attributes for ExpandableBinaryDictionary." 2013-09-29 05:14:22 +00:00
Satoshi Kataoka
b0c5ddb9c7 Merge "Stop vibration while repeating delete key in emoji view" 2013-09-28 10:37:57 +00:00
Satoshi Kataoka
d0df68e6cb Stop vibration while repeating delete key in emoji view
Bug: 10960355
Change-Id: Ic1fdecdbcab4082c5383623c1f2575e3976ebe27
2013-09-28 17:02:58 +09:00
Keisuke Kuroyanagi
5ed30a7660 Set header attributes for ExpandableBinaryDictionary.
Bug: 6669677

Change-Id: I2462777eaa07600f1c774226adfc4f351882f523
2013-09-28 12:50:09 +09:00
Alan Viverette
67319f92f3 Speak auto-corrections for accessibility
BUG: 8669376
Change-Id: Id71b2c2835daa7a8c9d6c92c57a7e302551c289d
2013-09-27 14:15:53 -07:00
Satoshi Kataoka
4dc2b9131f Merge "Fix possible NPE in KeyboardSwitcher" 2013-09-27 16:52:32 +00:00
Satoshi Kataoka
adbb979b56 Fix possible NPE in KeyboardSwitcher
Bug: 10964306
Change-Id: Ibcea76da746f6cac92c8d91425d25d04ade62af0
2013-09-28 01:19:18 +09:00
Keisuke Kuroyanagi
8b580819a5 Merge "Add unigram/bigram counting." 2013-09-27 14:14:49 +00:00
Keisuke Kuroyanagi
31097a57cc Add unigram/bigram counting.
Bug: 6669677
Change-Id: I05ea2201d822dddf062b08c8467daa336760e16c
2013-09-27 23:12:12 +09:00
Keisuke Kuroyanagi
e74d4a184b Stop reading dictionary while regenerating.
Bug: 10831272

Change-Id: Iead7268a9371b48d729a5f65074ccbc05f3185db
2013-09-27 21:44:26 +09:00
Jean Chalard
b7dfacd31e Merge "Send backspace as an event when TYPE_NULL." 2013-09-27 08:00:43 +00:00
Jean Chalard
de814ec0ec Send backspace as an event when TYPE_NULL.
This is not enough to really fix behavior with TYPE_NULL,
but it does make things a bit better.

Bug: 10949594
Change-Id: Ia359f781cdd76a2e2c5a4c9f166025d81b931174
2013-09-27 16:55:12 +09:00
Yuichiro Hanada
a328f538c3 Fix PrioritizedSerialExecutor.
It was possible that fetchNextTasks() would be called by multiple
threads concurrently.
If it happens, some tasks in the task queues might be ignored.

Change-Id: Idc81c43c45e382da3850cc55b9a42c281548d2a8
2013-09-27 16:46:34 +09:00
Yuichiro Hanada
781feb748c Remove unused methods.
Change-Id: I542db0c717c0bc05c8baa08f1e9db0a05946a99b
2013-09-27 12:34:38 +09:00
Keisuke Kuroyanagi
e3e10317b0 Merge "Create empty dictionary file in native code." 2013-09-26 08:03:38 +00:00
Yuichiro Hanada
d188af7022 Add SparseTable.
Bug: 10920165
Change-Id: I749dd0269e788799e30b10beb2671813d40ce15f
2013-09-26 16:16:30 +09:00
Keisuke Kuroyanagi
5ef6209656 Create empty dictionary file in native code.
Bug: 6669677
Change-Id: I46d23deee1fd091678f4593561cb8687eb815212
2013-09-26 12:59:02 +09:00
Ken Wakasa
4350a93aa5 Merge "Fix the offdevice regression test build" 2013-09-25 10:30:18 +00:00
Ken Wakasa
f56b82f809 Fix the offdevice regression test build
Followup to If4e44eca3cdc5bb02cf2e0c8c44ecd4bf27fae57

bug: 10622489
Change-Id: If98b2c75725f8692f0c2b41c33e448086404479b
2013-09-25 19:13:47 +09:00
Keisuke Kuroyanagi
5fa9654045 Merge "Clear traverse sessions when closing." 2013-09-25 10:06:33 +00:00
Satoshi Kataoka
6e41d9a479 Merge "Input delete onUpKey" 2013-09-25 10:02:24 +00:00
Satoshi Kataoka
a456e3f659 Input delete onUpKey
to avoid deletion when the user starts gesture from the delete key

Bug: 7303982
Change-Id: If4b3e6287ceee1cf9f72a1d92f2a6789065da454
2013-09-25 18:55:57 +09:00
Keisuke Kuroyanagi
6142068a33 Clear traverse sessions when closing.
Bug: 6669677
Change-Id: I859be934f0c60485e04cdc4cab288a18242fa04e
2013-09-25 18:32:40 +09:00
Ken Wakasa
399422f4b9 Merge "Make Ver4DictEncoder write an address table of terminal nodes." 2013-09-25 08:45:39 +00:00
Satoshi Kataoka
1e69f3e637 Fix emoji page
Bug: 10538430
Change-Id: If4d5ebb26e7ead259e8f370462ccf4c9dbf734f8
2013-09-25 17:20:27 +09:00
Yuichiro Hanada
22c5c450fe Make Ver4DictEncoder write an address table of terminal nodes.
Bug: 10920165
Change-Id: I86017456ea9fa5d6e12b57172c34f5ed4f88ef94
2013-09-25 17:03:54 +09:00
Satoshi Kataoka
0938fb6913 Allow gesture from the delete key
And inputting unexpected word while repeating the gesture
Bug: 7303982
Change-Id: I17bb6a689397500fa0e26706d6e07e427ea0b4d7
2013-09-25 14:15:43 +09:00