ad0233fa02
Merge "Refactor a method" into jb-dev
2012-05-11 04:09:17 -07:00
4455fe2c89
Refactor a method
...
Rename it, rename parameters, and add a parameter that will
be necessary soon.
Also, rescale the bigram frequency as necessary.
Bug: 6313806
Change-Id: I192543cfb6ab6bccda4a1a53c8e67fbf50a257b0
2012-05-11 19:34:35 +09:00
a6204bbe2a
Fix Spanish keyboard to have easy access to inverted ? and !
...
Bug: 6480385
Change-Id: Iae7879b5264711962a662f4b3d47a834bda715be
2012-05-11 19:17:53 +09:00
2de0b52a03
Merge "Reorganize punctuations and diacritics of Arabic and Persian" into jb-dev
2012-05-11 03:06:33 -07:00
6792a909cd
Merge "Output caps debug code" into jb-dev
2012-05-11 03:06:29 -07:00
5434f46481
Remove unexpectedly split words with single quotes
...
Bug: 6451163
Change-Id: I4c5595f727934f2b401e9bb11a6ba613668f4a42
2012-05-11 18:49:29 +09:00
b6fb5eb391
Output caps debug code
...
Change-Id: I4a3399d9066bd28dab893ecebb720924110b871d
2012-05-11 17:37:14 +09:00
88794b24c0
Remove the dependency to SpellCheckerProximityInfo from ProximityInfo.
...
In conjunction with I596b2deb
Change-Id: I42f059158ae78e1c1c807ed4d3688edbcf18c006
2012-05-11 17:03:06 +09:00
ef6dadbe6c
Reorganize punctuations and diacritics of Arabic and Persian
...
Bug: 6029665
Change-Id: Id72d5af2c9c8fff09a366819901c950b87756dea
2012-05-11 15:48:56 +09:00
d995452d2e
Merge "Add Bulgarian BDS keyboard" into jb-dev
2012-05-10 22:22:22 -07:00
3904af7ef1
Add Bulgarian Phonetic keyboard
...
Bug: 5738545
Change-Id: I4779136e717efd2934acaa68abc469016d08cd37
2012-05-11 14:14:29 +09:00
286c594dc3
Add Bulgarian BDS keyboard
...
Bug: 5738545
Change-Id: I20f31c4ff57a06e6df93ce3cfe4d032afd5bacc7
2012-05-11 12:32:25 +09:00
176354466e
Merge "Import translations. DO NOT MERGE" into jb-dev
2012-05-10 15:42:20 -07:00
79525efec5
Import translations. DO NOT MERGE
...
Change-Id: I6955e7f746cbe31e27e32aa8d2d33dccf465f571
2012-05-10 15:06:38 -07:00
6662e2a40d
Implement "lift-to-type" interaction. Fix event text.
...
Bug: 6456970
Change-Id: Idd6b84fc7a730a1e78d9c1157e3b5f22e5d49fc4
2012-05-10 11:37:13 -07:00
7c23ad92fc
Merge "Use key index as virtual view ID." into jb-dev
2012-05-10 11:34:20 -07:00
0462f4dced
Fix 10-inch tablet layout
...
* Fix missing delete key for greek
* Remove shift keys from farsi
* Move delete and enter key down for farsi
* Tweak 3rd-row key position of nordic
Bug: 6422448
Change-Id: I2066c1927f60660513c89615488520f716a15fa5
2012-05-10 19:20:19 +09:00
60ece5cba5
Merge "Tidy up Hindi 7-inch layouts" into jb-dev
2012-05-10 02:56:16 -07:00
e6241e2543
Merge "Tidy up Arabic and Farsi 7-inch layouts" into jb-dev
2012-05-10 02:54:20 -07:00
c44a3e07a3
Merge "Tidy up 11-11-{7,8,9} 7-inch tablet layouts" into jb-dev
2012-05-10 02:54:14 -07:00
3b7d40f464
Merge "Tidy up 10-10-7 7-inch tablet layouts" into jb-dev
2012-05-10 02:54:08 -07:00
7aa6c030cf
Tidy up Hindi 7-inch layouts
...
* Remove right shift key from hindi (same as east_slavic)
Bug: 6422448
Change-Id: Icea9a027c825f74471425abea261d5499f02c2c6
2012-05-10 18:50:49 +09:00
edde070a90
Tidy up Thai 7-inch layouts
...
* Remove right shift key from thai
* Add comma and period keys
Bug: 6422448
Change-Id: I40ff445ee763d964860fe6eb46e7168534a98c35
2012-05-10 18:36:44 +09:00
09d942e0da
Tidy up Arabic and Farsi 7-inch layouts
...
* Tweak key width and positon for arabic.
* Move delete and enter key down for farsi.
Bug: 6422448
Change-Id: I4fce1f4761eb1b53e432900c19e455a023721fc6
2012-05-10 18:28:38 +09:00
2363d0c931
Tidy up 11-11-{7,8,9} 7-inch tablet layouts
...
* Add gutters between shift keys and letters for nordic
* Slightly narrower 3rd-row letter keys for bulgarian
* Remove "ъ" key from 1st-row of east_slavic
* Remove right shift for 11-11-9 east_slavic and south_slavic
Bug: 6422448
Change-Id: I2311bd475aabda51080f0be3714fabffa65b2009
2012-05-10 18:27:58 +09:00
4739b21b41
Tidy up 10-10-7 7-inch tablet layouts
...
Bug: 6422448
Change-Id: I0c1721462572da7be7850d670c4f86d0c18cb610
2012-05-10 18:26:38 +09:00
a97bfdc225
Merge "Tidy up 10-9-7 7-inch tablet layouts" into jb-dev
2012-05-10 02:20:19 -07:00
684c519d9d
Merge "Cleanup indentation" into jb-dev
2012-05-10 01:53:38 -07:00
cee24a1f6c
Cleanup indentation
...
Change-Id: Iaaade378acb81a2d68e2e721778a82fd8d5e20a5
2012-05-10 17:48:10 +09:00
5fc2c22d43
Tidy up 10-9-7 7-inch tablet layouts
...
* Slightly smaller key width and larger shift key and space key.
* Both left and right shift key has the same width.
* Move the 2nd-row slight right.
Bug: 6422448
Change-Id: If27028eaac20c503c352ba35dd156befc53918c7
2012-05-10 15:26:55 +09:00
b4c41fa813
Use key index as virtual view ID.
...
Bug: 6464677
Change-Id: I443e4add8052dbce1d413c2ce38a7b98408613bf
2012-05-09 22:23:14 -07:00
52ab6864d0
Merge "Remove unused code from AccessibilityEntityProvider." into jb-dev
2012-05-09 22:18:50 -07:00
bced82709a
Merge "Fix calculation of more keys keyboard position based on key preview" into jb-dev
2012-05-09 06:04:47 -07:00
7ecc1081ab
Fix calculation of more keys keyboard position based on key preview
...
Bug: 6135881
Change-Id: Id1c4e2c13d13b474466cb9b42b425aa9f6f9448b
2012-05-09 21:23:09 +09:00
5a40dcaf8b
Release previously pressed key even when the up event points new key
...
Bug: 6457266
Change-Id: I52c9fe88791d2c3a4385dfa457f07da160c60699
2012-05-09 20:24:14 +09:00
c8bde75cf4
Merge "Optimize InputConnection.getCursorCapsMode calling" into jb-dev
2012-05-09 00:24:00 -07:00
03ca17c841
Optimize InputConnection.getCursorCapsMode calling
...
Bug: 6464226
Change-Id: I30c1b01be5e1719ded5f7f8a7e24a38e9bbc3637
2012-05-09 16:19:08 +09:00
d5cd7e64aa
Small optimization
...
Change-Id: I067249976e557b60b606d2153deaeb3c8f1f38ac
2012-05-09 16:14:25 +09:00
442ac5d0bb
Merge "Don't ask for surrounding characters for each keypress" into jb-dev
2012-05-08 23:38:53 -07:00
736b109e16
Don't ask for surrounding characters for each keypress
...
Bug: 6464226
Change-Id: I03745bbcc21e5ec6ca57fa1257bf21c0cd26391a
2012-05-09 15:19:35 +09:00
8e5f79f57d
Remove unused code from AccessibilityEntityProvider.
...
Change-Id: I73882668b516344d36e69355e9cb39534becb629
2012-05-08 19:51:49 -07:00
34b2b5e694
Remove accessibility gesture handlers from LatinIME.
...
Bug: 6457558
Change-Id: If33ca6f026d4846ba79a701ef42c0112f5b0b488
2012-05-08 17:23:58 -07:00
67b2c58404
Merge "Fix key preview background of GB theme" into jb-dev
2012-05-08 06:43:48 -07:00
f52aef84a5
Merge "Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified" into jb-dev
2012-05-08 06:43:05 -07:00
465003441f
Fix key preview background of GB theme
...
To match with the requirements of Id1c4e2c1
Bug: 6135881
Change-Id: If877fffb3863101edec2fa96f1fa4ae016c017f1
2012-05-08 17:07:58 +09:00
0b831ba2aa
Tab key preforms next action when EditorInfo.IME_ACTION_NEXT is specified
...
Bug: 6435484
Change-Id: Iccca7d1b770c547efae0b5e5931cebd910083d40
2012-05-08 13:20:39 +09:00
47021b7a94
Merge "Preserve enter key's label case" into jb-dev
2012-05-07 21:12:02 -07:00
a10003281d
Preserve enter key's label case
...
Bug: 6449347
Change-Id: I897df3a3c5464eaccf04c8b1cba70ccf313dd0bb
2012-05-08 12:57:34 +09:00
7b6afb1287
Enable long-press spacebar on 7 inch tablet
...
This change also eliminate useless attribute longPressSpaceKeyTimeout
of LatinKeyboardView.
Bug: 6449356
Change-Id: Ib4dace4b9510c0eb96bdddacf8e0dbaa14fcfbbf
2012-05-08 12:50:07 +09:00
22d196cb17
Import translations. DO NOT MERGE
...
Change-Id: Ic65c9b1373f39ff3fde9631e516d56b05eae2d1f
2012-05-07 14:39:45 -07:00
e58f3af8a7
Treat apostrophe as single quote in spell checker
...
Bug: 6435348
Change-Id: Iaaac9042e7e6cb21a3f2243bc6e8e055cc24f74d
2012-05-07 22:21:55 +09:00
165725aba8
Fix build
...
Related-change: I173a3dc0
Change-Id: I4b5adedb70f7501e84fd3604aa240161c97dc713
2012-05-07 08:19:17 +09:00
8e50c5d198
Fix subtype name for a custom input style with en_US and en_GB
...
This change utilizes "UntranslatableReplacementStringInSubtypeName"
subtype extra value to display keyboard layout name dynamically.
Bug: 6449315
Change-Id: I9ef4c3d66ff9a223aa8c89c346d04cb72e4f6263
2012-05-07 03:25:08 +09:00
4e6c604645
Merge "Fix newly created custom input style display name" into jb-dev
2012-05-06 10:46:07 -07:00
ca93442026
Fix newly created custom input style display name
...
This will revert I4263632e
Bug: 6443665
Bug: 6410653
Change-Id: Id9ad1a204ed9802488abfc2c536a95d62d55afe0
2012-05-07 02:42:08 +09:00
3665e2a8fc
Merge "Tidy up the MakedictLog class." into jb-dev
2012-05-06 10:31:46 -07:00
4c9bdcc957
Merge "Fix missing synchronized modifier" into jb-dev
2012-05-06 09:52:52 -07:00
90b73b85e4
Merge "Get subtype name string resource from its own locale" into jb-dev
2012-05-06 09:44:57 -07:00
5b2eb0f505
Fix missing synchronized modifier
...
Change-Id: Ied70a86bedb08adcf8353b189367172459f55292
2012-05-07 00:55:01 +09:00
757c12556b
Get subtype name string resource from its own locale
...
Bug: 6443655
Change-Id: Ib9ee55178f0d0f885aa0640b9cba4a179cf0c566
2012-05-07 00:44:54 +09:00
ee8ac602e8
Preserve label case of to-symbol-key
...
Bug: 6443192
Change-Id: I66c3c13d43c04fef4731ad2b4edabd8cd32f9437
2012-05-06 15:58:17 +09:00
84478103ec
Tidy up the MakedictLog class.
...
Follow up to I436b2b7b
Change-Id: Id17b134dab2f876b874a505e92a379c8b5567fa4
2012-05-05 23:40:21 +09:00
03b423f313
Suppress debug log from makedict in LatinIME
...
bug: 6447900
Change-Id: I436b2b7b261b422a7edca9cb99a4689b63877fe0
2012-05-05 09:28:27 +09:00
a995714184
Import translations. DO NOT MERGE
...
Change-Id: I5527274e1462dab152b4b3bf907343d22ec0e102
2012-05-03 16:34:22 -07:00
558f073311
Import translations. DO NOT MERGE
...
Change-Id: I4f26fabb1968b81ba8646deb459a2ebd0fc07fe3
2012-05-02 14:50:24 -07:00
9ec06c17d4
Fix build breakage
...
Change-Id: I22305137b336c9aab019d044a517ae8bc5fefe45
2012-05-02 18:14:40 +09:00
57007ed582
Merge "Workaround return preserved backing view height when the backing view is not ready" into jb-dev
2012-05-02 01:42:00 -07:00
f4cf5b9952
Workaround return preserved backing view height when the backing view is not ready
...
Change-Id: If4f24500ead516c46e6a93a95291e0897548c2f0
2012-05-02 17:40:10 +09:00
a1c89d9dbf
Import translations. DO NOT MERGE
...
Change-Id: Ia71f1f0df919691792648da0d4b6eb41edcf5747
2012-05-01 14:12:13 -07:00
76d6673b2a
Merge "Fix checking if subtype belongs to this ime" into jb-dev
2012-05-01 04:23:40 -07:00
ae2388c7f7
Fix checking if subtype belongs to this ime
...
Bug: 6422318
Change-Id: I5779c0e277444315191fa964a976dcb4316cc24a
2012-05-01 20:21:10 +09:00
aec1770ed1
Tune letter text size of 7 inch tablet
...
Bug: 6422086
Bug: 6411272
Change-Id: Ia3c40206555353b6f0c633a529d546dc2379e9aa
2012-05-01 19:56:40 +09:00
dadcfcf011
Merge "Narrow horizontal gap of 7 inch tablet landscape" into jb-dev
2012-05-01 03:51:20 -07:00
7995703ded
Narrow horizontal gap of 7 inch tablet landscape
...
Change-Id: I20579d75f5669909efd18a70b47cd44f471fd452
2012-05-01 19:24:48 +09:00
d780963db7
Auto X scale domain key label
...
Bug: 6411275
Change-Id: I94906adb6936371f5275a1494f6f8b5546633a2b
2012-05-01 19:21:15 +09:00
dd5e6e6559
Remove duplicated functional keys
...
Bug: 6410931
Change-Id: I07e84729da00d335e3864b9324bb1261df8968f7
2012-05-01 19:10:24 +09:00
d16c838d6e
Merge "Remove tab key from alphabet layout of tablet 7" into jb-dev
2012-05-01 03:08:24 -07:00
ad5c0dc8f0
Remove tab key from alphabet layout of tablet 7
...
Bug: 6410889
Change-Id: If7269aa2aeb1b6af9f0286f96c48b68309d646c5
2012-05-01 18:47:00 +09:00
d44c196ae4
Merge "Override defaultActionKeyStyle to use non-blue action background" into jb-dev
2012-05-01 01:33:24 -07:00
1ecd46189d
Merge "Add keyboard bottom padding for 7 inch tablet" into jb-dev
2012-05-01 01:19:29 -07:00
e02de4b9a9
Override defaultActionKeyStyle to use non-blue action background
...
Bug: 6412932
Change-Id: I1c7335c53a35fc88694224332511415ea63ac745
2012-05-01 17:19:10 +09:00
a474dbc5c2
Merge "Don't autocorrect after suggestion resuming" into jb-dev
2012-05-01 01:15:23 -07:00
4b5b46bb66
Don't autocorrect after suggestion resuming
...
Bug: 6105732
Change-Id: I92e7a9c6d6eb648f747c3b396d7993479fd8478a
2012-05-01 17:06:29 +09:00
6f953ba202
Add keyboard bottom padding for 7 inch tablet
...
Bug: 6411451
Change-Id: I183e9dca258aa2b632e486ce1d115d1d7f3d739d
2012-05-01 17:05:21 +09:00
2f83e9e532
Can override key-style
...
Bug: 6412932
Change-Id: I9576ae5b42bcc54cfd8ede0bae5148f3b04c1978
2012-05-01 16:56:53 +09:00
30ce0c4e64
Merge "Fix CHAR LIMIT of some string resources" into jb-dev
2012-04-30 22:54:23 -07:00
088350d663
Fix CHAR LIMIT of some string resources
...
Bug: 6421155
Change-Id: I1e2f1fa419c16dcbf483ace7c1a362b51f0dc7bb
2012-05-01 14:15:41 +09:00
ec06215970
Remove tab key from number/phone layout of 7 inch tablet
...
Bug: 6411288
Bug: 6411588
Bug: 6411840
Change-Id: I44b358ae9c078779d6b1108281c1458387a32948
2012-05-01 12:58:59 +09:00
3287067185
Remove tab key from phone layout of 7 inch tablet
...
Bug: 6411288
Change-Id: Ie3836becf787536b7346150008053a985280f61b
2012-05-01 12:15:06 +09:00
3bb419ec18
Import translations. DO NOT MERGE
...
Change-Id: Ie86b666066f353bd16f3c8564111f8c096c32283
2012-04-30 14:22:58 -07:00
f963a462c1
Merge "Import translations. DO NOT MERGE" into jb-dev
2012-04-27 20:55:47 -07:00
c0e67ea640
Import translations. DO NOT MERGE
...
Change-Id: I34b791b8bd756e6e68e6e396e5e02bf8950398a3
2012-04-27 14:16:09 -07:00
0ab1c664c1
Avoid Resources$NotFoundException
...
bug: 6410653
Change-Id: I4263632e76b44abf8ecd9114a9eb185ad39201fd
2012-04-28 03:24:05 +09:00
7570954a18
modifications for new system volume policy.
...
The new system and UX sound volume policy makes that STREAM_SYSTEM
volume is not fixed anymore. It is tracking STREAM_RING (phones) or
STREAM_MUSIC (tablets) in a constrained range between -24dB and -6dB.
Sound Fx where previously played over STREAM_SYSTEM with a fixed
attenuation of -20dB. The default value of 5% in the keypress sound
volume setting was corresponding to -26dB, meaning 6dB below default.
Modified the default volume value to 50% so that by default, keypress sound
volume varies from -30dB to -12dB which is also 6dB below the other system
sounds.
Change-Id: I146f72275b8e88fdce5ccf8b6dae2903c27f15eb
2012-04-26 18:37:10 -07:00
681b7bd8b5
Import translations. DO NOT MERGE
...
Change-Id: I1df0104d5ec4dac73c45667c621cbb671b44e6df
2012-04-26 16:44:11 -07:00
18f0d1938a
Merge "Show settings key when noMicrophone option is enabled on PC QWERTY" into jb-dev
2012-04-26 01:41:38 -07:00
20a6dea1ca
Add a flag for bigram presence in the header
...
This is a cherry-pick of Icb602762 onto jb-dev.
Bug: 6355745
Change-Id: Icb602762bb0d81472f024fa491571062ec1fc4e9
2012-04-26 16:40:29 +09:00
329c8d7bcc
Merge "Ignore bigrams that are not also listed as unigrams" into jb-dev
2012-04-26 00:26:04 -07:00
93e122e28d
Merge "Fix potential "divided by zero" exception" into jb-dev
2012-04-26 00:21:07 -07:00
bd2ca9c021
Fix potential "divided by zero" exception
...
This change also refactors the language name selection to use text
x-scale.
Bug: 6396854
Change-Id: I31249a85bd042a93d627f40413161aef13617c87
2012-04-26 16:01:55 +09:00
9bfec98275
Merge "Increase CHAR LIMIT in some string resources" into jb-dev
2012-04-25 23:58:38 -07:00
6b006b4947
Increase CHAR LIMIT in some string resources
...
Bug: 6374565
Bug: 6381144
Change-Id: I2fff2323e8f0f79df2b71ed030a1a0953b2854c8
2012-04-26 15:38:41 +09:00
45c57dcc2d
Merge "Fix SubtypeSwitcher incomplete initialization" into jb-dev
2012-04-25 23:22:06 -07:00
44c64f46a1
Ignore bigrams that are not also listed as unigrams
...
This is a cherry pick of I14b67e51 on jb-dev
Bug: 6340915
Change-Id: Iaa512abe1b19ca640ea201f9761fd7f1416270ed
2012-04-26 15:20:30 +09:00
41398ba265
Show settings key when noMicrophone option is enabled on PC QWERTY
...
Change-Id: Ib419a597e218af347e5d5da19f5ca8b3db8548c7
2012-04-26 15:20:23 +09:00
3d407cc086
Fix SubtypeSwitcher incomplete initialization
...
Bug: 6400718
Change-Id: Id5dce156ad397b911bfeaedeeddd4aeb21a10b3a
2012-04-26 13:41:15 +09:00
27b42ced86
Fix "no language" subtype name (DO NOT MERGE)
...
* Move SubtypeLocale.get{Full,Middle,Short}DisplayName() to
LatinLeyboardView and add unit tests (SpacebarTextTests).
* Add SubtypeLocale.getSubtypeDisplayName()
This is a cherry-pick of I57420c6a from Master.
Bug: 6393865
Change-Id: I68748189c17c73984ac4ae05a5a40fb54bf46453
2012-04-26 11:50:28 +09:00
49caddbdab
Support PC QWERTY layout
...
Bug: 4460018
Change-Id: I9a29f6a322af66f6a152fa1883b3686c5f7a3328
2012-04-25 16:34:59 +09:00
cbaf6d85f1
Cancel SubtypePreference dialog properly
...
Bug: 6384416
Bug: 6387408
Change-Id: Ia7b0653a09410b42a55915815c887bf0ad56c856
2012-04-25 15:42:14 +09:00
9f0a137f82
Save & restore additional subtype dialog state when orientation is changed
...
Bug: 6384416
Change-Id: Id5fa4742ad900fafb82cc37a0bbb9f380b99254d
2012-04-25 15:29:05 +09:00
d454fcc2cf
Merge "Ignore unknown keyboard layout safely"
2012-04-24 23:22:26 -07:00
96e404310d
Ignore unknown keyboard layout safely
...
Bug: 6393755
Change-Id: I3a74b23f934cd52925026ad04647cc76de92ee07
2012-04-25 13:34:04 +09:00
b7286439f6
Fix percent sign in more keys
...
Bug: 6029665
Change-Id: I4bf0f5703d0c11d76bab478da2729b0e20fc64ea
2012-04-25 11:51:19 +09:00
da346cadb2
Merge "Import translations. DO NOT MERGE"
2012-04-24 14:21:42 -07:00
b4f5c9c088
Import translations. DO NOT MERGE
...
Change-Id: I17745dd7dbabcc6409361e1b2fa0141ff3f13e09
2012-04-24 14:17:36 -07:00
ce54a14bed
Merge "Change expandable binary dict write to a temp file first."
2012-04-24 10:54:56 -07:00
a9b2be8a81
Change expandable binary dict write to a temp file first.
...
Bug: 6380724
Change-Id: Ic1d0d902dc45ecb41a1792f33a60ab85e606fcef
2012-04-24 10:52:53 -07:00
bce2c214d1
Use HTML entity for non-ASCII unicode
...
Change-Id: If8b605778196a5c0a0205ebd49378759027ee265
2012-04-24 18:06:54 +09:00
3443f52150
Merge "Move functional keys out from rowkeys_symbols{_shift}3."
2012-04-24 00:49:38 -07:00
8e7740b28a
Merge "Add header commnets of KeyboardTextsSet.tmpl"
2012-04-24 00:49:11 -07:00
5723bedcd0
Merge "Revert keyHintLetterPadding only to apply horizontally"
2012-04-24 00:41:57 -07:00
ab771b01eb
Revert keyHintLetterPadding only to apply horizontally
...
Partially reverts the Ia3680d84.
Bug: 6356125
Change-Id: I8faa810b833cb98ce6f0f760aa1722e63475cd45
2012-04-24 16:20:47 +09:00
aaac9a5217
Add header commnets of KeyboardTextsSet.tmpl
...
Bug: 6371604
Change-Id: I1054685b9985b6923e3176679b3d95424d8114e0
2012-04-24 16:19:17 +09:00
805fed49e1
Merge "Fix binary reading code performance."
2012-04-23 23:39:37 -07:00
fe4d13cbcb
Merge "Make the "Touch again to save" hint text touchable."
2012-04-23 23:20:49 -07:00
1d80a7f395
Fix binary reading code performance.
...
This is not the Right fix ; the Right fix would be to read
the file in a buffered way. However this delivers tolerable
performance for a minimal amount of code changes.
We may want to skip submitting this patch, but keep it around
in case we need to use the functionality until we have a good
patch.
Change-Id: I1ba938f82acfd9436c3701d1078ff981afdbea60
2012-04-24 15:16:17 +09:00
0b6f6729d2
Move functional keys out from rowkeys_symbols{_shift}3.
...
Change-Id: Iee5e7e93e5f319551a8ad28c58813c00fc713308
2012-04-24 14:25:27 +09:00
cbebbaf065
Merge "Fix a bug where a node size would be seen as increasing."
2012-04-23 22:19:19 -07:00
a64a1a46e4
Fix a bug where a node size would be seen as increasing.
...
The core reason for this is quite shrewd. When a word is a bigram
of itself, the corresponding chargroup will have a bigram referring
to itself. When computing bigram offsets, we use cached addresses of
chargroups, but we compute the size of the node as we go. Hence, a
discrepancy may happen between the base offset as seen by the bigram
(which uses the recomputed value) and the target offset (which uses
the cached value).
When this happens, the cached node address is too large. The relative
offset is negative, which is expected, since it points to this very
charnode whose start is a few bytes earlier. But since the cached
address is too large, the offset is computed as smaller than it should
be.
On the next pass, the cache has been refreshed with the newly computed
size and the seen offset is now correct (or at least, much closer to
correct). The correct value is larger than the previously computed
offset, which was too small. If it happens that it crosses the -255 or
-65335 boundary, the address will be seen as needing 1 more byte than
previously computed. If this is the only change in size of this node,
the node will be seen as having a larger size than previously, which
is unexpected. Debug code was catching this and crashing the program.
So this case is very rare, but in an even rarer occurence, it may
happen that in the same node, another chargroup happens to decrease
it size by the same amount. In this case, the node may be seen as
having not been modified. This is probably extremely rare. If on
top of this, it happens that no other node has been modified, then
the file may be seen as complete, and the discrepancy left as is
in the file, leading to a broken file. The probability that this
happens is abyssally low, but the bug exists, and the current debug
code would not have caught this.
To further catch similar bugs, this change also modifies the test
that decides if the node has changed. On grounds that all components
of a node may only decrease in size with each successive pass, it's
theoritically safe to assume that the same size means the node
contents have not changed, but in case of a bug like the bug above
where a component wrongly grows while another shrinks and both cancel
each other out, the new code will catch this. Also, this change adds
a check against the number of passses, to avoid infinite loops in
case of a bug in the computation code.
This change fixes this bug by updating the cached address of each
chargroup as we go. This eliminates the discrepancy and fixes the
bug.
Bug: 6383103
Change-Id: Ia3f450e22c87c4c193cea8ddb157aebd5f224f01
2012-04-24 14:04:02 +09:00
9f763d1445
Make the "Touch again to save" hint text touchable.
...
Bug: 6355346
Change-Id: I96933719cc94f25e6c7ecb1d6345c11b6acc4134
2012-04-24 13:44:14 +09:00
3e3bb36f1f
Fix NPE in AdditionalSubtypeSettings
...
Bug: 6384416
Change-Id: I878071b8b78acce51649f9637b59830ab681c696
2012-04-24 11:01:45 +09:00
fa1affbaec
Merge "Fix a bug where two spaces would be added instead of one"
2012-04-23 17:03:32 -07:00
5ee0ee0dbe
Merge "Fix a bug where a batch edit would not be started."
2012-04-23 17:02:41 -07:00
87f7fa12db
Merge "Pass words as int[] to the native code."
2012-04-23 17:02:26 -07:00
7f45ec7bb8
Import translations. DO NOT MERGE
...
Change-Id: I11d27b3c5c1005bd6679f59804f217640f8d5992
2012-04-23 14:03:26 -07:00
c04075b138
Cleanup <include/> and etc. in keyboard XML
...
* Remove keyXPos and keyWidth from key_*.xml and make it more generic.
* Add keyXPos and keyWidth to <include/> generalized key_*.xml.
* Remove zero width <Spacer/> and fold into successive <include/>.
Change-Id: I4b5c02a165ba0bc9ef8741be0b4938c1efaf5e27
2012-04-24 01:47:03 +09:00
9a7cdb2051
Merge "Remove alt-code-while-typing from tablet"
2012-04-23 09:37:15 -07:00
bebcae8ff5
Merge "Binary bigram lookup checks both uppercase and lowercase when previous word is uppercase."
2012-04-23 09:06:05 -07:00
608691edb8
Merge "Fix key preview when shifted hint letter is activated"
2012-04-23 07:43:40 -07:00
0b27e788fe
Remove alt-code-while-typing from tablet
...
Change-Id: I4471d10e3f7c681c27805b966869c0b47508329f
2012-04-23 20:25:16 +09:00
9dc1200b9b
Fix key preview when shifted hint letter is activated
...
Change-Id: I70d2627318d21eb612c3c3fee2ce8e80555dba12
2012-04-23 18:50:07 +09:00
551612dd9e
Fix a bug where two spaces would be added instead of one
...
Bug: 6378291
Change-Id: Id2453333ae16146f816faf0eb68baa8ea1dd106a
2012-04-23 18:15:51 +09:00
96fb3094aa
Fix a bug where a batch edit would not be started.
...
This would end up in TextView sometimes calling onUpdateSelection
multiple times (this is the correct behavior for TextView). We now
commit the space and the word in a batch edit, and we only get
onUpdateSelection once.
Bug: 6300527
Change-Id: I9579f3d8f5320c1cc24a7a42f19db8e105eb090d
2012-04-23 17:45:50 +09:00
4849634c70
Separate Hebrew row4 on tablet
...
Change-Id: Iea17aa7cae60e131d4b5bfeb78d287915fd04164
2012-04-23 16:41:36 +09:00
522a04ea5b
Pass words as int[] to the native code.
...
We need to get the bigrams during the call to getSuggestions for
bug#6313806. We already give an int[] to getSuggestions and we
wanted to get rid of char[]'s anyway because it doesn't work with
surrogate pairs, so here we go.
Bug: 6313806
Change-Id: I56ce99f1db6b3302cdf42f0527343bded837091e
2012-04-23 16:05:36 +09:00
5f1d71fbc8
Modularize shortcut key on 10 inch tablet
...
Change-Id: Ie4cace33f8bcffd092bea7ce2da0cee5a1cbd685
2012-04-23 15:33:59 +09:00
b560a6cfee
Support Colemak layout
...
Bug: 4460018
Change-Id: I60c3dfaf205c95b92a54022f0256c33f644c8b10
2012-04-23 15:19:37 +09:00
e060d1a540
Merge "Fix using keyboard layout display name in custom input style spinner"
2012-04-22 23:16:57 -07:00
a245be6819
Fix using keyboard layout display name in custom input style spinner
...
Change-Id: I80626591574aa9995011202cf868f9c2c5168303
2012-04-23 13:54:58 +09:00
0df78d46da
Use the best matching cached dictionary for each category
...
Bug: 6327270
Change-Id: I5a0e732c8a3fd55fd8ac3c8fe1c58e7f91555d97
2012-04-23 12:37:52 +09:00
Jean Chalard
Tadashi G. Takaoka
satok
Ken Wakasa
Eric Fischer
alanv
Charles Chen
Svetoslav Ganov
Eric Laurent
Tom Ouyang