Commit graph

31695 commits

Author SHA1 Message Date
Keisuke Kuroyanagi
c548b35b6a am 5717c63a: Fix possible NPE in DictionaryFacilitatorForSuggest.
* commit '5717c63a2b3876716986b24c86cc6c564c38e720':
  Fix possible NPE in DictionaryFacilitatorForSuggest.
2014-01-10 04:50:25 -08:00
Jean Chalard
7294cc5bfe Merge "Fix a test." 2014-01-10 12:47:41 +00:00
Keisuke Kuroyanagi
5717c63a2b Fix possible NPE in DictionaryFacilitatorForSuggest.
Change-Id: I57792b7417b5f1acbb99e6ea60250eb44b193785
2014-01-10 21:42:08 +09:00
Jean Chalard
7b6e999cd1 Fix a test.
Bug: 12483313
Change-Id: Ia811d614b9260367871bc5717f587538adf46789
2014-01-10 21:39:43 +09:00
Jean Chalard
b19c09797a am db0adf86: Merge "[IL55] Remove a useless argument."
* commit 'db0adf86a4c615ca8838238a1c318b1fbc05111e':
  [IL55] Remove a useless argument.
2014-01-10 03:37:54 -08:00
Keisuke Kuroyanagi
c35d5abe6f am eb66f190: Merge "Check corpus handles during startup for personalization."
* commit 'eb66f1906d4269dd5c10ab83c86e3885f140cc4f':
  Check corpus handles during startup for personalization.
2014-01-10 03:37:47 -08:00
Jean Chalard
db0adf86a4 Merge "[IL55] Remove a useless argument." 2014-01-10 11:36:01 +00:00
Keisuke Kuroyanagi
eb66f1906d Merge "Check corpus handles during startup for personalization." 2014-01-10 11:34:39 +00:00
Jean Chalard
6c24b91601 [IL55] Remove a useless argument.
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
2014-01-10 20:28:50 +09:00
Keisuke Kuroyanagi
eb28bac542 Check corpus handles during startup for personalization.
Bug: 12479792
Change-Id: I62fd75d4bebd28afebd9631e865f5d59385511e7
2014-01-10 20:28:30 +09:00
Keisuke Kuroyanagi
7110ce3339 am 4db09448: Merge "Boundary check for ProximityInfoState::getProximityTypeG()."
* commit '4db09448e98b81fe285d685c11988beed55b0208':
  Boundary check for ProximityInfoState::getProximityTypeG().
2014-01-10 03:26:21 -08:00
Keisuke Kuroyanagi
4db09448e9 Merge "Boundary check for ProximityInfoState::getProximityTypeG()." 2014-01-10 11:24:22 +00:00
Keisuke Kuroyanagi
84c52a3c81 Boundary check for ProximityInfoState::getProximityTypeG().
Bug: 12481052
Change-Id: Ic0b64d2fa17eb8f65f3ad1a7b468cdf6dddf7e70
2014-01-10 20:15:36 +09:00
Jean Chalard
1255712a17 am 4be91376: Merge "[IL54.5] Use the cursor pos estimate, not the last value"
* commit '4be9137609913cb1e3769b3f47b925b649ca91f8':
  [IL54.5] Use the cursor pos estimate, not the last value
2014-01-10 02:48:49 -08:00
Jean Chalard
4be9137609 Merge "[IL54.5] Use the cursor pos estimate, not the last value" 2014-01-10 10:46:27 +00:00
Jean Chalard
a224aafea3 [IL54.5] Use the cursor pos estimate, not the last value
For edit tasks, the estimate is actually the right thing to use.
This is really dangerous, but it will get rid of pretty much all
race conditions.

Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
2014-01-10 19:08:47 +09:00
Keisuke Kuroyanagi
75950a7867 am f96e0f07: Merge "Periodic wipe of the personalization dict."
* commit 'f96e0f07af8230a43d733ee7a19c08c205197037':
  Periodic wipe of the personalization dict.
2014-01-10 01:42:00 -08:00
Keisuke Kuroyanagi
f96e0f07af Merge "Periodic wipe of the personalization dict." 2014-01-10 09:31:22 +00:00
Jean Chalard
a9d45c9bf4 am ecf46df2: [IL54] Add a mirror method to fix the cursor pos estimate
* commit 'ecf46df22683b997311ba77b34b33dffa8be43c0':
  [IL54] Add a mirror method to fix the cursor pos estimate
2014-01-09 23:39:23 -08:00
Keisuke Kuroyanagi
ba07df7fc1 Periodic wipe of the personalization dict.
Bug: 12216453

Change-Id: Ie59dd19c044e9b1eb9b8bd805366200737ea506a
2014-01-10 16:30:59 +09:00
Jean Chalard
ecf46df226 [IL54] Add a mirror method to fix the cursor pos estimate
This just mirrors what InputLogic#tryFixLyingCursorPosition
is doing. That method will go away in the next change.

Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
2014-01-10 16:05:02 +09:00
Jean Chalard
1124cff216 am 6fbe83be: [IL53] Fix a wrong test.
* commit '6fbe83be7af6b15df3ed915b408c8179ca01c0cd':
  [IL53] Fix a wrong test.
2014-01-09 22:52:30 -08:00
Jean Chalard
6fbe83be7a [IL53] Fix a wrong test.
This test was intended only for cases without a selection, and as
a safety net for cases where the app would pretend the cursor
is at N but we can get P chars from the editor where P > N.

When there is a selection, this is wrong. In the practice it works
because these values are not used in this case, but it's still wrong.

The case where P > N is arguable, but actually I see little reason
to trust the getTextBeforeCursor() method more than the
onUpdate selection method. Plus in the practice, I don't think
we are aware of any app with this bug, and it's probably not a
great idea to be too robust about this as it may encourage wrong
values sent to onUpdateSelection.

Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
2014-01-10 15:21:20 +09:00
Jean Chalard
f36b520c20 am 958e4520: Merge "Fix an NPE."
* commit '958e4520250e8f2ddcbbbd56afc713262bf1a9f1':
  Fix an NPE.
2014-01-09 21:16:17 -08:00
Jean Chalard
958e452025 Merge "Fix an NPE." 2014-01-10 05:13:47 +00:00
Jean Chalard
e1de87ae69 Fix an NPE.
Bug: 12397228
Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
2014-01-10 13:46:37 +09:00
Jean Chalard
f43a9a7eb2 am 84a3047e: Fix build.
* commit '84a3047e801923bd486b0cff2f9ea0de25d7e3ba':
  Fix build.
2014-01-09 20:13:50 -08:00
Jean Chalard
84a3047e80 Fix build.
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
2014-01-10 12:18:26 +09:00
Tadashi G. Takaoka
34e4149068 am ee35e69e: Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
* commit 'ee35e69eae734448d0aa90e46037273cc3f1e6ad':
  Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
2014-01-09 02:18:36 -08:00
Tadashi G. Takaoka
f6d219daf0 am 494e2d6c: Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
* commit '494e2d6c17cdbf27615a2fbc02b12d2562bf7cd3':
  Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
2014-01-09 02:18:27 -08:00
Tadashi G. Takaoka
ee35e69eae Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
This change must be checked in together with Iec437d6df0.

Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
2014-01-09 19:05:09 +09:00
Tadashi G. Takaoka
b7b2411817 am d7660c6f: Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode"
* commit 'd7660c6f56a65b835ad178c2860f36d273655b14':
  Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode
2014-01-09 01:45:12 -08:00
Tadashi G. Takaoka
ff6735e481 am c912b222: Merge "Add American typography boolean to SpacingAndPunctuations"
* commit 'c912b2228a340354d7f951aad25c0bdfc1dee323':
  Add American typography boolean to SpacingAndPunctuations
2014-01-09 01:45:05 -08:00
Tadashi G. Takaoka
494e2d6c17 Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
2014-01-09 18:33:25 +09:00
Tadashi G. Takaoka
d7660c6f56 Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode" 2014-01-09 09:31:32 +00:00
Tadashi G. Takaoka
c912b2228a Merge "Add American typography boolean to SpacingAndPunctuations" 2014-01-09 09:31:24 +00:00
Tadashi G. Takaoka
0a75cf51af Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
2014-01-09 18:19:17 +09:00
Tadashi G. Takaoka
860c3b8e8c Add American typography boolean to SpacingAndPunctuations
Change-Id: Ic2663eaef38fbe7c5bd1fb3a81771e94c2d4de52
2014-01-09 18:17:29 +09:00
Keisuke Kuroyanagi
00b77f0b81 am 85040b7c: Merge "Fix a unit test in InputLogicTests."
* commit '85040b7cde2a8d7165bcfff7101ac09caea2af52':
  Fix a unit test in InputLogicTests.
2014-01-08 23:30:04 -08:00
Keisuke Kuroyanagi
85040b7cde Merge "Fix a unit test in InputLogicTests." 2014-01-09 07:28:30 +00:00
Keisuke Kuroyanagi
e4ae5855cb Fix a unit test in InputLogicTests.
Change-Id: I63a20bb2e4b3c39495fade6cae3a14fdd11ca48c
2014-01-09 16:23:43 +09:00
Yohei Yukawa
21ebd83d6f am 6c326caa: A style fix
* commit '6c326caa4f37eb29774aeb82a39c56df62c7f568':
  A style fix
2014-01-08 23:06:31 -08:00
Yohei Yukawa
6c326caa4f A style fix
Just a style fix to follow up the previous commit.

BUG: 11439600
Change-Id: Ib7a4654627a6fc22d86f2097f86f001bd76426e9
2014-01-09 15:54:47 +09:00
Keisuke Kuroyanagi
de63718309 am b30f7e4b: Merge "Check whether the word is OOV or not for amanatto update."
* commit 'b30f7e4bceefc4f30c7b942675cc6af5f6d8d852':
  Check whether the word is OOV or not for amanatto update.
2014-01-08 22:26:31 -08:00
Keisuke Kuroyanagi
b30f7e4bce Merge "Check whether the word is OOV or not for amanatto update." 2014-01-09 06:24:17 +00:00
Jean Chalard
91cc895ce9 am eab4d252: Merge "Remove some warnings"
* commit 'eab4d252103741eb9487b4e70534d2ec3f1c64a4':
  Remove some warnings
2014-01-08 21:48:24 -08:00
Jean Chalard
eab4d25210 Merge "Remove some warnings" 2014-01-09 05:45:10 +00:00
Yohei Yukawa
828f2a570a am c1f2986a: Merge "Trigger haptic feedback at touch down on the EmojiPalettesView"
* commit 'c1f2986a72dfaa18ed5438bf03ce9c40cae973c0':
  Trigger haptic feedback at touch down on the EmojiPalettesView
2014-01-08 21:21:32 -08:00
Yohei Yukawa
c1f2986a72 Merge "Trigger haptic feedback at touch down on the EmojiPalettesView" 2014-01-09 05:19:37 +00:00
Jean Chalard
b11339b3ab Remove some warnings
Change-Id: I5cfa0d2fccc139bd6c45c5590a68c3e0c90534b8
2014-01-09 14:04:34 +09:00