Commit Graph

30273 Commits (f58a96c977648cb720a748ad56be4001090f062a)

Author SHA1 Message Date
Jean Chalard 6fbe83be7a [IL53] Fix a wrong test.
This test was intended only for cases without a selection, and as
a safety net for cases where the app would pretend the cursor
is at N but we can get P chars from the editor where P > N.

When there is a selection, this is wrong. In the practice it works
because these values are not used in this case, but it's still wrong.

The case where P > N is arguable, but actually I see little reason
to trust the getTextBeforeCursor() method more than the
onUpdate selection method. Plus in the practice, I don't think
we are aware of any app with this bug, and it's probably not a
great idea to be too robust about this as it may encourage wrong
values sent to onUpdateSelection.

Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
2014-01-10 15:21:20 +09:00
Jean Chalard f36b520c20 am 958e4520: Merge "Fix an NPE."
* commit '958e4520250e8f2ddcbbbd56afc713262bf1a9f1':
  Fix an NPE.
2014-01-09 21:16:17 -08:00
Jean Chalard 958e452025 Merge "Fix an NPE." 2014-01-10 05:13:47 +00:00
Jean Chalard e1de87ae69 Fix an NPE.
Bug: 12397228
Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
2014-01-10 13:46:37 +09:00
Jean Chalard f43a9a7eb2 am 84a3047e: Fix build.
* commit '84a3047e801923bd486b0cff2f9ea0de25d7e3ba':
  Fix build.
2014-01-09 20:13:50 -08:00
Jean Chalard 84a3047e80 Fix build.
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
2014-01-10 12:18:26 +09:00
Tadashi G. Takaoka 34e4149068 am ee35e69e: Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
* commit 'ee35e69eae734448d0aa90e46037273cc3f1e6ad':
  Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
2014-01-09 02:18:36 -08:00
Tadashi G. Takaoka f6d219daf0 am 494e2d6c: Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
* commit '494e2d6c17cdbf27615a2fbc02b12d2562bf7cd3':
  Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
2014-01-09 02:18:27 -08:00
Tadashi G. Takaoka ee35e69eae Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
This change must be checked in together with Iec437d6df0.

Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
2014-01-09 19:05:09 +09:00
Tadashi G. Takaoka b7b2411817 am d7660c6f: Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode"
* commit 'd7660c6f56a65b835ad178c2860f36d273655b14':
  Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode
2014-01-09 01:45:12 -08:00
Tadashi G. Takaoka ff6735e481 am c912b222: Merge "Add American typography boolean to SpacingAndPunctuations"
* commit 'c912b2228a340354d7f951aad25c0bdfc1dee323':
  Add American typography boolean to SpacingAndPunctuations
2014-01-09 01:45:05 -08:00
Tadashi G. Takaoka 494e2d6c17 Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
2014-01-09 18:33:25 +09:00
Tadashi G. Takaoka d7660c6f56 Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode" 2014-01-09 09:31:32 +00:00
Tadashi G. Takaoka c912b2228a Merge "Add American typography boolean to SpacingAndPunctuations" 2014-01-09 09:31:24 +00:00
Tadashi G. Takaoka 0a75cf51af Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
2014-01-09 18:19:17 +09:00
Tadashi G. Takaoka 860c3b8e8c Add American typography boolean to SpacingAndPunctuations
Change-Id: Ic2663eaef38fbe7c5bd1fb3a81771e94c2d4de52
2014-01-09 18:17:29 +09:00
Keisuke Kuroyanagi 00b77f0b81 am 85040b7c: Merge "Fix a unit test in InputLogicTests."
* commit '85040b7cde2a8d7165bcfff7101ac09caea2af52':
  Fix a unit test in InputLogicTests.
2014-01-08 23:30:04 -08:00
Keisuke Kuroyanagi 85040b7cde Merge "Fix a unit test in InputLogicTests." 2014-01-09 07:28:30 +00:00
Keisuke Kuroyanagi e4ae5855cb Fix a unit test in InputLogicTests.
Change-Id: I63a20bb2e4b3c39495fade6cae3a14fdd11ca48c
2014-01-09 16:23:43 +09:00
Yohei Yukawa 21ebd83d6f am 6c326caa: A style fix
* commit '6c326caa4f37eb29774aeb82a39c56df62c7f568':
  A style fix
2014-01-08 23:06:31 -08:00
Yohei Yukawa 6c326caa4f A style fix
Just a style fix to follow up the previous commit.

BUG: 11439600
Change-Id: Ib7a4654627a6fc22d86f2097f86f001bd76426e9
2014-01-09 15:54:47 +09:00
Keisuke Kuroyanagi de63718309 am b30f7e4b: Merge "Check whether the word is OOV or not for amanatto update."
* commit 'b30f7e4bceefc4f30c7b942675cc6af5f6d8d852':
  Check whether the word is OOV or not for amanatto update.
2014-01-08 22:26:31 -08:00
Keisuke Kuroyanagi b30f7e4bce Merge "Check whether the word is OOV or not for amanatto update." 2014-01-09 06:24:17 +00:00
Jean Chalard 91cc895ce9 am eab4d252: Merge "Remove some warnings"
* commit 'eab4d252103741eb9487b4e70534d2ec3f1c64a4':
  Remove some warnings
2014-01-08 21:48:24 -08:00
Jean Chalard eab4d25210 Merge "Remove some warnings" 2014-01-09 05:45:10 +00:00
Yohei Yukawa 828f2a570a am c1f2986a: Merge "Trigger haptic feedback at touch down on the EmojiPalettesView"
* commit 'c1f2986a72dfaa18ed5438bf03ce9c40cae973c0':
  Trigger haptic feedback at touch down on the EmojiPalettesView
2014-01-08 21:21:32 -08:00
Yohei Yukawa c1f2986a72 Merge "Trigger haptic feedback at touch down on the EmojiPalettesView" 2014-01-09 05:19:37 +00:00
Jean Chalard b11339b3ab Remove some warnings
Change-Id: I5cfa0d2fccc139bd6c45c5590a68c3e0c90534b8
2014-01-09 14:04:34 +09:00
Jean Chalard 738807fdc5 am d3e78fc5: Merge "Fix a bug where changing auto-shift would cancel autorepeat."
* commit 'd3e78fc5ce8be694bd97e6580d761f3e4ec6e519':
  Fix a bug where changing auto-shift would cancel autorepeat.
2014-01-08 20:56:20 -08:00
Jean Chalard d3e78fc5ce Merge "Fix a bug where changing auto-shift would cancel autorepeat." 2014-01-09 04:53:34 +00:00
Baligh Uddin 0b3ed3b43e am 941a4540: (-s ours) Import translations. DO NOT MERGE
* commit '941a4540bc648f329d3dd8e357d33ccd80694679':
  Import translations. DO NOT MERGE
2014-01-08 20:21:24 -08:00
Jean Chalard 5cbda70956 Fix a bug where changing auto-shift would cancel autorepeat.
Bug: 12453966
Change-Id: Idd65f732e2de0a7309e08315893c28cca63732c5
2014-01-09 12:57:10 +09:00
Yohei Yukawa df10aeb1da Trigger haptic feedback at touch down on the EmojiPalettesView
EmojiPalettesView triggers the haptic feedback at the timing of touch-up rather than touch-down.
This patch set changes the timing to touch-up so that the UX on the EmojiPalettesView can be consistent with normal keyboard layouts.

This patch set also fixes the missing haptic feedback from facemarks such as ":-)".

Bug: 11439600
Change-Id: I22245946712bd1c36226786d6ff81e3b563f7ef7
2014-01-09 12:27:31 +09:00
Baligh Uddin 941a4540bc Import translations. DO NOT MERGE
Change-Id: Ia2d0f4528529df463307e1706cd4d7265b3958c1
Auto-generated-cl: translation import
2014-01-08 13:45:51 -08:00
Baligh Uddin 87e0a5c89e Import translations. DO NOT MERGE
Change-Id: I5a8ed486c75c319212cfa5d831ccbca3f10acd26
Auto-generated-cl: translation import
2014-01-08 13:44:53 -08:00
Keisuke Kuroyanagi 05113c1847 Check whether the word is OOV or not for amanatto update.
Bug: 11736529
Change-Id: I27973212da7e922b2185dbb4febfb5bb4dfbdcbb
2014-01-08 21:02:35 +09:00
Keisuke Kuroyanagi 00183a8a05 am 5742a415: Merge "Make reloadMainDict() private."
* commit '5742a415f37a3f3d4ddba4c7cc0b47385db7ecc7':
  Make reloadMainDict() private.
2014-01-08 03:05:10 -08:00
Keisuke Kuroyanagi 5742a415f3 Merge "Make reloadMainDict() private." 2014-01-08 11:03:02 +00:00
Keisuke Kuroyanagi 9f1fe87580 Make reloadMainDict() private.
Bug: 8187060
Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
2014-01-08 18:59:43 +09:00
Jean Chalard cb617344a7 am b90fa0fb: Revert "Revert "Separate spacing and punctuation related settings values""
* commit 'b90fa0fb2ce195cfaec878dea9702261290176c2':
  Revert "Revert "Separate spacing and punctuation related settings values""
2014-01-08 01:43:07 -08:00
Jean Chalard 3d38accd1f am e5cdcaff: Fix a race condition, take 2.
* commit 'e5cdcaff658f5366621115a728cb683eab5fda0a':
  Fix a race condition, take 2.
2014-01-08 01:43:00 -08:00
Jean Chalard efd575919b am 1e7f2809: Merge "Revert "Separate spacing and punctuation related settings values""
* commit '1e7f2809d2ec544b07956bdbe89c905c981b75fc':
  Revert "Separate spacing and punctuation related settings values"
2014-01-08 01:42:52 -08:00
Jean Chalard 3cabb6dac1 am d4843c25: Merge "Revert "Fix a race condition, take 2.""
* commit 'd4843c25e2b9f7e7c7c972af0cb22aac89e15d7d':
  Revert "Fix a race condition, take 2."
2014-01-08 01:42:42 -08:00
Jean Chalard b90fa0fb2c Revert "Revert "Separate spacing and punctuation related settings values""
This reverts commit 8bc427799a.

Change-Id: I34f509998afdb1a7c120fbfdb9f0a1b188224a4d
2014-01-08 18:08:01 +09:00
Jean Chalard e5cdcaff65 Fix a race condition, take 2.
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
2014-01-08 18:04:44 +09:00
Jean Chalard 1e7f2809d2 Merge "Revert "Separate spacing and punctuation related settings values"" 2014-01-08 09:03:15 +00:00
Jean Chalard 8bc427799a Revert "Separate spacing and punctuation related settings values"
This is conflicting with later changes. Temporary revert for cherry-pick.

This reverts commit 0b593ce858.

Change-Id: Id53eadb023a950cfcca496c0cfbfe583c7ec7b8c
2014-01-08 09:00:45 +00:00
Jean Chalard d4843c25e2 Merge "Revert "Fix a race condition, take 2."" 2014-01-08 09:00:18 +00:00
Jean Chalard a247264dc6 Revert "Fix a race condition, take 2."
Conflicts prevent this to be cherry-picked.

This reverts commit dd3d697a6e.

Change-Id: Ib97fae2234633b4bb27d611f48a79060db9ab16f
2014-01-08 08:59:26 +00:00
Jean Chalard 83d761456a am ff7103d3: Merge "Fix a race condition, take 2."
* commit 'ff7103d356819952bf040ab851f96a30ed0d3abc':
  Fix a race condition, take 2.
2014-01-08 00:37:15 -08:00