Commit graph

30770 commits

Author SHA1 Message Date
Tadashi G. Takaoka
ef8a03685f Fix null KeyDetector reference
This change must be checked in together with I737c266c45.

Bug: 13011041
Change-Id: Ia3d25be6de47fa16ab7156a25641e53a23948ff4
2014-02-14 11:42:09 +09:00
Yohei Yukawa
f45b3b98cf am 362ab36c: Fix a null object reference crash on Emoji Palette
* commit '362ab36cf009d724768e742c3b2e264387efc521':
  Fix a null object reference crash on Emoji Palette
2014-02-13 17:56:36 -08:00
Yohei Yukawa
362ab36cf0 Fix a null object reference crash on Emoji Palette
Do nothing if the current EmojiPageKeyboardView is null.

BUG: 13006906
Change-Id: I169b70122ec939075b5be033953b48762fd528fc
2014-02-14 10:36:31 +09:00
Yohei Yukawa
a1e6d5cb5f am 5f9f4b92: Merge "Fix indent."
* commit '5f9f4b929b246491865553758fe55d58e720ca44':
  Fix indent.
2014-02-13 17:28:34 -08:00
Yohei Yukawa
5f9f4b929b Merge "Fix indent." 2014-02-14 01:26:48 +00:00
Keisuke Kuroyanagi
a000a32c80 Fix reading uninitialized memory.
Bug: 12967899

Change-Id: Ia17e4ca9dd8c1e0b24b0fb7e73d07b97c5d81c0c
2014-02-13 21:18:02 +09:00
Tadashi G. Takaoka
e6cd4aba1e am bd0591ce: Merge "Make InputLogicTest more robust"
* commit 'bd0591ce62b3b6f084ad560ddbddf20505d3157d':
  Make InputLogicTest more robust
2014-02-13 02:47:35 -08:00
Tadashi G. Takaoka
bd0591ce62 Merge "Make InputLogicTest more robust" 2014-02-13 10:44:44 +00:00
Tadashi G. Takaoka
da973e75dc Make InputLogicTest more robust
Change-Id: I134f14971126cbeed05b472c08747f2b88ad30e6
2014-02-13 19:38:51 +09:00
Jean Chalard
2ae245ffd3 am 5dc0d405: Merge "Clean-up follow-up to I3ecc8496"
* commit '5dc0d405b4912ba60dd2461549c24c0254faa27a':
  Clean-up follow-up to I3ecc8496
2014-02-13 02:29:12 -08:00
Jean Chalard
5dc0d405b4 Merge "Clean-up follow-up to I3ecc8496" 2014-02-13 10:26:48 +00:00
Jean Chalard
2d68f4b392 Clean-up follow-up to I3ecc8496
Change-Id: I8db952a4152dab027e4f34bc5270bfca508d154d
2014-02-13 19:18:29 +09:00
Jean Chalard
ef30447d2a am 5e099580: Merge "Backward compatibility hack : send delete when empty."
* commit '5e099580565039dfd19cc23eff5e086202473fcd':
  Backward compatibility hack : send delete when empty.
2014-02-13 02:13:00 -08:00
Jean Chalard
5e09958056 Merge "Backward compatibility hack : send delete when empty." 2014-02-13 10:09:41 +00:00
Jean Chalard
2c48846903 Backward compatibility hack : send delete when empty.
Some apps depend on the keyboard sending something to them
when the text is empty. This is BROKEN. Your app must not lie
to the keyboard about what is before the cursor. If there is something
to delete, you must not pretend there is not and try to catch some
delete event. This will result in a bad user experience. This will not
work with all IMEs. If your app needs this broken behavior, you're
doing it wrong. Seriously guys, we're not in the era of typewriters
any more, there are touch screens, there are gestures, there is
accessibility, there are many innovative IMEs that don't have
keys. Do *NOT* rely on key events.

This change implements an ugly hack so that these broken apps
may continue half-working with LatinIME. We are very unhappy
about this.

Bug: 12998568
Change-Id: Ia62ae2fbee4fee65b463acf3a79aafcfd0defa1d
2014-02-13 18:41:54 +09:00
Tadashi G. Takaoka
8950f96b84 am 7ae6721f: Remove RTL aware !code and add corresponding !text
* commit '7ae6721ffad1e79ee446de87d13f18a27619830b':
  Remove RTL aware !code and add corresponding !text
2014-02-13 01:37:30 -08:00
Tadashi G. Takaoka
64e4e1883b am 3cb77678: Fix Armenian switch to alphabet key text
* commit '3cb77678f52d343aff03cd9facf5379c7ef7e519':
  Fix Armenian switch to alphabet key text
2014-02-13 01:37:28 -08:00
Tadashi G. Takaoka
7ae6721ffa Remove RTL aware !code and add corresponding !text
Change-Id: I9021c8fa1cf2d4ac07579237a939c15551509a0b
2014-02-13 17:32:09 +09:00
Tadashi G. Takaoka
3cb77678f5 Fix Armenian switch to alphabet key text
Bug: 7963631
Change-Id: If5768c761ec96d3404900b0c017abc2317cce8d4
2014-02-13 17:26:16 +09:00
Tadashi G. Takaoka
f676586b85 am 0af6d988: Merge "Optimize KeyboardTextsTable"
* commit '0af6d988a7dc0ccce2ba7d0c4cbe4cc0c9c0c921':
  Optimize KeyboardTextsTable
2014-02-13 00:25:48 -08:00
Tadashi G. Takaoka
0af6d988a7 Merge "Optimize KeyboardTextsTable" 2014-02-13 08:22:58 +00:00
Tadashi G. Takaoka
0fe4d00068 Optimize KeyboardTextsTable
This change counts all occurrences of each string resource and sort
those in descending order of the occurrence.

Change-Id: I726402157feb0d436a54bd0a7252acd17fd711f9
2014-02-13 17:11:00 +09:00
Tadashi G. Takaoka
8cdc727346 am 36b8962a: Merge "Fix UserHistoryDictionaryTests"
* commit '36b8962a9ae063e51567ccae25d81b841cb322f0':
  Fix UserHistoryDictionaryTests
2014-02-12 23:52:10 -08:00
Tadashi G. Takaoka
36b8962a9a Merge "Fix UserHistoryDictionaryTests" 2014-02-13 07:49:51 +00:00
Tadashi G. Takaoka
6f028d243d am 32c8d58c: Merge "Fix showing all suggestions when the top suggestion is long"
* commit '32c8d58cef6ef9c55e8c4362da7ab1d4f9942d37':
  Fix showing all suggestions when the top suggestion is long
2014-02-12 23:19:58 -08:00
Tadashi G. Takaoka
32c8d58cef Merge "Fix showing all suggestions when the top suggestion is long" 2014-02-13 07:17:31 +00:00
Tadashi G. Takaoka
0cda0e8a9c Fix UserHistoryDictionaryTests
Change-Id: I5f2f555f9c3f471545921ef80e4cf528976be837
2014-02-13 16:16:44 +09:00
Baligh Uddin
552d5e9d0e am d23cef69: (-s ours) Merge "Import translations. DO NOT MERGE"
* commit 'd23cef69c6f4f83389a00c2a7f33d25ad50f73b5':
  Import translations. DO NOT MERGE
2014-02-12 22:48:02 -08:00
Baligh Uddin
9819bb7c2e Merge "Import translations. DO NOT MERGE" into jb-ub-latinimegoogle 2014-02-13 06:43:32 +00:00
Baligh Uddin
d23cef69c6 Merge "Import translations. DO NOT MERGE" 2014-02-13 06:43:25 +00:00
Tadashi G. Takaoka
4f8a8f125e Fix showing all suggestions when the top suggestion is long
This change also fixes Bug#12982404; displays the suggestion word
using entire suggestions strip if there is only one suggestion.

Bug: 12564279
Bug: 12982404
Change-Id: I51806b90c3ee34a2072880245d4e33f7be273c8f
2014-02-13 15:22:36 +09:00
Jean Chalard
2311c4b976 am e0a42568: Merge "Fix a test."
* commit 'e0a425681c2902b463e57c55a4c4e9d6b3dc7311':
  Fix a test.
2014-02-12 21:22:57 -08:00
Jean Chalard
e0a425681c Merge "Fix a test." 2014-02-13 05:20:58 +00:00
Jean Chalard
542d21e124 am 85f6edba: Merge "Fix a failing test."
* commit '85f6edbaba0a8ce54257ca79d18b9c6ab241558c':
  Fix a failing test.
2014-02-12 21:02:42 -08:00
Jean Chalard
cf03ff02b1 Fix a test.
This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.

Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
2014-02-13 14:01:37 +09:00
Jean Chalard
85f6edbaba Merge "Fix a failing test." 2014-02-13 04:59:39 +00:00
Tadashi G. Takaoka
d360816f43 am 8dd47029: Merge "Refactor dictionary constructor"
* commit '8dd47029f129cf7077c091170a8f7eeb88dd0ccf':
  Refactor dictionary constructor
2014-02-12 20:58:18 -08:00
Tadashi G. Takaoka
8dd47029f1 Merge "Refactor dictionary constructor" 2014-02-13 04:55:16 +00:00
Jean Chalard
92e772e5df am c3cfabd0: Merge "Dump settings."
* commit 'c3cfabd0ebdaf51251e4ec14ad46ba4d476bacca':
  Dump settings.
2014-02-12 20:29:18 -08:00
Jean Chalard
c3cfabd0eb Merge "Dump settings." 2014-02-13 04:26:52 +00:00
Tadashi G. Takaoka
870d89b1a8 Refactor dictionary constructor
This change must be checked in together with I3923d5af2a.

Bug: 12994268
Change-Id: I19de6efbdfa3b6c6c69a20a836e53962fd5737de
2014-02-13 13:23:55 +09:00
Baligh Uddin
a973e0926a Import translations. DO NOT MERGE
Change-Id: Ibf72865a393c8e5e41ef6420e7131bbcddfb18e5
Auto-generated-cl: translation import
2014-02-12 16:04:35 -08:00
Baligh Uddin
e99f9d727e Import translations. DO NOT MERGE
Change-Id: I54170dbd991b10f1a037318adcc766ead114ea27
Auto-generated-cl: translation import
2014-02-12 16:03:08 -08:00
Yohei Yukawa
cfe26bbcde Fix indent.
This is a follow up for the previous commit to fix indent.

BUG: 12964092
Change-Id: I0530b1c0dae26ac736ddcc6d426ec6ce57bce4d1
2014-02-13 01:58:58 +09:00
Jean Chalard
bac89ecc50 Fix a failing test.
A replay of that old, horribly hard-to-find bug: we post a
resume message during onStartInputView, so we need
to process it before we start the test. But now the message
is posted with a delay, so we need to wait for the delay...

Change-Id: I843d70e636fa51a68aadbdbbaa73b1711ad7bddd
2014-02-12 23:32:51 +09:00
Jean Chalard
367a35d377 Dump settings.
Bug: 10315296
Change-Id: Ieb020a23886514b3ba97611d8a6001f32b322f63
2014-02-12 22:53:15 +09:00
Yohei Yukawa
a8a06ad6d4 am 50fbe4cc: Merge "Cancel keydown events immediately once the view starts scrolling"
* commit '50fbe4cc09e9ee98f94f3a90b1353ec22ac149c7':
  Cancel keydown events immediately once the view starts scrolling
2014-02-12 02:23:24 -08:00
Yohei Yukawa
50fbe4cc09 Merge "Cancel keydown events immediately once the view starts scrolling" 2014-02-12 10:21:08 +00:00
Yohei Yukawa
4c259866c4 Cancel keydown events immediately once the view starts scrolling
The motivation of this patch is to make sure a user never feel
haptic feedback when scrolling the Emoji palette. In order to
achieve it, EmojiPageKeyboardView#releaseCurrentKey() should
be called whenever (delayed) keydown events should be canceled.

This patch wires up ViewPager.OnPageChangeListener#onPageScrolled
with EmojiPageKeyboardView#releaseCurrentKey() so that delayed
keydown events will be canceled immediately once the ViewParger
starts scrolling.

BUG: 12964092
Change-Id: Iea8c3e090bb16a8622e6b4a850af2bf963aa77d0
2014-02-12 18:56:08 +09:00
Tadashi G. Takaoka
71a6277e87 am 5a885e85: Merge "Keep showing key preview even when keyboard has been changed"
* commit '5a885e85c2df89247ccdde50fe26ca46438727fb':
  Keep showing key preview even when keyboard has been changed
2014-02-12 01:43:41 -08:00