Commit graph

4249 commits

Author SHA1 Message Date
Jean Chalard
e3ec5fcc88 Fix a bug in gesture after a dash or apostrophe
It would insert a space when it shouldn't when composing a
word ending in either dash or apostrophe and gesturing right
away.

Bug: 7889078
Change-Id: Ib3e2f6f5e551888cc081b464a641e2deac6f5ef7
2013-01-18 15:05:34 +09:00
Jean Chalard
5a6b4f953e Merge "Insert into user dict in lower case if auto-caps (D2)" 2013-01-18 05:39:18 +00:00
Kurt Partridge
345ef67627 [Rlog78a] Annotate logUnits with corrections
If the user makes a correction to a word, this is now explicitly indicated
in the logUnit.

Change-Id: I8638aadd7b8c8e32bbc9c4b020548d786513d887
2013-01-17 14:05:02 -08:00
Kurt Partridge
e6a9655a03 Merge "Consolidate SuggestedWords.getWordInfo and .getInfo" 2013-01-17 22:01:26 +00:00
Kurt Partridge
937877b877 Merge "[Rlog14] Increase feedback buffer to cover whole session" 2013-01-17 21:21:49 +00:00
Kurt Partridge
63ed9abbe8 Merge "[Rlog13] ResearchLogger fix feedback" 2013-01-17 19:56:25 +00:00
Kurt Partridge
f881f10e90 Merge "Fix commit partial text logStatement" 2013-01-17 19:15:32 +00:00
Kurt Partridge
34ecd12a05 Merge "Add comment" 2013-01-17 17:50:42 +00:00
Kurt Partridge
b5ac8ef586 Consolidate SuggestedWords.getWordInfo and .getInfo
Change-Id: I959cf049f550b7be3ec002281ca7457e566b0214
2013-01-17 07:50:15 -08:00
Kurt Partridge
5213559e0e Fix commit partial text logStatement
- No longer suggests that it is called from a non-existent method
  in RichInputConnection

Change-Id: I25fe4a0f232a4320ca113598bbcdd029ca319944
2013-01-17 07:46:06 -08:00
Jean Chalard
8914555776 Reset forgotten members (D3)
Only resetting mCapitalizedMode is enough to fix bug#8013488,
but we may as well correctly reset both fields.

Bug: 8013488
Change-Id: Icb0d7c5b1e93368e8eb7848aa9137b45d5d3531e
2013-01-17 20:39:09 +09:00
Jean Chalard
96845ecff6 Insert into user dict in lower case if auto-caps (D2)
Also recapitalize afterwards if the word has been changed.

Bug: 7972124
Change-Id: I9306580bb4ed0ffa80cc4559ce1abcd2034d1905
2013-01-17 20:38:52 +09:00
Jean Chalard
c665cbee7f Merge "Forward the capitalized mode to the positional info (D1)" 2013-01-17 11:02:00 +00:00
Jean Chalard
15ea1d4096 Merge "Simplify the space-before and space-after logic." 2013-01-17 09:07:20 +00:00
Jean Chalard
ae3b96b26e Simplify the space-before and space-after logic.
Bug: 7889078
Bug: 7268000
Change-Id: I6c77b8c9e60ef69f02526b407124d2f5d02818ee
2013-01-17 17:52:46 +09:00
Tadashi G. Takaoka
40c59727cf Merge "Add default button to vibration/volume settings dialog" 2013-01-17 08:41:01 +00:00
Tadashi G. Takaoka
1b1fa7a18b Merge "SeekBarDialog supports neutral and dismiss listener" 2013-01-17 08:27:27 +00:00
Jean Chalard
22959faad4 Merge "Stop relying on the soft keyboard to get the editor action." 2013-01-17 07:16:58 +00:00
Jean Chalard
b6b7f5e39e Forward the capitalized mode to the positional info (D1)
Bug: 7972124
Change-Id: I3c74f3b075e698b9e9dd1d2c7b6f173073539063
2013-01-17 14:35:58 +09:00
Kurt Partridge
7f8c096bf2 [Rlog13] ResearchLogger fix feedback
The feedback string was not being inserted in the feedback logs.  Also changed the tag to
"UserFeedback" from "UserTimestamp" to better reflect the data recorded.

Change-Id: Iccf781b25e2573168c36e729419468f5bd73903e
2013-01-16 21:29:51 -08:00
Tadashi G. Takaoka
84ce64f2c0 Fix bounding rectangle of gesture preview trail
Bug: 7917443
Bug: 7987585
Change-Id: I99e6db1fe43d3a9b497e92330a6857e0454c428c
2013-01-16 19:51:01 +09:00
Jean Chalard
d818f1e3b6 Stop relying on the soft keyboard to get the editor action.
Bug: 7969231
Change-Id: I9848c63c4c51550b5dc53c981eafa74e7fa95197
2013-01-16 18:22:00 +09:00
Kurt Partridge
14b800d858 [Rlog14] Increase feedback buffer to cover whole session
Change-Id: I55b61d9ca6eecd56181b8d2913f71559555cd89e
2013-01-15 18:34:13 -08:00
Kurt Partridge
9579936bcf [Rlog67] Renaming clarification
ResearchLogger.latinIME_handleSeparator wasn't doing anything really specific to
the separator, so its implementation has been renamed according to its role.

Change-Id: I24e8691c7dc440dd067e96d23e50463683e17cfc
2013-01-15 08:57:52 -08:00
Jean Chalard
dcfceaff1b Distinguish action-enter/shift-enter/enter
Bug: 7969231
Change-Id: I75d495ee1ea126da9be4e269ee990ee0a97793c1
2013-01-15 19:12:41 +09:00
Ken Wakasa
c995dbcf59 Merge "Remove MAX_WORD_LENGTH_INTERNAL" 2013-01-14 19:46:09 -08:00
Ken Wakasa
5db594abba Remove MAX_WORD_LENGTH_INTERNAL
Change-Id: Ie11ff000675601acff5fbb00e9e9f48eb32c5071
2013-01-15 12:39:08 +09:00
Tadashi G. Takaoka
722eeb144f Fix drawing Arabic diacritics
Bug: 8001868
Change-Id: I0e5aab266bbaad8c68e4a900b8d5572977a0379d
2013-01-15 11:03:15 +09:00
Kurt Partridge
019bcc62b9 Merge "[Rlog68] Logger; make filenames more unique to prevent filesys conflicts" 2013-01-14 10:02:16 -08:00
Kurt Partridge
5b611e184b Merge "[Rlog63] Log whether a manual suggestion is a prediction" 2013-01-14 09:30:12 -08:00
Kurt Partridge
0a292ad883 Add comment
Change-Id: If21222aa678a827c1fcad5cacac0fa20655e4e5e
2013-01-14 09:08:51 -08:00
Kurt Partridge
939e3f3152 Merge "[Rlog59d] Pass separatorString through revertCommit" 2013-01-14 08:59:04 -08:00
Kurt Partridge
67a61fc6be [Rlog68] Logger; make filenames more unique to prevent filesys conflicts
multi-project commit with If6b9f8990d7cdbf570740a81096513698d0e0f4c

Change-Id: I124aed24be0beb4c472869594184ecf003c2fed4
2013-01-14 07:11:42 -08:00
Kurt Partridge
31156c816e [Rlog59d] Pass separatorString through revertCommit
Change-Id: I5ef20476318979f99f543f9300cf6198d18f6244
2013-01-14 07:01:49 -08:00
Kurt Partridge
3e05370d53 Merge "[Rlog59c] More detailed logging of backspace" 2013-01-13 11:13:37 -08:00
Kurt Partridge
916c0a08c6 Merge "[Rlog60] Log if a logUnit is uncommitted" 2013-01-12 12:57:19 -08:00
Kurt Partridge
ef3936bc54 [Rlog59c] More detailed logging of backspace
- Normal delete events are recorded
- Includes number of characters deleted for both batch and normal delete

Change-Id: I422da3ddc94fa0ccd6c7586eaacf14c62dd16679
2013-01-12 12:54:59 -08:00
Kurt Partridge
343a852cd9 Merge "[Rlog59b] Log CodeInput and KeyCode properly" 2013-01-12 10:18:57 -08:00
Kurt Partridge
b75e2380e2 Merge "[Rlog58b] Log user pauses" 2013-01-11 10:19:13 -08:00
Kurt Partridge
3338703a2f [Rlog63] Log whether a manual suggestion is a prediction
Change-Id: Ia6f793611d4b18aecb1a635655af5edb639e1ecf
2013-01-11 09:55:09 -08:00
Kurt Partridge
5523a6818d Merge "[Rlog59a] Split logUnits correctly around separators" 2013-01-11 09:18:10 -08:00
Ken Wakasa
f6870cc82d Remove BinaryDictionary.MAX_PREDICTION and MAX_SPACES, and rename MAX_WORDS to MAX_RESULTS
Change-Id: Iab2a422b367e7521f346481c7fe5e2575f2e9de3
2013-01-11 20:47:42 +09:00
Kurt Partridge
99931201d0 [Rlog59b] Log CodeInput and KeyCode properly
- Fix function calls to happen at more resilient times
- In the case of phantom spaces, ensure that the logStatement goes to the
  correct logUnit

Change-Id: Ida8f6eba1e4f33d9f9b4735316e3c6316ed316c0
2013-01-10 23:39:11 -08:00
Kurt Partridge
b4fe364b39 [Rlog60] Log if a logUnit is uncommitted
Normally logUnits are committed to a log when the word that their data
corresponds to is complete.   However, if the user reverts a word, or goes
back to edit it, then the system may "uncommit" the logUnit, and append
additional editing steps to the end of it.  When this happens, we want to
make a note of it in the log, which is what this patch does.

Change-Id: If2bbb948469824c76facf5f06ed8a6da8ff9777c
2013-01-10 23:18:40 -08:00
Jean Chalard
d8590857bd Fix spell checker subtype list.
Remove the subtypes that don't get a dictionary any more in AOSP.
Also prepare for all downloadable-dictionary supported subtypes.

Bug: 7673670
Change-Id: I5b754a791233c270237b8f7e5e2208f7282ad294
2013-01-11 14:59:34 +09:00
Kurt Partridge
05ee6ad843 [Rlog58b] Log user pauses
Change-Id: I7802f07192a4cba4f3cfb5c08ce6d5d2d85a46c1
2013-01-10 19:54:40 -08:00
Kurt Partridge
aa9db1e259 Merge "[Rlog] Fix some potential NPEs" 2013-01-10 17:14:10 -08:00
Kurt Partridge
90aaa2d0a5 [Rlog59a] Split logUnits correctly around separators
Change-Id: I65ecdead7e7bdeb8a5f1748e27068ddbd5d3ce00
2013-01-10 16:36:18 -08:00
Kurt Partridge
211103d7fe [Rlog58a] Fix privacy leak of word in logUnitStart
Change-Id: Idcea4cd0256581e9868ac987fd1fa281ff074483
2013-01-10 16:06:01 -08:00
Kurt Partridge
4acdd3ad69 [Rlog] Fix some potential NPEs
Change-Id: I07b18b5db81784dca32683e5f208088181c5eed9
2013-01-10 16:04:23 -08:00
Kurt Partridge
75e69753b7 [Rlog57b] fix logging of reverts
Change-Id: I07c817061a0cc060197e0fea45195ca07a9bf276
2013-01-10 15:00:28 -08:00
Kurt Partridge
a097004264 Merge "[Rlog57a] include logUnit boundaries in output" 2013-01-10 12:04:32 -08:00
Kurt Partridge
700ce8df07 Merge "[Rlog56] Buffer words before pushing out LogUnit" 2013-01-10 10:51:17 -08:00
Ken Wakasa
4da2ed7a78 Fix too thick gesture trail width
Change-Id: If1b78183b24fa0029bc28e5f56a988372182903e
2013-01-10 22:18:23 +09:00
satok
2ef0d3bf8d Merge "fix possible NPE in DebugSettings" 2013-01-10 03:00:24 -08:00
satok
e8b4fd2644 fix possible NPE in DebugSettings
Change-Id: I44ec5bd3b2a00087603316f14d732164dbcf399f
2013-01-10 19:57:33 +09:00
Jean Chalard
d9c7a6b9b3 Merge "Move a method to a utility class (C1)" 2013-01-10 00:04:11 -08:00
Jean Chalard
9c75ad1ade Merge "Fix international tests" 2013-01-10 00:03:05 -08:00
Tadashi G. Takaoka
a80b8fc98f Merge "Show final suggested word when batch input is finished" 2013-01-09 23:35:09 -08:00
Tadashi G. Takaoka
50d902ac6f Show final suggested word when batch input is finished
This change moves dismiss timer of gesture floating preview text from
PreviewPlacerView to KeyboardView.

Bug: 7967461
Change-Id: I0ca5beddc93cb4bc4a405f914d217d37b997402b
2013-01-10 16:25:05 +09:00
Jean Chalard
ae4c81993c Merge "Initial implementation for dead keys (B3)" 2013-01-09 23:15:49 -08:00
Jean Chalard
6a26de1d7e Initial implementation for dead keys (B3)
Bug: 5037589
Change-Id: I9e1ff92df7d0c58eb7a0f33603adebc9efb86585
2013-01-10 15:47:21 +09:00
Kurt Partridge
b74a0a78c2 [Rlog57a] include logUnit boundaries in output
Change-Id: I4d1647b971b0e7a4cf1a96f341236f6ab1d2ab16
2013-01-09 22:38:27 -08:00
Tadashi G. Takaoka
433f54ce90 Merge "Remove unused variables" 2013-01-09 22:32:23 -08:00
Jean Chalard
424d76fbf5 Merge "Add a next Event (B2)" 2013-01-09 22:23:05 -08:00
Jean Chalard
912ad4614f Fix international tests
Tests have been broken again by recent changes to subtype
choice within Latin IME. This fixes the problem and all tests
pass again.

This change also includes a small fix to one test that was
checking for something irrelevant.

Change-Id: I6a03dea24f99b0d2ad84c4161a8413f3060bb811
2013-01-10 15:12:17 +09:00
Tadashi G. Takaoka
a7a7f4e002 Add default button to vibration/volume settings dialog
Change-Id: I7beb4517314efdefeb47d91b14a6b02c3075c19f
2013-01-10 15:11:30 +09:00
Tadashi G. Takaoka
6512cd289d Merge "Cancel update batch input timer only when point is added" 2013-01-09 21:47:46 -08:00
Tadashi G. Takaoka
b2f5d15250 Cancel update batch input timer only when point is added
Bug: 7972004
Change-Id: Ie5db5910efba851976da2284cafc69be2910d354
2013-01-10 14:31:07 +09:00
Tadashi G. Takaoka
88df3d9239 SeekBarDialog supports neutral and dismiss listener
Change-Id: I652fd1a383ef4074c04d03a37ebc779d229474e6
2013-01-10 14:24:54 +09:00
Kurt Partridge
759506ef2d Merge "[Rlog52z] Cleanup and small bug fixes" 2013-01-09 21:12:13 -08:00
Kurt Partridge
403c423940 [Rlog56] Buffer words before pushing out LogUnit
Previously, a logbuffer only held an n-gram.  Data went in and out of it, FIFO, until privacy
conditions were met (i.e. data not collected too frequently), and then an n-gram was saved.
E.g., if n=2, and only 10% of data is collected, then 18 words went through the logbuffer before
it captured the next 2 words.

However, if a user then went back and edited the n-gram, these edits were not captured.

This change changes the logbuffer size to temporarily hold data about words that are not recorded,
so that if the user backs up over them, the edits to an n-gram that we do eventually capture are
stored.  If the example above, instead of a logbuffer holding 2 words, it holds 20.  The system
waits until all the words not needed for the n-gram have been gathered (i.e. the buffer is full),
so the user has adequate time to edit, before shifting out the n-gram.  The buffer is still flushed
when the user closes the IME.  See the comment for MainLogBuffer for an explanation.

multi-project commit with I45317bc95eeb859adc1b35b24d0478f2df1a67f3

Change-Id: I4ffd95d08c6437dcf650d866ef9e24b6af512334
2013-01-09 21:09:19 -08:00
Kurt Partridge
8bda35809b [Rlog52z] Cleanup and small bug fixes
Change-Id: Ia3fca4881370ffcdd5f2b14d2d1094c51f4330ae
2013-01-09 21:07:51 -08:00
Kurt Partridge
f11c4a9aeb Merge "[Rlog50] capture bigrams properly even with deletions" 2013-01-09 19:52:45 -08:00
Tadashi G. Takaoka
1aa547d94a Remove unused variables
Change-Id: I508679c2ad21b2624760d37a9503e21733964d4c
2013-01-10 12:34:35 +09:00
Tadashi G. Takaoka
95e3008d25 Merge "Rename variables related to key preview popup" 2013-01-09 19:32:33 -08:00
Tadashi G. Takaoka
6ece8f718b Merge "Remove unused variable" 2013-01-09 19:32:18 -08:00
Tadashi G. Takaoka
3727a3fd61 Merge "Clean up public helper methods of SettingsValues" 2013-01-09 19:04:46 -08:00
Tadashi G. Takaoka
813692c956 Rename variables related to key preview popup
Change-Id: I0161e5844dd325af9afba80ac54a569b16c80660
2013-01-10 11:47:18 +09:00
Tadashi G. Takaoka
e0e0b04188 Remove unused variable
Change-Id: I7001d8b6200a5cefcf84630d663da8316422026f
2013-01-10 11:43:35 +09:00
Kurt Partridge
3b95eaf70b [Rlog50] capture bigrams properly even with deletions
multi-project commit with Ia4ec213e8356897807cb6a278fccdbaa945732f0

Change-Id: Ib3fe886dc889954a31586ab81d00a21d8d55efd2
2013-01-09 16:02:37 -08:00
Jean Chalard
6c75253c11 Add a next Event (B2)
Change-Id: If2fe6f0f4f88a6ae1f22664ded61cec6942c18b9
2013-01-09 22:12:13 +09:00
Jean Chalard
125ad22370 Merge "Abandon the idea of an Event pool and make Event immutable (B1)" 2013-01-09 05:07:42 -08:00
Jean Chalard
8da9c337db Move a method to a utility class (C1)
This is a preparatory change to fix bug 7969231

Change-Id: I44604ae75192a17b4e75a01f3e3d679d4901299e
2013-01-09 21:59:06 +09:00
Jean Chalard
ae74b8cf67 Abandon the idea of an Event pool and make Event immutable (B1)
Change-Id: I750a07c0c564a95ceac734afa873ca3da9626a7f
2013-01-09 21:08:58 +09:00
Jean Chalard
b112a13518 Merge "Fix a race condition with backspaces" 2013-01-09 01:53:47 -08:00
Jean Chalard
516b63db28 Fix a race condition with backspaces
And add a test to make sure it stays not-broken.

Bug: 7946604
Change-Id: I996da3d5507d591ec25a13fb57434f39843f1df5
2013-01-09 18:37:10 +09:00
Tadashi G. Takaoka
e56686f43a Merge "Cancel update batch input timer whenever MotionEvent is received" 2013-01-09 01:12:59 -08:00
Tadashi G. Takaoka
915f348b35 Cancel update batch input timer whenever MotionEvent is received
Bug: 7911739
Change-Id: Id2cd98385371fd98435943ed66ec5381dfaa48e0
2013-01-09 17:55:42 +09:00
Tadashi G. Takaoka
8353e751ca Don't cancel gesture typing while more keys keyboard is shown
Bug: 7964225
Change-Id: I4c572527b6f399282bdd963e38c147c7e69815ac
2013-01-09 16:56:59 +09:00
Tadashi G. Takaoka
d3b0ecec22 Clean up public helper methods of SettingsValues
Change-Id: I6c6087580b67f497eaaf16900f8df7a4a895b8e3
2013-01-09 11:23:34 +09:00
Tadashi G. Takaoka
8315e8168b Merge "Clean up debug related preference keys" 2013-01-08 16:56:13 -08:00
Kurt Partridge
e9c6455881 [Rlog48] Better logging of MotionEvents
- Now includes all historical data stored in a motionEvent
- Simpler API, refactored to move extraction code to JsonUtils

Change-Id: I52d9756ddbeaa14d1704787da59bf1aad18f0335
2013-01-08 08:50:06 -08:00
Kurt Partridge
9bad176ebe Merge "[Rlog32] ResearchLogger segment motion data around gestures correctly" 2013-01-08 08:10:31 -08:00
Kurt Partridge
b7fb16e8cc Merge "[Rlog27] Refactor LogBuffer" 2013-01-08 07:40:57 -08:00
Tadashi G. Takaoka
a5ff9f0c77 Clean up debug related preference keys
Change-Id: Ib7129692c673b3bce253120ee709e0253aeafa52
2013-01-08 18:26:47 +09:00
Tadashi G. Takaoka
ff0735ada8 Make Settings class singleton to manage SettingsValues
Change-Id: Id30828a141de86d9bcf8bce586d2adb468cc59e1
2013-01-08 17:48:47 +09:00
Tadashi G. Takaoka
8873b5ae31 Merge "Rename Settings to SettingsFragment" 2013-01-07 23:00:59 -08:00
Tadashi G. Takaoka
4b852d6044 Merge "Consolidate VibratorUtils with AudioAndHapticFeedbackManager" 2013-01-07 23:00:04 -08:00
Tadashi G. Takaoka
cbee8a33d5 Rename Settings to SettingsFragment
Change-Id: If5bc53efc67be507663091de0f569f604c03e719
2013-01-08 15:59:16 +09:00