d543984d2e
Create a new KeyboardLayout class to represent the layout.
...
Change-Id: Ia08c8194f460271c831702675cfb687ab9f6678b
2015-01-30 17:24:09 -08:00
77e0fa1d67
LatinIME portion of multi-lang option removal.
...
Bug 19188067.
Change-Id: Ic9a3637f59dda30c699141222b9dcac3cd624b99
2015-01-29 15:57:03 -08:00
e1758feeff
Disable the Burmese keyboard.
...
We'll resurrect this effort in the new code base.
Bug 16900511.
Change-Id: Iae4cd27cb29cb8f991e97cffd88ed59c30d66628
2015-01-29 10:17:33 -08:00
ab6f3b36d0
Change DictionaryFacilitator.java to an interface, create its
...
implementation DictionaryFacilitatorImpl.java and add a java-overridable
factory DictionaryFacilitatorProvider.java used to create a
DictionaryFacilitator.
Change-Id: Id4a58ae31feaa4d12a048a772c8d76ff82fdee45
2015-01-27 21:38:32 +00:00
d523bacebc
Merge "Add a method for handling for words not found in dictionary."
2015-01-23 16:35:16 +00:00
fc47007674
Merge "AOSP change for showing the app icon."
2015-01-16 17:49:37 +00:00
d913617e0c
AOSP change for showing the app icon.
...
This change deletes a bunch of code that was used to conditionally show/hide
the keyboard app icon given system states and user preferences.
Bug 19001197.
Change-Id: I69a57aa21872a571af87a193b3e52b7f985e5168
2015-01-16 09:37:30 -08:00
9fe700ec4f
Merge "Fix moving the cursor inside composition in lang w/o spaces"
2015-01-16 03:22:18 +00:00
2e8d536678
Add a method for handling for words not found in dictionary.
...
This is apparently called only once for every unique word, so repeated instances
of the same word are not handled separately. Upon changing orientation of the
device, however, all invalid words in the textbox are underlined again and this
method is called for each unique instance in order.
Change-Id: Ic57e4b9e5675bd7abd723644aa318d964f7f875f
2015-01-14 16:20:42 -08:00
303a2ae5c9
Fix NPE in PunctuationSuggestions.
...
The NPE happens when the keyboard doesn't specify any punctuation suggestions.
Bug 18047927.
Change-Id: I9f8aa35df4f163b527dc6580a99afc6da45a96b8
2015-01-13 13:24:16 -08:00
a1a9896b42
Rename production flag for cloud sync feature
...
Change-Id: I24cbe94f128f54fb9bfeeef78cf271fee2216c8e
2014-12-29 12:45:27 -08:00
8e235191dd
Fix moving the cursor inside composition in lang w/o spaces
...
Also introduce the cursor move event, which we needed to do
anyway
Bug: 18827118
Change-Id: I30e994764c095b4423b874dc05d1bbedc0de592f
2014-12-22 17:47:33 +09:00
3e35b8712c
[3]Ping dictionary stats:Pass DictionaryFacilitator
...
Pass dictionaryFacilitator to StatsUtilsManager from
LatinIME
Bug:16553957
Change-Id: I912a0b447e5684909ff67e3653a4bd8649cd03c5
2014-12-18 13:42:41 -08:00
20469a8779
Merge "[2]Pass context to StatsUtilsManager for alarms."
2014-12-18 21:35:45 +00:00
2b69244555
[2]Pass context to StatsUtilsManager for alarms.
...
Change corresponding to ag/605384
Bug:16553957
Change-Id: I77024957b9497c45296bbbb24ca972b26348a8c3
2014-12-17 12:16:02 -08:00
dbdc81a36a
Merge "Cleanup InputMethodInfoCache"
2014-12-17 06:39:19 +00:00
4077a7e52f
Merge "Remove SubtypeSwitcher"
2014-12-17 06:39:07 +00:00
bc4ae6bdc0
Passing account info to dictionaryFacilitator
...
Attempt to use dictionary facilitor without invoking
preference manager. Instead use account from settings only when
things are being reset/changed. Discussion forked from ag/591663
Overall, the idea here is to maintain an account information
inside dictionary groups. Reset the dictionary groups if
account changes (the way we do for locale). Since only user
history dictionary is currently affected, the check to reset user
history dictionary also includes the check to verify the account.
For other things remain the same.
SettingsValues holds the current account (and is updated if prefs change
due to change in account settings). The updated settings are then
propagated to dictionary facilitator via LatinIME#loadSettings.
Bug:18104749,18469539
Change-Id: I553e776e7ea125d0fb7a1fe70a4c7eb0b2277fb8
2014-12-16 15:56:00 -08:00
25daca0053
Merge "Provide a preference to delete data from cloud."
2014-12-12 19:43:16 +00:00
afd52dfc60
Cleanup InputMethodInfoCache
...
Change-Id: I40afeb4557c3b1ad32bd90f67502a625df2bc3fb
2014-12-12 13:53:13 +09:00
31a10e226d
Remove SubtypeSwitcher
...
Change-Id: Ic4def69a9f742f13c98bc3e518c406658b52797d
2014-12-12 13:45:46 +09:00
8cfad7ed64
Merge "Make LanguageOnSpacebarHelper as utility class"
2014-12-12 04:42:09 +00:00
498dbfbd9d
Disable multiple language input
...
Bug: 18705799
Change-Id: I73730ccf59e2697acfb3fe436c01b94c40307f2f
2014-12-11 14:50:03 +09:00
4934a88b61
Make LanguageOnSpacebarHelper as utility class
...
Change-Id: I546f3b1943999a41803222bd14f9ddd23aa87a51
2014-12-11 14:22:21 +09:00
2b25f674f2
Add NetworkConnectivityUtils class
...
Change-Id: I7bd71f1d4ef0fc0fe21ddfd9f3e11463f53ac4e7
2014-12-11 01:37:44 +00:00
6814e7aa87
Provide a preference to delete data from cloud.
...
For now, it is a debug preference, but we may make this a proper
user setting in the future. Thus note that the messaging is not
final.
Pref looks like :
1. https://screenshot.googleplex.com/OLxW0myWD9.png
2. https://screenshot.googleplex.com/YeqWYXGstw.png
Bug: 18106936
Change-Id: I88bbc1a2ee0c23a48ff3972a91d57c218b10bb65
2014-12-09 12:45:34 -08:00
52e92f812b
Merge "Quit auto-correct explicit accented letters to base letters."
2014-12-09 10:24:56 +00:00
515c508135
Quit auto-correct explicit accented letters to base letters.
...
Bug: 7677193
Change-Id: I66eddbf27a9db8682c0347a1be19922792a3bea7
2014-12-09 19:23:27 +09:00
be819dbe2b
Revert "Add keyboard margin options to place the keyboard dynamically."
...
This reverts commit 8584db1461
2014-12-09 17:53:24 +09:00
45bbdc20bb
Merge "Rename variable name to remove ambiguity"
2014-12-09 03:53:22 +00:00
88cd34f8f8
Rename variable name to remove ambiguity
...
Change-Id: If95c34c9eab09cbc941bef5ee3d34b9048bf3bf9
2014-12-08 19:27:25 -08:00
8af412d80c
Remove unnecessary cast and import
...
Change-Id: I9bcd6c9c48ad51aa0f95937869eb6757e4dd4511
2014-12-09 11:57:32 +09:00
2bdd5290a9
Merge "Hook for fetching sync content from UserHistoryDict"
2014-12-08 20:00:10 +00:00
3dca77ec07
Merge "Refactor KeysCache to UniqueKeysCache"
2014-12-08 08:33:38 +00:00
5ac8b040e8
Merge "Remove RichInputMethodManager.updateShortcutIME call from SubtypeSwitcher"
2014-12-06 01:44:54 +00:00
8584db1461
Add keyboard margin options to place the keyboard dynamically.
...
Keyboard location and location can now be set in the debug options
section.
Change-Id: I87c5a1d679489e12dccf26632c399af28087629e
2014-12-05 16:21:20 +09:00
e79d504cf5
Merge "Cancel interval alarm for dictionary decaying in onDestroy."
2014-12-03 02:32:52 +00:00
47ae0c3af4
Cancel interval alarm for dictionary decaying in onDestroy.
...
Bug: 18528171
Change-Id: I6e12c006bd9eff15f3fa9cfd335bdd9fa081be61
2014-12-02 15:10:10 +09:00
d179e40899
Stop passing through keyPrefs as it's already available.
...
Change-Id: I43a56beba0cf0fdf5f93c5c764edbd279ee033b2
2014-12-02 05:17:51 +00:00
11a3965f8c
Fix a misspelled method name
...
Change-Id: I1151dc1d5db3986a97daf68c1e387dbc2e4610dc
2014-12-02 12:53:56 +09:00
391e83dc8f
Merge "Add null analysis annotations to keyboard package"
2014-12-01 03:37:53 +00:00
4486314225
Remove RichInputMethodManager.updateShortcutIME call from SubtypeSwitcher
...
Change-Id: I5661a7926cf5a404788516c542b25cc0707bb417
2014-12-01 12:16:10 +09:00
949045b6a3
Merge "Be always confident in the current language when only one"
2014-11-28 03:25:29 +00:00
2d81c1f183
Be always confident in the current language when only one
...
Change-Id: I7ea289f7e78aa33562c7737e91024a25c02333b6
2014-11-28 12:22:16 +09:00
063b2e8d71
Merge "Make LocaleUtils.constructLocaleFromString as @Nonnull"
2014-11-28 03:02:20 +00:00
b0a0ce0b31
Remove unused import and local variable
...
Change-Id: I256d1c6bf96c07b10d2d063d7935e20e0ab8ea17
2014-11-28 11:53:12 +09:00
60d880cf5e
Remove unnecessary code of CustomInputStylePreference
...
Change-Id: I68d2c85139e01684d5f0705f621ba223fc5e4425
2014-11-27 17:05:37 +09:00
01d54002b3
Refactor KeysCache to UniqueKeysCache
...
Change-Id: I8e3c4705c705a1c6e05e9112211d7012912d7e41
2014-11-27 15:44:22 +09:00
9d5d01a543
Add null analysis annotations to keyboard package
...
Change-Id: I6f020ece3c45d584d413e4265d6d3fbdf1ea8bd8
2014-11-27 12:37:38 +09:00
bb4075bc93
Merge "Fix possible NPE in MainKeyboardView"
2014-11-27 03:03:54 +00:00
2ffcad113a
Merge "Remove unused code from DictionaryFactory"
2014-11-27 03:01:46 +00:00
b5a7ece02b
Merge "Remove obsolete comment"
2014-11-27 02:52:04 +00:00
12d63820d4
Hook for fetching sync content from UserHistoryDict
...
Add API to ExpandableBinaryDictionary to dump content
from a given dictionary. We use this for dumping data
for sync process.
Refactored UserHistoryDictionaryTests to scrap out the util
methods for testing. These utility methods would be used
for testing sync + user dictionary code in LatinIMEGoogleTests
Bug:18106539
Change-Id: I357f9192ea1bd69a526d0b620c25616a2e8e9d5b
2014-11-26 11:17:24 -08:00
56577461d6
Allow whitelist changes when no close word
...
When there isn't a close word in another language of the
current multi-language set, we allow whitelist entries
to take force even if we are not confident in the current
language.
Bug: 18063142
Bug: 18130489
Bug: 18132240
Bug: 18136721
Bug: 18200415
Change-Id: I044674ba7b70aa86ab2a48d2e4d53a1c8007b62c
2014-11-26 18:43:22 +09:00
e752aab70d
Use confidence to fix whitelist
...
With this the most obvious problem is fixed. However there
are two remaining items : we should still enforce whitelist
when there are no close candidates at all, and we should
start in confident mode when pressing the globe key.
Bug: 18063142
Bug: 18130489
Bug: 18132240
Bug: 18136721
Bug: 18200415
Change-Id: Ibc0571ae35fc28f8d13760aa86b25db1163d3e31
2014-11-26 17:29:59 +09:00
cbefc0c8f9
Remove obsolete comment
...
Change-Id: I9e606fd573a60d12482b12e0e9adaecd552f66a7
2014-11-26 12:02:07 +09:00
b479a56f28
Merge "Add confidence."
2014-11-25 06:22:30 +00:00
d06dd0ca12
Add confidence.
...
Bug: 18063142
Bug: 18130489
Bug: 18132240
Bug: 18136721
Bug: 18200415
Change-Id: Ica09d11cb95308dd014c4e4e0d99a30dd66bfea9
2014-11-25 14:41:27 +09:00
8e32700914
Merge "Refactor PointerTracker and MainKeyboardView"
2014-11-25 02:09:25 +00:00
a414b81a6c
Remove unused code from DictionaryFactory
...
Change-Id: I666308ada968ee7993235ad98b92f2ad522af122
2014-11-21 17:58:50 +09:00
8a711f2a54
Remove unneeded Context argument
...
Change-Id: Ib34931836a617d0dc049fb3c9ae6686374ec8c12
2014-11-21 12:49:04 +09:00
53b6d627e7
Refactor PointerTracker and MainKeyboardView
...
This CL reorganize the key press/release state visual drawing code.
Change-Id: I4aa10f57309ae2f81333a1e2bd863c23a7a41d82
2014-11-21 12:40:00 +09:00
ebe5b42f71
Make LocaleUtils.constructLocaleFromString as @Nonnull
...
Change-Id: I82d574c67b25239510f3ecc8882efe46e40677eb
2014-11-21 12:02:06 +09:00
a7efe06208
Annotate the typed word with its source dictionary
...
...when applicable of course. This will allow for informing the
language switching authorities that the typed word was a
specific language, instead of leaving them in the dark.
Bug: 18063142
Bug: 18130489
Bug: 18132240
Bug: 18136721
Bug: 18200415
Change-Id: Ice3e7026a68c3018f54d730ec84f6762bf55899b
2014-11-20 18:31:01 +09:00
a66069abd8
Fix possible NPE in MainKeyboardView
...
Change-Id: I1fc21a981d9f1740315763b5ca0c1024ece1fa4d
2014-11-20 15:07:28 +09:00
a94733cbca
Fix an NPE.
...
Change-Id: Ie5ab5cc716ef1211eb9ad76baa0467455e1f1a71
2014-11-20 14:48:33 +09:00
1d80cb2301
Merge "Fix a NPE"
2014-11-20 05:28:47 +00:00
a2cb2f36a6
Make the typed word a SuggestedWordInfo
...
That allows to carry the language information in an
accurate manner.
Bug: 18063142
Change-Id: I0bca8981372ae10648274095b18b26a3686b762b
2014-11-20 13:57:01 +09:00
0e00f5fe3a
Fix a NPE
...
Bug: 18451316
Change-Id: Ia20bf388471f84c963354df050182e722d966a02
2014-11-20 13:50:27 +09:00
8736f2d719
Merge "Fix oscillations on ICS"
2014-11-19 10:23:28 +00:00
9444d70514
Fix oscillations on ICS
...
Bug: 18181427
Change-Id: Ib4dd62037b1f7b2d10496ee3e45b4a138e29f90a
2014-11-19 19:22:04 +09:00
6c47403e27
Rename StringUtils methods that handle title case manipulation
...
Change-Id: Iee0dd077a0423f110f4f8dad0f04933045baef2a
2014-11-19 19:08:05 +09:00
fde0cce103
Merge "Remove the other deprecated constructor to SuggestedWords"
2014-11-19 08:30:03 +00:00
b9116af29f
Fix SubtypeLocaleUtils.getSubtypeNameForLogging accepting null
...
Change-Id: Ic5cb55e24a2d843027ccc4e8e5d6954f9391c125
2014-11-19 11:57:49 +09:00
6d1201915d
Rename a confusing method name
...
...and fix a bug that happened because of it.
Bug: 18417740
Change-Id: I7a33780adcb8f4e2625abcd3eec906dfee1f5dcf
2014-11-18 11:52:35 +09:00
76f47ee433
Merge "Refactor KeyboardState.SavedKeyboardState class a bit"
2014-11-17 10:00:02 +00:00
81dde500a8
Merge "Remove deprecated Canvas.clipRegion(Region) call"
2014-11-17 09:05:12 +00:00
83f9524b87
Remove the other deprecated constructor to SuggestedWords
...
Change-Id: Ied821df01e032ebc913d2f15dffdf41a51372ea4
2014-11-17 16:23:52 +09:00
37f5b0d4ff
Bumping metadata database version to 11.
...
Change-Id: I19e2f701f3e2334355bfd7105f9b62dcb53cc209
2014-11-14 15:14:21 -08:00
91a81a2790
More verbosity when reporting broken dictionaries
...
Also added toString for AssetFileAddress for easier debugging.
Change-Id: Ie5d15d12bae46c31b28d8c67002e627f4c6690e3
2014-11-14 13:42:24 -08:00
39d50e7e7a
Merge "UpdateHandler to support v202 dicts."
2014-11-14 03:45:32 +00:00
d60f9c046e
Merge "Implement UserHistoryDictionary for each user account."
2014-11-14 00:46:37 +00:00
5365191a9d
Implement UserHistoryDictionary for each user account.
...
UserHistoryDictionary currently uses locale to determine the
UserHistoryDictionary on the filesystem. With this change we
use the account name as well. Thus each UserHistoryDictionary
would following the following spec:
UserHistoryDictionary.<locale>.<account>.dict.
In case no account is selected, we default to the existing
spec:
UserHistoryDictionary.<locale>.dict
Example
UserHistoryDictionary.en_US.testaccount@example.com.dict
Bug: 18104749
Change-Id: Iab031e166b55cf2ded68275a7e9be22475737b37
2014-11-13 14:21:38 -08:00
d6e367ff5b
Move isRtlLanguage method to LocaleUtils
...
Change-Id: I485a076b81927fed0da593216fea2c740449ef4c
2014-11-12 16:47:38 -08:00
63e076764b
Merge "Add RichInputMethodSubtype.getKeyboardLayoutSetName"
2014-11-13 00:41:10 +00:00
6de31466b0
Add RichInputMethodSubtype.getKeyboardLayoutSetName
...
Change-Id: I90cc74ee882e8aa2b243885d3b994223ca3b6f44
2014-11-12 15:41:38 -08:00
1dfdd9b509
Clean SubtypeLocaleUtils a bit
...
Change-Id: If8b981715983e3a12867c9b7c53bfa5effaddd39
2014-11-12 15:14:52 -08:00
de29278592
UpdateHandler to support v202 dicts.
...
Change-Id: Ib61a5005a82927f5e12a19c9c14f20d46572cf31
2014-11-12 12:04:38 -08:00
dd0b8a06a8
Refactor KeyboardState.SavedKeyboardState class a bit
...
Change-Id: I5be7339c4797b0308c1a192d2984056619fdfbdd
2014-11-10 16:40:59 -08:00
0d6ce46528
Move logic to determine spacebar text to LanguageOnSpacebarHelper
...
Change-Id: Ib9dbbb4bd4e35c15fd752c364d3012e8a7da2410
2014-11-08 18:50:59 -08:00
52a87a4cc3
Merge "Clean up KeyboardLayoutSet a bit"
2014-11-07 18:02:48 +00:00
ec0d6bb9b7
Merge "Move current subtype management code to RichInputMethodManager"
2014-11-07 18:02:22 +00:00
5c4f642df6
Merge "Move util classes under common"
2014-11-07 09:15:35 +00:00
5b91b551e5
Move util classes under common
...
Also why did we have two copies of LocaleUtils >.>
Bug: 18108776
Change-Id: I03b4403dfd51934e66b567f2f8b87da419cfb3ab
2014-11-07 18:00:03 +09:00
e0c2e5b2f7
Merge "Remove a deprecated constructor to SuggestedWords"
2014-11-07 08:49:26 +00:00
c3e211bd6b
Remove a deprecated constructor to SuggestedWords
...
Change-Id: If4d358b3a11fb25fc214c728269519d8c25f9adc
2014-11-07 16:40:24 +09:00
7286667754
Merge "Move shorcut IME related code from SubtypeSwitcher to RichInputMethodManager"
2014-11-07 06:20:07 +00:00
51d0b3351b
Merge "Remove a useless method."
2014-11-07 06:00:54 +00:00
536bf61658
Merge "Remove dicttool dependency to NativeSuggestOptions"
2014-11-07 06:00:40 +00:00
7fb0ed58ed
Move current subtype management code to RichInputMethodManager
...
Change-Id: I82d5a17a5ec96f26047d29e79f3f28850fc5b3bb
2014-11-06 11:51:07 -08:00
8a2c4afad4
Move shorcut IME related code from SubtypeSwitcher to RichInputMethodManager
...
Change-Id: I0f95f603d80570c937e8c38ded88df341c11795e
2014-11-06 11:51:07 -08:00
2a7da0ab87
Move some methods out from SubtypeSwitcher
...
Change-Id: I89aaf87d7d0cc204b0ca0f61c2f64d15e2df848e
2014-11-06 11:51:01 -08:00
b395ce4396
Remove a useless method.
...
Yay for cleanup
Bug: 18108776
Change-Id: I13f4066cd54f294377fdcf375a69350c44d4a32a
2014-11-06 21:38:17 +09:00
03eb9de961
Remove dicttool dependency to NativeSuggestOptions
...
Bug: 18108776
Change-Id: I0f57594617f8d5080aea9002b2356d18bfe97043
2014-11-06 21:38:11 +09:00
b68f90ac1a
Clean up KeyboardLayoutSet a bit
...
This CL moves getScriptId() from KeyboardLayoutSet.Builder to
KeyboardLayoutSet.
Change-Id: I13588467e3d03abb92120acb367f021ee3490a50
2014-11-06 12:30:16 +09:00
ab68143ad0
Fix a bug where LatinIME would recorrect with no input view
...
Bug: 18071127
Change-Id: I634d1f63f7d5c5b7453ed7559f9b65fa0433dcd8
2014-11-05 17:41:15 +09:00
b1439c2872
Fix EmojiPageKeyboardView onPress bug
...
Change-Id: I110f36e0547be4957656217c42a8dafd9359b700
2014-11-04 20:27:39 +09:00
ede88a3bd6
Merge "Revert "Fix Emoji key feedback""
2014-11-04 11:25:58 +00:00
a5d24336bf
Revert "Fix Emoji key feedback"
...
This reverts commit 953858d615
2014-11-04 11:24:26 +00:00
c514d3ead2
Merge "Fix Emoji key feedback"
2014-11-04 09:17:51 +00:00
953858d615
Fix Emoji key feedback
...
Bug: 18166905
Change-Id: I3c3296cabeed31e1250ff0753ea94576b494b96a
2014-11-04 17:49:18 +09:00
98dfa6e334
Fix MainKeyboardView visibility must be aligned with main keyboard frame
...
Bug: 18105755
Change-Id: Ifdcaded538d0eac3b100486ddf27ae4314293792
2014-11-04 13:17:07 +09:00
d60f49425b
Merge "Make DrawingProxy and TimerProxy as a top-level interface"
2014-11-04 02:52:15 +00:00
933920feae
Fix a wrong indent
...
Change-Id: Iaee83be85bb52c350dd08e4497732927b92eabcd
2014-11-04 11:18:52 +09:00
f296e7cdfa
Small comment fixes
...
Change-Id: Iecb432c414eadf13ee6a57fb21fc02d1c27e777f
2014-11-02 23:54:20 +09:00
c235a3be9d
Add debug logging
...
Change-Id: I38bf53a0b5ea5064462b8eb5d99b7247ff8bddc4
2014-11-02 22:34:43 +09:00
b3bae2e89b
Merge "Update v4 format version from 402 to 403."
2014-10-31 14:19:44 +00:00
ef8068f9a8
Merge "Add helper methods to convert flags to readable text"
2014-10-31 10:12:37 +00:00
ea468cc9de
Update v4 format version from 402 to 403.
...
Without personalization:
Total words: 1134774, Success Num: 899230, Success Percentage: 79.243%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1871, Bad Failure Percentage: 0.165%
Failures, with auto-correction (F-C): 29084, F-C Percentage: 2.563%
Max Keystrokes: 6072959, Min Keystrokes: 4436090, Keystroke Saving Percentage:26.953%
Before:
Total words: 1134646, Success Num: 925194, Success Percentage: 81.540%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1316, Bad Failure Percentage: 0.116%
Failures, with auto-correction (F-C): 28288, F-C Percentage: 2.493%
Max Keystrokes: 6072831, Min Keystrokes: 3946188, Keystroke Saving Percentage:35.019%
After
Total words: 1134659, Success Num: 944746, Success Percentage: 83.263%
Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1258, Bad Failure Percentage: 0.111%
Failures, with auto-correction (F-C): 28016, F-C Percentage: 2.469%
Max Keystrokes: 6072844, Min Keystrokes: 3387333, Keystroke Saving Percentage:44.222%
Change-Id: I3af42ec37a11847c0429c28616e726f6a339247f
2014-10-31 17:23:39 +09:00
5840a7c6e7
Merge "Remove Dict dependency on WordComposer and ProximityInfo"
2014-10-31 07:59:12 +00:00
9dc3ae84ee
Add helper methods to convert flags to readable text
...
Change-Id: I23608927cef8a897ff4ad8c938560cc78093ddac
2014-10-31 16:20:20 +09:00
ed575b62da
Merge "Add documentation for CollectionUtils#arrayAsList"
2014-10-31 07:07:07 +00:00
d443146c34
Add documentation for CollectionUtils#arrayAsList
...
(This is a cherrypick of http://ag/576739 )
Also, modify the IllegalArgumentException to capture the
values passed for start, end, and array.length to make
debugging easier in the unlikely event that it is thrown.
Add corresponding tests for the exceptions.
Tested:
tapas LatinImeGoogle LatinImeGoogleTests userdebug
make -j30 && \
adb install -r \
out/target/product/generic/data/app/LatinImeGoogleTests/LatinImeGoogleTests.apk && \
adb install -r \
out/target/product/generic/system/app/LatinImeGoogle/LatinImeGoogle.apk && \
adb shell am instrument -w -e class \
com.android.inputmethod.latin.utils.CollectionUtilsTests \
com.google.android.inputmethod.latin.tests/android.support.test.runner.AndroidJUnitRunner
Change-Id: I0c579ca4f4f2a9b2575aa6f8fa75e3ee4a21cf8a
2014-10-31 06:18:35 +00:00
88480f39f6
Update unit tests for new static dict version.
...
Bug: 11031090
Change-Id: Ifd7b241f1a0a30678ca7de97cc6e96927a9b5c8f
2014-10-31 14:50:18 +09:00
7c87859d4c
Using "blacklist" flag as "possibly offensive"
...
Bug: 11031090
Change-Id: I5cc0d006ab003656498eb82b0875eb9c051d331e
2014-10-31 14:33:05 +09:00
8523720b22
Remove deprecated Canvas.clipRegion(Region) call
...
Change-Id: I88e0a8d327c17bf4bafbe44cdfa265f5d0acb879
2014-10-31 14:06:30 +09:00
77947c9c96
Merge "Consolidate TimerHandler.Callbacks with PointerTracker.DrawingProxy"
2014-10-30 09:55:51 +00:00
34a9e2ae87
Make DrawingProxy and TimerProxy as a top-level interface
...
Change-Id: Ia425f341255595f8f80c13b2aa409249f9ce4202
2014-10-30 18:29:49 +09:00
be708c4e59
Consolidate TimerHandler.Callbacks with PointerTracker.DrawingProxy
...
Change-Id: I654f7483d1c013ac2685a45af4eb2af15fa219ad
2014-10-30 18:28:40 +09:00
0ca400c827
Merge "Add a preference to resize the keyboard height."
2014-10-30 03:37:26 +00:00
d9b1327c21
Merge "Consolidate similar methods"
2014-10-30 02:54:38 +00:00
bb9400aebc
Add a preference to resize the keyboard height.
...
The keyboard height is controlled by a slider in the debug preferences.
Without access to debug preferences, this change is a no-op.
Bug: 6867494
Change-Id: I984064ed1cab752876615f5ed582818474d6041b
2014-10-30 11:45:41 +09:00
d2c00f550d
Fix dismiss key preview bug introduced by I658a5b16cc
...
Change-Id: I5248374dfe0504f6e64cc5d994e275d80364ec9d
2014-10-30 11:43:53 +09:00
051f8b1442
Consolidate similar methods
...
This CL consolidates similar methods in MainKeyboardView.
- startWhileTypingFadeinAnimation and startWhileTypingFadeoutAnimation
- showSlidingKeyInputPreview and dismissSlidingKeyInputPreview
Change-Id: I607ab74683820de2456af3e75663cf8cf358ab38
2014-10-30 11:15:59 +09:00
4e0149c22a
Merge "Remove DrawingHandler"
2014-10-29 13:42:44 +00:00
93e5cdea71
Merge "[CS8] Add explanations"
2014-10-29 12:26:23 +00:00
2ad6d9cda3
Remove DrawingHandler
...
Change-Id: I658a5b16cca1e56f0b944009b8aef09e0a97a0db
2014-10-29 18:51:41 +09:00
ca6e5dfedb
Remove DrawingHandler.Callbacks.dismissAllKeyPreviews()
...
Change-Id: I2b11ca0dec0f3522648557a9a909f305cc4170fb
2014-10-29 15:25:09 +09:00
ecab6aff59
Remove Dict dependency on WordComposer and ProximityInfo
...
Bug: 18108776
Change-Id: I9b399a44241e05a7add9bb8094263aa76de37880
2014-10-29 12:27:24 +09:00
36799b2aa2
Move InputPointers and ResizableIntArray to common
...
Bug: 18108776
Change-Id: Ie5c0430aa41a8d6c58bf510a10173223d7dfe9fe
2014-10-29 12:09:11 +09:00
48ee473c1e
Merge "Clean up UserDictionaryCompatUtils"
2014-10-29 00:37:43 +00:00
4beeb9253a
Move StringUtils under common.
...
Bug: 18108776
Change-Id: Ia46a4102a0e86e71118ca5e641f9f531998e166b
2014-10-28 22:44:30 +09:00
ca724ef71f
Reduce StringUtils dependency on the Android libs
...
Bug: 18108776
Change-Id: I43feb25d79f89276d44462ba71788a14c4583277
2014-10-28 22:03:18 +09:00
fec5219974
Fix Serbian Latin subtype handling
...
This CL also adds unit tests for Hinglish and Serbian Latin.
Bug: 9687668
Bug: 17169632
Change-Id: Ib9aa1bcdf5b390a9d8c61f07165beacf850e2692
2014-10-28 18:36:16 +09:00
dccf4f2a41
Clean up UserDictionaryCompatUtils
...
Change-Id: I1b22c82930af4f30db4237335850fb34b66f9299
2014-10-28 17:42:17 +09:00
395009c03e
Fix NPE in AppearanceSettingsFragment
...
Bug: 18147440
Change-Id: I7a7a47b3484e54146d34d11b5bd9c1305421d829
2014-10-28 15:02:31 +09:00
67527f847e
[CS8] Add explanations
...
Bug: 13238601
Change-Id: I72a78be5848485f7fd77f5586573692529c7547b
2014-10-28 13:41:00 +09:00
d5455fea4a
Merge "Add null analysis annotation to CollectionUtils"
2014-10-27 09:43:22 +00:00
7a3de4dca9
Add null analysis annotation to CollectionUtils
...
Change-Id: I3a610b037d6d1431cced3ea193171108bd5a040d
2014-10-27 18:30:29 +09:00
f6a6371096
Refactor CoordinateUtils
...
Change-Id: I607b803273a4d7983e9e25a81b6941a3b59194c6
2014-10-27 18:02:33 +09:00
f7e01e866f
Remove device checking of Emoji physical key
...
This CL also adds a settings option to enable/disable an Emoji-ALT
physical key.
Bug: 18122464
Change-Id: Iee1d97efec979a902b0492071d5e511ca1792ff0
2014-10-27 16:26:22 +09:00
53b010384e
Remove an unused import
...
Follow up to I2b81450f99d7b4493ba0fc5e502f4333b8db48cd
Change-Id: I3d106db076e8181b65ce6843b801d12c6ca0adb1
2014-10-24 21:36:24 +09:00
23a357d71d
Small cleanup
...
Change-Id: I2b81450f99d7b4493ba0fc5e502f4333b8db48cd
2014-10-24 19:47:26 +09:00
067d8cdf56
Fix unit test breakage
...
Change-Id: I538288054a58eb2c81ce3cbe5c9bef900fb653a5
2014-10-24 16:48:46 +09:00
aad188d40a
Merge "Height of the keyboard for spellchecker is too large."
2014-10-24 06:29:10 +00:00
6cc318bd6a
Height of the keyboard for spellchecker is too large.
...
Bug: 18109041
Change-Id: I0eb98a66290058c28e20c86f36395af4f763952e
2014-10-24 14:59:52 +09:00
7e88eae623
Add missing header
...
Change-Id: I1befc2f1288674b4d871b27bdc5251b2b95e8bb7
2014-10-24 12:00:26 +09:00
2c6aaa7c3c
Merge "Move Constants.java to the latin.common package"
2014-10-24 02:50:07 +00:00
989699a690
Fix unit tests (InputLogicTestsDeadKeys).
...
Change-Id: I9a3191548aa0a4e674d736bc10845b952fc9a1e8
2014-10-23 22:09:08 +09:00
9342484e8d
Move Constants.java to the latin.common package
...
Our intention is to have classes of latinime-common under the common
package as much as we can.
Change-Id: I76efbbbe7bebf1a4aa943715cdff64f91675e20d
2014-10-23 20:27:37 +09:00
b224594aca
Merge "Fix a concurrency bug that ends up in a crash."
2014-10-23 08:02:37 +00:00
ade5ad1dae
Merge "Use trigrams for personalization dict."
2014-10-23 05:42:38 +00:00
16cc3992d7
Use trigrams for personalization dict.
...
5Bug: 14425059
Change-Id: I73cf6904e569d60996a3b079f16ea6df0cb90f02
2014-10-23 14:32:45 +09:00
b11fc7d423
Move annotations classes to latiime-common
...
Move Constants.java too.
Change-Id: I55e8cf06f61c0a37746a7328834a52a5306cf0f2
2014-10-23 13:00:46 +09:00
4097a20b36
Fix a concurrency bug that ends up in a crash.
...
Bug: 18085768
Change-Id: I016bec997787839526ddfc521ebb99d0c7b05189
2014-10-23 12:36:42 +09:00
d3a4c51324
Fix Javadoc and null analysis related warnings
...
This CL also adds @SuppressWarning("unused" to java-overridable package.
Bug: 18003991
Change-Id: If70527e30654384705d7a814f5efd181d9f539e1
2014-10-23 09:58:42 +09:00
b5ef884fbb
Support dumping ngram entries.
...
Bug: 14425059
Change-Id: Ib03a0c3d166ed6f1e60c67127b28006d55143b6b
2014-10-22 18:15:53 +09:00
baecaa5411
Merge "Remove BuildCompatUtils.VERSION_CODES_LXX"
2014-10-22 02:01:32 +00:00
66d30a4b22
Remove BuildCompatUtils.VERSION_CODES_LXX
...
Finally it is turned out to be a XXL-size Lollipop.
Change-Id: Icbd22506be9de514eba287cdd8d97fbfd070ac09
2014-10-22 01:29:58 +09:00
63cbdf49b9
Add @Override for a method that is overriding a new L API
...
Now all the downstream builds have switched to API Level 21.
Hence putting @Override to new APIs no longer makes javac unhappy.
Change-Id: Ib3324a5d06b17d298beacab8c8802bb14e5be968
2014-10-22 01:28:10 +09:00
46a007261f
Merge "Fix some compiler warnings"
2014-10-21 15:06:55 +00:00
5f00fe09e9
Fix some compiler warnings
...
This CL fixes the following compiler warnings.
- Indirect access to static member
- Access to a non-accessible member of an enclosing type
- Parameter assignment
- Method can be static
- Local variable declaration hides another field or variable
- Value of local variable is not used
- Unused import
- Unused private member
- Unnecessary 'else' statement
- Unnecessary declaration of throw exception
- Redundant type arguments
- Missing '@Override' annotation
- Unused '@SuppressWarning' annotations
Bug: 18003991
Change-Id: Icfebe753e53a2cc621848f769d6a3d7ce501ebc7
2014-10-21 19:28:37 +09:00
2105aa3ea6
Merge "FIx potential NPE"
2014-10-21 08:14:46 +00:00
097bcdcde8
FIx potential NPE
...
Bug: 18052047
Change-Id: I9097d0a504b8a1d875cf66e44bb65eb6ecc8908e
2014-10-21 14:13:27 +09:00
05172bf1a5
Renaming "blacklist" flag to "possibly offensive"
...
No behaviour changes.
Unified the overloaded FusionDictionary::add method to always take an
isPossiblyOffensive argument.
Bug: 11031090
Change-Id: I5741a023ca1ce842d2cf10d4f6c926b0efabaa78
2014-10-21 11:51:47 +09:00
b0ccf3a0a2
Refactor CustomInputStyleSettingsFragment
...
Bug: 18003991
Change-Id: Ib005dd394faf546e4faed89ff2018ce49858a06e
2014-10-20 17:12:33 +09:00
1085fef8d0
Change entry count limit.
...
Unigram 10K, Bigram 30K, Trigram 30K.
Change-Id: Ibd19c6a2b618499df1c70000bad7b47498187f0a
2014-10-20 15:01:49 +09:00
01acdac11e
fix build
...
Change-Id: Iedbf01e1c6191350aed8d31c2638b2430e67a36f
2014-10-18 07:37:46 -07:00
237f6ca799
fix build
...
Change-Id: I58a94fc0be01f272b6ad12524946f073c9f49894
2014-10-18 06:50:03 -07:00
ea32e8fb04
Merge "Enforce a length limit to auto-correction for some languages"
2014-10-17 13:11:39 +00:00
8fc872762f
Enforce a length limit to auto-correction for some languages
...
Bug: 15379262
Change-Id: I27fad12f468b5bc6ad1a0876aac72e5f5ca5760a
2014-10-17 22:05:05 +09:00
ad2f695083
Bring back long press timeout settings
...
Bug: 18025209
Change-Id: Id8dbb051e04270f6892cae12a443103bd0d32dcb
2014-10-17 18:20:43 +09:00
bd4693cd3f
Merge "[ML27.1] Allow adding additional features to other settings"
2014-10-16 11:08:37 +00:00
bdf70af177
[ML27.1] Allow adding additional features to other settings
...
We may want to add additional features from some of the
other screens.
Bug: 11230254
Bug: 17966252
Change-Id: I1bb877e5cbdd74f2ffa8010b5bc6af35fe77279a
2014-10-16 19:32:00 +09:00
eaa7efd136
[ML29] Reinitialize the subtype at input start
...
Bug: 11230254
Bug: 17994347
Change-Id: I3476909c4b371d6e94a0d4c35d91e109d639b8d5
2014-10-16 18:43:14 +09:00
f13487dfbf
[ML25] Add an hasDict method.
...
We used to have separate methods for existence of dicts
according to whether it's a file or a resource. This unifies both.
Bug: 11230254
Bug: 17979623
Change-Id: I728773461f3465f756d06297c3f3bee34390c3e6
2014-10-16 17:09:27 +09:00
17100ad8ea
am 8435acd7: am f7f786d8: am d9c04a6b: am 6456af0e: am ecea8551: Fix a bug with no suggestions flag
...
* commit '8435acd789bd4f9c1322a73b9e0567c2dee7b336':
Fix a bug with no suggestions flag
2014-10-15 07:52:58 +00:00
ecea8551c3
Fix a bug with no suggestions flag
...
We should reset the composition state when moving the cursor inside
the word after a gesture when the text field specifies no suggestions.
Bug: 17959921
Change-Id: I977fea775f7b7e145e343636f0fb94266a40953a
2014-10-15 06:15:02 +00:00
b17a3bc4e8
Move sync policy related code out of account settings
...
Bug: 17981687
Bug: 17464069
Change-Id: I0ae3400564fd346cc84af74dfef65f01cc1ce6a8
2014-10-14 13:39:28 -07:00
296b11503e
Merge "Add JSR305 annotation to LeakGuardHandlerWrapper"
2014-10-14 12:30:12 +00:00
10ac940312
Merge "[ML24] Add facilities to read the script of a subtype"
2014-10-14 11:26:07 +00:00
b256bb5791
[ML24] Add facilities to read the script of a subtype
...
...or more exactly, the script of the keyboard layout set associated
with a given subtype.
Bug: 11230254
Change-Id: I82f5fc81ecffc561781816008c853be6ff9438dd
2014-10-14 20:19:15 +09:00
d1471ee053
Merge "Remove shouldBlockAutoCorrectionBySafetyNet"
2014-10-14 10:52:32 +00:00
c4ffa235e5
Add JSR305 annotation to LeakGuardHandlerWrapper
...
Change-Id: I7456200af739db4510c5549b7bc894fb48749455
2014-10-14 18:19:22 +09:00
95f100ba40
Merge "Performance fix for multiple language subtypes"
2014-10-14 06:42:14 +00:00
d15f6e8c98
Performance fix for multiple language subtypes
...
The code would iterate all enabled subtypes each time
getCurrentSubtype() is called, which is really quite frequent.
Bug: 11230254
Change-Id: I91feb36de6eca84967e848fc585aae04b350be89
2014-10-14 15:13:35 +09:00
9959140f15
Merge "Fix an NPE."
2014-10-14 02:51:16 +00:00
7d74594123
Fix an NPE.
...
Bug: 17958289
Change-Id: I5c9ea668ff75b38c7ddebd767c36a950835c0c9f
2014-10-14 11:42:43 +09:00
cbd59e02a9
Merge "Don't restore debug preferences"
2014-10-14 02:28:50 +00:00
29b4f7aa67
Remove shouldBlockAutoCorrectionBySafetyNet
...
Bug: 13756409
[Category diff]
+1 27
-1 0
+2 0
-2 0
+3 0
-3 1
+4 11
-4 0
+5 51
-5 0
+6 0
-6 38
+7 0
-7 50
[Weighted category diff]
+1 28
-1 0
+2 0
-2 0
+3 0
-3 1
+4 11
-4 0
+5 51
-5 0
+6 0
-6 39
+7 0
-7 50
show diff for ./en_user_log_phones_2011_08.csv
+1 4
+4 5
+5 7
-6 9
-7 7
The increase of false positives comes from the spaceless
typing test cases that are synthetic data.
Change-Id: I4ea77aa56ebfaa5518c71107169e1d2332de6327
2014-10-14 11:20:33 +09:00
06a438d3a5
Don't restore debug preferences
...
Bug: 17942814
Change-Id: I0bbef716dff47ed8eb880209d448629ad853b904
2014-10-13 18:59:48 -07:00
ae3ad8ebdd
(DO NOT MERGE) Fix checking a11y status just before calling an a11y method
...
Cherry picked from Master, commit 04cd8794e0
2014-10-14 01:40:27 +00:00
19084d076a
Cleanup LoginAccountUtils
...
Bug: 17464068
Change-Id: Icf994a7582491afebc5db522c127a30d079ce05c
2014-10-13 12:23:22 -07:00
d9015233f5
Set up a sync preference and policy for syncing [2]
...
- Adds a preference for enabling sync, which controls the sync behavior
- Make the ProductionFlags depend on appropriate flags to guarantee that
we don't mess things when flipping some flags
- Preferences now control the "syncable" property of the provider
thereby controlling the policy and when this entry shows up in
system settings.
Bug: 17464069
Change-Id: I1d58351188518c1ae9f1f9e147b5ea15d32a3427
2014-10-10 16:03:54 -07:00
1e10d29bc8
Don't restore device specific preferences
...
There are two categories of preferences:
1. That are part of the default shared preference
They were all getting backed up and restored.
Added a blacklist to not restore some of these.
e.g. current account
2. That are in a non-default shared preference file.
These are not getting backed up currently, but added a specific
local preference file for all such preferences.
Bug: 17288591
Change-Id: I2f748be971a2337543e5014434aa39313fd1e1d8
2014-10-10 10:49:32 -07:00
6e565332df
Merge "Fixing keyboard theme selection"
2014-10-10 09:28:24 +00:00
7d5e1cb265
[ML23] Introduce a different accuracy/performance tradeoff
...
Bug: 11230254
Change-Id: Ic09518c818ae7b68942b1c63160dd462e5922cb5
2014-10-10 18:02:52 +09:00
4f17f3df46
Fixing keyboard theme selection
...
Bug: 17937287
Change-Id: I476045980843c5897820cd544daea06fa991acb5
2014-10-10 17:42:03 +09:00
5d2d852eb0
[ML22] Improve the language on spacebar for SLS
...
Bug: 11230254
Change-Id: Ib54be1a2a77b6e80cdff1af89a7b4203ea859716
2014-10-10 16:19:48 +09:00
701b14ffa6
Merge "Make SuggestionWordInfo non-final for testabilty"
2014-10-10 05:18:55 +00:00
80f0e89aaf
Remove UsedForTesting tags from BlockingHttpClient
...
Bug: 17464069
Change-Id: I45aa6da0e339ffb56de613c2a0a43fe37fb2defd
2014-10-09 14:30:45 -07:00
eaf517ffea
Merge "Changes related Sync Engine library that communicates to cloud server"
2014-10-09 18:06:32 +00:00
bc18005948
Always show the typed word in recorrections.
...
Bug: 11330140
Bug: 17875601
Bug: 17623275
Change-Id: Ie4620f36f312c54c7b01b5f6cbdb0bc9171b6179
2014-10-09 17:54:58 +09:00
41302021d6
Merge "Rename updateCounter to updateEntriesForWordWithNgramContext."
2014-10-09 08:51:18 +00:00
ab4437f468
Rename updateCounter to updateEntriesForWordWithNgramContext.
...
Bug: 14425059
Change-Id: Id9b0dd7e32c711ed4292981517c3febd5fe9e897
2014-10-09 17:34:29 +09:00
fca049a4b0
Merge "Extend jni method to dump ngram entries."
2014-10-09 08:28:13 +00:00
6547311865
Merge "Simplify CursorAnchorInfoCompatWrapper"
2014-10-09 08:13:50 +00:00
437fcbaa9f
[ML20.1] Move getRichInputMethodSubtype to additional features
...
Bug: 11230254
Change-Id: I9bc19db5f101eeb6841394fe3637f271c93cbfa7
2014-10-09 16:35:15 +09:00
db1b736446
Changes related Sync Engine library that communicates to cloud server
...
This change updates some of the code that the library uses
to communicate with the cloud server
Specifically :
- Update BlockingHttpClient to use template ResponseProcessor
- Update HttpUrlConnectionBuilder to setAuthToken for HttpUrlConnection
Bug: 17464069
Bug: 17464805
Change-Id: I7d7b58dff594b920162f799d102e8582ff9fe6a4
2014-10-09 00:01:32 -07:00
dac49f9f6d
Simplify CursorAnchorInfoCompatWrapper
...
With this CL, we will use CursorAnchorInfoCompatWrapper just to
avoid unexpected NoClassDefFoundError due to the direct
dependency CursorAnchorInfo class, which is available only on
API level 21 and later.
Change-Id: I254ff83f1ca41daa21d0666b5824af22ba529022
2014-10-09 15:54:34 +09:00
d7a51c242b
Extend jni method to dump ngram entries.
...
Bug: 14425059
Change-Id: Ib03b58525fae12f254b45630bee31ecbdde227b1
2014-10-09 15:26:10 +09:00
176e6e22cf
Merge "[ML19] Actually switch the language when appropriate"
2014-10-09 05:12:01 +00:00
81a5a10476
[ML19] Actually switch the language when appropriate
...
That is, when auto-correcting or when manually picking.
This is not great, but it's a good starting point.
Bug: 11230254
Change-Id: I07627f48e2de1c28053d6572c7c72625808ec79c
2014-10-09 13:13:25 +09:00
15480481be
Add keyboard shadow
...
This CL sets 8dp elevation ot input view in order to cast a shadow
onto underlying application.
Bug: 16210054
Change-Id: I7779c63612fc88e24dde65de3e4e7a45b9d1762f
2014-10-09 12:39:15 +09:00
3c6ac75c48
Merge "Fix messaging for sync now feature, when no account is selected"
2014-10-08 23:40:27 +00:00
f66a6a3bb0
Fix messaging for sync now feature, when no account is selected
...
Change-Id: I5e81b7a1eed9c2177ad3ddfa6c96c2b85c433766
2014-10-08 15:26:39 -07:00
9bda19891c
Merge "Stop dimming main keyboard while showing more keys keyboard"
2014-10-08 13:13:26 +00:00
15335d7526
Merge "[ML18] Make WordComposer#getAutoCorrection a word info"
2014-10-08 13:04:25 +00:00
176ad53c6f
[ML18] Make WordComposer#getAutoCorrection a word info
...
Bug: 11230254
Change-Id: I6ad2e7f89862fbfe7af5502961643320c782347f
2014-10-08 21:46:13 +09:00
5b39af37c0
Fix unit test failure
...
Change-Id: I5a28c6775385ba3b0b7d86c85064fd28f3cbb353
2014-10-08 17:27:28 +09:00
6085839627
Stop dimming main keyboard while showing more keys keyboard
...
Bug: 17910364
Change-Id: Ibe76ee86a43c5939f48e45506c985b3f289eac7a
2014-10-08 16:59:21 +09:00
847735fdfa
Merge "Skeleton code for user dictionary sync"
2014-10-08 02:09:50 +00:00
3fbe459fa7
Make SuggestionWordInfo non-final for testabilty
...
Needed for ag/563043
Bug:17731683
Change-Id: I4d19e512a311547204f7e8d7885fc886757a18b7
2014-10-07 18:43:13 -07:00
734733d8ad
Skeleton code for user dictionary sync
...
Bug:17464069
Change-Id: If683b80e882c07fba576959346ae74cd445dd83e
2014-10-07 12:30:12 -07:00
89d7965e76
Merge "Fix NoClassDefFoundError due to CursorAnchorInfo in K"
2014-10-07 10:30:36 +00:00
883bfd2c0b
Fix NoClassDefFoundError due to CursorAnchorInfo in K
...
Check API level before touching CursorAnchorInfo that is only
available in L and later.
BUG: 17891202
Change-Id: I6e8d2e3f071bd78bed8c1d24ba2b97207dea3044
2014-10-07 19:19:20 +09:00
be4e1539cb
[ML17] Add a method to switch the most probable language
...
Also directly hold a ref to it. It's simpler for now, though
we may want to remove it completely later to have a flat,
purely weight-based system with no preference.
Also split weights between gesturing and typing.
Bug: 11230254
Change-Id: Ica15964a193ae6e7f14c85a9a3ed806130fa7efb
2014-10-07 19:09:49 +09:00
38ec825ef8
[ML16] Remove DictionaryFacilitator.getLocale()
...
Bug: 11230254
Change-Id: Ife99df42bc145fbd2d5c3128330bc0f88b104de9
2014-10-07 16:44:26 +09:00
ea07734956
[ML15] First step in removing DictionaryFacilitator.getLocale
...
Bug: 11230254
Change-Id: Ied010ec6f1024080e8a499f682d2fc1780e82ef7
2014-10-07 16:06:35 +09:00
3ead4d7f8a
Merge "Quit having obsolete options for ime-simulator."
2014-10-07 02:03:59 +00:00
639837f85d
Merge "Postponing memory deallocation after onFinishInputView"
2014-10-06 23:45:40 +00:00
6fb586a527
Fix missing prediction words on contextual strip
...
Bug: 17874801
Change-Id: Iaba935a6b2548376f10a0ecd80f07ea7ada6c60a
2014-10-07 00:06:53 +09:00
db6c32778e
Merge "Add a utility method to SuggestionSpanUtils"
2014-10-06 15:03:20 +00:00
7b8f317050
Postponing memory deallocation after onFinishInputView
...
Bug: 17559789
Change-Id: I1d4b1524028164d27ec4eadd3960b567148f2b84
2014-10-06 23:14:48 +09:00
fcc4cbf6f1
Merge "[ML14] Forward the locale list to relevant places, again"
2014-10-06 13:32:32 +00:00
a84a8d38c0
Quit having obsolete options for ime-simulator.
...
Bug: 16547409
Change-Id: I43f5a15153cbd7072fde15764a664ad4d1c6417f
2014-10-06 22:03:39 +09:00
bc051a561f
[ML14] Forward the locale list to relevant places, again
...
Diff:
+++ b/java/src/com/android/inputmethod/keyboard/internal/KeyboardBuilder.java
@@ -735,7 +735,7 @@ public class KeyboardBuilder<KP extends KeyboardParams> {
private boolean matchLocaleCodes(TypedArray caseAttr, final Locale[] locales) {
// TODO: adujst this for multilingual input
- return matchString(caseAttr, R.styleable.Keyboard_Case_languageCode, locales[0].toString());
+ return matchString(caseAttr, R.styleable.Keyboard_Case_localeCode, locales[0].toString());
}
private boolean matchLanguageCodes(TypedArray caseAttr, Locale[] locales) {
Change-Id: Icefac18dd6d5fea97f591177cf8df1ba6de7f4f0
2014-10-06 21:27:32 +09:00
4f04fd95f4
Merge "Remove ENABLE_CURSOR_ANCHOR_INFO_CALLBACK"
2014-10-06 11:02:24 +00:00
81c2dfe9c6
Remove ENABLE_CURSOR_ANCHOR_INFO_CALLBACK
...
We can now start relying on L APIs even in unbundled release.
This means ENABLE_CURSOR_ANCHOR_INFO_CALLBACK can be always true.
Hence we simply remove it.
Change-Id: I0353e992e97e252059f83accea100504594bf171
2014-10-06 19:39:13 +09:00
4bde90bf77
Merge "Update setup wizard video and image of AOSP"
2014-10-06 08:08:11 +00:00
48b707e1bd
Update setup wizard video and image of AOSP
...
Bug: 17769384
Change-Id: I23748bce17566aad1693ff56e8c04f493f957f84
2014-10-06 16:53:22 +09:00
8b24e7abde
Merge "Refactor custom input style settings"
2014-10-06 07:35:34 +00:00
03c1e7955a
Add a utility method to SuggestionSpanUtils
...
This is a ground work for subsequent CLs.
BUG: 16995261
Change-Id: Icbb708a35412a635a0d625b520069840c0bb0904
2014-10-06 16:22:51 +09:00
a48ff4e294
Merge "Add unittest for SuggestionSpanUtils"
2014-10-06 07:20:39 +00:00
9290d0a4eb
Make UserHistoryDictionary use updateEntriesForWordWithNgramContext()
...
Bug: 14425059
Change-Id: I409ebf90f68f4a0f1638128ac5ee6af859323d30
2014-10-06 15:50:38 +09:00
399a3bd930
Refactor custom input style settings
...
This CL removes references of Pair class.
Change-Id: I7cda0ac438ac1d5026599cb52ac2ea8845339da9
2014-10-06 15:39:42 +09:00
ceedaf6321
Add unittest for SuggestionSpanUtils
...
This adds unittest for SuggestionSpanUtils for subsequent CLs.
No behavior change is intended in this CL.
BUG: 16995261
Change-Id: I90d1591cab893a1421ca633963b7c8f00a5fe4b4
2014-10-06 12:24:46 +09:00
6accf63d0a
Make unit tests use new entry updating method.
...
Bug: 14425059
Change-Id: Ie7d92e92822a0d3a8b654d213e55d45aab799f5d
2014-10-06 12:09:15 +09:00
faefad5b0f
Revert "[ML14] Forward the locale list to relevant places"
...
This reverts commit 15dbd38283
2014-10-03 23:48:53 +00:00
15dbd38283
[ML14] Forward the locale list to relevant places
...
Bug: 11230254
Change-Id: Idf3ed27b396d63ade9800c72c5ce0ed613f5f669
2014-10-03 23:20:38 +09:00
826186f66b
Use Devanagari Danda letter as full stop on Nepali keyboard
...
Bug: 17741882
Change-Id: I62e8c9a3f194b9a3a6724c7d1a92292b150ddeb9
2014-10-03 09:48:18 +00:00
332f43275d
Merge "Fix a behavior change in dicttool"
2014-10-03 09:33:28 +00:00
d415747a27
Merge "[ML13] Fix the locale passing in ProximityInfo"
2014-10-03 09:24:49 +00:00
96d31df8c4
Fix when to show input view
...
Bug: 15922840
Bug: 17788786
Change-Id: I69aea682202650b601a295d9da583ef8e05a3982
2014-10-03 18:20:06 +09:00
4ef27c0358
[ML13] Fix the locale passing in ProximityInfo
...
The locale is used to determine additional proximity characters. This
is dependent on the dictionary language, but was passed as a function
of the layout, which is wrong and would have given bad suggestions in
multi-lingual mode.
Ideally, additional proximity characters should be inserted in the
dictionary header, but for now it's a rather simple change to get
it from the dictionary's locale instead of the proximity info locale.
Also, that allows us to remove completely the locale parameter from
proximity info, which is a much needed change.
This change has zero effect on unit tests and on regression tests.
Bug: 11230254
Change-Id: If95157155db7dccd1f00b8ba55ccb3600283f9e4
2014-10-03 18:16:34 +09:00
b28d1cc487
Fix a behavior change in dicttool
...
The behavior change was introduced by I8b3458ad. Concretely,
empty bigram lists would end up as empty lists instead of null.
Change-Id: Ibcdf7e6aabc6aba3f5db0477335882394e050ce5
2014-10-03 18:04:10 +09:00
c92c883fdf
Add calls to stub for API to consume gesture data.
...
Bug: 17400259
Change-Id: Ib3511afffe1d14662e7dd14611f384689516e664
2014-10-03 15:01:34 +09:00
049d642cc4
Fix ellipsizing and text scale x calculation
...
Bug: 17742721
Bug: 11158757
Change-Id: I98b55a8e661804e84f75e75675c6f2ef33ac1a11
2014-10-02 19:58:24 +09:00
45ebb2001d
Merge "Preserve spans when splitting sentences"
2014-10-02 09:29:23 +00:00
371d76ff07
Merge "[ML12] Add a getPrimaryLocale function and some refactoring"
2014-10-02 09:20:04 +00:00
1c0876dc49
[ML12] Add a getPrimaryLocale function and some refactoring
...
Bug: 11230254
Change-Id: Ic579b93702c24f47e6cdb0c9a4da6b11f1fa76c8
2014-10-02 18:15:35 +09:00
7e5614520a
Merge "Include a code point table in the binary dictionary."
2014-10-02 08:55:18 +00:00
a5cdd6f4c5
Merge "Fix unnecessary touch event handling"
2014-10-02 07:51:02 +00:00
3852cfa717
Preserve spans when splitting sentences
...
This CL fixes a bug that span information was unintentionally
removed when given sentences are split into words. Nothing is
changed in KitKat and prior because TextInfo never returns
spanned text until L.
Note that the spell checker service still doesn't rely on
span information even with this CL.
BUG: 16419551
Change-Id: I6ffb75ee6add4ae20e9d3dcfb90b65f097d70fba
2014-10-02 14:08:59 +09:00
c91166de54
Merge "Avoid downloading the metadata in quick succession."
2014-10-02 04:31:08 +00:00
8ab46225b3
Fix unnecessary touch event handling
...
Bug: 17762449
Change-Id: I698ca91ab977aa65c7bd8a5fb82b3d91264cfbca
2014-10-02 12:48:26 +09:00
9168ab60cf
Include a code point table in the binary dictionary.
...
Bug:17097992
Change-Id: I677a5eb3a704e4386f6573360e44ca335d81d2df
2014-10-02 12:27:49 +09:00
2910990065
Merge "Never include the typed word in recorrections"
2014-10-01 10:34:22 +00:00
eff21b653f
Merge "Make a better effort to detect a framework lie."
2014-10-01 10:24:32 +00:00
38144047ea
Make a better effort to detect a framework lie.
...
Bug: 17130496
Change-Id: I1a3631670c152d9b7667c9c4e08e14c48569eef5
2014-10-01 19:17:31 +09:00
7f226b4f9d
Merge "Fix an NPE on ICS factory rom."
2014-10-01 10:16:40 +00:00
57e29436b1
Fix an NPE on ICS factory rom.
...
In ICS factory rom and MR0, there was a bug where calling the
constructor for SuggestionSpan that doesn't take a context as
an argument would always return in a crash. Don't call it,
and pass an explicit context instead.
Bug: 13552505
Change-Id: I5c919499b9d086c2cf283795b2af5b91cb425933
2014-10-01 18:33:47 +09:00
4c90df7e5b
Never include the typed word in recorrections
...
Bug: 17623275
Change-Id: I2461e5e8baf06fb80a05b87f9d3db7a4d1952a01
2014-10-01 18:32:02 +09:00
31c16d41bc
Add Uzbek keyboard
...
Bug: 13222403
Change-Id: I9a4cf447a8ab0c26c4dc7f7794c57390024660cc
2014-10-01 09:29:34 +00:00
79d992ccba
Merge "Use Devanagari Danda letter as full stop on Hindi keyboard"
2014-10-01 09:29:14 +00:00
a987f6d0cc
Use Devanagari Danda letter as full stop on Hindi keyboard
...
Bug: 17418371
Change-Id: I22bb2913015a83604301576e68095974c38b7c9a
2014-10-01 18:20:31 +09:00
bcb439e702
Merge "Add jni method to update entries for a word efficiently."
2014-10-01 08:57:02 +00:00
ce5fd94b97
Add jni method to update entries for a word efficiently.
...
Bug: 14425059
Change-Id: Ic628939ea68cdee17573409883a8403c73b78905
2014-10-01 17:40:20 +09:00
d368975cdb
Merge "Add Akkhor Layout for Bengali Bangladesh"
2014-10-01 08:13:46 +00:00
f41c11a5c0
Merge "Fix when to show more suggestions dot hint"
2014-10-01 07:58:28 +00:00
0487290f0f
Merge "Fix NPE in KeyboardParams"
2014-10-01 07:54:47 +00:00
108dad1491
Merge "Introduce NgramProperty in Java side."
2014-10-01 07:53:04 +00:00
23b35a9689
Fix when to show more suggestions dot hint
...
Bug: 17742406
Change-Id: Ifdf5d196778da2bb9bb9e3ca9250d23857d90bab
2014-10-01 16:50:28 +09:00
dbf5701ee0
Fix NPE in KeyboardParams
...
Bug: 17707885
Change-Id: Ie6a54ac5ab60f5d11363ac8da8eef850d65dba7c
2014-10-01 16:08:58 +09:00
9d92d3e02d
Avoid downloading the metadata in quick succession.
...
Bug: 17668298
Bug: 8651816
Bug: 17709442
Change-Id: Ib232f9d95d7c01a028be85d10f974a5a570c0ed5
2014-10-01 12:20:27 +09:00
7b673c7265
am 5139c4fd: am 702a736e: am 31838876: am 9baaa4b5: am 6ad437ed: Merge "Fix NPE due to the lack of null-check" into lmp-dev
...
* commit '5139c4fd28d1a34981d590f2fbec9b407481ea52':
Fix NPE due to the lack of null-check
2014-10-01 02:26:35 +00:00
c6a6f6a990
Introduce NgramProperty in Java side.
...
Bug: 14425059
Change-Id: I8b3458ad22730b3dccbe0caea2c5930f5276dc82
2014-10-01 11:21:08 +09:00
0187db39b5
Merge "Add StatsUtils#onLoadSettings for when settings are changed"
2014-10-01 00:41:32 +00:00
cc7e44e34c
Add StatsUtils#onLoadSettings for when settings are changed
...
Non-blocking call in nature.
Bug:17013677
Change-Id: Iff737422bbacbf22c9b0ff6eaf1c1f75e6bf23c3
2014-09-30 17:09:00 -07:00
9586d69bdf
Avoid double space when autocorrect is triggered
...
Bug: 17596034
Change-Id: Iaa6cc066eefd2436195a91791f2628e9a5f1c449
2014-09-30 15:48:48 +09:00
de12c1bf49
Fix NPE due to the lack of null-check
...
The case that was not coverted well is that
CursorAnchorInfoCompatWrapper could be instantiated
with null object. In such situations, we should
do nothing.
BUG: 17682582
Change-Id: I6625a2f0ed8c5580ed9edfe4728f342da77a8e40
2014-09-29 17:03:29 +09:00
4936d259d7
Merge "Fix verbalizing missing emoticons"
2014-09-29 06:39:30 +00:00
5e828b2c61
Merge "Create a code point table based on occurrence counts."
2014-09-29 06:31:33 +00:00
d9d5ba4287
Fix verbalizing missing emoticons
...
Bug: 15585153
Change-Id: I8ae184047558d1a78e20efde0b08e40beb4458b9
2014-09-29 15:15:18 +09:00
a4a4e9d96b
Merge "Rename PrevWordsInfo to NgramContext."
2014-09-29 03:00:55 +00:00
33b0ebff27
Merge "Refactoring PrevWordsInfo."
2014-09-29 02:33:00 +00:00
bb0eca5705
Rename PrevWordsInfo to NgramContext.
...
Bug: 14425059
Change-Id: Id06a71681fa8b5e589e29fba10fe5c1cfed66984
2014-09-29 10:52:18 +09:00
76150b8133
Add Akkhor Layout for Bengali Bangladesh
...
Bug: 16143057
Change-Id: I0b4a3d0d1125f9af25a98ee7a1852129ae1c1d2c
2014-09-26 18:20:25 +00:00
569f6f1c9e
Merge "Add authentication/http request related code to LatinIme"
2014-09-26 17:22:12 +00:00
05274d5a0d
Add authentication/http request related code to LatinIme
...
Bug: 17464068
Bug: 17464805
Change-Id: I533ae8821e0628fdf6591538a96ab50f805c0cdf
2014-09-26 10:14:24 -07:00
bbd6a26be0
Refactoring PrevWordsInfo.
...
Bug: 14425059
Change-Id: I48a193b965e3055bd10a00046322c2b7b19a6232
2014-09-26 21:46:57 +09:00
dade81d78c
Fix adding more diacritics letters for Nordic languages
...
Bug: 10787354
Change-Id: Ia71417069a0cc10d7908d0c404ce85eb0cd76540
2014-09-26 20:21:17 +09:00
8108a3e1cd
Add Serbian Latin keyboard
...
Bug: 9687668
Change-Id: I0631ab04cf33e3d454c965e98a756c31666537bf
2014-09-26 16:01:34 +09:00
8a6e96d286
Create a code point table based on occurrence counts.
...
Bug:17097992
Change-Id: Ifd76dbd4d385d800af416368e25c9e56a76d0fbf
2014-09-26 15:15:16 +09:00
1c70a8e147
Merge "Add info log of custom input styles"
2014-09-26 03:56:22 +00:00
10a93dc80c
Add info log of custom input styles
...
Bug: 17622871
Change-Id: Ia97c7bc2f0923417b458b178fbd8776d5cd0758c
2014-09-26 12:51:42 +09:00
90058c3d1f
Add an internal state test to ImportantNoticeUtilsTests
...
On some 32bit-x86 testing emulators, it seems the internal state after
clear the related settings seems like a contradiction state. This CL
adds an test to check such internal state in order to investigate what
is happening on these emulators.
Bug: 17635340
Change-Id: Iba85f06c46959b1dc22e2a9213c50c9e7e30949b
2014-09-26 12:16:54 +09:00
f99cce8615
Merge "Fix checking a11y status just before calling an a11y method"
2014-09-25 14:14:28 +00:00
aaefd56661
Add !string/<resource_name> reference
...
This CL introduces new text reference notation !string/<resource_name>
to refer a string resource on the fly.
This notation is mainly used to represent action key labels may refer
a string in a system locale in run-time.
This notation is needed to implement Hinglish and Serbian-Latin
keyboards that need to refer its own action key labels.
Bug: 17169632
Bug: 9687668
Change-Id: I042f6bd04714e0e448cd92031730eb9fb422e6d3
2014-09-25 18:27:23 +09:00
04cd8794e0
Fix checking a11y status just before calling an a11y method
...
Bug: 17035860
Change-Id: I9627d525a570ced085281b4db93fe6896081e818
2014-09-25 18:24:17 +09:00
951252bf47
Merge "Get stats from dictionary."
2014-09-25 08:24:55 +00:00
22e2fa372c
Merge "Add allowRedundantMoreKeys attribute"
2014-09-25 08:20:19 +00:00
2828d9eda7
Merge "[ML10.1] Adjust call for additional features"
2014-09-25 08:19:47 +00:00
0be4e6e585
Add allowRedundantMoreKeys attribute
...
This CL also adds a couple of custom layout tests of Nordic languages.
Bug: 10787354
Change-Id: I5e875d3f30863395511afa82f0a02deb093d3a6f
2014-09-25 15:12:06 +09:00
8da2052113
[ML10.1] Adjust call for additional features
...
Bug: 11230254
Change-Id: I7b60d9174d7d267eb1b3cd848cff36cdbea75b12
2014-09-25 12:50:11 +09:00
a40db55d9b
Merge "Fix typo."
2014-09-25 02:52:12 +00:00
97465afbf8
Fix typo.
...
Change-Id: Ib090a3dfa7e53232e0d1ef5e4d2cbe48130f657f
2014-09-25 11:50:30 +09:00
145f05d637
Merge "Add account change receiver to handle account removal"
2014-09-24 23:40:58 +00:00
d4aec65f65
Add account change receiver to handle account removal
...
Also cleanup the manifest to group similar components together.
Moving LoginAccountUtils to its own package
Bug: 17464068
Change-Id: Iad7928855531d58334b1e4039bb45b97dde75462
2014-09-24 13:10:54 -07:00
21f038ee0a
Stop showing more suggestions while important notice is showing
...
Bug: 15812659
Change-Id: I314e235cfffae3ae655320a9a75867efc28066bf
2014-09-24 14:12:05 +09:00
064ba6bc0a
Merge "Fix Turkish/Azerbaijani keyboard to add more accented letters"
2014-09-24 03:36:10 +00:00
9a73a79cbe
Merge "Fix not intercepting touch event while in modal mode"
2014-09-24 03:24:18 +00:00
3db17c5394
Merge "[ML9.1] Add option for multi-lingual support"
2014-09-24 02:42:46 +00:00
620bfb9bb9
am 4c4ba10b: am 71b51590: am a76e11a2: am 1f490d6c: am be4e0d0e: Fix when to show important notice
...
* commit '4c4ba10bbb257036d7cb6ae8a128263285b7384f':
Fix when to show important notice
2014-09-23 16:18:45 +00:00
9997853d6f
Merge "Prepare supporting n-gram for user history dictionary."
2014-09-23 10:18:41 +00:00
e2e48eb9b3
Merge "Add StatsUtilManager.onStartInput & onFinishInput"
2014-09-22 16:15:14 +00:00
ddfaeff544
Prepare supporting n-gram for user history dictionary.
...
Bug:17097992
Change-Id: Ic8bfde3d4cc0e720bf7681e08e16fb2ad94d5670
2014-09-22 18:18:50 +09:00
4b0dba4cd8
[ML9.1] Add option for multi-lingual support
...
Bug: 11230254
Change-Id: I15d42fad155142fa6f556f13e84cad489be00dbd
2014-09-22 17:41:37 +09:00
d144b7874e
Fix not intercepting touch event while in modal mode
...
Bug: 17600156
Change-Id: Ife8f04550411d88311e08dd33e370a410d791ca2
2014-09-22 15:30:29 +09:00
b12c174c2f
Merge "Hiding SuggestedWords.EMPTY and refactoring code that compares SuggestedWords instances directly to it to use isEmpty instead"
2014-09-22 06:20:25 +00:00
30f4a2a4d7
Hiding SuggestedWords.EMPTY and refactoring code that compares SuggestedWords instances directly to it to use isEmpty instead
...
Bug: 17560717
Change-Id: I7032bf0ab46f9cf5e3b3312a14e689b5496764c1
2014-09-22 14:50:21 +09:00
be4e0d0e39
Fix when to show important notice
...
This CL introduces a timeout duration to show an important notice
message. When the timeout has passed, the important notice message
will be suppressed without user intervention.
This CL also adds unit tests and fixes a bug in
getNextImportantNoticeTitle().
Bug: 17181982
Change-Id: If321c0060cc2f7ca14ad0631b84f4990f88bd659
2014-09-22 14:28:31 +09:00
6a6137325b
Add StatsUtilManager.onStartInput & onFinishInput
...
Bug:15657192
Change-Id: I6e976202812d1c1675bd7822c4a15686d1ec1fe9
2014-09-21 20:19:12 -07:00
825747348b
Merge "Create DictionaryStats in executor."
2014-09-22 02:49:04 +00:00
8f116d7cda
Merge "Invoke onWordCommitUserTyped on startInput() with non empty wordcomposer"
2014-09-22 02:13:21 +00:00
8ea51a2760
Fix Turkish/Azerbaijani keyboard to add more accented letters
...
Bug: 16807005
Change-Id: Ifd0ab3aeb8207cdecacf8cfe5b1d58c07690142f
2014-09-22 10:55:08 +09:00
743a9b4499
Get stats from dictionary.
...
Bug: 16553957
Change-Id: I70c7a7be3c902dc8a0dfe8f946f9ef75ba6c9655
2014-09-22 10:26:19 +09:00
c724864c61
Create DictionaryStats in executor.
...
Bug: 16553957
Change-Id: Ie4e9a6ee67f90ba0086af2075068e078efc7f189
2014-09-22 10:25:51 +09:00
c514d64bff
am d8c83fb8: am 88cae78f: am 89dd5f03: am c1d35148: am f2d0d9b0: Merge "Avoid the add-to-dictionary indicator from being clipped" into lmp-dev
...
* commit 'd8c83fb81bb06e22ab0857e1a7531c666ad8701e':
Avoid the add-to-dictionary indicator from being clipped
2014-09-20 04:46:48 +00:00
f2d0d9b0b9
Merge "Avoid the add-to-dictionary indicator from being clipped" into lmp-dev
2014-09-20 03:58:03 +00:00
Mohammadinamul Sheik
Dan Zivkovic
Mario Tanev
Chieu Nguyen
Jean Chalard
Jatin Matani
Tadashi G. Takaoka
Keisuke Kuroyanagi
Andy Wang
Adrian Velicu
Ken Wakasa
David Faden
Yohei Yukawa
Nick Kralevich
Sandeep Siddhartha
Akifumi Yoshimoto
