3c8b26a71f
am 3f8c6b8c: Merge "Add description of disabled voice input key option"
...
* commit '3f8c6b8c54b6a0cf15da10c3c2fcf80c9af27c42':
Add description of disabled voice input key option
2014-01-05 19:28:06 -08:00
3f8c6b8c54
Merge "Add description of disabled voice input key option"
2014-01-06 03:25:15 +00:00
12ba821bfb
Add description of disabled voice input key option
...
Bug: 12377179
Change-Id: I44d35c6fa82883710674ecca6f630d09076472fe
2014-01-06 12:11:55 +09:00
c6f0674c6f
am e91559a1: Merge "Update shortcut IME info before checking availability of it"
...
* commit 'e91559a1197e794f3c41e442900907a680d0c91d':
Update shortcut IME info before checking availability of it
2014-01-05 19:09:35 -08:00
e91559a119
Merge "Update shortcut IME info before checking availability of it"
2014-01-06 03:07:23 +00:00
b0e81cdf77
am e9584a16: Merge "Add DictionaryFacilitatorForSuggest constructor for testing"
...
* commit 'e9584a161249e1045de0909db45b224660a8e3ef':
Add DictionaryFacilitatorForSuggest constructor for testing
2014-01-05 19:00:36 -08:00
e9584a1612
Merge "Add DictionaryFacilitatorForSuggest constructor for testing"
2014-01-06 02:58:12 +00:00
b7c531b751
Update shortcut IME info before checking availability of it
...
Bug: 12377179
Change-Id: I4e2de78dc7e21f3f34eb56c790160b77cfc7584c
2014-01-06 11:54:46 +09:00
49b5fadae1
Add DictionaryFacilitatorForSuggest constructor for testing
...
This change must be checked in together with I00b6e79d6b.
Change-Id: Id5f87a8d0286eb44958381fefd428f16896dc0d4
2014-01-06 11:00:51 +09:00
97966af6d7
am 1e50c681: [IL52] Remove a useless method.
...
* commit '1e50c681af56dd77d97a1e6d463f1e3023c1a69b':
[IL52] Remove a useless method.
2013-12-27 05:54:15 -08:00
1e50c681af
[IL52] Remove a useless method.
...
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.
Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.
Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
2013-12-27 22:40:19 +09:00
85adaab7bc
am 8ce921dd: [IL51] Make private what can be made private
...
* commit '8ce921dd6ba5c63a2dc44b7578a3587aa7dc75c7':
[IL51] Make private what can be made private
2013-12-27 04:27:35 -08:00
17c67ab802
am 53c320e2: [IL50] Move the InputUpdater out of LatinIME.
...
* commit '53c320e2757ec37e40dc1dc54a2b04a05a995003':
[IL50] Move the InputUpdater out of LatinIME.
2013-12-27 04:27:32 -08:00
8ce921dd6b
[IL51] Make private what can be made private
...
Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
2013-12-27 21:09:47 +09:00
53c320e275
[IL50] Move the InputUpdater out of LatinIME.
...
...at last
Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
2013-12-27 21:09:41 +09:00
b70d74a3f9
am 81e0ca5f: [IL49] Move InputLogic-related init code to InputLogic.
...
* commit '81e0ca5fd395fd67c7b93e7d87e7d90fa136f065':
[IL49] Move InputLogic-related init code to InputLogic.
2013-12-27 03:55:05 -08:00
98c0121ccd
am 4970eda2: Fix a failing test
...
* commit '4970eda28628e044f90fb8425edcd0aa01f7c3dd':
Fix a failing test
2013-12-27 03:55:02 -08:00
81e0ca5fd3
[IL49] Move InputLogic-related init code to InputLogic.
...
Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
2013-12-27 20:06:39 +09:00
4970eda286
Fix a failing test
...
How/when did this happen? How was it not noticed?
Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
2013-12-27 20:04:41 +09:00
394c63a501
am d05ea8bd: Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic."
...
* commit 'd05ea8bd829da4110e86c38629fba94b4f560033':
[IL48] Move onEndBatchInputAsyncInternal to InputLogic.
2013-12-27 00:09:19 -08:00
d05ea8bd82
Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic."
2013-12-27 08:06:48 +00:00
e099325f99
am af26a441: Merge "[IL47] Inline getSuggestedWordsGestureLocked"
...
* commit 'af26a44102c004844546cb8d049aa43b629f3598':
[IL47] Inline getSuggestedWordsGestureLocked
2013-12-27 00:06:03 -08:00
af26a44102
Merge "[IL47] Inline getSuggestedWordsGestureLocked"
2013-12-27 08:04:51 +00:00
ab14bb51c8
am 51e79fb4: Merge "[IL46] Remove a useless message passing."
...
* commit '51e79fb4b2025985f7cc29f43357d60c6889e3ff':
[IL46] Remove a useless message passing.
2013-12-26 23:59:26 -08:00
d2c0bed052
am 2fc1cc09: Merge "[IL45] Remove lingering messages"
...
* commit '2fc1cc099f27442c9a3f93f8a49dd333c83a2abe':
[IL45] Remove lingering messages
2013-12-26 23:59:24 -08:00
51e79fb4b2
Merge "[IL46] Remove a useless message passing."
2013-12-27 07:56:56 +00:00
2fc1cc099f
Merge "[IL45] Remove lingering messages"
2013-12-27 07:56:44 +00:00
c654fe57b1
[IL48] Move onEndBatchInputAsyncInternal to InputLogic.
...
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
2013-12-27 16:50:08 +09:00
4a144b9b4d
[IL47] Inline getSuggestedWordsGestureLocked
...
This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.
Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
2013-12-27 16:50:08 +09:00
71a3e96382
[IL46] Remove a useless message passing.
...
The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords
The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.
Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
2013-12-27 16:50:06 +09:00
3735857dc9
am 0d212235: Merge "[IL44] Some factorization"
...
* commit '0d212235211e5860242baf4c77a25ae2166b5498':
[IL44] Some factorization
2013-12-26 23:00:39 -08:00
0d21223521
Merge "[IL44] Some factorization"
2013-12-27 06:58:12 +00:00
31ff2a4335
[IL45] Remove lingering messages
...
Bug: 8636060
And possibly bug: 12085864
Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
2013-12-27 15:34:30 +09:00
69e7a0d24d
[IL44] Some factorization
...
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.
Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
2013-12-27 15:34:26 +09:00
5d5537b2de
am c197b9ed: Merge "Make setAdditionalDictionaries private."
...
* commit 'c197b9ed902f6ea8f14764bbe04c9f1541bfb8f5':
Make setAdditionalDictionaries private.
2013-12-26 22:24:45 -08:00
c197b9ed90
Merge "Make setAdditionalDictionaries private."
2013-12-27 06:22:18 +00:00
913173131e
am 86da47e8: Fix possible NPE in FileUtils.
...
* commit '86da47e8d72f275b7f6e111930dfe205cb34423f':
Fix possible NPE in FileUtils.
2013-12-26 22:07:20 -08:00
86da47e8d7
Fix possible NPE in FileUtils.
...
Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
2013-12-27 14:58:38 +09:00
abc3d0eb56
Make setAdditionalDictionaries private.
...
Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
2013-12-27 14:49:32 +09:00
99dfe3f273
am 6bca9ac4: Fix a bug where predictions would not pop upon manual pick
...
* commit '6bca9ac43d0db9a83b02577783cc609ecf13e3f4':
Fix a bug where predictions would not pop upon manual pick
2013-12-26 06:39:28 -08:00
6bca9ac43d
Fix a bug where predictions would not pop upon manual pick
...
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
2013-12-26 23:19:29 +09:00
b9c96ca75a
am 33b2aaaf: Merge "Fix a code path that looks ridiculous"
...
* commit '33b2aaafc25acbfae1a670435ceb7cd7fe624a1c':
Fix a code path that looks ridiculous
2013-12-26 05:43:23 -08:00
33b2aaafc2
Merge "Fix a code path that looks ridiculous"
2013-12-26 13:39:21 +00:00
f294ed3308
Fix a code path that looks ridiculous
...
Bug: 12295276
Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
2013-12-26 22:28:16 +09:00
06b7e9e8f5
am f441047f: [IL43] Small cleanup
...
* commit 'f441047fadd6bc60b05274ca4a7195e4ff4b680d':
[IL43] Small cleanup
2013-12-26 05:17:52 -08:00
654fe9724d
am c28f0288: [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync
...
* commit 'c28f02880c307c1bf7c11a755765ea6354150bd4':
[IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync
2013-12-26 05:17:48 -08:00
f441047fad
[IL43] Small cleanup
...
All calls are already passing this
Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
2013-12-26 22:12:24 +09:00
c28f02880c
[IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync
...
Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
2013-12-26 22:12:22 +09:00
c3f4239ed7
am 70433efc: [IL41] Remove a useless call and trampoline.
...
* commit '70433efc41970b4dc475b7e446388430aaf801b9':
[IL41] Remove a useless call and trampoline.
2013-12-26 05:11:23 -08:00
70433efc41
[IL41] Remove a useless call and trampoline.
...
No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.
Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
2013-12-26 21:58:41 +09:00
Tadashi G. Takaoka
Jean Chalard
Keisuke Kuroyanagi