Commit graph

5747 commits

Author SHA1 Message Date
Keisuke Kuroyanagi
581ca435cf Merge "Implement addMultipleDictionaryEntries as a jni method." 2013-11-26 07:32:23 +00:00
Jean Chalard
045fb2de64 Fix caps mode upon gesture-after-type-period.
Bug: 11630231
Change-Id: Id5626a2f5b7294e4fda0bf9b82ff85537500a104
2013-11-26 16:25:09 +09:00
Keisuke Kuroyanagi
ca16be7552 Implement addMultipleDictionaryEntries as a jni method.
Bug: 11757169

Change-Id: Ie1569e0b3c0503588ebfe5d09c7ca06116f54485
2013-11-26 16:03:10 +09:00
Tadashi G. Takaoka
ad4216becd Use InputMethodSubtypeCompatUtils to create subtypes
This change adds fixed subtypeId to dummy NO_LANGUAGE and EMOJI
subtypes.

Bug: 11142698
Change-Id: Ie633b5dea77f17a9981bd999df6e1957bde740ee
2013-11-26 15:32:14 +09:00
Tadashi G. Takaoka
6f490fb200 Fix extraValue of DUMMY_NO_LANGUAGE_SUBTYPE
This is a follow up of I9cf3d94825.

Change-Id: I2646a045d21f2a7a3bb89c76d431be844e739af3
2013-11-26 13:31:18 +09:00
Jean Chalard
b68e613016 Merge "Fix a flaky test." 2013-11-25 08:53:47 +00:00
Jean Chalard
e629f860d1 Fix a flaky test.
Corrections depend on the proximity info, which depends
on the layout, which in turn depends on the subtype and
not only the language. Thus, we need to force the whole
subtype for meaningful tests.

Bug: 11142685
Change-Id: I9cf3d948259e0236061454a93ffc2e28c7e0768f
2013-11-25 17:22:15 +09:00
Jean Chalard
3e4c520dcf Merge "Fix a failing test" 2013-11-25 04:01:28 +00:00
Jean Chalard
a78b0f6b9e Fix a failing test
Bug: 11846748
Change-Id: Ieda55477201c11fb31b0f84e70ecd081211c78fc
2013-11-25 12:55:52 +09:00
Kurt Partridge
801d140176 Use Google Feedback
Change-Id: Icc39898fc9216a91e5a75958a959aa52d0ccea73
2013-11-22 18:02:18 -08:00
Tadashi G. Takaoka
585fa0491a Implement key preview zoom in/out animations
Bug: 11518021
Change-Id: I139b18708055e0811234886578c5a30b8cc71fec
2013-11-22 19:50:45 +09:00
Tadashi G. Takaoka
7c542558bf Merge "Update Color Scheme summary explicitly" 2013-11-22 10:33:30 +00:00
Tadashi G. Takaoka
b0b1982442 Update Color Scheme summary explicitly
Bug: 11622614
Change-Id: I5464054425e4d688eaa39f96ba9a3a3c613c6f42
2013-11-22 19:21:30 +09:00
Tadashi G. Takaoka
9eb8814931 Add configuration boolean for fading key top letter
Bug: 11518021
Change-Id: I1297a258650f4b2f81b942bbfbfbc2dba686ef20
2013-11-22 18:21:37 +09:00
Ken Wakasa
16d1e77a16 Merge "handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL" 2013-11-22 07:28:15 +00:00
Ken Wakasa
89182e8fea handleBackspace should always send KEYCODE_DEL for InputType.TYPE_NULL
bug: 11797053
Change-Id: I295eeb5f9f0f1f07e919bf54122d003be150a174
2013-11-21 17:48:09 +09:00
Tadashi G. Takaoka
42d9980a84 Rename ambiguous feature name and related resources
Bug: 11737015
Change-Id: I39f7ca13b99f019a2edb5aa690e3142ceba4e837
2013-11-21 10:52:53 +09:00
Keisuke Kuroyanagi
d39371e231 Merge "Fix: PtNode array size writirng when array size > 127." 2013-11-20 10:07:19 +00:00
Keisuke Kuroyanagi
680f66023c Fix: PtNode array size writirng when array size > 127.
Bug: 11772864
Change-Id: Ib729ceedbc8ef837e50490439817b36039ae2b4e
2013-11-20 18:15:59 +09:00
Tadashi G. Takaoka
d088e0e726 Merge "Don't draw key top letter when key preview is showing" 2013-11-20 08:42:34 +00:00
Tadashi G. Takaoka
818ece917f Don't draw key top letter when key preview is showing
Bug: 11518021
Change-Id: Ibd33e892b21189a7d044099942845379aa010484
2013-11-20 17:26:02 +09:00
Tadashi G. Takaoka
3a1be7e4cf Merge "Unbundle Key preview text and PointerTracker" 2013-11-20 05:46:25 +00:00
Tadashi G. Takaoka
e9ec4d1add Merge "Fix more keys keyboard display position" 2013-11-20 05:46:17 +00:00
Tadashi G. Takaoka
f914f8814c Unbundle Key preview text and PointerTracker
This change binds key preview text with Key.

Bug: 11518021
Change-Id: I5028e1108d6a5728e4feac7f6f945453eea679b6
2013-11-20 14:09:29 +09:00
Keisuke Kuroyanagi
dd0da393e1 Add DEBUG_DUMP to ContactsBinaryDictionary.
Change-Id: Iebfae5f37727deeb6636ad6301b7b1bbe5f454e0
2013-11-20 14:07:44 +09:00
Tadashi G. Takaoka
0381415423 Fix more keys keyboard display position
This is a follow up of Ia39b3d6de8.

Change-Id: I9e6152fdc5cb9fa9490b41fcf0420b9ffccea438
2013-11-20 14:00:03 +09:00
Satoshi Kataoka
994530d9bd Show source dictionary name of suggestions in the debug mode
Bug: 11772864
Change-Id: I393352494b1ef81d24622a22fe7556d09945d6ff
2013-11-20 12:31:01 +09:00
Keisuke Kuroyanagi
077b3def52 Merge "Create a method to add multiple dictionary entries." 2013-11-19 09:41:14 +00:00
Keisuke Kuroyanagi
da2ccbd4cd Create a method to add multiple dictionary entries.
Bug: 11740462
Change-Id: I7903cb02fd08d649a05b8799fb3cd00c3da26e00
2013-11-19 18:12:07 +09:00
Keisuke Kuroyanagi
eacb44b38d Show amanatto settings only when in debug mode.
Bug: 11740462
Change-Id: I206b16ab785215c6fa64e740a6dd46588c633ec8
2013-11-19 14:40:20 +09:00
Kurt Partridge
0a51c2b657 Merge "Track selection end in RichInputConnection" 2013-11-16 00:55:43 +00:00
Kurt Partridge
d564466d30 Track selection end in RichInputConnection
Change-Id: Ie5cffe03b676dcde83896cda139b42f3829eb528
2013-11-15 16:49:24 -08:00
Tadashi G. Takaoka
2cbcc987ee Merge "Fix unusual NPE after onDestroy" 2013-11-15 09:03:51 +00:00
Tadashi G. Takaoka
ffb064656e Fix unusual NPE after onDestroy
Bug: 11673978
Change-Id: I4d5268312911685ff1ca9483a62442a1a9686c62
2013-11-15 17:48:10 +09:00
Tadashi G. Takaoka
be734d298a Return copied String array from getStringArray method
In the Key class constructor, elements in a String[] instance returned
from DeclaredKeyStyle.getStringArray() may be altered by
KeySpecParser.get(Int|Boolean)Value methods.

Bug: 11245712
Change-Id: I3a7fc5ccdb2a14efb72c402dd11559ab13e08596
2013-11-15 17:19:23 +09:00
Kurt Partridge
2bf3a77814 Rename mExpectedCursorStart to mExpectedSelStart
Change-Id: If23d8bd73fe464f12f473e093dc87ed68756e1ec
2013-11-14 07:45:02 -08:00
Kurt Partridge
a2632aabf7 Merge "Extract method to reloadTextCache()" 2013-11-14 15:28:07 +00:00
Tadashi G. Takaoka
f7bb78fb58 Merge "Add keyboard color switch option" 2013-11-14 09:33:09 +00:00
Tadashi G. Takaoka
4c8a96cf88 Merge "Fix additional subtype id calculation" 2013-11-14 09:04:33 +00:00
Tadashi G. Takaoka
053424e56e Merge "Add StringUtils.joinCommaSplittableText" 2013-11-14 09:04:24 +00:00
Tadashi G. Takaoka
b4c7a10840 Add keyboard color switch option
Bug: 11622614
Change-Id: I25aa1ff7376fe72fd94ab2cb7190c61d7a98a1af
2013-11-14 17:56:07 +09:00
Tadashi G. Takaoka
1d1db42d89 Fix additional subtype id calculation
Bug: 11678247
Change-Id: I4a2061fae264473e1ebff6961aa897367ef9cc09
2013-11-14 17:45:53 +09:00
Tadashi G. Takaoka
6589751ace Add StringUtils.joinCommaSplittableText
Change-Id: I80ad9d8b5aee53f1403486a56ffae8d09cbd4e28
2013-11-14 17:43:03 +09:00
Keisuke Kuroyanagi
97fdb184bc Purge ExpandableDictionary.
Bug: 11245133
Change-Id: Ia0886686d8add940409dcd5c883c34eb5289380d
2013-11-14 14:18:02 +09:00
Jean Chalard
5a0bc6ac69 Fix many small nits.
...the interaction of which results in a very bad bug.

Bug: 11648854
Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
2013-11-13 14:42:27 +09:00
Tadashi G. Takaoka
a2a1096406 Revert back punctuations to the more keys keyboard of the period
Bug: 11621857
Change-Id: I157164910fc6f23ef36c838d0a13792c766be223
2013-11-12 14:46:40 +09:00
Tadashi G. Takaoka
1c95c8ba3b Add JB/ICS resources from Azuki MR1 release
Bug: 11622614
Change-Id: I126fc42dd31e912788db0446b67a9d4ea80f848e
2013-11-12 13:04:47 +09:00
Tadashi G. Takaoka
c10757e8e8 Rename KLP theme related resources
Bug: 11622614
Change-Id: I4e390aa263349d730b47502d84e4d528e7f5ce71
2013-11-11 20:01:00 +09:00
Tadashi G. Takaoka
4b37b2b3f6 Rename KLP/JB/ICS common resource name suffixes to _holo
Bug: 11622614
Change-Id: I53b5ff8b6627a38aef352855ad024213a450b40f
2013-11-11 19:08:07 +09:00
Jean Chalard
af8df16887 Remove an out-of-place check
Bug: 11584525
Change-Id: I76cc3e4ee21d62fbd56042adcf085efd5cafb53f
2013-11-08 20:32:43 +09:00
Tadashi G. Takaoka
541fa7858d Add keyLabelHintVerticalAdjustment attribute
Bug: 11546184
Change-Id: I1fbdbbdcf4d6a74888c48f2e4f0b7afce7913653
2013-11-07 19:29:23 +09:00
Tadashi G. Takaoka
4d49908682 Move reference char/digit width/height method to TypefaceUtils
Change-Id: I3c94c23c31b273a07e145d381587ab0aa4ee8e68
2013-11-07 18:39:42 +09:00
Tadashi G. Takaoka
0a4f4b2bbd Add autoScale Key attribute
Bug: 11546184
Change-Id: I754e98dbc0689dbf14c52d4906141a150bde97a6
2013-11-07 16:56:37 +09:00
Kurt Partridge
4e1f8be3e5 Extract method to reloadTextCache()
Change-Id: Ibdaa9553cafeded15f800077606378b06af755cb
2013-11-06 23:43:56 -08:00
Tadashi G. Takaoka
0ea72c8519 Separate action key labels to strings-action-keys.xml
Bug: 11562208
Change-Id: I70390f9eafe51f16ff47b2e39454d1948a259469
2013-11-07 15:12:55 +09:00
Tadashi G. Takaoka
aaf532e641 Fix possible RuntimeException in parsing saved addtional subtypes
Bug: 11488129
Change-Id: I91f333aee9f3ae8d4b1d5e67d47de30f361947f3
2013-11-06 17:16:24 +09:00
Tadashi G. Takaoka
463674f950 Merge "Remove unused vertical scrollable KeyboardView" 2013-11-05 10:26:14 +00:00
Tadashi G. Takaoka
78d2895c8d Remove unused vertical scrollable KeyboardView
Bug: 11517736
Change-Id: I9d71290112c2306336e136c94b628b533e386aaa
2013-11-05 19:15:20 +09:00
Keisuke Kuroyanagi
9b3e59d644 Implement ver4 bigram reading method.
Bug: 11073222
Change-Id: I7b3408938f304da361201892e0a1342fdf92e62e
2013-11-05 16:00:26 +09:00
Keisuke Kuroyanagi
67cff29fd4 Merge "Fix UserHistoryDictIOUtilsTests by adding @UsedForTesting." 2013-10-29 04:48:05 +00:00
Keisuke Kuroyanagi
82c962f1e0 Fix UserHistoryDictIOUtilsTests by adding @UsedForTesting.
Change-Id: I1bfeeafa002496bb98a385b87437e7f4eb0f6e1d
2013-10-28 21:46:05 -07:00
Satoshi Kataoka
40a3712a4c Merge "Show version in dumped info" 2013-10-29 02:43:09 +00:00
Satoshi Kataoka
5982b1ea08 Show version in dumped info
Bug: 10315296
Change-Id: Icb8e271451f4f9c5b083bfb5eb408372479c2140
2013-10-28 19:22:20 -07:00
Keisuke Kuroyanagi
388c953613 Fix tests by adding @UsedForTesting.
Change-Id: I5b98db67a083bde65bb0f2fb714ae2e799fb1d45
2013-10-28 17:16:01 -07:00
Satoshi Kataoka
ba212e9d76 Add a facility to dump the dictionary contents while closing
Change-Id: I02e920e0512f2b46a778f0b23f7ca03f8d5dabe6
2013-10-28 11:25:38 -07:00
Keisuke Kuroyanagi
8e9df884aa Add a test for ver4 native binary dictionary.
Bug: 10197478
Bug: 11073222
Change-Id: I6daac6c4b048c65682c25afe6ca0fad83cc9720f
2013-10-25 12:32:30 -07:00
Jean Chalard
d4b5bc1695 Merge "Preliminary refactor" 2013-10-22 11:26:54 +00:00
Jean Chalard
b00ed46385 Preliminary refactor
Bug: 11328842
Change-Id: I7c22e951fef9bc4443c6b64625e25f632f876ab1
2013-10-22 20:16:17 +09:00
Jean Chalard
729abe6332 Stopgap solution for a crash.
This returns the wrong string, but since it's used for getting the
previous word for bigrams, it only results in slightly worse
suggestions quality.

Bug: 11273655
Change-Id: I6ce5de2f76effc453ca691a654ab6bf17445b9e7
2013-10-22 20:00:09 +09:00
Jean Chalard
926ebe849a Merge "Add a sequence number to SuggestedWords." 2013-10-22 04:02:11 +00:00
Jean Chalard
ac76463306 Add a sequence number to SuggestedWords.
This allows testing for suggestion freshness in an asynchronous
suggestions world.

Bug: 11301597
Change-Id: Ic76cd17568598d8534aec81e037f9e37f52eb6b4
2013-10-22 12:52:58 +09:00
Jean Chalard
c6a121805f Fix a bug where autocaps would jam auto-commit
Bug: 11311002
Change-Id: I62955e364c9ffc75322cf05fa3ad7985f1d09259
2013-10-22 12:39:49 +09:00
Ken Wakasa
513b99dfa2 Cosmetic fixes
Change-Id: I44ac89edaba2e57bd1b7e091ff74b77a5e598f2f
2013-10-21 15:53:49 +09:00
Yuichiro Hanada
52f18d7f40 Change the block sizes for SparseTables.
This change saves about 240k bytes.

Bug: 10941472
Change-Id: Ieb00e4dd3391cdb0d42d705f8d0a7b1421f516f9
2013-10-18 20:28:07 +09:00
Keisuke Kuroyanagi
8e9af925b1 Merge "Fix: Suggested words from user history are invalid." 2013-10-18 11:05:03 +00:00
Keisuke Kuroyanagi
53686e0f5f Fix: Suggested words from user history are invalid.
- Suggestions form user history can contain invalid words.
- isValidWord always returns false.

Bug: 11139426
Change-Id: I6075b275603332ddb00f4a9284afcaa82d824270
2013-10-18 19:53:57 +09:00
Satoshi Kataoka
7fdb2c2956 Merge "Change the numbering order of terminal IDs." 2013-10-18 10:31:27 +00:00
Yuichiro Hanada
9ae7d37108 Change the numbering order of terminal IDs.
Change-Id: I85a6b6e948ee0de012eef2f9f841240cbca63947
2013-10-18 19:16:11 +09:00
Yuichiro Hanada
2b7110ff1f (2/2) Implement insertWord in Ver4DictUpdater.
Change-Id: I2328a9df0a009b564e8acaf4180f9b0c1ed0901a
2013-10-18 18:03:44 +09:00
Yuichiro Hanada
19b247e79d Fix the name of the argument of writeString.
Change-Id: I76916914f1402913daa56dd5387fe82e42287989
2013-10-18 17:33:10 +09:00
Yuichiro Hanada
520f612849 (1/2) Implement insertWord in Ver4DictUpdater.
Change-Id: Ia3079d5ef00ca7d831c91fb9220ad9c17038c5a3
2013-10-18 16:42:59 +09:00
Jean Chalard
0f45e1bfbc Fix a bug where autoshift would be ignored coming from emoji
Bug: 11123691
Change-Id: I36474e12e34af95051129840865015f85595411b
2013-10-17 22:58:34 +09:00
Jean Chalard
578e9b91c1 Merge "Remove useless code." 2013-10-17 06:56:12 +00:00
Jean Chalard
8447409c77 Merge "Remove mIsExpectingUpdateSelection." 2013-10-17 06:55:54 +00:00
Yuichiro Hanada
ad5b9bcec2 Add readVer4PtNodeInfo to Ver4DictDecoder.
Change-Id: Ibffaf64a9bda1fb0779a9b53558ca56ed31660d3
2013-10-17 14:37:04 +09:00
Yuichiro Hanada
36dd126ab4 Add ShortcutContentReader.
Change-Id: I7c2d0d86d85775065a9bcb2b4a8463bb4969579e
2013-10-17 11:11:29 +09:00
Jean Chalard
548716d6d9 Remove useless code.
The only use of mDeleteCount is to implement delete
acceleration. It's reset at each non-delete code point, and
is guarded by a timer.
Plus, ultimately we want to remove this completely :
acceleration should be implemented by actually deleting
stuff faster, not by deleting several code points at a time.

Change-Id: Ia3144860b3aa2499034f2a2a7c81f32087af9598
2013-10-16 18:43:15 +09:00
Jean Chalard
5731b86b88 Merge "Remove unneeded code." 2013-10-16 09:41:44 +00:00
Jean Chalard
1194b2b204 Remove mIsExpectingUpdateSelection.
Bug: 11226045
Change-Id: I043f90ba92989bd8307c978eb32630439f63a0b9
2013-10-16 18:39:20 +09:00
Jean Chalard
497976e09b Remove unneeded code.
We don't support LOG_FULL_TEXTVIEW_CONTENTS any more, nor do
we have any plans to support it again in the future.

This also is a prelude to removing mIsExpectingUpdateSelection.

Bug: 11226045
Change-Id: Ib68c6daf52993b87225a7ea9e71a414caaecfdb7
2013-10-16 18:36:16 +09:00
Yuichiro Hanada
098639d99f Add SparseContentTableReader.
Change-Id: I976afc5d320bc65835d659bae1d10d2cdc68262b
2013-10-16 17:24:59 +09:00
Yuichiro Hanada
7b5f2b71f5 Fix Ver4DictDecoder.readAndFollowForwardLink().
Change-Id: Ib527a376b693be21aebd4920ac804ee9b161eb96
2013-10-16 17:16:26 +09:00
Ken Wakasa
008d84ffa5 Merge "Fix readAndFollowForwardLink." 2013-10-16 07:48:30 +00:00
Ken Wakasa
6b7037fa68 Merge "Extract SparseTableContentWriter." 2013-10-16 07:34:03 +00:00
Yuichiro Hanada
ed831f38db Extract SparseTableContentWriter.
Change-Id: I9a58e53317654f8a09fbe79044214de3e9c59eb7
2013-10-16 09:53:30 +09:00
Yuichiro Hanada
1557de7aa4 Consolidate CharEncoding.writeString and BinaryDictIOUtils.writeString.
Change-Id: I6f990fd84e7f08fd1149198c33d8bbf1cac8e078
2013-10-16 00:30:45 +09:00
Yuichiro Hanada
522dc0d8ac Fix readAndFollowForwardLink.
Change-Id: Ifda44e6139a4a1bd065468a7f74cd9483b343644
2013-10-16 00:16:39 +09:00
Ken Wakasa
b067be0e5f Merge "Revert "Revert "Add Swiss French and German keyboard layouts.""" 2013-10-15 14:12:29 +00:00
Ken Wakasa
b044047227 mExpectingUpdateSelection was out of sync when nothing to delete.
cherripick of I9c6a948331726a821bd3ccec9c1d02dec2c4703a
(forward cherrypicking this because the automerger is stuck now.)

This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.

1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace

The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.

bug: 11181913
Change-Id: I1cbf444d8d105416e7de75c16d80b3797f470495
2013-10-15 14:05:34 +09:00
Ken Wakasa
cf5dfd2464 am 3a3bbf4a: am eed74b81: am c8383eda: Fix wrong commitText parameter in sendKeyCodePoint()
* commit '3a3bbf4a38870ecc42b7f6fbd3a7cae20fe020a7':
  Fix wrong commitText parameter in sendKeyCodePoint()
2013-10-14 10:52:40 -07:00