03d1dff38d
Merge "Fix Binary dict tests"
2013-04-15 03:53:54 +00:00
c2e9c511cb
Fix Binary dict tests
...
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.
The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.
All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.
Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
2013-04-15 12:48:16 +09:00
a91da76683
Suppress calling onPressKey and onReleaseKey while detecting gesture
...
Bug: 8284624
Change-Id: I14470bb2373965aefa921b2c94948450bfa438e3
2013-04-15 10:59:54 +09:00
0dbc8c3509
am f2ab0adc: Import translations. DO NOT MERGE
...
* commit 'f2ab0adc5e3bd8f436aafcea1b396e288c69f7d4':
Import translations. DO NOT MERGE
2013-04-12 16:59:36 -07:00
bfedad238f
Merge "Import translations. DO NOT MERGE"
2013-04-12 23:56:49 +00:00
8515649312
Import translations. DO NOT MERGE
...
Change-Id: I2cb68d3f0804a0c9990916a89e079510b465253f
Auto-generated-cl: translation import
2013-04-12 13:26:13 -07:00
f2ab0adc5e
Import translations. DO NOT MERGE
...
Change-Id: Ie74fdb8041ac5d7eb5d15a49f9aac834751cc9c2
Auto-generated-cl: translation import
2013-04-12 13:19:32 -07:00
ededdc6a8b
Merge "Avoid NPE"
2013-04-12 18:10:49 +00:00
2cd1136b8e
Merge "Remove the dialog to insert words to the dictionary."
2013-04-12 12:33:24 +00:00
91bcf5eb5d
Merge "Restart suggestions when the cursor moves."
2013-04-12 12:27:50 +00:00
02ce3dc2d1
Fix a bug with bad application completions
...
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
2013-04-12 20:53:06 +09:00
6a114fa700
Restart suggestions when the cursor moves.
...
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.
Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
2013-04-12 20:49:03 +09:00
d24f939712
Merge "Make shortcut-only user dict entry non-words."
2013-04-12 11:02:00 +00:00
fb5869e9ff
Merge "Add a class to encapsulate getting the metadata URI"
2013-04-12 11:01:36 +00:00
6a2a4b8e4d
Make shortcut-only user dict entry non-words.
...
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
2013-04-12 16:17:09 +09:00
1a51833828
Remove the dialog to insert words to the dictionary.
...
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
2013-04-12 15:58:50 +09:00
d0623ad7f3
Merge "Move some values to a place where they are easier to override"
2013-04-12 02:53:41 +00:00
2927223edd
Merge "Better isolate ResearchLogging data"
2013-04-11 21:56:01 +00:00
8987cccf89
Add a class to encapsulate getting the metadata URI
...
Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
2013-04-11 17:52:16 +09:00
7ad078e89c
Move some values to a place where they are easier to override
...
Bug: 8418765
Change-Id: Iff0edd4ed8da9d0d1a6fb9545224b232ba374469
2013-04-11 17:35:23 +09:00
cd692be1e1
Merge "Change the default vibration duration to 20msec"
2013-04-11 08:15:29 +00:00
b5d5190deb
Merge "Add some utility functions."
2013-04-11 07:35:22 +00:00
e1416b4399
Change the default vibration duration to 20msec
...
Bug: 8556975
Change-Id: Ia6a0fe230585c9826199a0696fb0c1367e917134
2013-04-11 16:30:32 +09:00
1cbb0b8f2a
Add some utility functions.
...
Bug: 7657025
Change-Id: I4889721b5348c77ed56c5157557e9988dea48a02
2013-04-11 16:16:19 +09:00
4f5f81d5f7
Reorder advanced settings menu
...
Bug: 8247224
Change-Id: I339f285304824b778635f435d8587893fc241c4e
2013-04-11 15:54:38 +09:00
bd8e92d843
Add debug message to detect unusual zero width condition
...
Bug: 8452013
Change-Id: I0169dc6b0d08d1b4d9e01a5fa2ad01e9db292bda
2013-04-11 15:08:36 +09:00
f67a388197
Merge "Add TypefaceUtils"
2013-04-11 05:32:58 +00:00
08ae0d5ca0
Add TypefaceUtils
...
Change-Id: I2d939bc1e3279253902b28ff12bbf7861716b64d
2013-04-11 14:27:42 +09:00
6d0027a46a
Merge "Use SparseIntArray instead of TreeMap<Integer, Integer>"
2013-04-11 05:06:35 +00:00
cee512b63e
Merge "More precise geometry checking for more keys keyboard"
2013-04-11 03:51:42 +00:00
3722f0877e
Merge "Fix two bugs in dicttool"
2013-04-11 03:07:30 +00:00
cfdc91b99a
am 58df3cfa: Import translations. DO NOT MERGE
...
* commit '58df3cfaeee020b6703f90feda89a3bc95a3a116':
Import translations. DO NOT MERGE
2013-04-10 19:35:52 -07:00
9620943cc8
am d9a22235: Hide Setup Wizard icon for stock keyboard
...
* commit 'd9a2223570759d622c690b007369cf32f437f7e5':
Hide Setup Wizard icon for stock keyboard
2013-04-10 19:35:51 -07:00
1aaaa64da8
am 75618c33: am 19dcd154: Merge "Offer to add any OOV typed word to the dictionary."
...
* commit '75618c3321b8eae559886ba5f71e967591da7065':
Offer to add any OOV typed word to the dictionary.
2013-04-10 19:35:50 -07:00
0d72a23054
am 04bb419c: am ddafcf82: Merge "Fix bugs and add tests"
...
* commit '04bb419c3290d059c5ccd5e1eda8600d44a0a69d':
Fix bugs and add tests
2013-04-10 19:35:48 -07:00
bea42fc5bd
am 5bd24642: am 1f70a4d6: Merge "Allow logging while replaying"
...
* commit '5bd2464297db3035b93410c5359accbda74e9f50':
Allow logging while replaying
2013-04-10 19:35:47 -07:00
41a049a410
am ae144fe9: am d117c1a1: Merge "Do not record log split time when handling separator"
...
* commit 'ae144fe9c3a6c80150c11d96da84f5868f44ab8a':
Do not record log split time when handling separator
2013-04-10 19:35:45 -07:00
4c896a2fe8
am f71b9640: am d17c8bd9: Update comments
...
* commit 'f71b96406391fc00c1d3dc45e6b3e827f3595842':
Update comments
2013-04-10 19:35:44 -07:00
34cff46a9c
am ed8fd94e: am 370461ef: Clean up a few option strings under the Advanced settings
...
* commit 'ed8fd94e3c4fd16c0c767c1a45f46461313bdcb8':
Clean up a few option strings under the Advanced settings
2013-04-10 19:35:37 -07:00
024d0e4abf
am f10e7cbe: am e9f69e16: Merge "Move a generic string utility to StringUtils"
...
* commit 'f10e7cbe96596971be5de6592c9cab0aba9ad764':
Move a generic string utility to StringUtils
2013-04-10 19:35:36 -07:00
a4463d7a9a
More precise geometry checking for more keys keyboard
...
Bug: 8484528
Change-Id: I0dd09530a5262fee9c19bb0f11d5830b00306944
2013-04-11 10:44:54 +09:00
cdaee868a3
Merge "Preserve a class for testing"
2013-04-10 23:45:33 +00:00
3684036eed
Preserve a class for testing
...
Addresses b/8583091
Change-Id: I89605223784312d9572dfc7c8aaa7e5eba44c4f6
2013-04-10 16:40:17 -07:00
099dd3f277
Merge "Better release build reporting"
2013-04-10 22:51:21 +00:00
cc42e139c3
Import translations. DO NOT MERGE
...
Change-Id: Icb4c4f32b1549f3d98b99a48b7c2f1b0de1b5a04
Auto-generated-cl: translation import
2013-04-10 13:25:52 -07:00
58df3cfaee
Import translations. DO NOT MERGE
...
Change-Id: Iafc0a5506abef8e709d76ebf4600bacae7dd1e00
Auto-generated-cl: translation import
2013-04-10 13:21:21 -07:00
6108624a00
Better isolate ResearchLogging data
...
Calls to LatinIME#onStartInputViewInternal log important information
about the context in which an IME is used. This is reported as a
single LogStatement. Previously, this was not placed into a separate
LogUnit, and was mixed in with general word data. This change wraps
this LogStatement in its own LogUnit.
Change-Id: I0fecd41c8a1de622a764cc4b5d6902336697046c
2013-04-10 11:53:38 -07:00
dfa5628cd3
Better release build reporting
...
The ResearchLogger reports whether a build is a release build or not
to avoid polluting data with IME debugging work by developers.
Previously this was done by checking a constant flag, which was also
serving the dual purpose of masking out debug code in release builds.
This change introduces a heuristic to determine whether a build was
created by a developer (using the package versionName), and annotating
the data sent to the server appropriately.
Change-Id: Icbad17c66b703cabf6d23d05e2c7c41bcceaae45
2013-04-10 11:52:37 -07:00
ca0fdbbe2e
Fix two bugs in dicttool
...
Both bugs only affect debug mode. One has the wrong object tested
with equals, the other has the iteration failing in some cases.
Change-Id: Ie9100d257a3f9e3be340cf3e38116f63417bdc1a
2013-04-10 22:10:31 +09:00
fb3e805722
Merge "Fix a bug where a space would not be inserted before a gesture"
2013-04-10 11:19:31 +00:00
30b8004b56
Fix a bug where a space would not be inserted before a gesture
...
Bug: 8583675
Change-Id: I14924fef5663f48481994c02c56be45f9f85be65
2013-04-10 20:10:28 +09:00
c7d4158979
Merge "Use private object as a lock instead of synchronized method"
2013-04-10 09:56:27 +00:00
12e77de212
Merge "Use private lock object instead of synchronized method"
2013-04-10 09:35:12 +00:00
1e256f5888
Merge "Protect simultaneously modifying gesture preview data"
2013-04-10 09:34:59 +00:00
951ea3c06d
Use private object as a lock instead of synchronized method
...
Change-Id: I0b9a935d8c97ddfb18ab7950a9d6bf542863072a
2013-04-10 18:34:01 +09:00
ce811f50d2
Use private lock object instead of synchronized method
...
Change-Id: Ifc62bacbd0583a7d102009681a94bdd9ccff7d47
2013-04-10 18:27:11 +09:00
ad205b2e3f
Protect simultaneously modifying gesture preview data
...
Bug: 8556775
Change-Id: I83272e3adbfc0c9cc14f9e8b479e926aabf4fa2a
2013-04-10 18:18:54 +09:00
99b93d17d5
Fix a bug where autocorrection status would be wrong.
...
Change-Id: Ic220129dc59f585164dbf63591cd1c96de17fe6f
2013-04-10 17:49:19 +09:00
262d5bd9f9
Don't override EXTRA_SHOW_FRAGMENT if exists
...
Bug: 8541190
Change-Id: I37d3de12558efd55f157389d2e0b51fc83dc5da1
2013-04-10 16:24:17 +09:00
10af4b6e45
Merge "Separate StringUtils.capitalizeFirstCharacter"
2013-04-10 06:30:33 +00:00
d20c5a78e2
Separate StringUtils.capitalizeFirstCharacter
...
Bug: 8582061
Change-Id: Iac8f65defdd92d7df533bdf0e2937ad897d96363
2013-04-10 14:55:23 +09:00
d9a2223570
Hide Setup Wizard icon for stock keyboard
...
Bug: 8581647
Change-Id: Id530f1a33a5c919f4a732ec0d545dfbe76e56316
2013-04-09 21:39:18 -07:00
87fdde6ec4
Typing double letters via a 'circle' on the key.
...
Bug: 8550980
Change-Id: I5e432dea0e025ccea196f80e90a6bf945488e130
2013-04-10 12:43:13 +09:00
f606fd8554
Hide Setup Wizard icon for stock keyboard
...
Bug: 8581647
Change-Id: Id530f1a33a5c919f4a732ec0d545dfbe76e56316
2013-04-10 12:24:40 +09:00
869ea1e555
Use SparseIntArray instead of TreeMap<Integer, Integer>
...
Change-Id: I56a64228a5fd85d440d0d08ac67cba8bf2e5690d
2013-04-10 10:15:26 +09:00
4fdfce6dcc
Merge "Refactor SpellCheckerProximityInfo as extending ProximityInfo"
2013-04-10 01:06:36 +00:00
224e969ef4
Merge "Import translations. DO NOT MERGE"
2013-04-09 19:42:18 +00:00
09ab6495a2
Merge "[FileEncap18] Clean up uploading scheduling"
2013-04-09 19:08:40 +00:00
19dcd15493
Merge "Offer to add any OOV typed word to the dictionary."
2013-04-09 10:28:47 +00:00
ddafcf82dc
Merge "Fix bugs and add tests"
2013-04-09 08:35:28 +00:00
9310f42a36
Offer to add any OOV typed word to the dictionary.
...
That includes gestures, which used not to work.
Bug: 8532637
Change-Id: I04606565d7000faadf954c4a806c39d4d162a2c1
2013-04-09 12:05:54 +09:00
1f70a4d681
Merge "Allow logging while replaying"
2013-04-09 02:33:09 +00:00
d117c1a116
Merge "Do not record log split time when handling separator"
2013-04-09 02:31:48 +00:00
e4760624ce
Import translations. DO NOT MERGE
...
Change-Id: I3605a7fd941d9ebe76460d114f384b1e233b3440
Auto-generated-cl: translation import
2013-04-08 14:47:06 -07:00
d17c8bd929
Update comments
...
Change-Id: I6aef328ec9041666cc168c8323bed04d39591b71
2013-04-08 23:05:45 +09:00
370461ef9f
Clean up a few option strings under the Advanced settings
...
Change-Id: If41ac016128fce401dedcab0fa7d6c23edaca158
2013-04-08 01:16:32 +09:00
c87449497c
Fix bugs and add tests
...
Change-Id: I6b56b91ace57f4a49584b5dceb71b145859f839e
2013-04-05 12:11:19 +09:00
7d3836d63a
Move a generic string utility to StringUtils
...
Change-Id: I9cc2e9a7ac0b3346af40bcb083f939333336cf09
2013-04-05 12:09:14 +09:00
3547bd2932
am 228d4533: am 5779bc91: Merge "Split LogUnits differently."
...
* commit '228d45337bdf3bd2bcd0170ddf73ab05b4f7e53f':
Split LogUnits differently.
2013-04-03 19:33:00 -07:00
3ec6a8bdf9
am 6c522b53: am 0c0ab2b4: Merge "Reorder ResearchLogger call"
...
* commit '6c522b53f0950fa511bf93e1e506434e7cdef6ad':
Reorder ResearchLogger call
2013-04-03 19:27:26 -07:00
b1533116f5
am b08506c2: am 9413e957: Merge "Interpolate gesture preview trails"
...
* commit 'b08506c2211490fb42617f30dbd8901bf5651b47':
Interpolate gesture preview trails
2013-04-03 19:27:22 -07:00
873c20ba06
am e40d5633: am 43341ba0: Merge "Ask the client to make itself known when it\'s not"
...
* commit 'e40d5633659a401e1357e1c530238ed74cc158f6':
Ask the client to make itself known when it's not
2013-04-03 19:27:20 -07:00
3b9d7fd179
am 151e4e18: am 065f126f: Merge "Fix two nasty bugs with surrogate pairs."
...
* commit '151e4e182c86a2b7aea534bda777e9e9aafa549b':
Fix two nasty bugs with surrogate pairs.
2013-04-03 19:27:19 -07:00
4c535232bc
am a38d907b: am 740da0d8: Fix an NPE
...
* commit 'a38d907b96882f41174d6cf7d0da6faefcc97228':
Fix an NPE
2013-04-03 19:27:15 -07:00
76c00decc9
am 7580e994: am 48d8d8d0: Fix potential NPE in MainKeyboardView.KeyTimerHandler
...
* commit '7580e9945ba096a2a084a6f571c2bd1a945dec8c':
Fix potential NPE in MainKeyboardView.KeyTimerHandler
2013-04-03 19:27:13 -07:00
86b8b7b407
am 9bf1dfeb: am 2188cbae: Merge "Fix an NPE"
...
* commit '9bf1dfebd8e51fb16ac26c59de9aa646b4499765':
Fix an NPE
2013-04-03 19:27:12 -07:00
1c63efc975
am a657afc3: am d555a0d7: Merge "Cleanup"
...
* commit 'a657afc32e099d1b12516788e1a32d1303ced295':
Cleanup
2013-04-03 19:27:11 -07:00
a747d76285
am 6e78878f: am 844e5014: Merge "Increase string limits"
...
* commit '6e78878f7b038afa46afc75117cd773e2d181a5c':
Increase string limits
2013-04-03 19:21:06 -07:00
395e500b09
am bb9a8e08: am f463b45d: Merge "Fix Possible NPE"
...
* commit 'bb9a8e082aebbcdd46e4d2378d9839f896c15476':
Fix Possible NPE
2013-04-03 19:21:01 -07:00
0c99a379bd
am e42522f3: am 2cdf5351: Merge "Fix possible SIOOBE"
...
* commit 'e42522f33566857402a8db645f58de2818456dc7':
Fix possible SIOOBE
2013-04-03 19:21:00 -07:00
35e02ccdda
am bf62dc03: am ef103e1f: Merge "Close ResearchLogger upon onFinishInputView"
...
* commit 'bf62dc036f1e71751c8713ff13e686bbf635d6c3':
Close ResearchLogger upon onFinishInputView
2013-04-03 19:20:59 -07:00
4b8494c4fc
Import translations. DO NOT MERGE
...
Change-Id: I66b30c5f9673fc4ed3b96753cfec023e7d498dec
Auto-generated-cl: translation import
2013-04-03 13:13:26 -07:00
4cdb7ccb32
Import translations. DO NOT MERGE
...
Change-Id: Ic405d085ced9e64efd9b7da38097734c71808fbc
Auto-generated-cl: translation import
2013-04-03 13:06:22 -07:00
6e3f307266
Refactor SpellCheckerProximityInfo as extending ProximityInfo
...
Change-Id: I544eec9d661796d57749dbaa2163bc1e2a891353
2013-04-02 19:06:32 +09:00
ecb59eff90
Revert "[DO NOT MERGE] Activate hardware keyboard handling"
...
This reverts commit c741f1f83b
2013-04-02 16:08:48 +09:00
c741f1f83b
[DO NOT MERGE] Activate hardware keyboard handling
...
Change-Id: Ifdec9338a454291621b2b87c899f5d4301480b27
2013-04-02 15:38:13 +09:00
30772c3758
Allow logging while replaying
...
Previously logging was disabled during replay. This makes it impossible to use logged data as a
regression test, since the new log was unavailable. This change corrects this problem.
Change-Id: I19dc31def2f2f87fd219dc561c739d18e4ab9c9c
2013-04-01 16:49:39 -07:00
636b8c4231
Do not record log split time when handling separator
...
Previously handleSeparator() caused the ResearchLogger to mark the time at which a LogUnit should be
broken. However, this causes the motion data associated with a separator to be associated with the
LogUnit of the previous word. This change corrects this bug.
Change-Id: I8b4d4fa6de2a013de9e2a28bb668c446a07f1957
2013-04-01 16:48:15 -07:00
5779bc91e6
Merge "Split LogUnits differently."
2013-04-01 23:08:21 +00:00
02fc1ed512
Merge "Import translations. DO NOT MERGE"
2013-04-01 20:54:38 +00:00
Jean Chalard
Tadashi G. Takaoka
Baligh Uddin
Kurt Partridge
Ken Wakasa
Keisuke Kuroynagi
Satoshi Kataoka