Commit Graph

843 Commits (d89f6842f2309a82431574b5095f8eea346ed535)

Author SHA1 Message Date
Tadashi G. Takaoka d648d066ea Fix unit test message to use 0-based index
Change-Id: I2c91628d21dc96712f6cbea996f28f5d39fb402e
2014-03-03 12:39:53 +09:00
Keisuke Kuroyanagi 684f5f18b1 Merge "Added a method and run GC for testing." 2014-02-28 09:33:51 +00:00
Keisuke Kuroyanagi d302b98ce6 Added a method and run GC for testing.
Bug: 13231889
Change-Id: If64b7422967c3e4107c845072b64a7bb26a35f7e
2014-02-28 18:17:09 +09:00
Tadashi G. Takaoka 5c7c538f16 Add unit test message for KeyboardLayoutSetTests
Change-Id: Ia92e4b410ca966d2dc1c5f29a340d366aa066838
2014-02-28 13:15:27 +09:00
Tadashi G. Takaoka b24dc822bc Name constants of the number of subtypes.
This is a follow up CL of Ief028e8ab5.

Bug: 13017434
Change-Id: Idf0a47300c208b9904ffcc8b64d97a43b4d708ae
2014-02-27 12:37:20 +09:00
Tadashi G. Takaoka 997ba1b41e Merge "Add keyboard layout set tests" 2014-02-27 03:08:42 +00:00
Tadashi G. Takaoka dd01a0bb1d Add keyboard layout set tests
This CL is a ground work to add keyboard layout labels and more keys
tests.

Bug: 13017434
Change-Id: Ief028e8ab563d79bc0b0f9c06f1fe1d645a6469d
2014-02-26 16:10:52 +09:00
Tadashi G. Takaoka 53b62fe7d0 Add KeyboardTextsSetTests
- Text "label_to_alpha_key" needed to implement Emoji keyboard exists.
- Test the text from resources are loaded correctly.

Bug: 13017434
Change-Id: Idfb9ac87c1556c535ebc10eaef78d8166799a657
2014-02-25 12:24:55 +09:00
Jean Chalard 890b44e537 Correctly read the header of APK-embedded dicts
Bug: 13164518
Change-Id: I8768ad887af8b89ad9f29637f606c3c68629c7ca
2014-02-24 22:54:01 +09:00
Tadashi G. Takaoka 8e2951f299 Merge "Fix punctuation test for tablet" 2014-02-21 11:54:28 +00:00
Tadashi G. Takaoka d28a58c25d Fix punctuation test for tablet
It seems that some test devices are tablet and some are phone. The
unit test should aware of which device the test is running.

Change-Id: I8651a540993de29aa1cd9f40919dffe7a8df9512
2014-02-21 17:50:07 +09:00
Keisuke Kuroyanagi 239256b156 Merge "Add an auto-correction by user history test." 2014-02-21 07:59:05 +00:00
Keisuke Kuroyanagi 4cc582f3ba Add an auto-correction by user history test.
Bug: 11122480
Change-Id: I830bb3399f9839a80c6d86fbf582299bce424871
2014-02-21 13:12:26 +09:00
Keisuke Kuroyanagi e03e4257f1 Merge "Add test only methods to test personalized dicts." 2014-02-20 13:25:59 +00:00
Keisuke Kuroyanagi d36328cecf Add test only methods to test personalized dicts.
Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
2014-02-20 22:20:43 +09:00
Keisuke Kuroyanagi 21f9482999 Fix: UserHistoryDictionaryTests.testDecaying().
Bug: 13106697
Change-Id: If81f77c3cefdefae94cb9145aa9f700494f8237a
2014-02-20 21:23:57 +09:00
Keisuke Kuroyanagi 0bc66daae3 Add user history dictionary decaying test.
Bug: 10667710

Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
2014-02-20 18:36:46 +09:00
Jean Chalard fbb8cb5a82 Fix build
This is a forgotten rebase

Change-Id: I7c7c381775488ed9239dc284bd9c31247a86a972
2014-02-18 20:08:53 +09:00
Jean Chalard 28e0b24965 Merge "Fix a bug where the cache would be out of sync" 2014-02-18 10:58:50 +00:00
Jean Chalard fe92c174ea Fix a bug where the cache would be out of sync
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.

Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
2014-02-18 19:55:54 +09:00
Jean Chalard 63be066544 Cleanup.
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.

Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
2014-02-18 17:07:46 +09:00
Yohei Yukawa 6d43124215 Stop using deprecated InputMethodSubtype constructor
The constructors of InputMethodSubtype were deprecated in API level 19.
However we cannot yet switch to a new InputMethodSubtypeBuilder style
due to our minimum support API level.

As an intermediate solution, this patch replaces the these API calls
with InputMethodSubtypeCompatUtils.newInputMethodSubtype so that
these legacy API call can be consolidated at the same place.

BUG: 13030512
Change-Id: I561a585f5dbea56c337680b645be5ef07015a0b1
2014-02-17 15:32:33 +09:00
Keisuke Kuroyanagi 95d16561e0 Remove unused code.
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
2014-02-15 17:39:24 +09:00
Keisuke Kuroyanagi 0fc93fe445 Implement PatriciaTriePolicy::getNextWordAndNextToken().
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
2014-02-15 17:39:20 +09:00
Keisuke Kuroyanagi 85fe06e759 Merge "Remove unused argument from readDictionaryBinary." 2014-02-14 10:37:56 +00:00
Keisuke Kuroyanagi 8e3a1d0f89 Remove unused argument from readDictionaryBinary.
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
2014-02-14 19:02:15 +09:00
Keisuke Kuroyanagi 8fa7a09f1e Merge "Implement PatriciaTriePolicy::getWordProperty()." 2014-02-14 09:08:09 +00:00
Tadashi G. Takaoka e4b0add353 Fix SpacingAndPunctuationsTests due to I2219224840
Bug: 12640318
Change-Id: If0b0696b937c580d69cb909ddaf414d01ea2c01b
2014-02-14 17:59:53 +09:00
Keisuke Kuroyanagi c63d183473 Implement PatriciaTriePolicy::getWordProperty().
Bug: 12810574
Change-Id: I7bcccfd3641ebbcf2b8d857d33bb4734c42af5eb
2014-02-14 17:56:45 +09:00
Tadashi G. Takaoka a273319c59 Add PunctuationSuggestions class
This change must be checked in together with I366c477516.

Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
2014-02-14 14:13:39 +09:00
Tadashi G. Takaoka bd0591ce62 Merge "Make InputLogicTest more robust" 2014-02-13 10:44:44 +00:00
Tadashi G. Takaoka da973e75dc Make InputLogicTest more robust
Change-Id: I134f14971126cbeed05b472c08747f2b88ad30e6
2014-02-13 19:38:51 +09:00
Jean Chalard 5dc0d405b4 Merge "Clean-up follow-up to I3ecc8496" 2014-02-13 10:26:48 +00:00
Jean Chalard 2d68f4b392 Clean-up follow-up to I3ecc8496
Change-Id: I8db952a4152dab027e4f34bc5270bfca508d154d
2014-02-13 19:18:29 +09:00
Tadashi G. Takaoka 7ae6721ffa Remove RTL aware !code and add corresponding !text
Change-Id: I9021c8fa1cf2d4ac07579237a939c15551509a0b
2014-02-13 17:32:09 +09:00
Tadashi G. Takaoka 36b8962a9a Merge "Fix UserHistoryDictionaryTests" 2014-02-13 07:49:51 +00:00
Tadashi G. Takaoka 0cda0e8a9c Fix UserHistoryDictionaryTests
Change-Id: I5f2f555f9c3f471545921ef80e4cf528976be837
2014-02-13 16:16:44 +09:00
Jean Chalard e0a425681c Merge "Fix a test." 2014-02-13 05:20:58 +00:00
Jean Chalard cf03ff02b1 Fix a test.
This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.

Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
2014-02-13 14:01:37 +09:00
Jean Chalard bac89ecc50 Fix a failing test.
A replay of that old, horribly hard-to-find bug: we post a
resume message during onStartInputView, so we need
to process it before we start the test. But now the message
is posted with a delay, so we need to wait for the delay...

Change-Id: I843d70e636fa51a68aadbdbbaa73b1711ad7bddd
2014-02-12 23:32:51 +09:00
Keisuke Kuroyanagi 2ef87aee3e Merge "Make PtNode have ProbabilityInfo instead of raw value." 2014-02-10 06:10:51 +00:00
Keisuke Kuroyanagi 8ffc631826 Make PtNode have ProbabilityInfo instead of raw value.
Bug: 11281877
Bug: 12810574
Change-Id: Id1cda0afc74c4e30633c735729143491b2274a7b
2014-02-10 15:05:08 +09:00
Tadashi G. Takaoka bd9887a574 Fix possible NPE while finding device override value from resource
Bug: 12949735
Change-Id: Iffda08db413b3b3d338ab9bf625bb0968c2e48dd
2014-02-10 14:38:53 +09:00
Tadashi G. Takaoka a9e1db6636 Merge "Decimal number is treated as outputText" 2014-02-07 09:26:04 +00:00
Keisuke Kuroyanagi 6422f77e94 Merge "Use native logic to read Ver4 dict." 2014-02-06 13:00:09 +00:00
Keisuke Kuroyanagi ab6a93773b Use native logic to read Ver4 dict.
Bug: 11281877
Bug: 12810574
Change-Id: Ief371d3ef61818e4e031de4659aee3c9584c7379
2014-02-06 21:55:37 +09:00
Tadashi G. Takaoka 3bbd50c36b Use SubtypeLocaleUtils.isRtlLanguage
Change-Id: Ic0208412cd9c02975641cb5c448d092f28786746
2014-02-06 18:15:32 +09:00
Jean Chalard a9e1930a6a Merge "Conditionally store the raw suggestions." 2014-02-06 07:31:22 +00:00
Tadashi G. Takaoka 4a64ad9538 Decimal number is treated as outputText
Change-Id: I9d4a8ac5dd26a7c41fcfbe1842a40f347a2f2aab
2014-02-06 16:30:12 +09:00
Jean Chalard a49f61f8a7 Conditionally store the raw suggestions.
Bug: 12913520
Change-Id: Ie15f97d90c142c51089280252b35b5ad1d226e19
2014-02-06 16:14:41 +09:00
Keisuke Kuroyanagi 337dce8074 Merge "Consolidate WordProperty and Word." 2014-02-06 07:02:07 +00:00
Keisuke Kuroyanagi 5f5feeba13 Consolidate WordProperty and Word.
Bug: 11281877
Bug: 12810574
Change-Id: I9dc99188f80f25a8780c1860dab46e4aa80a23e5
2014-02-06 15:13:33 +09:00
Jean Chalard 58eed6360d Merge "Stop considering personalization dicts outputs as words" 2014-02-05 13:33:12 +00:00
Jean Chalard 5095fabdd0 Stop considering personalization dicts outputs as words
Bug: 12800726
Bug: 12798403
Change-Id: I6d60f9ad39761757f8a64533f40d6441f3a36410
2014-02-05 21:57:37 +09:00
Keisuke Kuroyanagi 239f7daf4a Merge "Make WeightedString have ProbabilityInfo." 2014-02-05 12:53:14 +00:00
Keisuke Kuroyanagi df1d3e733e Make WeightedString have ProbabilityInfo.
Bug: 11281877
Bug: 12810574
Change-Id: I265e3d8654c75766cd0e0d09d67ef62b4566298a
2014-02-05 21:44:55 +09:00
Tadashi G. Takaoka 02a534d13f Merge "Treat a sole "|" as a special case of key label" 2014-02-05 09:32:12 +00:00
Tadashi G. Takaoka 6e5dbdd501 Merge "Add null check to KeySpecParser" 2014-02-05 09:32:04 +00:00
Jean Chalard b162911fa4 Merge "[HD04] Make the locale mandatory." 2014-02-05 09:16:17 +00:00
Tadashi G. Takaoka f7d8b8fcbc Treat a sole "|" as a special case of key label
Change-Id: Ia72c31d15c891fa522935ba9792e88fd5d8ce7f7
2014-02-05 17:57:44 +09:00
Tadashi G. Takaoka d9c6b33209 Add null check to KeySpecParser
Change-Id: Ic37db8cbf8f83f753d7381e1edba8eac1ef1ceb1
2014-02-05 17:49:26 +09:00
Jean Chalard 43cf9076b2 [HD04] Make the locale mandatory.
Bug: 11281748
Change-Id: I69281b0053bec404c3e3c713ade3f65a140f51b1
2014-02-05 17:35:25 +09:00
Tadashi G. Takaoka 2151216c09 Rename base test class KeySpecParserTestsBase
Change-Id: I41e1ccb3f0cfde4e5ae311a763e5659e5ff71d3c
2014-02-05 14:55:36 +09:00
Tadashi G. Takaoka e158c92ae1 Merge "Add KeySpecParser unit test" 2014-02-05 03:35:17 +00:00
Keisuke Kuroyanagi b986f78ba8 Separate header class from FormatSpec.
Bug: 12810574
Change-Id: Iacf1cd05a268bf690ab864b5e32a18a4b0ccc693
2014-02-04 21:36:04 +09:00
Tadashi G. Takaoka 853e8d8869 Add KeySpecParser unit test
Change-Id: Ie1c32daecefc2909e58056f515631cbd7de687f7
2014-02-04 19:01:45 +09:00
Keisuke Kuroyanagi d79fd29f61 Make dumpAllWordsForDebug() use getNextWordProperty().
Bug: 11736680
Bug: 12810574
Change-Id: I32a388e23ee7da5d7291e88a46c90b61d2f25dee
2014-02-04 13:51:49 +09:00
Keisuke Kuroyanagi 941734695b Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken.
Bug: 12810574
Change-Id: Idea44f03c477964f58e65fbf2b55e3fcd77a2934
2014-02-04 12:42:14 +09:00
Keisuke Kuroyanagi 9221772ab7 Get bigram information via getWordProperty().
Bug: 12810574
Change-Id: I2750a5659ccbc3e31307c28e35dd9a1dbdffbeee
2014-02-03 11:47:26 +09:00
Keisuke Kuroyanagi 5ecf74b148 Merge "Extend jni interface to get bigrams in WordProperty." 2014-01-31 11:53:10 +00:00
Keisuke Kuroyanagi 94d9a2309f Extend jni interface to get bigrams in WordProperty.
Bug: 12810574
Change-Id: Ia4b88d02ea8790a5c47d32376cc0b84c3e071ddd
2014-01-31 20:32:44 +09:00
Tadashi G. Takaoka 2ae7e53c77 Merge "Move some methods to MoreKeySpec class" 2014-01-31 11:23:41 +00:00
Tadashi G. Takaoka e855093f55 Move some methods to MoreKeySpec class
Change-Id: I025ed15e36ac3113db6a5fccefa0c87f016703fa
2014-01-31 20:19:48 +09:00
Keisuke Kuroyanagi 35ff07c70b Merge "Fix BinaryDictDecoderEncoderTests." 2014-01-31 10:58:26 +00:00
Keisuke Kuroyanagi 5cb7509314 Fix BinaryDictDecoderEncoderTests.
Bug: 12809791
Change-Id: I04313df78692b01e153a34c932a37f079a924105
2014-01-31 19:44:17 +09:00
Jean Chalard 4e6f72cb80 Merge "[HD03] Straighten out attribute key names in Java." 2014-01-31 08:40:25 +00:00
Tadashi G. Takaoka 0bae2ab460 Refactor KeyboardTextsSet class
Change-Id: I0b48c85aa2c291e1e7ee25d61c558700fc677e29
2014-01-31 16:31:07 +09:00
Jean Chalard 79b2e4d86c [HD03] Straighten out attribute key names in Java.
Bug: 11281748
Change-Id: I1d813bdacd45bcfd9c4cc73ac1d67c5c89854e86
2014-01-31 14:46:07 +09:00
Keisuke Kuroyanagi 080a35e959 Rename UnigramProperty to WordProperty.
Bug: 12810574
Change-Id: If5ddd803948aaf6e491ddcbaa5436fb3af3f7257
2014-01-31 11:06:42 +09:00
Keisuke Kuroyanagi 26bd46095a Reading dictionary containing timestamps in Java Side.
Just skipping historical information fields.

Bug: 11281877
Change-Id: I43d2adaa576b7da11ed3ca54990265dbb6f53b08
2014-01-29 20:19:24 +09:00
Tadashi G. Takaoka c2e2b3949b Merge "Add SubtypeLocaleUtils.isRtlLanguage method" 2014-01-28 01:28:47 +00:00
Tadashi G. Takaoka c0c74d22a0 Add SubtypeLocaleUtils.isRtlLanguage method
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
2014-01-27 19:05:16 +09:00
Jean Chalard 6d1c8b2c3f Merge "Try to figure out whether d.quotes open or close." 2014-01-27 10:01:17 +00:00
Tadashi G. Takaoka 73472efac1 Fix SubtypeLocaleUtilsTests
Change-Id: Ifbdfd320b1416d210592ec14099e4dd9d9d0047d
2014-01-27 18:23:54 +09:00
Jean Chalard c7ef305bbc Try to figure out whether d.quotes open or close.
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
2014-01-27 18:17:33 +09:00
Keisuke Kuroyanagi 963d97af6d Merge "Add length check for dict update operations." 2014-01-25 00:47:27 +00:00
Keisuke Kuroyanagi 51c5ec10f9 Add length check for dict update operations.
Bug: 12602903
Change-Id: I6835dee8bf8b356f0f1cf6c0531bee5b3415a13f
2014-01-24 16:32:42 -08:00
Ken Wakasa 0acd121083 Fix wrong indents.
Removed an unused method too.

Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
2014-01-24 23:55:33 +09:00
Jean Chalard 90adbc7fdf Fix build
Missing change after a thousandth comment fix

Change-Id: Iec48f892978507fb9823236cd1c5a70209b58b0e
2014-01-24 12:16:22 +09:00
Jean Chalard 1d6e647ac3 [IL69.1] Move a static method to a utility class.
This is a followup to IL69.

Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
2014-01-24 11:59:23 +09:00
Jean Chalard 1284e556f4 [IL70] Remove unused arguments
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
2014-01-23 15:33:14 +09:00
Jean Chalard d1f463eacf [IL69] Oust Keyboard from WordComposer#setComposingWord
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
2014-01-23 15:32:59 +09:00
Tadashi G. Takaoka c93cf1c398 Use sorted int[] to represent word separators
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
2014-01-20 19:40:02 +09:00
Tadashi G. Takaoka 837cdd738b Add SpacingAndPunctuationsTests
Change-Id: I78d488ad84a11af809ee1f8d3d2fa01a89fbfa28
2014-01-20 18:33:45 +09:00
Jean Chalard 2334bf6d8c Merge "Fix a bug specific to German capitalization." 2014-01-17 01:49:14 +00:00
Jean Chalard 60afa7000f Fix a bug specific to German capitalization.
Bug: 9663105
Change-Id: Ib68ee4edb135e96dfca229c1ccce308e7e638bdd
2014-01-17 02:06:24 +09:00
Keisuke Kuroyanagi d78a447d10 Add a dedicated method to control time in native code.
Bug: 12443085
Change-Id: I41a5cf6c895cb59e54af98b40efded36afcd3247
2014-01-15 14:55:57 -08:00
Tadashi G. Takaoka 7b9b095090 Move LanguageModelParams class to utility package
This change must be checked in together with Ic82d951237.

Change-Id: I2ab451330f85a0147563b805682f26edecb71a29
2014-01-15 16:14:53 +09:00
Keisuke Kuroyanagi 68069c55c4 Fix flaky unit test.
Change-Id: I8df0f9a0398b29f679844f256ad84f09ebcea8ee
2014-01-14 18:51:29 -08:00
Jean Chalard 7b6e999cd1 Fix a test.
Bug: 12483313
Change-Id: Ia811d614b9260367871bc5717f587538adf46789
2014-01-10 21:39:43 +09:00
Jean Chalard 84a3047e80 Fix build.
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
2014-01-10 12:18:26 +09:00
Tadashi G. Takaoka ee35e69eae Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
This change must be checked in together with Iec437d6df0.

Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
2014-01-09 19:05:09 +09:00
Tadashi G. Takaoka 494e2d6c17 Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
2014-01-09 18:33:25 +09:00
Tadashi G. Takaoka d7660c6f56 Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode" 2014-01-09 09:31:32 +00:00
Tadashi G. Takaoka 0a75cf51af Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
2014-01-09 18:19:17 +09:00
Keisuke Kuroyanagi e4ae5855cb Fix a unit test in InputLogicTests.
Change-Id: I63a20bb2e4b3c39495fade6cae3a14fdd11ca48c
2014-01-09 16:23:43 +09:00
Keisuke Kuroyanagi 5742a415f3 Merge "Make reloadMainDict() private." 2014-01-08 11:03:02 +00:00
Keisuke Kuroyanagi 9f1fe87580 Make reloadMainDict() private.
Bug: 8187060
Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
2014-01-08 18:59:43 +09:00
Tadashi G. Takaoka ad78058a93 Rename InputPointers.addPointer and ResizableIntArray.add
Change-Id: I5580250c91b29f93ed886b080ce33845b3b67ace
2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka e13cc9d7e5 Fix ResizableIntArrayTests readability
Change-Id: I68862b98f228210f1d76fef4fd7454edbfd8e01d
2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka e7dc5302af Fix InputPointersTests
InputPointers.getTime(int) has a validity check of time values. And
the check is enabled when LatinImeLogger.sDBG is on. Such situation
may occur while unit testing. This change ensure that time values are
monotonic while unit testing.

Change-Id: I9ff2cff2bcd253de0e8206dd3be964fe565170fa
2014-01-08 14:14:42 +09:00
Jean Chalard 1e50c681af [IL52] Remove a useless method.
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.

Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.

Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
2013-12-27 22:40:19 +09:00
Jean Chalard 6bca9ac43d Fix a bug where predictions would not pop upon manual pick
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
2013-12-26 23:19:29 +09:00
Keisuke Kuroyanagi d77ad1902b Fix NPE in a unit test.
Change-Id: I0dfc23232ed77e1ff1aedecfa6ac022020cb1c19
2013-12-26 17:01:48 +09:00
Keisuke Kuroyanagi 4a55ee1440 Fix typo in a unit test.
Change-Id: I9222533704722265511b9fe6fb5caf99765e198b
2013-12-25 13:13:43 +09:00
Jean Chalard 1404c1af85 [IL21] Move the workaround utils to a better place.
Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
2013-12-20 16:48:54 +09:00
Jean Chalard dfbe2bfe08 Add some info to test crashes to help diagnose flakiness
Bug: 11142685
Change-Id: Ic3a5d452f6c325248ac4e1bfa37774c58586f359
2013-12-18 18:10:56 +09:00
Keisuke Kuroyanagi c2fd53ee0e Remove ver4 dict updater.
Change-Id: I468994c98d091be621b9fb3fbe6405c67fc6a465
2013-12-17 18:17:51 +09:00
Keisuke Kuroyanagi 42334bb493 Quit checking bigram order in BinaryDictDecoderEncoderTests.
Change-Id: I1b8eb6ab2ea797d2590495b1f57f9ec9560ea817
2013-12-17 17:38:24 +09:00
Keisuke Kuroyanagi b54c747d7c Merge "Move DictUpdater to the tests directory." 2013-12-17 05:33:16 +00:00
Keisuke Kuroyanagi 4fdcefe504 Move DictUpdater to the tests directory.
Bug: 11245133
Change-Id: I0907a091ac3ae960eaf3b27da78dbb48a24b2ea1
2013-12-17 14:31:25 +09:00
Jean Chalard 7cd7cf73f4 Fix a bug with languages without spaces and predictions
This is simpler and more correct.

Change-Id: I41806d2fc12b4ca25f76e32972b38f91f3d05c2b
2013-12-16 23:16:02 +09:00
Jean Chalard b868375763 Fix failing tests
- Version 3 is not supported
- Now passing the right string to open v4 dicts. Fix the tests for this.

Change-Id: I7829330c3568a715b96396ba4e4e69c6e17775ab
2013-12-16 14:32:19 +09:00
Jean Chalard f08b1ea41a Merge "Remove references to the v3 dictionary." 2013-12-13 10:08:12 +00:00
Jean Chalard 1dc7eca114 Remove references to the v3 dictionary.
Change-Id: I811c8c923ad67a6d9bfdd11bdef8991eb7135c27
2013-12-13 18:53:41 +09:00
Keisuke Kuroyanagi 3e81d9c39f Merge "Remove code for forgetting curve in Java side." 2013-12-13 09:44:16 +00:00
Keisuke Kuroyanagi cc8c544ee2 Remove code for forgetting curve in Java side.
Change-Id: I294ed179c642ff52452b5884326c1083477e1bce
2013-12-13 18:40:58 +09:00
Jean Chalard a245d15da5 Have dicttool use the native library to generate v4 dicts.
Yay !

Change-Id: Iea8ced9e81031b9ab7eff05ad9ef7215be248de9
2013-12-13 18:18:20 +09:00
Jean Chalard 7b55cd3e2b Remove flags from Java side.
This simplifies the code quite a bit.
- GERMAN_UMLAUTS are now handled through a key-value attribute.
  The dictionary generator does not need to know about it any more.
- FRENCH_LIGATURES are deprecated as we handle them with shortcuts now.
- CONTAINS_BIGRAMS is deprecated. Bigram processing is always applied
  regardless of this flag.

Bug: 11281748
Change-Id: If567e52e245a9342adc7f3104a0f7d8d782df8c1
2013-12-13 18:15:05 +09:00
Ken Wakasa 2fa3693c26 Reset to 9bd6dac470
The bulk merge from -bayo to klp-dev should not have been merged to master.

Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
2013-12-13 17:13:32 +09:00
Jean Chalard 5b5ed3d609 Fix a bug where autocaps would jam auto-commit
Bug: 11311002
Change-Id: I62955e364c9ffc75322cf05fa3ad7985f1d09259
2013-10-22 05:23:48 -07:00
Ken Wakasa eacb2be8fe Fix unit test for If8c94ef91ed58bb5028f51be7c8d9beb677436a4
Change-Id: I056013de3a5e09feed429dfd8097d3d85331a0ab
2013-10-11 16:52:12 +09:00
Yuichiro Hanada 9514ed5c2a Add the new format of bigram entries.
In new format, each bigram entry has flags (1 byte), a terminal id (3 byte),
a time-stamp (4 byte), a counter (1 byte) and a level (1 byte).

Bug: 10920255
Bug: 10920165
Change-Id: I0f7fc125a6178e6d25a07e8462afc41a7f57e3e1
2013-10-11 14:50:41 +09:00
Ken Wakasa 56402cf10a Revert "Add Swiss French and German keyboard layouts."
This reverts commit 220ce8f269.

Sorry, but we are now in the week before the final cut for the next launch. We shouldn't be taking new features like this at this point. Let me revert this change for now. I'll re-revert this after the cut next week.

Change-Id: Ia8b00680c992ec526e6a858945f2380cbcdfdd55
2013-10-10 02:05:50 +00:00
Fredrik Roubert 220ce8f269 Add Swiss French and German keyboard layouts.
There used to be two "Swiss" keyboard layouts, labelled fr_CH and de_QY,
available in LatinIME. They were, however, not actually Swiss layouts
but instead work-arounds to be able to get French or German with qwertz
or qwerty (instead of azerty and qwertz) layouts, respectively. These
were thus removed by commit f6972561fc
replacing them with the generic fr-qwertz and de-qwerty layouts instead.

Here, now, is a proper Swiss keyboard layout, following Swiss standards
for people accustomed to typing on Swiss keyboards, with the expected
tailorings for French and German.

Change-Id: I9feed752053ecc694c84db713284f69bc1daf155
2013-10-09 17:42:17 +02:00
Jean Chalard 36c56caee3 Merge "Make the sentence separator a resource." 2013-10-08 06:44:20 +00:00
Jean Chalard 10581e68af Make the sentence separator a resource.
This will help handing correctly the armenian full stop.

Bug: 10082781
Change-Id: Id7bb219ebd89daba203216eab362d1cc26a65a36
2013-10-08 15:28:43 +09:00
Keisuke Kuroyanagi 61aae2b450 Merge "Add Ime language switching test." 2013-10-08 05:35:25 +00:00
Keisuke Kuroyanagi 72bc9ad37e Add Ime language switching test.
Change-Id: I6a96dc5fdd533899353d537382608c2759faff1c
2013-10-08 14:00:57 +09:00
Keisuke Kuroyanagi a81d37eef6 Merge "Add a large test adding bigrams for decaying dictionary." 2013-10-08 03:52:09 +00:00
Keisuke Kuroyanagi a2821fde60 Add a large test adding bigrams for decaying dictionary.
Bug: 10197478
Change-Id: I34d3c21bd7f70885a3031ce91a4d4c4ba3564856
2013-10-08 12:43:58 +09:00
Jean Chalard a6047aae94 Merge "Set the shortcut frequency correctly." 2013-10-07 10:00:34 +00:00
Jean Chalard f3204eebb1 Set the shortcut frequency correctly.
14 is the right value.

Bug: 11076722
Change-Id: I95d404b540f7fbe4932d1f8498cde23f1df0314f
2013-10-07 18:55:42 +09:00
Keisuke Kuroyanagi cfb018ba6d Fix bug and Add large test for decaying dictionary.
- GC gets failure when the dictionary become empty.
- Useless unigrams are sometimes not removed.

Bug: 10197478
Change-Id: I8d1479c01efba61a81f03bc077da6bcb4797a940
2013-10-07 17:31:01 +09:00
Jean Chalard 5db7eabafb Merge "Accept double-space-period after emoji." 2013-10-04 13:05:43 +00:00
Jean Chalard 8142fd83a6 Accept double-space-period after emoji.
This also includes a fix that allows this code to read surrogate
pairs in this processing.

Bug: 11070482
Change-Id: If5ef8d6863938252f09128b7e99ea07ece6e7019
2013-10-04 22:01:36 +09:00
Ken Wakasa 676bb517ed Merge "Add Ver4DictUpdater." 2013-10-04 09:48:27 +00:00
Ken Wakasa 618158e675 Merge "Refactor BinaryDictIOUtilsTests." 2013-10-04 09:47:35 +00:00
Yuichiro Hanada e4e0add9fb Add Ver4DictUpdater.
Change-Id: I986ab26faf535fc4bc98443053f534eced9d048f
2013-10-04 17:33:29 +09:00
Keisuke Kuroyanagi 966af8b5ba Merge "Make BinaryDictionaryTests use current time as a seed." 2013-10-04 08:04:05 +00:00
Keisuke Kuroyanagi bcb196e3b5 Make BinaryDictionaryTests use current time as a seed.
Bug: 10197478
Change-Id: Ib79cd3a81b01b16259df29b36e1df6b8f0affca8
2013-10-04 16:48:22 +09:00
Keisuke Kuroyanagi 3e5f4b53b0 Merge "Check the elapsed time for decaying." 2013-10-04 07:16:17 +00:00
Keisuke Kuroyanagi 67c855ea6f Check the elapsed time for decaying.
Bug: 6669677
Change-Id: I0401a4c0908c702ce65abfa5e017dd16cb1296f9
2013-10-04 16:11:11 +09:00
Yuichiro Hanada 75d60e821c Refactor BinaryDictIOUtilsTests.
Change-Id: I2208378b33038771b460abb33f9a690872e998e2
2013-10-04 14:19:13 +09:00
Keisuke Kuroyanagi 864ee881bd Merge "Fix UserHistoryDictionaryTests." 2013-10-03 12:02:34 +00:00
Keisuke Kuroyanagi 11f7cae094 Fix UserHistoryDictionaryTests.
Bug: 6669677
Bug: 10667710

Change-Id: I6cdc6a6c9cacc7f276fda3a26ec31e3eb928471c
2013-10-03 20:55:34 +09:00
Yuichiro Hanada d6e307a4b7 Add DictUpdater.
Change-Id: Ic586e46e5a9f59de53d53e59886d635345940974
2013-10-03 20:16:34 +09:00
Ken Wakasa 596a565ae7 Merge "Remove some unused variables." 2013-10-02 09:38:00 +00:00
Keisuke Kuroyanagi 21ce9c4a89 Merge "Stochastic decay." 2013-10-02 09:37:56 +00:00
Yuichiro Hanada 3aa8977cb2 Remove some unused variables.
Change-Id: Iaf1556fec194d17cb4318f2bdcc837f8d79449ef
2013-10-02 18:26:03 +09:00
Keisuke Kuroyanagi c76bbceedc Stochastic decay.
Bug: 6669677
Change-Id: Ib2d9228b951c77dab7a8675ce9db60677e87e771
2013-10-02 17:51:12 +09:00
Yuichiro Hanada 4284e9aae7 Make SparseTable have multiple content tables.
Bug: 10920165
Change-Id: Ie9008452ee292fb0b1fec66e2ffed228c4af6c3e
2013-10-02 15:36:13 +09:00
Jean Chalard fa946d4a0f Fix a test and crash with a better error message when reading
When there are too many bigrams, we stop reading the file,
so the file pointer is in an inconsistent place. This means we
have no idea what's going to happen next. It's better to crash
right away.

Change-Id: Id3b7b78cbe4fda3493b3c9c46758763e1ab5f6a3
2013-10-02 11:48:47 +09:00
Keisuke Kuroyanagi 6995310996 Separate "GC" and "GC with decay".
Bug: 6669677
Change-Id: I9d6aba76cef2616f0549e612db9701e1d6a19467
2013-10-01 18:09:31 +09:00
Keisuke Kuroyanagi fd02b2d6ee Implement simple dictionary decay.
Groundwork and implement simple decay.
Increment probability when typed and decrement probability
at GC.

Bug: 6669677

Change-Id: Ib12caead0cbeef4ce7808fe8ac0b00ee331523fe
2013-09-30 20:53:35 +09:00
Keisuke Kuroyanagi b698e9c1fa Fix build.
Change-Id: If7c76ca5f7030ba2003228ed1877bdb948b4b99d
2013-09-30 14:21:48 +09:00
Keisuke Kuroyanagi 1cf4789ba6 Merge "Set header attributes for ExpandableBinaryDictionary." 2013-09-29 05:14:22 +00:00
Keisuke Kuroyanagi 5ed30a7660 Set header attributes for ExpandableBinaryDictionary.
Bug: 6669677

Change-Id: I2462777eaa07600f1c774226adfc4f351882f523
2013-09-28 12:50:09 +09:00
Keisuke Kuroyanagi 8b580819a5 Merge "Add unigram/bigram counting." 2013-09-27 14:14:49 +00:00
Keisuke Kuroyanagi 31097a57cc Add unigram/bigram counting.
Bug: 6669677
Change-Id: I05ea2201d822dddf062b08c8467daa336760e16c
2013-09-27 23:12:12 +09:00
Yuichiro Hanada a328f538c3 Fix PrioritizedSerialExecutor.
It was possible that fetchNextTasks() would be called by multiple
threads concurrently.
If it happens, some tasks in the task queues might be ignored.

Change-Id: Idc81c43c45e382da3850cc55b9a42c281548d2a8
2013-09-27 16:46:34 +09:00
Keisuke Kuroyanagi e3e10317b0 Merge "Create empty dictionary file in native code." 2013-09-26 08:03:38 +00:00
Yuichiro Hanada d188af7022 Add SparseTable.
Bug: 10920165
Change-Id: I749dd0269e788799e30b10beb2671813d40ce15f
2013-09-26 16:16:30 +09:00
Keisuke Kuroyanagi 5ef6209656 Create empty dictionary file in native code.
Bug: 6669677
Change-Id: I46d23deee1fd091678f4593561cb8687eb815212
2013-09-26 12:59:02 +09:00
Ken Wakasa f56b82f809 Fix the offdevice regression test build
Followup to If4e44eca3cdc5bb02cf2e0c8c44ecd4bf27fae57

bug: 10622489
Change-Id: If98b2c75725f8692f0c2b41c33e448086404479b
2013-09-25 19:13:47 +09:00
Keisuke Kuroyanagi 2e58670da9 Quit using ExpandableDictionary.
Bug: 6669677
Change-Id: Ie90417fa9b726454fe729a665fcd549efabb9e94
2013-09-24 22:57:15 +09:00
Keisuke Kuroyanagi 3e6b68bc0e Merge "Allow large memory space for GC." 2013-09-24 10:24:28 +00:00
Keisuke Kuroyanagi 3d2802ef2e Allow large memory space for GC.
Bug: 6669677
Change-Id: I021c92a1ca5cd28f745cbfe729c99e346c58074d
2013-09-24 19:21:17 +09:00
Jean Chalard 3d68b06662 Copy only the spans we are interested in.
The PARAGRAPH type of span is dangerous, as concatenating
CharSequences that contain it may crash. We also don't use
other spans than SuggestionSpans, so we don't copy them.

Bug: 10622489
Change-Id: If4e44eca3cdc5bb02cf2e0c8c44ecd4bf27fae57
2013-09-24 19:04:51 +09:00
Keisuke Kuroyanagi f3cd38f2c7 GC step 5. Add large tests and fix bugs.
Bug: 6669677
Change-Id: I41e44a64730f9c66645995095a7ecff51ffd5351
2013-09-24 16:32:25 +09:00
Keisuke Kuroyanagi dd7d95bd4a Merge "GC step 4. Update all positions in new dict and add a test." 2013-09-24 06:45:25 +00:00
Keisuke Kuroyanagi 2cfe7f9e3b GC step 4. Update all positions in new dict and add a test.
Bug: 6669677
Change-Id: I035d848a210653dcd3c1a1f21781968adced9225
2013-09-24 15:29:56 +09:00
Yuichiro Hanada 1625aeafd2 Fix runReadUnigramsAndBigramsTests.
Change-Id: Idd9176c9943dfacac5a06957f1a07187b642b207
2013-09-24 12:31:45 +09:00
Yuichiro Hanada 14087ba52c Add Ver4DictDecoder.
Bug: 9618601
Change-Id: I43c5840505c6a847aaf4893a400392ccd45903c0
2013-09-19 16:11:23 +09:00
Keisuke Kuroyanagi 561a83118c Merge "Add dictionary header writing methods." 2013-09-18 09:17:54 +00:00
Keisuke Kuroyanagi 484fa7b59c Add dictionary header writing methods.
Bug: 6669677
Change-Id: I392ac4776b55779903cbaa17e683005d80017a41
2013-09-18 18:08:33 +09:00
Satoshi Kataoka 8837deab73 Merge "Fix Emoji recents" 2013-09-18 08:46:25 +00:00
Satoshi Kataoka ea7bfa5cd5 Fix Emoji recents
Bug: 10538430

Change-Id: Ia2e423eb1843195b3c3218afc79a5820b8cd729b
2013-09-18 17:44:16 +09:00
Keisuke Kuroyanagi 72e53a1e38 Merge "Implement dictionary flush." 2013-09-18 05:20:05 +00:00
Keisuke Kuroyanagi 1560543754 Implement dictionary flush.
Bug: 6669677
Change-Id: I1d70ac6319fb6d8700074de382568c2108887960
2013-09-18 13:19:14 +09:00
Keisuke Kuroyanagi 9465819cf6 Merge "Add BinaryDictionary.getBigramProbabilityNative()." 2013-09-18 04:10:38 +00:00
Keisuke Kuroyanagi 4d02a2d44d Add BinaryDictionary.getBigramProbabilityNative().
Bug: 10197478
Change-Id: Id16e3ee22a17679c46cc7a0199a9e28065177aa3
2013-09-18 11:18:28 +09:00
Jean Chalard e8f717943f Improve trailing quotes processing
Bug: 10445496
Change-Id: Ib7bd05aea59ae6c9b8ce31299ef2235521b0e350
2013-09-17 22:17:22 +09:00
Keisuke Kuroyanagi d9f450ef00 Implement removeBigramWords() for DynamicPatriciaTrie.
Bug: 6669677
Change-Id: I99cb517511b4c968b8bf937baab5d7f42b0f534e
2013-09-17 18:05:32 +09:00
Jean Chalard 7e51989b3f Merge "[AC7] Actually auto-commit." 2013-09-17 08:20:47 +00:00
Keisuke Kuroyanagi e8754aba1c [AC7] Actually auto-commit.
Bug: 9059617
Change-Id: I7e5d89a9037b9181a0a6456c12043b4bfda8fe4b
2013-09-17 16:44:50 +09:00
Keisuke Kuroyanagi 71cce2dd3e Add a large test for BinaryDictionary.addBigramWords().
Bug; 10197478

Change-Id: I52590dd1ff9469557672a4bef4f898ad94b47b6f
2013-09-17 15:32:37 +09:00
Keisuke Kuroyanagi 78b55a31cb Fix handling multi-bytes characters and add a test.
Bug: 6669677

Change-Id: Id2154db47adea2929559a4187a726f9dfa83363e
2013-09-17 15:11:24 +09:00
Keisuke Kuroyanagi cd6a0430c7 Implement addBigramWords() for DynamicPatriciaTrie.
Bug: 6669677
Change-Id: Ia6aa76c212165690191c65fee9dacdc44be5acd5
2013-09-17 12:52:21 +09:00
Jean Chalard 41aaff6cdf Merge "[AC4] Add native methods necessary for auto-commit" 2013-09-13 11:41:55 +00:00