Commit Graph

41991 Commits (d7970ac3c627b9bf39c23c873ca44218b29dc665)

Author SHA1 Message Date
Ming-Shin Lu d7970ac3c6 [automerger skipped] Fix Keyboard Theme update when device orientation changed am: 6ae09365a5 -s ours
am skip reason: Merged-In I288a31baf04fa2e63d6b4a14ad81b401cb36ece5 with SHA-1 407f8a3216 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/15021672

Change-Id: I3d0ca553f117d3d0871930362f68b87df2105b1c
2021-06-18 15:07:45 +00:00
Ming-Shin Lu 6ae09365a5 Fix Keyboard Theme update when device orientation changed
As CL[1] introduces diplayContext to address
IME service context's Resources / DisplayMetrics update when
switching IME window to another display after onConfigurationChange.

In LatinIME#onInitializeInterface, we only update keyboard theme context
and displayContent when the displayId is changed, but overlooked even
the displayId is the same, the display context's resource configuration
might changed like the device orientation changd.

It leads getDefaultKeyboardHeight will get wrong config_max_keyboard_height
fraction value when rotating to landcape because the context resources
didn't get updated.

Add a check to update keyboard theme context when the current display
configuation is changed accordingly.

[1]: I0ed6a079af1ed90c75fee1d36d5ce3ef3c41f8ed

Fix: 186507147
Test: manual as issue steps
    1) Turn on auto-rotate
    2) Open Settings
    3) Rotating the device to landscape mode
    4) Tap “Search settings", verify if the soft-keyboard shown and the
       size is expected.
Change-Id: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
Merged-In: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
2021-06-18 02:16:19 +00:00
Yohei Yukawa 516ab1c9b1 [automerger skipped] Bump targetSdkVersion to "30" am: 07ce283acd -s ours
am skip reason: Merged-In I4bf7588c62fb77bf78d4afcb665e9bfbbef53966 with SHA-1 360052f304 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/14985309

Change-Id: Ifc9ea2e2344d5a501e9ff031410cc4f1da99c38c
2021-06-17 10:33:11 +00:00
Yohei Yukawa 07ce283acd Bump targetSdkVersion to "30"
With this CL, versionCode, targetSdkVersion and minSdkVersion will be
bumped/set as follows:

       versionCode: 28 -> 30
  targetSdkVersion: 28 -> 30
     minSdkVersion: 21

As far as we know, there should be no user-visible behavior change on
supported OS versions.

Fix: 189558760
Test: manually verified that LatinIME still is functional
Change-Id: I3a7deb452960b370f5290f3d1bac9c79fe935303
Merged-In: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
(cherry picked from commit 360052f304)
2021-06-15 11:13:09 -07:00
Treehugger Robot a6fbccdd9e Merge "Bump targetSdkVersion to "30"" am: c880212a59 am: c7fa63d4c5
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1737355

Change-Id: Ie0ef45d6f1171bd3767bd1a26001e9513a0b94fe
2021-06-15 06:49:43 +00:00
Treehugger Robot c7fa63d4c5 Merge "Bump targetSdkVersion to "30"" am: c880212a59
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1737355

Change-Id: I63caa1f35eeda340064f05c0310d3a5eccbb1690
2021-06-15 06:35:05 +00:00
Treehugger Robot c880212a59 Merge "Bump targetSdkVersion to "30"" 2021-06-15 06:24:25 +00:00
Yohei Yukawa 360052f304 Bump targetSdkVersion to "30"
With this CL, versionCode, targetSdkVersion and minSdkVersion will be
bumped/set as follows:

       versionCode: 28 -> 30
  targetSdkVersion: 28 -> 30
     minSdkVersion: 21

As far as we know, there should be no user-visible behavior change on
supported OS versions.

Fix: 189558760
Test: manually verified that LatinIME still is functional
Change-Id: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
2021-06-14 20:32:50 -07:00
Treehugger Robot 9d1ee4ae5a Merge "Fix Keyboard Theme update when device orientation changed" am: 7ae00baa87 am: 16a01e7c0d
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1721930

Change-Id: Ic168a7cbb656a3939061ad58bd0cc7991c0ceff1
2021-05-28 06:26:09 +00:00
Treehugger Robot 16a01e7c0d Merge "Fix Keyboard Theme update when device orientation changed" am: 7ae00baa87
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1721930

Change-Id: I1d756d3f5a24e21b791ec0cd4726dadc1daa0759
2021-05-28 06:00:13 +00:00
Treehugger Robot 7ae00baa87 Merge "Fix Keyboard Theme update when device orientation changed" 2021-05-28 05:38:10 +00:00
Ming-Shin Lu 407f8a3216 Fix Keyboard Theme update when device orientation changed
As CL[1] introduces diplayContext to address
IME service context's Resources / DisplayMetrics update when
switching IME window to another display after onConfigurationChange.

In LatinIME#onInitializeInterface, we only update keyboard theme context
and displayContent when the displayId is changed, but overlooked even
the displayId is the same, the display context's resource configuration
might changed like the device orientation changd.

It leads getDefaultKeyboardHeight will get wrong config_max_keyboard_height
fraction value when rotating to landcape because the context resources
didn't get updated.

Add a check to update keyboard theme context when the current display
configuation is changed accordingly.

[1]: I0ed6a079af1ed90c75fee1d36d5ce3ef3c41f8ed

Fix: 186507147
Test: manual as issue steps
    1) Turn on auto-rotate
    2) Open Settings
    3) Rotating the device to landscape mode
    4) Tap “Search settings", verify if the soft-keyboard shown and the
       size is expected.
Change-Id: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
2021-05-28 10:18:03 +08:00
Pedro Loureiro e03eca7c3a [automerger skipped] Merge "Add lint baseline to address NewApi errors" am: 685abcb913 am: 0605aae4de am: 7e35eb12cd -s ours
am skip reason: skip tag Change-Id Ic37bd8c531af7e68c939ce9c05614c37e6699b03 with SHA-1 b47de75af3 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1675572

Change-Id: Ibc1f110c41ad148391c842766732892c31340e03
2021-04-15 13:15:22 +00:00
Pedro Loureiro 7e35eb12cd Merge "Add lint baseline to address NewApi errors" am: 685abcb913 am: 0605aae4de
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1675572

Change-Id: I1dca662027a09c4377349f1cc59e7bd5317d1e2a
2021-04-15 12:27:00 +00:00
Pedro Loureiro 0605aae4de Merge "Add lint baseline to address NewApi errors" am: 685abcb913
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1675572

Change-Id: I7d81740175550e0be44ac9069bfa6e2f1fb8716d
2021-04-15 11:49:52 +00:00
Pedro Loureiro 685abcb913 Merge "Add lint baseline to address NewApi errors" 2021-04-15 11:03:47 +00:00
Pedro Loureiro 57d4aef280 Add lint baseline to address NewApi errors
We are enabling a new lint check where the min sdk != compile sdk.
It has produced a lot of errors and adding the baseline file(s)
allows us to continue work without introducing more problems.

Bug: 150847901

Test: m lint-check
Change-Id: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
Merged-In: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
2021-04-13 15:29:44 +00:00
Pedro Loureiro b47de75af3 Add lint baseline to address NewApi errors
We are enabling a new lint check where the min sdk != compile sdk.
It has produced a lot of errors and adding the baseline file(s)
allows us to continue work without introducing more problems.

Bug: 150847901

Test: m lint-check
Change-Id: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
2021-04-12 10:48:26 +00:00
Xin Li 86bf93cdeb [automerger skipped] Mark ab/7061308 as merged in stage. am: b7027a6614 -s ours am: 8a739fb004 -s ours
am skip reason: Change-Id Ie1a0307f3c8f3fc4013b4395cb843f1a96d32b6d with SHA-1 644c0062b9 is in history

Original change: undetermined

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I9ad294a9e69b8745bfee510271ab83e3ef1e8d2d
2021-02-21 19:11:52 +00:00
Bob Badour a2330e5fb4 Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME" am: 27f8543961 am: 155f6bbb4a am: 4fd407ab72
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1588514

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I154b31a133b0b6b756a536f1c5a6c6e1b62ef1b9
2021-02-21 19:04:28 +00:00
Xin Li 8a739fb004 [automerger skipped] Mark ab/7061308 as merged in stage. am: b7027a6614 -s ours
am skip reason: Change-Id Ie1a0307f3c8f3fc4013b4395cb843f1a96d32b6d with SHA-1 644c0062b9 is in history

Original change: undetermined

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ieabf19901256253b47b767a3639b14fd3ece89a5
2021-02-20 12:06:21 +00:00
Xin Li b7027a6614 Mark ab/7061308 as merged in stage.
Bug: 180401296
Merged-In: Ie1a0307f3c8f3fc4013b4395cb843f1a96d32b6d
Change-Id: I833ab148ad9f4632a639c45b97d0b6aebd7471f1
2021-02-20 00:24:34 -08:00
Bob Badour 4fd407ab72 Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME" am: 27f8543961 am: 155f6bbb4a
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1588514

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I8ff8434dbc8097b1b1c6d36b9e652166ac19c326
2021-02-19 07:48:41 +00:00
Bob Badour 155f6bbb4a Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME" am: 27f8543961
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1588514

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I5d0e72a1db85341c5c0139b7db54862c074d6bbd
2021-02-19 06:54:36 +00:00
Bob Badour 27f8543961 Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME" 2021-02-19 06:23:21 +00:00
Bob Badour f3d9532a32 [LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME
Added SPDX-license-identifier-Apache-2.0 to:
  Android.bp
  common/Android.bp
  java/Android.bp
  native/dicttoolkit/Android.bp
  native/jni/Android.bp
  tests/Android.bp
  tools/EditTextVariations/Android.bp
  tools/dicttool/Android.bp
  tools/make-keyboard-text/Android.bp

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all

Exempt-From-Owner-Approval: janitorial work
Change-Id: I440008bffac5c97a2497970af377a9d03262b6d8
2021-02-17 09:46:27 -08:00
Treehugger Robot 936ca12acb Merge "Mark liblatinime_unittests as unit_test:true to run in presubmit in CI" am: e04480b68b am: 7471a535f4 am: ecd2dab26e
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589854

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I8458c3d58fe2efc428a69c4591c5b87bfcbd1035
2021-02-17 12:01:31 +00:00
Treehugger Robot ecd2dab26e Merge "Mark liblatinime_unittests as unit_test:true to run in presubmit in CI" am: e04480b68b am: 7471a535f4
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589854

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I4dc6006500214b819d459dc514541a06ca8cd33a
2021-02-17 11:27:38 +00:00
Treehugger Robot 7471a535f4 Merge "Mark liblatinime_unittests as unit_test:true to run in presubmit in CI" am: e04480b68b
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589854

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Idd588629cd634ebf3772d16bce882bc5b1732362
2021-02-17 10:47:51 +00:00
Treehugger Robot e04480b68b Merge "Mark liblatinime_unittests as unit_test:true to run in presubmit in CI" 2021-02-17 10:24:20 +00:00
Treehugger Robot 8d3ca33152 Merge "Fix broken liblatinime_unittests" am: 62013c4f80 am: 5e1756c5fe am: 326ff853c7
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589747

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I942d720895724ae24a241a59c3feaf71b5d2cba2
2021-02-16 20:09:36 +00:00
Treehugger Robot 326ff853c7 Merge "Fix broken liblatinime_unittests" am: 62013c4f80 am: 5e1756c5fe
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589747

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I6dd60fb5d01feed612f81fbb33adf07b1abec0cc
2021-02-16 19:35:32 +00:00
Treehugger Robot 5e1756c5fe Merge "Fix broken liblatinime_unittests" am: 62013c4f80
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589747

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I15fc9d572d67f9d8aabb699636d18f642f30cd02
2021-02-16 19:16:10 +00:00
Treehugger Robot 62013c4f80 Merge "Fix broken liblatinime_unittests" 2021-02-16 18:45:48 +00:00
Julien Desprez b19114e93b Mark liblatinime_unittests as unit_test:true to run in presubmit in CI
This will ensure that the target stays green.
Note: we will clean up the explicit unit_tests:true once cc_test default is changed.

Change-Id: I5153ca918e94b370b1f08289118877d209385ba2
Test: presubmit
Bug: 180014759
2021-02-16 18:31:04 +00:00
Adrian Roos 8b3d8f48e1 Fix broken liblatinime_unittests
Change-Id: I95021965ecc2699fbce01ed0552dd28fed7f8fe4
Merged-In: I95021965ecc2699fbce01ed0552dd28fed7f8fe4
Fixes: 180014759
Test: atest liblatinime_unittests --host
2021-02-16 17:49:08 +00:00
Xin Li a9bbf1d33a Mark ab/6881855 as merged am: 478d45fde7 am: 644c0062b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/13112993

Change-Id: I6c52501a762dee138a8d24b7b7ad30e1c64d5c1f
2020-11-23 22:58:54 +00:00
Xin Li 644c0062b9 Mark ab/6881855 as merged am: 478d45fde7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/13112993

Change-Id: Ie1a0307f3c8f3fc4013b4395cb843f1a96d32b6d
2020-11-23 22:31:40 +00:00
Xin Li 478d45fde7 Mark ab/6881855 as merged
Bug: 172690556
Change-Id: If9cf64206ba6c851ac2d72a5682a5481b25f4764
2020-11-23 11:31:57 -08:00
Xin Li b448164a2f [automerger skipped] Skip ab/6749736 in stage. am: 587c17241a -s ours am: 962c1dd464 -s ours am: 99b2349754 -s ours
am skip reason: Change-Id Idac165021a2a4835aaefeff5dc4aa9086f91015b with SHA-1 ccfef1083a is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/12797210

Change-Id: I1a8305513cb63b218647942567bbffcd1d1a2041
2020-10-09 03:37:02 +00:00
Xin Li 99b2349754 [automerger skipped] Skip ab/6749736 in stage. am: 587c17241a -s ours am: 962c1dd464 -s ours
am skip reason: Change-Id Idac165021a2a4835aaefeff5dc4aa9086f91015b with SHA-1 ccfef1083a is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/12797210

Change-Id: I0059462c62170fc5652c8453a0d9349abe996f2f
2020-10-09 02:58:26 +00:00
Xin Li 962c1dd464 [automerger skipped] Skip ab/6749736 in stage. am: 587c17241a -s ours
am skip reason: Change-Id Idac165021a2a4835aaefeff5dc4aa9086f91015b with SHA-1 ccfef1083a is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/12797210

Change-Id: Ia9b9fa1e1983ad307649562d70d79be43c759238
2020-10-09 02:24:18 +00:00
Xin Li 587c17241a Skip ab/6749736 in stage.
Merged-In: Idac165021a2a4835aaefeff5dc4aa9086f91015b
Change-Id: I41711acdaf34010adb53412e3a970cb8cff0add8
2020-10-08 17:23:11 -07:00
Xin Li 6647754cef [automerger skipped] Merge "Merge Android R" am: c65e16db60 -s ours am: 4908f9ae18 -s ours am: e2a6086b5c -s ours am: 029fc7ffa9 -s ours am: b7bacbff96 -s ours
am skip reason: Change-Id Ia56c511912ee213555b170faf292f1640d90cb75 with SHA-1 98755ccae9 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1422510

Change-Id: I80987dd2969a339472f121577cca18646639599a
2020-09-11 21:27:27 +00:00
Xin Li b7bacbff96 [automerger skipped] Merge "Merge Android R" am: c65e16db60 -s ours am: 4908f9ae18 -s ours am: e2a6086b5c -s ours am: 029fc7ffa9 -s ours
am skip reason: Change-Id Ia56c511912ee213555b170faf292f1640d90cb75 with SHA-1 98755ccae9 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1422510

Change-Id: Idb95a634a561669ed5e396f499a2d203a8c51f76
2020-09-11 03:58:57 +00:00
Xin Li 029fc7ffa9 [automerger skipped] Merge "Merge Android R" am: c65e16db60 -s ours am: 4908f9ae18 -s ours am: e2a6086b5c -s ours
am skip reason: Change-Id Ia56c511912ee213555b170faf292f1640d90cb75 with SHA-1 98755ccae9 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1422510

Change-Id: I1362f20646ccdb11a15df1eb73947764eba57928
2020-09-11 03:33:27 +00:00
Xin Li e2a6086b5c [automerger skipped] Merge "Merge Android R" am: c65e16db60 -s ours am: 4908f9ae18 -s ours
am skip reason: Change-Id Ia56c511912ee213555b170faf292f1640d90cb75 with SHA-1 98755ccae9 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1422510

Change-Id: If1dde117b9fc7e6fce93d62f9ee20ff67ccfd1ad
2020-09-11 02:02:36 +00:00
Xin Li 4908f9ae18 [automerger skipped] Merge "Merge Android R" am: c65e16db60 -s ours
am skip reason: Change-Id Ia56c511912ee213555b170faf292f1640d90cb75 with SHA-1 98755ccae9 is in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1422510

Change-Id: Ifb0e8dbe8fe34b47cc18957462003375865382b6
2020-09-11 00:40:02 +00:00
Xin Li c65e16db60 Merge "Merge Android R" 2020-09-10 17:22:04 +00:00
Xin Li 60be45ecb2 Merge Android R
Bug: 168057903
Merged-In: Ia56c511912ee213555b170faf292f1640d90cb75
Change-Id: Id2ed98b896c8f23246df31fead70c94e764aab97
2020-09-08 16:56:16 -07:00