df39eb6961
Consolidate KeyboardTextsSet.setLocale and loadStringResoucres
...
Change-Id: Idaf8f0d80fdeef4f1430f11d4083366e8ab7f6e0
2014-03-20 18:55:03 +09:00
0c268b08b6
Merge "Refactor KeyboardTextsSet class"
2014-03-20 09:52:02 +00:00
58b19655d8
Merge "Add pcqwerty layout test"
2014-03-20 09:40:47 +00:00
6007a1b7a9
Refactor KeyboardTextsSet class
...
Change-Id: Ibb59a9d4902db9ec0e00244304be9ab35b215a50
2014-03-20 18:38:59 +09:00
f64a9d8fd6
Fix subtype count test
...
This is a follow up of I6cce26c4fc.
Because we implement Basque, Galician, and preliminary Myanmar
keyboard.
Change-Id: I055fe4f453cf454bbd65bc8542733411e9d3556c
2014-03-20 17:09:08 +09:00
e7420f6bd1
Merge "Utilize autoColumnOrder for punctuation more keys"
2014-03-20 08:01:18 +00:00
844205ca2e
Utilize autoColumnOrder for punctuation more keys
...
Change-Id: I1f8f5013f0bdf93cf590b8bd00d680b31e03d8b0
2014-03-20 16:38:38 +09:00
7e9e20b7bc
Fix subtype count test
...
Because we implement Basque and Galician keyboard.
Change-Id: I6cce26c4fc17100b8f0511cb38243b1235a2375f
2014-03-20 16:36:21 +09:00
e884fde8d2
Merge "Fix Armenian punctuation order"
2014-03-20 06:43:50 +00:00
e4e6e739e8
Merge "Add armenian_phonetic layout tests"
2014-03-20 04:55:58 +00:00
d51aebd328
Fix Armenian punctuation order
...
Bug: 12623502
Change-Id: I6cc026132922e103d212b663664e7e0aa2404b35
2014-03-20 13:17:38 +09:00
36c89e7e00
Add armenian_phonetic layout tests
...
This CL adds Armenian (AM) Phonetic keyboard test.
Bug: 13017434
Change-Id: I3b93ef2094b8a9d82ca0e1b88f93136271166ddb
2014-03-20 13:01:17 +09:00
270bd39af4
Remove Latin comma from Arabic/Persian keyboard
...
Bug: 12807701
Change-Id: Icca63586d561a57b2c15cbfbae0de98dfcc137a3
2014-03-20 11:45:53 +09:00
b2b01f9125
Add pcqwerty layout test
...
This CL adds No language PC Qwerty keyboard test.
Bug: 13017434
Change-Id: I64df493b884ff0a5d30fe9e66a8c5efffacb71aa
2014-03-19 21:20:33 +09:00
110e9f9e88
Add Galician keyboard
...
Bug: 13169021
Bug: 13017434
Change-Id: I5d44dc4c2387644028a5cf594954795e014f357a
2014-03-19 19:41:18 +09:00
0c797e8867
Add Basque keyboard
...
Bug: 13169021
Bug: 13017434
Change-Id: I46c738e833a9f287586a03bda9ab0230f8b9eac1
2014-03-19 19:40:34 +09:00
9ab9f281f9
Merge "Add cloemak keyboard test"
2014-03-19 10:38:42 +00:00
4640e7c989
Fix French accented letters order
...
Bug: 13497958
Change-Id: I062a0e2e75b2f6c2606b1309808cbaa83cc91018
2014-03-19 17:43:53 +09:00
5b2c686885
Add cloemak keyboard test
...
This CL adds No language Colemak keyboard test.
Bug: 13017434
Change-Id: Ifa3480ce874013e0ae6ed62dd842e37f00d7d882
2014-03-19 17:41:21 +09:00
e40a52cc62
Add dvorak layout tests
...
This CL adds, English Dvorak, French Dvorak, German Dvorak, and No
language Dvorak keyboard tests.
Bug: 13017434
Change-Id: Ie87cee896c687eec279141389a1feda8951fddad
2014-03-19 17:40:18 +09:00
0dabae720a
Support additional more keys for keyboard layout test
...
Bug: 13017434
Change-Id: I44c31dce3391d9638979539bb5e58c0525186fb4
2014-03-19 17:27:48 +09:00
54d74ff74a
Fix unit test message
...
Change-Id: I7f98cb5784ebd7a04cd2951f0b62fa4afdcf085c
2014-03-19 15:25:27 +09:00
b58b529c9a
Merge "Clean up keyboard layout test harness a bit"
2014-03-18 08:48:23 +00:00
6d44cb5122
Clean up keyboard layout test harness a bit
...
Bug: 13017434
Change-Id: I66e5da53b9afbe44f43b8c398c2821e7a72ec4b4
2014-03-18 17:11:43 +09:00
1325ddbae3
Merge "Guard possible NumberFormatException"
2014-03-18 07:26:18 +00:00
d2c6151d4d
Guard possible NumberFormatException
...
Bug: 13472379
Change-Id: Ib7640b3d8816d8d7fb4747d2288eedd94bc49b06
2014-03-18 15:40:43 +09:00
f4f4ae8fee
Merge "Add hebrew keyboard test"
2014-03-17 10:22:06 +00:00
7961d3bb02
Add hebrew keyboard test
...
This CL adds Hebrew keyboard test.
Bug: 13017434
Change-Id: I4b200e9d1e70919d671281bf52f671240ddbe63a
2014-03-17 18:31:41 +09:00
e8facf4559
Fix cosmetic comment typo
...
Change-Id: I9772daaa2f742556b4f63ed8c08693dbce5f7534
2014-03-17 18:05:28 +09:00
b8f8d2ceb8
Add farsi keyboard test
...
This CL adds Persian keyboard test.
Bug: 13017434
Change-Id: I8c73b0940d78642fa17ac17c88ed5f5d7d7b0fa8
2014-03-17 12:42:46 +09:00
d28ac52033
Merge "Add lao keyboard test"
2014-03-17 03:25:59 +00:00
082e033ea2
Merge "Add mongolian keyboard test"
2014-03-17 03:25:51 +00:00
a8b3748b9a
Merge "Add georgian keyboard test"
2014-03-17 03:25:42 +00:00
4b94d09444
Merge "Fix Arabic keyboard text and test comments"
2014-03-17 03:25:34 +00:00
538abc27dc
Fix Arabic keyboard text and test comments
...
Bug: 13017434
Change-Id: Iec2ddab719e0c68a70bcf56a90eb4522c5fd7978
2014-03-17 11:56:13 +09:00
1234c7c4c6
Add georgian keyboard test
...
This CL adds Georgian (Georgia) keyboard test.
Bug: 13017434
Change-Id: I8499bda89365a15cfb417bdfc0bf07cf51ab232b
2014-03-17 11:37:18 +09:00
a62906126a
Add mongolian keyboard test
...
This CL adds Mongolian (Mongolia) keyboard test.
Bug: 13017434
Change-Id: I9241ef442c97a6120e97af97bbd189442e5f35fe
2014-03-17 11:36:48 +09:00
4a00627fcc
Add lao keyboard test
...
This CL adds Lao (Laos) keyboard test.
Bug: 13017434
Change-Id: I4ae63099d260b14df9663f1bc938cce7c384b9fd
2014-03-17 11:35:26 +09:00
7db6162622
Add khmer keyboard test
...
This CL adds Khmer (Cambodia) keyboard test.
Bug: 13017434
Change-Id: I610da333950ccada2bf20ae5ea49073292141e86
2014-03-17 10:57:45 +09:00
bef6a4e209
Cleanup key definitions a bit
...
Bug: 13017434
Change-Id: I0d0cfa2eb62b5030ff3c67fa40d203255e63258c
2014-03-17 10:37:58 +09:00
e8dd8b99e6
Merge "Add nepali_(romanized|traditional) keyboard layout tests"
2014-03-14 11:05:33 +00:00
b76cebee18
Merge "Add hindi keyboard test"
2014-03-14 11:04:13 +00:00
1d6855eecc
Add nepali_(romanized|traditional) keyboard layout tests
...
This CL adds Nepali Romanized, Nepali Traditional keyboard tests.
Bug: Bug: 13017434
Change-Id: Icc00aa8c34e333331a459f8d488621308dfb572b
2014-03-14 20:03:25 +09:00
e5c0e90221
Merge "Cleanup qwerty expected layout definition a bit"
2014-03-14 11:02:05 +00:00
d6e561552c
Add hindi keyboard test
...
This CL adds Hindi keyboard test.
Bug: Bug: 13017434
Change-Id: Ie9a4af5b758923474840748e190b1450d958012a
2014-03-14 20:01:48 +09:00
5c126f81ee
Merge "Add south_slavic keyboard layout tests"
2014-03-14 10:55:51 +00:00
815690273f
Merge "Add swiss keyboard layout tests"
2014-03-14 10:55:36 +00:00
a558cbaf69
Merge "Add spanish keyboard layout tests"
2014-03-14 10:55:25 +00:00
832e075167
Merge "Add qwertz keyboard layout tests"
2014-03-14 10:55:12 +00:00
e4b742cce8
Add spanish keyboard layout tests
...
This CL adds, Catalan, Esperanto, Spanish, Spanish (US), and Tagalog
keyboard tests.
Bug: 13017434
Change-Id: I0f33bfeb05300e9dd525faac982c5f08e12f1847
2014-03-14 19:48:44 +09:00
cc7ce4ea9b
Cleanup qwerty expected layout definition a bit
...
Bug: 13017434
Change-Id: I21152679986924fa56966f5476c6e797d92da57c
2014-03-14 19:41:14 +09:00
ffd7db77c3
Add swiss keyboard layout tests
...
This CL adds French (CH) and German (CH) keyboards tests.
Bug: 13017434
Change-Id: Ic8a1849cb49c4f72a9a7cd9b3f2ce3a848e0334a
2014-03-14 19:37:06 +09:00
9cd2729c88
Merge "Add greek keyboard layout test"
2014-03-14 10:36:56 +00:00
38df3a9072
Merge "Add nordic layout keyboard tests"
2014-03-14 10:36:45 +00:00
3eb267cc46
Merge "Add bulgarian and bulgarian_bds keyboard layout tests"
2014-03-14 10:36:35 +00:00
e6674070a5
Add bulgarian and bulgarian_bds keyboard layout tests
...
Bug: 13017434
Change-Id: I271476d06941864a44890321231b1f0ad570c05b
2014-03-14 19:31:06 +09:00
4e3fa63891
Add south_slavic keyboard layout tests
...
This CL adds, Macedonian and Serbian keyboard tests.
Bug: 13017434
Change-Id: I6336a700b42dc886c7b1ccb32da83a5dbf9bd767
2014-03-14 19:30:02 +09:00
2f23ad940a
Add qwertz keyboard layout tests
...
This CL adds Croatian, Czech, French (QWERTY), German, Hungarian
keyboard tests.
Bug: 13017434
Change-Id: If567f86335d9f4a2985cc73544fe85dee32c9844
2014-03-14 19:25:13 +09:00
c132390b58
Add nordic layout keyboard tests
...
This CL adds Danish, Estonian, Finnish, Norwegian, and Swedish tests.
Bug: 13017434
Change-Id: I26fa2c42b78f708c0ffa2c3b4e7d340a4306f74b
2014-03-14 19:22:51 +09:00
a394a62d0b
Add greek keyboard layout test
...
This CL adds Greek keyboard tests.
Bug: 13017434
Change-Id: Iab02d0582d71ebb37a3b96efc258781ed65db203
2014-03-14 19:18:33 +09:00
be1c44c688
Merge "Add east_slavic keyboard layout tests"
2014-03-14 10:17:51 +00:00
391eaaeed5
Merge "Add azerty layout keyboard tests"
2014-03-14 10:17:39 +00:00
240fb4b3ff
Add east_slavic keyboard layout tests
...
This CL adds, Belarusian, Kazakh, Kyrgyz, Russian, and Ukrainian
keyboard tests.
Bug: 13017434
Change-Id: I0c53c66dd062e549485075398ed80e7836b50566
2014-03-14 19:10:52 +09:00
a56681c9cd
Add azerty layout keyboard tests
...
This CL adds French and Dutch (Belgium) keyboard tests.
Bug: 13017434
Change-Id: I06dc20c86493ef67dda141b49523bb3ce7960d94
2014-03-14 19:04:36 +09:00
8e63a8eaa0
Add arabic keyboard layout test
...
Bug: 13017434
Change-Id: If22733ceff08ac8568943ec461e018ea586afc23
2014-03-14 19:02:32 +09:00
598c311ce0
Add thai layout test
...
This CL adds Thai keyboard test.
Bug: 13017434
Change-Id: Ic0d7a0807e03ac93509ef9f48b97eebe5456ea71
2014-03-14 18:43:37 +09:00
cd15cfdaab
No need to specify dimensions for AbstractKeyboardBuilder
...
Bug: 13017434
Change-Id: I1cce6d9f072dff8ce2a53b8089f09105ba812a2b
2014-03-14 18:37:40 +09:00
746f94c671
Add ZWNJ_ZWJ_KEY for keyboard layout test
...
This CL also refactors Symbols and SymbolsShifted class a bit.
Bug: 13017434
Change-Id: I42bfe96553ea8447fc834d29c09ce1ce7794650d
2014-03-14 16:32:09 +09:00
74f259a74e
Add moreKeys helper method for unit test
...
Bug: 13017434
Change-Id: Icfaa4093686e2d8dec00d5acce894bfc6a2474b7
2014-03-14 15:54:25 +09:00
599e61d70c
Merge "Change default decaying parameters."
2014-03-14 06:16:02 +00:00
4ba6eec9fd
Merge "Fix unit tests."
2014-03-14 05:12:51 +00:00
98705b6bf5
Fix unit tests.
...
Change-Id: I2a85763358e1eef0f76ef827413afffeb4cb8058
2014-03-14 12:27:23 +09:00
73a2426d45
Change default decaying parameters.
...
Bug: 13458617
Change-Id: I4942af4a48881fb6ca866c74140b262e6d323f4a
2014-03-14 12:23:24 +09:00
1912609a9e
Add qwerty keyboard layout tests
...
This CL adds Afrikaans, Azerbaijani (AZ), Dutch, English (UK), French
(CA), German (QWERTY), Icelandic, Indonesian, Italian, Latvian,
Lithuanian, Malay (NY), Polish, Portuguese (BR/PT), Romanian, Slovak,
Slovenian, Swahili, Turkish, Vietnamese, Zulu, and No Language
keyboards tests.
Bug: 13017434
Change-Id: I2343dc8e74172ac551ef86f82453ae796b6f19dc
2014-03-14 10:42:27 +09:00
15a6b66dda
Refactor keyboard layout test more customizable
...
Bug: 13017434
Change-Id: I804b4cb9f56684d425e83a20cb3f71d947a87f98
2014-03-13 20:55:22 +09:00
61467744e7
Unit test update for I7ed95a54344d8b.
...
Change-Id: Ic8af56b8741ee7c231d73ce6a660fd32c9f5a3b3
2014-03-12 15:41:20 +09:00
8542c48c30
Cleanup private method names
...
This is a follow up of Ib0ded6f98a.
Change-Id: I91ad3504d301113680194ad5b10913fc86006150
2014-03-11 19:04:57 +09:00
8c1965ba04
Add keyboard layout name constant
...
Change-Id: I6cdc3efdb58e7a1efb3e352d80d0aa41e333a150
2014-03-11 18:41:55 +09:00
bab437fb3b
Another small cleanup for test code
...
Change-Id: Ib0ded6f98a6ce9197c8af79778af59d894ee54a6
2014-03-11 17:55:11 +09:00
0722e6b3df
Small cleanup for test code
...
Change-Id: I5106c8c52bdd11bfd23aa2e09f7ea53504083679
2014-03-11 17:28:19 +09:00
f247b171ce
Refactor currency and quotes keys tests
...
Bug: 13017434
Change-Id: I38dff3c8b9b28eff4397c7cdbad623fb43cbc312
2014-03-11 16:11:31 +09:00
32326a9d7a
Merge "Move DictionaryOptions from FusionDictionary to FormatSpec."
2014-03-07 10:42:18 +00:00
a0a8d96c49
Merge "Filter Spacer before keyboard layout test"
2014-03-07 10:33:37 +00:00
8c6b34e51d
Filter Spacer before keyboard layout test
...
Bug: 13017434
Change-Id: I836d2f79a839ee77325535c08d7a59bb02b83c28
2014-03-07 19:18:51 +09:00
a103e29d00
Merge "Separate WeightedString from FusionDictionary."
2014-03-07 09:07:26 +00:00
0dc53b0699
Add en_US keyboard layout test
...
Bug: 13017434
Change-Id: I3fb343721221ecae210bffcb3e83ce4f2df0d0ff
2014-03-07 17:44:36 +09:00
238e9898cd
Add QWERTY expected keyboard layouts
...
Bug: 13017434
Change-Id: Ia8a65b692521f0050f003e20712a5873a0b236b4
2014-03-07 17:39:54 +09:00
ff8405cdfb
Add ActualKeyboardBuilder for testing keyboard layouts
...
Bug: 13017434
Change-Id: I38b1f5c261ea1f3ff312c780d7d9b5fe3fba8aaf
2014-03-07 17:29:58 +09:00
f7c84f35c7
Add ExpectedKeyboardBuilder for testing keyboard layouts
...
Bug: 13017434
Change-Id: I77ea2a60b1f3adf061689c68971d136ea5cf595e
2014-03-06 19:32:43 +09:00
3ad4af2354
Move DictionaryOptions from FusionDictionary to FormatSpec.
...
Bug: 8187060
Bug:13035567
Change-Id: Id4f45e589521ae98c926a4c0607be10ce1a983f2
2014-03-06 18:53:09 +09:00
516f86815d
Separate WeightedString from FusionDictionary.
...
Bug: 8187060
Change-Id: I40c1dafca3eb52244c64fdb4c1db30a56385d678
2014-03-06 18:53:06 +09:00
c39c912a33
Add ExpectedKey for testing keyboard layouts
...
Bug: 13017434
Change-Id: I1c3b2c9cd1b86bdd782fc522b83380ec112f863b
2014-03-06 18:13:28 +09:00
274eae95ba
Merge "Separate utility methods from BinaryDictionary."
2014-03-05 10:07:33 +00:00
e784148ae6
Separate utility methods from BinaryDictionary.
...
Bug: 8187060
Change-Id: Ice2984e332b7bd3bb17174aefc80b5635b72fc50
2014-03-05 18:19:34 +09:00
3da9e4ade0
Add action key label/icon tests
...
Bug: 13017434
Change-Id: Ib04b377f4f4f9081573ef341f15b4b444ce7260c
2014-03-04 15:42:59 +09:00
73b3b81149
Separate flaky unit test from KeyboardLayoutSetTestsBase
...
Move the flaky unit test to KeyboardLayoutSetSubtypesCountTests.
Bug: 13291370
Bug: 13017434
Change-Id: I2144be4cc6b8215b895c45f47a5190fdeaa806f9
2014-03-04 15:40:40 +09:00
3f91acdc96
Add additional subtypes test
...
Change-Id: I2994fd72bc284c84757f5a2bfa8045aa574a8fbc
2014-03-03 17:16:02 +09:00
d648d066ea
Fix unit test message to use 0-based index
...
Change-Id: I2c91628d21dc96712f6cbea996f28f5d39fb402e
2014-03-03 12:39:53 +09:00
684f5f18b1
Merge "Added a method and run GC for testing."
2014-02-28 09:33:51 +00:00
d302b98ce6
Added a method and run GC for testing.
...
Bug: 13231889
Change-Id: If64b7422967c3e4107c845072b64a7bb26a35f7e
2014-02-28 18:17:09 +09:00
5c7c538f16
Add unit test message for KeyboardLayoutSetTests
...
Change-Id: Ia92e4b410ca966d2dc1c5f29a340d366aa066838
2014-02-28 13:15:27 +09:00
b24dc822bc
Name constants of the number of subtypes.
...
This is a follow up CL of Ief028e8ab5.
Bug: 13017434
Change-Id: Idf0a47300c208b9904ffcc8b64d97a43b4d708ae
2014-02-27 12:37:20 +09:00
997ba1b41e
Merge "Add keyboard layout set tests"
2014-02-27 03:08:42 +00:00
dd01a0bb1d
Add keyboard layout set tests
...
This CL is a ground work to add keyboard layout labels and more keys
tests.
Bug: 13017434
Change-Id: Ief028e8ab563d79bc0b0f9c06f1fe1d645a6469d
2014-02-26 16:10:52 +09:00
53b62fe7d0
Add KeyboardTextsSetTests
...
- Text "label_to_alpha_key" needed to implement Emoji keyboard exists.
- Test the text from resources are loaded correctly.
Bug: 13017434
Change-Id: Idfb9ac87c1556c535ebc10eaef78d8166799a657
2014-02-25 12:24:55 +09:00
890b44e537
Correctly read the header of APK-embedded dicts
...
Bug: 13164518
Change-Id: I8768ad887af8b89ad9f29637f606c3c68629c7ca
2014-02-24 22:54:01 +09:00
8e2951f299
Merge "Fix punctuation test for tablet"
2014-02-21 11:54:28 +00:00
d28a58c25d
Fix punctuation test for tablet
...
It seems that some test devices are tablet and some are phone. The
unit test should aware of which device the test is running.
Change-Id: I8651a540993de29aa1cd9f40919dffe7a8df9512
2014-02-21 17:50:07 +09:00
239256b156
Merge "Add an auto-correction by user history test."
2014-02-21 07:59:05 +00:00
4cc582f3ba
Add an auto-correction by user history test.
...
Bug: 11122480
Change-Id: I830bb3399f9839a80c6d86fbf582299bce424871
2014-02-21 13:12:26 +09:00
e03e4257f1
Merge "Add test only methods to test personalized dicts."
2014-02-20 13:25:59 +00:00
d36328cecf
Add test only methods to test personalized dicts.
...
Bug: 11122480
Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
2014-02-20 22:20:43 +09:00
21f9482999
Fix: UserHistoryDictionaryTests.testDecaying().
...
Bug: 13106697
Change-Id: If81f77c3cefdefae94cb9145aa9f700494f8237a
2014-02-20 21:23:57 +09:00
0bc66daae3
Add user history dictionary decaying test.
...
Bug: 10667710
Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
2014-02-20 18:36:46 +09:00
fbb8cb5a82
Fix build
...
This is a forgotten rebase
Change-Id: I7c7c381775488ed9239dc284bd9c31247a86a972
2014-02-18 20:08:53 +09:00
28e0b24965
Merge "Fix a bug where the cache would be out of sync"
2014-02-18 10:58:50 +00:00
fe92c174ea
Fix a bug where the cache would be out of sync
...
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.
Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
2014-02-18 19:55:54 +09:00
63be066544
Cleanup.
...
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.
Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
2014-02-18 17:07:46 +09:00
6d43124215
Stop using deprecated InputMethodSubtype constructor
...
The constructors of InputMethodSubtype were deprecated in API level 19.
However we cannot yet switch to a new InputMethodSubtypeBuilder style
due to our minimum support API level.
As an intermediate solution, this patch replaces the these API calls
with InputMethodSubtypeCompatUtils.newInputMethodSubtype so that
these legacy API call can be consolidated at the same place.
BUG: 13030512
Change-Id: I561a585f5dbea56c337680b645be5ef07015a0b1
2014-02-17 15:32:33 +09:00
95d16561e0
Remove unused code.
...
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
2014-02-15 17:39:24 +09:00
0fc93fe445
Implement PatriciaTriePolicy::getNextWordAndNextToken().
...
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
2014-02-15 17:39:20 +09:00
85fe06e759
Merge "Remove unused argument from readDictionaryBinary."
2014-02-14 10:37:56 +00:00
8e3a1d0f89
Remove unused argument from readDictionaryBinary.
...
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
2014-02-14 19:02:15 +09:00
8fa7a09f1e
Merge "Implement PatriciaTriePolicy::getWordProperty()."
2014-02-14 09:08:09 +00:00
e4b0add353
Fix SpacingAndPunctuationsTests due to I2219224840
...
Bug: 12640318
Change-Id: If0b0696b937c580d69cb909ddaf414d01ea2c01b
2014-02-14 17:59:53 +09:00
c63d183473
Implement PatriciaTriePolicy::getWordProperty().
...
Bug: 12810574
Change-Id: I7bcccfd3641ebbcf2b8d857d33bb4734c42af5eb
2014-02-14 17:56:45 +09:00
a273319c59
Add PunctuationSuggestions class
...
This change must be checked in together with I366c477516.
Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
2014-02-14 14:13:39 +09:00
bd0591ce62
Merge "Make InputLogicTest more robust"
2014-02-13 10:44:44 +00:00
da973e75dc
Make InputLogicTest more robust
...
Change-Id: I134f14971126cbeed05b472c08747f2b88ad30e6
2014-02-13 19:38:51 +09:00
5dc0d405b4
Merge "Clean-up follow-up to I3ecc8496"
2014-02-13 10:26:48 +00:00
2d68f4b392
Clean-up follow-up to I3ecc8496
...
Change-Id: I8db952a4152dab027e4f34bc5270bfca508d154d
2014-02-13 19:18:29 +09:00
7ae6721ffa
Remove RTL aware !code and add corresponding !text
...
Change-Id: I9021c8fa1cf2d4ac07579237a939c15551509a0b
2014-02-13 17:32:09 +09:00
36b8962a9a
Merge "Fix UserHistoryDictionaryTests"
2014-02-13 07:49:51 +00:00
0cda0e8a9c
Fix UserHistoryDictionaryTests
...
Change-Id: I5f2f555f9c3f471545921ef80e4cf528976be837
2014-02-13 16:16:44 +09:00
e0a425681c
Merge "Fix a test."
2014-02-13 05:20:58 +00:00
cf03ff02b1
Fix a test.
...
This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.
Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
2014-02-13 14:01:37 +09:00
bac89ecc50
Fix a failing test.
...
A replay of that old, horribly hard-to-find bug: we post a
resume message during onStartInputView, so we need
to process it before we start the test. But now the message
is posted with a delay, so we need to wait for the delay...
Change-Id: I843d70e636fa51a68aadbdbbaa73b1711ad7bddd
2014-02-12 23:32:51 +09:00
2ef87aee3e
Merge "Make PtNode have ProbabilityInfo instead of raw value."
2014-02-10 06:10:51 +00:00
8ffc631826
Make PtNode have ProbabilityInfo instead of raw value.
...
Bug: 11281877
Bug: 12810574
Change-Id: Id1cda0afc74c4e30633c735729143491b2274a7b
2014-02-10 15:05:08 +09:00
bd9887a574
Fix possible NPE while finding device override value from resource
...
Bug: 12949735
Change-Id: Iffda08db413b3b3d338ab9bf625bb0968c2e48dd
2014-02-10 14:38:53 +09:00
a9e1db6636
Merge "Decimal number is treated as outputText"
2014-02-07 09:26:04 +00:00
6422f77e94
Merge "Use native logic to read Ver4 dict."
2014-02-06 13:00:09 +00:00
ab6a93773b
Use native logic to read Ver4 dict.
...
Bug: 11281877
Bug: 12810574
Change-Id: Ief371d3ef61818e4e031de4659aee3c9584c7379
2014-02-06 21:55:37 +09:00
3bbd50c36b
Use SubtypeLocaleUtils.isRtlLanguage
...
Change-Id: Ic0208412cd9c02975641cb5c448d092f28786746
2014-02-06 18:15:32 +09:00
a9e1930a6a
Merge "Conditionally store the raw suggestions."
2014-02-06 07:31:22 +00:00
4a64ad9538
Decimal number is treated as outputText
...
Change-Id: I9d4a8ac5dd26a7c41fcfbe1842a40f347a2f2aab
2014-02-06 16:30:12 +09:00
a49f61f8a7
Conditionally store the raw suggestions.
...
Bug: 12913520
Change-Id: Ie15f97d90c142c51089280252b35b5ad1d226e19
2014-02-06 16:14:41 +09:00
337dce8074
Merge "Consolidate WordProperty and Word."
2014-02-06 07:02:07 +00:00
5f5feeba13
Consolidate WordProperty and Word.
...
Bug: 11281877
Bug: 12810574
Change-Id: I9dc99188f80f25a8780c1860dab46e4aa80a23e5
2014-02-06 15:13:33 +09:00
58eed6360d
Merge "Stop considering personalization dicts outputs as words"
2014-02-05 13:33:12 +00:00
5095fabdd0
Stop considering personalization dicts outputs as words
...
Bug: 12800726
Bug: 12798403
Change-Id: I6d60f9ad39761757f8a64533f40d6441f3a36410
2014-02-05 21:57:37 +09:00
239f7daf4a
Merge "Make WeightedString have ProbabilityInfo."
2014-02-05 12:53:14 +00:00
df1d3e733e
Make WeightedString have ProbabilityInfo.
...
Bug: 11281877
Bug: 12810574
Change-Id: I265e3d8654c75766cd0e0d09d67ef62b4566298a
2014-02-05 21:44:55 +09:00
02a534d13f
Merge "Treat a sole "|" as a special case of key label"
2014-02-05 09:32:12 +00:00
6e5dbdd501
Merge "Add null check to KeySpecParser"
2014-02-05 09:32:04 +00:00
b162911fa4
Merge "[HD04] Make the locale mandatory."
2014-02-05 09:16:17 +00:00
f7d8b8fcbc
Treat a sole "|" as a special case of key label
...
Change-Id: Ia72c31d15c891fa522935ba9792e88fd5d8ce7f7
2014-02-05 17:57:44 +09:00
d9c6b33209
Add null check to KeySpecParser
...
Change-Id: Ic37db8cbf8f83f753d7381e1edba8eac1ef1ceb1
2014-02-05 17:49:26 +09:00
43cf9076b2
[HD04] Make the locale mandatory.
...
Bug: 11281748
Change-Id: I69281b0053bec404c3e3c713ade3f65a140f51b1
2014-02-05 17:35:25 +09:00
2151216c09
Rename base test class KeySpecParserTestsBase
...
Change-Id: I41e1ccb3f0cfde4e5ae311a763e5659e5ff71d3c
2014-02-05 14:55:36 +09:00
e158c92ae1
Merge "Add KeySpecParser unit test"
2014-02-05 03:35:17 +00:00
b986f78ba8
Separate header class from FormatSpec.
...
Bug: 12810574
Change-Id: Iacf1cd05a268bf690ab864b5e32a18a4b0ccc693
2014-02-04 21:36:04 +09:00
853e8d8869
Add KeySpecParser unit test
...
Change-Id: Ie1c32daecefc2909e58056f515631cbd7de687f7
2014-02-04 19:01:45 +09:00
d79fd29f61
Make dumpAllWordsForDebug() use getNextWordProperty().
...
Bug: 11736680
Bug: 12810574
Change-Id: I32a388e23ee7da5d7291e88a46c90b61d2f25dee
2014-02-04 13:51:49 +09:00
941734695b
Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken.
...
Bug: 12810574
Change-Id: Idea44f03c477964f58e65fbf2b55e3fcd77a2934
2014-02-04 12:42:14 +09:00
9221772ab7
Get bigram information via getWordProperty().
...
Bug: 12810574
Change-Id: I2750a5659ccbc3e31307c28e35dd9a1dbdffbeee
2014-02-03 11:47:26 +09:00
5ecf74b148
Merge "Extend jni interface to get bigrams in WordProperty."
2014-01-31 11:53:10 +00:00
94d9a2309f
Extend jni interface to get bigrams in WordProperty.
...
Bug: 12810574
Change-Id: Ia4b88d02ea8790a5c47d32376cc0b84c3e071ddd
2014-01-31 20:32:44 +09:00
2ae7e53c77
Merge "Move some methods to MoreKeySpec class"
2014-01-31 11:23:41 +00:00
e855093f55
Move some methods to MoreKeySpec class
...
Change-Id: I025ed15e36ac3113db6a5fccefa0c87f016703fa
2014-01-31 20:19:48 +09:00
35ff07c70b
Merge "Fix BinaryDictDecoderEncoderTests."
2014-01-31 10:58:26 +00:00
5cb7509314
Fix BinaryDictDecoderEncoderTests.
...
Bug: 12809791
Change-Id: I04313df78692b01e153a34c932a37f079a924105
2014-01-31 19:44:17 +09:00
4e6f72cb80
Merge "[HD03] Straighten out attribute key names in Java."
2014-01-31 08:40:25 +00:00
0bae2ab460
Refactor KeyboardTextsSet class
...
Change-Id: I0b48c85aa2c291e1e7ee25d61c558700fc677e29
2014-01-31 16:31:07 +09:00
79b2e4d86c
[HD03] Straighten out attribute key names in Java.
...
Bug: 11281748
Change-Id: I1d813bdacd45bcfd9c4cc73ac1d67c5c89854e86
2014-01-31 14:46:07 +09:00
080a35e959
Rename UnigramProperty to WordProperty.
...
Bug: 12810574
Change-Id: If5ddd803948aaf6e491ddcbaa5436fb3af3f7257
2014-01-31 11:06:42 +09:00
26bd46095a
Reading dictionary containing timestamps in Java Side.
...
Just skipping historical information fields.
Bug: 11281877
Change-Id: I43d2adaa576b7da11ed3ca54990265dbb6f53b08
2014-01-29 20:19:24 +09:00
c2e2b3949b
Merge "Add SubtypeLocaleUtils.isRtlLanguage method"
2014-01-28 01:28:47 +00:00
c0c74d22a0
Add SubtypeLocaleUtils.isRtlLanguage method
...
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
2014-01-27 19:05:16 +09:00
6d1c8b2c3f
Merge "Try to figure out whether d.quotes open or close."
2014-01-27 10:01:17 +00:00
73472efac1
Fix SubtypeLocaleUtilsTests
...
Change-Id: Ifbdfd320b1416d210592ec14099e4dd9d9d0047d
2014-01-27 18:23:54 +09:00
c7ef305bbc
Try to figure out whether d.quotes open or close.
...
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
2014-01-27 18:17:33 +09:00
963d97af6d
Merge "Add length check for dict update operations."
2014-01-25 00:47:27 +00:00
51c5ec10f9
Add length check for dict update operations.
...
Bug: 12602903
Change-Id: I6835dee8bf8b356f0f1cf6c0531bee5b3415a13f
2014-01-24 16:32:42 -08:00
0acd121083
Fix wrong indents.
...
Removed an unused method too.
Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
2014-01-24 23:55:33 +09:00
90adbc7fdf
Fix build
...
Missing change after a thousandth comment fix
Change-Id: Iec48f892978507fb9823236cd1c5a70209b58b0e
2014-01-24 12:16:22 +09:00
1d6e647ac3
[IL69.1] Move a static method to a utility class.
...
This is a followup to IL69.
Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
2014-01-24 11:59:23 +09:00
1284e556f4
[IL70] Remove unused arguments
...
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
2014-01-23 15:33:14 +09:00
d1f463eacf
[IL69] Oust Keyboard from WordComposer#setComposingWord
...
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
2014-01-23 15:32:59 +09:00
c93cf1c398
Use sorted int[] to represent word separators
...
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
2014-01-20 19:40:02 +09:00
837cdd738b
Add SpacingAndPunctuationsTests
...
Change-Id: I78d488ad84a11af809ee1f8d3d2fa01a89fbfa28
2014-01-20 18:33:45 +09:00
2334bf6d8c
Merge "Fix a bug specific to German capitalization."
2014-01-17 01:49:14 +00:00
60afa7000f
Fix a bug specific to German capitalization.
...
Bug: 9663105
Change-Id: Ib68ee4edb135e96dfca229c1ccce308e7e638bdd
2014-01-17 02:06:24 +09:00
d78a447d10
Add a dedicated method to control time in native code.
...
Bug: 12443085
Change-Id: I41a5cf6c895cb59e54af98b40efded36afcd3247
2014-01-15 14:55:57 -08:00
7b9b095090
Move LanguageModelParams class to utility package
...
This change must be checked in together with Ic82d951237.
Change-Id: I2ab451330f85a0147563b805682f26edecb71a29
2014-01-15 16:14:53 +09:00
68069c55c4
Fix flaky unit test.
...
Change-Id: I8df0f9a0398b29f679844f256ad84f09ebcea8ee
2014-01-14 18:51:29 -08:00
7b6e999cd1
Fix a test.
...
Bug: 12483313
Change-Id: Ia811d614b9260367871bc5717f587538adf46789
2014-01-10 21:39:43 +09:00
84a3047e80
Fix build.
...
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
2014-01-10 12:18:26 +09:00
ee35e69eae
Passing SpacingAndPunctuations to StringUtils.looksValidForDictionaryInsertion
...
This change must be checked in together with Iec437d6df0.
Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
2014-01-09 19:05:09 +09:00
494e2d6c17
Passing SpacingAndPunctuations to RichInputConnection.getNthPreviousWords
...
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
2014-01-09 18:33:25 +09:00
d7660c6f56
Merge "Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode"
2014-01-09 09:31:32 +00:00
0a75cf51af
Passing SpacingAndPunctuations to CapsModeUtils.getCapsMode
...
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
2014-01-09 18:19:17 +09:00
e4ae5855cb
Fix a unit test in InputLogicTests.
...
Change-Id: I63a20bb2e4b3c39495fade6cae3a14fdd11ca48c
2014-01-09 16:23:43 +09:00
5742a415f3
Merge "Make reloadMainDict() private."
2014-01-08 11:03:02 +00:00
9f1fe87580
Make reloadMainDict() private.
...
Bug: 8187060
Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
2014-01-08 18:59:43 +09:00
ad78058a93
Rename InputPointers.addPointer and ResizableIntArray.add
...
Change-Id: I5580250c91b29f93ed886b080ce33845b3b67ace
2014-01-08 14:30:21 +09:00
e13cc9d7e5
Fix ResizableIntArrayTests readability
...
Change-Id: I68862b98f228210f1d76fef4fd7454edbfd8e01d
2014-01-08 14:30:21 +09:00
e7dc5302af
Fix InputPointersTests
...
InputPointers.getTime(int) has a validity check of time values. And
the check is enabled when LatinImeLogger.sDBG is on. Such situation
may occur while unit testing. This change ensure that time values are
monotonic while unit testing.
Change-Id: I9ff2cff2bcd253de0e8206dd3be964fe565170fa
2014-01-08 14:14:42 +09:00
1e50c681af
[IL52] Remove a useless method.
...
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.
Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.
Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
2013-12-27 22:40:19 +09:00
6bca9ac43d
Fix a bug where predictions would not pop upon manual pick
...
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
2013-12-26 23:19:29 +09:00
d77ad1902b
Fix NPE in a unit test.
...
Change-Id: I0dfc23232ed77e1ff1aedecfa6ac022020cb1c19
2013-12-26 17:01:48 +09:00
4a55ee1440
Fix typo in a unit test.
...
Change-Id: I9222533704722265511b9fe6fb5caf99765e198b
2013-12-25 13:13:43 +09:00
1404c1af85
[IL21] Move the workaround utils to a better place.
...
Bug: 8636060
Change-Id: I566f9e109ebcabe3a6a778118434ce79d02d1113
2013-12-20 16:48:54 +09:00
dfbe2bfe08
Add some info to test crashes to help diagnose flakiness
...
Bug: 11142685
Change-Id: Ic3a5d452f6c325248ac4e1bfa37774c58586f359
2013-12-18 18:10:56 +09:00
c2fd53ee0e
Remove ver4 dict updater.
...
Change-Id: I468994c98d091be621b9fb3fbe6405c67fc6a465
2013-12-17 18:17:51 +09:00
42334bb493
Quit checking bigram order in BinaryDictDecoderEncoderTests.
...
Change-Id: I1b8eb6ab2ea797d2590495b1f57f9ec9560ea817
2013-12-17 17:38:24 +09:00
b54c747d7c
Merge "Move DictUpdater to the tests directory."
2013-12-17 05:33:16 +00:00
4fdcefe504
Move DictUpdater to the tests directory.
...
Bug: 11245133
Change-Id: I0907a091ac3ae960eaf3b27da78dbb48a24b2ea1
2013-12-17 14:31:25 +09:00
7cd7cf73f4
Fix a bug with languages without spaces and predictions
...
This is simpler and more correct.
Change-Id: I41806d2fc12b4ca25f76e32972b38f91f3d05c2b
2013-12-16 23:16:02 +09:00
b868375763
Fix failing tests
...
- Version 3 is not supported
- Now passing the right string to open v4 dicts. Fix the tests for this.
Change-Id: I7829330c3568a715b96396ba4e4e69c6e17775ab
2013-12-16 14:32:19 +09:00
f08b1ea41a
Merge "Remove references to the v3 dictionary."
2013-12-13 10:08:12 +00:00
1dc7eca114
Remove references to the v3 dictionary.
...
Change-Id: I811c8c923ad67a6d9bfdd11bdef8991eb7135c27
2013-12-13 18:53:41 +09:00
3e81d9c39f
Merge "Remove code for forgetting curve in Java side."
2013-12-13 09:44:16 +00:00
cc8c544ee2
Remove code for forgetting curve in Java side.
...
Change-Id: I294ed179c642ff52452b5884326c1083477e1bce
2013-12-13 18:40:58 +09:00
a245d15da5
Have dicttool use the native library to generate v4 dicts.
...
Yay !
Change-Id: Iea8ced9e81031b9ab7eff05ad9ef7215be248de9
2013-12-13 18:18:20 +09:00
7b55cd3e2b
Remove flags from Java side.
...
This simplifies the code quite a bit.
- GERMAN_UMLAUTS are now handled through a key-value attribute.
The dictionary generator does not need to know about it any more.
- FRENCH_LIGATURES are deprecated as we handle them with shortcuts now.
- CONTAINS_BIGRAMS is deprecated. Bigram processing is always applied
regardless of this flag.
Bug: 11281748
Change-Id: If567e52e245a9342adc7f3104a0f7d8d782df8c1
2013-12-13 18:15:05 +09:00
2fa3693c26
Reset to 9bd6dac470
...
The bulk merge from -bayo to klp-dev should not have been merged to master.
Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
2013-12-13 17:13:32 +09:00
5b5ed3d609
Fix a bug where autocaps would jam auto-commit
...
Bug: 11311002
Change-Id: I62955e364c9ffc75322cf05fa3ad7985f1d09259
2013-10-22 05:23:48 -07:00
eacb2be8fe
Fix unit test for If8c94ef91ed58bb5028f51be7c8d9beb677436a4
...
Change-Id: I056013de3a5e09feed429dfd8097d3d85331a0ab
2013-10-11 16:52:12 +09:00
9514ed5c2a
Add the new format of bigram entries.
...
In new format, each bigram entry has flags (1 byte), a terminal id (3 byte),
a time-stamp (4 byte), a counter (1 byte) and a level (1 byte).
Bug: 10920255
Bug: 10920165
Change-Id: I0f7fc125a6178e6d25a07e8462afc41a7f57e3e1
2013-10-11 14:50:41 +09:00
56402cf10a
Revert "Add Swiss French and German keyboard layouts."
...
This reverts commit 220ce8f269
2013-10-10 02:05:50 +00:00
220ce8f269
Add Swiss French and German keyboard layouts.
...
There used to be two "Swiss" keyboard layouts, labelled fr_CH and de_QY,
available in LatinIME. They were, however, not actually Swiss layouts
but instead work-arounds to be able to get French or German with qwertz
or qwerty (instead of azerty and qwertz) layouts, respectively. These
were thus removed by commit f6972561fc
2013-10-09 17:42:17 +02:00
36c56caee3
Merge "Make the sentence separator a resource."
2013-10-08 06:44:20 +00:00
10581e68af
Make the sentence separator a resource.
...
This will help handing correctly the armenian full stop.
Bug: 10082781
Change-Id: Id7bb219ebd89daba203216eab362d1cc26a65a36
2013-10-08 15:28:43 +09:00
61aae2b450
Merge "Add Ime language switching test."
2013-10-08 05:35:25 +00:00
72bc9ad37e
Add Ime language switching test.
...
Change-Id: I6a96dc5fdd533899353d537382608c2759faff1c
2013-10-08 14:00:57 +09:00
a81d37eef6
Merge "Add a large test adding bigrams for decaying dictionary."
2013-10-08 03:52:09 +00:00
a2821fde60
Add a large test adding bigrams for decaying dictionary.
...
Bug: 10197478
Change-Id: I34d3c21bd7f70885a3031ce91a4d4c4ba3564856
2013-10-08 12:43:58 +09:00
a6047aae94
Merge "Set the shortcut frequency correctly."
2013-10-07 10:00:34 +00:00
f3204eebb1
Set the shortcut frequency correctly.
...
14 is the right value.
Bug: 11076722
Change-Id: I95d404b540f7fbe4932d1f8498cde23f1df0314f
2013-10-07 18:55:42 +09:00
cfb018ba6d
Fix bug and Add large test for decaying dictionary.
...
- GC gets failure when the dictionary become empty.
- Useless unigrams are sometimes not removed.
Bug: 10197478
Change-Id: I8d1479c01efba61a81f03bc077da6bcb4797a940
2013-10-07 17:31:01 +09:00
5db7eabafb
Merge "Accept double-space-period after emoji."
2013-10-04 13:05:43 +00:00
8142fd83a6
Accept double-space-period after emoji.
...
This also includes a fix that allows this code to read surrogate
pairs in this processing.
Bug: 11070482
Change-Id: If5ef8d6863938252f09128b7e99ea07ece6e7019
2013-10-04 22:01:36 +09:00
676bb517ed
Merge "Add Ver4DictUpdater."
2013-10-04 09:48:27 +00:00
618158e675
Merge "Refactor BinaryDictIOUtilsTests."
2013-10-04 09:47:35 +00:00
e4e0add9fb
Add Ver4DictUpdater.
...
Change-Id: I986ab26faf535fc4bc98443053f534eced9d048f
2013-10-04 17:33:29 +09:00
966af8b5ba
Merge "Make BinaryDictionaryTests use current time as a seed."
2013-10-04 08:04:05 +00:00
bcb196e3b5
Make BinaryDictionaryTests use current time as a seed.
...
Bug: 10197478
Change-Id: Ib79cd3a81b01b16259df29b36e1df6b8f0affca8
2013-10-04 16:48:22 +09:00
3e5f4b53b0
Merge "Check the elapsed time for decaying."
2013-10-04 07:16:17 +00:00
67c855ea6f
Check the elapsed time for decaying.
...
Bug: 6669677
Change-Id: I0401a4c0908c702ce65abfa5e017dd16cb1296f9
2013-10-04 16:11:11 +09:00
Tadashi G. Takaoka
Keisuke Kuroyanagi
Jean Chalard
Yohei Yukawa
Ken Wakasa
Yuichiro Hanada
Fredrik Roubert