Commit Graph

181 Commits (d1a615e9a2ab2cd18277064091c243b9b7e61d82)

Author SHA1 Message Date
Keisuke Kuroyanagi ba07df7fc1 Periodic wipe of the personalization dict.
Bug: 12216453

Change-Id: Ie59dd19c044e9b1eb9b8bd805366200737ea506a
2014-01-10 16:30:59 +09:00
Keisuke Kuroyanagi c837767819 Make required binary dictionary version use FormatSpec.*
Change-Id: Ifb17d6551bc5071553e32a5640dd166c39374461
2013-12-16 16:50:28 +09:00
Keisuke Kuroyanagi 9642286c01 Make ExpandableBinaryDictionary usable for offdevice tests.
Bug: 11956652
Change-Id: If5a503ef161781818f2efceba542be5a61be6bd1
2013-12-13 14:48:43 +09:00
Keisuke Kuroyanagi 9bd6dac470 Add a constructor for testing to non-main dictionaries.
The new constructor is used for creating dictionary instance
that uses a given file.

Bug: 11956652
Change-Id: Ifbf420a1a768eb95a5c3a58eeb1be5936b306d35
2013-12-12 20:14:06 +09:00
Keisuke Kuroyanagi d06de553b2 Add waitAllTasksForTests for testing.
Bug: 10667710
Change-Id: I7a189e32286a6005393fbde8da736541ca9226a8
2013-12-12 17:08:51 +09:00
Keisuke Kuroyanagi 9ff51527a3 Quit passing header file path to native.
Bug: 12089197
Change-Id: Ia898f8d2836c0c131a1834dc0a396d9121ecb972
2013-12-12 16:48:34 +09:00
Keisuke Kuroyanagi 84cc5a2c76 Create ver4 dictionary files with the dictionary name.
Bug: 12025402

Change-Id: Ia0bb13b2e26aa60a67dff73f3f6a1e276f1bb1dd
2013-12-11 19:30:18 +09:00
Jean Chalard 83c879ad67 Fix typos.
One of these cost me a day and a half searching for a bug :(

Change-Id: I20f0b727f7c02e2754aaaf6a05b74c9cf9e6375e
2013-12-11 12:06:05 +09:00
Jean Chalard c5db41a9d5 [RF4] Actually remove ver4 dicts
And fix a couple bugs.

Bug: 11281748
Change-Id: If07953a4b1ff9eb1165af03fdb332d7e47cd8f32
2013-12-06 17:07:59 +09:00
Jean Chalard a72e8f1ede [RF3] Cleanups
Make the version number a single number on native and java side.
Also, remove the hasValidContents method. It's useless since the
native code already checks this when creating the dictionary (I
wish I had known that when I added it).

Bug: 11281748
Change-Id: I572d37429972b2f280e4bdb748b709e5d0d7737e
2013-12-06 14:53:03 +09:00
Jean Chalard b8481456f2 [RF2] Some refactoring and some cleanup
Bug: 11281748
Change-Id: Iff45fdf6b23f77c08271a169c7d7ca45912c85e8
2013-12-06 13:06:49 +09:00
Keisuke Kuroyanagi a0befc6490 Start passing timestamp for dynamic dictionaries.
Bug: 11073222
Change-Id: I89e1277f734d5959e33d61e7e9e7048084b9007a
2013-12-04 11:57:45 +09:00
Keisuke Kuroyanagi 8bfc8c46ff Add required header attributes for user/contacts dictionary.
Bug: 11973488

Change-Id: I91ef720a24633aec0f4e81cd4f7c49c749805c49
2013-12-03 19:22:17 +09:00
Keisuke Kuroyanagi d1501ea789 Make contacts/user dictionary ver2.
Change-Id: I10c29bd45fd37d765f115333087e1700dd90570b
2013-12-02 21:59:56 +09:00
Keisuke Kuroyanagi cffe4d2d0f Quit recording LastUserHistoryWriteTime.
Change-Id: I0f2b408b4976d8119c932654e23836803d42c568
2013-12-02 18:45:32 +09:00
Keisuke Kuroyanagi 8ac3c65b00 Add version check to open binary dictionary.
Bug: 11073222
Change-Id: Iabae12b8f14a9da3cdc804dcc6af443cedeb3f99
2013-11-28 20:40:26 +09:00
Keisuke Kuroyanagi 3c7b603c46 Merge "Start using Ver4 dictionary format." 2013-11-27 10:02:21 +00:00
Keisuke Kuroyanagi 02fd1a78a3 Start using Ver4 dictionary format.
Bug: 11073222

Change-Id: Idd836ee15501e2f8c57c8eebc1fef7f103b01d18
2013-11-27 12:14:03 +09:00
Keisuke Kuroyanagi ca16be7552 Implement addMultipleDictionaryEntries as a jni method.
Bug: 11757169

Change-Id: Ie1569e0b3c0503588ebfe5d09c7ca06116f54485
2013-11-26 16:03:10 +09:00
Keisuke Kuroyanagi da2ccbd4cd Create a method to add multiple dictionary entries.
Bug: 11740462
Change-Id: I7903cb02fd08d649a05b8799fb3cd00c3da26e00
2013-11-19 18:12:07 +09:00
Keisuke Kuroyanagi 97fdb184bc Purge ExpandableDictionary.
Bug: 11245133
Change-Id: Ia0886686d8add940409dcd5c883c34eb5289380d
2013-11-14 14:18:02 +09:00
Satoshi Kataoka ba212e9d76 Add a facility to dump the dictionary contents while closing
Change-Id: I02e920e0512f2b46a778f0b23f7ca03f8d5dabe6
2013-10-28 11:25:38 -07:00
Jean Chalard f3204eebb1 Set the shortcut frequency correctly.
14 is the right value.

Bug: 11076722
Change-Id: I95d404b540f7fbe4932d1f8498cde23f1df0314f
2013-10-07 18:55:42 +09:00
Keisuke Kuroyanagi 11f7cae094 Fix UserHistoryDictionaryTests.
Bug: 6669677
Bug: 10667710

Change-Id: I6cdc6a6c9cacc7f276fda3a26ec31e3eb928471c
2013-10-03 20:55:34 +09:00
Keisuke Kuroyanagi f36a97ab3a Try decaying user history at hourly intervals.
Bug: 6669677

Change-Id: Ib465fa7e1a7f289a07843535ba89d0dd5259e803
2013-10-02 18:06:08 +09:00
Keisuke Kuroyanagi 03cb8f751a Quit blocking getSuggestion during GC.
Bug: 10831272

Change-Id: I995c619dc18a9120a47f547d31045cb73a9353ec
2013-10-01 12:04:06 +09:00
Keisuke Kuroyanagi c18510049a Prepare dictionary decay.
Bug: 6669677
Change-Id: I8fbae190dd44a6bdbee7e9b6d3a16208322727f7
2013-09-30 13:57:54 +09:00
Keisuke Kuroyanagi 1cf4789ba6 Merge "Set header attributes for ExpandableBinaryDictionary." 2013-09-29 05:14:22 +00:00
Keisuke Kuroyanagi 5ed30a7660 Set header attributes for ExpandableBinaryDictionary.
Bug: 6669677

Change-Id: I2462777eaa07600f1c774226adfc4f351882f523
2013-09-28 12:50:09 +09:00
Keisuke Kuroyanagi e74d4a184b Stop reading dictionary while regenerating.
Bug: 10831272

Change-Id: Iead7268a9371b48d729a5f65074ccbc05f3185db
2013-09-27 21:44:26 +09:00
Yuichiro Hanada a328f538c3 Fix PrioritizedSerialExecutor.
It was possible that fetchNextTasks() would be called by multiple
threads concurrently.
If it happens, some tasks in the task queues might be ignored.

Change-Id: Idc81c43c45e382da3850cc55b9a42c281548d2a8
2013-09-27 16:46:34 +09:00
Yuichiro Hanada 781feb748c Remove unused methods.
Change-Id: I542db0c717c0bc05c8baa08f1e9db0a05946a99b
2013-09-27 12:34:38 +09:00
Keisuke Kuroyanagi 5ef6209656 Create empty dictionary file in native code.
Bug: 6669677
Change-Id: I46d23deee1fd091678f4593561cb8687eb815212
2013-09-26 12:59:02 +09:00
Keisuke Kuroyanagi 2e58670da9 Quit using ExpandableDictionary.
Bug: 6669677
Change-Id: Ie90417fa9b726454fe729a665fcd549efabb9e94
2013-09-24 22:57:15 +09:00
Keisuke Kuroyanagi 40f66795a2 Quit skipping user history dictionary for gesture.
Bug: 6669677
Change-Id: Id4344f2a30e9827f210055d6c65ee7776d3a63e3
2013-09-19 13:12:11 +09:00
Yuichiro Hanada a099a3e341 Add shutdown and isTerminated to PrioritizedSerialExecutor.
Change-Id: Id185224d135c8571a39efe8a41a66ce769142903
2013-09-13 17:46:50 +09:00
Yuichiro Hanada ef073f4024 Use PrioritizedSerialExecutor instead of ReentrantReadWriteLock.
Change-Id: I003b769e408ebd692085a7e17fed6d9396876202
2013-09-10 19:05:41 +09:00
Keisuke Kuroyanagi e531c2241e Move a flag about switching dynamic update to java.
Bug: 6669677

Change-Id: I6aa99cae4a227f9202179c2873d13473a773e024
2013-09-10 18:45:53 +09:00
Satoshi Kataoka be96361156 Merge "Check contents in user history dictionary tests" 2013-09-09 06:46:45 +00:00
Satoshi Kataoka e5a35711b8 Check contents in user history dictionary tests
Bug: 10667710

Change-Id: I45ebb08cb4ef9a9f6d2da31e2c50e740f88209c2
2013-09-09 15:28:50 +09:00
Keisuke Kuroyanagi 37e0fd2ff0 Revise TODO comment for I823912e3979829a.
Change-Id: I839d8cb4d45d7d17b7940d710a2fef5aeacc11ab
2013-09-09 12:26:40 +09:00
Keisuke Kuroyanagi 773f227242 Fix: wrong locking order.
Change-Id: I823912e3979829ad1e825cf91dc5e18f7f0f9cc3
2013-09-09 12:13:21 +09:00
Keisuke Kuroyanagi fe87f5f417 Pass additionalFeaturesOptions for getSuggestions().
This fixes null pointer exceptions that are caused when
getSuggestion() is called from spell checker.

Change-Id: Ifc9e7abb900e1a4646e33c91022effde439673e4
2013-08-28 19:24:28 +09:00
Keisuke Kuroyanagi 6e04d65932 Make DynamicPred...Base extend ExpandableBinaryDictionary.
Bug: 6669677
Change-Id: I06afad35d3eb73510c34d10cd4116f5bcf934f7c
2013-08-26 18:50:22 +09:00
Keisuke Kuroyanagi 87a72f50c2 Introduce DynamicDictionaryWriter for dynamic dictionary.
Bug: 6669677
Change-Id: Ifcbeb88b908f2301ac062b411a95c8b38d24b90e
2013-08-23 22:04:27 +09:00
Keisuke Kuroyanagi c8ac8da4e4 Merge "Prepare ExpandableBinaryDictionary to make it updatable" 2013-08-19 07:20:16 +00:00
Yuichiro Hanada 8aaae56cf6 Fix unit test.
Change-Id: Ib104d5de71c2ab1a07921b407c74c21b0409d9af
2013-08-19 11:10:28 +09:00
Keisuke Kuroyanagi c8db6f21e9 Prepare ExpandableBinaryDictionary to make it updatable
Bug: 6669677

Change-Id: Iaa6100f58de78d104e19c7a3c41d67e7826264f9
2013-08-16 20:16:31 +09:00
Satoshi Kataoka ffcbbaf127 Refactor on UserHistoryDictionary
Bug: 9429906
Change-Id: I576a91643bdaf5017cc826ac2e07a74a9a275d60
2013-07-26 13:00:19 +09:00
Keisuke Kuroynagi cfbb7fbd48 Fix: Read lock is wrongly used for gutSuggestions.
Bug: 9737865

Change-Id: I017f80b46c5dc48c40f2de7c4d516a042992feb4
2013-07-09 08:40:43 +00:00
Keisuke Kuroynagi edd1992ed3 DictionaryWriter to abstract binary dictionary writing.
UserHistoryDictionary should become to use ExpandableBinaryDictionary.

Bug: 6669677

Change-Id: I6831c7dd2d84207d1a8f51ba15d52e0a72205d0c
2013-07-04 21:06:04 +09:00
Keisuke Kuroynagi 0b1c08bf5a Use ReentrantReadWriteLock in ExpandableBinaryDictionary.
Bug: 6669677

Change-Id: I2acde0517d5ed5cbd7b7149709e35fc36651335d
2013-07-03 19:46:08 +09:00
Keisuke Kuroynagi a62b5b22ef Regenerate old version dictionaries using new format.
Bug: 9617181
Change-Id: I228a3eac959f81b38e4092015e8e3c429d46fa60
2013-07-01 15:25:33 +09:00
Keisuke Kuroynagi 981717da4c Add a parameter isUpdatable to the constructor of BinaryDictionary.
Bug: 6669677
Change-Id: I6bc25131afd97112e3bbde036a81ab559a9a6460
2013-06-25 17:39:06 +09:00
Ken Wakasa e28eba5074 Move util classes to the latin/utils directory
Change-Id: I1c5b27c8edf231680edb8d96f63b9d04cfc6a6fa
2013-06-24 17:04:40 +09:00
Jean Chalard 2dbb5957e3 Pass blockOffensiveWords as a parameter
Bug: 8773353
Change-Id: Ic1019742ce7ff6e4f7fff4d2729f8ab52d841488
2013-05-01 20:47:35 +09:00
Jean Chalard 6a2a4b8e4d Make shortcut-only user dict entry non-words.
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
2013-04-12 16:17:09 +09:00
Jean Chalard 1c5b2a41ec Cleanups
Follow-up to Idc6f419a

Change-Id: I4aae8f4e19f27a0a309879dc19af6e40906d58c5
2013-02-11 21:14:56 -08:00
Tadashi G. Takaoka 8aa9963a89 Fix Apache license comment
Change-Id: Ic56167f952a7f4449da366e1e81610e72c966086
2013-01-21 22:23:37 +09:00
Ken Wakasa f6870cc82d Remove BinaryDictionary.MAX_PREDICTION and MAX_SPACES, and rename MAX_WORDS to MAX_RESULTS
Change-Id: Iab2a422b367e7521f346481c7fe5e2575f2e9de3
2013-01-11 20:47:42 +09:00
Ken Wakasa 96b22200be Privatize a few constants in BinaryDictionary.java
Change-Id: I7defaf1f577fd67e678cac83ff935e8181dd0a48
2012-12-17 17:46:57 +09:00
Tadashi G. Takaoka bc464e2952 Replace useless CharSequence to String
Change-Id: Idc478f901185ee1b4912acc82d0cbc54fee4e991
2012-10-22 11:03:28 -07:00
Yuichiro Hanada 1a347723c5 Move FormatOptions and FileHeader to FormatSpec.
Change-Id: I232e35598635113bf2c81825669c744aadc79efe
2012-09-13 16:35:41 +09:00
Yuichiro Hanada 83dfe0fd8c Add FormatOptions.
Change-Id: Ibad05a5f9143de1156b2c897593ec89b0a0b07e7
2012-09-05 18:05:43 +09:00
Jean Chalard 72b1c93941 Reinstate the shortcut-only attribute
Also add the blacklist attribute

Bug: 7005742
Bug: 2704000
Change-Id: Icbe60bdf25bfb098d9e3f20870be30d6aef07c9d
2012-08-31 22:11:52 +09:00
Tadashi G. Takaoka 5f282ea9e4 Add CollectionUtils class to create generic collection easily
Change-Id: I6b4de9187e122298e5e9cd8ddc9070d062df6a89
2012-08-22 10:21:38 +09:00
Jean Chalard f5943153ad Cleanup old methods (A90)
Change-Id: I5435cef8ac6be523934ffa394952cb120c8e89d6
2012-07-10 19:30:46 +09:00
Jean Chalard b30d2185f2 Implement the common Dictionary interface (A89)
This will de-duplicate a lot of existing code.

Change-Id: Idaffb2fde23b9741f057bcb2ecb3dde9d12ea5c5
2012-07-10 19:30:42 +09:00
Jean Chalard a69f12a246 Reduce method visibility (A88)
Change-Id: I29d6afbcba0998558c9b19287a460d9f0e410994
2012-07-10 19:19:47 +09:00
Jean Chalard 05efe576f9 Cleanup the dictionary type.
Stop storing an int in each of the different class types, and
just store a string in the top class.

Change-Id: I2af1832743e6fe78e5c1364f6d9cc21252bf5831
2012-06-27 17:31:09 +09:00
Jean Chalard 2f1b6c9ea4 Remove the callback argument to getBigrams() (A16)
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I7457ac04f8cd4019fb86c986725aae3de1b1a65e
2012-06-26 17:54:49 +09:00
Jean Chalard 60eed92dc3 Remove the callback argument to getWords() (A15)
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I919bf70a1213ab5d7c7a9e5715bd72a6e257148b
2012-06-26 17:36:47 +09:00
Jean Chalard d82898c5a9 Change the return type of getWords and getBigrams (A8)
This only returns stuff, but it doesn't change yet how the data
is really passed. It merely adds a way of getting the same data.
Later, the old way will be removed.

Change-Id: If3a064de362175fc5a6781b7a97b65d8730aaf3c
2012-06-26 16:44:26 +09:00
Satoshi Kataoka 7368009799 Change JNI for Gesture
Change-Id: I774a0052038d16677f60f7efa11fd266cb5f3088
2012-06-25 18:54:37 +09:00
Tom Ouyang 1ed017ef0e Fix performance issue when there are no contacts in the dictionary dictionary.
Bug: 6551480
Change-Id: I8681a1bd82423c612af2d012f9b872501d8c201d
2012-05-29 09:45:42 -07:00
Tom Ouyang f6adff6227 Change to a binary version of the expandable user dictionary.
Bug: 6435677
Change-Id: If83409f699608d443796e64a3c65692ae81b98e6
2012-05-17 15:12:00 -07:00
Tom Ouyang 4d289d39ae Contacts dictionary rebuilds only when contact names have changed.
Bug: 6396600
Change-Id: Iad693ec4bab6351793d624e5c5b0a9f5c12a60e3
2012-05-11 18:43:53 -07:00
Jean Chalard 44c64f46a1 Ignore bigrams that are not also listed as unigrams
This is a cherry pick of I14b67e51 on jb-dev

Bug: 6340915
Change-Id: Iaa512abe1b19ca640ea201f9761fd7f1416270ed
2012-04-26 15:20:30 +09:00
Tom Ouyang a9b2be8a81 Change expandable binary dict write to a temp file first.
Bug: 6380724
Change-Id: Ic1d0d902dc45ecb41a1792f33a60ab85e606fcef
2012-04-24 10:52:53 -07:00
Jean Chalard ac27e4544b Pass the previous word to getSuggestions
This is a preparative change to bug#6313806

Change-Id: I1be9ec49b21005c1f45ce459fa93712bc74ef3f0
2012-04-17 12:43:53 +09:00
Tom Ouyang ecd2ac93bc Add an expandable binary dictionary that can be modified at runtime and works with native algorithms.
Bug: 6188977
Change-Id: Iec5c4e7d1d3918ac645187bd32dc3f82a95fec1e
2012-04-10 10:17:52 -07:00