Jean Chalard
5ef447aeea
Straighten the dead char implementation.
...
This now supports all cases, including cases not supported by
the framework.
Now rebased on top of the right change, and renamed
Change-Id: I7886f0dcbb86cdb4dccec09aa7c52ad339680e04
2014-08-27 17:59:39 +09:00
Yohei Yukawa
97681ebdf1
Set highlight color along with the commit indicator
...
With this CL, the text highlight color is applied
when the commit indicator is displayed.
Note that the underline is not rendered when the
background color is enabled. This is a known issue.
Change-Id: Ia19355e1303e3a10e8a7d69bc47c779feb70248a
2014-08-27 01:41:16 -07:00
Yohei Yukawa
29200b0abe
Set the text bgcolor only when CursorAnchorInfo is available
...
When CursorAnchorInfo is unavailable, we shouldn't try to show
the commit indicator and set the text highlight color.
With this CL, RichInputConnection can be used to track if the
application responded that it does support CursorAnchorInfo or
not. This result will be taken into consideration when
InputLogic needs to determine whether the commit indicator
should be displayed or not.
Change-Id: I945d70eeb02a7a5f3d9b22459b23d7028508910f
2014-08-27 01:30:45 -07:00
Yohei Yukawa
00d140caeb
am a475c854
: Introduce a mechanism to hide the indicator speculatively
...
* commit 'a475c85480b2bc2a8d036b4b1ea29f6a8e749ac5':
Introduce a mechanism to hide the indicator speculatively
2014-08-27 07:31:42 +00:00
Yohei Yukawa
a475c85480
Introduce a mechanism to hide the indicator speculatively
...
This is an optional optimization to reduce the UI latency.
Imagine that the commit indicator is now displayed and the
composing text is being updated, it is highly likely that
the commit indicator will disappear unless the application
rejects the setComposingText request.
If we assume that the application will accept the new
composing text without any modifications, we can hide the
indicator without waiting for the arrival of new
CursorAnchorInfo event.
This optimization isn't dangerous because we can show the
indicator again when we receive new CursorAnchorInfo event
and the assumption is turned out to be invalid.
Change-Id: Id59c6607a1029782410611e768791af9984f14ac
2014-08-26 23:42:53 -07:00
Keisuke Kuroyanagi
7d8dad7ab0
am b7bedccb
: Merge "Add TimeKeeperTest."
...
* commit 'b7bedccb295b43f486ec60d029d7e6219d9c5a8b':
Add TimeKeeperTest.
2014-08-27 06:20:09 +00:00
Keisuke Kuroyanagi
b7bedccb29
Merge "Add TimeKeeperTest."
2014-08-27 06:13:47 +00:00
Keisuke Kuroyanagi
78aea9f133
Add TimeKeeperTest.
...
Change-Id: Id35823414f8552fd6820a5a559d6c9d54c7d6cb6
2014-08-27 14:39:27 +09:00
Yohei Yukawa
0268f7368f
am bea17c49
: Introduce commit/add-to-dictionary indicators
...
* commit 'bea17c49ec23bf0f646cb548445c7756aa50d233':
Introduce commit/add-to-dictionary indicators
2014-08-27 05:01:40 +00:00
Yohei Yukawa
bea17c49ec
Introduce commit/add-to-dictionary indicators
...
This CL introduces commit/add-to-dictionary indicators.
Note that the text is not yet highlighted when the commit
indicator is displayed. It will be addressed in subsequent
CLs.
Change-Id: I7e9b0fcfdc0776a50a1d8cfb41ee0add813317dd
2014-08-26 21:20:27 -07:00
Ken Wakasa
090b72a11a
am 4660ecaa
: Merge "Fix a bug where mic/emoji key wouldn\'t work."
...
* commit '4660ecaa44d4ca141ba53552d9533ea60d3e8323':
Fix a bug where mic/emoji key wouldn't work.
2014-08-26 13:35:45 +00:00
Ken Wakasa
4660ecaa44
Merge "Fix a bug where mic/emoji key wouldn't work."
2014-08-26 13:30:15 +00:00
Jean Chalard
e38043849e
Fix a bug where mic/emoji key wouldn't work.
...
Bug: 17272902
Bug: 17269948
Change-Id: I561609fa84a6265f8148db7d2411bc1fd38dd163
2014-08-26 22:06:21 +09:00
Jean Chalard
ebf4a3e792
am 96522da9
: am 2a2d324e
: am 8380f921
: Fix a bug where the top prediction would disappear.
...
* commit '96522da9eb584c173083af677f47cdbc35d81436':
Fix a bug where the top prediction would disappear.
2014-08-26 12:47:04 +00:00
Jean Chalard
96522da9eb
am 2a2d324e
: am 8380f921
: Fix a bug where the top prediction would disappear.
...
* commit '2a2d324eb627807a9d09b491fbb4ac78ffb253fc':
Fix a bug where the top prediction would disappear.
2014-08-26 12:37:17 +00:00
Jean Chalard
2a2d324eb6
am 8380f921
: Fix a bug where the top prediction would disappear.
...
* commit '8380f921f7edaeea2033a1e967a14941400fe246':
Fix a bug where the top prediction would disappear.
2014-08-26 12:25:59 +00:00
Jean Chalard
8380f921f7
Fix a bug where the top prediction would disappear.
...
This is because prediction can't be easily distinguished in
style. This fixes the bug by simulating the right members,
but some refactoring should be done to remove useless
booleans.
Bug: 17271923
Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
2014-08-26 20:35:59 +09:00
David Faden
e4fb843a7f
am 9cf69a45
: Adds documentation for a few methods.
...
* commit '9cf69a45b24646bdd4bf365afe4e8e9fb30f9a22':
Adds documentation for a few methods.
2014-08-26 11:15:07 +00:00
David Faden
9cf69a45b2
Adds documentation for a few methods.
...
Change-Id: I6bdae25a8b81cdac931f2591f33570b01e34fb2c
2014-08-26 08:08:24 +00:00
Keisuke Kuroyanagi
7d47500357
Use word id to construct DicNode instead of isTerminal flag.
...
Bug: 14425059
Change-Id: I8484d34756bd76668ece34211e7366a4758d7bf5
2014-08-26 14:33:19 +09:00
Keisuke Kuroyanagi
8b4409f4b9
Use LanguageModelDictContent in getWordProperty().
...
Bug: 14425059
Change-Id: Ic230f764ff5570f24ce6ce930023798718f326df
2014-08-26 12:05:02 +09:00
Keisuke Kuroyanagi
1c14effab5
Use LanguageModelDictContent in iterateNgramEntries().
...
Bug: 14425059
Change-Id: I8a5028657ea5a4eeee8ef40db52a80f09b878972
2014-08-26 12:03:14 +09:00
Keisuke Kuroyanagi
07b3b41c25
Add a method to iterate entries in LanguageModelDictContent.
...
Bug: 14425059
Change-Id: I4e9c3a97891c020f762fa709f806d333c067f496
2014-08-26 12:01:08 +09:00
Keisuke Kuroyanagi
16bb2c5a4e
am 4793e913
: Merge "Add SparseTableTest."
...
* commit '4793e91317f8fe00627405d87f007acb92c39d54':
Add SparseTableTest.
2014-08-26 02:31:51 +00:00
Keisuke Kuroyanagi
4793e91317
Merge "Add SparseTableTest."
2014-08-26 02:23:51 +00:00
Keisuke Kuroyanagi
30e6b21af0
Add SparseTableTest.
...
Change-Id: I5684a24f9584cd326e014274c2298773aa3a91ca
2014-08-25 22:27:01 +09:00
Keisuke Kuroyanagi
893c1aab3e
am bf6fc495
: Merge "Get dynamic dict stats via DictionaryFacilitator"
...
* commit 'bf6fc4953b6529274f94ecfef967faece8a0003d':
Get dynamic dict stats via DictionaryFacilitator
2014-08-25 11:32:57 +00:00
Keisuke Kuroyanagi
bf6fc4953b
Merge "Get dynamic dict stats via DictionaryFacilitator"
2014-08-25 11:24:54 +00:00
Yohei Yukawa
029833d30e
am d8dfac6d
: am abf05cc0
: am fdfe73ff
: Merge "Use more descriptive names for some internal fields" into lmp-dev
...
* commit 'd8dfac6dcb16f01bb20c7e1ed669b981835a2e1f':
Use more descriptive names for some internal fields
2014-08-25 10:24:32 +00:00
Yohei Yukawa
d8dfac6dcb
am abf05cc0
: am fdfe73ff
: Merge "Use more descriptive names for some internal fields" into lmp-dev
...
* commit 'abf05cc0da1ead7e270a7c99bf9f000dabf91f5b':
Use more descriptive names for some internal fields
2014-08-25 10:16:11 +00:00
Yohei Yukawa
abf05cc0da
am fdfe73ff
: Merge "Use more descriptive names for some internal fields" into lmp-dev
...
* commit 'fdfe73ff1f4b8c9d7d8728baa322d70c3a74df99':
Use more descriptive names for some internal fields
2014-08-25 10:07:25 +00:00
Jean Chalard
ec84eef165
am 1a31d784
: Merge "Introduce onEvent() to improve testability"
...
* commit '1a31d784cdf6c651d1ee6001dcbd3660d93b4945':
Introduce onEvent() to improve testability
2014-08-25 10:06:55 +00:00
Jean Chalard
1a31d784cd
Merge "Introduce onEvent() to improve testability"
2014-08-25 09:57:42 +00:00
Yohei Yukawa
fdfe73ff1f
Merge "Use more descriptive names for some internal fields" into lmp-dev
2014-08-25 09:50:59 +00:00
Tadashi G. Takaoka
54ca9dd998
am d147db87
: am c500700f
: am 19dd34a0
: Show view even when IME is explicitly shown with physical keyboard
...
* commit 'd147db876365066e8989764807f532c0865349e3':
Show view even when IME is explicitly shown with physical keyboard
2014-08-25 09:43:38 +00:00
Tadashi G. Takaoka
d147db8763
am c500700f
: am 19dd34a0
: Show view even when IME is explicitly shown with physical keyboard
...
* commit 'c500700faec11b7a6d54a821009be4d657c43394':
Show view even when IME is explicitly shown with physical keyboard
2014-08-25 09:35:08 +00:00
Jean Chalard
781d75126b
am ee8ebeec
: Merge "Fix unit tests"
...
* commit 'ee8ebeecbf80b9cccc5569570112634b49c45b53':
Fix unit tests
2014-08-25 09:34:30 +00:00
Yohei Yukawa
a61b7245b0
Use more descriptive names for some internal fields
...
This CL clarifies that delay parameters are specified with
milliseconds.
Change-Id: I401a60b8c09c2a04201af5b74babcdb091c07f4a
2014-08-25 02:28:01 -07:00
Jean Chalard
ee8ebeecbf
Merge "Fix unit tests"
2014-08-25 09:26:17 +00:00
Tadashi G. Takaoka
c500700fae
am 19dd34a0
: Show view even when IME is explicitly shown with physical keyboard
...
* commit '19dd34a02320b7a368c4ad65398248ceca41b69e':
Show view even when IME is explicitly shown with physical keyboard
2014-08-25 09:26:15 +00:00
Jean Chalard
dc110b2a6a
Fix unit tests
...
Change-Id: I48bfa4e4dd80f36d2fe0a1e9d2a2706533cc722e
2014-08-25 18:19:00 +09:00
Keisuke Kuroyanagi
5ce1a5eb48
am e5e7a91b
: Merge "Add ByteArrayUtilsTest."
...
* commit 'e5e7a91b490eb1214ee19031cada5f9754b45933':
Add ByteArrayUtilsTest.
2014-08-25 09:10:41 +00:00
Tadashi G. Takaoka
ca9e970c7c
am 7defe926
: am 4a782da3
: am f145fff0
: Merge "Fix NPE when pressing ALT key" into lmp-dev
...
* commit '7defe926ca0eed2a18665cd0e4bf2ec305a03879':
Fix NPE when pressing ALT key
2014-08-25 09:10:40 +00:00
Yohei Yukawa
8787d7f154
am 4587b135
: am 2d508203
: am 8681287c
: Fix build due to an illegal character
...
* commit '4587b135be7f184bdf60f8e4113e81070ce2d825':
Fix build due to an illegal character
2014-08-25 09:10:38 +00:00
Yohei Yukawa
34439d70e2
am 8c7daa82
: am 02716083
: am 5eebaddc
: Merge "Dismiss "Add to dictionary" hint with non-special char event" into lmp-dev
...
* commit '8c7daa829a3a81b3a803048d7af82383a8b48aed':
Dismiss "Add to dictionary" hint with non-special char event
2014-08-25 09:10:37 +00:00
Yohei Yukawa
aa19b7d304
am a5687ee9
: am b65a1e46
: am 2c4cce8d
: Merge "Introduce #shouldShowAddToDictionaryHint" into lmp-dev
...
* commit 'a5687ee9f7c3eff7eb8b97ebfb12fc1d93b9e41c':
Introduce #shouldShowAddToDictionaryHint
2014-08-25 09:10:35 +00:00
Tadashi G. Takaoka
4cc44f9f62
am ef7c701e
: am 129af927
: am 5e7a6fe0
: Merge "Fix the bottom row of tablet keyboard layout" into lmp-dev
...
* commit 'ef7c701e72d9ccc735ce77829cb55cf46ed25339':
Fix the bottom row of tablet keyboard layout
2014-08-25 09:10:34 +00:00
Yohei Yukawa
9a0b9aba64
am f6f55add
: am e0d00803
: am 4a71d2c4
: Allow to add/remove background color to/from the committed text
...
* commit 'f6f55add175bcd37710764afd05052974167bd1d':
Allow to add/remove background color to/from the committed text
2014-08-25 09:10:32 +00:00
Yohei Yukawa
3d057b402d
am c06c6e42
: am 7d146cdb
: am cd6ef9a8
: Indroduce SuggestedWords#getTypedWordInfoOrNull
...
* commit 'c06c6e42ad24e02a5433dcb44dba452d1cfb3f4f':
Indroduce SuggestedWords#getTypedWordInfoOrNull
2014-08-25 09:10:31 +00:00
Keisuke Kuroyanagi
e5e7a91b49
Merge "Add ByteArrayUtilsTest."
2014-08-25 09:06:08 +00:00