nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
14110 commits 1 branch 0 tags 363 MiB
Commit graph

4915 commits

Author SHA1 Message Date
Jean Chalard
a024ac6b20 Merge "Fix an NPE" 2013-04-16 03:43:06 +00:00
Jean Chalard
2b42ad0eaa Fix an NPE 
Bug: 8620678
Change-Id: Ia91761f33518a010b2844d34523cadece261c67e
 2013-04-16 12:20:10 +09:00
Jean Chalard
7be3ca2ccf Fix an NPE 
Bug: 8620758
Change-Id: I39f07939ebb6148a48aae5b915ee807002a5b02d
 2013-04-16 12:17:22 +09:00
Jean Chalard
5fca38c538 Merge "Small performance improvement / minor bugfix" 2013-04-15 14:28:16 +00:00
Jean Chalard
b76ce1251e Merge "Remove a useless function" 2013-04-15 13:06:33 +00:00
Jean Chalard
bc501647fd Remove a useless function 
Bug: 8583091
Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
 2013-04-15 22:01:37 +09:00
Jean Chalard
1e5bbe4ce8 Small performance improvement / minor bugfix 
The only place where it's used is checked for nullity.
Also, it's possible, also difficult, to match a different
recapitalize with the old code, triggering a bug that
this fixes.

Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
 2013-04-15 21:18:50 +09:00
Jean Chalard
a5a2f3e3c7 Remove gesture suggestions with an INT_MIN score 
Bug: 7980115
Change-Id: I8de31068992aec712eaad132857d9dc61f28e30a
 2013-04-15 20:55:49 +09:00
Jean Chalard
033958330d Merge "Have Latin IME re-capitalize a selected string" 2013-04-15 11:29:28 +00:00
Jean Chalard
2995abe7aa Have Latin IME re-capitalize a selected string 
Upon pressing Shift, if there is currently a selected string, have
Latin IME change its capitalization.
This does not yet have the keyboard mode follow the mode - the change
is complicated enough as is.

Bug: 7657025
Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
 2013-04-15 20:23:01 +09:00
Jean Chalard
0e9ee4d3bf If there are no suggestion span, recompute suggestions. 
Bug: 8084810
Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
 2013-04-15 19:33:23 +09:00
Jean Chalard
059e084e98 Merge "Reject a previously user-refused suggestion." 2013-04-15 07:45:34 +00:00
Jean Chalard
d40f3f6bc1 Reject a previously user-refused suggestion. 
If the user gestures a word, then hits backspace in
disapproval, and gestures about the same thing again,
make sure that we don't suggest the same thing again.

Bug: 7549311
Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
 2013-04-15 16:36:44 +09:00
Tadashi G. Takaoka
216fb6a042 Remove unnecessary harmful finish() from SettingsActivity 
Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3
 2013-04-15 16:26:40 +09:00
Tadashi G. Takaoka
1ec4c07a13 Merge "Ignore modifier key while sliding key input" 2013-04-15 06:19:10 +00:00
Tadashi G. Takaoka
f224941c37 Merge "Suppress calling onPressKey and onReleaseKey while detecting gesture" 2013-04-15 06:18:48 +00:00
Tadashi G. Takaoka
29105a725d Add preference dependency to gesture input related options 
Bug: 8613600
Change-Id: I279d3264080aede59203205c45763c7f8ff08ae6
 2013-04-15 15:07:49 +09:00
Tadashi G. Takaoka
8dfbb740e1 Ignore modifier key while sliding key input 
Bug: 8284624
Change-Id: I839d7a769d98f29be647dbe511ba3f73ca44446d
 2013-04-15 14:39:02 +09:00
Tadashi G. Takaoka
e2af9b7eb5 Merge "Reset vertical correction when more suggestions are in modal mode" 2013-04-15 04:57:33 +00:00
Tadashi G. Takaoka
51c38a441a Reset vertical correction when more suggestions are in modal mode 
Bug: 8605150
Change-Id: Iadbebfb80e765c97e58e8524eb87419f2a9e41d4
 2013-04-15 13:56:03 +09:00
Jean Chalard
03d1dff38d Merge "Fix Binary dict tests" 2013-04-15 03:53:54 +00:00
Jean Chalard
c2e9c511cb Fix Binary dict tests 
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.

The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.

All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.

Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
 2013-04-15 12:48:16 +09:00
Tadashi G. Takaoka
a91da76683 Suppress calling onPressKey and onReleaseKey while detecting gesture 
Bug: 8284624
Change-Id: I14470bb2373965aefa921b2c94948450bfa438e3
 2013-04-15 10:59:54 +09:00
Kurt Partridge
ededdc6a8b Merge "Avoid NPE" 2013-04-12 18:10:49 +00:00
Jean Chalard
2cd1136b8e Merge "Remove the dialog to insert words to the dictionary." 2013-04-12 12:33:24 +00:00
Jean Chalard
91bcf5eb5d Merge "Restart suggestions when the cursor moves." 2013-04-12 12:27:50 +00:00
Jean Chalard
02ce3dc2d1 Fix a bug with bad application completions 
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
 2013-04-12 20:53:06 +09:00
Jean Chalard
6a114fa700 Restart suggestions when the cursor moves. 
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.

Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
 2013-04-12 20:49:03 +09:00
Jean Chalard
d24f939712 Merge "Make shortcut-only user dict entry non-words." 2013-04-12 11:02:00 +00:00
Jean Chalard
fb5869e9ff Merge "Add a class to encapsulate getting the metadata URI" 2013-04-12 11:01:36 +00:00
Jean Chalard
6a2a4b8e4d Make shortcut-only user dict entry non-words. 
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
 2013-04-12 16:17:09 +09:00
Jean Chalard
1a51833828 Remove the dialog to insert words to the dictionary. 
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
 2013-04-12 15:58:50 +09:00
Kurt Partridge
2927223edd Merge "Better isolate ResearchLogging data" 2013-04-11 21:56:01 +00:00
Jean Chalard
8987cccf89 Add a class to encapsulate getting the metadata URI 
Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
 2013-04-11 17:52:16 +09:00
Jean Chalard
b5d5190deb Merge "Add some utility functions." 2013-04-11 07:35:22 +00:00
Jean Chalard
1cbb0b8f2a Add some utility functions. 
Bug: 7657025
Change-Id: I4889721b5348c77ed56c5157557e9988dea48a02
 2013-04-11 16:16:19 +09:00
Tadashi G. Takaoka
bd8e92d843 Add debug message to detect unusual zero width condition 
Bug: 8452013
Change-Id: I0169dc6b0d08d1b4d9e01a5fa2ad01e9db292bda
 2013-04-11 15:08:36 +09:00
Tadashi G. Takaoka
f67a388197 Merge "Add TypefaceUtils" 2013-04-11 05:32:58 +00:00
Tadashi G. Takaoka
08ae0d5ca0 Add TypefaceUtils 
Change-Id: I2d939bc1e3279253902b28ff12bbf7861716b64d
 2013-04-11 14:27:42 +09:00
Tadashi G. Takaoka
6d0027a46a Merge "Use SparseIntArray instead of TreeMap<Integer, Integer>" 2013-04-11 05:06:35 +00:00
Tadashi G. Takaoka
cee512b63e Merge "More precise geometry checking for more keys keyboard" 2013-04-11 03:51:42 +00:00
Jean Chalard
3722f0877e Merge "Fix two bugs in dicttool" 2013-04-11 03:07:30 +00:00
Tadashi G. Takaoka
a4463d7a9a More precise geometry checking for more keys keyboard 
Bug: 8484528
Change-Id: I0dd09530a5262fee9c19bb0f11d5830b00306944
 2013-04-11 10:44:54 +09:00
Kurt Partridge
cdaee868a3 Merge "Preserve a class for testing" 2013-04-10 23:45:33 +00:00
Kurt Partridge
3684036eed Preserve a class for testing 
Addresses b/8583091

Change-Id: I89605223784312d9572dfc7c8aaa7e5eba44c4f6
 2013-04-10 16:40:17 -07:00
Kurt Partridge
6108624a00 Better isolate ResearchLogging data 
Calls to LatinIME#onStartInputViewInternal log important information
about the context in which an IME is used.  This is reported as a
single LogStatement.  Previously, this was not placed into a separate
LogUnit, and was mixed in with general word data.  This change wraps
this LogStatement in its own LogUnit.

Change-Id: I0fecd41c8a1de622a764cc4b5d6902336697046c
 2013-04-10 11:53:38 -07:00
Kurt Partridge
dfa5628cd3 Better release build reporting 
The ResearchLogger reports whether a build is a release build or not
to avoid polluting data with IME debugging work by developers.
Previously this was done by checking a constant flag, which was also
serving the dual purpose of masking out debug code in release builds.

This change introduces a heuristic to determine whether a build was
created by a developer (using the package versionName), and annotating
the data sent to the server appropriately.

Change-Id: Icbad17c66b703cabf6d23d05e2c7c41bcceaae45
 2013-04-10 11:52:37 -07:00
Jean Chalard
ca0fdbbe2e Fix two bugs in dicttool 
Both bugs only affect debug mode. One has the wrong object tested
with equals, the other has the iteration failing in some cases.

Change-Id: Ie9100d257a3f9e3be340cf3e38116f63417bdc1a
 2013-04-10 22:10:31 +09:00
Jean Chalard
fb3e805722 Merge "Fix a bug where a space would not be inserted before a gesture" 2013-04-10 11:19:31 +00:00
Jean Chalard
30b8004b56 Fix a bug where a space would not be inserted before a gesture 
Bug: 8583675
Change-Id: I14924fef5663f48481994c02c56be45f9f85be65
 2013-04-10 20:10:28 +09:00
Tadashi G. Takaoka
c7d4158979 Merge "Use private object as a lock instead of synchronized method" 2013-04-10 09:56:27 +00:00
Tadashi G. Takaoka
12e77de212 Merge "Use private lock object instead of synchronized method" 2013-04-10 09:35:12 +00:00
Tadashi G. Takaoka
1e256f5888 Merge "Protect simultaneously modifying gesture preview data" 2013-04-10 09:34:59 +00:00
Tadashi G. Takaoka
951ea3c06d Use private object as a lock instead of synchronized method 
Change-Id: I0b9a935d8c97ddfb18ab7950a9d6bf542863072a
 2013-04-10 18:34:01 +09:00
Tadashi G. Takaoka
ce811f50d2 Use private lock object instead of synchronized method 
Change-Id: Ifc62bacbd0583a7d102009681a94bdd9ccff7d47
 2013-04-10 18:27:11 +09:00
Tadashi G. Takaoka
ad205b2e3f Protect simultaneously modifying gesture preview data 
Bug: 8556775
Change-Id: I83272e3adbfc0c9cc14f9e8b479e926aabf4fa2a
 2013-04-10 18:18:54 +09:00
Jean Chalard
99b93d17d5 Fix a bug where autocorrection status would be wrong. 
Change-Id: Ic220129dc59f585164dbf63591cd1c96de17fe6f
 2013-04-10 17:49:19 +09:00
Tadashi G. Takaoka
262d5bd9f9 Don't override EXTRA_SHOW_FRAGMENT if exists 
Bug: 8541190
Change-Id: I37d3de12558efd55f157389d2e0b51fc83dc5da1
 2013-04-10 16:24:17 +09:00
Tadashi G. Takaoka
10af4b6e45 Merge "Separate StringUtils.capitalizeFirstCharacter" 2013-04-10 06:30:33 +00:00
Tadashi G. Takaoka
d20c5a78e2 Separate StringUtils.capitalizeFirstCharacter 
Bug: 8582061
Change-Id: Iac8f65defdd92d7df533bdf0e2937ad897d96363
 2013-04-10 14:55:23 +09:00
Keisuke Kuroynagi
87fdde6ec4 Typing double letters via a 'circle' on the key. 
Bug: 8550980
Change-Id: I5e432dea0e025ccea196f80e90a6bf945488e130
 2013-04-10 12:43:13 +09:00
Tadashi G. Takaoka
f606fd8554 Hide Setup Wizard icon for stock keyboard 
Bug: 8581647
Change-Id: Id530f1a33a5c919f4a732ec0d545dfbe76e56316
 2013-04-10 12:24:40 +09:00
Tadashi G. Takaoka
869ea1e555 Use SparseIntArray instead of TreeMap<Integer, Integer> 
Change-Id: I56a64228a5fd85d440d0d08ac67cba8bf2e5690d
 2013-04-10 10:15:26 +09:00
Tadashi G. Takaoka
4fdfce6dcc Merge "Refactor SpellCheckerProximityInfo as extending ProximityInfo" 2013-04-10 01:06:36 +00:00
Kurt Partridge
09ab6495a2 Merge "[FileEncap18] Clean up uploading scheduling" 2013-04-09 19:08:40 +00:00
Jean Chalard
19dcd15493 Merge "Offer to add any OOV typed word to the dictionary." 2013-04-09 10:28:47 +00:00
Jean Chalard
ddafcf82dc Merge "Fix bugs and add tests" 2013-04-09 08:35:28 +00:00
Jean Chalard
9310f42a36 Offer to add any OOV typed word to the dictionary. 
That includes gestures, which used not to work.

Bug: 8532637
Change-Id: I04606565d7000faadf954c4a806c39d4d162a2c1
 2013-04-09 12:05:54 +09:00
Kurt Partridge
1f70a4d681 Merge "Allow logging while replaying" 2013-04-09 02:33:09 +00:00
Kurt Partridge
d117c1a116 Merge "Do not record log split time when handling separator" 2013-04-09 02:31:48 +00:00
Ken Wakasa
d17c8bd929 Update comments 
Change-Id: I6aef328ec9041666cc168c8323bed04d39591b71
 2013-04-08 23:05:45 +09:00
Jean Chalard
c87449497c Fix bugs and add tests 
Change-Id: I6b56b91ace57f4a49584b5dceb71b145859f839e
 2013-04-05 12:11:19 +09:00
Jean Chalard
7d3836d63a Move a generic string utility to StringUtils 
Change-Id: I9cc2e9a7ac0b3346af40bcb083f939333336cf09
 2013-04-05 12:09:14 +09:00
Tadashi G. Takaoka
6e3f307266 Refactor SpellCheckerProximityInfo as extending ProximityInfo 
Change-Id: I544eec9d661796d57749dbaa2163bc1e2a891353
 2013-04-02 19:06:32 +09:00
Jean Chalard
ecb59eff90 Revert "[DO NOT MERGE] Activate hardware keyboard handling" 
This reverts commit c741f1f83b
DO NOT MERGE is ignored and this is merged anyway :(

Change-Id: Ie044cdfc6021933379ec97ad7346c5c8591f70bf
 2013-04-02 16:08:48 +09:00
Jean Chalard
c741f1f83b [DO NOT MERGE] Activate hardware keyboard handling 
Change-Id: Ifdec9338a454291621b2b87c899f5d4301480b27
 2013-04-02 15:38:13 +09:00
Kurt Partridge
30772c3758 Allow logging while replaying 
Previously logging was disabled during replay.  This makes it impossible to use logged data as a
regression test, since the new log was unavailable.  This change corrects this problem.

Change-Id: I19dc31def2f2f87fd219dc561c739d18e4ab9c9c
 2013-04-01 16:49:39 -07:00
Kurt Partridge
636b8c4231 Do not record log split time when handling separator 
Previously handleSeparator() caused the ResearchLogger to mark the time at which a LogUnit should be
broken.  However, this causes the motion data associated with a separator to be associated with the
LogUnit of the previous word.  This change corrects this bug.

Change-Id: I8b4d4fa6de2a013de9e2a28bb668c446a07f1957
 2013-04-01 16:48:15 -07:00
Kurt Partridge
5779bc91e6 Merge "Split LogUnits differently." 2013-04-01 23:08:21 +00:00
Kurt Partridge
0c0ab2b4d9 Merge "Reorder ResearchLogger call" 2013-04-01 15:19:45 +00:00
Jean Chalard
0745fe83d4 am b8869ec1: am 0fcc4960: Deactivate hardware keyboard handling. 
* commit 'b8869ec1e39c1751825841e790d21fc854dca9ce':
  Deactivate hardware keyboard handling.
 2013-04-01 05:42:42 -07:00
Jean Chalard
0fcc4960bc Deactivate hardware keyboard handling. 
Bug: 8000119

Change-Id: I021481343d6d87efd8ff6110e9aa0906a1a3d11d
 2013-04-01 21:35:45 +09:00
Tadashi G. Takaoka
75028af28c Interpolate gesture preview trails 
There is the boolean flag to kill interpolation.

Bug: 7167303
Change-Id: Iac7e4cb88cf437c2ee77c003c9cddb92416025c7
 2013-04-01 19:15:36 +09:00
Jean Chalard
43341ba042 Merge "Ask the client to make itself known when it's not" 2013-04-01 09:00:25 +00:00
Jean Chalard
76d5f512f9 Ask the client to make itself known when it's not 
Upon invoking the settings of the dictionary pack with an unknown
client, we now launch an intent to ask the client to make itself known.
This change also includes the code that receives this intent and
acts upon it.

Bug: 8492879
Change-Id: I2c6496dea845646961ecafcf64e282cb93ee91dc
 2013-04-01 17:37:22 +09:00
Jean Chalard
065f126f1d Merge "Fix two nasty bugs with surrogate pairs." 2013-04-01 08:28:08 +00:00
Jean Chalard
a411595b16 Fix two nasty bugs with surrogate pairs. 
The important bug is in findWordInTree. The problem, which is
not obvious, is that we were calling codePointAt() with the
code point index in the string, instead of the char index.
The other bug this change fixes was harmless in the practice,
because it's in the iteration which is only used for debug and
pretty printing purposes. It's very similar in that it would
substract a length in code point to a length in chars and
truncate a StringBuilder at that length, so it would fail in a
quite similar manner. This changes the meaning of the "length"
attribute in Position, but it's clearer this way anyway.

Bug: 8450145
Change-Id: If396f883a9e6449de39351553ba83f5be5bd30f0
 2013-04-01 17:06:19 +09:00
Jean Chalard
740da0d8d0 Fix an NPE 
Also remove an unused method and make 2 private variables
final.

Bug: 8461093
Change-Id: I676d93fda28e82eb5a6978f2e7ad5a0add2cbecf
 2013-03-29 18:41:29 +09:00
Tadashi G. Takaoka
48d8d8d0ae Fix potential NPE in MainKeyboardView.KeyTimerHandler 
Bug: 8469652
Change-Id: Ib7a548e6a24d2e02de85ab444c0ec99d8f6b82c3
 2013-03-28 17:54:36 +09:00
Jean Chalard
2188cbae63 Merge "Fix an NPE" 2013-03-28 06:56:49 +00:00
Jean Chalard
d555a0d77a Merge "Cleanup" 2013-03-28 06:16:40 +00:00
Jean Chalard
28d5f4577f Fix an NPE 
The code was passing the wrong parameter.

Bug: 8492879
Change-Id: I091d62ca29601e3807eed287c7bdad38bf43a502
 2013-03-28 15:08:05 +09:00
Jean Chalard
dae90cfb01 Cleanup 
Seems there was an unclosed cursor :o

Change-Id: I7616849ace5217d8c6f54465f7b3a634e3c14116
 2013-03-28 14:43:32 +09:00
Satoshi Kataoka
f463b45d8e Merge "Fix Possible NPE" 2013-03-27 04:51:48 +00:00
Satoshi Kataoka
2cdf5351aa Merge "Fix possible SIOOBE" 2013-03-27 03:28:49 +00:00
Satoshi Kataoka
33306acfa4 Fix possible SIOOBE 
Bug: 8461021

Change-Id: I8b0385610b80b5a672ec380935c485a0e01ae984
 2013-03-27 12:25:02 +09:00
Kurt Partridge
39cb0334d9 Avoid NPE 
Initialize FeedbackLog earlier to avoid NPE

Change-Id: I646944c68a7d092345def16060b2a4edd8c7dbef
 2013-03-26 16:46:43 -07:00
Kurt Partridge
189be5196a Split LogUnits differently. 
Previously an autocorrection caused a new LogUnit to be started,
splitting off the previous LogUnit right at the autocorrection method
time.  This change causes the split to happen before the MotionEvents
that led to the autocorrection being called.

Change-Id: I2504df8eb47ee77e5f46bac34a8450636c03fd9f
 2013-03-26 16:46:43 -07:00
Kurt Partridge
cb25e1fe37 Reorder ResearchLogger call 
Previously, ResearchLogger#onWordFinished() was called with an outdated parameter value for
isBatchMode, causing it to report false even for gestures.  This changes fixes this problem.

Change-Id: Ifcabee236ba5fe20376ad882155d3f3142cd7613
 2013-03-26 14:37:57 -07:00
Kurt Partridge
ef103e1f2e Merge "Close ResearchLogger upon onFinishInputView" 2013-03-26 19:23:00 +00:00
Tadashi G. Takaoka
73d00e68d8 Merge "Use XmlPullParser.getEventType()" 2013-03-26 05:38:18 +00:00
Satoshi Kataoka
435cccb2c5 Fix Possible NPE 
Bug: 8448448
Change-Id: Ibe89c9abd24c4debb33a69c372eadf2afb09ea1c
 2013-03-26 13:02:23 +09:00
Satoshi Kataoka
0b3271010f Merge "Fix possible NPE" 2013-03-26 03:49:06 +00:00
Tadashi G. Takaoka
52f4b04768 Use XmlPullParser.getEventType() 
Change-Id: Ie423d3416639f81409cc920658c8088b7519b045
 2013-03-26 12:13:56 +09:00
Tadashi G. Takaoka
d17b69ec00 Clean up XmlParserUtils 
Change-Id: I636e8f359d47f39e61a7f77e3e686f2721779b6f
 2013-03-26 12:03:07 +09:00
Kurt Partridge
6d71d238e2 [FileEncap18] Clean up uploading scheduling 
- Move scheduling logic from ResearchLogger.java to
  UploaderService.java
- Switch to a one-shot timer.  Previously the uploader was scheduled
  on an inexact repeating schedule.  It's better to reschedule the
  next upload after the current one is finished to reduce the chances
  of multiple uploads happening at the same time.
- Avoid double-execution
    - Previously a scheduled upload might run right after an explicit
      one if they occured at the same time.  This change reduces the
      chances of this.
- Some method extraction and naming

Change-Id: I9efda11be77d334c7f61bd40a36d65f0421ebde4
 2013-03-25 17:50:26 -07:00
Kurt Partridge
87bc3a4a62 Close ResearchLogger upon onFinishInputView 
Previously, ResearchLogger#stop() was called both in
LatinIME#onFinishInputView() and in LatinIME#onWindowHidden().  This
resulted in multiple logs being written.

Since onFinishInputView is the more reliable of the two (it is called
in InputMethodService#onDestroy; onWindowHidden is not), the code now
uses onFinishInputView as a stopping signal.

Change-Id: Iae4b8c3bdab226027624eeab19b3737367e4a108
 2013-03-25 17:31:25 -07:00
Satoshi Kataoka
a17dccbfc6 Fix possible NPE 
Bug: 8457109
Change-Id: I321fbef53e20a7c36ef4bd9f544b50abe6a52be9
 2013-03-25 19:00:38 +09:00
Tadashi G. Takaoka
fb658d6c53 Fix possible ArrayIndexOutOfBoundsException 
Bug: 8461864
Change-Id: Icd8f4f51ec064461c08d00c1c58bedf5fbae2553
 2013-03-25 12:37:04 +09:00
Alan Viverette
a7b4398c35 Don't announce changes for A11y within the same keyboard mode. 
Bug: 8439108
Change-Id: If9f14bb65625468dcd399df47ad0d2123be30be7
 2013-03-22 11:53:12 -07:00
Satoshi Kataoka
19a7008728 Merge "Fix appname" 2013-03-22 07:23:08 +00:00
Satoshi Kataoka
3c8117c88f Fix appname 
Bug: 6789579
Change-Id: Ic4694e36e0846af95fa8dcdef919be251983b528
 2013-03-22 16:19:44 +09:00
Tadashi G. Takaoka
3a8a63c399 Remove unused import 
This is a follow up of I062c076f.

Change-Id: Ic3a83d95aed1f86121ed552a6f20f0d24f9d6d83
 2013-03-22 15:23:06 +09:00
Tadashi G. Takaoka
c6452f2569 Merge "Remove reference to string.english_ime_name" 2013-03-22 05:11:50 +00:00
Satoshi Kataoka
f4352c2ce3 Merge "Use correct appname resource" 2013-03-22 05:11:26 +00:00
Satoshi Kataoka
242c066dde Use correct appname resource 
Bug: 6789579
Change-Id: Id11435a28d6c5b6c72867814e23f5e62429080f8
 2013-03-22 14:08:38 +09:00
Tadashi G. Takaoka
9f3774c194 Remove reference to string.english_ime_name 
Bug: 6789579
Change-Id: I062c076f0ca16cc39274e20955aa83d667b7380d
 2013-03-22 14:08:23 +09:00
Tadashi G. Takaoka
ee91bde16c Clean up InflateException reference from KeyboardBuilder 
Change-Id: If9daa00b6d829ce2069a027e4bfec310ec108615
 2013-03-21 12:27:33 +09:00
Alan Viverette
9da7fa0f50 am 559616fb: Prevent keyboard A11y proxy from referencing a null keyboard view. 
* commit '559616fb0c39e2f0bacdf294b84ba16ad1e8f371':
  Prevent keyboard A11y proxy from referencing a null keyboard view.
 2013-03-19 23:59:56 +00:00
Alan Viverette
559616fb0c Prevent keyboard A11y proxy from referencing a null keyboard view. 
Bug: 8402674
Change-Id: I507cdabccdabb3fd7aebc071c93eb6d4dcb9635d
 2013-03-19 13:17:42 -07:00
Satoshi Kataoka
a462cd80ae Support feedback 
Bug: 8143554
Change-Id: If0a6bafc94da040f97f27c6d046fb58bed9fd615
 2013-03-19 17:25:55 +09:00
Jean Chalard
8e005f2989 am 1061bfdb: Break dependencies to allow offdevice tests to build 
* commit '1061bfdb34bbcb63bf0046eec42313d264ac33fa':
  Break dependencies to allow offdevice tests to build
 2013-03-19 08:12:50 +00:00
Jean Chalard
6d90a10a34 am 0cc0544a: Merge the dictionary pack in Latin IME. 
* commit '0cc0544a2995c7eb54a830ae54db60af89d4073d':
  Merge the dictionary pack in Latin IME.
 2013-03-19 08:12:49 +00:00
Jean Chalard
1061bfdb34 Break dependencies to allow offdevice tests to build 
Change-Id: Ia9a2e8f0672b3f72943f26fb15de1d3c7c5ce7f1
 2013-03-19 16:45:25 +09:00
Jean Chalard
0cc0544a29 Merge the dictionary pack in Latin IME. 
Bug: 8161354
Change-Id: I17c23f56dd3bc2f27726556bf2c5a9d5520bd172
 2013-03-19 15:40:14 +09:00
Tadashi G. Takaoka
841c295f3c resolved conflicts for merge of 5b048292 to master 
Change-Id: I67ebab46954cd7b8e3e79e7fed523bafb15f8835
 2013-03-19 10:48:10 +09:00
Ken Wakasa
9c3860ce46 Rename ProductionFlag.IS_EXPERIMENTAL to USES_DEVELOPMENT_ONLY_DIAGNOSTICS 
bug: 8393568
Change-Id: Ie5edf44a3627aca9416145aff56bf05bbf2a05f3
 2013-03-18 23:15:47 +09:00
Jean Chalard
f8325ec4bb am 5cb0560b: Merge "Access the dictionary pack only if have INTERNET permission" into jb-mr2-dev 
* commit '5cb0560b000f37b3fb3937f01b6d3e928afef57a':
  Access the dictionary pack only if have INTERNET permission
 2013-03-18 11:08:52 +00:00
Jean Chalard
5cb0560b00 Merge "Access the dictionary pack only if have INTERNET permission" into jb-mr2-dev 2013-03-18 11:04:53 +00:00
Jean Chalard
ce487bcf33 Access the dictionary pack only if have INTERNET permission 
Bug: 8161354
Change-Id: I68ee3acb2955a017d25666cc2dad791798f9064a
 2013-03-18 18:40:33 +09:00
Satoshi Kataoka
62ed594c37 am e0e67373: Refactor parameters by naming convention 
* commit 'e0e67373735918c78eaeaf24f127e1d28816aa29':
  Refactor parameters by naming convention
 2013-03-18 06:47:10 +00:00
Satoshi Kataoka
e0e6737373 Refactor parameters by naming convention 
Change-Id: I8bda8075b33f656ecbec08320afcd864b620fe77
 2013-03-18 15:42:15 +09:00
Tadashi G. Takaoka
3268a44e1c am a5067333: Disable the header list of DebugSettingsActivity 
* commit 'a50673330e012f6cca02b83eca1c047b8da319e0':
  Disable the header list of DebugSettingsActivity
 2013-03-15 07:10:00 +00:00
Tadashi G. Takaoka
a50673330e Disable the header list of DebugSettingsActivity 
This change addresses the issue that the debug settings on 10-inch
tablet doesn't show up.

Change-Id: I60540cf21276869a3ca81b7b0154056ce7d93ff1
 2013-03-15 15:33:27 +09:00
Kurt Partridge
f33f1cab2f [FileEncap9] Extract ResearchLogDirectory class 
Previously used a monotonically increasing int.  Now uses uuid and nanoseconds.

squashed in:
    [FileEncap11] Read preference from ResearchSettings
    Change-Id: Ic779e0a69db6b16e92c6f4b63dbe7b7add566ab6

    [FileEncap12] Simplify directory cleanup invocation
    Change-Id: I688047409c0343d32b11447fb625dfb726c731ec

    [FileEncap14] Change log filename syntax
    Change-Id: I9243b20b2eb392f81ab8c5c3d19315211240e0bc

Change-Id: I5c9d70e0cb7b0965158e17dd71dfab796bd9a440
 2013-03-14 06:37:56 -07:00
Kurt Partridge
7faa2caa80 Merge "[Lazy4] Remove useless debug code" 2013-03-14 13:13:57 +00:00
Tadashi G. Takaoka
fb606c6277 am f0864b1d: Merge "Clean up StaticInnerHandlerWrapper a bit" into jb-mr2-dev 
* commit 'f0864b1d95411ce9886a5ade13f42cb17f578828':
  Clean up StaticInnerHandlerWrapper a bit
 2013-03-14 03:44:00 +00:00
Tadashi G. Takaoka
f0864b1d95 Merge "Clean up StaticInnerHandlerWrapper a bit" into jb-mr2-dev 2013-03-14 03:41:01 +00:00
Tadashi G. Takaoka
1ab33383f9 am 0d5f214a: Fix NPE found in monkey test 
* commit '0d5f214aa774ab0ab7c17521984caae11c9f4c2b':
  Fix NPE found in monkey test
 2013-03-14 03:39:38 +00:00
Tadashi G. Takaoka
41e60bf6dd Clean up StaticInnerHandlerWrapper a bit 
Change-Id: Ib07efe6da1eb2f0fd9ef68ca71502c98f7e19f4b
 2013-03-14 12:35:47 +09:00
Tadashi G. Takaoka
0d5f214aa7 Fix NPE found in monkey test 
Bug: 8383127
Change-Id: Ifd70acabe118b477f103937c7f1e99e38e210833
 2013-03-14 12:19:10 +09:00
Tadashi G. Takaoka
f5caf5be99 am 601a8582: Merge "Move checking non-persistent checkbox to onResume" into jb-mr2-dev 
* commit '601a8582d0f761a85b6eb16e7a6b78402f6f2599':
  Move checking non-persistent checkbox to onResume
 2013-03-14 02:33:28 +00:00
Satoshi Kataoka
0b2512017e am 0ab44b21: Merge "Make isInternal mutable" into jb-mr2-dev 
* commit '0ab44b21bd6ef5e9fde329b25dfd84f6ca5c0825':
  Make isInternal mutable
 2013-03-13 17:24:49 +00:00
Kurt Partridge
64b9596544 Merge "[Lazy2] Pass a runnable to abort" 2013-03-13 13:20:55 +00:00
Jean Chalard
8067b769f1 Merge "[DO NOT MERGE] Deactivate H/W keyboard handling" into jb-mr2-dev 2013-03-13 10:55:04 +00:00
Tadashi G. Takaoka
601a8582d0 Merge "Move checking non-persistent checkbox to onResume" into jb-mr2-dev 2013-03-13 07:52:35 +00:00
Satoshi Kataoka
0ab44b21bd Merge "Make isInternal mutable" into jb-mr2-dev 2013-03-13 07:41:11 +00:00
Satoshi Kataoka
756791e6bf Make isInternal mutable 
Change-Id: Ib81ceba801be0ac7ef65c4eadd1ec8599e80dacc
 2013-03-13 16:28:50 +09:00
Tadashi G. Takaoka
24cea7f1fb Move checking non-persistent checkbox to onResume 
Bug: 8336068
Change-Id: I07e67a6aee24a239a21e6fc69eb2ec741b9a5b2b
 2013-03-13 15:54:33 +09:00
Jean Chalard
13a82d9530 [Lazy2] Pass a runnable to abort 
Change-Id: I721afbf426099753aa876a55323eb806b08c24d6
 2013-03-12 18:56:57 -07:00
Kurt Partridge
5e75e15a95 Merge "[Lazy1] Switch to blocking log closures" 2013-03-13 00:18:02 +00:00
Jean Chalard
7423005b96 [Lazy1] Switch to blocking log closures 
Change-Id: I4daec20b7b47b0d71c5aab6e17cd660015e19e71
 2013-03-12 17:09:08 -07:00
Tadashi G. Takaoka
dbfd2825c8 am 2bbd3065: Language dependent single/doule quotation more keys 
* commit '2bbd3065d3bd9785ad1638c65f8c73f11bf21922':
  Language dependent single/doule quotation more keys
 2013-03-12 05:57:30 +00:00
Tadashi G. Takaoka
2bbd3065d3 Language dependent single/doule quotation more keys 
The natural way of marking quoted text vary from language to
language. This change introduces the following variations.

* LEFT and RIGHT quotations (English etc.)
* LOW-9 and LEFT quotations (German etc.)
* LOW-9 and RIGHT quotations (Dutch etc.)
* RIGHT and RIGHT quotations (Swedish etc.)
* LEFT ANGLE and RIGHT ANGLE quotations (French etc.)
* RIGHT ANGLE and LEFT ANGLE quotations

Bug: 8356419
Change-Id: I75726ab7ed783d02f189b46236c9d5079737bcff
 2013-03-12 14:43:34 +09:00
Jean Chalard
92eaa6fc7c [DO NOT MERGE] Deactivate H/W keyboard handling 
For MR2, LatinIME should not be handling hardware keyboard
events. The feature is still work in progress.

Change-Id: I56ff18bff84ba6b5a6bc3f8829b42eaf33b72554
 2013-03-12 14:22:06 +09:00
Jean Chalard
220b271dfa [Lazy4] Remove useless debug code 
This code is cluttering readability and getting in the way
of future updates.
Future updates will make it much easier to debug and to
test this code, so this needs to disappear.

Change-Id: I32e28ec608587b6b7c07250a2692b13e8fc98465
 2013-03-08 17:46:00 -08:00
Svetoslav Ganov
2d9b7f60dd am af37cbb4: Merge "Announce keyboard mode changes as a WINDOW_STATE_CHANGED event." into jb-mr2-dev 
* commit 'af37cbb44ef40fcd15fa02456c9abda8021847ce':
  Announce keyboard mode changes as a WINDOW_STATE_CHANGED event.
 2013-03-08 19:24:25 +00:00
Svetoslav Ganov
af37cbb44e Merge "Announce keyboard mode changes as a WINDOW_STATE_CHANGED event." into jb-mr2-dev 2013-03-08 19:20:00 +00:00
Tadashi G. Takaoka
60906d4d08 am 914d054e: Move logic of selecting key preview attribute to Key class 
* commit '914d054ea26d18a1ba6a60f8c5e749136477bbf2':
  Move logic of selecting key preview attribute to Key class
 2013-03-08 11:24:13 +00:00
Tadashi G. Takaoka
914d054ea2 Move logic of selecting key preview attribute to Key class 
This change also fixes the size of a key preview letter to follow a
keyLabelFlags specification.

Change-Id: Ie13790788a16c5a053c1a2cbcac3d38314b14b7f
 2013-03-08 19:44:22 +09:00
Kurt Partridge
bba39b9b67 [FileEncap8] Remove useless "success" variable 
Change-Id: Icf76bc0b795b6a9221d9a6d61c38df31af54ab7b
 2013-03-07 17:43:35 -08:00
Kurt Partridge
ee3261ff55 [FileEncap7] Extract uploadContents method 
Change-Id: I018b2726533042dbcb25713ea039aec41c148db2
 2013-03-07 17:43:28 -08:00
Kurt Partridge
4436446e9b [FileEncap6] Extract Uploader class 
Gerrit was stuck on original change I9ef4eb7450

Change-Id: I6d4ee686944074779aca5b09b018782c7033874d
 2013-03-07 16:19:44 -08:00
Alan Viverette
c2ee72a214 Announce keyboard mode changes as a WINDOW_STATE_CHANGED event. 
Bug: 8165295
Change-Id: Ie416f6cdb68377f3e06f30e9b6363c38ba2a602d
 2013-03-07 10:39:55 -08:00
Kurt Partridge
41c471d93d Merge "[FileEncap5] Move conditional logic to caller" 2013-03-06 20:59:04 +00:00
Kurt Partridge
1bc20700d5 Merge "[FileEncap4] Simplify logic" 2013-03-06 20:05:47 +00:00
Kurt Partridge
719bb3aa39 Merge "[FileEncap3] Extract isUploadingUnconditionally method" 2013-03-06 19:14:52 +00:00
Kurt Partridge
5e5b6b7870 Merge "[FileEncap2] Remove mCanUpload instance variable" 2013-03-06 18:39:07 +00:00
Kurt Partridge
b000e94eea Merge "[FileEncap1] Extract hasUploadingPermisssions method" 2013-03-06 18:02:26 +00:00
Kurt Partridge
9283644c41 [FileEncap5] Move conditional logic to caller 
Change-Id: I6599539059f86dc8902210d325439c08035b2e2a
 2013-03-06 07:19:41 -08:00
Kurt Partridge
88f466678c [FileEncap4] Simplify logic 
Change-Id: Ibb8660d12812b867856259d3e5c04a31e281027d
 2013-03-06 07:19:41 -08:00
Kurt Partridge
7f7850d23a [FileEncap3] Extract isUploadingUnconditionally method 
- remove isUploadingUnconditionally local variable

Change-Id: I69be8708c1f306568cbb9c5cbefc9e42a87df497
 2013-03-06 07:19:41 -08:00
Kurt Partridge
466e665b3c [FileEncap2] Remove mCanUpload instance variable 
Change-Id: I62a100c4d73bb64a14a7994f7dd9af7b6946d064
 2013-03-06 07:19:41 -08:00
Kurt Partridge
347b2ebebf [FileEncap1] Extract hasUploadingPermisssions method 
Change-Id: Ica1dabcf066cde6580035f12fa35a404cb32fb3f
 2013-03-06 07:19:41 -08:00
Kurt Partridge
68b3e4e7d3 Merge changes I2ded3d0a,I27ad9dfb 
* changes:
  Little cleanups
  Clean up initialization ordering
 2013-03-06 15:08:08 +00:00
Kurt Partridge
dc89d76f6b Merge "Make some methods visible for testing" 2013-03-06 03:43:55 +00:00
Kurt Partridge
25343124dd Make some methods visible for testing 
bug: 8302967

multi-project commit with Icf915abb57ef00840ee93b67a25db42ba51f1c38

Change-Id: I105bda5bdff871508140fb99487dddbf17992790
 2013-03-05 19:28:31 -08:00
Kurt Partridge
84bc16af3e Little cleanups 
Change-Id: I2ded3d0a29610941fac27c9b26168dd6c06ceccc
 2013-03-05 18:37:44 -08:00
Kurt Partridge
4eeb90cd72 Clean up initialization ordering 
This change is based on an earlier one that got stuck in Gerrit: Iab77504b

Change-Id: I27ad9dfb1bbb2300bd1e61d881a6ea0e116db066
 2013-03-05 18:37:00 -08:00
Kurt Partridge
60f51684f1 Merge "Clean up logic in onUserLoggingConsent" 2013-03-05 16:43:08 +00:00
Tadashi G. Takaoka
249c887008 am 84fa8043: Merge "Add show setup wizard icon preference settings" into jb-mr2-dev 
* commit '84fa8043e6bef47378b3fc32c277e33034d5c174':
  Add show setup wizard icon preference settings
 2013-03-05 06:30:33 +00:00
Tadashi G. Takaoka
2e1b55f796 Add show setup wizard icon preference settings 
Bug: 8239067
Change-Id: If6106a3632d3abad3e22ce29f1351525a5152ec7
 2013-03-05 14:56:41 +09:00
Kurt Partridge
157c00145b Clean up logic in onUserLoggingConsent 
- Make ResearchSetting for whether the user has seen the splash screen
- Inline #setLoggingAllowed, which is short and is now only called by
  onUserLoggingConsent

Change-Id: Icdf4592777b80643807b6ccf1d3896459c503e02
 2013-03-04 12:05:03 -08:00
Kurt Partridge
75e6fb68e9 Clean up PREF_USABILITY_STUDY_MODE 
- Refer to a common default value in DebugSettings
- Make PREF_USABILITY_STUDY_MODE independent of the ResearchLogger
- ResearchLogger uses its own preference through ResearchSettings

multi-project commit with Ie0df836c9d779eba484b522666ec357f4e234823

Change-Id: I88547a2f619db6e7364abbbec12f9f76855dd11a
 2013-03-04 12:05:03 -08:00
Kurt Partridge
788dc55662 Merge "Remove MainLogBuffer#setSuggest()" 2013-03-04 15:10:31 +00:00
Ken Wakasa
31a5386794 am a8d3d509: Small cleanup in CompatUtils 
* commit 'a8d3d50970cecf961940efc0e908fbb2f9b35472':
  Small cleanup in CompatUtils
 2013-03-04 03:56:05 +00:00
Ken Wakasa
a8d3d50970 Small cleanup in CompatUtils 
Change-Id: I9b4a8d7eae744ba6252a6475b75240248c70a3c0
 2013-03-02 17:18:18 +09:00
Kurt Partridge
a8e668c81e Merge "Move UUID preference reading to ResearchSettings.java" 2013-03-02 01:50:03 +00:00
Kurt Partridge
b094372bd6 Remove MainLogBuffer#setSuggest() 
multi-project commit with Ia98b1406fc2ee11a96893c77ea58d800fece7624

Change-Id: I8bc3d07b83dbe7d8fc56a618de07dade7f510b13
 2013-03-01 13:32:11 -08:00
Tadashi G. Takaoka
578e71e28b am 99b0dc6f: Merge "Add setup wizard launcher icon" into jb-mr2-dev 
* commit '99b0dc6f0d18f5fdd8634e8fa533bf1b3f81a538':
  Add setup wizard launcher icon
 2013-03-01 16:13:45 +00:00
Tadashi G. Takaoka
99b0dc6f0d Merge "Add setup wizard launcher icon" into jb-mr2-dev 2013-03-01 16:08:09 +00:00
Kurt Partridge
bc2588708a Merge "[TestPrep22] Make variable package-private for testing" 2013-03-01 14:48:43 +00:00
Tadashi G. Takaoka
1ffdaafd83 Add setup wizard launcher icon 
The setup wizard icon will be hidden if the Android Keyboard is in
system image.

Bug: 8239067
Change-Id: Ib0c0c9e3a0954512c3e03e42a661cdf86eff0dca
 2013-03-01 22:28:00 +09:00
Jean Chalard
31747ba787 am abaf5827: Separate suggestions from SuggestionView 
* commit 'abaf5827e7a7f5f6c5d8d98e03e6b9528b0c9351':
  Separate suggestions from SuggestionView
 2013-03-01 05:17:52 +00:00
Jean Chalard
abaf5827e7 Separate suggestions from SuggestionView 
This is a cleanup change, but it's also necessary for

Bug: 8152758
Change-Id: Id6ba06243f573fdb856f87d1df03277c9f2e5e71
 2013-02-28 21:03:18 -08:00
Kurt Partridge
00ed4704f9 Move UUID preference reading to ResearchSettings.java 
Change-Id: I8157249259cf8c3218c5c82a5729f4cbc1fb4eeb
 2013-02-28 19:54:21 -08:00
Kurt Partridge
9ba7ad8d4f Merge "[TestPrep20] Clean up import statement" 2013-03-01 01:32:35 +00:00
Tadashi G. Takaoka
040b442f3c am 18e21d58: Remove closing method from KeyboardView 
* commit '18e21d58f7c0b5c5c001835c093221c573a841c4':
  Remove closing method from KeyboardView
 2013-02-28 22:38:11 +00:00
Kurt Partridge
59912837b3 [TestPrep22] Make variable package-private for testing 
Change-Id: I902a6a40df1c672c611672f34d2f3237b0d1821b
 2013-02-28 06:45:35 -08:00
Kurt Partridge
5cd50faaca [TestPrep20] Clean up import statement 
Change-Id: Ifcfec09b669d8b2012b1c960bd4b1471c7946870
 2013-02-28 06:45:34 -08:00
Kurt Partridge
abaa88fd4e Merge "[TestPrep18] Make class public for testing" 2013-02-28 01:00:46 +00:00
Kurt Partridge
a04fbce412 Merge "[TestPrep17] Allow fake dictionary for testing" 2013-02-27 23:59:01 +00:00
Tadashi G. Takaoka
2ed1ec411d am 016046eb: Keep Keyboard object while closing KeyboardView 
* commit '016046eb4e3ea28745b9a29c41c126801f177f58':
  Keep Keyboard object while closing KeyboardView
 2013-02-27 23:22:32 +00:00
Tadashi G. Takaoka
18e21d58f7 Remove closing method from KeyboardView 
This is a follow up of Ie00ba827. After the change, the
KeyboardView.closing() method does nothing important.

Change-Id: I9659ea56ce82a95f8798a4136bf93f164b67fae7
 2013-02-27 17:35:20 +09:00
Tadashi G. Takaoka
016046eb4e Keep Keyboard object while closing KeyboardView 
Bug: 8217626
Change-Id: Ie00ba827bc391aa152427965c57488b66308a75c
 2013-02-27 17:30:16 +09:00
Kurt Partridge
424a976e58 Merge "Ensure Preference listener is unregistered" 2013-02-27 03:49:40 +00:00
Kurt Partridge
96d019f183 [TestPrep18] Make class public for testing 
Change-Id: I4b457f44dd6a5a595c61a62061ea02c251fa9ab1
 2013-02-26 19:22:56 -08:00
Kurt Partridge
5ee261a990 [TestPrep17] Allow fake dictionary for testing 
Currently ResearchLog requires a full dictionary to perform privacy-related checks.
This makes testing difficult.  This change allows a fake dictionary to be used instead.

Change-Id: Ifca5bd8647475a6b84e4324117e0faa0a35479ee
 2013-02-26 19:22:55 -08:00
Kurt Partridge
7e2c1e69bf Ensure Preference listener is unregistered 
Change-Id: I1a4d1e7bc45fc30cb1b63ea6020f0eee6e804333
 2013-02-26 18:40:34 -08:00
Kurt Partridge
64c34122f2 Merge "[TestPrep11] Only use mHasWrittenData to control JsonWriter#endArray() call" 2013-02-27 00:41:12 +00:00
Kurt Partridge
62abc40d7d Merge "[TestPrep10] Add some comments" 2013-02-26 23:09:48 +00:00
Kurt Partridge
f170f145af [TestPrep11] Only use mHasWrittenData to control JsonWriter#endArray() call 
Change-Id: If2107e38575b009a4c372194ecd827e27bdbb2b4
 2013-02-26 15:02:52 -08:00
Kurt Partridge
a5e564bea0 [TestPrep10] Add some comments 
Change-Id: Ia8e0bd72b0dc09bfc256ec5d1996637554376b5f
 2013-02-26 15:02:52 -08:00
Tadashi G. Takaoka
183fe80031 Small cleanup of RunInLocale 
Change-Id: Ib588e67da2c88345fc4eb51587b07ebfa434e0bb
 2013-02-26 19:11:49 +09:00
Jean Chalard
0f3c05cd6b Merge "Send the dictionaries descriptions to the dict pack" 2013-02-23 10:18:03 +00:00
Jean Chalard
c6799ffeab Send the dictionaries descriptions to the dict pack 
Bug: 8255795
Change-Id: I12a5922f50c2d2e3aa639457abcc1483e6a48721
 2013-02-23 01:46:39 -08:00
Jean Chalard
76ead0ead0 Fix a possible crash 
If the dictionary ID, as indicated in the metadata, is
less than three chars long, it crashes LatinIME.
Of course we don't have such dictionary IDs in the current
metadata, but it's still better to be able to handle
the case gracefully ^^;

Change-Id: I60cdf6f8ecce9f4d44b42ddd5d157aebff9a4163
 2013-02-23 01:41:44 -08:00
Jean Chalard
aefaec3c5f Remove a cluttering log 
Bug: 8175067
Change-Id: I9a104a32ba2b3b52a5dfa250f8c642abd6169cc0
 2013-02-23 00:48:10 -08:00
Jean Chalard
8b4023c4d6 Merge "Tiny cleanup" 2013-02-23 08:07:27 +00:00
Jean Chalard
2521edec09 Fix a bug with the passed dictionary id 
We used to make the dictionary that we passed to the
dictionary pack as an initial value based on the locale.
This is wrong - it should be read from the dictionary.
This change fixes that.

Bug: 7005813
Change-Id: Ib08ed31dd9c216f6f7b9c6c3174ca514bf96e06f
 2013-02-22 20:49:48 -08:00
Jean Chalard
da0d771fe9 Tiny cleanup 
Change-Id: I5d7150a4abb3a498e790f41af569093217cb8b43
 2013-02-22 19:42:45 -08:00
Jean Chalard
8f794c72db Merge "Fix how the Enter action is decided" 2013-02-23 00:13:27 +00:00
Jean Chalard
4e4f88127b Fix how the Enter action is decided 
This unifies the software and hardware keyboard code
under a single decision process that works.

Bug: 8129303
Bug: 8152758
Change-Id: I7574c563d5f957d57bfe62fe5e3eec59a519d335
 2013-02-22 16:01:37 -08:00
Kurt Partridge
744b363ae8 [TestPrep8] Narrow try/catch scope 
Change-Id: If15f250feb81c2ad55ce1bc7dc3dafa57de87aef
 2013-02-21 17:01:08 -08:00
Kurt Partridge
78c1ad32e6 [TestPrep7] Encapsulate JsonWriter creation 
Change-Id: I4e97fa28dd0bb1101edc0db03f024432fee6f6fe
 2013-02-21 17:01:08 -08:00
Kurt Partridge
07050549b1 Merge "[TestPrep5] Parameterize MainLogBuffer" 2013-02-21 23:52:05 +00:00
Kurt Partridge
bf0d6af3d3 Merge "[TestPrep4] Add some finals" 2013-02-21 22:13:05 +00:00
Kurt Partridge
7c996475d8 Merge "[TestPrep3] Add helper method to retrive dictionary" 2013-02-21 21:18:32 +00:00
Kurt Partridge
c8a1ec6e41 Merge "[TestPrep2] Rename a method" 2013-02-21 15:57:34 +00:00
Kurt Partridge
4e5a4ddbd0 Merge "[TestPrep1] Move MotionEvent.Action strings to LoggingUtils" 2013-02-21 14:54:46 +00:00
Tadashi G. Takaoka
07296cf7ff Merge "Use WordComposer.addKeyInfo for testing" 2013-02-21 06:20:01 +00:00
Kurt Partridge
ab0bda1499 [TestPrep5] Parameterize MainLogBuffer 
Change-Id: I6d84f490922cd1f40e44ca4f95c9d950fba38290
 2013-02-20 19:37:12 -08:00
Kurt Partridge
22acdb540c [TestPrep4] Add some finals 
Change-Id: Ib437a6ad7fd6a897e2bbc65afe881ae8a3b1cbb0
 2013-02-20 19:37:12 -08:00
Kurt Partridge
19e05359e6 [TestPrep3] Add helper method to retrive dictionary 
Change-Id: Id6e03c6f8a3e96979d589f0605ac056fcad7e1ff
 2013-02-20 19:36:56 -08:00
Kurt Partridge
b6d05aeb7c [TestPrep2] Rename a method 
Change-Id: Id9a72045afa3558b20b9d63c8720fb7443d34fd9
 2013-02-20 17:13:00 -08:00
Kurt Partridge
8d429bf1a8 [TestPrep1] Move MotionEvent.Action strings to LoggingUtils 
Change-Id: I7b9ed800552f2fd546ed21e9dc06ea1ff5798337
 2013-02-20 17:12:56 -08:00
Tadashi G. Takaoka
46878544ec Add preliminary setup wizard 
Bug: 8159728
Change-Id: I30d9cd637fb1d2e64588550e0aa4387bc1f7e6e5
 2013-02-21 09:54:02 +09:00
Tadashi G. Takaoka
5701a6647f Use WordComposer.addKeyInfo for testing 
Change-Id: I500654e7a26717aa5547942357e56060afb72969
 2013-02-20 17:09:25 +09:00
Jean Chalard
d4cbc4fd07 Implement getting data files with protocol v2 
This also does it for deleting them
Bug: 8167342
Bug: 6789534
Change-Id: I1823f98508881f109a667146d3608003f87aa4cb
 2013-02-15 11:09:16 -08:00
Jean Chalard
4beaab2a88 Merge "Determine the protocol version of the dictionary pack" 2013-02-14 20:22:09 +00:00
Tadashi G. Takaoka
cb0beaf3f1 Add placeholder of keyboard setup wizard 
Bug: 8159728
Change-Id: I5552e9d0ffa8f94d183e76378d55bba6f718adfe
 2013-02-14 18:00:11 +09:00
Jean Chalard
b1f27a2e26 Determine the protocol version of the dictionary pack 
...for query.

Bug: 8167342
Change-Id: Ieb8e5b31c4b62bf507593c4631e31799aad5f267
 2013-02-13 20:45:36 -08:00
Kurt Partridge
de3e5fbf9d Merge "Cleanup in preparation for tests" 2013-02-13 23:34:07 +00:00
Kurt Partridge
531dd150eb Cleanup in preparation for tests 
multi-project commit with I1212da392ecda0ad78962da68941870b5a651eee

Change-Id: Ie74af59d4e45bf954723fee9dcf350a36468c381
 2013-02-12 20:48:44 -08:00
Jean Chalard
a9df972780 Clean up dictionary pack presence test. 
This method is much cleaner and much more readable.

Change-Id: I8055c169ef7c4453ab45c463704bd56a6080da4f
 2013-02-12 17:59:36 -08:00
Kurt Partridge
04de6802cc Merge "Add batchMode field to PickSuggestionManually" 2013-02-12 16:54:35 +00:00
Tadashi G. Takaoka
fdb1ca560e Merge "Separate caps mode related utils to CapsModeUtils" 2013-02-12 09:26:16 +00:00
Tadashi G. Takaoka
ce6bcdd1a5 Separate caps mode related utils to CapsModeUtils 
Change-Id: I32700c434b296bb3fd39e040c2dda1fe90667daf
 2013-02-12 18:15:42 +09:00
Tadashi G. Takaoka
2c2942dd4b Merge "Move parseCsvString to StringUtils" 2013-02-12 07:57:24 +00:00
Tadashi G. Takaoka
b3fd701181 Move parseCsvString to StringUtils 
Change-Id: I602f33991ca57b6057ec2defe01573552b322857
 2013-02-12 16:18:19 +09:00
Jean Chalard
e26f0d4320 Merge "Cleanups" 2013-02-12 06:49:41 +00:00
Tadashi G. Takaoka
4cbe84ad08 Merge "Fix RTL language key code mapping" 2013-02-12 06:43:40 +00:00
Tadashi G. Takaoka
9a2039d94e Fix RTL language key code mapping 
Bug: 8168899
Bug: 8169343
Change-Id: I23120704e97d89d5ddec2b2bdff2a98a6daac4d5
 2013-02-12 14:51:54 +09:00
Jean Chalard
1c5b2a41ec Cleanups 
Follow-up to Idc6f419a

Change-Id: I4aae8f4e19f27a0a309879dc19af6e40906d58c5
 2013-02-11 21:14:56 -08:00
Jean Chalard
8018051022 Some cleanups 
Improve a slew of logging statements, and put commands that we don't
expect to need protecting against exceptions out of a try {} block.

This is a followup to Id3dc510a

Change-Id: Idc6f419ac095b5b0f2d6862d58926ef888cb34e6
 2013-02-11 19:47:15 -08:00
Jean Chalard
82441e60e2 Remove unnecessary whitespace 
This is a cleanup followup to Id3dc510a

Change-Id: Ie64395eb4b6218fd8c73cacddeed2fba1df65d26
 2013-02-11 13:31:47 -08:00
Jean Chalard
b2eac474ff Don't try to issue delete() commands on missing provider 
Bug: 8173622
Change-Id: Id3dc510ae3535169b5290e87075cb2f433a1f603
 2013-02-11 12:38:24 -08:00
Kurt Partridge
2cabb7aed0 Close file properly 
Change-Id: Ied55b6a6f1e64bbca558316d8d3d207d7655cf91
 2013-02-08 11:43:51 -08:00
Kurt Partridge
c52569ffcb Add batchMode field to PickSuggestionManually 
Change-Id: Iaaffc71378154240538bf90f0b85c3f17f3f78b3
 2013-02-08 11:39:04 -08:00
Jean Chalard
3623ad238c [B14] Implement sending the dictionary list. 
Bug: 7005813
Change-Id: Ic3ef69510d2b385d0d403191b2f701b6527d0166
 2013-02-06 19:19:30 -08:00
Jean Chalard
6ecb4c4dcc [B11] Implement reset and passing of the URL to the dict pack 
Bug: 7601410
Bug: 7595195
Change-Id: I78cf04dce7c1e64de6725d32317de288a83bd39d
 2013-02-06 15:21:33 -08:00
Jean Chalard
afe889a83d Merge "[B9] Pass the client id parameter for dict info requests" 2013-02-06 04:38:44 +00:00
Kurt Partridge
b02a19c49d Refactor LogStatement publishing method 
The method in LogUnit for publishing a LogStatement to a JsonWriter doesn't
depend on anything in the LogUnit.

multi-project commit with Id1d6ff4851148bba0e6b5a1ec6eec2b842d9c707

Change-Id: I323cec239d6ea1cee602c2ecf9b13713791e9283
 2013-02-05 15:18:20 -08:00
Tadashi G. Takaoka
298b4240f8 Separate IntentUtils from CompatUtils 
Change-Id: I373ae7ad26eee44cc8e9720314f6a53b811d0021
 2013-02-04 16:06:38 -08:00
Kurt Partridge
445d8e8bf6 Merge "[Rlog79b] Save channel name during internal use" 2013-02-04 19:16:33 +00:00
Kurt Partridge
5ca4afa543 Merge "[Rlog48c] Replay historical motion data" 2013-02-04 18:36:57 +00:00
Kurt Partridge
82b4374c75 Merge "[Rlog48b] Better visual indicator for logging state" 2013-02-04 18:06:41 +00:00
Kurt Partridge
7708bcf6fb [Rlog48c] Replay historical motion data 
Change-Id: Ib398ea61ff048b1a4ac3b7f7b4a772e173a7b294
 2013-02-04 06:13:51 -08:00
Kurt Partridge
d34347bd4b [Rlog79b] Save channel name during internal use 
The feedback string is used as a channel name in internal builds.  Add a flag
that lets it be saved between calls to make it easier to generate test data.

Change-Id: I5c6149b1e68239cd968b6852d03cc240ddde99ca
 2013-02-04 06:09:45 -08:00
Jean Chalard
8192b4a6ef [B9] Pass the client id parameter for dict info requests 
Bug: 6789534
Change-Id: Ie3ea75b19ae4da2dea531e0077c58742a9502bc6
 2013-02-02 18:23:40 +09:00
Jean Chalard
f1acb0e52d Make some strings private 
Change-Id: I0ffdbcf6bede86a3cdcb3a0e4ec263398502617c
 2013-02-02 15:00:09 +09:00
Kurt Partridge
ce9e7f667d [Rlog48b] Better visual indicator for logging state 
Now applies yellow bars if recording, green bars if replaying.

Change-Id: I39d39de6254fd57107ea5355c43b154244520985
 2013-02-01 17:10:56 -08:00
Kurt Partridge
ceffa0bec9 Merge "[Rlog79a] Disallow empty feedback messages" 2013-02-01 17:15:07 +00:00
Kurt Partridge
0cafd6580c Merge "[Rlog48a] Update and make logging strings consistent" 2013-02-01 16:33:42 +00:00
Kurt Partridge
d3f718fccd [Rlog79a] Disallow empty feedback messages 
Change-Id: I30f7c07606e466c3c9538adad94024d00f0901de
 2013-02-01 07:08:32 -08:00
Kurt Partridge
5bdd7bab11 Merge "[Rlog47] Replayer service, inspect-researchLog.py" 2013-02-01 15:05:58 +00:00
Tadashi G. Takaoka
5c58133c80 Clean up GestureFloatingPreviewText 
Change-Id: Ie64dd06a99e54b2f432725f69dc4f38c81359ce6
 2013-02-01 15:23:21 +09:00
Kurt Partridge
c20a415e15 [Rlog48a] Update and make logging strings consistent 
Change-Id: Iae04115921aaf6bbc3c6ad6e7d2d0e7401af41f8
 2013-01-31 19:08:54 -08:00
Kurt Partridge
40be4c3bdb ResearchLogger invocation tests 
- Start with just a smoke test.
- Sets up a private SharedPreferences

multi-project commit with I81cceba23692d64c2ea58a46351fc36d118ff825

Change-Id: I96e02d9a8de70cb5c03fd7411b886903e7a83673
 2013-01-31 14:54:14 -08:00
Kurt Partridge
588d9b5c8d [Rlog47] Replayer service, inspect-researchLog.py 
multi-project commit with Ia2dd81afb4ea124094a20a39e31ffd193edff3d2

Change-Id: I80fe8f2ce137fedf48038955d5f3d9deed04f763
 2013-01-31 12:13:08 -08:00
Kurt Partridge
6b574f8056 Merge "[Rlog39] Remove unnecessary commitCurrentLogUnit() call" 2013-01-31 18:52:31 +00:00
Jean Chalard
5ea4365f07 Merge "Create methods in LatinIME to make the current dict lists" 2013-01-31 16:59:11 +00:00
Kurt Partridge
e8a0bfb315 [Rlog39] Remove unnecessary commitCurrentLogUnit() call 
Change-Id: I1983095058d004476065328ad34bb9e325af7062
 2013-01-30 17:39:42 -08:00
Jean Chalard
af4a7e8c4b Create methods in LatinIME to make the current dict lists 
Bug: 7005813
Change-Id: I82232af8e3071333b6fd01e4453b6b3c0a3ddb1f
 2013-01-31 09:26:52 +09:00
Jean Chalard
3c67f6a2d0 Merge "Add a way to know externally if we're installing a new dict" 2013-01-31 00:19:23 +00:00
Jean Chalard
01a4ebcd88 Add a way to know externally if we're installing a new dict 
That helps tests know when to wait and when to declare the
dictionary actually not usable.

Bug: 7925814
Change-Id: Ic963c1206c43e3cde39ac4214a0d601f4fc6c03b
 2013-01-31 09:04:55 +09:00
Kurt Partridge
9c18a47162 Merge "[Rlog29] User interface for recording" 2013-01-30 16:40:03 +00:00
Kurt Partridge
4e049897ef Merge "[Rlog27] Add replay capability" 2013-01-30 14:38:16 +00:00
Tadashi G. Takaoka
e1f091c5d4 Add keyboardLetfPadding and keyboardRightPadding attributes 
This change splits keyboardHorizontalEdgesPadding attributes of
Keyboard into two attributes.

Change-Id: Iefdb358783b81af4027e8d9e991db36a6c429cf1
 2013-01-30 15:01:33 +09:00
Tadashi G. Takaoka
48409b9ac6 Merge "Remove "dimension|fraction" format from Key and Keyboard attributes" 2013-01-30 04:08:16 +00:00
Tadashi G. Takaoka
5ee2d79e41 Remove "dimension|fraction" format from Key and Keyboard attributes 
Change-Id: Ieec8b7f5ccdf2a57bcc539dcb5313b6353f926d7
 2013-01-30 13:01:14 +09:00
Kurt Partridge
faf35c323b [Rlog29] User interface for recording 
- Also, internal flag for automatically replaying after a recording is made (off by default)
- RLog key to "Bug?"

multi-project commit with I0c2fababd73eed5a341af487bca04ddd650d4cc2

Change-Id: I162c96a715de7180f276e08b4686a20f29dabafb
 2013-01-29 15:46:16 -08:00
Kurt Partridge
f3731188e5 [Rlog27] Add replay capability 
- Add support for replaying log files to the ResearchLogger.  This will let
  users preview data that they choose to upload.
- When the user explicitly requests that the system record their action, it
  will record everything up to, and including, the motion involved in shutting
  off the recording.  This change also removes the stop-recording motion
  commands.

Change-Id: Ib1df383bbf1881512cb111fab9f6749c25e436ba
 2013-01-29 09:33:25 -08:00
Tadashi G. Takaoka
3079b71964 Fix off-device regression test build 
Bug: 8093623
Change-Id: I775a8691bbedf58caef07d0b4af59c7444dd81be
 2013-01-29 23:02:08 +09:00
Jean Chalard
3d0477fbd2 Merge "Refactoring" 2013-01-29 10:29:25 +00:00
Jean Chalard
d515f134f7 Refactoring 
This creates a new DictionaryInfoUtils class and moves a bunch
of static methods there for later usage.

Change-Id: Iecb0643e6029a7be36bd6cb36aa918c40e6d8c6a
 2013-01-29 19:16:21 +09:00
Tadashi G. Takaoka
17dae3057c Remove {max,min}keyboardHeight attribute from Keyboard 
This change removes a DisplayMetrics reference from KeyboardBuilder.

Change-Id: I512694274e69e5281d5be47c3f938bcfd6571152
 2013-01-29 18:32:04 +09:00
Tadashi G. Takaoka
8630cd9d17 Remove keyboard layout description on the spacebar 
Bug: 8056376
Change-Id: I33f07e7a044c2b5fc20de40c7a9777dab493e41c
 2013-01-28 11:49:44 +09:00
Kurt Partridge
f77e9d7e3a Merge "Initialize ResearchLogger later to avoid NPE" 2013-01-25 17:17:34 +00:00
Jean Chalard
5228745ae0 Merge "Remove pending update messages upon starting a gesture" 2013-01-25 12:34:46 +00:00
Jean Chalard
a280e56014 Remove pending update messages upon starting a gesture 
Bug: 8064307
Change-Id: Ia623ab81b6d12eedc6b20bc4c1ce34ce72d5832f
 2013-01-25 17:00:41 +09:00
Tadashi G. Takaoka
ce875664e0 Clean up Settings and SettingsFragment a bit 
Change-Id: I93bf3cb1ea7e8fc09f4ad34b0bdd74f5f5ff1a68
 2013-01-25 16:23:29 +09:00
Kurt Partridge
63bc279596 Initialize ResearchLogger later to avoid NPE 
Change-Id: I1b817dfbdc319ac9bbf2f08e094a007849ce767f
 2013-01-24 11:13:20 -08:00
Tadashi G. Takaoka
52a0d491b4 Merge "Add preliminary graphics of sliding key input preview" 2013-01-24 09:23:28 +00:00
Tadashi G. Takaoka
ff961ddf8c Add preliminary graphics of sliding key input preview 
Bug: 7548583
Change-Id: Idde6a62f9e64458055c99c893b71c02d1adc7b04
 2013-01-24 18:14:20 +09:00
Tadashi G. Takaoka
12f2fc71f7 Merge "Display custom input style name in system locale" 2013-01-24 08:53:46 +00:00
Tadashi G. Takaoka
8203f7afe7 Display custom input style name in system locale 
Bug: 8032166
Change-Id: Ib9a6b63c4d540ce377892fb865e53abdd8adec16
 2013-01-24 17:44:49 +09:00
Tadashi G. Takaoka
f0b5fddcb8 Clean up SettingsFragment a bit 
Change-Id: Ic0727003f2645f0c38200b67bb2f4046249c6273
 2013-01-24 16:16:53 +09:00
Tadashi G. Takaoka
ef43cc9d1c Fix dismissing gesture floating preview 
Bug: 8063926
Change-Id: I3b5b29ea0d5e4833e10e830dbdb086c868cd4884
 2013-01-24 12:07:01 +09:00
Kurt Partridge
2baa4b0701 [Rlog83] Fix missing uses of hasWord() abstraction 
Change-Id: I78e286723b1b8c8bcc7aea0cc81ef2ee66a193ac
 2013-01-23 09:21:56 -08:00
Kurt Partridge
edb5c4638b Merge "[Rlog81a] Determine correction type of words" 2013-01-23 17:12:02 +00:00
Tadashi G. Takaoka
9d514af466 Merge "Refactor SubtypeLocale to hold Resources" 2013-01-23 08:37:57 +00:00
Tadashi G. Takaoka
9dc85a673e Merge "Configurable key long press timeout" 2013-01-23 08:37:36 +00:00
Tadashi G. Takaoka
cc5e4a4445 Configurable key long press timeout 
The default long presss timeout is 300msec (previous timeout was
400ms).

Bug: 7600340
Change-Id: Ia8b64784ac03588631cfcbad30e021d74f3fd0d8
 2013-01-23 17:12:28 +09:00
Satoshi Kataoka
f1074c508e Throw exception when invalid time stamps are detected in debug mode 
Change-Id: I360b5bd09869bc85ab3bccb8a43a20fed0035d9b
 2013-01-23 16:29:19 +09:00
Tadashi G. Takaoka
4b3cae9b0c Refactor SubtypeLocale to hold Resources 
Change-Id: Ia667bc2d406d66c87215dd3b9569f36f4642cfe0
 2013-01-23 16:23:11 +09:00
Tadashi G. Takaoka
40651c8cf7 Fix activity flags to launch settings activity 
This change adds the following flags to the intent to lauch settings activity.
 - Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED
 - Intent.FLAG_ACTIVITY_CLEAR_TOP

Bug: 8055342
Change-Id: I85284409bbba3fd284442e5ac4c7a55e58ad15ec
 2013-01-23 15:08:35 +09:00
Kurt Partridge
0c16a5c6ee [Rlog81a] Determine correction type of words 
Heuristic to determine whether a word was a typo correction or a complete
replacement by examining a correction to see if it falls within the list of
suggested words of the original.

Change-Id: Ieec4861a811e96aef0d14622e662b589ef8b4772
 2013-01-22 11:41:52 -08:00
Tadashi G. Takaoka
f008a11cce Merge "Cache MoreKeysKeyboard instead of container view of it" 2013-01-22 08:45:52 +00:00
Tadashi G. Takaoka
a729377395 Cache MoreKeysKeyboard instead of container view of it 
This change also cleans up MoreKeysPanel related stuff.

Bug: 8047165
Change-Id: I4f2211e00c7d08469a7413568db039c1c597fb3c
 2013-01-22 17:34:36 +09:00
Tadashi G. Takaoka
8028c1c523 Merge "SeekBarDialogPreference supports minValue and stepValue" 2013-01-22 07:40:48 +00:00
Tadashi G. Takaoka
c053293484 SeekBarDialogPreference supports minValue and stepValue 
Change-Id: I7aaeeb2db85103708747ae318610bd4896ef96fd
 2013-01-22 16:35:59 +09:00
Ken Wakasa
6c22439bf8 Remove MAX_PROXIMITY_CHARS_SIZE_INTERNAL 
Change-Id: I18a997503de4033b5341b564145bca862a872098
 2013-01-22 13:18:49 +09:00
Kurt Partridge
4cb853191c [Rlog15] ResearchLogger option to include account name in feedback 
multi-project commit with I0a293f392bd605c8203dc9a62993345ad58dcfbe

Change-Id: Ief5b940a62dbaeaecdf1c55f2ffdd1e0fdaea2b9
 2013-01-21 12:18:43 -08:00
Kurt Partridge
8b788374de Merge "[Rlog78b] Make log privacy filtering decisions on n-grams" 2013-01-21 19:39:38 +00:00
Kurt Partridge
80685aa4b9 [Rlog78b] Make log privacy filtering decisions on n-grams 
Previously, words were pushed out of a LogBuffer one at a time.  The receiving code had to keep
state to know whether a n-gram was safe to log.  This patch looks at the entire n-gram and makes a
single decision based on it alone.

mult-project commit with I3c40d7e02c77943d2668094ddb1d03efb942c74f

Change-Id: Id7d90bbd551b1a2f4e0e35f38852652f68f273f8
 2013-01-21 10:50:32 -08:00
Kurt Partridge
08d9c996dc Merge "[Rlog81b] Log more data with handleSeparator" 2013-01-21 18:48:16 +00:00
Tadashi G. Takaoka
fb523d7f5d Move AbstractDrawingPreview objects to MainKeyboardView 
Change-Id: I0be72fba9a66f7c326028ec8e4670ca74a46053f
 2013-01-21 23:25:18 +09:00
Tadashi G. Takaoka
2277733048 Merge "Add GestureTrailsPreview class" 2013-01-21 13:44:13 +00:00
Tadashi G. Takaoka
8673594830 Merge "Add SlidingKeyInputPreview class" 2013-01-21 13:43:41 +00:00
Tadashi G. Takaoka
470a5805e1 Add GestureTrailsPreview class 
Change-Id: Ibf9dff6d834d34b4134dbe38a609fd983731eedc
 2013-01-21 22:31:54 +09:00
Tadashi G. Takaoka
a237cd4a02 Add SlidingKeyInputPreview class 
Change-Id: Ided47b3420b0b1e34063f30d5142a1858af2718e
 2013-01-21 22:30:14 +09:00
Tadashi G. Takaoka
8aa9963a89 Fix Apache license comment 
Change-Id: Ic56167f952a7f4449da366e1e81610e72c966086
 2013-01-21 22:23:37 +09:00
Tadashi G. Takaoka
78292e45cb Fix missing super call in PreviewPlacerView.onDetachedFromWindow 
Change-Id: Iea79c0081cb66f54f161c0cf02cb365fcf88a07c
 2013-01-21 19:31:05 +09:00
Tadashi G. Takaoka
4987108f34 Add surrounding drawing view to AbstractDrawingPreview constructor 
Change-Id: If57e59f25fc3e29c0e7f46e8218d04fb233c27c6
 2013-01-21 18:48:06 +09:00
Tadashi G. Takaoka
820b5e079c Merge "Add PointerTracker.isOldestPointerInQueue" 2013-01-21 09:37:59 +00:00
Tadashi G. Takaoka
ab334eb646 Add PointerTracker.isOldestPointerInQueue 
Change-Id: Ic6f38253c94067ec7aa7b5add4452fa144fd9352
 2013-01-21 18:26:46 +09:00
Jean Chalard
b56260b891 [AD4] Actually copy the file in place. 
This finally makes it work.

Bug: 7702011

Change-Id: I3508c88567f79598e4d1dff561b6ba7dc5c3808f
 2013-01-21 17:58:38 +09:00
Tadashi G. Takaoka
db906a7c9a Merge "Rename AbstractDrawingPreview.onDraw to drawPreview" 2013-01-21 08:34:25 +00:00
Tadashi G. Takaoka
2ecbfe8e93 Rename AbstractDrawingPreview.onDraw to drawPreview 
This is because the android lint warns calling a method onDraw(Canvas)
from View.onDraw(Canvas).

Change-Id: I4f54996da5454d9a8c4ef43fbbcaec37724fb20e
 2013-01-21 17:00:47 +09:00
Tadashi G. Takaoka
f3c4cd45a5 Move dimming keyboard to MainKeyboardView 
Change-Id: Id44d4b758c8b92d1120d3a8b06812dc1fc26390c
 2013-01-21 16:54:08 +09:00
Jean Chalard
bde94dd96f Merge "[AD3] Implement the interface to choose a local dictionary" 2013-01-21 07:41:48 +00:00
Tadashi G. Takaoka
9c968b62d1 Move gesture related XML attribute to MainKeyboardView 
Change-Id: Ia12f73a3d7d26596ee14a0aff23244ef72753d68
 2013-01-21 16:16:48 +09:00
Tadashi G. Takaoka
375982106b Move PointerTracker.DrawingProxy to MainKeyboardView (step 2) 
Change-Id: If15d5ee683b8026d1871a3fe438dba498944faa7
 2013-01-21 16:09:25 +09:00
Tadashi G. Takaoka
0e4f0da449 Move PointerTracker.DrawingProxy to MainKeyboardView (step 1) 
Change-Id: I86014de147416453503b6412eb862a2d172426aa
 2013-01-21 16:06:50 +09:00
Jean Chalard
fbc5e9b334 [AD3] Implement the interface to choose a local dictionary 
Bug: 7702011
Change-Id: Id3b9c58dbbf5097e4d6ce986d20924eae19f9690
 2013-01-21 15:40:46 +09:00
Tadashi G. Takaoka
d9449ccf3c Move MoreKeysPanel.Controller implementation to MainKeyboardView 
Change-Id: Iffa298d51ca21a7dcd1e77c633217532d96d2cf5
 2013-01-21 15:28:17 +09:00
Tadashi G. Takaoka
b9f219c935 Remove unused Keyboard.purgeKeyboardAndClosing method 
Change-Id: Ia09ac04b0edca2a22d64ba83e054b115fe8851a6
 2013-01-21 14:26:33 +09:00
Kurt Partridge
80375649d3 [Rlog81b] Log more data with handleSeparator 
Change-Id: I4b2ebaa2398ac2f669e1e009e00842e55979e866
 2013-01-18 11:51:26 -08:00
Jean Chalard
1d15fe7e51 [AD2] Add a helper method to read an arbitrary dict header 
Bug: 7702011
Change-Id: Ib88f6dc222892831ae6932635b65fd2595b16b43
 2013-01-18 20:34:28 +09:00
Jean Chalard
babc71ee30 Merge "[AD1] Add an option to read an arbitrary dictionary." 2013-01-18 11:30:28 +00:00
Jean Chalard
fd80d1ad48 Merge "Deactivate h/w keyboard when not an internal build." 2013-01-18 11:28:24 +00:00
Jean Chalard
2e680c890d Merge "Trigger the set action when pressing hardware enter (C2)" 2013-01-18 11:18:32 +00:00
Jean Chalard
9058bc0df4 [AD1] Add an option to read an arbitrary dictionary. 
Bug: 7702011
Change-Id: I76f52dd3fdb22824fc243ab3845ceec610469c81
 2013-01-18 20:18:06 +09:00
Jean Chalard
2fc4d422e7 Deactivate h/w keyboard when not an internal build. 
The implementation is not really ready yet, so we want to
disable it for normal builds for now.
This goes together with Ic1edc6ed

Bug: 7987492
Change-Id: Id81f417e200c118f24424943823665f0b8bd6849
 2013-01-18 20:15:18 +09:00
Jean Chalard
b4ac04ae48 Trigger the set action when pressing hardware enter (C2) 
Bug: 7969231
Change-Id: I581212093df6f16fa9304e0b3e5b46714a7acdb3
 2013-01-18 20:03:38 +09:00
Jean Chalard
d5e869ced8 Merge "Track handled events to consistently return handled status (C1)" 2013-01-18 10:49:54 +00:00
Jean Chalard
976a42b873 Track handled events to consistently return handled status (C1) 
Bug: 5037589
Change-Id: I92d5be669420f0b2fdeb8fcf85aefd3961bf84b4
 2013-01-18 19:32:22 +09:00
Tadashi G. Takaoka
5d894dcfaa Merge "Correct GesturePreviewTrail.getWidth() implementation" 2013-01-18 10:26:05 +00:00
Tadashi G. Takaoka
f420e506a0 Merge "Add SeekBarDialogPreference" 2013-01-18 10:25:13 +00:00
Tadashi G. Takaoka
2df0cf2c5a Add SeekBarDialogPreference 
This change removes SeekBarDialog class.

Change-Id: I437b1e554a5af264b8031ebe05b8250a831c8d3b
 2013-01-18 19:10:55 +09:00
Tadashi G. Takaoka
41afa87a72 Merge "Remove automatic switch back to alphabet feature" 2013-01-18 10:03:02 +00:00
Tadashi G. Takaoka
cc2636b4e1 Remove automatic switch back to alphabet feature 
Change-Id: I4600c808f2ec31c18d3698a43afa7f4be9407e3e
 2013-01-18 18:44:27 +09:00
Tadashi G. Takaoka
9e63ef89e3 Correct GesturePreviewTrail.getWidth() implementation 
Bug: 7981153
Change-Id: I20785b7f82329ce6f19c883e77a9716772cda290
 2013-01-18 17:55:24 +09:00
Jean Chalard
81a4b7f48e Merge "Fix a bug in gesture after a dash or apostrophe" 2013-01-18 08:39:58 +00:00
Jean Chalard
889a5e1430 Merge "Reset forgotten members (D3)" 2013-01-18 07:46:41 +00:00
Jean Chalard
e3ec5fcc88 Fix a bug in gesture after a dash or apostrophe 
It would insert a space when it shouldn't when composing a
word ending in either dash or apostrophe and gesturing right
away.

Bug: 7889078
Change-Id: Ib3e2f6f5e551888cc081b464a641e2deac6f5ef7
 2013-01-18 15:05:34 +09:00
Jean Chalard
5a6b4f953e Merge "Insert into user dict in lower case if auto-caps (D2)" 2013-01-18 05:39:18 +00:00
Kurt Partridge
345ef67627 [Rlog78a] Annotate logUnits with corrections 
If the user makes a correction to a word, this is now explicitly indicated
in the logUnit.

Change-Id: I8638aadd7b8c8e32bbc9c4b020548d786513d887
 2013-01-17 14:05:02 -08:00
Kurt Partridge
e6a9655a03 Merge "Consolidate SuggestedWords.getWordInfo and .getInfo" 2013-01-17 22:01:26 +00:00
Kurt Partridge
937877b877 Merge "[Rlog14] Increase feedback buffer to cover whole session" 2013-01-17 21:21:49 +00:00
Kurt Partridge
63ed9abbe8 Merge "[Rlog13] ResearchLogger fix feedback" 2013-01-17 19:56:25 +00:00
Kurt Partridge
f881f10e90 Merge "Fix commit partial text logStatement" 2013-01-17 19:15:32 +00:00
Kurt Partridge
34ecd12a05 Merge "Add comment" 2013-01-17 17:50:42 +00:00
Kurt Partridge
b5ac8ef586 Consolidate SuggestedWords.getWordInfo and .getInfo 
Change-Id: I959cf049f550b7be3ec002281ca7457e566b0214
 2013-01-17 07:50:15 -08:00
Kurt Partridge
5213559e0e Fix commit partial text logStatement 
- No longer suggests that it is called from a non-existent method
  in RichInputConnection

Change-Id: I25fe4a0f232a4320ca113598bbcdd029ca319944
 2013-01-17 07:46:06 -08:00
Jean Chalard
8914555776 Reset forgotten members (D3) 
Only resetting mCapitalizedMode is enough to fix bug#8013488,
but we may as well correctly reset both fields.

Bug: 8013488
Change-Id: Icb0d7c5b1e93368e8eb7848aa9137b45d5d3531e
 2013-01-17 20:39:09 +09:00
Jean Chalard
96845ecff6 Insert into user dict in lower case if auto-caps (D2) 
Also recapitalize afterwards if the word has been changed.

Bug: 7972124
Change-Id: I9306580bb4ed0ffa80cc4559ce1abcd2034d1905
 2013-01-17 20:38:52 +09:00
Jean Chalard
c665cbee7f Merge "Forward the capitalized mode to the positional info (D1)" 2013-01-17 11:02:00 +00:00
Jean Chalard
15ea1d4096 Merge "Simplify the space-before and space-after logic." 2013-01-17 09:07:20 +00:00
Jean Chalard
ae3b96b26e Simplify the space-before and space-after logic. 
Bug: 7889078
Bug: 7268000
Change-Id: I6c77b8c9e60ef69f02526b407124d2f5d02818ee
 2013-01-17 17:52:46 +09:00
Tadashi G. Takaoka
40c59727cf Merge "Add default button to vibration/volume settings dialog" 2013-01-17 08:41:01 +00:00
Tadashi G. Takaoka
1b1fa7a18b Merge "SeekBarDialog supports neutral and dismiss listener" 2013-01-17 08:27:27 +00:00
Jean Chalard
22959faad4 Merge "Stop relying on the soft keyboard to get the editor action." 2013-01-17 07:16:58 +00:00
Jean Chalard
b6b7f5e39e Forward the capitalized mode to the positional info (D1) 
Bug: 7972124
Change-Id: I3c74f3b075e698b9e9dd1d2c7b6f173073539063
 2013-01-17 14:35:58 +09:00
Kurt Partridge
7f8c096bf2 [Rlog13] ResearchLogger fix feedback 
The feedback string was not being inserted in the feedback logs.  Also changed the tag to
"UserFeedback" from "UserTimestamp" to better reflect the data recorded.

Change-Id: Iccf781b25e2573168c36e729419468f5bd73903e
 2013-01-16 21:29:51 -08:00
Tadashi G. Takaoka
84ce64f2c0 Fix bounding rectangle of gesture preview trail 
Bug: 7917443
Bug: 7987585
Change-Id: I99e6db1fe43d3a9b497e92330a6857e0454c428c
 2013-01-16 19:51:01 +09:00
Jean Chalard
d818f1e3b6 Stop relying on the soft keyboard to get the editor action. 
Bug: 7969231
Change-Id: I9848c63c4c51550b5dc53c981eafa74e7fa95197
 2013-01-16 18:22:00 +09:00
Kurt Partridge
14b800d858 [Rlog14] Increase feedback buffer to cover whole session 
Change-Id: I55b61d9ca6eecd56181b8d2913f71559555cd89e
 2013-01-15 18:34:13 -08:00
Kurt Partridge
9579936bcf [Rlog67] Renaming clarification 
ResearchLogger.latinIME_handleSeparator wasn't doing anything really specific to
the separator, so its implementation has been renamed according to its role.

Change-Id: I24e8691c7dc440dd067e96d23e50463683e17cfc
 2013-01-15 08:57:52 -08:00
Jean Chalard
dcfceaff1b Distinguish action-enter/shift-enter/enter 
Bug: 7969231
Change-Id: I75d495ee1ea126da9be4e269ee990ee0a97793c1
 2013-01-15 19:12:41 +09:00
Ken Wakasa
c995dbcf59 Merge "Remove MAX_WORD_LENGTH_INTERNAL" 2013-01-14 19:46:09 -08:00
Ken Wakasa
5db594abba Remove MAX_WORD_LENGTH_INTERNAL 
Change-Id: Ie11ff000675601acff5fbb00e9e9f48eb32c5071
 2013-01-15 12:39:08 +09:00
Tadashi G. Takaoka
722eeb144f Fix drawing Arabic diacritics 
Bug: 8001868
Change-Id: I0e5aab266bbaad8c68e4a900b8d5572977a0379d
 2013-01-15 11:03:15 +09:00
Kurt Partridge
019bcc62b9 Merge "[Rlog68] Logger; make filenames more unique to prevent filesys conflicts" 2013-01-14 10:02:16 -08:00
Kurt Partridge
5b611e184b Merge "[Rlog63] Log whether a manual suggestion is a prediction" 2013-01-14 09:30:12 -08:00
Kurt Partridge
0a292ad883 Add comment 
Change-Id: If21222aa678a827c1fcad5cacac0fa20655e4e5e
 2013-01-14 09:08:51 -08:00
Kurt Partridge
939e3f3152 Merge "[Rlog59d] Pass separatorString through revertCommit" 2013-01-14 08:59:04 -08:00
Kurt Partridge
67a61fc6be [Rlog68] Logger; make filenames more unique to prevent filesys conflicts 
multi-project commit with If6b9f8990d7cdbf570740a81096513698d0e0f4c

Change-Id: I124aed24be0beb4c472869594184ecf003c2fed4
 2013-01-14 07:11:42 -08:00
Kurt Partridge
31156c816e [Rlog59d] Pass separatorString through revertCommit 
Change-Id: I5ef20476318979f99f543f9300cf6198d18f6244
 2013-01-14 07:01:49 -08:00