Commit Graph

9733 Commits (c7f41139bcbd7e2dd92cb5be599d9cf9cff1f173)

Author SHA1 Message Date
Jean Chalard ac84fe642e [IL106] Inline a now useless method.
Bug: 8636060
Change-Id: Ic8e0225206358680aa0de421f17ab443c888036d
2014-01-29 12:23:40 +09:00
Jean Chalard fa7075768d [IL105] Remove more useless arguments
Bug: 8636060
Change-Id: I9e817bb9622c84544a5ca8708e5c1fccad1ed447
2014-01-29 12:23:26 +09:00
Jean Chalard 084c9961f4 [IL104] Remove useless arguments
Bug: 8636060
Change-Id: I97a371fe0c6227eb0f03d3e391a33726e6280322
2014-01-29 12:23:25 +09:00
Jean Chalard 1d2e4f9dcc [IL103] Save the typed word separately in SuggestedWords.
This helps managing the cases where the typed word is not
in the suggestions. This happens during recorrection.

Bug: 8636060
Change-Id: I6784feb793cae96272a7f1d123a0e3bbb8f03143
2014-01-29 12:22:21 +09:00
Tadashi G. Takaoka a454a7b85c Add method to clear user history dictionary for testing
This change should be checked in together with I19cd689157.

Bug: 12179576
Change-Id: I5cc9f52a37ad6623809a14575f3f4b1cd18725c3
2014-01-29 12:01:37 +09:00
Tadashi G. Takaoka 937bd8a541 am 005d2454: Merge "Remove suggestion_word and suggestion_info layout files"
* commit '005d2454c97400bef3da7961267fe6b943da5833':
  Remove suggestion_word and suggestion_info layout files
2014-01-28 17:07:51 -08:00
Tadashi G. Takaoka 005d2454c9 Merge "Remove suggestion_word and suggestion_info layout files" 2014-01-29 01:05:37 +00:00
Yohei Yukawa dfcc8b9443 am be18530a: Merge "Fix inconsistent behavior with the back-to-the-main-keyboard key"
* commit 'be18530acfc3364aa77dda8184318311c4fb60f2':
  Fix inconsistent behavior with the back-to-the-main-keyboard key
2014-01-28 02:52:23 -08:00
Yohei Yukawa be18530acf Merge "Fix inconsistent behavior with the back-to-the-main-keyboard key" 2014-01-28 10:50:23 +00:00
Tadashi G. Takaoka c2ea3f7dd9 Remove suggestion_word and suggestion_info layout files
Change-Id: I37fea41cfc6e717ce7e5aa36ad331675fc9e8ce5
2014-01-28 19:38:35 +09:00
Yohei Yukawa 576f8a5b72 Fix inconsistent behavior with the back-to-the-main-keyboard key
With this patch, the back-to-the-main-keyboard in the Emoji
palette will be registered as a key-release action instead of
a key-press action, like switch-to-the-emoji-palette in the
main layout. This provides mroe consistent UX when the layout is
switched from the main layout to the Emoji palette then
switched back to the main layout.

BUG: 12464067
Change-Id: Ia0d0185db43234dfcfb7cee2677f3d199fe6ed96
2014-01-28 19:30:27 +09:00
Jean Chalard 1fe68195bd am 9c034480: Merge "[IL102] Rename a method"
* commit '9c0344801bd05ab56c3cb70bd32e77747a264627':
  [IL102] Rename a method
2014-01-28 01:45:40 -08:00
Jean Chalard bb4280669a am 67d85f66: Merge "[IL101] Remove a method"
* commit '67d85f663aaad5b14acf089ef0f62a5293d485c1':
  [IL101] Remove a method
2014-01-28 01:45:38 -08:00
Jean Chalard fc12004571 am 9214f17b: Merge "[IL100] Pull up a check"
* commit '9214f17b862aa6b35dcda15ad14d3604e90988bb':
  [IL100] Pull up a check
2014-01-28 01:45:35 -08:00
Jean Chalard ec725d1421 am 28196662: Merge "[IL99] Migrate some code to InputLogic."
* commit '281966621705caf9240af4156e62d26d43d40ccb':
  [IL99] Migrate some code to InputLogic.
2014-01-28 01:36:59 -08:00
Jean Chalard 6cf9d44119 am 675f1dba: [IL98] Refactoring of setSuggestedWords
* commit '675f1dbaf0c9a2e01fe04c07ceb23f6b79721fd0':
  [IL98] Refactoring of setSuggestedWords
2014-01-28 00:24:31 -08:00
Jean Chalard dbd7915611 am eb00023b: [IL97] Readability improvement
* commit 'eb00023b9b12e3b42bfd080157066a0f0b39f934':
  [IL97] Readability improvement
2014-01-28 00:24:28 -08:00
Jean Chalard c9cc1b1de5 [IL102] Rename a method
Bug: 8636060
Change-Id: Ia54afdfab9124aa5c35699e357e63eae66a7557f
2014-01-28 17:18:02 +09:00
Jean Chalard 4500dedfa9 [IL101] Remove a method
Bug: 8636060
Change-Id: Ic9c12fc6970987b0e1912e8ae85bed55260d66b5
2014-01-28 17:18:02 +09:00
Jean Chalard 491a6a6f23 [IL100] Pull up a check
Bug: 8636060
Change-Id: I344ed59f5f55b412880fc6dc70205eecb1e79961
2014-01-28 17:18:01 +09:00
Jean Chalard 4761d2fb00 [IL99] Migrate some code to InputLogic.
Bug: 8636060
Change-Id: Ibf1f9c7bdc3fdd872d6c15447fa555434485cc52
2014-01-28 17:18:01 +09:00
Jean Chalard 675f1dbaf0 [IL98] Refactoring of setSuggestedWords
Bug: 8636060
Change-Id: Iab53df96f2c23bddc6c70c3560b380fbaef1053c
2014-01-28 17:18:01 +09:00
Jean Chalard eb00023b9b [IL97] Readability improvement
Bug: 8636060
Change-Id: I6b15c7fb91cd4cf23a993541c19842b51e328f8f
2014-01-28 17:17:58 +09:00
Tadashi G. Takaoka a15565eca6 am 95e5e267: Merge "Suggestion strip honors RTL layout"
* commit '95e5e267ac1aca7c5a7db2ceea96716437c6b2fe':
  Suggestion strip honors RTL layout
2014-01-27 23:53:32 -08:00
Tadashi G. Takaoka 95e5e267ac Merge "Suggestion strip honors RTL layout" 2014-01-28 07:52:25 +00:00
Keisuke Kuroyanagi 927437177d am 25270ec5: Merge "Check probability before adding to the user history dict."
* commit '25270ec5405a8221a2e69acf86d70e46783be56d':
  Check probability before adding to the user history dict.
2014-01-27 23:38:09 -08:00
Keisuke Kuroyanagi 25270ec540 Merge "Check probability before adding to the user history dict." 2014-01-28 07:35:31 +00:00
Jean Chalard a2129ea38b am 36fda2ba: Merge "[IL96] Inline a method"
* commit '36fda2bae38a8bf6b07c449f63af817cdde72de5':
  [IL96] Inline a method
2014-01-27 23:34:54 -08:00
Jean Chalard c03fd7bac4 am 7593f935: Merge "[IL95] Inline a method that\'s always called in sequence"
* commit '7593f93565766be82365ba4af8d947e7b5e08a50':
  [IL95] Inline a method that's always called in sequence
2014-01-27 23:34:51 -08:00
Jean Chalard 36fda2bae3 Merge "[IL96] Inline a method" 2014-01-28 07:31:48 +00:00
Keisuke Kuroyanagi 90ac041c9f Check probability before adding to the user history dict.
Bug: 12764888
Change-Id: I5da3ef21d9d82b7034e7dc9b7d0fdca0d48a49f4
2014-01-28 16:31:37 +09:00
Jean Chalard 7593f93565 Merge "[IL95] Inline a method that's always called in sequence" 2014-01-28 07:31:31 +00:00
Tadashi G. Takaoka bcd30bf3e7 Suggestion strip honors RTL layout
Bug: 9126496
Change-Id: Ia4a1c52bd2a80ea7fe6b9529f2767fee5f9e8aeb
2014-01-28 15:47:54 +09:00
Jean Chalard 86210c7dc7 [IL96] Inline a method
Bug: 8636060
Change-Id: I517591c484dce74788398cf4a4db9a074d91a6c0
2014-01-28 15:47:04 +09:00
Jean Chalard 90916143b6 [IL95] Inline a method that's always called in sequence
Bug: 8636060
Change-Id: I514cf14596b3fa46eccadcf536342e4bb805708d
2014-01-28 15:47:01 +09:00
Tadashi G. Takaoka 61ba174e16 am 02b08709: Merge "Fix test fails caused by I8bede13c87"
* commit '02b087090e9a4fe1a388bd18939711f988931744':
  Fix test fails caused by I8bede13c87
2014-01-27 21:22:47 -08:00
Tadashi G. Takaoka 02b087090e Merge "Fix test fails caused by I8bede13c87" 2014-01-28 05:19:53 +00:00
Yohei Yukawa a04ead80d7 am 02725535: Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete."
* commit '02725535784e03c3d6789251569204d2e397000f':
  Fix inconsistent behavior with the spacebar on the Emoji pallete.
2014-01-27 21:08:47 -08:00
Yohei Yukawa 0272553578 Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete." 2014-01-28 05:06:07 +00:00
Yohei Yukawa 0e04c24a05 Fix inconsistent behavior with the spacebar on the Emoji pallete.
On the Emoji palette, unlike other layouts, a user could not
cancel events by moving the finger away from the spacebar.

With this patch, the actual handler of the spacebar will be
registered as onClick event, which will not occur when the user
cancel the event.

Bug: 12464067
Change-Id: I7e7e11ae5f17073e5d92116adca0702579d3ae9c
2014-01-28 13:44:31 +09:00
Jean Chalard 4b5e56d648 am ca1c1ddd: Merge "[IL94] Remove a function and some reordering"
* commit 'ca1c1ddd4ecdca1a863dbf8274dca2fc3e91a8ac':
  [IL94] Remove a function and some reordering
2014-01-27 19:48:05 -08:00
Jean Chalard ca1c1ddd4e Merge "[IL94] Remove a function and some reordering" 2014-01-28 03:46:28 +00:00
Jean Chalard 43502ea3ba am 9909d6aa: Merge "[IL93] Refactor a method inside another"
* commit '9909d6aa49ea17b6dd391a48e2ad29be11006249':
  [IL93] Refactor a method inside another
2014-01-27 19:34:07 -08:00
Jean Chalard d5259d578b am cbf54dea: Merge "[IL92] Straighten out showSuggestionStripWithTypedWord"
* commit 'cbf54dea49151e3d8a8dff5074d289ce38dd0698':
  [IL92] Straighten out showSuggestionStripWithTypedWord
2014-01-27 19:34:05 -08:00
Jean Chalard 9909d6aa49 Merge "[IL93] Refactor a method inside another" 2014-01-28 03:32:52 +00:00
Jean Chalard cbf54dea49 Merge "[IL92] Straighten out showSuggestionStripWithTypedWord" 2014-01-28 03:32:17 +00:00
Jean Chalard ba122b291b am 5a1f8373: Merge "[IL91] Call reorder"
* commit '5a1f837356673f04fd68dea8f0b084dc9de7db33':
  [IL91] Call reorder
2014-01-27 19:28:41 -08:00
Jean Chalard 5a1f837356 Merge "[IL91] Call reorder" 2014-01-28 03:26:23 +00:00
Tadashi G. Takaoka 9ac6c9064d Fix test fails caused by I8bede13c87
Change-Id: I1e816bf7ea5fd46b39c2482bbcbfcdc16d5acc21
2014-01-28 11:17:47 +09:00
Tadashi G. Takaoka a4d04eb863 am c2e2b394: Merge "Add SubtypeLocaleUtils.isRtlLanguage method"
* commit 'c2e2b3949b159d6412e0e5815c1503d94b2b5ce7':
  Add SubtypeLocaleUtils.isRtlLanguage method
2014-01-27 17:30:14 -08:00
Tadashi G. Takaoka c2e2b3949b Merge "Add SubtypeLocaleUtils.isRtlLanguage method" 2014-01-28 01:28:47 +00:00
Baligh Uddin 16a9bb3da8 Import translations. DO NOT MERGE
Change-Id: I9632cf713ad9e1bba1df5819c4038739229f7ec2
Auto-generated-cl: translation import
2014-01-27 14:42:02 -08:00
Baligh Uddin 92b67fc32b Import translations. DO NOT MERGE
Change-Id: I4aa5b70b2bb231583501347c69dba7172aa975cb
Auto-generated-cl: translation import
2014-01-27 14:40:58 -08:00
Jean Chalard 5b5e877efe [IL94] Remove a function and some reordering
Bug: 8636060
Change-Id: I4baa237c9c7b58a8eb4158c34b9d3f3dfb95c69c
2014-01-27 20:38:45 +09:00
Jean Chalard 37e1cc931f [IL93] Refactor a method inside another
The calls to setAutoCorrectionIndicator with a constant are
always the exact same as mWillAutoCorrect.

Bug: 8636060
Change-Id: I8106919819b978b0a9655af2ef444664fad4c1ad
2014-01-27 20:38:45 +09:00
Jean Chalard 4c6029e530 [IL92] Straighten out showSuggestionStripWithTypedWord
Bug: 8636060
Change-Id: I066ff29c76349f0ab61441ea5f7bc9085d24bdbc
2014-01-27 20:38:45 +09:00
Jean Chalard c6367ee64d [IL91] Call reorder
Bug: 8636060
Change-Id: I3d0ce6dcb3b51cabc424d00a397d243c32360e92
2014-01-27 20:38:43 +09:00
Jean Chalard b3b2676c4a am 01893b25: Merge "[IL90] Small refactoring"
* commit '01893b25dd25266d14c38d892176fbda052e1812':
  [IL90] Small refactoring
2014-01-27 03:22:08 -08:00
Jean Chalard efef6d87e9 am 3f226af4: Merge "[IL89] Inline a function"
* commit '3f226af439700e9e01eabf7280a5c366e10a3d74':
  [IL89] Inline a function
2014-01-27 03:22:06 -08:00
Jean Chalard 2a36d9bf3b am 5b9e54c1: Merge "[IL88] Simple refactoring"
* commit '5b9e54c135cb1fa2ca1a5b5967a7934b789a8ed4':
  [IL88] Simple refactoring
2014-01-27 03:22:03 -08:00
Jean Chalard 925f8fcf88 am 8f3e37a6: Merge "[IL87] Remove a call to clearSuggestionStrip"
* commit '8f3e37a63187f4fb2731f629472037a373796097':
  [IL87] Remove a call to clearSuggestionStrip
2014-01-27 03:22:01 -08:00
Jean Chalard 01893b25dd Merge "[IL90] Small refactoring" 2014-01-27 11:18:52 +00:00
Jean Chalard 38f4272ade am 521a83a3: Merge "[IL86] Simplification and correctness fix."
* commit '521a83a3f122d02d24317540fd7bafb1918acb08':
  [IL86] Simplification and correctness fix.
2014-01-27 03:18:40 -08:00
Jean Chalard ddfce8b7c4 am 7aa7e366: Merge "[IL85] Maybe show punctuations when app completions are null"
* commit '7aa7e3661117ab60d85b4d4ce83167073c370bec':
  [IL85] Maybe show punctuations when app completions are null
2014-01-27 03:18:37 -08:00
Jean Chalard 9cc7238f71 am 264f4e38: Merge "[IL84] Remove a useless call and rename a method"
* commit '264f4e380dd496b156914a47089bd26b9eba1cb6':
  [IL84] Remove a useless call and rename a method
2014-01-27 03:18:34 -08:00
Jean Chalard 1ced9e6ddc am 7ac542d4: Merge "[IL83] Inline a call"
* commit '7ac542d490b4761837733d1732a8e6ca8c097739':
  [IL83] Inline a call
2014-01-27 03:18:32 -08:00
Jean Chalard 3f226af439 Merge "[IL89] Inline a function" 2014-01-27 11:18:19 +00:00
Jean Chalard 5b9e54c135 Merge "[IL88] Simple refactoring" 2014-01-27 11:17:54 +00:00
Jean Chalard 8f3e37a631 Merge "[IL87] Remove a call to clearSuggestionStrip" 2014-01-27 11:17:45 +00:00
Jean Chalard 521a83a3f1 Merge "[IL86] Simplification and correctness fix." 2014-01-27 11:17:31 +00:00
Jean Chalard 7aa7e36611 Merge "[IL85] Maybe show punctuations when app completions are null" 2014-01-27 11:17:18 +00:00
Jean Chalard 264f4e380d Merge "[IL84] Remove a useless call and rename a method" 2014-01-27 11:17:05 +00:00
Jean Chalard 7ac542d490 Merge "[IL83] Inline a call" 2014-01-27 11:16:30 +00:00
Jean Chalard 2e7f0680ad am 47ff4231: Merge "[IL82] Fix a wrong comment"
* commit '47ff423121ce9d584cb4c71295ff42b275552214':
  [IL82] Fix a wrong comment
2014-01-27 02:13:37 -08:00
Jean Chalard 0256b15d3a am 75ec579e: Merge "[IL81] Remove a useless test."
* commit '75ec579e07ccb598970bc800db2d9f2dac11ec7a':
  [IL81] Remove a useless test.
2014-01-27 02:13:35 -08:00
Jean Chalard 47ff423121 Merge "[IL82] Fix a wrong comment" 2014-01-27 10:11:42 +00:00
Jean Chalard 75ec579e07 Merge "[IL81] Remove a useless test." 2014-01-27 10:11:14 +00:00
Tadashi G. Takaoka c0c74d22a0 Add SubtypeLocaleUtils.isRtlLanguage method
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
2014-01-27 19:05:16 +09:00
Jean Chalard 7f1a5c4d9b am 6d1c8b2c: Merge "Try to figure out whether d.quotes open or close."
* commit '6d1c8b2c3f78969866db7f718e7e8d2be240f674':
  Try to figure out whether d.quotes open or close.
2014-01-27 02:02:44 -08:00
Jean Chalard a8b37414f8 am b084da2a: Merge changes I5092942a,I931c553f
* commit 'b084da2ae6622488779ddb3a66081610bfe96a66':
  [IL80] Reverse a test for clarity.
  [IL79] Some refactoring
2014-01-27 02:02:42 -08:00
Jean Chalard 6d1c8b2c3f Merge "Try to figure out whether d.quotes open or close." 2014-01-27 10:01:17 +00:00
Jean Chalard b084da2ae6 Merge changes I5092942a,I931c553f
* changes:
  [IL80] Reverse a test for clarity.
  [IL79] Some refactoring
2014-01-27 10:00:37 +00:00
Jean Chalard f58a96c977 am a3a85e8c: Merge "[IL78] Move most of onUpdateSelection to InputLogic."
* commit 'a3a85e8c2bcab6ff9b00fda52e3ba0c666055951':
  [IL78] Move most of onUpdateSelection to InputLogic.
2014-01-27 01:57:15 -08:00
Jean Chalard a3a85e8c2b Merge "[IL78] Move most of onUpdateSelection to InputLogic." 2014-01-27 09:55:08 +00:00
Jean Chalard d38b0468b0 [IL90] Small refactoring
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
2014-01-27 18:42:33 +09:00
Jean Chalard 33ff321d6c [IL89] Inline a function
We will then refactor the contents of showSuggestionStripWithTypedWord

Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
2014-01-27 18:42:33 +09:00
Jean Chalard ca819178a1 [IL88] Simple refactoring
With this, the value passed to suggestedWords is never null.

Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
2014-01-27 18:42:33 +09:00
Jean Chalard d90bdd2187 [IL87] Remove a call to clearSuggestionStrip
The goal is to remove the function completely.

Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
2014-01-27 18:42:33 +09:00
Jean Chalard 3b939ed77f [IL86] Simplification and correctness fix.
This should be what was intended.

Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
2014-01-27 18:42:33 +09:00
Jean Chalard 07eddf3c43 [IL85] Maybe show punctuations when app completions are null
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.

Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
2014-01-27 18:42:32 +09:00
Jean Chalard b2c0388a69 [IL84] Remove a useless call and rename a method
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
2014-01-27 18:42:32 +09:00
Jean Chalard eb190ab32f [IL83] Inline a call
The coming string of changes is very complicated, so
I'm going to do things really slowly.

Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
2014-01-27 18:42:32 +09:00
Jean Chalard 17f1528f9e [IL82] Fix a wrong comment
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
2014-01-27 18:42:32 +09:00
Jean Chalard abbd755689 [IL81] Remove a useless test.
It seems the comments were right all along. This seems to really
be useless.

Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
2014-01-27 18:42:32 +09:00
Jean Chalard f1e5b9b4d1 [IL80] Reverse a test for clarity.
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
2014-01-27 18:42:32 +09:00
Jean Chalard f59487379e [IL79] Some refactoring
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
2014-01-27 18:42:29 +09:00
Jean Chalard 10460441db [IL78] Move most of onUpdateSelection to InputLogic.
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
2014-01-27 18:42:04 +09:00
Tadashi G. Takaoka c8bddebf1a am 1e4b1300: Merge "Refactor SuggestionsStripLayoutHelper class"
* commit '1e4b1300e65095ca4b064afb5590d4bc02ff7725':
  Refactor SuggestionsStripLayoutHelper class
2014-01-27 01:39:02 -08:00
Tadashi G. Takaoka 1e4b1300e6 Merge "Refactor SuggestionsStripLayoutHelper class" 2014-01-27 09:36:52 +00:00
Jean Chalard d7c3ceac59 am 68d7291a: Merge "[IL77] Remove refs to Settings from InputLogic"
* commit '68d7291a6bdc1d5633d744759a5c76599499d9e9':
  [IL77] Remove refs to Settings from InputLogic
2014-01-27 01:35:46 -08:00