Commit Graph

1463 Commits (c4518d54ac96f67b440645e1d615a0ee00a241a0)

Author SHA1 Message Date
Tadashi G. Takaoka a6d3a4d61b Make action key background more visually prominent
Bug: 5232726
Change-Id: I76ff2fb431ca295693ceb231a0f13da44f9293e6
2011-09-15 17:40:44 +09:00
Jean Chalard 39fe5bfc3c Merge "Avoid returning an object that's still used internally" 2011-09-15 00:28:19 -07:00
Jean Chalard 5c08151c22 Avoid returning an object that's still used internally
There is no definite path known for this to end up being
touched by other classes, but we could imagine through
some way or some other it ends up shoved in the stringbuilder
pool, leading to catastrophic results.

Hopefully related to
Bug: 5248688

Change-Id: Ib8abfc31263cbf31d515ed607ced5d8253971938
2011-09-15 16:23:03 +09:00
Jean Chalard b568a627b4 Merge "Don't kill LatinIME if the spellchecker crashes." 2011-09-15 00:13:45 -07:00
Jean Chalard 199dc5e0e4 Don't kill LatinIME if the spellchecker crashes.
If the spellchecker encounters a bug and happens to crash,
it may be sensible to avoid killing the keyboard in response.
This is a possible way to do it, which comes with the big
drawback of making bugs in the spell checker harder to find.

Change-Id: Idb26fb592b9718e1dbdadeda8fbd1a8a1d805c28
2011-09-15 16:01:21 +09:00
Tadashi G. Takaoka 7918ed0169 Refactor Key.isFunctional to more generic Key.keyType
Bug: 5232726
Change-Id: Idc861ca725f62eaf37795f57401573394a17d6d3
2011-09-15 14:38:45 +09:00
satok fa52a09f21 Merge "Remove experimental settings" 2011-09-14 02:57:58 -07:00
Jean Chalard d2738757d2 Merge "Filter out of spellchecking words that don't look like words" 2011-09-14 02:05:48 -07:00
Jean Chalard 88fa53b840 Filter out of spellchecking words that don't look like words
Note that this affects only the results of the spell checker if
actually passed such a word. For example, the spell checker will
not flag "http://oju" as a typo, because it looks like a URL.
But in the current implementation, TextView passes "http" and
"oju" separately, so "oju" is still flagged as a typo.

Bug: 5281875
Change-Id: I9d721fd3af34edc51b11908cf2e8fe994b164242
2011-09-14 17:46:06 +09:00
satok c9c54a84bc Remove experimental settings
Bug: 5314288
Change-Id: I31cbc6da0ca5e61a5fa4a893c774f2110a5698f1
2011-09-14 16:24:39 +09:00
Jean Chalard 1586dc6edf Merge "Fix a bug where the user dict's locale match would be wrong" 2011-09-13 23:44:44 -07:00
Jean Chalard d97def5925 Fix a bug where the user dict's locale match would be wrong
This is preparation for
Bug: 5280929

Change-Id: Iab0096acf057aa288b1986d225aad815bd70b145
2011-09-14 15:41:46 +09:00
Jean Chalard 63e55cd55e Don't report 1-char words as typos
Bug: 5281875
Change-Id: If6b6d057e18390bf01dcd31c46104b6856fbdbda
2011-09-13 21:45:19 +09:00
Tadashi G. Takaoka ea843f2a24 Make WordComposer aware of capitalized word
Change-Id: If6c0edef2334f018f2e04c6034f8ce747206f150
2011-09-13 19:11:10 +09:00
Tadashi G. Takaoka 6602b03e80 Merge "Linger the "more suggestions" when the user is sliding the touch point" 2011-09-12 21:33:14 -07:00
Tadashi G. Takaoka 02ce5392f5 Merge "Dismiss the more suggestions when the user is sliding down the touch point" 2011-09-12 21:32:40 -07:00
Tadashi G. Takaoka 87104bace9 Dismiss the more suggestions when the user is sliding down the touch point
Bug: 5299142
Change-Id: I466ff41948bbb49fb6874817ecfd94d338238d19
2011-09-13 13:03:50 +09:00
Tadashi G. Takaoka 2abd8547e3 Linger the "more suggestions" when the user is sliding the touch point
Bug: 5299024
Change-Id: I00b5e59ba480cbf057bdd69d1357d2c477be90f7
2011-09-13 13:03:24 +09:00
Tadashi G. Takaoka 697bf585f8 Update suggestions strip text color
Bug: 5287964
Change-Id: Ic40bb656873f41bb6d65427f02399464e831aab2
2011-09-13 12:54:59 +09:00
Tadashi G. Takaoka 4486d77270 Introduce autoXScale label option
Bug: 5267649
Change-Id: I7fdcb98c209b7ccf73075ef3a4e758782fe161e3
2011-09-12 17:32:28 +09:00
Jean Chalard f5ef30dfc6 Have the spell checker honor case
Bug: 5281103
Change-Id: I415c84dbb55f1eeb5deb9f248b4056881982ee13
2011-09-12 12:25:25 +09:00
satok 53bbf4da5a Merge "Remove the exception in SubtypeSwitcher" 2011-09-09 02:49:18 -07:00
satok 1ecf0fb5d7 Remove the exception in SubtypeSwitcher
Bug: 5261455

Change-Id: Idb070702418caeb6cb975849d71b39952ac4afab
2011-09-09 18:44:48 +09:00
Jean Chalard a40aba0022 Merge "Fix an NPE" 2011-09-09 02:18:11 -07:00
Jean Chalard 5955cfdaea Fix an NPE
I think only the monkey can realistically stumble on this one,
but still.

Bug: 5276917
Change-Id: I0d9f76e4786973d3695fcd46127f0bed46621c33
2011-09-09 18:08:53 +09:00
Tadashi G. Takaoka f01ba10c8f Merge "Cancel more suggestions when its outside is touched" 2011-09-09 00:49:15 -07:00
Tadashi G. Takaoka 530b4176c2 Merge "Fix potential ArrayIndexOutOfBoundsException" 2011-09-08 23:24:20 -07:00
Tadashi G. Takaoka 4a9be115f2 Cancel more suggestions when its outside is touched
Bug: 5241105
Change-Id: Ic28afaf998dabd3c5529286a3e60400d733d3d82
2011-09-09 14:21:43 +09:00
Tadashi G. Takaoka 8332fd0b81 Fix potential ArrayIndexOutOfBoundsException
Change-Id: I5dad81fb274cbbcf2c4f106825eecf8e4903461c
2011-09-09 09:42:22 +09:00
Tadashi G. Takaoka 2cb36637f4 Back button to dismiss the more suggestions
Bug: 5275063
Change-Id: If31e9a25d827f44c8d4ff455a780ec2a6d2d9bef
2011-09-09 09:33:35 +09:00
Tadashi G. Takaoka a08a7e99b4 Merge "Add visual dividers to more suggestions panel" 2011-09-08 07:25:17 -07:00
Tadashi G. Takaoka 30bd8cb2da Add visual dividers to more suggestions panel
Bug: 5275003
Change-Id: I9464db71388a40ea768984b4cf06c8da05bfa26c
2011-09-08 23:05:55 +09:00
Jean Chalard af3b56c887 Fix a bug where the wrong suggestion score would matter.
Also introduce a few debug prints.

Bug: 5240463
Change-Id: Iea2fffa3be9d7bd69da751ece9e67e94e9819ee1
2011-09-08 21:17:24 +09:00
Tadashi G. Takaoka 236928c555 Merge "Make Spacer as extended Key class" 2011-09-08 01:44:24 -07:00
Tadashi G. Takaoka 18453d69e0 Make Spacer as extended Key class
Bug: 5275003
Change-Id: I809a8ca363ba72b22ac5cfd926414990f7e8467c
2011-09-08 17:38:50 +09:00
Ken Wakasa 293db0873f Get rid of the double quote from the suggestion strip
bug: 5271209
Change-Id: I1823eaac07e184092bdf2a5d607fa08ff680fca5
2011-09-08 11:46:09 +09:00
Tadashi G. Takaoka 2be872555c Use full screen mode on landscape/phone device
Bug: 5262767
Change-Id: I721c18522c972ced9f359f2e5208572d54a4b7a1
2011-09-08 11:02:55 +09:00
Ken Wakasa 6b97d2b9c2 Tweak bottom padding for the "..." popup hint
Follow up to I45bd6edf

bug: 5255103

Change-Id: I6d5368dadbaf6c7dffadd783d8a8756fea9dbff7
2011-09-07 21:58:30 +09:00
Tadashi G. Takaoka ed3758e33c Merge "Tune the threshold of fullscreen mode from 2.5in to 500dip" 2011-09-07 01:08:51 -07:00
Tadashi G. Takaoka f80b6a0699 Tune the threshold of fullscreen mode from 2.5in to 500dip
Bug: 5262767
Change-Id: Ie418ab766951a568d0f40822d8e8d719582749ba
2011-09-07 16:37:50 +09:00
Tadashi G. Takaoka ae56d5c33d Merge "Use different reference character for hit label" 2011-09-07 00:30:32 -07:00
Tadashi G. Takaoka 2ed13003af Use different reference character for hit label
Bug: 5255103
Change-Id: I45bd6edfa68abccb9d67fed617b88efad2bfcc04
2011-09-07 15:06:59 +09:00
satok 6d468c513f Fix NPE in settings
Bug: 5246032
Change-Id: I452dab9bf863fb8cba142467f338088ee8b30283
2011-09-07 12:36:07 +09:00
Tadashi G. Takaoka 50e1073e11 More suggestions view can be modal
Bug: 5241105
Change-Id: Ib430ee129b9f3cad0bdb1ae083b1068c51a5f2ea
2011-09-06 19:18:40 +09:00
Tadashi G. Takaoka 4269a7cebd Add gap between suggestions strip and more suggestions
Bug: 5260292
Change-Id: Iba792ebe0767f5117f259bcb73ac0bff778b166e
2011-09-06 18:33:01 +09:00
Tadashi G. Takaoka 8ac6d505b7 More processTouchEvent from LatinKeyboardView to PointerTracker
Bug: 5241105
Change-Id: I8a5d15f43e2c9f294e78127eda68b0f85da5ad15
2011-09-06 15:57:15 +09:00
Tadashi G. Takaoka ea0c567f86 Tune mini keyboard visual
This change only gets rid of the surrounding paddings of the mini keyboard.

Bug: 5248783
Change-Id: Idb95ac1467085c230fd60e4bc0f466fef5700bfb
2011-09-05 20:36:19 +09:00
Tadashi G. Takaoka 3f8351e186 Merge "Introduce maxMoreSuggestionsRow and minMoreSuggetionsWidth attributes to SuggestionsView" 2011-09-05 03:56:37 -07:00
Tadashi G. Takaoka 9676038b6e Introduce maxMoreSuggestionsRow and minMoreSuggetionsWidth attributes to SuggestionsView
Bug: 5257594
Change-Id: Id52c841b72e38eb9034a1a7f26bcf3d4d81ad216
2011-09-05 18:59:37 +09:00
satok 6a9f0db202 Merge "Support automatic language" 2011-09-05 02:39:58 -07:00
satok 0cba0c11f6 Support automatic language
Bug: 5057886

Change-Id: I807776b0a3d1286c66ba032c3701b3503911664c
2011-09-05 17:54:01 +09:00
Tadashi G. Takaoka 1d8ec1cb9f Merge "Rename suggestionsPaneViewStyle to moreSuggestionsViewStyle" 2011-09-05 01:39:33 -07:00
Tadashi G. Takaoka 0e7bd388d2 Merge "Get rid of LinearLayoutCompatUtils" 2011-09-05 01:22:15 -07:00
Tadashi G. Takaoka 0e2fa66144 Rename suggestionsPaneViewStyle to moreSuggestionsViewStyle
Change-Id: I30873ad870c728e28a044baf9946b4461ab03575
2011-09-05 16:48:56 +09:00
Tadashi G. Takaoka c412309b7a Get rid of LinearLayoutCompatUtils
Change-Id: If0f63eaeb4539c0e03ef20190d2f9211a176babc
2011-09-05 16:15:28 +09:00
Jean Chalard 59b501a050 Only set LOOKS_LIKE_TYPO if the max score meets a threshold
Bug: 5240463
Change-Id: I51e85edae57789d638aa1e12b82e6a75c49d33c7
2011-09-05 12:31:43 +09:00
Tadashi G. Takaoka 787bac0603 Merge "Use separate View for key preview backing" 2011-09-02 12:59:31 -07:00
Tadashi G. Takaoka abb0c77af1 Use separate View for key preview backing
Bug: 5246982
Change-Id: Icec4281cb01771909fcece36647ee42ba179118c
2011-09-03 01:36:26 +09:00
satok e197542a57 Merge "Add logs" 2011-09-02 04:21:07 -07:00
satok 8e5d12af9f Add logs
Change-Id: I640186c8be8013841b542e8cefa5f033eb7afc32
2011-09-02 19:55:09 +09:00
Tadashi G. Takaoka f2bd8a07bb Merge "Squash MiniKeyboardKeyDetector and SuggestionsPaneKeyDetector into one" 2011-09-02 03:08:41 -07:00
Tadashi G. Takaoka 9734ecbf46 Squash MiniKeyboardKeyDetector and SuggestionsPaneKeyDetector into one
Bug: 5241105
Change-Id: I4c310373fb8b2426fb46205fa17a49a8346f8244
2011-09-02 17:58:39 +09:00
Tadashi G. Takaoka d4d9b33c39 Move Row class into KeyboardBuilder
This is a followup of I5929e656.

Bug: 5245837
Change-Id: I06bc2774f77a2c5ddf0b6fe1b3ee70e9b3a7dd23
2011-09-02 17:51:27 +09:00
Tadashi G. Takaoka 08e64e1874 Merge "Calculate x coordinate with floating point" 2011-09-02 01:13:34 -07:00
Tadashi G. Takaoka f8c617028b Merge "Squash SuggestionsStripParams into SuggestionsViewParams" 2011-09-02 01:07:30 -07:00
Tadashi G. Takaoka b58925ea0d Calculate x coordinate with floating point
This change also fixes some keyboard layouts a bit.

Bug: 5245837
Change-Id: I5929e656763b150e71afe89238386904da214e21
2011-09-02 17:05:24 +09:00
Tadashi G. Takaoka 3e0511e304 Merge "Move current x coordinate value into Row class" 2011-09-02 00:58:15 -07:00
Tadashi G. Takaoka d3e50a2acf Squash SuggestionsStripParams into SuggestionsViewParams
Bug: 5246982
Change-Id: Idc2563cb0175aabc4282f9fd45eefaa129ed4961
2011-09-02 16:53:38 +09:00
Tadashi G. Takaoka e84274ede1 Move current x coordinate value into Row class
This is a preparation to address the issue.

Bug: 5245837
Change-Id: If5d463304c1689a840c8b761fedb0a8e2193734b
2011-09-02 16:24:36 +09:00
Jean Chalard 5bb7a64fe2 Merge "Fix an NPE in settings" 2011-09-01 23:42:43 -07:00
Jean Chalard ad56a9ac51 Fix an NPE in settings
Change-Id: I264c001a9cc28f864ad024fcf51fb42e9c203d3f
2011-09-02 15:35:23 +09:00
Jean Chalard 66a5884ad8 Merge "Add an option to prevent insertion of suggestion spans" 2011-09-01 22:57:39 -07:00
Jean Chalard 1531528bfe Add an option to prevent insertion of suggestion spans
This is to help debug of
Bug: 5250788

Change-Id: I961321aff3776c4912eaf7a1fa4de0c01d715f24
2011-09-02 14:43:13 +09:00
Tadashi G. Takaoka 1b087064c0 Dim keyboard when more suggestions are shown
Bug: 5241009
Change-Id: Ia42bcfc34dddf93d35f9cea8a4f0efead6ce3a6a
2011-09-01 18:48:19 +09:00
Tadashi G. Takaoka 913e2aeef2 Rename CandidateView to SuggestionsView
Change-Id: I6480cdf025f065130e1969899b259a243e7a11be
2011-09-01 15:41:34 +09:00
Jean Chalard b17300e2f0 Merge "Fix a bug where autotext would occasionally not work" 2011-08-31 22:42:11 -07:00
Tadashi G. Takaoka 537e3d3696 Merge "Remove unused suggestions pane code" 2011-08-31 22:35:12 -07:00
Tadashi G. Takaoka 3a566c48b0 Remove unused suggestions pane code
This is a followup for Ie1d69131.

Bug: 5023981
Change-Id: I42ec596af40cb7dcdd84b96ba5bff9ef1fb5dc92
2011-09-01 14:28:59 +09:00
Tadashi G. Takaoka d81479a340 Implement KeyboardLocale InputMethodSubtype extra key
The locale is specified by KeyboardLocale extra key in method.xml,
LatinIME will use the specified locale for keyboard layout.

Bug: 5238658
Change-Id: I8e6cb66c73a7ac1bf611d9910b42fa9cff38eba0
2011-09-01 14:05:01 +09:00
Jean Chalard 358e1327d8 Fix a bug where autotext would occasionally not work
Autotext correction would check whether the first suggestion
so far was the same as what Autotext would return, and if it
was indeed the same, would not send its result as
autocorrect. However, the first suggestion is not guaranteed
to have a high enough score to trigger autocorrection, and
there would be cases where a word in autotext would not get
autocorrected because the word came out of bigram
suggestions. These occurrences would be extremely rare, as
they would require concomitant insert between autotext for
one char and bigram suggestion. It is, in fact, probably
limited to the capitalization of "I".

This did not happen in gingerbread because gingerbread would
not register 1-letter words as valid bigrams.

This fix works by just always sending the result of autotext
regardless of whether it is already the first suggestion or
not. This is okay because duplicates are removed afterwards
anyway - and this processing is absolutely necessary because
the autotext'd word may actually be somewhere else in the
suggestion, so it made really no sense checking for only the
first one.

Please note that there is also a race condition that can
result in "i" not being converted to "I": at the moment,
Latin IME relies on having the suggestions evaluated
at the time autocorrection is performed, but when typing
very, very fast, those messages may have been canceled.
This is not limited to the autocorrection of "i", but
affects all autocorrections. It requires a nearly
inhumane typing speed to trigger, but hitting "i" and
space in turn as fast as one can it's possible to
reproduce occasionally.

Bug: 5135113
Change-Id: I530ea6212487300001a2c0fc5b25a5c7716bdf63
2011-09-01 12:59:17 +09:00
Tadashi G. Takaoka fdec5c1a78 Merge "Implement popup suggestions pane" 2011-08-31 05:23:54 -07:00
Tadashi G. Takaoka 29e7b7ed6e Implement popup suggestions pane
Bug: 5023981
Change-Id: Ie1d69131dbf884a3f6a2beb3ac3427e5437c1486
2011-08-31 21:21:22 +09:00
Jean Chalard 0fd2135219 Merge "Fix a possible NPE" 2011-08-31 03:06:37 -07:00
Jean Chalard a770d650b5 Fix a possible NPE
Change-Id: I5c57752772414b4f9475d0ad43d7fc52b97c3f33
2011-08-31 19:04:34 +09:00
Tadashi G. Takaoka dcb1c7b802 Merge "Rename PopupCharactersParser to MoreKeySpecParser" 2011-08-31 02:39:03 -07:00
Tadashi G. Takaoka 9d5601e901 Rename PopupCharactersParser to MoreKeySpecParser
Also renames PopupPanel to MoreKeysPanel

Change-Id: I37209a5a8fe7dbba1eef03e3be88ba5253653926
2011-08-31 18:34:35 +09:00
Tadashi G. Takaoka 2fe9a43ab7 Merge "Remove unused XML attribute" 2011-08-31 00:14:55 -07:00
Tadashi G. Takaoka 79dc056d22 Remove unused XML attribute
This is a followup for Ic83cd120.

Change-Id: Iecdcf28e2e07e1110c1b2974a9cb994ab2c0a769
2011-08-31 16:08:25 +09:00
Jean Chalard b29b225847 Merge "Clean up bigram settings" 2011-08-31 00:03:41 -07:00
Jean Chalard 18ccd552a8 Clean up bigram settings
Move bigram suggestion option to the advanced settings screen,
remove bigram prediction option for ICS release and remove the
now-empty bigram option category.

Bug: 5240082
Change-Id: Ib1fc608ad33d5598410f7b0cb4a1639bffef28c7
2011-08-31 15:41:13 +09:00
Tadashi G. Takaoka 0e7ee45f54 Merge "Rename PopupMiniKeyboardView to MiniKeyboardView" 2011-08-30 23:39:14 -07:00
Tadashi G. Takaoka 9237a72634 Rename PopupMiniKeyboardView to MiniKeyboardView
Change-Id: Ic83cd1200cfb8f8c0b0cfbcad449031b8e8a29e0
2011-08-31 15:30:54 +09:00
Jean Chalard fcee70ea92 Merge "Check the magic number of a decoded file" 2011-08-30 22:58:29 -07:00
Jean Chalard 7a408431fe Check the magic number of a decoded file
Checking the magic number of a file upon decoding is necessary,
because if the file is corrupt and we don't check it, we will
fall back to a simple copy of the corrupted file. Latin IME
would realize this and would not crash, but would not use the
corrupted dictionary. If this happened to be a main dictionary,
then the user would lose the ability to use the correct
built-in dictionary.

Not the same, but kinda similar to
Bug: 5223031

Change-Id: Ic2783dc9dd5f3dcf2865623d9452765fe3778db7
2011-08-31 14:37:11 +09:00
Tadashi G. Takaoka b8dc674663 Get rid of MeasureSpec.UNSPECIFIED
Bug: 5023981
Change-Id: I14ded3c3d554ac72b66f190110652f54d91df954
2011-08-31 14:15:20 +09:00
Tadashi G. Takaoka 241f1cfdf6 Add outputText and icon to the Key constructor
This is a follow up change for I737bacb1.

Bug: 5023981
Change-Id: I980e3e993c81afe4fbdb95c9c263d7aa52aff66c
2011-08-30 21:47:12 +09:00
Tadashi G. Takaoka 39cc806605 Merge "Cleanup keyboard related code a bit" 2011-08-30 03:40:37 -07:00
Tadashi G. Takaoka c06d0ef01d Cleanup keyboard related code a bit
Change-Id: I04f1014ab3b115bd457e25a267d2e46d306c8a0e
2011-08-30 19:16:46 +09:00
Tadashi G. Takaoka 392276d73d Add Key constructor for suggestions pane
Bug: 5023981
Change-Id: I737bacb1a6bb40f70be65d6eff85614afe6c79ed
2011-08-30 19:14:52 +09:00
Tadashi G. Takaoka 84b1284d01 Revert "Add hintLabel to Key constructor"
This reverts commit be34d97334.

Bug: 5023981
Change-Id: I34f75cde035f04a9a82c9259442ed0e255cb7118
2011-08-30 18:40:21 +09:00