Commit Graph

7324 Commits (bed514bd902d9736edcbfe03d37d8cced2bb03a3)

Author SHA1 Message Date
Jean Chalard bed514bd90 Simplify a method call.
Change-Id: Ieede787a13cef79353f13af52488ef3732ac9850
2012-06-26 19:33:16 +09:00
Jean Chalard 9433ce86b7 Refactor and squash long-standing bugs (A2)
This is awesome.
- Improve performance by stopping useless string/array conversions.
- Simplify method interface.
- Fix localization bugs - we now know our locale
- Fix bugs with surrogate code points

Bug: 4769095
Change-Id: I8a8ee224b713429ee0a4ce5bd52f1b63378cf56f
2012-06-26 19:12:07 +09:00
Jean Chalard 8e17f6d93a Remember the locale in the Suggest object (A1)
This will be necessary for uppercasing and titlecasing words
correctly.

Change-Id: I0f446a4c82bc482240ff730a2ad6586a61571d6b
2012-06-26 18:55:18 +09:00
Jean Chalard a5cfeeb6ef Merge "Remove a useless member (A2)" 2012-06-26 02:46:48 -07:00
Jean Chalard 0f455ae2a6 Merge "Convert a member to a local variable (A1)" 2012-06-26 02:46:39 -07:00
Jean Chalard bf0cae3695 Merge "Reword the 'word prediction' option" 2012-06-26 02:45:49 -07:00
Jean Chalard 6cad198d9c Remove a useless member (A2)
Change-Id: Ia727ffc2946352bbf79e0c97684f8fa98f428cef
2012-06-26 18:42:06 +09:00
Jean Chalard 0da9a7c094 Convert a member to a local variable (A1)
Change-Id: I9eab910989443704f83711cf4fb0070c5987a13a
2012-06-26 18:41:49 +09:00
Jean Chalard 8d076be2d1 Reword the 'word prediction' option
Bug: 6694141
Change-Id: Ic8fd902554cdf81998f3806a58484d9733848d99
2012-06-26 18:23:06 +09:00
Jean Chalard f05392f213 Remove an unused method (A22)
Change-Id: I2195f365df1799c8b3b2a53670d1df535ab1a742
2012-06-26 17:59:04 +09:00
Jean Chalard 6234be1fe7 Simplification and optimization (A20)
Change-Id: Ia837e553ccfe67cd4303096290194a5186df059b
2012-06-26 17:59:04 +09:00
Jean Chalard 77e95e60bb Preparation for a simplification (A19)
Change-Id: I4605a571faf5fbc68b18ce525d6019600bfa8cf7
2012-06-26 17:59:04 +09:00
Jean Chalard 0a79446531 Remove a meaningless separation (A18)
Change-Id: I267177044c7d7b0d9119839a11057b2bbf41f75f
2012-06-26 17:59:04 +09:00
Jean Chalard 61e7ec6587 Remove the Callback interface for simpler code. (A17)
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530

Change-Id: I009b54fc2e73cadca6734bdca074d033e81f6a2b
2012-06-26 17:58:52 +09:00
Jean Chalard 2f1b6c9ea4 Remove the callback argument to getBigrams() (A16)
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I7457ac04f8cd4019fb86c986725aae3de1b1a65e
2012-06-26 17:54:49 +09:00
Jean Chalard 89239eeb74 Merge "Remove the callback argument to getWords() (A15)" 2012-06-26 01:53:24 -07:00
Jean Chalard 582b69b317 Merge "Do away with Utils#addAllSuggestions (A14)" 2012-06-26 01:53:08 -07:00
Jean Chalard 6ff66f986b Merge "Neutralize AndroidSpellChecker.SuggestionsGatherer#addWords (A13)" 2012-06-26 01:52:47 -07:00
Jean Chalard a4bd4e442e Merge "Neutralize Suggest#addWords (A12)" 2012-06-26 01:52:32 -07:00
Jean Chalard 1822388727 Merge "Refactoring (A11)" 2012-06-26 01:52:18 -07:00
Jean Chalard 2db68fcfdb Merge "Remove an unused method and inline another (A10)" 2012-06-26 01:52:04 -07:00
Satoshi Kataoka aee43c4f57 Merge "Add skeleton classes for gesture" 2012-06-26 01:39:00 -07:00
Jean Chalard 60eed92dc3 Remove the callback argument to getWords() (A15)
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I919bf70a1213ab5d7c7a9e5715bd72a6e257148b
2012-06-26 17:36:47 +09:00
Jean Chalard 2225b3bace Do away with Utils#addAllSuggestions (A14)
It's not used any more.

Change-Id: Id9da40fdbf7078f3ac647d1368237d6601f5a2ba
2012-06-26 17:36:47 +09:00
Jean Chalard d9df8094e6 Neutralize AndroidSpellChecker.SuggestionsGatherer#addWords (A13)
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Ia54e1e44e1fd4e8ba2c9316928c0595cbe3f933c
2012-06-26 17:36:47 +09:00
Jean Chalard 7830476022 Neutralize Suggest#addWords (A12)
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: Id923367342a62a650a5f1d38e2fa0e913030dca8
2012-06-26 17:36:47 +09:00
Jean Chalard fd998bd37a Refactoring (A11)
Change-Id: I86bd7587dd80773a51ba6db312ba55dc41e7c8c7
2012-06-26 17:36:47 +09:00
Jean Chalard 64dad2d5a9 Remove an unused method and inline another (A10)
Change-Id: Ifd71ce79711b0c15c7764e97351dbb1b8e4c0c2d
2012-06-26 17:36:47 +09:00
Jean Chalard d522ddefc2 Merge "Merge the interface of two methods that do the same thing (A9)" 2012-06-26 01:35:15 -07:00
Jean Chalard 90981e423a Merge "Change the return type of getWords and getBigrams (A8)" 2012-06-26 01:33:04 -07:00
Satoshi Kataoka 91eb4d898e Add skeleton classes for gesture
Change-Id: I6ada110a934b0dafc57d0dcd87723275fa733548
2012-06-26 17:33:03 +09:00
Jean Chalard 9053862470 Merge "Remove dependency on WordCallback from BinaryDictionary (A7)" 2012-06-26 01:16:43 -07:00
Jean Chalard b9f99c8679 Merge "Remove useless code and storage (A6)" 2012-06-26 01:16:32 -07:00
Jean Chalard 8fb0ff00b1 Merge "Remove a duplicate processing (A5)" 2012-06-26 01:16:19 -07:00
Tadashi G. Takaoka 1c6a9cc44d Merge "Update current key reference in PointerTracker when keyboard is changed" 2012-06-26 00:58:16 -07:00
Jean Chalard 28eeb35d14 Merge the interface of two methods that do the same thing (A9)
Change-Id: Ia5701d713d0fd5bb646b54a03a1a5602dad0a9e6
2012-06-26 16:55:09 +09:00
Jean Chalard d82898c5a9 Change the return type of getWords and getBigrams (A8)
This only returns stuff, but it doesn't change yet how the data
is really passed. It merely adds a way of getting the same data.
Later, the old way will be removed.

Change-Id: If3a064de362175fc5a6781b7a97b65d8730aaf3c
2012-06-26 16:44:26 +09:00
Jean Chalard bda7eaa63a Remove dependency on WordCallback from BinaryDictionary (A7)
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I8245698fbd170e0f5cbad3c0109774bcaddc0614
2012-06-26 16:42:48 +09:00
Jean Chalard 17111afcd6 Remove useless code and storage (A6)
This is only used as temporary storage to be then added to
the other variable, relying on the fact that it is hopefully
sorted. It's better to just add it right away to the final
storage.

Change-Id: I5da702ac9dc579593ab21feb2021a01e5dfdf4dc
2012-06-26 16:39:32 +09:00
Jean Chalard 5e0545d69d Remove a duplicate processing (A5)
This filtering is already done in native code. It's useless (and
costly) to do it again here.

Change-Id: Ide6794d7a8682a881f097f33e222f10d30f297bd
2012-06-26 16:37:05 +09:00
Jean Chalard fac8a16c6f Merge "Remove another dependency to WordCallback (A4)" 2012-06-25 23:31:39 -07:00
Tadashi G. Takaoka 8a092b4ede Update current key reference in PointerTracker when keyboard is changed
This change also checks that the current key is the same key that
started the key repeat, when key repeat timer is fired.

Bug: 6722052
Change-Id: Id69880ded3338a5a3cbe7f8bf951f94f2651119c
2012-06-26 15:00:12 +09:00
Kurt Partridge 3ec249c6d1 Merge "fix IllegalOutOfBoundsException" 2012-06-25 22:52:36 -07:00
Kurt Partridge 01106f6a10 fix IllegalOutOfBoundsException
StringUtils.toCodePointArray() had thrown IllegalOutOfBoundsException if
passed an empty string.  change to just return an empty int[].

Bug: 6188932
Change-Id: Ic41c628c0d407f49fc98cd48cb7ea13d8d5bdd77
2012-06-25 22:40:56 -07:00
Jean Chalard d7b9e8f503 Remove another dependency to WordCallback (A4)
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530
Change-Id: I5b277124dc9244e78c4a1f4d542a55071eb479bd
2012-06-26 13:12:01 +09:00
Tadashi G. Takaoka 3c5db23c7a Merge "Tune CHAR LIMIT" 2012-06-25 20:02:43 -07:00
Ken Wakasa 681184d137 Merge "Remove "Key popup dismiss delay" when "Popup on keypress" is suppressed" 2012-06-25 19:52:05 -07:00
Tadashi G. Takaoka 11327c7b20 Tune CHAR LIMIT
Bug: 6513247
Change-Id: I55e36620bd8b2e7b47a51ccde1b0bf3e277cd56b
2012-06-26 11:00:19 +09:00
Jean Chalard 30dd558802 Merge "Pull the "next word prediction" option up a level." 2012-06-25 18:54:28 -07:00
Eric Fischer 31e82e7e0f am 67727e34: (-s ours) am 04f0b211: Import translations. DO NOT MERGE
* commit '67727e34a28e3bfe3f331733b9d1e3c78294e793':
  Import translations. DO NOT MERGE
2012-06-25 14:27:19 -07:00