Commit Graph

5458 Commits (b4fb829138bce995118f964231aa466a925224e4)

Author SHA1 Message Date
Jean Chalard a7d0ab80a0 Fix an off-by-one error.
These variables were meant to represent the (x,y) coordinate of the
last pixel of the grid, to avoid going one pixel too far. But the last
pixel of the grid, of course, has coord (width - 1, height - 1).

This bug only ever happens in a rare case because to reproduce,
it needs the right (resp. bottom) coordinate of the rightmost
(resp. bottommost) plus the threshold plus half the grid width
(resp. height) to be exactly the number of pixels of the grid,
which is pretty unlikely... unless there are more tiles in the
grid than pixels on the screen, in which case the grid width is
1 and this becomes likely.

This fixes the fencepost error and renames the variables to
clarify their meaning.

Bug: 10537485
Change-Id: Iecfe2c0f29ee17776ee2cceaa4b1db722276b1f3
2013-09-19 13:43:09 +09:00
Keisuke Kuroyanagi 40f66795a2 Quit skipping user history dictionary for gesture.
Bug: 6669677
Change-Id: Id4344f2a30e9827f210055d6c65ee7776d3a63e3
2013-09-19 13:12:11 +09:00
Jean Chalard 8678062853 Merge "Fix an NPE." 2013-09-18 12:42:16 +00:00
Jean Chalard 08bc97f86f Merge "Allow double-space-to-period after a plus char" 2013-09-18 12:40:29 +00:00
Jean Chalard 673275cbc6 Fix an NPE.
Apparently, it is possible that File#getPath() returns null.
In this case, we'll have a null AssetFileAddress and an NPE
later down the road.

Bug: 9944824
Change-Id: Id6ceac1cb55439660f9811cf0fe3b574200d5a20
2013-09-18 21:39:30 +09:00
Jean Chalard ba99d8cd0b Allow double-space-to-period after a plus char
Bug: 10704936
Change-Id: I30fdaea648605ef7e7fea6c093581ed5c6de03f3
2013-09-18 21:04:25 +09:00
Satoshi Kataoka 957a2337ee Merge "Set EmojiCapable" 2013-09-18 08:48:35 +00:00
Satoshi Kataoka 8837deab73 Merge "Fix Emoji recents" 2013-09-18 08:46:25 +00:00
Satoshi Kataoka ea7bfa5cd5 Fix Emoji recents
Bug: 10538430

Change-Id: Ia2e423eb1843195b3c3218afc79a5820b8cd729b
2013-09-18 17:44:16 +09:00
Ken Wakasa 256937b475 Merge "Fix getChildrenPosition." 2013-09-18 08:36:48 +00:00
Satoshi Kataoka 51f275d8be Set EmojiCapable
Bug: 10240645
Change-Id: I891309c2a82f8d10f8fdb0872403a7a235e27b5f
2013-09-18 17:29:23 +09:00
Jean Chalard 59418672a1 Merge "Don't resume suggestion on digits." 2013-09-18 07:05:01 +00:00
Keisuke Kuroyanagi 4ad4b9d976 Merge "Fix contacts/user dictionary writing." 2013-09-18 07:00:58 +00:00
Yuichiro Hanada d0c87576ff Fix getChildrenPosition.
Change-Id: Ic39592dbf0d4e6d2e4879cdb1a95b65d46a57e92
2013-09-18 15:50:10 +09:00
Keisuke Kuroyanagi 0011ab4bf3 Fix contacts/user dictionary writing.
Bug: 10743878
Change-Id: I5d61b7955ef69a635f994f01cc575fb23fdf942b
2013-09-18 15:31:06 +09:00
Keisuke Kuroyanagi 9465819cf6 Merge "Add BinaryDictionary.getBigramProbabilityNative()." 2013-09-18 04:10:38 +00:00
Jean Chalard f71e1db2da Don't resume suggestion on digits.
Bug: 10780016
Change-Id: I94fad06e4c71eddc96bdda1765925f98bed160f3
2013-09-18 11:37:19 +09:00
Keisuke Kuroyanagi 4d02a2d44d Add BinaryDictionary.getBigramProbabilityNative().
Bug: 10197478
Change-Id: Id16e3ee22a17679c46cc7a0199a9e28065177aa3
2013-09-18 11:18:28 +09:00
Jean Chalard e8f717943f Improve trailing quotes processing
Bug: 10445496
Change-Id: Ib7bd05aea59ae6c9b8ce31299ef2235521b0e350
2013-09-17 22:17:22 +09:00
Jean Chalard 060917ed9a [AC9] Resize an array
It's not easy for native code to only output the first
result, so let's supply enough room for it to output all.

Bug: 9059617
Change-Id: Ie93b7e54284c8c5d01fdc15846cf52d3442287b6
2013-09-17 19:05:30 +09:00
Jean Chalard 5cab0eb75b Merge "[AC8] Restrict the suggestion strip to the correct part" 2013-09-17 09:48:02 +00:00
Jean Chalard b1e98c2f4f [AC8] Restrict the suggestion strip to the correct part
...for phrase gesture.

Bug: 9059617
Change-Id: Ic5c0616f28af4ba45ca72a5721d1926029adc1c5
2013-09-17 18:43:12 +09:00
Keisuke Kuroyanagi d0246277fd Prepare dictionary saving in native code.
Bug: 6669677

Change-Id: I0787f66409e2b183c6328fa05805945520e1e93a
2013-09-17 18:07:16 +09:00
Jean Chalard 7e51989b3f Merge "[AC7] Actually auto-commit." 2013-09-17 08:20:47 +00:00
Keisuke Kuroyanagi e8754aba1c [AC7] Actually auto-commit.
Bug: 9059617
Change-Id: I7e5d89a9037b9181a0a6456c12043b4bfda8fe4b
2013-09-17 16:44:50 +09:00
Satoshi Kataoka fb9b50671d Temporary disable saving keys of emoticons to recents
Bug: 10538430
Change-Id: I4c3d0d692eecdd3bb5e780bdaca46f3310065471
2013-09-17 16:40:13 +09:00
Satoshi Kataoka fc51a82079 Merge "Disable smooth scroll of Emoji pager" 2013-09-17 03:51:47 +00:00
Jean Chalard 73d607fb70 Merge "[AC5] Introduce the setting for phrase gesture." 2013-09-17 03:42:38 +00:00
Satoshi Kataoka 44220e7271 Disable smooth scroll of Emoji pager
Bug: 10538430
Change-Id: Ib9dfa28bf6b642cc8895022ead9e6b2d64001097
2013-09-17 11:46:34 +09:00
Satoshi Kataoka f3f00006cb Save & restore emoji keyboard state
Bug: 10538430
Change-Id: I7982f53f5dfa44071e74da63826acffcdc2547e6
2013-09-16 19:39:20 +09:00
Satoshi Kataoka 5dfbc8af24 Split Emoji categories fitting the pager
Bug: 10538430
Change-Id: Ic023ac0b9db8a1fe16c73ab5fd12dfcd7cbbe6a3
2013-09-16 18:27:20 +09:00
Ken Wakasa 0f317a5603 Fix issues with Nepali layouts
- Added the missing ZWNJ/ZWJ key
- Fix a wrong letter in the shift layout of Nepali Romaized layout
- Put the currency symbol for Nepalese Rupee
- Fix the missing 2nd symbols layout
- Use the Devanagari numbers just like Hindi layout
- Fix the Main/Symbols switch key label just like Hindi layout

bug: 6910787
bug: 9833890
Change-Id: Ie6aa5a06008f1e9347d4fc08ededd48287df5d73
2013-09-16 02:08:51 +09:00
Ken Wakasa 1313d17d37 Small tweak for label_to_more_symbol_for_tablet_key
To make it a bit more consistent with the one for phones

Change-Id: Ia5775b07a0d70cabc5c51ff2b954c64ce4dc8c7c
2013-09-14 12:10:04 +09:00
Satoshi Kataoka cdc2ce8c89 Merge "Use DynamicGridKeyboard for EmojiPager" 2013-09-13 12:20:14 +00:00
Satoshi Kataoka b0bf7e729b Use DynamicGridKeyboard for EmojiPager
Bug: 10538430
Change-Id: Iff84e306faaa8e87d107e418d5c61c5613b57430
2013-09-13 21:18:57 +09:00
Ken Wakasa 505b6ba103 Merge "Add Lao keyboard" 2013-09-13 12:11:31 +00:00
Ken Wakasa 47761678f1 Add Lao keyboard
bug: 6911140
Change-Id: Id689be1fb9dbc89b5a9b7f142626751a62d931ed
2013-09-13 21:10:17 +09:00
Jean Chalard a37bee2805 [AC5] Introduce the setting for phrase gesture.
Bug: 9059617
Change-Id: I6fa0f675f4edac10bd19228cd2f0c8fca97cebd6
2013-09-13 20:44:37 +09:00
Jean Chalard 41aaff6cdf Merge "[AC4] Add native methods necessary for auto-commit" 2013-09-13 11:41:55 +00:00
Jean Chalard 24aad5a4d5 [AC4] Add native methods necessary for auto-commit
Bug: 9059617
Change-Id: I7a47b0675446fc4f39628c60d16de9aea90d1b4d
2013-09-13 20:15:15 +09:00
Ken Wakasa fbc7e61a3e Merge "Add Ver4DictEncoder." 2013-09-13 08:51:58 +00:00
Satoshi Kataoka ffebc9cfa7 Merge "Add shutdown and isTerminated to PrioritizedSerialExecutor." 2013-09-13 08:51:43 +00:00
Yuichiro Hanada a099a3e341 Add shutdown and isTerminated to PrioritizedSerialExecutor.
Change-Id: Id185224d135c8571a39efe8a41a66ce769142903
2013-09-13 17:46:50 +09:00
Yuichiro Hanada a141d8ef7d Add Ver4DictEncoder.
Bug: 9618601
Change-Id: I161d2845906f07c1251deb8005fdffe49c5b7940
2013-09-13 17:33:51 +09:00
Satoshi Kataoka 2c011c697b Refactor RecentsKeyboard
Bug: 10538430
Change-Id: I7a22d2d4a105b17b2a84a3fff2bc3981823d228d
2013-09-13 16:35:07 +09:00
Satoshi Kataoka 12ff349f29 Fix emoji tabs
Bug: 10541453
Change-Id: If920eafa0c48e437301fc0b7055ea7b7bbc04669
2013-09-13 14:48:52 +09:00
Satoshi Kataoka 244eca3809 Merge "Fix emoji keyboard insets" 2013-09-13 05:25:33 +00:00
Satoshi Kataoka 898dbe3c29 Fix emoji keyboard insets
Bug: 10541453
Change-Id: I16dd72c8c55cb5d21ad61a3307c0f3c5f16f460c
2013-09-13 14:21:40 +09:00
Satoshi Kataoka dd072e3201 Consolidate EmojiKeyboardView
bug: 10538430
Change-Id: Ia799eca303d8ec68eeeb9f00fa8002a44d0c49fc
2013-09-13 11:32:18 +09:00
Jean Chalard 40666017c9 Merge "Avoid recorrection in ex-password fields." 2013-09-12 12:29:33 +00:00
Jean Chalard ce96d0d12f Avoid recorrection in ex-password fields.
Bug: 10115839
Change-Id: I1f1025c9f28adfb6f5a63d5ba86e359f30c0963e
2013-09-12 21:20:07 +09:00
Ken Wakasa a6dc3056ff Merge "Add getDictDecoder." 2013-09-12 11:17:03 +00:00
Yuichiro Hanada 0e40cd0c40 Add getDictDecoder.
Bug: 9618601
Change-Id: I173100ac704c03f7d5d0d53477e83cab5d1110d4
2013-09-12 20:14:09 +09:00
Satoshi Kataoka 28af9ed19e Merge "Suppress emoji tabs on JB-MR2 or previous versions" 2013-09-12 10:58:29 +00:00
Keisuke Kuroyanagi b118a9d729 Merge "Change cache capacity depending on the dictionary size." 2013-09-12 10:38:42 +00:00
Satoshi Kataoka 36ccb030ed Suppress emoji tabs on JB-MR2 or previous versions
Change-Id: I6a9c4994a446026b9736fda37ad7eccbd67a9a3d
2013-09-12 19:38:26 +09:00
Satoshi Kataoka 695a5a391d Merge "Change space key height in Emoji keyboard view" 2013-09-12 10:25:33 +00:00
Satoshi Kataoka 2d3d415826 Change space key height in Emoji keyboard view
bug: 10538430

Change-Id: I724a8c92b49a64196c7da2af40f3d20758e0dbae
2013-09-12 19:18:41 +09:00
Keisuke Kuroyanagi 4c2767857a Change cache capacity depending on the dictionary size.
Bug: 10699291

Change-Id: I7042d4c1307da2d991d4dd10d637f18026acb996
2013-09-12 18:47:56 +09:00
Yuichiro Hanada be470f06e4 Hide DictBuffer from BinaryDictDecoderUtils.
Bug: 9618601
Change-Id: I87515bc1555bdfe09426a056ceda74d8e63eba82
2013-09-12 16:49:54 +09:00
Jean Chalard 87472f0038 Remove changing a word when added to the dictionary
This code is now useless.
I thought it affected 9902905, but it seems it actually does not.
Still, it's dead code.

Bug: 9902905
Change-Id: Id9c90fbf88f015af47b2368b90d173c481647093
2013-09-12 15:10:10 +09:00
Keisuke Kuroyanagi 76e431b315 Merge "Use same session id for typing and gesture." 2013-09-12 03:16:43 +00:00
Keisuke Kuroyanagi f1233b58c2 Use same session id for typing and gesture.
Bug: 10699291
Change-Id: I7c8a3a57e8d189b72a17e4b9c6831becee6ec146
2013-09-12 12:08:22 +09:00
Yuichiro Hanada 7547a7042c Add writePtNode to DictEncoder.
Bug: 9618601
Change-Id: Ie4529444780edee8d0f0d5f23c5619c1a3344286
2013-09-11 18:27:06 +09:00
Yuichiro Hanada 95bc256f41 Add a flag to readDictioanryBinary in DictDecoder.
Change-Id: I356adb72047ebc43c924fbff1ff45e7460508a31
2013-09-11 18:20:56 +09:00
Yuichiro Hanada e193c5255d Revert Ida230ca42 and I6adf7d08f.
Change-Id: I2ddb250d5a473ea955a5171656974de7288a13f7
2013-09-10 19:08:43 +09:00
Yuichiro Hanada ef073f4024 Use PrioritizedSerialExecutor instead of ReentrantReadWriteLock.
Change-Id: I003b769e408ebd692085a7e17fed6d9396876202
2013-09-10 19:05:41 +09:00
Ken Wakasa 40e91e4582 Merge "Check the version of format options before writing." 2013-09-10 10:01:12 +00:00
Yuichiro Hanada 8a06b26cb4 Check the version of format options before writing.
Change-Id: I3951e4395a2da225e240e856c23339b679e6155e
2013-09-10 18:59:31 +09:00
Keisuke Kuroyanagi e531c2241e Move a flag about switching dynamic update to java.
Bug: 6669677

Change-Id: I6aa99cae4a227f9202179c2873d13473a773e024
2013-09-10 18:45:53 +09:00
Yuichiro Hanada acdabb25f4 Add AsyncResultHolder.
Change-Id: Icfa685bcda2f5c74f5649f09098d00b4bd321c5a
2013-09-10 15:48:06 +09:00
Satoshi Kataoka be96361156 Merge "Check contents in user history dictionary tests" 2013-09-09 06:46:45 +00:00
Satoshi Kataoka e5a35711b8 Check contents in user history dictionary tests
Bug: 10667710

Change-Id: I45ebb08cb4ef9a9f6d2da31e2c50e740f88209c2
2013-09-09 15:28:50 +09:00
Yuichiro Hanada 70e81af726 Hide physical structure of the dictionary from BinaryDictEncoderUtils.
Bug: 9618601
Change-Id: I01b8da42058d7c05bf7f4e6d43718032c2ad12c5
2013-09-09 14:55:33 +09:00
Yuichiro Hanada cc2751ba03 Make commitCurrentAutoCorrection asynchronous.
Change-Id: Ida230ca4243347fb3ab9fda7de3a9a18f886cd1c
2013-09-09 14:47:26 +09:00
Keisuke Kuroyanagi 37e0fd2ff0 Revise TODO comment for I823912e3979829a.
Change-Id: I839d8cb4d45d7d17b7940d710a2fef5aeacc11ab
2013-09-09 12:26:40 +09:00
Keisuke Kuroyanagi 773f227242 Fix: wrong locking order.
Change-Id: I823912e3979829ad1e825cf91dc5e18f7f0f9cc3
2013-09-09 12:13:21 +09:00
Keisuke Kuroyanagi e7ac900340 Merge "Write forgetting curve flag." 2013-09-09 01:46:59 +00:00
Yuichiro Hanada 563bcb5117 Rename write(|Signed)VariableAddress and to write(|Signed)ChildrenPosition.
Change-Id: Ib018bde346744b470a4fb13b0c57e3a633b8bb20
2013-09-06 23:53:58 +09:00
Yuichiro Hanada 6156892b7e Add computeChildrenPosition and simplify writePlacedNode.
Change-Id: Idcf0e056bf61e29844d4d0e91c482cd78c41704c
2013-09-06 23:52:10 +09:00
Keisuke Kuroyanagi 859b9eeaf0 Write forgetting curve flag.
Bug: 6669677
Change-Id: Ic19aa3b69fb45d9638f9dcc8c3dd8a34aad41965
2013-09-06 21:03:09 +09:00
Satoshi Kataoka 741831d322 Add margin to the label of language
Change-Id: I48dc63475caf5cc1a1ac09b82b26fbeaef993fa1
2013-09-06 17:21:44 +09:00
Satoshi Kataoka 98565a9c02 Optimize tablet layout
Bug: 9059539
Change-Id: Ideb6965768fcf092c081eb1d3102312c863cc5b6
2013-09-06 16:43:19 +09:00
Satoshi Kataoka b690c03927 Merge "Optimize layout" 2013-09-05 13:31:53 +00:00
Satoshi Kataoka d6217a323c Optimize layout
Bug: 9059539

Change-Id: Iabfd44daae1ef6da99a864859488a4f644240925
2013-09-05 22:27:26 +09:00
Yuichiro Hanada b1af47c8fe Add a callback to the arguments of commitCurrentAutoCorrection.
Change-Id: I6adf7d08fdc4382233a63304743207368db8058a
2013-09-05 20:00:40 +09:00
Satoshi Kataoka 80fe84b3a4 Merge "Consolidate voice input key options no.1" 2013-09-05 07:33:59 +00:00
Satoshi Kataoka 21a89c1137 Consolidate voice input key options no.1
Change-Id: I2f928522a0795f57b4133072f270d8fd2498cae9
2013-09-05 16:25:41 +09:00
Yuichiro Hanada 55f5f7a005 [Refactor] Add writeDictionaryHeader.
Change-Id: I69026c47ce1d23f5c39c99ace76fa6b96cd1ce1b
2013-09-05 16:19:26 +09:00
Yuichiro Hanada 663f5375d1 Add comments about how to calculate parent and children addresses.
Change-Id: Idf37d9a08a7b464a14c8755bedb755005e49ba33
2013-09-05 15:10:28 +09:00
Satoshi Kataoka e0502496da Revert "Remove symbols shifted layout"
This reverts commit c02a365485.

Change-Id: I11d31632469a594c0637f035bdd74ba60b2ac33e
2013-09-04 18:22:59 +09:00
Satoshi Kataoka e3150664ae Revert "Remove symbols shifted layout related code"
This reverts commit 1cd027850b.

Bug: 9059539

Change-Id: I1880b799e2d0f148ae913f13cffa1b8cac48be60
2013-09-04 16:27:34 +09:00
Satoshi Kataoka 42b799d93a Revert "Remove symbols shifted related unused texts and styles"
This reverts commit 59f49b3861.

Bug: 9059539

Change-Id: I6e298a55feb942fc3720a91b65f841220443b42b
2013-09-04 12:24:55 +09:00
Yuichiro Hanada 648088aa9e Change GET_SUGGESTED_WORDS_TIMEOUT to 200.
Change-Id: Ia5aa0b7af16d7ad45c98d0c5a7dcabba76d19b67
2013-09-03 18:52:53 +09:00
Ken Wakasa c4c7a59a12 Merge "Change GET_SUGGESTED_WORDS_TIMEOUT to 50." 2013-09-03 08:54:12 +00:00
Yuichiro Hanada d6c947ef7b Change GET_SUGGESTED_WORDS_TIMEOUT to 50.
Change-Id: I4d495a782ed1dea1c377837c6579ce5ff74086b5
2013-09-03 17:39:47 +09:00
Satoshi Kataoka eaee156128 Optimize tablet layout
Bug: 9059539
Change-Id: I049941d2c83764c7f07c5215799b9657a7f27764
2013-09-03 17:36:42 +09:00
Yuichiro Hanada 908fc4f1c3 Call getSuggestedWords asynchronously.
Change-Id: Ia8a21b53f4d12b759d9ef5a5181ed04875e4d198
2013-09-03 15:12:49 +09:00
Yuichiro Hanada 8616e4c03d Remove typedWord from the arguments of showSuggestionStrip.
Change-Id: Iddf33227982e65705b49c6a527286d8695878c90
2013-09-02 22:31:43 +09:00
Yuichiro Hanada 9666a22815 Revert "Revert "Add onGetSuggestedWordsCallback.""
This reverts commit 78f707a142.
Change-Id: I5dd4f2d40314002736226886477563f29a25079c
2013-09-02 14:09:53 +09:00