Commit graph

30687 commits

Author SHA1 Message Date
Tadashi G. Takaoka
2600c092b0 Merge "Cleanup private method names" 2014-03-11 10:20:57 +00:00
Tadashi G. Takaoka
8542c48c30 Cleanup private method names
This is a follow up of Ib0ded6f98a.

Change-Id: I91ad3504d301113680194ad5b10913fc86006150
2014-03-11 19:04:57 +09:00
Tadashi G. Takaoka
470a4502ab Merge "Fix Greek tablet layout aligned with phone layout" 2014-03-11 09:55:13 +00:00
Tadashi G. Takaoka
e6b992d9be Merge "Add keyboard layout name constant" 2014-03-11 09:42:51 +00:00
Tadashi G. Takaoka
8c1965ba04 Add keyboard layout name constant
Change-Id: I6cdc3efdb58e7a1efb3e352d80d0aa41e333a150
2014-03-11 18:41:55 +09:00
Keisuke Kuroyanagi
34ab038414 Merge "Stop new BigramDictionary." 2014-03-11 09:38:14 +00:00
Keisuke Kuroyanagi
e7ddf49d50 Merge "Use emplace_back in getWordProperty()." 2014-03-11 09:38:00 +00:00
Keisuke Kuroyanagi
ed72a768d6 Merge "Make getWordProperty return reconstructed bigram probability." 2014-03-11 09:37:49 +00:00
Tadashi G. Takaoka
bab437fb3b Another small cleanup for test code
Change-Id: Ib0ded6f98a6ce9197c8af79778af59d894ee54a6
2014-03-11 17:55:11 +09:00
Tadashi G. Takaoka
0722e6b3df Small cleanup for test code
Change-Id: I5106c8c52bdd11bfd23aa2e09f7ea53504083679
2014-03-11 17:28:19 +09:00
Tadashi G. Takaoka
709acaa9e9 Fix Greek tablet layout aligned with phone layout
Bug: 13406008
Change-Id: Iba5bd757c5874e426d5d4fcb8c404c21d259b833
2014-03-11 17:23:01 +09:00
Tadashi G. Takaoka
f247b171ce Refactor currency and quotes keys tests
Bug: 13017434
Change-Id: I38dff3c8b9b28eff4397c7cdbad623fb43cbc312
2014-03-11 16:11:31 +09:00
Keisuke Kuroyanagi
ca42ec0f44 Use emplace_back in getWordProperty().
Change-Id: If164d2b897bd6ad9c89baf0e9a90356100c5087b
2014-03-11 15:21:55 +09:00
Keisuke Kuroyanagi
a34bdc395b Make getWordProperty return reconstructed bigram probability.
Bug: 13403530
Change-Id: I7ed95a54344d8b77b88922093cf3ef0e530fcae6
2014-03-11 15:20:12 +09:00
Keisuke Kuroyanagi
89dbd056d1 Merge "Use isFirstCharUppercase instead of get first code point." 2014-03-10 11:42:23 +00:00
Keisuke Kuroyanagi
5c2f55fe6e Merge "Add getter methods for public member variables." 2014-03-10 11:40:24 +00:00
Keisuke Kuroyanagi
da5b4fb6da Merge "Move initialization logic for from DicNode to DicNodeState." 2014-03-10 11:40:08 +00:00
Keisuke Kuroyanagi
7036762072 Merge "Remove unused member of DicNodeStatePrevWord." 2014-03-10 09:45:54 +00:00
Keisuke Kuroyanagi
b43ea5c335 Use isFirstCharUppercase instead of get first code point.
Change-Id: I0a28305397bfc1e7218e16df00839781a74f5599
2014-03-10 18:39:45 +09:00
Keisuke Kuroyanagi
0a5efa31de Add getter methods for public member variables.
Change-Id: Ic6656bb3db6db992b37923db53816e0a73a7621f
2014-03-10 18:39:45 +09:00
Keisuke Kuroyanagi
6066069f35 Move initialization logic for from DicNode to DicNodeState.
Change-Id: Ic7075349e2e9c7f4ca707efa12ad1d24b49a2c87
2014-03-10 18:39:43 +09:00
Keisuke Kuroyanagi
258260bef2 Remove unused member of DicNodeStatePrevWord.
Change-Id: I265855da58e3a2e070e525e116ac0d18d1a10d18
2014-03-10 18:39:15 +09:00
Keisuke Kuroyanagi
bd44c9815d Merge "Improve DicNode handling." 2014-03-10 09:21:10 +00:00
Keisuke Kuroyanagi
632c9aca5b Improve DicNode handling.
- Stop creating useless DicNode and DicNodeVector.
- Remove useless virtual.
- Implement copy constructor and assignment operator of DicNodeState.
- Remove useless memset.

Before:
(0)  2266.21 (0.79%)
(1)  285422.05 (98.97%)
(2)  642.62 (0.22%)
(66)  0.19 (0.00%)
Total 288384.35 (sum of others 288331.07)

After:
(0)  2232.70 (0.86%)
(1)  255258.50 (98.89%)
(2)  585.73 (0.23%)
(66)  0.26 (0.00%)
Total 258126.46 (sum of others 258077.18)


Change-Id: I0bb1e9de8b38a6743a11aaeb2b17bd0da5b7ad34
2014-03-10 17:57:53 +09:00
Tadashi G. Takaoka
9e222d46d0 Merge "Fix unused text resources of keyboard layouts" 2014-03-10 08:45:03 +00:00
Tadashi G. Takaoka
567fbe90f7 Fix unused text resources of keyboard layouts
Icelandic keyboard has no nordic layout.
Latvian, Lithuanian, and Slovak keyboards have duplicated N WITH ACUTE.
No Language keyboard has duplicated letter a variants.

Change-Id: Iaeacebc1f7efdb70294e6342e42232b73aed9398
2014-03-10 17:31:25 +09:00
Jean Chalard
e93a7232d1 Don't reset the value needed before it's used
Nice recipe for failure

Bug: 13387534
Change-Id: Ida1978449c1997587b2ec0955c5c94fcef336121
2014-03-10 15:55:15 +09:00
Keisuke Kuroyanagi
1db3b10f14 Merge "Use emplace_back to push DicNode to vector." 2014-03-10 06:47:37 +00:00
Keisuke Kuroyanagi
87db47d175 Use emplace_back to push DicNode to vector.
Before:
(0)  2234.43 (0.71%)
(1)  310083.71 (99.07%)
(2)  626.88 (0.20%)
(66)  0.26 (0.00%)
Total 312995.33 (sum of others 312945.28)

After
(0)  2266.21 (0.79%)
(1)  285422.05 (98.97%)
(2)  642.62 (0.22%)
(66)  0.19 (0.00%)
Total 288384.35 (sum of others 288331.07)


Change-Id: I5ab98076c54d147ff7ec2a29280859f4558e24d0
2014-03-10 15:41:33 +09:00
Keisuke Kuroyanagi
66cc9dec55 Stop new BigramDictionary.
BigramDictionary is allocated inside of Dictionary.

Change-Id: If224b4c408403f43eb3d2e292c0e0ecb86429290
2014-03-10 05:42:36 +00:00
Tadashi G. Takaoka
e07a777ed6 Fix unneeded u with diaeresis more key on Swedish keyboard
Change-Id: Ib4a17fa464899907616e76426e5df0d370a40f80
2014-03-10 11:15:18 +09:00
Tadashi G. Takaoka
315010636a Fix excessive more keys on Estonian keyboard
Change-Id: I6c2d5d123d519278a6ff0f12fece69ccbad1aad5
2014-03-10 10:56:26 +09:00
Ken Wakasa
783aee47e0 Remove string-arrays that are getting in the way
These empty string-arrays should not have been in this resource file.
They are in the translated files, and they are getting in the way of
the resource finding paths.

Fundamental fixes definitely should follow. For now, this CL should be
safe and acceptable for Cannellini.

bug: 13340486
Change-Id: I14c36babf9eb30cfc1c0adc5977136189a305f33
2014-03-08 22:37:27 +09:00
Keisuke Kuroyanagi
f14cf3e64c Fix: dicttool build.
Change-Id: I5c3bcbe9f3054bdd1a760398fe11344e0e05ac6a
2014-03-07 13:01:48 +00:00
Keisuke Kuroyanagi
32326a9d7a Merge "Move DictionaryOptions from FusionDictionary to FormatSpec." 2014-03-07 10:42:18 +00:00
Keisuke Kuroyanagi
ee5d8441d1 Merge "Introduce SuggestionResults and use it for predictions." 2014-03-07 10:38:22 +00:00
Keisuke Kuroyanagi
e137ec0a91 Introduce SuggestionResults and use it for predictions.
Bug: 8187060
Bug: 13333066
Change-Id: I1ead897024508b7e40fbd93af7d14bfe74b93826
2014-03-07 19:36:19 +09:00
Tadashi G. Takaoka
a0a8d96c49 Merge "Filter Spacer before keyboard layout test" 2014-03-07 10:33:37 +00:00
Tadashi G. Takaoka
8c6b34e51d Filter Spacer before keyboard layout test
Bug: 13017434
Change-Id: I836d2f79a839ee77325535c08d7a59bb02b83c28
2014-03-07 19:18:51 +09:00
Keisuke Kuroyanagi
a103e29d00 Merge "Separate WeightedString from FusionDictionary." 2014-03-07 09:07:26 +00:00
Keisuke Kuroyanagi
c36c97b4f7 Merge "Use unique_ptr." 2014-03-07 09:06:58 +00:00
Tadashi G. Takaoka
0dc53b0699 Add en_US keyboard layout test
Bug: 13017434
Change-Id: I3fb343721221ecae210bffcb3e83ce4f2df0d0ff
2014-03-07 17:44:36 +09:00
Tadashi G. Takaoka
238e9898cd Add QWERTY expected keyboard layouts
Bug: 13017434
Change-Id: Ia8a65b692521f0050f003e20712a5873a0b236b4
2014-03-07 17:39:54 +09:00
Tadashi G. Takaoka
ad04ed5460 Merge "Add ActualKeyboardBuilder for testing keyboard layouts" 2014-03-07 08:36:43 +00:00
Tadashi G. Takaoka
ff8405cdfb Add ActualKeyboardBuilder for testing keyboard layouts
Bug: 13017434
Change-Id: I38b1f5c261ea1f3ff312c780d7d9b5fe3fba8aaf
2014-03-07 17:29:58 +09:00
Ken Wakasa
6767f88e3c Address warnings pointed out by clang
Change-Id: I7943f6c7f9ba08f283a3116adc2af29495f04a21
2014-03-07 17:05:09 +09:00
Ken Wakasa
2bebda2fa7 Merge "Recover the dicttool build except for Mac" 2014-03-07 06:14:07 +00:00
Ken Wakasa
344742b0d1 Recover the dicttool build except for Mac
With a hack: Temporarily disable host tool build on Mac until the
build system is ready for C++11.

Change-Id: Ib412ba0d7fecc968cc09b4d8fde4e838bdc0618a
2014-03-07 15:04:27 +09:00
Keisuke Kuroyanagi
9c2f003d59 Merge "Revert "Revert "Use std::min() and std::max()""" 2014-03-07 05:33:30 +00:00
Tadashi G. Takaoka
937c40ee00 Merge "Fix AZERTY/tablet layout" 2014-03-07 05:32:05 +00:00