Commit graph

7430 commits

Author SHA1 Message Date
Tadashi G. Takaoka
adba09b54e Remove redundant override methods and extended classes
Bug: 15727335
Change-Id: Icea09f0643e7aeb8e722e473ad322f7439c3497a
2014-06-24 22:31:43 -07:00
Tadashi G. Takaoka
3d8848e5cb Refactor keyboard accessibility delegate classes
Bug: 15727335
Change-Id: I1aa79a6f7f8cf14bacec391c016a5d1c553eea24
2014-06-24 22:14:07 -07:00
Keisuke Kuroyanagi
67f863f4cb Merge "Extend jni method to use multiple previous words." 2014-06-24 01:52:26 +00:00
Jean Chalard
c0748a1990 Fix the build
That was a merge not well resolved by git >.>

Change-Id: I3cd042d6a5206daf1e9942358405d647c67423dd
2014-06-26 18:44:54 +09:00
Keisuke Kuroyanagi
d58a07666e Merge "Rename jni method for n-gram supporting." 2014-06-24 01:52:26 +00:00
Keisuke Kuroyanagi
6c7cebdefb Fix build.
Change-Id: I5c6c0a9098c5a228ed82b208aa6f237a41f2f6cc
2014-06-26 14:42:40 +09:00
Keisuke Kuroyanagi
83b6ee2538 Rename jni method for n-gram supporting.
Bug: 14425059
Change-Id: I242d1de5d9db37344f02d8fba9035829794a56c8
2014-06-25 14:14:40 +09:00
Keisuke Kuroyanagi
e708b1bc2e Make PrevWordsInfo have multiple words' information.
Bug: 14425059
Change-Id: I2bd6a872904a44b80f638a13d91a97559217cc1a
2014-06-25 14:14:37 +09:00
Jean Chalard
310bb2c76f Merge "[HW1] Fix some bugs with event handling" 2014-06-24 01:52:26 +00:00
Jean Chalard
09291050a0 [HW1] Fix some bugs with event handling
With hardware events, we do have some events that
have both a keycode and a code point, so we need
a better way of distinguishing between auto-insert
keystrokes and others.

Change-Id: Ia23042989b4dca9d3a7d4a4c06bcebdabe324a7a
2014-06-26 18:27:53 +09:00
Jean Chalard
90759f2ab7 Merge "[CS4] Remove useless tests and processing" 2014-06-24 01:59:00 +00:00
Jean Chalard
b740886aeb [CS4] Remove useless tests and processing
Since we have a de-duped and transformed collection, we
can just read from it instead of computing it separately.

Bug: 13238601
Change-Id: I0aa4b0d91d3b350f9449e13658bfb587fc538764
2014-06-26 18:26:08 +09:00
Keisuke Kuroyanagi
92827b0712 Merge "Make PrevWordsInfo have multiple words' information." 2014-06-24 01:52:26 +00:00
Keisuke Kuroyanagi
0aef59746c Make Beginning-of-Sentence prediction require two exposures.
Bug: 15868192
Change-Id: I4b577ad11c992d872d6f902fd50527d9ca5cc1ba
2014-06-25 20:20:44 +09:00
Jean Chalard
53f23234e3 Merge "[CS3.5] Small correction" 2014-06-24 01:46:27 +00:00
Jean Chalard
c82257ba6e [CS3.5] Small correction
Bug: 13238601
Change-Id: I7bd82a4678d8bf88f16bf271f20be8d37f9b97d7
2014-06-24 18:26:51 +09:00
Jean Chalard
d700e59700 Merge "Some cleanup to accommodate a fix" 2014-06-24 01:59:00 +00:00
Jean Chalard
132bdd079c Merge "[CS3] Move transformation of words to earlier" 2014-06-24 01:52:26 +00:00
Jean Chalard
8d3d0f3b84 Merge "[SD1] Move script-related methods to a new utils class." 2014-06-24 01:46:27 +00:00
Jean Chalard
289299bf66 [SD1] Move script-related methods to a new utils class.
Bug: 15840116
Change-Id: I3a2a9c41e40590c0116c7885a49c6fa308ed8f44
2014-06-26 18:24:11 +09:00
Jean Chalard
a3f7a5840a Don't commit a space before it's actually needed
Bug: 15740318
Change-Id: Idad06cb2c18335a981d5e9dea7eccf5e7ea8f701
2014-06-25 10:37:06 +09:00
Keisuke Kuroyanagi
dc6ee3a63f Merge "Enable beginning-of-sentence prediction." 2014-06-24 01:46:27 +00:00
Keisuke Kuroyanagi
2725cc17d7 Enable beginning-of-sentence prediction.
Bug: 14119293
Change-Id: I23c407f0afed0ae4af290a1195b0e3bbcd5af8d7
2014-06-24 12:37:09 +09:00
Keisuke Kuroyanagi
88fa47a27d Support migration/dump of Beginning-of-Sentence entries.
Bug: 14119293
Change-Id: Ie975138f819794d5c34a7a547be5a6117050e084
2014-06-24 12:37:07 +09:00
Keisuke Kuroyanagi
702e153fbc Merge "Support migration/dump of Beginning-of-Sentence entries." 2014-06-24 01:59:00 +00:00
Jean Chalard
a1d518ca88 Merge "[CS2] Refactor a bit removeDups" 2014-06-24 01:46:27 +00:00
Tadashi G. Takaoka
d92204b56a Merge "Reorganize Keyboard settings screen" 2014-06-23 21:50:10 +00:00
Tadashi G. Takaoka
058c6c6491 Reorganize Keyboard settings screen
This CL must be checked in together with Ie45df15b18.

Bug: 11866784
Change-Id: I44d6ceb45108be135e3eaa361f4ee2c83f04fb57
2014-06-23 18:46:09 -07:00
Tadashi G. Takaoka
84405d2a68 Fix some comments and rename method and parameter names
This is a follow up change of I12139a925d and I0ac92c56bd

Change-Id: Id6e9f4434fddd5d4274e06da5063606c2ffad932
2014-06-23 13:56:50 -07:00
Jean Chalard
1ec3f158d2 [CS3] Move transformation of words to earlier
Bug: 13238601
Change-Id: I37fe66c6152cdf8c60878d5619bb5dc41f3223df
2014-06-23 22:58:52 +09:00
Jean Chalard
fdebf4005f [CS2] Refactor a bit removeDups
This way is more understandable, and also supporting an
external string is helping for future refactorings

Bug: 13238601
Change-Id: I4ebeed46eb0b35011164946af71ac257c6449ddb
2014-06-23 22:58:46 +09:00
Jean Chalard
debe0dacbd Some cleanup to accommodate a fix
Also, this double tests for CODE_SPACE in the path going through
maybeDoubleSpacePeriod, but that's temporary.

Bug: 15740318
Change-Id: I0a6ace09cc791f0009157d3017675b9b3eb92145
2014-06-23 22:51:45 +09:00
Jean Chalard
e83e79cb05 [CS1] Some initial clean up
Bug: 13238601
Change-Id: I54ee9a85ecfee3c50c8db3eb4cd6f391a775a630
2014-06-23 22:19:09 +09:00
Jean Chalard
7d6bc4d063 Merge "[CS1] Some initial clean up" 2014-06-19 22:58:18 +00:00
Ken Wakasa
ffc843550c Merge "Revert "Reorganize Keyboard settings screen"" 2014-06-19 22:58:18 +00:00
Ken Wakasa
e6a57bc82e Revert "Reorganize Keyboard settings screen"
This reverts commit 339929ba16.

Bug: 11866784
Bug: 13888366
Bug: 15781377

This doesn't build with LOCAL_SDK_VERSION := 19 for UnbundledLatinImeGoogle.

Change-Id: Idf8bd335b076152265f245f578dadf651e291878
2014-06-23 11:20:25 +00:00
Tadashi G. Takaoka
339929ba16 Reorganize Keyboard settings screen
This CL must be checked in together with I6ebfbeb4e8.

Bug: 11866784
Bug: 15781377
Bug: 13888366
Change-Id: I57d47ab174d03121a604fd0dbf553795de0ab9b8
2014-06-22 22:37:26 -07:00
Tadashi G. Takaoka
593fe9b0cf Merge "Add click and long click actions to key node info" 2014-06-20 21:00:34 +00:00
Tadashi G. Takaoka
d4b6af14d8 Add click and long click actions to key node info
This CL adds ACTION_CLICK or ACTION_LONG_CLICK actions to a key node
info. But report a node info without these actions for the same key
while hovering to avoid announcement "double tap to select and double
tap and hold to long press".

Bug: 15727335
Change-Id: I1e9333c94c819d049bda81ad410299f5a509d29c
2014-06-20 18:25:25 -07:00
Tadashi G. Takaoka
d801b6ee66 Populate accessibility root node info of keyboard
Partially reverting Ie033d21ef8 to populate root node info.

This CL also fixes the bounds in screen of virtual node info.

Bug: 15746768
Bug: 15582251
Change-Id: I3a82f904270adf138036ef462fd70b349a3cd33e
2014-06-20 14:32:16 -07:00
Keisuke Kuroyanagi
d2e566f999 Fix unit tests by adding @UsedForTesting.
Change-Id: I62ec07210817295f59a174383ee4b33cc4fc2ca6
2014-06-20 16:27:46 +09:00
Tadashi G. Takaoka
e9d12c9f74 Merge "Refactor drawing preview classes" 2014-06-20 02:09:17 +00:00
Keisuke Kuroyanagi
9bbc3aa02a Merge "Move variables for I/O of a jni method to traverse session." 2014-06-19 22:55:19 +00:00
Tadashi G. Takaoka
294afba81f Merge "Reorganize Keyboard settings screen" 2014-06-21 03:15:09 +00:00
Tadashi G. Takaoka
496fd77850 Merge "Custom view for key preview popup" 2014-06-20 21:00:34 +00:00
Tadashi G. Takaoka
615f431465 Custom view for key preview popup
Bug: 15143928
Change-Id: I12411b9b5b9611ec089e4967def9b5c19a2367c7
2014-06-23 01:07:59 -07:00
Tadashi G. Takaoka
a74719c934 Fix dismissing more keys panel when hiding keyboard
This issue was introduced by Id7002ecb7f.

Bug: 15809493
Change-Id: Iaa51b7f40a54ccbafb45c6444d8bbd21c671f7af
2014-06-22 22:21:39 -07:00
Keisuke Kuroyanagi
f73769c638 Merge "Remove word from personalized dicts when it's canceled." 2014-06-19 22:55:19 +00:00
Keisuke Kuroyanagi
0fbca1ac23 Remove word from personalized dicts when it's canceled.
Bug: 15555552
Bug: 15552347
Change-Id: Ia4d8c79d079e3ce233d46d4bbad4fff1be5c5c39
2014-06-20 14:46:13 +09:00
Tadashi G. Takaoka
0f6f5b1fdc Merge "Disable empty suggestion word on the suggestions strip" 2014-06-20 02:04:45 +00:00
Tadashi G. Takaoka
ae42cd7e43 Disable empty suggestion word on the suggestions strip
It should be disabled when it is empty. But should be enabled even
when it is empty with accessibility exploration on to avoid announcing
"disabled".

Note that this CL may not be able to handle "suspending talk back"
state correctly. It should be handled by registering
TouchExplorationStateChangeListener that is available from API 19.

Bug: 15738513
Bug: 14849593
Change-Id: Id9ad89f770840f74a106f53833060407b20c1e24
2014-06-19 19:22:02 -07:00
Tadashi G. Takaoka
b80fb09ff8 Dismiss more keys panel when hiding window
Bug: 15727301
Change-Id: Id7002ecb7f4eea7be3505f6f0235074264418221
2014-06-19 11:42:32 -07:00
Tadashi G. Takaoka
f49e975740 Clear suggestions strip if a suggestion engine isn't attached
Bug: 15709298
Change-Id: I1b3fff3152960d85060149727d7a3422fea8a0bd
2014-06-18 18:47:34 -07:00
Tadashi G. Takaoka
7fb630b2a8 Refactor drawing preview classes
Change-Id: I0779caa720e3013f055ab48900bed223747b3952
2014-06-18 18:16:21 -07:00
Tadashi G. Takaoka
03288ef47f Refactor MoreKeysKeyboard.Builder a bit
Change-Id: I12139a925d59bb467df629cebc61423d61db1d2d
2014-06-18 18:06:17 -07:00
Tadashi G. Takaoka
d89a34b0a1 Merge "Hide voice input key from URI, Email, Number, and Phone layout" 2014-06-19 00:17:11 +00:00
Tadashi G. Takaoka
0351b81632 Hide voice input key from URI, Email, Number, and Phone layout
Bug: 15709298
Change-Id: I05d9433d4e1c2cc475a2136cc97bc32bde6fc745
2014-06-18 18:44:27 -07:00
Tadashi G. Takaoka
3ff72dd0da Consolidate 3 public methods of key preview into one
Change-Id: I0ac92c56bdb636998f7f5e20fba6830b4ac435fa
2014-06-18 10:05:59 -07:00
Keisuke Kuroyanagi
162f529e93 Move variables for I/O of a jni method to traverse session.
Bug: 15008504
Change-Id: I3e59bc856c1df0e1afe3b42d024620ca1745837b
2014-06-17 17:50:32 +09:00
Keisuke Kuroyanagi
4c45fff240 Merge "Fix: NPE when initializing AOSP keyboard." 2014-06-16 23:18:50 +00:00
Keisuke Kuroyanagi
34ed5b0742 Fix: NPE when initializing AOSP keyboard.
Bug: 15677822
Change-Id: Ibebb215a08795482c0f1eef965db06af57558906
2014-06-17 09:33:37 +09:00
Keisuke Kuroyanagi
37c49f63df Update suggestion strip when the contextual dict is updated.
Bug: 14161647
Change-Id: Ic7d53464bd051bffc8c7f8d097325321fe0aaee7
2014-06-16 18:30:59 +09:00
Keisuke Kuroyanagi
cb368a6dac Fix: Probability used for one word contextual phrase.
Bug: 14161647
Change-Id: Ia5f985ea467145fb381e3ad2c1f67f3b013f19e8
2014-06-16 18:20:33 +09:00
Jean Chalard
ccfc824a88 Merge "[CM2] Update beginning-of-sentence suggestions" 2014-06-10 22:31:57 +00:00
Jean Chalard
c715d95f17 [CM2] Update beginning-of-sentence suggestions
We need to update them after separator-space, and also when
the user presses shift and they are displayed.

Bug: 15554503
Change-Id: I5596163d5cd94d3cc5f6af10a1ab2cc74b6d4279
2014-06-16 18:44:43 +09:00
Jean Chalard
deccc23564 [CM1] Let predictions be aware of capitalize mode.
Bug: 15554503
Change-Id: If5e8c0d94ed26d929400ccbb0d45ac23dd98d180
2014-06-16 18:44:39 +09:00
Tadashi G. Takaoka
ad4f964a70 am 4f28b227: Update SDK version check due to I4716e71d72
* commit '4f28b22766e06b8c62636527393945114ea78002':
  Update SDK version check due to I4716e71d72
2014-06-13 19:20:40 +00:00
Tadashi G. Takaoka
a2e365da0a Stop announcing suggestions strip content while more keys keyboard is showing
This CL also supports announcing dismissing of a more keys keyboard.

Bug: 15582905
Change-Id: Ia9e5d6c7e3e23dac39ee570b20d32f0141ae6184
2014-06-14 01:29:45 +09:00
Tadashi G. Takaoka
4f28b22766 Update SDK version check due to I4716e71d72
Bug: 15603590
Change-Id: Ia2ac28a2dbf3e07678661d59e0aa6b4e6a536a02
2014-06-13 18:53:27 +09:00
Tadashi G. Takaoka
fd0d104fa7 Merge "Fix forwarding event only when sending view is visible" 2014-06-10 22:36:02 +00:00
Tadashi G. Takaoka
28593b5325 Fix forwarding event only when sending view is visible
Bug: 15579941
Change-Id: I25c19068ae4ad26b1ff64ffccf36ef8dd58ed295
2014-06-13 15:12:02 +09:00
Tadashi G. Takaoka
dc0c1e40be Merge "Add EmojiPageKeyboardAccessibilityDelegate" 2014-06-10 22:36:02 +00:00
Tadashi G. Takaoka
e9d9b37b5a Add EmojiPageKeyboardAccessibilityDelegate
Because EmojiPageKeyboardView doesn't use PointerTracker to handle
MotionEvent, a dedicated accessibility delegate is needed. Then the
recent tab can be updated even with accessibility mode on.

Bug: 15582599
Change-Id: I63d75b9aca21ec44f1f77d2eaaf2ba7813992183
2014-06-13 13:35:35 +09:00
Jean Chalard
8a23703763 Merge "[CM1] Let predictions be aware of capitalize mode." 2014-06-10 22:31:57 +00:00
Tadashi G. Takaoka
163f318545 Merge "Return an empty accessibility node info for a keyboard" 2014-06-10 22:31:57 +00:00
Tadashi G. Takaoka
9934740a5f Return an empty accessibility node info for a keyboard
Because a keyboard handling hover events and determining a virtual
node by itself, there is no need to supply whole virtual nodes info
for the keyboard. Just returning an empty accessibility node info
supresses annoucements of all keys.

This CL also fixes the undefined virtual id value.

Bug: 15582251
Change-Id: Ie033d21ef878d272417cf2b20f8eec1e516587f6
2014-06-13 16:44:59 +09:00
Tadashi G. Takaoka
1dbeb251b2 Use MoreKeysDetector for accessibility
A more keys keyboard may have a divider on it. The MoreKeysDetector
should be used even with accessibility mode on to be able to handle a
divider.

Bug: 15583354
Change-Id: Ife2cf8304496c4c330127fde8ca1f34c2f0838e2
2014-06-13 12:49:49 +09:00
Keisuke Kuroyanagi
6aa64e91ed Merge "Add clearContextualDictionary()." 2014-06-10 22:29:12 +00:00
Keisuke Kuroyanagi
60dad15f12 Add clearContextualDictionary().
Change-Id: Ia2f8d5640cde816cca23b26ee261acf44f3cdcdc
2014-06-16 17:01:14 +09:00
Keisuke Kuroyanagi
356539699a Add a method to update contextual dictionary.
Bug: 14161647
Change-Id: I2111f841c94e31d62b670da4236fc738df03a708
2014-06-16 17:00:12 +09:00
Keisuke Kuroyanagi
1a4d815b0b Contextual dictionary updater.
Bug: 14161647
Change-Id: I8106419678d5d26a4debec7bbef43af079c1ab18
2014-06-13 18:39:29 +09:00
Keisuke Kuroyanagi
d7a22c8439 Personalization dictionary updater.
Bug: 14161647
Change-Id: I7ab3d701525e9a19bc100aa577527e332bb2ad95
2014-06-13 16:31:12 +09:00
Keisuke Kuroyanagi
ec59371ff8 Merge "Block offensive words in native code." 2014-06-10 22:36:02 +00:00
Keisuke Kuroyanagi
59ed0c2db2 Block offensive words in native code.
Bug: 15300452

Change-Id: Ic6c91c47453e19fb5db2c62b66659619e72b1ecf
2014-06-12 11:36:00 +09:00
Keisuke Kuroyanagi
17f03583c8 Merge "Add a method to update contextual dictionary." 2014-06-10 22:31:57 +00:00
Keisuke Kuroyanagi
a4f2e8eee0 Merge "Contextual dictionary updater." 2014-06-10 22:31:57 +00:00
Yohei Yukawa
c1cb930dde Merge "Revert "Check OS codename for shouldOfferSwitchingToNextInputMethod"" 2014-06-10 22:29:12 +00:00
Yohei Yukawa
58e248ebda Revert "Check OS codename for shouldOfferSwitchingToNextInputMethod"
This reverts commit 1690992d1b.

Build.VERSION.SDK_INT is bumped with I4716e71d72b2526fe635079d1b.                                                                                     
We no longer need this workaround.

Change-Id: I75a1c2a7055af17a7d40291aadd62ae9bb42e056
2014-06-13 03:12:17 +00:00
Tadashi G. Takaoka
a68e0dd437 Fix NPE by disabling key preview popup of Emoji palette
Bug: 15579928
Change-Id: I6bcf885f2c1aa37b337a85978409ccf41e459c2a
2014-06-13 11:04:56 +09:00
Keisuke Kuroyanagi
da0ea7603b Merge "Add jni method for removeUnigramEntry()." 2014-06-10 22:31:57 +00:00
Keisuke Kuroyanagi
b4d77eca55 Add jni method for removeUnigramEntry().
Bug: 15552347
Change-Id: Iadcdc73d3335d561a27b9314d3fcdab0b0c96e49
2014-06-12 12:21:44 +09:00
Keisuke Kuroyanagi
81bd7e2007 Merge "Personalization dictionary updater." 2014-06-10 22:29:12 +00:00
Tadashi G. Takaoka
08199ec859 Clear PointerTracker state when more keys keyboard is dismissed
With accessibility mode on, hover events for a more keys keyboard are
handled among MoreKeysKeyboardAccessibilityDelegate and
MoreKeysKeyboardView. But the more keys keyboard is shown by
MainKeyboardAccessibilityDelegate that uses PointerTracker to handle
hover events. Thus we need to clear PointerTracker state when the more
keys keyboard is dismissed.

This is a workaround to resolve the issue. We should reconsider the
structure of those views and accessibility delegates in the future.

Bug: 15583751
Change-Id: Ida8c3e55194c59bdaa5bc4ff06068e699b888ced
2014-06-13 15:54:25 +09:00
Keisuke Kuroyanagi
4715baf93b Merge "Fix: Wrong name for ContextualDictionary." 2014-06-10 22:29:12 +00:00
Keisuke Kuroyanagi
3bedb9b3e6 Fix: Wrong name for ContextualDictionary.
Bug: 15557070
Change-Id: I5796df54a74c111d361da8c548e5597aba8e24d0
2014-06-11 19:58:22 +09:00
Tadashi G. Takaoka
6a96c508fd Fix logic to show suggestions
Bug: 15531465
Change-Id: Ic7fe5743ad3767cdaed699e5e2d1ebcaa75e22c2
2014-06-11 11:51:58 +09:00
Keisuke Kuroyanagi
447c19364a Merge "Enable Beginning-of-Sentence prediction for contextual dict." 2014-06-10 22:31:57 +00:00
Keisuke Kuroyanagi
22931cd941 Enable Beginning-of-Sentence prediction for contextual dict.
Bug: 14161647
Bug: 14119293
Change-Id: I0c00f13966db88e4de85e245e7bced43c9d474b2
2014-06-12 12:26:18 +09:00
Jean Chalard
d979d416c1 Merge "Special case periods in the spell checker" 2014-06-10 11:57:21 +00:00
Keisuke Kuroyanagi
cdfd2ce5a3 Merge "Add prefix to the arguments of getDictionary()." 2014-06-10 11:41:34 +00:00
Keisuke Kuroyanagi
f36da2fdba Merge "Make dump dictionary settings easily extensible." 2014-06-10 11:08:38 +00:00
Keisuke Kuroyanagi
a20432479d Make dump dictionary settings easily extensible.
This adds "Dump contextual dictionary".

Bug: 14161647
Change-Id: I41a6d6e131d9d8c300ac0120d903d46d88bb3346
2014-06-10 19:59:19 +09:00
Jean Chalard
4863a06544 Special case periods in the spell checker
Special case <valid word>.<valid word> to send as a suggestion
the same string where the periods is replaced by a space.

Bug: 10780091
Change-Id: I43c94675977f9ab5d7ee5671486cb742b39f3974
2014-06-10 19:52:58 +09:00
Keisuke Kuroyanagi
48b0074349 Merge "Purge dict reading code for 401 and create for 402." 2014-06-10 10:31:05 +00:00
Keisuke Kuroyanagi
07e1412631 Purge dict reading code for 401 and create for 402.
Change-Id: Ib0150b3306bb2db8aff443d1158fecc8464cbbdb
2014-06-10 19:22:40 +09:00
Keisuke Kuroyanagi
18df192535 Add prefix to the arguments of getDictionary().
Bug: 13630847
Change-Id: Ib4513b8cb6981e01dd33fd9703cc01646a2c7ccc
2014-06-10 18:05:10 +09:00
Jean Chalard
2d7feb5ad0 Merge "Split the sentences into words ourselves" 2014-06-10 08:18:36 +00:00
Keisuke Kuroyanagi
1ffb7cd448 Merge "Debug log when failed to add/remove n-gram entry." 2014-06-10 05:14:23 +00:00
Keisuke Kuroyanagi
354a59dfa4 Debug log when failed to add/remove n-gram entry.
Change-Id: Ibf0a4e01e1abc81b09aec104ba39d2ec18f4db8b
2014-06-10 13:04:57 +09:00
Jean Chalard
e689d37f72 Remove a useless method
Change-Id: I21a4219f682f43f4a84b1ab12d00dd930b35caa1
2014-06-10 12:47:55 +09:00
Jean Chalard
264afb10bd Merge "Remove mPrevWordsInfo" 2014-06-10 03:21:47 +00:00
Jean Chalard
367c199de1 Remove mPrevWordsInfo
This member has outlived its usefulness. It's not clear now that it
makes things really faster, but it does bring a lot of complexity
that we can avoid by removing it.

Change-Id: Ifbc8094a45b56b958fe165b1930f4cc358a97721
2014-06-10 12:07:51 +09:00
Tadashi G. Takaoka
874a600dc8 Add audio and haptic feedback for Emoji and Suggestions
Bug: 15378862
Change-Id: Ia14929bd9eb63ad5735cae0ad98ad0e2ad301128
2014-06-10 09:15:59 +09:00
Tadashi G. Takaoka
d022df49bd Merge "Set content descrition of words in suggestions strip" 2014-06-09 13:01:44 +00:00
Tadashi G. Takaoka
f3c852efad Set content descrition of words in suggestions strip
Bug: 14849593
Change-Id: If020e2352c8e950ce87dc4711c39b8a6a41f66fc
2014-06-09 21:40:36 +09:00
Jean Chalard
43ea8f6e77 Merge "Use RichInputConnection to get the previous word." 2014-06-09 10:47:28 +00:00
Jean Chalard
453711abe2 Use RichInputConnection to get the previous word.
We don't need the optimization of storing the old words now
that the RichInputConnection can supply it without IPC.

Bug: 13703802
Change-Id: I37ccb8d5fba879fb04b4f23d33571849736d897c
2014-06-09 19:43:20 +09:00
Jean Chalard
7a6bc607ca Split the sentences into words ourselves
The framework's default split is not suitable for all
languages. Also it does not perform very well when space
is mistyped as period.

Bug: 9063355
Bug: 10780091
Change-Id: I400d790ff1c29f221697fd94d79bbf67c61c7b8a
2014-06-09 19:38:03 +09:00
Tadashi G. Takaoka
48b96a6a52 Fix TalkBack descriptions of keyboard shift mode transition
Bug: 14846348
Change-Id: I32435a31f919974a506e598d1f3cc1b55a0866ae
2014-06-09 17:28:49 +09:00
Tadashi G. Takaoka
402e847477 Merge "Use rectangle region to ignore hover events after long press" 2014-06-09 07:56:41 +00:00
Tadashi G. Takaoka
862d7ec32e Merge "Refactor KeyCodeDescriptionMapper class a bit" 2014-06-09 07:56:28 +00:00
Tadashi G. Takaoka
176f803176 Use rectangle region to ignore hover events after long press
Bug: 15500282
Bug: 15501718
Change-Id: Ia4771198c3120a980b0a2cdd210928a4f47f5b83
2014-06-09 16:32:19 +09:00
Tadashi G. Takaoka
24fab555f9 Refactor KeyCodeDescriptionMapper class a bit
This CL adds getDescriptionForCode() method.

Bug: 15500282
Change-Id: I3bb92c8f356ea623fc992c924506b11e09256e98
2014-06-09 16:28:30 +09:00
Keisuke Kuroyanagi
7f0316c27e Merge "Add distracter cache to optimize the distracter test." 2014-06-09 05:35:46 +00:00
Keisuke Kuroyanagi
9f02a67c77 Merge "Fix: NPE after turning on personalized suggestion." 2014-06-09 05:35:32 +00:00
Keisuke Kuroyanagi
104b582c35 Add distracter cache to optimize the distracter test.
Bug: 13142176
Bug: 15428247
Change-Id: Ia390b148ffb36ace6c2010daf0f14838492413e8
2014-06-09 12:39:06 +09:00
Keisuke Kuroyanagi
65cf23eb38 Fix: NPE after turning on personalized suggestion.
Bug: 13142176
Bug: 15428247
Change-Id: I236202e3c1b70a11d512c946798035087945c0ac
2014-06-09 12:26:59 +09:00
Keisuke Kuroyanagi
a2a4ee2765 Merge "Check isInDictionary() before the distracter test." 2014-06-09 02:53:33 +00:00
Keisuke Kuroyanagi
bdf745da32 Check isInDictionary() before the distracter test.
Bug: 13142176
Bug: 15428247
Change-Id: I7ce2c09ebbef6ca8c056807c2a35f2f987fd436e
2014-06-09 11:43:45 +09:00
Keisuke Kuroyanagi
79e2e9fa8c Merge "Add Dictionary.isInDictionary()." 2014-06-09 02:40:39 +00:00
Keisuke Kuroyanagi
1910392eed Add Dictionary.isInDictionary().
Bug: 13142176
Bug: 15428247
Change-Id: If2d1c1fea7a69e41809a828da8dd032211ad144e
2014-06-09 11:04:28 +09:00
Tadashi G. Takaoka
dec599d172 Fix overwriting accessibility delegate in setKeyboard
A keyboard accessibility delegate object should be a singleton for
each keyboard view.

Bug: 15437933
Bug: 15419386
Change-Id: Ia70853c644d950ea6130c1f209b89929b1cb1ee5
2014-06-08 22:12:52 +09:00
Tadashi G. Takaoka
2385314be0 Merge "Refactor logic to determine showing suggestions strip or not" 2014-06-06 10:48:00 +00:00
Keisuke Kuroyanagi
7640bb1505 Merge "Make Distracter filter use getMaxFrequencyOfExactMatches()." 2014-06-06 10:44:04 +00:00
Tadashi G. Takaoka
987bff9136 Refactor logic to determine showing suggestions strip or not
The logic to determine when the suggestions strip (a.k.a. the
contextual strip) should be shown is already complex. In addition to
that the voice input key get shown on the strip as well. There are a
several factors to be considered and a few things to control.

- The password input field shouldn't have the strip.
- Show voice input key on the strip or not.
  - User preference settings "Show Voice Input Key".
  - A voice IME exists and is enabled.
  - The input field may have a private IME option to prevent the voice
    input key from being displayed.
- Application can specify auto completions.
  - Full screen mode or not.
- User preference settings "Show correction suggestions".
  - Always show, Show in portrait mode, Always hide.
- The input field may have flags to prevent showing suggestions or
  auto corrections.
- Suggestions is empty or not.
- An important notice may be shown.

Bug: 14981852
Bug: 15436479
Change-Id: I3050fd53ee6271fc64a8f17b6b12d9581d37b750
2014-06-06 19:41:21 +09:00
Keisuke Kuroyanagi
166d8c2293 Make Distracter filter use getMaxFrequencyOfExactMatches().
Bug: 13142176
Bug: 15428247

Change-Id: I5c23fbea2851f891f76f19d9da2cb70ae964569b
2014-06-06 19:38:44 +09:00
Keisuke Kuroyanagi
8cae9f50b4 Merge "Implement getMaxProbabilityOfExactMatches()." 2014-06-06 08:39:40 +00:00
Keisuke Kuroyanagi
d9b8602f48 Implement getMaxProbabilityOfExactMatches().
Bug: 13142176
Bug: 15428247
Change-Id: I5be6d683be95505412615ca7c88260de1ea05f54
2014-06-06 17:37:46 +09:00
Jean Chalard
6464d73ad9 Merge "When starting input, include the literal word in suggestions" 2014-06-06 07:27:40 +00:00
Tadashi G. Takaoka
bd3b20ce73 Merge "Always update voice key visibility" 2014-06-06 07:14:28 +00:00
Jean Chalard
fca2c4b439 When starting input, include the literal word in suggestions
This change also includes a fix that has suggestions re-computed
when the typed word is included but no prior suggestions were
found in spans.

Bug: 2349475
Change-Id: Ic06e6ac492507126ffc1e96a5f396c971b567272
2014-06-06 16:00:18 +09:00
Jean Chalard
eb771b9dc4 Merge "Fix a small bug with rotation." 2014-06-06 06:34:00 +00:00
Jean Chalard
c69ba5630d Fix a small bug with rotation.
Bug: 2349475
Change-Id: Id4aa5ce56b1a545e4cb88ca1b01cf24642deade2
2014-06-06 14:06:29 +09:00
Tadashi G. Takaoka
aa4b2c7127 Always update voice key visibility
Bug: 15128166
Change-Id: Ie15724c323efa3b102f6aebddc3bda210aad1727
2014-06-06 13:18:41 +09:00
Tadashi G. Takaoka
3ca65c8fd5 Remove unused supportsSwitchingToShortcutIme attribute
Change-Id: I51c5247ac925a158facb79057f704b763b903552
2014-06-06 13:11:57 +09:00
Tadashi G. Takaoka
b7206b6bca Merge "Add action key test for Lxx theme" 2014-06-06 04:08:40 +00:00
Tadashi G. Takaoka
c5dc740673 Add action key test for Lxx theme
Change-Id: I849cec7deb5607e8ce8fb25c1f903f15328fb611
2014-06-06 12:56:57 +09:00
Jean Chalard
70ff0c2122 Merge "Fix a bug on rotation with selection." 2014-06-06 03:12:12 +00:00
Jean Chalard
9fd9a68d87 Fix a bug on rotation with selection.
The symptom : when text is selected and the device is rotated,
sometimes the keyboard sets the word as being composed around
the start of the selection. Upon the next rotation this ends up
with the keyboard committing some text in place of the selection.

The cause : another bug in the framework with rotation >.>
The keyboard receives a call to startInput with a wrong cursor
position, namely one that does not represent a selection. The
keyboard sets a composition according to this wrong data. When
the keyboard is rotated again, it commits the text, which takes
the place of the selection.

The solution : actually when restarting input the keyboard
realizes that the cursor position is wrong. We cancel composition
at that time.
For robustness, this change also implements two other defensive
changes : upon call to onUpdateSelection, we actually realize
that the previous values were wrong, so we also fix it at that
time, and in addition, when rotating, we finishComposingText()
instead of commitText() which is less dangerous. Implementing
this later change also allows us to let less internal variables
from InputLogic escape to LatinIME, so it's also a good change
for design.

Bug: 14140799

Change-Id: Ib10de18e53e376ac1bbc8487e13d969828483346
2014-06-06 11:18:23 +09:00
Keisuke Kuroyanagi
0ee8644666 Merge "Add getMaxFrequencyOfExactMatches() to Dictionary." 2014-06-05 10:07:59 +00:00
Keisuke Kuroyanagi
d988fcc93d Add getMaxFrequencyOfExactMatches() to Dictionary.
Bug: 13142176
Bug: 15428247
Change-Id: I93b44ef40cafb6b811c68fa79f3a4971fc3916a5
2014-06-05 19:05:58 +09:00
Tadashi G. Takaoka
0dbf15f152 Merge "Rename some boolean variables for readability" 2014-06-05 09:33:05 +00:00
Tadashi G. Takaoka
a12d431c86 Merge "Refactor show voice key preferece migration code" 2014-06-05 09:33:03 +00:00
Tadashi G. Takaoka
2e32e37d5b Rename some boolean variables for readability
Change-Id: I434cf507e68349b9893ac084645986d6b3d7da91
2014-06-05 18:18:46 +09:00
Keisuke Kuroyanagi
d6b89e17a6 Add jni method for getMaxFrequencyOfExactMatches().
Bug: 13142176
Bug: 15428247
Change-Id: I2ae25090b67ad0c6df97dec7712e2f7e0bb08c40
2014-06-05 18:16:11 +09:00
Tadashi G. Takaoka
fcaf47f007 Refactor show voice key preferece migration code
Change-Id: I4f13e85a3db1ba4adf36c596cb23827bdcf93ae7
2014-06-05 15:23:58 +09:00
Jean Chalard
9d4d61f9c1 Merge "Allow multiple shortcuts for a personal dictionary word" 2014-06-04 13:32:45 +00:00
Tadashi G. Takaoka
aea429200e Support more suggestions accessibility mode
Bug: 12491371
Change-Id: Ib01452b6a2a53faa591b05e62014f356e0511308
2014-06-04 19:45:38 +09:00
Tadashi G. Takaoka
86e1e1f97c Merge "Support more keys accessibility mode" 2014-06-04 10:23:16 +00:00
Tadashi G. Takaoka
62316d7e82 Support more keys accessibility mode
Bug: 12491371
Change-Id: Ib1fc8affbccfbaca3424ecdc2812f47047106aa2
2014-06-04 19:13:41 +09:00
Jean Chalard
f8b4524c0e Allow multiple shortcuts for a personal dictionary word
Bug: 13869301
Change-Id: Icd77a308f85cc16dccffe65a532471c738d6fbc5
2014-06-04 18:01:50 +09:00
Tadashi G. Takaoka
70a1352cb9 Merge "Add onRegisterHoverKey to accessibility delegate" 2014-06-04 08:56:48 +00:00
Tadashi G. Takaoka
1a0cd0869d Add onRegisterHoverKey to accessibility delegate
Bug: 12491371
Change-Id: I8c5b1e91f41146a023edcc405e6120c0bf33f49b
2014-06-04 17:49:48 +09:00
Jean Chalard
4c91142771 Merge "Don't recapitalize just at the start of input" 2014-06-04 08:29:20 +00:00
Jean Chalard
07706dc347 Merge "Refactoring" 2014-06-04 07:43:31 +00:00
Jean Chalard
c84b10840e Don't recapitalize just at the start of input
Bug: 13283555
Change-Id: Iab0466425dc44779d110f2cd29d725d22eb04827
2014-06-04 16:29:31 +09:00
Jean Chalard
4a1113b6b0 Refactoring
Rename `initialize' to `start' and `deactivate' to `stop' for ease
of understanding. It's completely bizarre that you can "deactivate"
a recapitalization and that will just restart a new one the next time
you press shift. Start and stop are easier to understand.

Change-Id: I455175aebfcfe11198c6c61bf2c6b19efc3f82df
2014-06-04 16:29:29 +09:00
Tadashi G. Takaoka
a2b7c07e68 Merge "Revert "Pass hover event to accessibility key handling methods"" 2014-06-04 07:20:21 +00:00
Tadashi G. Takaoka
2c35f3bdd5 Revert "Pass hover event to accessibility key handling methods"
It turns out passing hover event to accessibility key handling methods
isn't necessary. This parically reverts I1f7feef707.

Bug: 12491371
Change-Id: I9d71cd29723344433427795e44cb22ac41faace6
2014-06-04 16:04:36 +09:00
Yohei Yukawa
5a3a7e3d8a Merge "Add a preference item for metrics logging" 2014-06-04 05:07:03 +00:00
Tadashi G. Takaoka
6e00de046a Merge "Reorder keys around the spacebar" 2014-06-04 04:04:28 +00:00
Yohei Yukawa
28c7b262aa Add a preference item for metrics logging
BUG: 14324207
Change-Id: Idc8582655bc73cb24e416e8ba78470209b2ff702
2014-06-04 13:02:42 +09:00
Tadashi G. Takaoka
dc62c711aa Reorder keys around the spacebar
This CL reorders keys around the spacebar.
- On phone's symbols and symbols shift layout, the comma key is moved
  to the left of the spacebar to aligned with main layout.
- On tablet's layout, the comma key is moved to the left of the
  spacebar on all layout to aligned with the same layout of
  phone's. Also the comma key has "settings" as more keys.
- In Arabic and Perisan, the comma key of tablet already has some more keys
  This CL remove "/" and add "settings" instead.

Bug: 15281451
Change-Id: I6e0e75e4d4abfb1f356e7499be91424c7c57c58b
2014-06-04 00:45:25 +09:00
Tadashi G. Takaoka
ae0fab9550 Load KeyCodeDescriptionMapper class lazily
Change-Id: I2cba2bb5b2f449ed29895365b9c6ca285a7640fe
2014-06-03 18:15:59 +09:00
Tadashi G. Takaoka
9a2162e6f2 Merge "Fix synthesizing MotionEvent" 2014-06-03 07:32:52 +00:00
Tadashi G. Takaoka
2351b4f74f Fix synthesizing MotionEvent
KeyboardAccessibilityDelegate.synthesizeTouchEvent() wrongly passed
pointer's id as a 6th argument of MotionEvent.obtain method that
should be metaState.

Change-Id: I822f9647a1ba27ee8cee39f373f6a1c003ebf665
2014-06-03 14:46:36 +09:00
Tadashi G. Takaoka
7a750ca50d Fix PointerTracker debug output to reflect new KeyDetector
Change-Id: I913ec290ddfd0ae4cc6e600ba95b7442167f0989
2014-06-03 14:32:40 +09:00
Tadashi G. Takaoka
a32803cefe More concise Key.toString()
Change-Id: I0ef983f54e828193e9c7e4a10c888f72702d499c
2014-06-03 13:32:42 +09:00
Tadashi G. Takaoka
d427d3b0fa Merge "Create AccessibilityDelegate only when accessibility mode is on" 2014-06-02 10:12:52 +00:00
Jean Chalard
28538d916c Merge "Fix an IOOB exception" 2014-06-02 10:07:12 +00:00
Tadashi G. Takaoka
d78b586976 Create AccessibilityDelegate only when accessibility mode is on
Change-Id: I4cbae476d16723778b46ff765dd97832f279785f
2014-06-02 18:53:58 +09:00
Jean Chalard
d660f3bec9 Fix an IOOB exception
Bug: 14602663
Change-Id: Ie2060931df911b44230d5a5ba268f687cbdd0dc8
2014-06-02 18:21:50 +09:00
Tadashi G. Takaoka
a021395e84 Pass hover event to accessibility key handling methods
Bug: 12491371
Change-Id: I1f7feef707b95e8862db71cbc4f6f5585a2441dd
2014-06-02 17:13:47 +09:00
Tadashi G. Takaoka
d0b79cc12a Add verbalization of symbols that are unsupported by TTS/TalkBack
Bug: 13336905
Change-Id: Iefd117fa7b30b8ba240590b13b03d7044fd37ede
2014-06-02 17:02:38 +09:00
Tadashi G. Takaoka
82674ca81c Fix to clear on hover visual cue
Bug: 12491371
Change-Id: Ib7ca91ae73aa40e45ea5f6d4e53348a261a4b823
2014-06-02 14:57:52 +09:00
Tadashi G. Takaoka
fa9b9578d4 Refactor MoreKeysKeyboardView a bit
Bug: 12491371
Change-Id: I3ce1e6557e41a94146b882751f75ae4b5f6bc73d
2014-06-02 12:41:50 +09:00
Tadashi G. Takaoka
509d07c764 am 61a8a66c: Merge "Workaround to draw spacebar icon of emoji palettes" into lmp-preview-dev
* commit '61a8a66ccac1de7e146344dd77c8be84aa8daf33':
  Workaround to draw spacebar icon of emoji palettes
2014-05-30 15:03:10 +00:00
Tadashi G. Takaoka
3558505bee Workaround to draw spacebar icon of emoji palettes
Bug: 15321822
Change-Id: Iab7cef83ffdf91c877c3ed2e59d412496b516e1c
2014-05-30 22:53:24 +09:00
Keisuke Kuroyanagi
8f71fab2ed Make prevWord = null if the next word starts from a connector.
This fixes PunctuationTests#
testAutoCorrectionWithSingleQuotesAround.

Bug: 14119293
Bug: 15334309

Change-Id: I604c21a21e89a5fc431fd56ab7b6ad03f4736b01
2014-05-30 20:30:17 +09:00
Jean Chalard
fa0e76dde6 Limit recapitalization for reasonable performance.
At 100k text, it's reasonably fast (less than 1s on latest hardware).

Bug: 12913404
Change-Id: I426b918b2610af24364934a1c37a7314f1142ad0
2014-05-30 18:04:39 +09:00
Tadashi G. Takaoka
6fe326ae42 am 761a6812: Don\'t reuse main keyboard\'s spacebar icon for Emoji palette
* commit '761a6812312c48d04bcb91e5c4448364c4925731':
  Don't reuse main keyboard's spacebar icon for Emoji palette
2014-05-29 15:06:36 +00:00
Tadashi G. Takaoka
761a681231 Don't reuse main keyboard's spacebar icon for Emoji palette
Bug: 15321822
Change-Id: I6a5a865364fb98e0ebb6206d80d5629bbcb817b8
2014-05-29 23:32:03 +09:00
Tadashi G. Takaoka
aaf2bbf9c3 Merge "Remove LatinImeLogger and UsabilityStudyLogUtils" 2014-05-29 09:33:25 +00:00
Tadashi G. Takaoka
51ee5a47b8 Remove LatinImeLogger and UsabilityStudyLogUtils
This CL must be checked in together with Ie52007dc5c.

Bug: 15318007
Change-Id: Ie665f296e43b5485ae8ba7e949aa262794ee0dcc
2014-05-29 18:03:03 +09:00
Keisuke Kuroyanagi
c4a3b9f0d6 Merge "Remove PrioritizedSerialExecutor." 2014-05-29 08:52:23 +00:00
Jean Chalard
944923f266 Fix: too many calls to getSuggestedWordsForTypingInput
This reverts commit d941ea18 and builds on it to fix the behavior
of the broken cases.
It also fixes a small, related bug that probably has existed for
a very long time: predictions not displayed when cancelling
double-space-to-period.

Bug: 15148015
Change-Id: I1f9358f8b6f5804f831643611576be347e83999d
2014-05-29 17:36:46 +09:00
Keisuke Kuroyanagi
94f88b4881 Remove PrioritizedSerialExecutor.
Bug: 15320560
Change-Id: Icb88a96ebd685da1d2cba7b07889a2751c603a2e
2014-05-29 17:36:32 +09:00
Tadashi G. Takaoka
262b1e7518 Merge "Remove researcher logger" 2014-05-29 07:30:16 +00:00
Tadashi G. Takaoka
bbf556e8e1 Remove researcher logger
This CL must be checked in together with I5cc76807e3.

Bug: 15318007
Change-Id: I61423c3377ddc299fb332e742d6626c2e47145bb
2014-05-29 15:10:28 +09:00
Keisuke Kuroyanagi
7d57fc248b Clean up for Iba6eeb7981634e7ddb.
Bug: 15298959
Change-Id: I6921db77b7d231ad3aad99d4c380ae2ed6bbf540
2014-05-29 13:16:24 +09:00
Keisuke Kuroyanagi
4bffac6db9 Stop directly checking SuggestedWordInfo.mKind
Bug: 15298959

Change-Id: Iba6eeb7981634e7ddb896404978b30f6efd6e72f
2014-05-28 20:35:45 +09:00
Tadashi G. Takaoka
f2b995769b Merge "Support fine grained hover event handling" 2014-05-28 05:53:53 +00:00
Tadashi G. Takaoka
14ea11fcde Add TODO comment about SuggestedWordInfo's kind and flags
This CL must be checked in together with I6fd87e1eec.

Change-Id: I4b24157f3e3ce6327579d37122a34d7a30069885
2014-05-28 11:51:05 +09:00
Tadashi G. Takaoka
639e431fa2 Support fine grained hover event handling
This CL also adds visual feedback of hovering key in accessibility
mode.

Bug: 12491371
Change-Id: I7b1f28a2e421ca60b2738ed94e7bdb406f75039b
2014-05-28 10:47:09 +09:00
Tadashi G. Takaoka
d3642a2a58 Merge "Refactor KeyboardAccessibilityDelegate class a bit" 2014-05-27 09:54:56 +00:00
Tadashi G. Takaoka
87d2f3ea0e Refactor KeyboardAccessibilityDelegate class a bit
Bug: 12491371
Change-Id: I2c2c6f3a6d0d7e7efbe0253127f5b9117cbc512d
2014-05-27 17:33:20 +09:00
Keisuke Kuroyanagi
dfca51726e Return whether the dynamic dict operation was success.
Bug: 12184250
Change-Id: Iee7e00c1e84c95551a077f4dd023c0a9b9ac9466
2014-05-27 17:30:00 +09:00
Keisuke Kuroyanagi
26628eeb4b Merge "Add thread name for PrioritizedSerialExecutor." 2014-05-27 07:24:26 +00:00
Tadashi G. Takaoka
ced6788518 Merge "Remove compiler warning from accessibility package" 2014-05-27 07:18:25 +00:00
Keisuke Kuroyanagi
6a546147eb Merge "Stop filtering out when perfect freq > top non-perfect freq." 2014-05-27 07:14:16 +00:00
Keisuke Kuroyanagi
00da83ed75 Stop filtering out when perfect freq > top non-perfect freq.
Bug: 13142176
Change-Id: I0290df918a5bd5018bf55231dc462d5e797155c6
2014-05-27 16:09:59 +09:00
Keisuke Kuroyanagi
733a9c09a9 Add thread name for PrioritizedSerialExecutor.
Bug: 15270123
Change-Id: I655ba97f0543476980d0e8461bc1c8a56c9f954b
2014-05-27 16:06:08 +09:00
Tadashi G. Takaoka
a80d55d4d3 Remove compiler warning from accessibility package
Change-Id: Idae3e89f0398ab2cd56985adfac18959aa1852e7
2014-05-27 15:24:39 +09:00
Tadashi G. Takaoka
01748cde4e Move MoreSuggestionsListener to MoreSuggestionsView
Change-Id: I3b5bc630bf73a357ed0beeec0b555149ef248313
2014-05-27 14:49:25 +09:00
Tadashi G. Takaoka
9647d7fbee Use onHoverEvent instead of dispatchHoverEvent
This CL also refactors KeyboardAccessibilityDelegate a bit to be able
to override on hovering methods that handle enter, move, and exit on a
key.

Bug: 12491371
Change-Id: I3c7e81ccb8729ae6e466c654efde0c18ed734bdf
2014-05-27 11:28:52 +09:00
Tadashi G. Takaoka
f6d59f6a6b Merge "Announce the same key again" 2014-05-27 02:18:59 +00:00
Tadashi G. Takaoka
a1b47eb446 Announce the same key again
Bug: 15237246
Change-Id: Ie7023b727cb3eca9d0727a511b3d64a32a02cd3d
2014-05-27 10:57:53 +09:00
Tadashi G. Takaoka
7b5bccc066 Use "unknown emoji" or emoji that has an empty translation
Because the number of emoji description spoken string resources is
rather huge (~800), some locales may chose an empty description as a
translation. If that is the case, we will announce "unknown emoji" as
a fallback.

Bug: 11452158
Change-Id: Ibb65e5bec93030c40bd33ac2be2115c3bbc8bd11
2014-05-27 10:48:03 +09:00
Keisuke Kuroyanagi
71c795d00b Merge "Apply distracter filter for UserHistoryDictionary." 2014-05-26 16:28:23 +00:00
Keisuke Kuroyanagi
17bd4eb0c9 Apply distracter filter for UserHistoryDictionary.
Bug: 13142176
Change-Id: I67d63a5c789d7c587bcd7abacd26b2e76da11978
2014-05-27 01:10:04 +09:00
Keisuke Kuroyanagi
f85b478cd8 Merge "Apply distracter filter for in-vocabulary words." 2014-05-26 14:25:17 +00:00
Keisuke Kuroyanagi
ba33831d76 Apply distracter filter for in-vocabulary words.
Bug: 13142176
Change-Id: I4db763783a2f8b9a0df0df951db3223f70748870
2014-05-26 23:11:24 +09:00
Keisuke Kuroyanagi
0088d1f668 Merge "Use whether it's exact match to detect distracters." 2014-05-26 13:53:19 +00:00
Keisuke Kuroyanagi
a6278eb9c1 Use whether it's exact match to detect distracters.
Bug: 13142176
Change-Id: Id5b7286d28897931f7bfe571be45d46ffeef4adf
2014-05-26 21:56:20 +09:00
Tadashi G. Takaoka
9df51d10fa Keep showing important notice when "show correction suggestions" is off
When
 1. The important notice message is shown on the suggestions strip.
 2. And the "Show correction suggestions" settings is off.
we will keep showing the important notice message on the suggestion
strip.

Bug: 13741460
Change-Id: I411007ab1e5e6959b6cdba7a6601a84635259313
2014-05-26 14:11:41 +09:00
Tadashi G. Takaoka
4905d83270 Merge "Release and register current key when emoji palette is hidden" 2014-05-25 13:09:15 +00:00
Tadashi G. Takaoka
0380421bf7 Release and register current key when emoji palette is hidden
Bug: 13290802
Change-Id: Ib087152f8bd47a5c81901377291e4223ee4a49ec
2014-05-25 10:54:15 +09:00
Tadashi G. Takaoka
1f217dbd51 Use functional key background for action key with label
This CL also adds label_search_key string resources for consistency.

Bug: 15135033
Change-Id: I81cae243e83a590ef56fe758a43c7184fc4159aa
2014-05-24 21:26:47 +09:00
Tadashi G. Takaoka
630a24141e Use ViewCompat support library and delete ViewCompatUtils
Change-Id: I57d60cacd86e83894294c3f64402aba8c1829872
2014-05-24 12:26:30 +09:00
Tadashi G. Takaoka
790934158d Revert "Use ViewCompat support library and delete ViewCompatUtils"
This reverts commit db21267b78.
The reverting change breaks build in unbundled jb-ub-latinimegoole branch.

Change-Id: Ia61424f5321eb97f981d22c4b08e9ea8d348f6c1
2014-05-23 18:31:43 +00:00
Tadashi G. Takaoka
db21267b78 Use ViewCompat support library and delete ViewCompatUtils
Change-Id: Ifee496ff7ecaf361898444ff4127f16748d96422
2014-05-24 02:13:52 +09:00
Tadashi G. Takaoka
7a76350b7b Merge "Enable "show language switch key" settings on K and before" 2014-05-23 16:43:37 +00:00
Tadashi G. Takaoka
6726bc9001 Merge "Use Java 7 diamond operator" 2014-05-23 16:43:12 +00:00
Tadashi G. Takaoka
e3bfb825f5 Merge "Consolidate attributes to EmojiPaletteView to control indicators" 2014-05-23 16:42:50 +00:00
Tadashi G. Takaoka
a91561aa58 Use Java 7 diamond operator
Change-Id: If16ef50ae73147594615d0f49d6a22621eaf1aef
2014-05-24 01:05:42 +09:00
Tadashi G. Takaoka
7ed40a13cc Enable "show language switch key" settings on K and before
"Show language switch key" and "Switch to other IME" settings are
enabled on KitKat and before. On L and later, its preference settings
UI gets hide and the settings values are forcibly set to true.

Bug: 14854377
Change-Id: I10456408452280a1b7688fd1f168933937666c9f
2014-05-24 00:58:24 +09:00
Keisuke Kuroyanagi
9f9988e996 Merge "Introduce EMPTY_PREV_WORDS_INFO and BEGINNING_OF_SENTENCE." 2014-05-23 14:53:13 +00:00
Ken Wakasa
991c9026b9 Merge "Revert "Fix: too many calls to getSuggestedWordsForTypingInput"" 2014-05-23 14:34:36 +00:00
Ken Wakasa
d941ea1826 Revert "Fix: too many calls to getSuggestedWordsForTypingInput"
This reverts commit 7aa895e2e3.

Bug: 15148015
Change-Id: If39c4f8b897f247d4eb935923d55d81def4c8fb4
2014-05-23 14:34:06 +00:00
Keisuke Kuroyanagi
a790c5b683 Introduce EMPTY_PREV_WORDS_INFO and BEGINNING_OF_SENTENCE.
Bug: 14119293
Change-Id: I5020e5f0aa64bc3e97b3a3c2c07a60c8b765ed64
2014-05-23 23:19:33 +09:00
Keisuke Kuroyanagi
a37f374ad1 Version up dynamic dict format from 401 to 402.
Change-Id: Ibea36af905ade773ae3db3a5456f7b5a0ad7d220
2014-05-23 20:20:56 +09:00
Keisuke Kuroyanagi
1adca93381 Extend jni methods and enable Beginning-of-Sentence.
Bug: 14119293
Change-Id: I78fc877367dd0d6240eeacb750b6d2d0b93cba83
2014-05-23 19:58:58 +09:00
Keisuke Kuroyanagi
85befc0873 Merge "Make DistracterFilter interface." 2014-05-23 10:11:57 +00:00
Jean Chalard
52fdaa2cd8 Merge "Fix some auto-caps problems: - (mainly for Spanish) auto-caps after inverted bang and what - (German only) don't auto-cap after digits-period-space" 2014-05-23 09:42:56 +00:00
Jean Chalard
e8e463832f Merge "Increase the DB version for the next release." 2014-05-23 09:18:22 +00:00
Jean Chalard
cfdb1b8d26 Fix some auto-caps problems:
- (mainly for Spanish) auto-caps after inverted bang and what
- (German only) don't auto-cap after digits-period-space

Bug: 15177663
Bug: 12206753
Change-Id: Ia214bc067319469d9debbbfbdcb1dcff980847f0
2014-05-23 18:17:09 +09:00
Keisuke Kuroyanagi
f498e53933 Make DistracterFilter interface.
Bug: 13142176
Bug: 15094186
Change-Id: If94b0a155b5ea2ff6b839e7da9d12a9cc6553931
2014-05-23 18:12:37 +09:00
Keisuke Kuroyanagi
1fa3e9044f Move distracter filter to dictionary facilitator.
Bug: 13142176
Bug: 15094186
Change-Id: Ib9e42f8e25538009f3ba62cf1e034cae3f6823c7
2014-05-23 16:10:36 +09:00
Tadashi G. Takaoka
2782f97927 Consolidate attributes to EmojiPaletteView to control indicators
This CL consolidates attributes of EmojiTabWidget and
EmojiCategoryPageIndicatorView with EmojiPaletteView.

Bug: 15151483
Change-Id: I6eca10b60e894d945080ef3f88523d539a4992fa
2014-05-23 16:09:00 +09:00
Keisuke Kuroyanagi
a1035be6d8 Have DictionaryFacilitator in LatinIME.
Bug: 13142176
Bug: 15094186
Change-Id: I9da67352ff2abcd289fa5885389895ced878a413
2014-05-23 09:30:55 +09:00
Keisuke Kuroyanagi
a2ce9a49ac Fix NPE happening in unit tests.
Change-Id: I2fc0dba53e18883755ff77351c152a9d3534c92b
2014-05-22 21:57:07 +09:00
Jean Chalard
483650fd1c Increase the DB version for the next release.
Bug: 15065819

Change-Id: Ie43660109002fdb25ce68d7e64506ada0e15e621
2014-05-22 18:01:37 +09:00
Yohei Yukawa
7c6f57d147 Merge "Add a new production flag for metrics logging" 2014-05-22 08:30:20 +00:00
Tadashi G. Takaoka
641205481a Merge "Add spoken description of accented letters" 2014-05-22 08:17:53 +00:00
Yohei Yukawa
17eeecdf49 Add a new production flag for metrics logging
BUG:14909963
Change-Id: I2d48c5b7d959d9bb95afe2cd3cbd16b27092a054
2014-05-22 16:57:52 +09:00
Jean Chalard
9b3d55fd1a Merge "Check the md5 checksum of the copied file." 2014-05-22 07:38:08 +00:00
Keisuke Kuroyanagi
9218c51129 Fix: NPE in DistracterFilter
Change-Id: I19a92d79cf547aae8f15e7e5fd5309812ae4f2d5
2014-05-22 16:33:45 +09:00
Tadashi G. Takaoka
fee4073f51 Add spoken description of accented letters
Bug: 15149856
Change-Id: I72f209fc3fdf619b3929325e2a810aa3c0bd1caa
2014-05-22 16:31:21 +09:00
Jean Chalard
9087d19fc0 Check the md5 checksum of the copied file.
If it doesn't match, mark it broken. It means the dictionary pack
will try to install it again next time it updates. We may want to
rethink this.

Bug: 13125743
Change-Id: I0eb547aa7066bed8cb00c009debbafe9181c37ad
2014-05-22 14:19:46 +09:00
Keisuke Kuroyanagi
5e2c4c0297 Merge "Use enabled subtypes for Keyboard in DistracterFilter." 2014-05-22 04:50:47 +00:00
Jean Chalard
68f46d9c2f Merge "Don't upcase suggestions when resuming on an uppercase word" 2014-05-22 03:57:38 +00:00
Jean Chalard
814cf03470 Merge "Arrange to send the rawChecksum to LatinIME." 2014-05-22 03:18:52 +00:00
Jean Chalard
2df6374ffa Merge "Fix: too many calls to getSuggestedWordsForTypingInput" 2014-05-22 03:14:01 +00:00
Jean Chalard
7aa895e2e3 Fix: too many calls to getSuggestedWordsForTypingInput
Bug: 15148015
Change-Id: Idcb729734bd62b537fb81acf8bdb5cae4470404c
2014-05-22 12:08:12 +09:00
Jean Chalard
ea09e6bddb Merge "Add the rawChecksum column to the database." 2014-05-22 02:41:00 +00:00
Jean Chalard
dfc38358fc Don't upcase suggestions when resuming on an uppercase word
Bug: 13917781
Change-Id: I7458d120898a7c8c0bc2db2f6db3578fd1dd1681
2014-05-22 11:37:08 +09:00
Jean Chalard
267e528253 Arrange to send the rawChecksum to LatinIME.
Bug: 13125743
Change-Id: I5d111336e6a0f5ab4e93ff333654a7a1f8f46480
2014-05-22 11:01:04 +09:00
Jean Chalard
e077c01461 Add the rawChecksum column to the database.
Bug: 13125743
Change-Id: I082aa9df1dd4a10cdb3f97ee0692f2d72f6c8e7e
2014-05-22 11:00:46 +09:00
Keisuke Kuroyanagi
17f326b745 Add beginning of sentence information in PrevWordsInfo.
Bug: 14119293
Bug: 14425059
Change-Id: I65320920e840082b0b697bb621676716d0933e0c
2014-05-21 15:40:08 +09:00
Keisuke Kuroyanagi
17ae0eb7e7 Use enabled subtypes for Keyboard in DistracterFilter.
Bug: 13142176
Bug: 15094186
Change-Id: I142eeaa11f838080a4fc5a342155e5d470eab3d4
2014-05-21 14:08:39 +09:00
Tadashi G. Takaoka
73788ea154 Merge "Refactor MoreKeysKeyboardView to use Key class" 2014-05-21 03:06:43 +00:00
Tadashi G. Takaoka
5fc1510bc1 Refactor MoreKeysKeyboardView to use Key class
This can make MoreSuggestionsView to use extended Key class to hold
a index of a suggested word.

Change-Id: I54d03d2447b04e3caf3e19e7cadcd391cbf58dd5
2014-05-21 11:19:01 +09:00
Keisuke Kuroyanagi
e507d92aa3 Use PrevWordsInfo for get/add/remove n-gram(bigram) entry.
Bug: 14119293
Bug: 14425059
Bug: 15102610
Change-Id: Ib482390f8d15b37d44a1a54e8c243a9eaec3f815
2014-05-21 11:15:38 +09:00
Ken Wakasa
06dd0ef877 Merge "Revert "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry."" 2014-05-20 14:01:34 +00:00
Ken Wakasa
4e21d3711f Revert "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry."
This reverts commit ff50b39176.

Bug: 14119293
Bug: 14425059
Bug: 15102610

Change-Id: If278b4ab236e38d20d8cdc0761b0438911bd4ff9
2014-05-20 14:01:06 +00:00
Tadashi G. Takaoka
305778b53a Support accessibility TalkBack in emoji palette
Bug: 11452158
Change-Id: I699e4e9f4baec4bb0fb9cd7875f675044f20465f
2014-05-20 17:35:39 +09:00
Tadashi G. Takaoka
f22285006a Move generic hover event handling to KeyboardAccessibilityDelegate
This is a follow up of I0d73b4cf60.

Change-Id: Iecfe124321682c8fc307ccf4c79e836390403d95
2014-05-20 17:25:19 +09:00
Tadashi G. Takaoka
4d146d5e3e Separate MainKeyboardView specific accessibility code
Change-Id: I0d73b4cf60145b6e34bd89f72eb49de3c686f5e3
2014-05-20 15:34:25 +09:00
Tadashi G. Takaoka
524392adfa Merge "Refactor accessibility classes to be more generic" 2014-05-20 06:19:30 +00:00
Tadashi G. Takaoka
7b90d2c432 Refactor accessibility classes to be more generic
Change-Id: Ifad1905f304bccdc39f0d5fbcab8a6353e0b4f76
2014-05-20 15:07:45 +09:00
Keisuke Kuroyanagi
1afaf6770b Merge "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry." 2014-05-20 05:36:10 +00:00
Keisuke Kuroyanagi
ff50b39176 Use PrevWordsInfo for get/add/remove n-gram(bigram) entry.
Bug: 14119293
Bug: 14425059

Change-Id: I12e9ba977c153b514c6591ab52940712fd0874e3
2014-05-20 13:37:04 +09:00
Tadashi G. Takaoka
9fb2797714 Fix number password field handling
Bug: 15088419
Change-Id: Ie88375c8c8203c318d9b410692c527443cb0a2d5
2014-05-20 10:26:26 +09:00
Tadashi G. Takaoka
437be2d5c4 Refactor Emoji tab indicators to refer keyboard theme
Bug: 14419121
Change-Id: I7086923fff153039c2d011bbccbfd04eb687a76a
2014-05-20 01:16:25 +09:00
Tadashi G. Takaoka
27ca9f1bf1 Remove Emoji label tab
Change-Id: Ia2f3482363b462c16a51f2baac59d6bcae96ffab
2014-05-19 23:11:39 +09:00
Tadashi G. Takaoka
3bfacd445e Merge "Remove Emoji delete key UX hack" 2014-05-19 05:33:28 +00:00
Tadashi G. Takaoka
6ea0dab845 Remove Emoji delete key UX hack
The Emoji delete key UX hack that changes key background color based
on the key state isn't keyboard theme compliant.

Change-Id: I0fa43a91cdd6da944d6d4d1a5a09b771f852a081
2014-05-19 14:07:35 +09:00
Keisuke Kuroyanagi
b52055bfd1 Merge "Use PrevWordsInfo instead of String in Java side." 2014-05-19 05:00:21 +00:00
Keisuke Kuroyanagi
83c40a2301 Use PrevWordsInfo instead of String in Java side.
Bug: 14119293
Bug: 14425059

Change-Id: I3d5da84881a49a04550180dd9aac2c37da2ed762
2014-05-19 13:55:40 +09:00
Tadashi G. Takaoka
10bd458efc Rename Emoji related resource names more consistent
Change-Id: I318a98feeaf7b8bc4d2ed6d54475a144e2dca0a1
2014-05-19 13:54:00 +09:00
Tadashi G. Takaoka
04e2a494e2 Rename LXX theme to LXX_Dark
Bug: 14419121
Change-Id: I3d73c51d339eafec26871a659575d8b7b8cc441c
2014-05-19 10:27:36 +09:00
Keisuke Kuroyanagi
23246ed18d Use dedicated DictionaryFacilitator for DistracterFilter
Bug: 15002249
Change-Id: Ic77eaa7d627d406daad7dcd15cb4884d9f647312
2014-05-17 01:18:08 +09:00
Keisuke Kuroyanagi
96013c9605 Merge "Revert "Use dedicated DictionaryFacilitator for DistracterFilter"" 2014-05-16 11:17:45 +00:00
Keisuke Kuroyanagi
f9377c8920 Revert "Use dedicated DictionaryFacilitator for DistracterFilter"
This reverts commit 7122fe76e3.

Change-Id: I341089864a2b58de6e0f35844a12fb632bd1eabb
2014-05-16 11:16:54 +00:00
Keisuke Kuroyanagi
0dac17f5fb Merge "Use dedicated DictionaryFacilitator for DistracterFilter" 2014-05-16 10:49:02 +00:00
Tadashi G. Takaoka
060e63835a Merge "Fix keyboard theme selection logic" 2014-05-16 09:59:22 +00:00
Tadashi G. Takaoka
3b12718537 Fix keyboard theme selection logic
Bug: 15002666
Change-Id: I5cc52db71ee609edffdb2613e93245e92ac6fc6a
2014-05-16 18:45:09 +09:00
Keisuke Kuroyanagi
7122fe76e3 Use dedicated DictionaryFacilitator for DistracterFilter
Bug: 15002249
Change-Id: I2ebf1941fb0453ea4b97c0e539f8b36e5e0262c1
2014-05-16 18:39:31 +09:00
Keisuke Kuroyanagi
d1f9ce00db Merge "Make session id mandatory for getSuggestions." 2014-05-16 09:33:28 +00:00
Keisuke Kuroyanagi
09c72207c6 Make session id mandatory for getSuggestions.
Bug: 15008504
Change-Id: Ic4a17a4b7242118ae74fd89c695da2bb52204fb2
2014-05-16 17:57:03 +09:00