nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
14175 commits 1 branch 0 tags 363 MiB
Commit graph

3321 commits

Author SHA1 Message Date
Tadashi G. Takaoka
6f7905ae75 Introduce MoreSuggestionsListener class 
Bug: 8694255
Change-Id: I9420a7cb1983c6211f58d13b3b11db4347c3f99b
 2013-05-01 18:03:37 +09:00
Tadashi G. Takaoka
47a66b12ec Override View.drawableStateChanged to detect state_pressed 
Unlike on JB, View.setPressed(boolean) is never called when the view
is pressed on ICS. To detect a pressed state of the view, we need to
override View.drawableStateChanged() and check the drawable state
contains state_pressed.

Bug: 8159728
Change-Id: I481051364d6f3d1370742723c3ce19d898ea5463
 2013-05-01 14:02:18 +09:00
Tadashi G. Takaoka
7b2114a428 Display still image when device can't play welcome video 
Note that the still image in this change is a placeholder and must be
replaced by final asset.

Bug: 8159728
Change-Id: I4f5a28e0af711edacbc87c2ee64508f34f67f0da
 2013-05-01 12:24:36 +09:00
Jean Chalard
019c38060d am ace3f3c5: am 25c90e6d: Merge "Don\'t do recorrection when suggestions are off." into jb-mr2-dev 
* commit 'ace3f3c5d56f5b4a58e8dc400fec1bb8c7b17a63':
  Don't do recorrection when suggestions are off.
 2013-04-30 19:22:13 -07:00
Jean Chalard
aa3a96f3a1 Don't do recorrection when suggestions are off. 
Bug: 8767981
Change-Id: If5c775e488b91ae03ecce2673c99918ac8134928
 2013-05-01 10:17:28 +09:00
Ken Wakasa
a0b62ece83 Merge "Cleanup an unused return value" 2013-04-30 11:16:28 +00:00
Tadashi G. Takaoka
ad46c9e0e0 Catch error while playing welcome video 
Bug: 8159728
Change-Id: Ic8eea7993f12395d6eca6db8d5529803251a9fee
 2013-04-30 18:18:32 +09:00
Ken Wakasa
0d6c87d113 Cleanup an unused return value 
Change-Id: I974964aa3cc24b5480e57bd38c197fe7a49acaa4
 2013-04-30 16:53:18 +09:00
Satoshi Kataoka
5aa14c2636 Fix the title of the fragment of the personal dictionary 
This change is corresponding to I9b8bab21b144385bc2386e7fcb

Bug: 8600958
Change-Id: I0a0cf37d0a11c14a51dc63b2e4371facb34514d0
 2013-04-30 15:01:51 +09:00
Jeff Sharkey
c5ebc792d6 Avoid leaking AssetFileDescriptor. 
Change-Id: Iac388c8aefc684980cb4c7131fb47319f6073eb3
 2013-04-29 12:26:44 -07:00
Tadashi G. Takaoka
be06bce18b Merge "Get rid of janky black box before the movie starts" 2013-04-26 09:38:54 +00:00
Tadashi G. Takaoka
732c93815a Get rid of janky black box before the movie starts 
Bug: 8159728
Change-Id: I1d0a01a05b3b694d21fdfdc246d1329ab829908d
 2013-04-26 18:26:12 +09:00
Jean Chalard
c03aaa1bde Merge "[ZF2] Read settings for profanity filtering." 2013-04-26 08:23:56 +00:00
Satoshi Kataoka
adbafa1a9b Merge "Support ICS on the user dictionary settings" 2013-04-26 06:50:42 +00:00
Satoshi Kataoka
dcef94165b Support ICS on the user dictionary settings 
Bug: 8600958
Change-Id: I50e9228afc7b04147eb7c4734d3145abe8859a30
 2013-04-26 15:48:08 +09:00
Tadashi G. Takaoka
82e476b188 Keep task stack when invoking settings from setup wizard 
Bug: 8336068
Change-Id: If1df32595f72285b2dad16e28b4429b7b6059839
 2013-04-26 13:03:37 +09:00
Jean Chalard
bb61293675 [ZF2] Read settings for profanity filtering. 
Bug: 7226877
Change-Id: Ie0c713e1eba1529c0b288a1e5011023a79bedd6b
 2013-04-25 20:29:14 +09:00
Jean Chalard
99e998286d [ZF1] Check profanity in Java rather than in native 
Bug: 7226877
Change-Id: Ib6c32bfee9977c27dbf7e1e590b2b00d9ceb7301
 2013-04-25 20:29:11 +09:00
Jean Chalard
43590149a5 Work around a bug in older DownloadManager versions. 
This adds a number to the extension.

Note that for DownloadManager to keep this, the server
needs to send it a mime type it does not recognize. Right
now, it does not recognize application/json so it's okay,
but we'd do well to remove the content/type header from
the server to prevent problems.

Bug: 8467516
Change-Id: Ic484f66ac3f67c36f59f2c0bcb8c7fdeb6e8590d
 2013-04-25 18:52:39 +09:00
Jean Chalard
a995bf4031 Put temp files within app files 
Bug: 8715614
Change-Id: I307d83923070994525cf0d27aad403e881a89314
 2013-04-25 18:14:40 +09:00
Satoshi Kataoka
30f0f3a92a Merge "Implement a functionality to add an entry to the user dictionary" 2013-04-25 06:04:08 +00:00
Satoshi Kataoka
a79ba8a3d6 Implement a functionality to add an entry to the user dictionary 
Bug: 8600958

Change-Id: Ic472500406b9d54ec4052c490ee7cef62fc4e52a
 2013-04-25 14:55:07 +09:00
Tadashi G. Takaoka
46913aedb4 Merge "Add next axction to setup wizard" 2013-04-24 10:30:56 +00:00
Tadashi G. Takaoka
b5d33059e0 Add next axction to setup wizard 
Bug: 8159728
Change-Id: Ia37ab32b63e4eda29bf1411719d00846525c278f
 2013-04-24 19:22:41 +09:00
Satoshi Kataoka
b35aa487fd Merge "Make aggressive threshold really aggressive" 2013-04-24 09:14:30 +00:00
Satoshi Kataoka
70f2762e28 Make aggressive threshold really aggressive 
Bug: 8701480
Change-Id: If8242cfe61f3e56712fd6e25e36858cff7f0d177
 2013-04-24 17:49:56 +09:00
Tadashi G. Takaoka
e918bf07a0 Refactor SetupStepGroup 
Bug: 8159728
Change-Id: I1ab846d0910aacbd2f979289d72bafea8a8e0378
 2013-04-24 14:15:59 +09:00
Tadashi G. Takaoka
480284e28a Merge "Add edit personal dictionary settings menu" 2013-04-23 06:01:45 +00:00
Jean Chalard
c3f4783649 Add an additional ID to the client info. 
Bug: 8651863
Change-Id: I748f35726d72ede926d5b06ed87ff029317f1ac3
 2013-04-23 14:37:15 +09:00
Satoshi Kataoka
9b4e3db1af Legal notice 
Bug: 8533258
Change-Id: I00e4916f86f29dd476c51a65e8fa5a6c136fd179
 2013-04-22 21:55:53 +09:00
Tadashi G. Takaoka
4f2535398a Add edit personal dictionary settings menu 
Bug: 8600958
Change-Id: I303adfbe25a56cc9b5ee9f3b5169a5bca0ad6c4a
 2013-04-22 19:59:12 +09:00
Tadashi G. Takaoka
508ab24875 Merge "Implement IMM.switchToNextInputMethod() for ICS" 2013-04-22 10:37:11 +00:00
Tadashi G. Takaoka
85629debaa Implement IMM.switchToNextInputMethod() for ICS 
Bug: 8633367
Change-Id: Ifc0f97b1fdf5e5cc3601c24a503058c4822478dc
 2013-04-22 19:30:56 +09:00
Jean Chalard
f0e579a171 Don't kill suggestions with native score < 1 
Change-Id: I954856b7fec0b91e19a467f2a87978d49caa639d
 2013-04-22 14:21:43 +09:00
Tadashi G. Takaoka
68e4de1e78 Add welcome screen to setup wizard 
This is a preliminary implementation because the welcome screen video
is just a placeholder.

Bug: 8159728
Change-Id: I6a2459a266babec2f078fc393b18c77b0b7992a8
 2013-04-19 20:49:49 +09:00
Tadashi G. Takaoka
fcefabf9ab Groundwork to implement landscape and welcome screen 
Bug: 8159728
Change-Id: I05ff6578980ec2e210ebb482ea51b1600e74a4f4
 2013-04-19 20:10:59 +09:00
Tadashi G. Takaoka
16ec2e1155 Merge "Add finish action to setup wizard" 2013-04-19 10:58:55 +00:00
Tadashi G. Takaoka
192743a6ae Add finish action to setup wizard 
Bug: 8159728
Change-Id: I1578fc31875a1edbfea213fb5e1a1b464d02e941
 2013-04-19 19:44:54 +09:00
Jean Chalard
ff078041e7 am f1dde6a1: am 758c74fe: Merge "Fix an NPE in recorrection" into jb-mr2-dev 
* commit 'f1dde6a1bf659d182db5a2645515cc1efe74459c':
  Fix an NPE in recorrection
 2013-04-19 00:10:22 -07:00
Jean Chalard
e5cbdfe1b8 am 3629605b: am 77226ed0: Merge "Fix an NPE in recapitalize" into jb-mr2-dev 
* commit '3629605b7c14b5eea498ef9588f4fef788ef454c':
  Fix an NPE in recapitalize
 2013-04-19 00:06:58 -07:00
Jean Chalard
758c74fe82 Merge "Fix an NPE in recorrection" into jb-mr2-dev 2013-04-19 07:03:19 +00:00
Jean Chalard
77226ed006 Merge "Fix an NPE in recapitalize" into jb-mr2-dev 2013-04-19 07:01:10 +00:00
Jean Chalard
ae7d1530b4 Fix an NPE in recorrection 
Also, theoretically, we don't want to retrieve older suggestions if
there are no results for a recorrection - that would look random.
This bug addresses this too.

Bug: 8657919
Change-Id: I44f36d34a708a968ab71fa0592da57f4c97d4b7f
 2013-04-19 15:53:33 +09:00
Jean Chalard
3bdf341ea0 Fix an NPE in recapitalize 
Bug: 8657736
Change-Id: I459d1c200826c1c394f8207475ecf60a4f356793
 2013-04-19 15:44:20 +09:00
Tadashi G. Takaoka
1f6e06cf92 Merge "Make setup wizard step number highlighted when activated" 2013-04-19 03:21:04 +00:00
Tadashi G. Takaoka
b84c0468e4 Make setup wizard step number highlighted when activated 
Bug: 8159728
Change-Id: I62ccbebaae0a0c4a93ad7c155fc3020a7f357f3c
 2013-04-19 11:14:21 +09:00
Jean Chalard
3a18ae70cc am a5d2da82: am d91268ad: Initialize dictionaries at onStartInputView 
* commit 'a5d2da82a6a4486a4ef74e51ddd1c875f4c2d935':
  Initialize dictionaries at onStartInputView
 2013-04-18 09:27:35 -07:00
Jean Chalard
d91268ad9f Initialize dictionaries at onStartInputView 
Bug: 8344402
Change-Id: I41b8440f0d72a66fde3f6feb0db8239c9bb10ea3
 2013-04-18 14:48:42 +09:00
Tadashi G. Takaoka
d794f5ae2a Update setup wizard icons 
Bug: 8159728
Change-Id: Ia5a14a35292b43dc1eaa2d4edd65134040355149
 2013-04-18 13:15:53 +09:00
Tadashi G. Takaoka
464202047d Add user feedback to setup action labels and icons 
Bug: 8159728
Change-Id: I46c77c31973ae492c2a12291f2e0b154f64d26c9
 2013-04-17 19:57:46 +09:00
Tadashi G. Takaoka
47a78aeb4d Merge "Finalize setup wizard strings and mark as translatable" 2013-04-17 10:55:41 +00:00
Tadashi G. Takaoka
8712ac7945 Finalize setup wizard strings and mark as translatable 
Bug: 8159728
Change-Id: I9f6f04b09b2cefdb7ece76a4f3c39ab56d0c8fab
 2013-04-17 19:52:50 +09:00
Tadashi G. Takaoka
bb5deb82b5 Fix singleton/utility classes initialization in SettingsFragment 
This is a follow up of Ide3cd3acba.

Bug: 8632344
Change-Id: Iafe51798a1a74eff5d8fcd6f0117d16b419d447d
 2013-04-17 16:16:10 +09:00
Tadashi G. Takaoka
888a194cf1 Fix missing AudioAndHapticFeedbackManager initialization 
Bug: 8632344
Change-Id: Ide3cd3acba3987317cff709fa591eadaa71834e8
 2013-04-17 15:32:01 +09:00
Jean Chalard
73ec85b8ad Don't insert automatic spaces when text looks like a URL 
This is about as ad-hoc as it gets, but then again, what we want
is probably as ad-hoc as it gets.
All URL boxes I know of double as search bars, and not adding
automatic spaces there sucks (e.g. in Chrome URL bar).
And in other boxes actually you don't want to add a space if
it looks like a URL. QSB isn't even a search box, and it behaves
like this.

So I think this is actually the right answer to the problem.

Bug: 7062925
Change-Id: Ib09472b34644fd5bf2dc84bb97cedeeba28bcd02
 2013-04-16 18:03:49 +09:00
Jean Chalard
78d658734d Merge "Don't recapitalize on shift while on symbol layout" 2013-04-16 05:31:43 +00:00
Jean Chalard
1f52364630 Don't recapitalize on shift while on symbol layout 
Change-Id: Ibf2cdedf510c296561bb5eeb6ff18c3414d6d6f4
 2013-04-16 14:29:02 +09:00
Jean Chalard
8094bf45d7 Match the keyboard state to the recapitalize state. 
Bug: 7657025
Change-Id: I2f8fe7fc4596a498322ba5ccabbd0c18a2bc36cf
 2013-04-16 14:25:03 +09:00
Jean Chalard
e259b9f57d Merge "Clean up RecapitalizeStatus" 2013-04-16 04:57:35 +00:00
Jean Chalard
fd15686ae9 Merge "Fix an NPE" 2013-04-16 04:12:18 +00:00
Jean Chalard
b794e904a3 Clean up RecapitalizeStatus 
Change-Id: Ib4d002f90cd3a0e9ad4c04b883b0c1f05ada3ccf
 2013-04-16 13:11:18 +09:00
Jean Chalard
a024ac6b20 Merge "Fix an NPE" 2013-04-16 03:43:06 +00:00
Jean Chalard
2b42ad0eaa Fix an NPE 
Bug: 8620678
Change-Id: Ia91761f33518a010b2844d34523cadece261c67e
 2013-04-16 12:20:10 +09:00
Jean Chalard
7be3ca2ccf Fix an NPE 
Bug: 8620758
Change-Id: I39f07939ebb6148a48aae5b915ee807002a5b02d
 2013-04-16 12:17:22 +09:00
Jean Chalard
5fca38c538 Merge "Small performance improvement / minor bugfix" 2013-04-15 14:28:16 +00:00
Jean Chalard
b76ce1251e Merge "Remove a useless function" 2013-04-15 13:06:33 +00:00
Jean Chalard
bc501647fd Remove a useless function 
Bug: 8583091
Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
 2013-04-15 22:01:37 +09:00
Jean Chalard
1e5bbe4ce8 Small performance improvement / minor bugfix 
The only place where it's used is checked for nullity.
Also, it's possible, also difficult, to match a different
recapitalize with the old code, triggering a bug that
this fixes.

Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
 2013-04-15 21:18:50 +09:00
Jean Chalard
a5a2f3e3c7 Remove gesture suggestions with an INT_MIN score 
Bug: 7980115
Change-Id: I8de31068992aec712eaad132857d9dc61f28e30a
 2013-04-15 20:55:49 +09:00
Jean Chalard
033958330d Merge "Have Latin IME re-capitalize a selected string" 2013-04-15 11:29:28 +00:00
Jean Chalard
2995abe7aa Have Latin IME re-capitalize a selected string 
Upon pressing Shift, if there is currently a selected string, have
Latin IME change its capitalization.
This does not yet have the keyboard mode follow the mode - the change
is complicated enough as is.

Bug: 7657025
Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
 2013-04-15 20:23:01 +09:00
Jean Chalard
0e9ee4d3bf If there are no suggestion span, recompute suggestions. 
Bug: 8084810
Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
 2013-04-15 19:33:23 +09:00
Jean Chalard
059e084e98 Merge "Reject a previously user-refused suggestion." 2013-04-15 07:45:34 +00:00
Jean Chalard
d40f3f6bc1 Reject a previously user-refused suggestion. 
If the user gestures a word, then hits backspace in
disapproval, and gestures about the same thing again,
make sure that we don't suggest the same thing again.

Bug: 7549311
Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
 2013-04-15 16:36:44 +09:00
Tadashi G. Takaoka
216fb6a042 Remove unnecessary harmful finish() from SettingsActivity 
Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3
 2013-04-15 16:26:40 +09:00
Tadashi G. Takaoka
29105a725d Add preference dependency to gesture input related options 
Bug: 8613600
Change-Id: I279d3264080aede59203205c45763c7f8ff08ae6
 2013-04-15 15:07:49 +09:00
Tadashi G. Takaoka
e2af9b7eb5 Merge "Reset vertical correction when more suggestions are in modal mode" 2013-04-15 04:57:33 +00:00
Tadashi G. Takaoka
51c38a441a Reset vertical correction when more suggestions are in modal mode 
Bug: 8605150
Change-Id: Iadbebfb80e765c97e58e8524eb87419f2a9e41d4
 2013-04-15 13:56:03 +09:00
Jean Chalard
c2e9c511cb Fix Binary dict tests 
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.

The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.

All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.

Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
 2013-04-15 12:48:16 +09:00
Jean Chalard
2cd1136b8e Merge "Remove the dialog to insert words to the dictionary." 2013-04-12 12:33:24 +00:00
Jean Chalard
91bcf5eb5d Merge "Restart suggestions when the cursor moves." 2013-04-12 12:27:50 +00:00
Jean Chalard
02ce3dc2d1 Fix a bug with bad application completions 
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
 2013-04-12 20:53:06 +09:00
Jean Chalard
6a114fa700 Restart suggestions when the cursor moves. 
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.

Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
 2013-04-12 20:49:03 +09:00
Jean Chalard
d24f939712 Merge "Make shortcut-only user dict entry non-words." 2013-04-12 11:02:00 +00:00
Jean Chalard
fb5869e9ff Merge "Add a class to encapsulate getting the metadata URI" 2013-04-12 11:01:36 +00:00
Jean Chalard
6a2a4b8e4d Make shortcut-only user dict entry non-words. 
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
 2013-04-12 16:17:09 +09:00
Jean Chalard
1a51833828 Remove the dialog to insert words to the dictionary. 
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
 2013-04-12 15:58:50 +09:00
Jean Chalard
8987cccf89 Add a class to encapsulate getting the metadata URI 
Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
 2013-04-11 17:52:16 +09:00
Jean Chalard
b5d5190deb Merge "Add some utility functions." 2013-04-11 07:35:22 +00:00
Jean Chalard
1cbb0b8f2a Add some utility functions. 
Bug: 7657025
Change-Id: I4889721b5348c77ed56c5157557e9988dea48a02
 2013-04-11 16:16:19 +09:00
Tadashi G. Takaoka
f67a388197 Merge "Add TypefaceUtils" 2013-04-11 05:32:58 +00:00
Tadashi G. Takaoka
08ae0d5ca0 Add TypefaceUtils 
Change-Id: I2d939bc1e3279253902b28ff12bbf7861716b64d
 2013-04-11 14:27:42 +09:00
Tadashi G. Takaoka
6d0027a46a Merge "Use SparseIntArray instead of TreeMap<Integer, Integer>" 2013-04-11 05:06:35 +00:00
Jean Chalard
3722f0877e Merge "Fix two bugs in dicttool" 2013-04-11 03:07:30 +00:00
Jean Chalard
ca0fdbbe2e Fix two bugs in dicttool 
Both bugs only affect debug mode. One has the wrong object tested
with equals, the other has the iteration failing in some cases.

Change-Id: Ie9100d257a3f9e3be340cf3e38116f63417bdc1a
 2013-04-10 22:10:31 +09:00
Jean Chalard
fb3e805722 Merge "Fix a bug where a space would not be inserted before a gesture" 2013-04-10 11:19:31 +00:00
Jean Chalard
30b8004b56 Fix a bug where a space would not be inserted before a gesture 
Bug: 8583675
Change-Id: I14924fef5663f48481994c02c56be45f9f85be65
 2013-04-10 20:10:28 +09:00
Tadashi G. Takaoka
ce811f50d2 Use private lock object instead of synchronized method 
Change-Id: Ifc62bacbd0583a7d102009681a94bdd9ccff7d47
 2013-04-10 18:27:11 +09:00
Jean Chalard
99b93d17d5 Fix a bug where autocorrection status would be wrong. 
Change-Id: Ic220129dc59f585164dbf63591cd1c96de17fe6f
 2013-04-10 17:49:19 +09:00
Tadashi G. Takaoka
262d5bd9f9 Don't override EXTRA_SHOW_FRAGMENT if exists 
Bug: 8541190
Change-Id: I37d3de12558efd55f157389d2e0b51fc83dc5da1
 2013-04-10 16:24:17 +09:00
Tadashi G. Takaoka
10af4b6e45 Merge "Separate StringUtils.capitalizeFirstCharacter" 2013-04-10 06:30:33 +00:00
Tadashi G. Takaoka
d20c5a78e2 Separate StringUtils.capitalizeFirstCharacter 
Bug: 8582061
Change-Id: Iac8f65defdd92d7df533bdf0e2937ad897d96363
 2013-04-10 14:55:23 +09:00
Tadashi G. Takaoka
f606fd8554 Hide Setup Wizard icon for stock keyboard 
Bug: 8581647
Change-Id: Id530f1a33a5c919f4a732ec0d545dfbe76e56316
 2013-04-10 12:24:40 +09:00
Tadashi G. Takaoka
869ea1e555 Use SparseIntArray instead of TreeMap<Integer, Integer> 
Change-Id: I56a64228a5fd85d440d0d08ac67cba8bf2e5690d
 2013-04-10 10:15:26 +09:00
Tadashi G. Takaoka
4fdfce6dcc Merge "Refactor SpellCheckerProximityInfo as extending ProximityInfo" 2013-04-10 01:06:36 +00:00
Jean Chalard
19dcd15493 Merge "Offer to add any OOV typed word to the dictionary." 2013-04-09 10:28:47 +00:00
Jean Chalard
ddafcf82dc Merge "Fix bugs and add tests" 2013-04-09 08:35:28 +00:00
Jean Chalard
9310f42a36 Offer to add any OOV typed word to the dictionary. 
That includes gestures, which used not to work.

Bug: 8532637
Change-Id: I04606565d7000faadf954c4a806c39d4d162a2c1
 2013-04-09 12:05:54 +09:00
Kurt Partridge
d117c1a116 Merge "Do not record log split time when handling separator" 2013-04-09 02:31:48 +00:00
Ken Wakasa
d17c8bd929 Update comments 
Change-Id: I6aef328ec9041666cc168c8323bed04d39591b71
 2013-04-08 23:05:45 +09:00
Jean Chalard
c87449497c Fix bugs and add tests 
Change-Id: I6b56b91ace57f4a49584b5dceb71b145859f839e
 2013-04-05 12:11:19 +09:00
Jean Chalard
7d3836d63a Move a generic string utility to StringUtils 
Change-Id: I9cc2e9a7ac0b3346af40bcb083f939333336cf09
 2013-04-05 12:09:14 +09:00
Tadashi G. Takaoka
6e3f307266 Refactor SpellCheckerProximityInfo as extending ProximityInfo 
Change-Id: I544eec9d661796d57749dbaa2163bc1e2a891353
 2013-04-02 19:06:32 +09:00
Jean Chalard
ecb59eff90 Revert "[DO NOT MERGE] Activate hardware keyboard handling" 
This reverts commit c741f1f83b
DO NOT MERGE is ignored and this is merged anyway :(

Change-Id: Ie044cdfc6021933379ec97ad7346c5c8591f70bf
 2013-04-02 16:08:48 +09:00
Jean Chalard
c741f1f83b [DO NOT MERGE] Activate hardware keyboard handling 
Change-Id: Ifdec9338a454291621b2b87c899f5d4301480b27
 2013-04-02 15:38:13 +09:00
Kurt Partridge
636b8c4231 Do not record log split time when handling separator 
Previously handleSeparator() caused the ResearchLogger to mark the time at which a LogUnit should be
broken.  However, this causes the motion data associated with a separator to be associated with the
LogUnit of the previous word.  This change corrects this bug.

Change-Id: I8b4d4fa6de2a013de9e2a28bb668c446a07f1957
 2013-04-01 16:48:15 -07:00
Kurt Partridge
0c0ab2b4d9 Merge "Reorder ResearchLogger call" 2013-04-01 15:19:45 +00:00
Jean Chalard
0745fe83d4 am b8869ec1: am 0fcc4960: Deactivate hardware keyboard handling. 
* commit 'b8869ec1e39c1751825841e790d21fc854dca9ce':
  Deactivate hardware keyboard handling.
 2013-04-01 05:42:42 -07:00
Jean Chalard
0fcc4960bc Deactivate hardware keyboard handling. 
Bug: 8000119

Change-Id: I021481343d6d87efd8ff6110e9aa0906a1a3d11d
 2013-04-01 21:35:45 +09:00
Jean Chalard
43341ba042 Merge "Ask the client to make itself known when it's not" 2013-04-01 09:00:25 +00:00
Jean Chalard
76d5f512f9 Ask the client to make itself known when it's not 
Upon invoking the settings of the dictionary pack with an unknown
client, we now launch an intent to ask the client to make itself known.
This change also includes the code that receives this intent and
acts upon it.

Bug: 8492879
Change-Id: I2c6496dea845646961ecafcf64e282cb93ee91dc
 2013-04-01 17:37:22 +09:00
Jean Chalard
065f126f1d Merge "Fix two nasty bugs with surrogate pairs." 2013-04-01 08:28:08 +00:00
Jean Chalard
a411595b16 Fix two nasty bugs with surrogate pairs. 
The important bug is in findWordInTree. The problem, which is
not obvious, is that we were calling codePointAt() with the
code point index in the string, instead of the char index.
The other bug this change fixes was harmless in the practice,
because it's in the iteration which is only used for debug and
pretty printing purposes. It's very similar in that it would
substract a length in code point to a length in chars and
truncate a StringBuilder at that length, so it would fail in a
quite similar manner. This changes the meaning of the "length"
attribute in Position, but it's clearer this way anyway.

Bug: 8450145
Change-Id: If396f883a9e6449de39351553ba83f5be5bd30f0
 2013-04-01 17:06:19 +09:00
Jean Chalard
740da0d8d0 Fix an NPE 
Also remove an unused method and make 2 private variables
final.

Bug: 8461093
Change-Id: I676d93fda28e82eb5a6978f2e7ad5a0add2cbecf
 2013-03-29 18:41:29 +09:00
Satoshi Kataoka
f463b45d8e Merge "Fix Possible NPE" 2013-03-27 04:51:48 +00:00
Satoshi Kataoka
2cdf5351aa Merge "Fix possible SIOOBE" 2013-03-27 03:28:49 +00:00
Satoshi Kataoka
33306acfa4 Fix possible SIOOBE 
Bug: 8461021

Change-Id: I8b0385610b80b5a672ec380935c485a0e01ae984
 2013-03-27 12:25:02 +09:00
Kurt Partridge
cb25e1fe37 Reorder ResearchLogger call 
Previously, ResearchLogger#onWordFinished() was called with an outdated parameter value for
isBatchMode, causing it to report false even for gestures.  This changes fixes this problem.

Change-Id: Ifcabee236ba5fe20376ad882155d3f3142cd7613
 2013-03-26 14:37:57 -07:00
Kurt Partridge
ef103e1f2e Merge "Close ResearchLogger upon onFinishInputView" 2013-03-26 19:23:00 +00:00
Satoshi Kataoka
435cccb2c5 Fix Possible NPE 
Bug: 8448448
Change-Id: Ibe89c9abd24c4debb33a69c372eadf2afb09ea1c
 2013-03-26 13:02:23 +09:00
Satoshi Kataoka
0b3271010f Merge "Fix possible NPE" 2013-03-26 03:49:06 +00:00
Tadashi G. Takaoka
d17b69ec00 Clean up XmlParserUtils 
Change-Id: I636e8f359d47f39e61a7f77e3e686f2721779b6f
 2013-03-26 12:03:07 +09:00
Kurt Partridge
87bc3a4a62 Close ResearchLogger upon onFinishInputView 
Previously, ResearchLogger#stop() was called both in
LatinIME#onFinishInputView() and in LatinIME#onWindowHidden().  This
resulted in multiple logs being written.

Since onFinishInputView is the more reliable of the two (it is called
in InputMethodService#onDestroy; onWindowHidden is not), the code now
uses onFinishInputView as a stopping signal.

Change-Id: Iae4b8c3bdab226027624eeab19b3737367e4a108
 2013-03-25 17:31:25 -07:00
Satoshi Kataoka
a17dccbfc6 Fix possible NPE 
Bug: 8457109
Change-Id: I321fbef53e20a7c36ef4bd9f544b50abe6a52be9
 2013-03-25 19:00:38 +09:00
Tadashi G. Takaoka
fb658d6c53 Fix possible ArrayIndexOutOfBoundsException 
Bug: 8461864
Change-Id: Icd8f4f51ec064461c08d00c1c58bedf5fbae2553
 2013-03-25 12:37:04 +09:00
Satoshi Kataoka
3c8117c88f Fix appname 
Bug: 6789579
Change-Id: Ic4694e36e0846af95fa8dcdef919be251983b528
 2013-03-22 16:19:44 +09:00
Satoshi Kataoka
242c066dde Use correct appname resource 
Bug: 6789579
Change-Id: Id11435a28d6c5b6c72867814e23f5e62429080f8
 2013-03-22 14:08:38 +09:00
Satoshi Kataoka
a462cd80ae Support feedback 
Bug: 8143554
Change-Id: If0a6bafc94da040f97f27c6d046fb58bed9fd615
 2013-03-19 17:25:55 +09:00
Jean Chalard
8e005f2989 am 1061bfdb: Break dependencies to allow offdevice tests to build 
* commit '1061bfdb34bbcb63bf0046eec42313d264ac33fa':
  Break dependencies to allow offdevice tests to build
 2013-03-19 08:12:50 +00:00
Jean Chalard
6d90a10a34 am 0cc0544a: Merge the dictionary pack in Latin IME. 
* commit '0cc0544a2995c7eb54a830ae54db60af89d4073d':
  Merge the dictionary pack in Latin IME.
 2013-03-19 08:12:49 +00:00
Jean Chalard
1061bfdb34 Break dependencies to allow offdevice tests to build 
Change-Id: Ia9a2e8f0672b3f72943f26fb15de1d3c7c5ce7f1
 2013-03-19 16:45:25 +09:00
Jean Chalard
0cc0544a29 Merge the dictionary pack in Latin IME. 
Bug: 8161354
Change-Id: I17c23f56dd3bc2f27726556bf2c5a9d5520bd172
 2013-03-19 15:40:14 +09:00
Tadashi G. Takaoka
841c295f3c resolved conflicts for merge of 5b048292 to master 
Change-Id: I67ebab46954cd7b8e3e79e7fed523bafb15f8835
 2013-03-19 10:48:10 +09:00
Ken Wakasa
9c3860ce46 Rename ProductionFlag.IS_EXPERIMENTAL to USES_DEVELOPMENT_ONLY_DIAGNOSTICS 
bug: 8393568
Change-Id: Ie5edf44a3627aca9416145aff56bf05bbf2a05f3
 2013-03-18 23:15:47 +09:00
Jean Chalard
f8325ec4bb am 5cb0560b: Merge "Access the dictionary pack only if have INTERNET permission" into jb-mr2-dev 
* commit '5cb0560b000f37b3fb3937f01b6d3e928afef57a':
  Access the dictionary pack only if have INTERNET permission
 2013-03-18 11:08:52 +00:00
Jean Chalard
5cb0560b00 Merge "Access the dictionary pack only if have INTERNET permission" into jb-mr2-dev 2013-03-18 11:04:53 +00:00
Jean Chalard
ce487bcf33 Access the dictionary pack only if have INTERNET permission 
Bug: 8161354
Change-Id: I68ee3acb2955a017d25666cc2dad791798f9064a
 2013-03-18 18:40:33 +09:00
Satoshi Kataoka
62ed594c37 am e0e67373: Refactor parameters by naming convention 
* commit 'e0e67373735918c78eaeaf24f127e1d28816aa29':
  Refactor parameters by naming convention
 2013-03-18 06:47:10 +00:00
Satoshi Kataoka
e0e6737373 Refactor parameters by naming convention 
Change-Id: I8bda8075b33f656ecbec08320afcd864b620fe77
 2013-03-18 15:42:15 +09:00
Tadashi G. Takaoka
3268a44e1c am a5067333: Disable the header list of DebugSettingsActivity 
* commit 'a50673330e012f6cca02b83eca1c047b8da319e0':
  Disable the header list of DebugSettingsActivity
 2013-03-15 07:10:00 +00:00
Tadashi G. Takaoka
a50673330e Disable the header list of DebugSettingsActivity 
This change addresses the issue that the debug settings on 10-inch
tablet doesn't show up.

Change-Id: I60540cf21276869a3ca81b7b0154056ce7d93ff1
 2013-03-15 15:33:27 +09:00
Tadashi G. Takaoka
fb606c6277 am f0864b1d: Merge "Clean up StaticInnerHandlerWrapper a bit" into jb-mr2-dev 
* commit 'f0864b1d95411ce9886a5ade13f42cb17f578828':
  Clean up StaticInnerHandlerWrapper a bit
 2013-03-14 03:44:00 +00:00
Tadashi G. Takaoka
f0864b1d95 Merge "Clean up StaticInnerHandlerWrapper a bit" into jb-mr2-dev 2013-03-14 03:41:01 +00:00
Tadashi G. Takaoka
1ab33383f9 am 0d5f214a: Fix NPE found in monkey test 
* commit '0d5f214aa774ab0ab7c17521984caae11c9f4c2b':
  Fix NPE found in monkey test
 2013-03-14 03:39:38 +00:00
Tadashi G. Takaoka
41e60bf6dd Clean up StaticInnerHandlerWrapper a bit 
Change-Id: Ib07efe6da1eb2f0fd9ef68ca71502c98f7e19f4b
 2013-03-14 12:35:47 +09:00
Tadashi G. Takaoka
0d5f214aa7 Fix NPE found in monkey test 
Bug: 8383127
Change-Id: Ifd70acabe118b477f103937c7f1e99e38e210833
 2013-03-14 12:19:10 +09:00
Tadashi G. Takaoka
f5caf5be99 am 601a8582: Merge "Move checking non-persistent checkbox to onResume" into jb-mr2-dev 
* commit '601a8582d0f761a85b6eb16e7a6b78402f6f2599':
  Move checking non-persistent checkbox to onResume
 2013-03-14 02:33:28 +00:00
Satoshi Kataoka
0b2512017e am 0ab44b21: Merge "Make isInternal mutable" into jb-mr2-dev 
* commit '0ab44b21bd6ef5e9fde329b25dfd84f6ca5c0825':
  Make isInternal mutable
 2013-03-13 17:24:49 +00:00
Jean Chalard
8067b769f1 Merge "[DO NOT MERGE] Deactivate H/W keyboard handling" into jb-mr2-dev 2013-03-13 10:55:04 +00:00
Tadashi G. Takaoka
601a8582d0 Merge "Move checking non-persistent checkbox to onResume" into jb-mr2-dev 2013-03-13 07:52:35 +00:00
Satoshi Kataoka
0ab44b21bd Merge "Make isInternal mutable" into jb-mr2-dev 2013-03-13 07:41:11 +00:00
Satoshi Kataoka
756791e6bf Make isInternal mutable 
Change-Id: Ib81ceba801be0ac7ef65c4eadd1ec8599e80dacc
 2013-03-13 16:28:50 +09:00
Tadashi G. Takaoka
24cea7f1fb Move checking non-persistent checkbox to onResume 
Bug: 8336068
Change-Id: I07e67a6aee24a239a21e6fc69eb2ec741b9a5b2b
 2013-03-13 15:54:33 +09:00
Jean Chalard
92eaa6fc7c [DO NOT MERGE] Deactivate H/W keyboard handling 
For MR2, LatinIME should not be handling hardware keyboard
events. The feature is still work in progress.

Change-Id: I56ff18bff84ba6b5a6bc3f8829b42eaf33b72554
 2013-03-12 14:22:06 +09:00
Svetoslav Ganov
2d9b7f60dd am af37cbb4: Merge "Announce keyboard mode changes as a WINDOW_STATE_CHANGED event." into jb-mr2-dev 
* commit 'af37cbb44ef40fcd15fa02456c9abda8021847ce':
  Announce keyboard mode changes as a WINDOW_STATE_CHANGED event.
 2013-03-08 19:24:25 +00:00
Alan Viverette
c2ee72a214 Announce keyboard mode changes as a WINDOW_STATE_CHANGED event. 
Bug: 8165295
Change-Id: Ie416f6cdb68377f3e06f30e9b6363c38ba2a602d
 2013-03-07 10:39:55 -08:00
Kurt Partridge
dc89d76f6b Merge "Make some methods visible for testing" 2013-03-06 03:43:55 +00:00
Kurt Partridge
25343124dd Make some methods visible for testing 
bug: 8302967

multi-project commit with Icf915abb57ef00840ee93b67a25db42ba51f1c38

Change-Id: I105bda5bdff871508140fb99487dddbf17992790
 2013-03-05 19:28:31 -08:00
Tadashi G. Takaoka
249c887008 am 84fa8043: Merge "Add show setup wizard icon preference settings" into jb-mr2-dev 
* commit '84fa8043e6bef47378b3fc32c277e33034d5c174':
  Add show setup wizard icon preference settings
 2013-03-05 06:30:33 +00:00
Tadashi G. Takaoka
2e1b55f796 Add show setup wizard icon preference settings 
Bug: 8239067
Change-Id: If6106a3632d3abad3e22ce29f1351525a5152ec7
 2013-03-05 14:56:41 +09:00
Kurt Partridge
75e6fb68e9 Clean up PREF_USABILITY_STUDY_MODE 
- Refer to a common default value in DebugSettings
- Make PREF_USABILITY_STUDY_MODE independent of the ResearchLogger
- ResearchLogger uses its own preference through ResearchSettings

multi-project commit with Ie0df836c9d779eba484b522666ec357f4e234823

Change-Id: I88547a2f619db6e7364abbbec12f9f76855dd11a
 2013-03-04 12:05:03 -08:00
Kurt Partridge
b094372bd6 Remove MainLogBuffer#setSuggest() 
multi-project commit with Ia98b1406fc2ee11a96893c77ea58d800fece7624

Change-Id: I8bc3d07b83dbe7d8fc56a618de07dade7f510b13
 2013-03-01 13:32:11 -08:00
Tadashi G. Takaoka
578e71e28b am 99b0dc6f: Merge "Add setup wizard launcher icon" into jb-mr2-dev 
* commit '99b0dc6f0d18f5fdd8634e8fa533bf1b3f81a538':
  Add setup wizard launcher icon
 2013-03-01 16:13:45 +00:00
Tadashi G. Takaoka
99b0dc6f0d Merge "Add setup wizard launcher icon" into jb-mr2-dev 2013-03-01 16:08:09 +00:00
Tadashi G. Takaoka
1ffdaafd83 Add setup wizard launcher icon 
The setup wizard icon will be hidden if the Android Keyboard is in
system image.

Bug: 8239067
Change-Id: Ib0c0c9e3a0954512c3e03e42a661cdf86eff0dca
 2013-03-01 22:28:00 +09:00
Jean Chalard
31747ba787 am abaf5827: Separate suggestions from SuggestionView 
* commit 'abaf5827e7a7f5f6c5d8d98e03e6b9528b0c9351':
  Separate suggestions from SuggestionView
 2013-03-01 05:17:52 +00:00
Jean Chalard
abaf5827e7 Separate suggestions from SuggestionView 
This is a cleanup change, but it's also necessary for

Bug: 8152758
Change-Id: Id6ba06243f573fdb856f87d1df03277c9f2e5e71
 2013-02-28 21:03:18 -08:00
Kurt Partridge
424a976e58 Merge "Ensure Preference listener is unregistered" 2013-02-27 03:49:40 +00:00
Kurt Partridge
7e2c1e69bf Ensure Preference listener is unregistered 
Change-Id: I1a4d1e7bc45fc30cb1b63ea6020f0eee6e804333
 2013-02-26 18:40:34 -08:00
Tadashi G. Takaoka
183fe80031 Small cleanup of RunInLocale 
Change-Id: Ib588e67da2c88345fc4eb51587b07ebfa434e0bb
 2013-02-26 19:11:49 +09:00
Jean Chalard
0f3c05cd6b Merge "Send the dictionaries descriptions to the dict pack" 2013-02-23 10:18:03 +00:00
Jean Chalard
c6799ffeab Send the dictionaries descriptions to the dict pack 
Bug: 8255795
Change-Id: I12a5922f50c2d2e3aa639457abcc1483e6a48721
 2013-02-23 01:46:39 -08:00
Jean Chalard
76ead0ead0 Fix a possible crash 
If the dictionary ID, as indicated in the metadata, is
less than three chars long, it crashes LatinIME.
Of course we don't have such dictionary IDs in the current
metadata, but it's still better to be able to handle
the case gracefully ^^;

Change-Id: I60cdf6f8ecce9f4d44b42ddd5d157aebff9a4163
 2013-02-23 01:41:44 -08:00
Jean Chalard
aefaec3c5f Remove a cluttering log 
Bug: 8175067
Change-Id: I9a104a32ba2b3b52a5dfa250f8c642abd6169cc0
 2013-02-23 00:48:10 -08:00
Jean Chalard
8b4023c4d6 Merge "Tiny cleanup" 2013-02-23 08:07:27 +00:00
Jean Chalard
2521edec09 Fix a bug with the passed dictionary id 
We used to make the dictionary that we passed to the
dictionary pack as an initial value based on the locale.
This is wrong - it should be read from the dictionary.
This change fixes that.

Bug: 7005813
Change-Id: Ib08ed31dd9c216f6f7b9c6c3174ca514bf96e06f
 2013-02-22 20:49:48 -08:00
Jean Chalard
da0d771fe9 Tiny cleanup 
Change-Id: I5d7150a4abb3a498e790f41af569093217cb8b43
 2013-02-22 19:42:45 -08:00
Jean Chalard
4e4f88127b Fix how the Enter action is decided 
This unifies the software and hardware keyboard code
under a single decision process that works.

Bug: 8129303
Bug: 8152758
Change-Id: I7574c563d5f957d57bfe62fe5e3eec59a519d335
 2013-02-22 16:01:37 -08:00
Tadashi G. Takaoka
07296cf7ff Merge "Use WordComposer.addKeyInfo for testing" 2013-02-21 06:20:01 +00:00
Tadashi G. Takaoka
46878544ec Add preliminary setup wizard 
Bug: 8159728
Change-Id: I30d9cd637fb1d2e64588550e0aa4387bc1f7e6e5
 2013-02-21 09:54:02 +09:00
Tadashi G. Takaoka
5701a6647f Use WordComposer.addKeyInfo for testing 
Change-Id: I500654e7a26717aa5547942357e56060afb72969
 2013-02-20 17:09:25 +09:00
Jean Chalard
d4cbc4fd07 Implement getting data files with protocol v2 
This also does it for deleting them
Bug: 8167342
Bug: 6789534
Change-Id: I1823f98508881f109a667146d3608003f87aa4cb
 2013-02-15 11:09:16 -08:00
Jean Chalard
4beaab2a88 Merge "Determine the protocol version of the dictionary pack" 2013-02-14 20:22:09 +00:00
Tadashi G. Takaoka
cb0beaf3f1 Add placeholder of keyboard setup wizard 
Bug: 8159728
Change-Id: I5552e9d0ffa8f94d183e76378d55bba6f718adfe
 2013-02-14 18:00:11 +09:00
Jean Chalard
b1f27a2e26 Determine the protocol version of the dictionary pack 
...for query.

Bug: 8167342
Change-Id: Ieb8e5b31c4b62bf507593c4631e31799aad5f267
 2013-02-13 20:45:36 -08:00
Jean Chalard
a9df972780 Clean up dictionary pack presence test. 
This method is much cleaner and much more readable.

Change-Id: I8055c169ef7c4453ab45c463704bd56a6080da4f
 2013-02-12 17:59:36 -08:00
Tadashi G. Takaoka
fdb1ca560e Merge "Separate caps mode related utils to CapsModeUtils" 2013-02-12 09:26:16 +00:00
Tadashi G. Takaoka
ce6bcdd1a5 Separate caps mode related utils to CapsModeUtils 
Change-Id: I32700c434b296bb3fd39e040c2dda1fe90667daf
 2013-02-12 18:15:42 +09:00
Tadashi G. Takaoka
2c2942dd4b Merge "Move parseCsvString to StringUtils" 2013-02-12 07:57:24 +00:00
Tadashi G. Takaoka
b3fd701181 Move parseCsvString to StringUtils 
Change-Id: I602f33991ca57b6057ec2defe01573552b322857
 2013-02-12 16:18:19 +09:00