Commit Graph

6945 Commits (a68cace7d150660f98991e2e4340be4eacc22a3c)

Author SHA1 Message Date
Kurt Partridge a68cace7d1 Avoid NPE by fixing ResearchLogger initialization
Previously, mMainResearchLog and mMainLogBuffer were set up
when the user moved to a new TextView, and set to null when
the user left the TextView.  This change causes
mMainResearchLog, mMainLogBuffer, mFeedbackLog, and
mFeedbackLogBuffer to be non-null forever after init() is
called.  start() no longer sets up these fields; instead
they are cleared and reset every time stop() is called.
Checks for null values are now removed.

The earlier code just didn't initialize these variables if
the user disabled logging, but since the new version
invariantly keeps these variables valid, we add a check for
whether the user has enabled logging in publishLogUnits().

Change-Id: Ifde3517f1cf924cfa33cda95fec24529b52b3c08
2013-05-09 18:38:32 -07:00
Tadashi G. Takaoka 104bb70c65 Merge "Avoid drawing too long gesture preview trails" 2013-05-07 11:58:09 +00:00
Jean Chalard 2afe88b8d7 Merge "Unify space-adding on gestures." 2013-05-07 11:51:01 +00:00
Tadashi G. Takaoka 80e396d83c Avoid drawing too long gesture preview trails
Bug: 7167303
Change-Id: I63c2e8fb60f76e80346b67fd44399fa91930f2f0
2013-05-07 20:48:46 +09:00
Jean Chalard e8b9b35471 Unify space-adding on gestures.
This is much simpler, and more correct.

Bug: 8808497
Change-Id: I7a56bf9d6d9fb481f898b7a9f5898a86c11b34c0
2013-05-07 20:38:09 +09:00
Satoshi Kataoka a9dd74cf3f refactor spell checker
Change-Id: Ie7bea23f2ac54f03572e77c31ba7cb3d5e8f8d2f
2013-05-07 20:21:11 +09:00
Tadashi G. Takaoka 9d71a6c968 Remove unused device form factor values
Change-Id: I1ed88b842a3d45e5460dd387bfad4276c844096a
2013-05-07 18:52:22 +09:00
Tadashi G. Takaoka 84ac8f31fb Move empty listner to KeyboardActionListener.Adapter
Change-Id: Ic7bad73c089de015746c667bbfb2c09bd429a9fc
2013-05-07 16:40:15 +09:00
Tadashi G. Takaoka 61b6fc7d7b Clean up unused static variable
Change-Id: I51c5903b7716d3927d2ff09a5054725215a626b5
2013-05-07 16:36:32 +09:00
Tadashi G. Takaoka ce67b41661 Record down point as gesture preview trail for sure
Change-Id: Ic712a6af8229a9a1aa4a5419d779927f1ef8be67
2013-05-07 15:51:23 +09:00
Tadashi G. Takaoka 4ddf1e47a7 Remove unused gesture preview trail code
Change-Id: I2aa77675628a4b1655b30852c950f5daae6f0a92
2013-05-07 14:27:34 +09:00
Baligh Uddin 580d4e9950 Import translations. DO NOT MERGE
Change-Id: I066a2af59e34e18a530af0f3977c4aecab350ef8
Auto-generated-cl: translation import
2013-05-06 13:47:37 -07:00
Baligh Uddin dd8197bcb2 Import translations. DO NOT MERGE
Change-Id: I838674303010d6bff9e3a6f747fd265d1c82baac
Auto-generated-cl: translation import
2013-05-03 16:52:20 -07:00
Tadashi G. Takaoka a5be033d4a Preserve setup wizard step while orientation change
Bug: 8159728
Change-Id: I596f59749443b8878b5613285f0fe793d449cdbd
2013-05-02 18:42:10 +09:00
Tadashi G. Takaoka 7d19ab5c9d Using int instead of booleans to save keyboard shift state
This is a follow up of Ib2bc262aac.

Bug: 8734294
Change-Id: I0b56797ffc4f16e18da72352777fe0f000d173aa
2013-05-02 16:21:39 +09:00
Tadashi G. Takaoka 7f8dd50b8f Save automatic shift state while orientation changing
Bug: 8734294
Change-Id: Ib2bc262aacedf786a318c2fe1bd4420a21e7d847
2013-05-02 15:48:56 +09:00
Baligh Uddin 3985e632ad Import translations. DO NOT MERGE
Change-Id: I3f66d23846516560e3a1e316cf56dc7a17dfe9e2
Auto-generated-cl: translation import
2013-05-01 14:35:47 -07:00
Jean Chalard 83757d439e Merge "Pass blockOffensiveWords as a parameter" 2013-05-01 11:57:36 +00:00
Jean Chalard 2dbb5957e3 Pass blockOffensiveWords as a parameter
Bug: 8773353
Change-Id: Ic1019742ce7ff6e4f7fff4d2729f8ab52d841488
2013-05-01 20:47:35 +09:00
Ken Wakasa 1490b53416 Cleanup -- follow up to Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1
Change-Id: Icb89c5119a67edaa019d5f7645b734cfcfc29041
2013-05-01 20:19:05 +09:00
Jean Chalard 53b37dc098 Merge "Fix a layout problem for pre-MR2" 2013-05-01 09:56:00 +00:00
Jean Chalard b15e822234 Fix a layout problem for pre-MR2
...where marginStart is not supported yet.

Change-Id: Id4f642333c17d091b1ab36549ca580f4572d3bf4
2013-05-01 18:45:24 +09:00
Satoshi Kataoka 1641a4a457 Merge "Fix Google spell checker tests" 2013-05-01 09:31:52 +00:00
Satoshi Kataoka d5781eef62 Fix Google spell checker tests
Bug: 8613307

Change-Id: Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1
2013-05-01 18:21:56 +09:00
Tadashi G. Takaoka 0caf3f6a04 Merge "Introduce MoreSuggestionsListener class" 2013-05-01 09:15:26 +00:00
Tadashi G. Takaoka 6f7905ae75 Introduce MoreSuggestionsListener class
Bug: 8694255
Change-Id: I9420a7cb1983c6211f58d13b3b11db4347c3f99b
2013-05-01 18:03:37 +09:00
Satoshi Kataoka 6314b845f4 Merge "Add permissions for personalization" 2013-05-01 08:13:40 +00:00
Satoshi Kataoka 492557e4f7 Add permissions for personalization
Bug: 8683365

Change-Id: Ia74d730a6b778c0e647794efc8c3a810c715902c
2013-05-01 17:10:20 +09:00
Tadashi G. Takaoka 47a66b12ec Override View.drawableStateChanged to detect state_pressed
Unlike on JB, View.setPressed(boolean) is never called when the view
is pressed on ICS. To detect a pressed state of the view, we need to
override View.drawableStateChanged() and check the drawable state
contains state_pressed.

Bug: 8159728
Change-Id: I481051364d6f3d1370742723c3ce19d898ea5463
2013-05-01 14:02:18 +09:00
Tadashi G. Takaoka 7b2114a428 Display still image when device can't play welcome video
Note that the still image in this change is a placeholder and must be
replaced by final asset.

Bug: 8159728
Change-Id: I4f5a28e0af711edacbc87c2ee64508f34f67f0da
2013-05-01 12:24:36 +09:00
Jean Chalard 019c38060d am ace3f3c5: am 25c90e6d: Merge "Don\'t do recorrection when suggestions are off." into jb-mr2-dev
* commit 'ace3f3c5d56f5b4a58e8dc400fec1bb8c7b17a63':
  Don't do recorrection when suggestions are off.
2013-04-30 19:22:13 -07:00
Jean Chalard ace3f3c5d5 am 25c90e6d: Merge "Don\'t do recorrection when suggestions are off." into jb-mr2-dev
* commit '25c90e6d51aeca5dce05b5adb691876b55a142d5':
  Don't do recorrection when suggestions are off.
2013-04-30 19:19:04 -07:00
Jean Chalard 25c90e6d51 Merge "Don't do recorrection when suggestions are off." into jb-mr2-dev 2013-05-01 02:16:20 +00:00
Jean Chalard aa3a96f3a1 Don't do recorrection when suggestions are off.
Bug: 8767981
Change-Id: If5c775e488b91ae03ecce2673c99918ac8134928
2013-05-01 10:17:28 +09:00
Baligh Uddin b4251873b0 am e5ae0bd3: Import translations. DO NOT MERGE
* commit 'e5ae0bd36aaaa3396ed09e23c7a19acab63eed7f':
  Import translations. DO NOT MERGE
2013-04-30 16:42:49 -07:00
Ken Wakasa a0b62ece83 Merge "Cleanup an unused return value" 2013-04-30 11:16:28 +00:00
Baligh Uddin e5ae0bd36a Import translations. DO NOT MERGE
Change-Id: I90d5918cc37eaa6d3e19822e149a8a16b9d76744
Auto-generated-cl: translation import
2013-04-30 03:55:36 -07:00
Tadashi G. Takaoka 1187ef9a97 Merge "Catch error while playing welcome video" 2013-04-30 09:31:20 +00:00
Jean Chalard 37bbaea8a1 Merge "[PB14] Cosmetic fixes to the progress bar" 2013-04-30 09:20:41 +00:00
Tadashi G. Takaoka ad46c9e0e0 Catch error while playing welcome video
Bug: 8159728
Change-Id: Ic8eea7993f12395d6eca6db8d5529803251a9fee
2013-04-30 18:18:32 +09:00
Jean Chalard 7eff677c29 [PB14] Cosmetic fixes to the progress bar
Bug: 7600384
Change-Id: I33ea155c0c97c7ead07686c4d2a9e0d98be9929c
2013-04-30 17:54:09 +09:00
Ken Wakasa 0d6c87d113 Cleanup an unused return value
Change-Id: I974964aa3cc24b5480e57bd38c197fe7a49acaa4
2013-04-30 16:53:18 +09:00
Satoshi Kataoka 71c1e50fdb Merge "Fix the title of the fragment of the personal dictionary" 2013-04-30 07:11:13 +00:00
Jean Chalard 01170ffebe [PB13] Actually update the progress bar
Bug: 7600384
Change-Id: Iaa8f3a59243a15d2a01aaf6017ed85c52b6482a6
2013-04-30 15:48:26 +09:00
Tadashi G. Takaoka 965329c192 Fix missing string reference of spellchecker.xml
This is a followup of I8dea5393ad.

Change-Id: I311c50cf8205298f20694e068bb9a4b661df8a8b
2013-04-30 15:31:58 +09:00
Satoshi Kataoka 5aa14c2636 Fix the title of the fragment of the personal dictionary
This change is corresponding to I9b8bab21b144385bc2386e7fcb

Bug: 8600958
Change-Id: I0a0cf37d0a11c14a51dc63b2e4371facb34514d0
2013-04-30 15:01:51 +09:00
Jean Chalard d282ebfb71 [PB12] Implement the progress bar update lifecycle
This ensures the thread does not run uselessly (it is even terminated when
the progress bar exits the screen).

Bug: 7600384
Change-Id: I09117a6f763b574b9b3266f36ba3da4720dc9224
2013-04-30 14:55:10 +09:00
Jeff Sharkey 7a800e7982 Merge "Avoid leaking AssetFileDescriptor." 2013-04-30 01:11:02 +00:00
Jeff Sharkey c5ebc792d6 Avoid leaking AssetFileDescriptor.
Change-Id: Iac388c8aefc684980cb4c7131fb47319f6073eb3
2013-04-29 12:26:44 -07:00
Baligh Uddin ed9ef5a778 am af77854a: am 31a70de6: Import translations. DO NOT MERGE
* commit 'af77854afce13fa54826cbe2c55745030621cb5a':
  Import translations. DO NOT MERGE
2013-04-29 11:22:26 -07:00