Commit Graph

42 Commits (a3b3991f45f125c855a930233c5c78d60260e881)

Author SHA1 Message Date
Yohei Yukaw 490fa47a46 Always specify non-null Locale object to SuggestionSpan
Confusingly, specifying a null Locale object to the constructor
of SuggestionSpan does not necessarily mean that
SuggestionSpan#getLocale() returns null.  The constructor in
question also receives Context object, and Context's locale can
be used as a fallback locale to initialize locale of
SuggestionSpan.

With this CL, LatinIME always specify non-null Locale object
when instantiating SuggestionSpan object.  It basically
corresponds to the active main dictionary, but can be
Locale#ROOT when one locale is not determined for some reasons.

BUG: 20435013
Change-Id: I2c152466410327300e7dba4d7ed9a22f57c17c4f
2015-04-20 20:29:44 -07:00
Dan Zivkovic 63a0bdb41b Forgot to remove reference to deleted class.
Change-Id: Ic662a536e468390a3f7266daf9c56e4fc5a70ac6
2015-03-03 12:11:00 -08:00
Tadashi G. Takaoka ebe5b42f71 Make LocaleUtils.constructLocaleFromString as @Nonnull
Change-Id: I82d574c67b25239510f3ecc8882efe46e40677eb
2014-11-21 12:02:06 +09:00
Jean Chalard 5b91b551e5 Move util classes under common
Also why did we have two copies of LocaleUtils >.>

Bug: 18108776
Change-Id: I03b4403dfd51934e66b567f2f8b87da419cfb3ab
2014-11-07 18:00:03 +09:00
Yohei Yukawa 03c1e7955a Add a utility method to SuggestionSpanUtils
This is a ground work for subsequent CLs.

BUG: 16995261
Change-Id: Icbb708a35412a635a0d625b520069840c0bb0904
2014-10-06 16:22:51 +09:00
Yohei Yukawa ceedaf6321 Add unittest for SuggestionSpanUtils
This adds unittest for SuggestionSpanUtils for subsequent CLs.
No behavior change is intended in this CL.

BUG: 16995261
Change-Id: I90d1591cab893a1421ca633963b7c8f00a5fe4b4
2014-10-06 12:24:46 +09:00
Jean Chalard 8380f921f7 Fix a bug where the top prediction would disappear.
This is because prediction can't be easily distinguished in
style. This fixes the bug by simulating the right members,
but some refactoring should be done to remove useless
booleans.

Bug: 17271923
Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
2014-08-26 20:35:59 +09:00
Tadashi G. Takaoka 03a1c442ae Clean up compatible utility classes
Change-Id: I95a682052037d292801477db0f05e04926b61412
2014-08-04 01:21:29 +00:00
Tadashi G. Takaoka 2dae79b196 Rename LatinImeLogger to DebugFlags
Bug: 15318007
Change-Id: Ic0268fd12865c9a692a5e7110a9beb76cb8b6d7f
2014-07-16 18:49:00 -07:00
Keisuke Kuroyanagi a6278eb9c1 Use whether it's exact match to detect distracters.
Bug: 13142176
Change-Id: Id5b7286d28897931f7bfe571be45d46ffeef4adf
2014-05-26 21:56:20 +09:00
Tadashi G. Takaoka a91561aa58 Use Java 7 diamond operator
Change-Id: If16ef50ae73147594615d0f49d6a22621eaf1aef
2014-05-24 01:05:42 +09:00
Tadashi G. Takaoka a273319c59 Add PunctuationSuggestions class
This change must be checked in together with I366c477516.

Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
2014-02-14 14:13:39 +09:00
Jean Chalard e22e67e37a [IL57] Don't require a main dict suggestion.
This is bad for recorrection (it will ignore recorrection suggestions).
But if you think about it well, if you didn't have a main dict, then you
probably will compute the same stuff anyway. It's not useful
to make this check at all.

Bug: 12297051
Change-Id: I6d6cf4d9353b7c668c5413c67701563b243e585c
2014-01-16 03:22:51 +09:00
Jean Chalard a905fcec00 [IL16] Improve getTextWithSuggestionSpan
Dynamically test for the presence of main dict suggestions. This
is much more potent and more accurate than the vaguely defined
boolean.
Also, resolve a TODO and avoid creating an object uselessly.

Not directly related, but helpful with:
Bug: 8636060

Change-Id: Ib1745f77ee6d9ec7cd8bbfa5a548652ec84ec902
2013-12-20 15:13:48 +09:00
Jean Chalard 93445b4821 Fix some warnings
Change-Id: I7290cd1fb675a1b85b9b6ac2d464c932b5bca1dd
2013-07-31 16:17:01 +09:00
Ken Wakasa e28eba5074 Move util classes to the latin/utils directory
Change-Id: I1c5b27c8edf231680edb8d96f63b9d04cfc6a6fa
2013-06-24 17:04:40 +09:00
Ken Wakasa b6ca354431 Small code cleanups
Multi-project commit with I249d5fbe

Change-Id: Ia28c4e970992aa1299a30e604eaa5d096655c3a5
2013-01-07 12:13:42 +09:00
Ken Wakasa fbe83245c9 Clean up SuggestionSpanUtils for API level 14+
Change-Id: Iadc235524341b48e7618e9ce05907c786409e004
2012-12-17 19:41:44 +09:00
Tadashi G. Takaoka bc464e2952 Replace useless CharSequence to String
Change-Id: Idc478f901185ee1b4912acc82d0cbc54fee4e991
2012-10-22 11:03:28 -07:00
Tadashi G. Takaoka c6ff7c42d9 Add SuggestedWords.isEmpty() method
Change-Id: I0fcb104a6a81aee4b99f5ee848eba7495630dc7d
2012-10-03 15:09:10 +09:00
Tadashi G. Takaoka 1e11c44d1b Make utility classes final
Change-Id: Ic4f69b4c8da33c9fca50d6829724179310c2f875
2012-08-29 17:38:08 +09:00
Tadashi G. Takaoka 5f282ea9e4 Add CollectionUtils class to create generic collection easily
Change-Id: I6b4de9187e122298e5e9cd8ddc9070d062df6a89
2012-08-22 10:21:38 +09:00
Tadashi G. Takaoka 7a13975700 Cleanup unused import and dead code
Change-Id: Ife877620561d29a8f25602916420741186104617
2012-08-06 17:28:33 +09:00
satok 0142b997bf Do not set "SuggestionSpan"s for suggestions from the next word predicition
Bug: 6294817
Change-Id: I5010eafa5ba7e947743706adf7e722f4f0cfb415
2012-05-15 12:08:31 +09:00
satok 65ebe190a9 Do not pass misspelled flags to TextView
Bug: 6310268
Original CL: I2f7a54ae0d63235a0b94e039109ab8

Change-Id: I28f64a4d0bb262db819f5f8c0ffc58a259c8e62d
2012-04-17 15:51:08 +09:00
satok cf6b2099be Add isDictionaryAvailable to SubtypeSwitcher
Change-Id: I534878d330b57bbfaa8b7711082456969771f4dc
2012-04-12 19:46:02 +09:00
Ken Wakasa aa300bb73a Don't draw red underline for manually picked words that came from bigram prediction
Change-Id: I544680c8b4b1baff71bd08168630a34e803c40b9
2012-04-05 20:50:27 +09:00
Tadashi G. Takaoka fde7efd877 Add private constructor to utility classes
Bug: 6129704
Change-Id: I52925ae7bd80683f63efc48649448865a5654f41
2012-04-03 18:01:04 +09:00
Tadashi G. Takaoka c61cd79229 Fix some obvious compiler warnings
Change-Id: I10a634f7492b45d5a72345f14d36cf341946387d
2012-03-29 15:07:53 +09:00
satok 356776a9b7 Put a misspelled flag if the word is not valid by the same logic of Android spell checker.
Bug: 6222722

Currently, the flags of the suggestion span from the Latin IME is different from the flags from Android spell checker.

Change-Id: I2f7a54ae0d63235a0b94e039109ab8b2f1311055
2012-03-27 17:11:48 +09:00
Jean Chalard 4f6cf258fe Use the unique flag in SuggestionsView
Also, the first word in a sugestions list can never be
obsolete.

Change-Id: Ib21439aac8db4e6ce5b15b7a2aabe4222bc354db
2012-03-15 14:11:41 +09:00
satok b95905669c Refactor reflection member
Change-Id: I112dbf851e10dae9e4291cf440f01b28d51180f4
2011-12-06 16:35:02 +09:00
satok e5db3871b1 Fix a field value for the suggestion max size
Bug: 5574747

This bug was introduced by I5e40edf6f790c078c4a05d

Change-Id: I5b0f51e1f5e8a12d786657167082bc604089505e
2011-12-05 12:53:45 +09:00
satok 68ef7b77ed Use reflection to get field values of SuggestionSpan
Bug: 5440299
Change-Id: I5e40edf6f790c078c4a05d0d347a89d63f7c042a
2011-10-28 19:03:49 +09:00
satok 53af4ae634 Set SuggestionSpan with FLAG_AUTO_CORRECTION as a composing span
Bug: 5460262
Change-Id: Ibeb875bb885fb663ed23f0299d671e995a66b642
2011-10-15 02:02:41 +09:00
satok ec780e2868 Put SuggestionSpan as the indicater of the auto-correction
Bug: 5245468

Change-Id: Ia5609e1b3c69f5553e3632fbce60a55665a5b185
2011-10-10 18:44:52 +09:00
satok add3e05379 Do not put the suggestion span for obsolete suggestions.
Bug: 5219037

Change-Id: I0300fbc7e1cc97f0f8ba4d21e0e699d9fe66ed76
2011-08-26 19:12:18 +09:00
satok 23726dbdca Refactor of SuggestionSpanUtils
Change-Id: Id266062831e8c28a346e129168b883ee3d5622bf
2011-06-17 18:25:36 +09:00
satok 064e21bb1d Remove the original text from SuggestionSpan
Change-Id: If70d32cad980b46ba77f399606d7ab3957c5d096
2011-06-15 18:32:07 +09:00
satok ea9098ca69 Add SuggestionSpan suggestion picked notification receiver
Bug: 4443922

Change-Id: I8a9dc5077ae06c6d0c39fd7fdd823fc4f4d05f45
2011-05-26 19:47:29 +09:00
satok 0d4757bb0b Disable the legacy recorrection functionalities if the suggestion span is supported
Bug: 4346045

Change-Id: Ib4594a9073b961038564bbcd601f9c290d153d5d
2011-05-25 18:37:48 +09:00
satok 1fef530ec7 Put SuggestionSpan at commitText
Bug: 4346045
Change-Id: Iaabdb8a148b2601bb9cbc2b08509adac164105a4
2011-05-25 17:48:31 +09:00