Commit graph

30709 commits

Author SHA1 Message Date
Jean Chalard
db38d5cf63 [IL123] Put the settings values inside the transaction
A transaction should always operate with a consistent set
of settings. It's better to have it reference them than to
always pass them along.

Bug: 8636060
Change-Id: I3c642dfea6be30712fc6cbb279c64f3185895791
2014-03-06 14:20:37 +09:00
Jean Chalard
5054530934 Merge "[IL122] Put the code, x and y in the transaction" 2014-03-06 03:55:00 +00:00
Jean Chalard
29881854bc [IL122] Put the code, x and y in the transaction
Bug: 8636060
Change-Id: Icdf87995dedec410b54c306e8d312ba7ec25cea6
2014-03-06 12:50:07 +09:00
Tadashi G. Takaoka
dbe531efa8 Merge "Remove unused text resource keylabel_for_east_slavic_row1_12" 2014-03-06 02:47:06 +00:00
Baligh Uddin
0b3f8935b5 Import translations. DO NOT MERGE
Change-Id: I7a730021b1c38c8ef7aa62b567a68a7cc478e516
Auto-generated-cl: translation import
2014-03-05 17:17:49 -08:00
Keisuke Kuroyanagi
de36b47d29 Use BinaryDictionaryUtils to read dictionary header.
Bug: 8187060
Bug:13035567
Change-Id: I90a5e0665c367f5a1bd786f4babf0d03e79e68fa
2014-03-05 19:42:53 +09:00
Keisuke Kuroyanagi
a84f7848d8 Merge "Fix: The top left key is a proximity of nonexistent keys." 2014-03-05 10:27:27 +00:00
Keisuke Kuroyanagi
274eae95ba Merge "Separate utility methods from BinaryDictionary." 2014-03-05 10:07:33 +00:00
Keisuke Kuroyanagi
6501255111 Fix: The top left key is a proximity of nonexistent keys.
Bug: 13315755
Change-Id: I39e905b6ddfc8d3510c408a3bea853390a75d088
2014-03-05 19:06:18 +09:00
Jean Chalard
c6e200ef3a Correctly update the suggestion strip on non-resumable word
Bug: 13303965
Change-Id: Iedc5d38f70af76fbebb99e59a0d17c1e226c810d
2014-03-05 18:47:41 +09:00
Keisuke Kuroyanagi
e784148ae6 Separate utility methods from BinaryDictionary.
Bug: 8187060
Change-Id: Ice2984e332b7bd3bb17174aefc80b5635b72fc50
2014-03-05 18:19:34 +09:00
Jean Chalard
4f6ce0df0b Merge "[IL121] Introduce InputTransaction" 2014-03-05 08:41:30 +00:00
Keisuke Kuroyanagi
287861c04b Merge "Separate utility methods from BinaryDictionary in native code." 2014-03-05 08:09:18 +00:00
Jean Chalard
7b905c40e9 [IL121] Introduce InputTransaction
We probably can't put this off any longer

Bug: 8636060
Change-Id: I1e5d3cf62d719f4d064ced3282bebf2e822f6baa
2014-03-05 17:04:10 +09:00
Keisuke Kuroyanagi
9e51c6c0c6 Separate utility methods from BinaryDictionary in native code.
Bug: 8187060
Change-Id: I099de557d2aaee95c6b809450108139550e9b0aa
2014-03-05 12:49:04 +09:00
Baligh Uddin
25d912df58 Merge "Import translations. DO NOT MERGE" 2014-03-04 17:24:35 +00:00
Tadashi G. Takaoka
8204078a84 Merge "Remove unused MoreKeysPanel argument from Controller interface" 2014-03-04 10:53:23 +00:00
Tadashi G. Takaoka
11eb0f9c14 Merge "Add action key label/icon tests" 2014-03-04 10:53:13 +00:00
Jean Chalard
151761a276 [IL120] Cleanup
Remove useless arguments, local vars, make stuff private

Change-Id: I7cc6c19e9c1703304d593e02be31eb9569cc7b4e
2014-03-04 17:52:14 +09:00
Jean Chalard
fb28935f82 [IL119] Make fields private.
Change-Id: Ia84d3e5a102e1056e3d7467be07df89390f17617
2014-03-04 17:52:14 +09:00
Jean Chalard
0e489d1ba3 [IL118] Factorize a method
If we can't get the right locale from the subtype switcher, we
should fallback in all cases.

Change-Id: I46a53a67927a793d9d3592a996a5a4392a36c6ff
2014-03-04 17:52:14 +09:00
Jean Chalard
129ca9e7eb [IL117] Simplification
Change-Id: Id4d4f30ecdc80dd59543f90fe2525f4bcc5afb9d
2014-03-04 17:52:11 +09:00
Tadashi G. Takaoka
4309b83ea9 Remove unused text resource keylabel_for_east_slavic_row1_12
The text resource used in 10 inch tablet layout.

This change also corrects {keylabel|more_keys}_for_east_slavic_row2_1
to _row2_2.

Change-Id: I60d69af22f97c008449b8dccc7c84ae6a05fe0d8
2014-03-04 17:12:31 +09:00
Jean Chalard
cf12210757 Merge "[IL116] Inline a method" 2014-03-04 07:48:02 +00:00
Jean Chalard
1940f26edb Merge "[IL115] Cleanup continues" 2014-03-04 07:46:11 +00:00
Tadashi G. Takaoka
1f215a58c9 Remove unused MoreKeysPanel argument from Controller interface
Bug: 13204690
Change-Id: Ife438e78d9bbbf796df20f95c2da7a4d50e5a035
2014-03-04 16:05:15 +09:00
Tadashi G. Takaoka
c451b4dee8 Merge "Separate flaky unit test from KeyboardLayoutSetTestsBase" 2014-03-04 06:57:31 +00:00
Tadashi G. Takaoka
3da9e4ade0 Add action key label/icon tests
Bug: 13017434
Change-Id: Ib04b377f4f4f9081573ef341f15b4b444ce7260c
2014-03-04 15:42:59 +09:00
Tadashi G. Takaoka
73b3b81149 Separate flaky unit test from KeyboardLayoutSetTestsBase
Move the flaky unit test to KeyboardLayoutSetSubtypesCountTests.

Bug: 13291370
Bug: 13017434
Change-Id: I2144be4cc6b8215b895c45f47a5190fdeaa806f9
2014-03-04 15:40:40 +09:00
Jean Chalard
2ca916c215 [IL116] Inline a method
Change-Id: I6af8f2bd6b4917f9b119ff78a0f299b2f6fb921e
2014-03-04 14:46:04 +09:00
Jean Chalard
030da519de [IL115] Cleanup continues
Bug: 8636060
Change-Id: I944b10ec9798eec57d986e1075ba348aa0892cae
2014-03-04 14:46:04 +09:00
Jean Chalard
e110018e2a [IL114] Move a method to InputLogic
Bug: 8636060
Change-Id: I0d8f93985ddc6e93ce9af0d92a8056620351a498
2014-03-04 14:46:04 +09:00
Jean Chalard
5d8f6660bf [IL113] More cleanup
We should not test punctuation with this equality test any more.
Also, whether the suggestion strip is displayed or not, or whether
the hint is displayed or not, has nothing to do with this method
and should be handled elsewhere rather than here -- and as a
matter of fact, it is, which makes this useless.

Bug: 8636060
Change-Id: I6a54ee87e4e9f81bc33158acf4a264c3abd5829d
2014-03-04 14:46:04 +09:00
Jean Chalard
c92dabb27e Merge "[IL112] Cleanup" 2014-03-04 05:45:15 +00:00
Jean Chalard
27c23c691c Merge "[IL111] Remove a member." 2014-03-04 05:36:00 +00:00
Jean Chalard
145e8568f4 [IL112] Cleanup
Bug: 8636060
Change-Id: Ic7c2dec2521613d52707457463691bec383177ff
2014-03-04 14:32:02 +09:00
Jean Chalard
32c6d4caea [IL111] Remove a member.
...and improve encapsulation and readability.

Bug: 8636060
Change-Id: I36407630b307df0721ea7fdb7e7a22cdf2b018b3
2014-03-04 14:31:47 +09:00
Tadashi G. Takaoka
ddc21f5bd1 Dismiss all key preview before showing more suggestions
This CL also release key graphics and dismiss sliding key input
preview.

Bug: 13204690
Change-Id: Ie8eb7b7beca51689a907da9c0713b4d34d48dda1
2014-03-04 14:26:00 +09:00
Ken Wakasa
61c726f591 Merge "Dismiss more keys keyboard before statring more suggestionsview to show" 2014-03-04 01:10:09 +00:00
Tadashi G. Takaoka
56e0373b5c Dismiss more keys keyboard before statring more suggestionsview to show
Bug: 13204690
Change-Id: I9188edd0e99ca8acdcb0f0e045be7d267d56b12d
2014-03-04 10:02:05 +09:00
Baligh Uddin
44c7ffb697 Import translations. DO NOT MERGE
Change-Id: I43912170c269379a86d2ae98efb2198f374a25aa
Auto-generated-cl: translation import
2014-03-03 16:40:23 -08:00
Tadashi G. Takaoka
8df489444d Merge "Fix InputMethodInfo cache in RichInputMethodManager" 2014-03-03 15:16:55 +00:00
Tadashi G. Takaoka
ad5795a891 Fix InputMethodInfo cache in RichInputMethodManager
Bug: 13271570
Change-Id: Ie06cd83baaaf674d8b34f0232c164c4541aceb43
2014-03-03 23:36:35 +09:00
Tadashi G. Takaoka
3f91acdc96 Add additional subtypes test
Change-Id: I2994fd72bc284c84757f5a2bfa8045aa574a8fbc
2014-03-03 17:16:02 +09:00
Tadashi G. Takaoka
f2b0829aa1 Merge "Fix unit test message to use 0-based index" 2014-03-03 07:08:45 +00:00
Keisuke Kuroyanagi
e76c273502 Merge changes I20ce61c4,I2edab4e3
* changes:
  Remove "Use only personalization dictionary".
  Remove redundant creation of dictionary facilitator.
2014-03-03 04:00:24 +00:00
Tadashi G. Takaoka
d648d066ea Fix unit test message to use 0-based index
Change-Id: I2c91628d21dc96712f6cbea996f28f5d39fb402e
2014-03-03 12:39:53 +09:00
Keisuke Kuroyanagi
858045b41c Merge "Fix: wrong auto correction for whilelist and personalized words." 2014-02-28 12:26:03 +00:00
Keisuke Kuroyanagi
23ae574a11 Fix: wrong auto correction for whilelist and personalized words.
This happens when there are tailing single quotes.

Bug: 13237314
Change-Id: I7fd2a20b25ac2217f9621d7f2510345bbd633c14
2014-02-28 21:24:26 +09:00
Keisuke Kuroyanagi
5128935ac4 Add header attributes for evaluation.
Bug: 13197276
Change-Id: Ib5247da691ff24a73e13485288237ccc51bb54f0
2014-02-28 21:06:03 +09:00