Commit Graph

6303 Commits (8dd47029f129cf7077c091170a8f7eeb88dd0ccf)

Author SHA1 Message Date
Keisuke Kuroyanagi 33fd13bf3c Check timestamp for each pointer.
Bug: 11325631
Change-Id: I4e296cdeccf21323c5732754e86c3a4075ccf82a
2014-02-04 14:04:26 +09:00
Keisuke Kuroyanagi d79fd29f61 Make dumpAllWordsForDebug() use getNextWordProperty().
Bug: 11736680
Bug: 12810574
Change-Id: I32a388e23ee7da5d7291e88a46c90b61d2f25dee
2014-02-04 13:51:49 +09:00
Keisuke Kuroyanagi 941734695b Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken.
Bug: 12810574
Change-Id: Idea44f03c477964f58e65fbf2b55e3fcd77a2934
2014-02-04 12:42:14 +09:00
Tadashi G. Takaoka 5be8a59a5a Use "Key popup dismiss delay" to control key preview zoom out animation
Bug: 12809303
Change-Id: I2db0362a2f8c512145f1cf9326f06e5f922987b8
2014-02-04 11:43:58 +09:00
Tadashi G. Takaoka b06e455797 Clear important notice strip
Bug: 10587358
Change-Id: Ic90e5825200a1d424aac4ba263b252187a203241
2014-02-03 18:28:21 +09:00
Tadashi G. Takaoka 4d539f2c1e Merge "Fix important notice strip text layout" 2014-02-03 09:14:02 +00:00
Tadashi G. Takaoka 9706f9a2f4 Fix important notice strip text layout
Bug: 10587358
Change-Id: I9cbdd3b450e05d6d0611a16b6b7fad945918dd5f
2014-02-03 18:07:19 +09:00
Tadashi G. Takaoka a2d83dfdc7 Merge "Show important notice dialog" 2014-02-03 08:04:03 +00:00
Tadashi G. Takaoka 342e81e7a6 Show important notice dialog
Bug: 10587358
Change-Id: I3b4282a1bb183aa901110a4a2fc1b6ed72818aae
2014-02-03 16:21:53 +09:00
Jean Chalard 80fa64e66b Merge "Don't resume suggestions if suggestions are not requested." 2014-02-03 07:07:14 +00:00
Jean Chalard 5d9be8039c Merge "Have empty suggestions go through setNeutralSuggestions." 2014-02-03 06:45:45 +00:00
Jean Chalard 2cbf152986 Have empty suggestions go through setNeutralSuggestions.
Bug: 12865205
Change-Id: If17a390c445d0820325a9b16cc4f2f27a361187a
2014-02-03 15:33:00 +09:00
Jean Chalard 9068fd4e77 Don't resume suggestions if suggestions are not requested.
Bug: 12832614
Change-Id: I6a9b6d128d7e0324ba59a43cf153a3b54e1d35bf
2014-02-03 15:20:45 +09:00
Keisuke Kuroyanagi 38f341a2a5 Add a jni method to iterate words in a dictionary.
Bug: 12810574
Change-Id: I87b13559765f0262dfd06c2ba40d43af6437ea7f
2014-02-03 14:51:58 +09:00
Yohei Yukawa 08d72c52f9 Merge "Introduce a delay for key-press feedback on the Emoji palette" 2014-02-03 02:14:59 +00:00
Keisuke Kuroyanagi 5ecf74b148 Merge "Extend jni interface to get bigrams in WordProperty." 2014-01-31 11:53:10 +00:00
Keisuke Kuroyanagi 94d9a2309f Extend jni interface to get bigrams in WordProperty.
Bug: 12810574
Change-Id: Ia4b88d02ea8790a5c47d32376cc0b84c3e071ddd
2014-01-31 20:32:44 +09:00
Tadashi G. Takaoka 2abe1cedc8 Merge "Add important notice strip" 2014-01-31 11:23:52 +00:00
Tadashi G. Takaoka e855093f55 Move some methods to MoreKeySpec class
Change-Id: I025ed15e36ac3113db6a5fccefa0c87f016703fa
2014-01-31 20:19:48 +09:00
Tadashi G. Takaoka 8a296e43c9 Add important notice strip
This change is a groundwork to show important notice.

Bug: 10587358
Change-Id: I80aa70d30e2a529b37798f0df2183b41df3ac38a
2014-01-31 20:07:27 +09:00
Jean Chalard 4e6f72cb80 Merge "[HD03] Straighten out attribute key names in Java." 2014-01-31 08:40:25 +00:00
Tadashi G. Takaoka 7914a97b73 Merge "Move some prefix strings to relevant classes" 2014-01-31 08:11:56 +00:00
Tadashi G. Takaoka 3b4eb03fa1 Move some prefix strings to relevant classes
Change-Id: I7321ac7820d4eded5f16f2440ffb4f525315b3f4
2014-01-31 17:09:14 +09:00
Tadashi G. Takaoka 1e40af5ebe Merge "Refactor KeyboardTextsSet class" 2014-01-31 08:05:02 +00:00
Tadashi G. Takaoka be0d05c5ef Merge "Move important notice version to resource" 2014-01-31 07:37:13 +00:00
Tadashi G. Takaoka 0bae2ab460 Refactor KeyboardTextsSet class
Change-Id: I0b48c85aa2c291e1e7ee25d61c558700fc677e29
2014-01-31 16:31:07 +09:00
Yohei Yukawa 94797fb3a6 Introduce a delay for key-press feedback on the Emoji palette
Currently key-press effect such as highlight and vibration
occur even when a user want to scroll the Emoji palette.
To mitigate this situation, this patch introduces a short delay
for key-press feedback on the Emoji palette.

This is not an ideal solution but should be better than now.

BUG: 11103083
Change-Id: I1fa4514d742eb37f36fef60e6beabbc5eaa1653a
2014-01-31 15:48:10 +09:00
Tadashi G. Takaoka d245f6c9e2 Move arrayAsList method to CollectionUtils
Change-Id: If7c1eb7c802490f19c5d3b81d714362408daf376
2014-01-31 15:26:05 +09:00
Tadashi G. Takaoka de76e62b69 Merge "Move some methods to StringUtils" 2014-01-31 06:16:14 +00:00
Tadashi G. Takaoka 639bf62e4f Move some methods to StringUtils
Change-Id: I29d87fdd65ec879d1c0bdf7e7792a677687c1693
2014-01-31 14:49:36 +09:00
Jean Chalard 79b2e4d86c [HD03] Straighten out attribute key names in Java.
Bug: 11281748
Change-Id: I1d813bdacd45bcfd9c4cc73ac1d67c5c89854e86
2014-01-31 14:46:07 +09:00
Jean Chalard b0df28f4cc Merge "[HD02] Make the date header attribute mandatory." 2014-01-31 03:58:55 +00:00
Tadashi G. Takaoka 5b8ffad26c Move important notice version to resource
Bug: 10587358
Change-Id: Ie24fc6c53b15880f4ace991a25223056f03f5eda
2014-01-31 12:49:36 +09:00
Keisuke Kuroyanagi 748f32feba Merge "Rename UnigramProperty to WordProperty." 2014-01-31 03:06:44 +00:00
Keisuke Kuroyanagi 080a35e959 Rename UnigramProperty to WordProperty.
Bug: 12810574
Change-Id: If5ddd803948aaf6e491ddcbaa5436fb3af3f7257
2014-01-31 11:06:42 +09:00
Jean Chalard a137c21c9c [HD02] Make the date header attribute mandatory.
Bug: 11281748
Change-Id: I48a6f3d95ca89ced0c51335527201ecabfb7998e
2014-01-30 18:19:21 +09:00
Tadashi G. Takaoka 776d46a771 Merge "Show "Touch again to save" in system locale" 2014-01-30 09:17:11 +00:00
Tadashi G. Takaoka 9b1a66843d Show "Touch again to save" in system locale
Bug: 12811156
Change-Id: I928daf17297ec5c526720850d6203cb9af0496ac
2014-01-30 18:03:23 +09:00
Keisuke Kuroyanagi 7ceee45376 Merge "Fix historical info of bigrams reading." 2014-01-30 08:21:34 +00:00
Tadashi G. Takaoka bf2f0892a0 Merge "Add ImportantNoticeUtils class" 2014-01-30 08:08:37 +00:00
Tadashi G. Takaoka a14ddfb5ff Add ImportantNoticeUtils class
Bug: 10587358
Change-Id: I76673b47aab1579cc1310b6a978d04f874d5bcfe
2014-01-30 17:04:05 +09:00
Keisuke Kuroyanagi 971bbcf562 Fix historical info of bigrams reading.
Bug: 12809791
Change-Id: I879279a0d0e1007a7c6cb87a627bf046340dda98
2014-01-30 16:19:22 +09:00
Tadashi G. Takaoka d432892f0c Fix Farsi keyboard comma and period
Bug: 12807701
Change-Id: I49503e9945d97e13d7cc98f54ca071cb935d1e52
2014-01-30 15:45:23 +09:00
Jean Chalard 0c186c31d2 Merge "[IL106] Inline a now useless method." 2014-01-30 03:47:32 +00:00
Jean Chalard 90c072a5ba Merge "[IL105] Remove more useless arguments" 2014-01-30 03:46:08 +00:00
Jean Chalard 362779d608 Merge "[IL104] Remove useless arguments" 2014-01-30 03:45:15 +00:00
Jean Chalard e5040f6b0d Merge "[IL103] Save the typed word separately in SuggestedWords." 2014-01-30 03:44:54 +00:00
Keisuke Kuroyanagi 26bd46095a Reading dictionary containing timestamps in Java Side.
Just skipping historical information fields.

Bug: 11281877
Change-Id: I43d2adaa576b7da11ed3ca54990265dbb6f53b08
2014-01-29 20:19:24 +09:00
Jean Chalard ac84fe642e [IL106] Inline a now useless method.
Bug: 8636060
Change-Id: Ic8e0225206358680aa0de421f17ab443c888036d
2014-01-29 12:23:40 +09:00
Jean Chalard fa7075768d [IL105] Remove more useless arguments
Bug: 8636060
Change-Id: I9e817bb9622c84544a5ca8708e5c1fccad1ed447
2014-01-29 12:23:26 +09:00
Jean Chalard 084c9961f4 [IL104] Remove useless arguments
Bug: 8636060
Change-Id: I97a371fe0c6227eb0f03d3e391a33726e6280322
2014-01-29 12:23:25 +09:00
Jean Chalard 1d2e4f9dcc [IL103] Save the typed word separately in SuggestedWords.
This helps managing the cases where the typed word is not
in the suggestions. This happens during recorrection.

Bug: 8636060
Change-Id: I6784feb793cae96272a7f1d123a0e3bbb8f03143
2014-01-29 12:22:21 +09:00
Tadashi G. Takaoka a454a7b85c Add method to clear user history dictionary for testing
This change should be checked in together with I19cd689157.

Bug: 12179576
Change-Id: I5cc9f52a37ad6623809a14575f3f4b1cd18725c3
2014-01-29 12:01:37 +09:00
Tadashi G. Takaoka 005d2454c9 Merge "Remove suggestion_word and suggestion_info layout files" 2014-01-29 01:05:37 +00:00
Yohei Yukawa be18530acf Merge "Fix inconsistent behavior with the back-to-the-main-keyboard key" 2014-01-28 10:50:23 +00:00
Tadashi G. Takaoka c2ea3f7dd9 Remove suggestion_word and suggestion_info layout files
Change-Id: I37fea41cfc6e717ce7e5aa36ad331675fc9e8ce5
2014-01-28 19:38:35 +09:00
Yohei Yukawa 576f8a5b72 Fix inconsistent behavior with the back-to-the-main-keyboard key
With this patch, the back-to-the-main-keyboard in the Emoji
palette will be registered as a key-release action instead of
a key-press action, like switch-to-the-emoji-palette in the
main layout. This provides mroe consistent UX when the layout is
switched from the main layout to the Emoji palette then
switched back to the main layout.

BUG: 12464067
Change-Id: Ia0d0185db43234dfcfb7cee2677f3d199fe6ed96
2014-01-28 19:30:27 +09:00
Jean Chalard c9cc1b1de5 [IL102] Rename a method
Bug: 8636060
Change-Id: Ia54afdfab9124aa5c35699e357e63eae66a7557f
2014-01-28 17:18:02 +09:00
Jean Chalard 4500dedfa9 [IL101] Remove a method
Bug: 8636060
Change-Id: Ic9c12fc6970987b0e1912e8ae85bed55260d66b5
2014-01-28 17:18:02 +09:00
Jean Chalard 675f1dbaf0 [IL98] Refactoring of setSuggestedWords
Bug: 8636060
Change-Id: Iab53df96f2c23bddc6c70c3560b380fbaef1053c
2014-01-28 17:18:01 +09:00
Jean Chalard 491a6a6f23 [IL100] Pull up a check
Bug: 8636060
Change-Id: I344ed59f5f55b412880fc6dc70205eecb1e79961
2014-01-28 17:18:01 +09:00
Jean Chalard 4761d2fb00 [IL99] Migrate some code to InputLogic.
Bug: 8636060
Change-Id: Ibf1f9c7bdc3fdd872d6c15447fa555434485cc52
2014-01-28 17:18:01 +09:00
Jean Chalard eb00023b9b [IL97] Readability improvement
Bug: 8636060
Change-Id: I6b15c7fb91cd4cf23a993541c19842b51e328f8f
2014-01-28 17:17:58 +09:00
Tadashi G. Takaoka 95e5e267ac Merge "Suggestion strip honors RTL layout" 2014-01-28 07:52:25 +00:00
Keisuke Kuroyanagi 25270ec540 Merge "Check probability before adding to the user history dict." 2014-01-28 07:35:31 +00:00
Jean Chalard 36fda2bae3 Merge "[IL96] Inline a method" 2014-01-28 07:31:48 +00:00
Keisuke Kuroyanagi 90ac041c9f Check probability before adding to the user history dict.
Bug: 12764888
Change-Id: I5da3ef21d9d82b7034e7dc9b7d0fdca0d48a49f4
2014-01-28 16:31:37 +09:00
Jean Chalard 7593f93565 Merge "[IL95] Inline a method that's always called in sequence" 2014-01-28 07:31:31 +00:00
Tadashi G. Takaoka bcd30bf3e7 Suggestion strip honors RTL layout
Bug: 9126496
Change-Id: Ia4a1c52bd2a80ea7fe6b9529f2767fee5f9e8aeb
2014-01-28 15:47:54 +09:00
Jean Chalard 86210c7dc7 [IL96] Inline a method
Bug: 8636060
Change-Id: I517591c484dce74788398cf4a4db9a074d91a6c0
2014-01-28 15:47:04 +09:00
Jean Chalard 90916143b6 [IL95] Inline a method that's always called in sequence
Bug: 8636060
Change-Id: I514cf14596b3fa46eccadcf536342e4bb805708d
2014-01-28 15:47:01 +09:00
Tadashi G. Takaoka 02b087090e Merge "Fix test fails caused by I8bede13c87" 2014-01-28 05:19:53 +00:00
Yohei Yukawa 0272553578 Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete." 2014-01-28 05:06:07 +00:00
Yohei Yukawa 0e04c24a05 Fix inconsistent behavior with the spacebar on the Emoji pallete.
On the Emoji palette, unlike other layouts, a user could not
cancel events by moving the finger away from the spacebar.

With this patch, the actual handler of the spacebar will be
registered as onClick event, which will not occur when the user
cancel the event.

Bug: 12464067
Change-Id: I7e7e11ae5f17073e5d92116adca0702579d3ae9c
2014-01-28 13:44:31 +09:00
Jean Chalard ca1c1ddd4e Merge "[IL94] Remove a function and some reordering" 2014-01-28 03:46:28 +00:00
Jean Chalard 9909d6aa49 Merge "[IL93] Refactor a method inside another" 2014-01-28 03:32:52 +00:00
Jean Chalard cbf54dea49 Merge "[IL92] Straighten out showSuggestionStripWithTypedWord" 2014-01-28 03:32:17 +00:00
Jean Chalard 5a1f837356 Merge "[IL91] Call reorder" 2014-01-28 03:26:23 +00:00
Tadashi G. Takaoka 9ac6c9064d Fix test fails caused by I8bede13c87
Change-Id: I1e816bf7ea5fd46b39c2482bbcbfcdc16d5acc21
2014-01-28 11:17:47 +09:00
Tadashi G. Takaoka c2e2b3949b Merge "Add SubtypeLocaleUtils.isRtlLanguage method" 2014-01-28 01:28:47 +00:00
Jean Chalard 5b5e877efe [IL94] Remove a function and some reordering
Bug: 8636060
Change-Id: I4baa237c9c7b58a8eb4158c34b9d3f3dfb95c69c
2014-01-27 20:38:45 +09:00
Jean Chalard 37e1cc931f [IL93] Refactor a method inside another
The calls to setAutoCorrectionIndicator with a constant are
always the exact same as mWillAutoCorrect.

Bug: 8636060
Change-Id: I8106919819b978b0a9655af2ef444664fad4c1ad
2014-01-27 20:38:45 +09:00
Jean Chalard 4c6029e530 [IL92] Straighten out showSuggestionStripWithTypedWord
Bug: 8636060
Change-Id: I066ff29c76349f0ab61441ea5f7bc9085d24bdbc
2014-01-27 20:38:45 +09:00
Jean Chalard c6367ee64d [IL91] Call reorder
Bug: 8636060
Change-Id: I3d0ce6dcb3b51cabc424d00a397d243c32360e92
2014-01-27 20:38:43 +09:00
Jean Chalard 01893b25dd Merge "[IL90] Small refactoring" 2014-01-27 11:18:52 +00:00
Jean Chalard 3f226af439 Merge "[IL89] Inline a function" 2014-01-27 11:18:19 +00:00
Jean Chalard 5b9e54c135 Merge "[IL88] Simple refactoring" 2014-01-27 11:17:54 +00:00
Jean Chalard 8f3e37a631 Merge "[IL87] Remove a call to clearSuggestionStrip" 2014-01-27 11:17:45 +00:00
Jean Chalard 521a83a3f1 Merge "[IL86] Simplification and correctness fix." 2014-01-27 11:17:31 +00:00
Jean Chalard 7aa7e36611 Merge "[IL85] Maybe show punctuations when app completions are null" 2014-01-27 11:17:18 +00:00
Jean Chalard 264f4e380d Merge "[IL84] Remove a useless call and rename a method" 2014-01-27 11:17:05 +00:00
Jean Chalard 7ac542d490 Merge "[IL83] Inline a call" 2014-01-27 11:16:30 +00:00
Jean Chalard 47ff423121 Merge "[IL82] Fix a wrong comment" 2014-01-27 10:11:42 +00:00
Jean Chalard 75ec579e07 Merge "[IL81] Remove a useless test." 2014-01-27 10:11:14 +00:00
Tadashi G. Takaoka c0c74d22a0 Add SubtypeLocaleUtils.isRtlLanguage method
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
2014-01-27 19:05:16 +09:00
Jean Chalard 6d1c8b2c3f Merge "Try to figure out whether d.quotes open or close." 2014-01-27 10:01:17 +00:00
Jean Chalard b084da2ae6 Merge changes I5092942a,I931c553f
* changes:
  [IL80] Reverse a test for clarity.
  [IL79] Some refactoring
2014-01-27 10:00:37 +00:00
Jean Chalard a3a85e8c2b Merge "[IL78] Move most of onUpdateSelection to InputLogic." 2014-01-27 09:55:08 +00:00
Jean Chalard d38b0468b0 [IL90] Small refactoring
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
2014-01-27 18:42:33 +09:00
Jean Chalard 33ff321d6c [IL89] Inline a function
We will then refactor the contents of showSuggestionStripWithTypedWord

Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
2014-01-27 18:42:33 +09:00
Jean Chalard ca819178a1 [IL88] Simple refactoring
With this, the value passed to suggestedWords is never null.

Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
2014-01-27 18:42:33 +09:00
Jean Chalard d90bdd2187 [IL87] Remove a call to clearSuggestionStrip
The goal is to remove the function completely.

Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
2014-01-27 18:42:33 +09:00
Jean Chalard 3b939ed77f [IL86] Simplification and correctness fix.
This should be what was intended.

Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
2014-01-27 18:42:33 +09:00
Jean Chalard 07eddf3c43 [IL85] Maybe show punctuations when app completions are null
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.

Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
2014-01-27 18:42:32 +09:00
Jean Chalard b2c0388a69 [IL84] Remove a useless call and rename a method
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
2014-01-27 18:42:32 +09:00
Jean Chalard eb190ab32f [IL83] Inline a call
The coming string of changes is very complicated, so
I'm going to do things really slowly.

Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
2014-01-27 18:42:32 +09:00
Jean Chalard 17f1528f9e [IL82] Fix a wrong comment
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
2014-01-27 18:42:32 +09:00
Jean Chalard abbd755689 [IL81] Remove a useless test.
It seems the comments were right all along. This seems to really
be useless.

Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
2014-01-27 18:42:32 +09:00
Jean Chalard f1e5b9b4d1 [IL80] Reverse a test for clarity.
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
2014-01-27 18:42:32 +09:00
Jean Chalard f59487379e [IL79] Some refactoring
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
2014-01-27 18:42:29 +09:00
Jean Chalard 10460441db [IL78] Move most of onUpdateSelection to InputLogic.
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
2014-01-27 18:42:04 +09:00
Tadashi G. Takaoka 1e4b1300e6 Merge "Refactor SuggestionsStripLayoutHelper class" 2014-01-27 09:36:52 +00:00
Jean Chalard 68d7291a6b Merge "[IL77] Remove refs to Settings from InputLogic" 2014-01-27 09:29:50 +00:00
Tadashi G. Takaoka 148dedbc5d Refactor SuggestionsStripLayoutHelper class
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
2014-01-27 18:25:25 +09:00
Jean Chalard 7bee84095e Merge "[IL75] Move the SubtypeSwitcher out of InputLogic." 2014-01-27 09:24:10 +00:00
Tadashi G. Takaoka 829ad708db Merge "Revert "Use ViewCompat support library"" 2014-01-27 09:20:19 +00:00
Jean Chalard 48df380f78 [IL77] Remove refs to Settings from InputLogic
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
2014-01-27 18:18:54 +09:00
Jean Chalard 969c06072d [IL75] Move the SubtypeSwitcher out of InputLogic.
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
2014-01-27 18:18:27 +09:00
Jean Chalard c7ef305bbc Try to figure out whether d.quotes open or close.
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
2014-01-27 18:17:33 +09:00
Tadashi G. Takaoka e4692c0050 Revert "Use ViewCompat support library"
This reverts commit e7ee4fa862.

Change-Id: I56fab60ac859289d3ed51f691cd7e2a15da01856
2014-01-27 18:14:40 +09:00
Jean Chalard 5cf70a1d44 Merge "[IL74] Remove unused/unwanted arguments to a method." 2014-01-27 08:57:12 +00:00
Yohei Yukawa 0b58617951 Merge "Fix inconsistent behavior with backspace in the Emoji pallete." 2014-01-27 08:11:51 +00:00
Jean Chalard 0fd556ceca [IL74] Remove unused/unwanted arguments to a method.
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
2014-01-27 16:48:17 +09:00
Yohei Yukawa ea8c1c811c Fix inconsistent behavior with backspace in the Emoji pallete.
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
  the key.

This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
  different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
  key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
  subsequent delete key events when the finger is moved away
  from the key area.

Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
2014-01-27 16:24:51 +09:00
Tadashi G. Takaoka f3ca92dd33 Merge "Use ViewCompat support library" 2014-01-27 07:21:41 +00:00
Tadashi G. Takaoka e7ee4fa862 Use ViewCompat support library
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
2014-01-27 16:11:03 +09:00
Ken Wakasa 03283b636c Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
some cleanups as well

Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
2014-01-27 16:08:27 +09:00
Keisuke Kuroyanagi 95043145df Merge "Check length of words for personalization dict." 2014-01-25 00:44:58 +00:00
Keisuke Kuroyanagi b7197b705b Check length of words for personalization dict.
Bug: 12602903

Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
2014-01-24 16:32:28 -08:00
Ken Wakasa 0acd121083 Fix wrong indents.
Removed an unused method too.

Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
2014-01-24 23:55:33 +09:00
Jean Chalard b6e128cc05 Merge "[IL69.1] Move a static method to a utility class." 2014-01-24 03:04:12 +00:00
Jean Chalard 1d6e647ac3 [IL69.1] Move a static method to a utility class.
This is a followup to IL69.

Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
2014-01-24 11:59:23 +09:00
Jean Chalard 0c72529088 Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer" 2014-01-24 01:55:57 +00:00
Jean Chalard 3aa2043a66 Merge "[IL76] Remove a SuggestionStripView dependency" 2014-01-23 10:06:42 +00:00
Jean Chalard f16a2a36d2 [IL71.1] Add some javadoc.
Change-Id: I382abd3104d535a1e868935d8cfb4e34ad8ebaed
2014-01-23 17:11:47 +09:00
Jean Chalard a1ed211c4e [IL76] Remove a SuggestionStripView dependency
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.

Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
2014-01-23 16:25:48 +09:00
Jean Chalard 4173610bc5 [IL66.1] Add a comment
Followup to IL66

Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
2014-01-23 16:00:49 +09:00
Jean Chalard be846fc352 [IL73] Remove all refs to Key and Keyboard in WordComposer
Please hold my gun while I have this nice cup of tea.
Yes !!

Bug: 8636060
Change-Id: I33c8ffe51bb2106b17f7941235ad1e427e3a81f7
2014-01-23 15:52:29 +09:00
Jean Chalard df8310c6e2 Merge "[IL71] Add indices to toCodePointArray." 2014-01-23 06:50:19 +00:00
Jean Chalard 1284e556f4 [IL70] Remove unused arguments
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
2014-01-23 15:33:14 +09:00
Jean Chalard d1f463eacf [IL69] Oust Keyboard from WordComposer#setComposingWord
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
2014-01-23 15:32:59 +09:00
Jean Chalard 9da4b49ef6 [IL68] Start refactoring setComposingWord
Bug: 8636060
Change-Id: I242b7c264abf380bcd6b6b3c848238921f988e54
2014-01-23 15:15:49 +09:00
Jean Chalard 18638d30c0 [IL71] Add indices to toCodePointArray.
This is necessary for tests

Bug: 8636060
Change-Id: I50ea401a22e4df72333eda61ca39aa180966ee4b
2014-01-23 13:11:40 +09:00
Jean Chalard eb6d41a525 [IL67] Externalize a call to the keyboard switcher
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
2014-01-23 13:10:02 +09:00
Jean Chalard ab80b41a0d [IL66] Remove two accesses to KeyboardSwitcher.
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
2014-01-23 13:09:58 +09:00
Jean Chalard a91dfff5e5 [IL65] Pull up X,Y processing, step 4
This works because getKey{X,Y} is a no-op on
Constants.NOT_A_COORDINATE.

Bug: 8636060
Change-Id: I2f7dd96b6011f094110f7978f8ff24ef2a6e2585
2014-01-22 14:44:27 +09:00
Jean Chalard 352286a43b [IL64] Pull up X,Y processing, step 3
Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
2014-01-22 14:44:25 +09:00
Jean Chalard b8216a4e7e [IL63] Pull up X,Y processing, step 2
This also fixes the coordinates passed to logOnDelete and
log onSeparator.

Bug: 8636060
Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
2014-01-22 14:42:52 +09:00
Jean Chalard 2b38b5e8e6 [IL62] Pull up X,Y processing, step 1
This is fine because getKey{X,Y} is idempotent for any
non-keyboard coordinate value.

However this makes a net change : the x,y values passed to
LatinImeLoggerUtils.onNonSeparator are now different.
The point is however that they used to be wrong. The logged
values used not to account for the keyboard padding that
is present on tablets, and in the simulating tools we don't
know about that padding so we couldn't use the coordinates.
The catch here is that other calls like LoggerUtils.onSeparator
should follow suit, but this is too big a change to do it at once.
Follow-up changes will fix them too.

Bug: 8636060
Change-Id: If4b3d3cb1ed4b44c35f23e66aba3b5797236bba7
2014-01-22 14:41:45 +09:00
Jean Chalard 591580ee8a Merge "[IL61] Remove an internal use of key coordinates" 2014-01-22 05:19:45 +00:00