Tadashi G. Takaoka
067d8cdf56
Fix unit test breakage
...
Change-Id: I538288054a58eb2c81ce3cbe5c9bef900fb653a5
2014-10-24 16:48:46 +09:00
Ken Wakasa
2c6aaa7c3c
Merge "Move Constants.java to the latin.common package"
2014-10-24 02:50:07 +00:00
Keisuke Kuroyanagi
989699a690
Fix unit tests (InputLogicTestsDeadKeys).
...
Change-Id: I9a3191548aa0a4e674d736bc10845b952fc9a1e8
2014-10-23 22:09:08 +09:00
Ken Wakasa
9342484e8d
Move Constants.java to the latin.common package
...
Our intention is to have classes of latinime-common under the common
package as much as we can.
Change-Id: I76efbbbe7bebf1a4aa943715cdff64f91675e20d
2014-10-23 20:27:37 +09:00
Tadashi G. Takaoka
d3a4c51324
Fix Javadoc and null analysis related warnings
...
This CL also adds @SuppressWarning("unused" to java-overridable package.
Bug: 18003991
Change-Id: If70527e30654384705d7a814f5efd181d9f539e1
2014-10-23 09:58:42 +09:00
Tadashi G. Takaoka
5f00fe09e9
Fix some compiler warnings
...
This CL fixes the following compiler warnings.
- Indirect access to static member
- Access to a non-accessible member of an enclosing type
- Parameter assignment
- Method can be static
- Local variable declaration hides another field or variable
- Value of local variable is not used
- Unused import
- Unused private member
- Unnecessary 'else' statement
- Unnecessary declaration of throw exception
- Redundant type arguments
- Missing '@Override' annotation
- Unused '@SuppressWarning' annotations
Bug: 18003991
Change-Id: Icfebe753e53a2cc621848f769d6a3d7ce501ebc7
2014-10-21 19:28:37 +09:00
Jean Chalard
f95770354c
Straighten the dead char implementation, take 3.
...
Change-Id: I4f70f6eebe076c7d2b780d25e3a2c1d3faa2edfa
2014-08-28 16:03:45 +09:00
Ken Wakasa
0ba6bcb16d
Revert "Straighten the dead char implementation."
...
This reverts commit 5ef447aeea
.
Reverting because this broke a bunch of unit tests -- https://sponge.corp.google.com/target?id=b6439742-099e-46cb-8f00-d0c602a4d9bb&target=com.google.android.inputmethod.latin.tests&searchFor=&show=FAILED&sortBy=STATUS
Change-Id: Ibbd9e11372993f62e630fd9da37158ffcf47c17a
2014-08-27 15:07:28 +00:00
Jean Chalard
5ef447aeea
Straighten the dead char implementation.
...
This now supports all cases, including cases not supported by
the framework.
Now rebased on top of the right change, and renamed
Change-Id: I7886f0dcbb86cdb4dccec09aa7c52ad339680e04
2014-08-27 17:59:39 +09:00
Jean Chalard
5bfd661b38
Revert "[HW17] Straighten the dead char implementation."
...
This reverts commit c6612ff051
.
Change-Id: I750d9bff9cb89a6ab13af7a33567c3a0fe2af381
2014-08-22 08:16:28 +00:00
Jean Chalard
c6612ff051
[HW17] Straighten the dead char implementation.
...
This now supports all cases, including cases not supported by
the framework.
Change-Id: I9dfbe2829c28c5bcb64b0b5a2551e7806990c00f
2014-08-22 15:55:32 +09:00
Jean Chalard
e0bad8e988
[HW12] Use the consumed status of the Event.
...
Change-Id: I1619f6132f8f71bc1291fd6a5604a5e1e3431ae2
2014-08-04 12:41:07 +09:00
Ken Wakasa
7f545a57c9
[HW7.5] Introduce the @Nonnull annotation (take 2)
...
Change-Id: I05512b5434810046c8b72d6bb41567b6cd8b9d6e
2014-07-30 04:13:58 +00:00
Jean Chalard
8e38b12e9c
[HW7] Introduce consumed events
...
Change-Id: I692c35b8e701d5a84500b949884472545b1f424d
2014-07-30 11:37:19 +09:00
Ken Wakasa
bfa6f9533c
Revert "[HW7] Introduce consumed events"
...
This reverts commit 99aff0af98
.
Reverting due to a few critical bugs and unit test failures.
Change-Id: Id41d802981d079f17134a03cc30ab36a3cdd4ac1
2014-07-30 00:53:24 +00:00
Jean Chalard
99aff0af98
[HW7] Introduce consumed events
...
Change-Id: Ic2d95d19b1ac66e3e97e4a16187ce5aecb4ac678
2014-07-29 17:49:14 +09:00
Jean Chalard
2282e8520a
Fix updating the shift state upon backspace
...
Bug: 13514349
Change-Id: If4c9db12b0ab5be676f7a2f72715f469066ee537
2014-04-14 21:28:24 +09:00
Jean Chalard
cbed462d19
[CB12] Reset the combining state when resetting the composer
...
Bug: 13406701
Change-Id: I490574b7ca4b953f67dd2c0ef97401297fade0a4
2014-03-24 17:44:31 +09:00
Jean Chalard
835965a75e
[CB11] Get the result of the combination
...
Change-Id: I165ec4a24f5b1334d55c14948e4d942ec40eb33b
2014-03-20 23:33:12 +09:00
Jean Chalard
f2bb15b0ab
[CB09] Pass events through the combiner chain
...
Bug: 13406701
Change-Id: I4696f145478afdd132314b7d3c148c3a9ca11c9c
2014-03-20 16:59:29 +09:00
Jean Chalard
a79a3265db
[CB02] Pass an Event to onCodeInput.
...
Bug: 13406701
Change-Id: Id82e9aab6544ca308e6ac6dee2cfa018b9ce2d8f
2014-03-13 18:41:02 +09:00
Jean Chalard
92db209c60
[CB01] Reset some old assumptions about dead keys
...
The combining framework will be more generic than previously
thought. We don't need to handle dead keys as a special type
of event, as all events can be combined arbitrarily.
Bug: 13406701
Change-Id: I8137fdb186c4d70eaa71808c5a1430b1559db1ae
2014-03-13 17:47:13 +09:00
Jean Chalard
6a26de1d7e
Initial implementation for dead keys (B3)
...
Bug: 5037589
Change-Id: I9e1ff92df7d0c58eb7a0f33603adebc9efb86585
2013-01-10 15:47:21 +09:00